Received: (at 76446) by debbugs.gnu.org; 21 Feb 2025 18:16:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 21 13:16:08 2025
Received: from localhost ([127.0.0.1]:35355 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tlXZH-0005B8-Ss
for submit <at> debbugs.gnu.org; Fri, 21 Feb 2025 13:16:08 -0500
Received: from mail-mw2nam10olkn2058.outbound.protection.outlook.com
([40.92.42.58]:16864 helo=NAM10-MW2-obe.outbound.protection.outlook.com)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.j.smith@HIDDEN>)
id 1tlXZD-0004we-SY
for 76446 <at> debbugs.gnu.org; Fri, 21 Feb 2025 13:16:05 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=WtS1XF3ppp69VorZ29Je12TV8yUa0eJQ/Ly8ceSr4qzXRFsU9oHFe03Fky0TzgJkcUVgODEQsWRLcw5Zfst19G4NEHAH3C57MX7WSZcPPSYmEOz2aRQvbLZwM3SrdWQYi43kfKna4qVF/6CwlLtmyJ8gZ00ltW3A/Yk3oXMreDc4Tdql7egatav6W/LOMepnDnoxxcmUTKZHF/jup/3CPoaBGXP2CnVIdcPp9mAGaMo1nxSzIG0bpZGSXF93r4SgrSshh2GJkFbDbQfaZr0JPv3QjGKwC8u4gKB1Rxa04xqPUWboGsqUvlGRXYYDrw7WGCX3pHW/iBkoC+GCWwTIqw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=gQySLknpVXvcOZG02wy2qU8j3qlqbqHuqriSqng2C1w=;
b=kwkmkJuZ/JV+kmFuhkHIllqyTAEYg1/OboX4ULksoBCGOMbUU2QuMgGbo+wjpxHERPk5kcTWSR3hBm3x+otz6Zv7CYy1quFieWsDOvwjJAIBcL9Jem3dryaaH+aCp+FhAteEToKy1UqnhqgnDvYnHC1xBiPBojGpTb8B4reNKv5XwxSxd46K7SXKGPRfCewnRQKbupMhVWXBnHCpJxLpnjn4/iZyoiHjBbahZ/yOhFFA89bSDfUTsiJsUesVxehyaeakA5NBoaBO0WZ3s30V+GrN2c4lBRPDFpn9aTG/EKwEMtxCgeTUsqQAruGPNKvJu/kaAE/KSiIIfNF84kntMw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=gQySLknpVXvcOZG02wy2qU8j3qlqbqHuqriSqng2C1w=;
b=qWwz8jf/k9ovarK7uI29lWKN/tBtKTBBxdxBaWC08PLv/LJgi6YkLpKq3LILu5pyCjlh+njpkXWpGM3np2zyNesHYkEmMwPlWmxPcfh9zuneQg2jew4UwTMaSTD8B9aUvjZBHCFvwVkMMJOxkWgP59G9HLTuuNNrkYpOR3hYjMkrH0Whv18Z3ZY57iUohMf/Zgp1wijiArMEl9KZALJQKn1UCuhV4kjlp2kAfeFVv7m2FUE8LvBkEnxWUMo3RPukgMllwwo0nAu5ThJTixBTtiTLWsJGMV+JMvLuGjVRGsZH84dTOUvSehJJbJXA8fQG+G+g/SUOPDtcYqmXg67mAQ==
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17)
by IA1PR84MB3108.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:208:3e8::9)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.16; Fri, 21 Feb
2025 18:15:57 +0000
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef%4]) with mapi id 15.20.8466.015; Fri, 21 Feb 2025
18:15:56 +0000
From: Morgan Smith <morgan.j.smith@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#76446:
0003-Makefile-Add-target-to-run-checkdoc-on-all-files.patch
In-Reply-To: <87v7t3wlo3.fsf@HIDDEN> (Michael Albinus's message of "Fri, 21
Feb 2025 13:02:20 +0100")
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
<87v7t3wlo3.fsf@HIDDEN>
X-Hashcash: 1:20:250221:76446 <at> debbugs.gnu.org::xDTGDMMzcXT9zlx+:0A6j
X-Hashcash: 1:20:250221:michael.albinus@HIDDEN::NaQuFYBT/hamGuzV:3hFJ
Date: Fri, 21 Feb 2025 13:15:53 -0500
Message-ID: <CH3PR84MB3424EB975A4BE9FE7185E74EC5C72@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Content-Type: multipart/mixed; boundary="=-=-="
X-ClientProxiedBy: YT4P288CA0084.CANP288.PROD.OUTLOOK.COM
(2603:10b6:b01:d0::18) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
(2603:10b6:610:1c4::17)
X-Microsoft-Original-Message-ID: <87ldtzduzq.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|IA1PR84MB3108:EE_
X-MS-Office365-Filtering-Correlation-Id: 4e86e6e3-6d2d-4b18-8cdb-08dd52a3c952
X-Microsoft-Antispam: BCL:0;
ARA:14566002|461199028|15080799006|19110799003|6092099012|7092599003|8060799006|5072599009|13095399003|440099028|3412199025|41001999003;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Gp5HNgYdoyKFM41Jg5gaiOLs9Fsvtv9pSuraTAsksugK11hUI9ld3SpRsMON?=
=?us-ascii?Q?TwkzBk7ASzrC3LM3Knih9wvZlg316sG9H94aP6Eo2zkIIy9i56Dmicx/Fz6S?=
=?us-ascii?Q?vx21mV26MwSbLLJZQQPrQVI3cNgKIS7ssLogJNBj6a+U370HL49iKxhT6io1?=
=?us-ascii?Q?xzMjYa+OO4BwlfYN3BD0OagaIqS5Paw2g+5V+Nfab35S2RmAkL/58tgac6Q+?=
=?us-ascii?Q?Q3a9hzx3cH4MJGcdqpFU7sEZoAzqLY9s8lgdzxi0Ljrqf9Pwo9wErD2PMVDK?=
=?us-ascii?Q?l2tsvrVeVqSI9sLqw6kcUVnyQU1DtehHf0NnWv0TsfNq4yfx3LFJUnawvp6X?=
=?us-ascii?Q?hQWG7Mce/h6KdqPu60neCc1eVbBa1TU4f0MfGrryiR/vkXx9p49zKBhYiLVv?=
=?us-ascii?Q?+aob0T7XQhs4moTH3NKuyJavE6m16wxSak7fM0/F8lgOEhVWqelxA3Lp3UvP?=
=?us-ascii?Q?pFX+6tdpJg1bQbleaZXxgNIfKC7qmrOgEhVoSnGW5lnGWrly8wIm+N7e/70E?=
=?us-ascii?Q?uHd01yVW0ehFam3hN30mvlbtNzavgSqKoBOghdhMAq5MPfmKe5Vz2PuZcFpA?=
=?us-ascii?Q?BSxGYHJsgQKN5K/3btP8xt1IW8J1ybtWBWA9A/X52RrAzsylsWThZJ+E4F5b?=
=?us-ascii?Q?La3kbU97npGjA3xuMiSH8LZmdslqsrUzszQKNYdbSxuYQJLzgsFYAbSIvD+3?=
=?us-ascii?Q?cElKD88V6ABgbCkOqGgaPlSgFdp2gqLjyKLqpsHTiAUsqcXsDLy2aaxVNMZO?=
=?us-ascii?Q?60y4jd6Tr9YOduvoPRtQRjPtjAD4XTzXDZFjP3v1vmlSvn5keR6WDb/NNkgc?=
=?us-ascii?Q?1OIMuEyWPFyN7aauoCxUpJJm07d41kEE9PKoundj/9roi69HUbO9Le8VBolg?=
=?us-ascii?Q?luOffqaJG8oGaD+5VrYErOu6/cac5n782/2XycdaFfA9rf2yFkGBvDharKI7?=
=?us-ascii?Q?5sAR2n5Eyy2WMan1CabWvtb3VvW7eL8Zz6LpYGaAoRGHsrJXwMKgqgEisJMl?=
=?us-ascii?Q?UM9gAY9PWjmRB/cAXwJv8EvNTC7PQClwHi8RbezI14nVMfCvzidw21CgJuro?=
=?us-ascii?Q?hjfoQlXPLAHOhL2qorlz+TnzlMSYoQ40fqEcyhtxsFdnUlEPYJsf7fNV5+LO?=
=?us-ascii?Q?jvD8YNerSBiNjQe/k5+/7X1fnXL5mtS7o5WHtSHdMERJji250VtyrZE=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Q9kvzoxJopnkw9hFL0mxxpIhHJzo6JsBOmrYnlBpZJkMEVN6qFzuDGHFuwQR?=
=?us-ascii?Q?UBiuhc2PGVMWbUjHaRHUInwwWBwRK/borUiT1vCiWg0x7IAPJG/2iN7D+FxY?=
=?us-ascii?Q?hHSKkL23cDolwCWw9YIJytZhhRmp/WlUWGbckgOP6thbGFtnJGfnvof60tNB?=
=?us-ascii?Q?JcPd4lmezRc37F9AGijspdAbzEEr7B+hJz0nh8Vit9bpGrpPY0/RMsBVS7v3?=
=?us-ascii?Q?2GswueygfInXxyXC1MhpkDPVH/EN8xiGBDBAyo1lFllSsjulXTDpcOzxu8pR?=
=?us-ascii?Q?KSCAYrE6RbVKHm1IuEl+UlmrBmXp68W9yqY/4+h1h2+tvbAzHyw9lXALN/6a?=
=?us-ascii?Q?ICYXAEU8pES2uFWXiBJx+0vwhWevSzgmJkOvDpxyp7lsDldmR+MfA/5R/+9N?=
=?us-ascii?Q?zpgj5JGWX0hNueeE4tsCZPqaMzgYX7A+cR9AZOSgRoDJ8SnudjjWsWliBV+T?=
=?us-ascii?Q?XbGQLp4lEv56Iot2PLQ8EORLJHRe7p4olSP9LaJlqCEymWpuzd32rkN9+qjV?=
=?us-ascii?Q?sABIL2u36Ix7InTara4ngdNZUnCkKu6NHo4q0Y7ujfCaLkmHewNx40PhATKI?=
=?us-ascii?Q?ozMdLAljZ7/3mWg4SVJcD6gzvhr3dn0xlk7RnfYGRdzaVSFUokxh5U7iR+vt?=
=?us-ascii?Q?iwm47/v7WdKYBLwpUQYmvEzwLVSZ2+pWOtfL1c+fADT490CZtzNVadOrXP2c?=
=?us-ascii?Q?lBy0UupFzRSo8xUezwXuRm/k14n4phyZ1IBc5flkhdcQcRhr36snNWewHZfZ?=
=?us-ascii?Q?o+XPDQXIO1xTdqcdOaAYXbsyzLhOy6WQslv9sKWo/IwV0PP63lZS0pERO567?=
=?us-ascii?Q?LRHztJ1caVvlHT73+T3ZyH1pdVVQeT4jxn5Ikk5U5wPV89jhGtbhd6QmeQJ6?=
=?us-ascii?Q?oyrCjuJzf+pr25iCYyM6Y95+aFts84yC7ASVR5hTtsLL9aAPqMnDCBEN6sS8?=
=?us-ascii?Q?Z3mLulz9OEEbH2L4/1ExyKG2OGXWbkS6hHYTLl/ZgxHs54VHFejxI0rcUguk?=
=?us-ascii?Q?0HEoHdBi2JkVfx22KQEKGiAXVqwwt5txyFx/bMD/Ou6hQy3fg/yjD4RGHnrY?=
=?us-ascii?Q?teWvxJs3efFV0DKq/ySyJuvZnb/cqtnAFQcV/KAA7S/YLJGN4/xKhrMqxlmH?=
=?us-ascii?Q?A8nLc2wsv4br7ahZPgjm43ayRA3t/bVDqwFeS+U5SumpLOnm5uPjvIBe7RSH?=
=?us-ascii?Q?zZcMSc2DT4zbVZVbiqoxR/yrM5vnOTgFEKUGpl6Vt2ZthyXVfTRHRf6DaNxh?=
=?us-ascii?Q?b+EEvCSqhwPn/rPAHKPv?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e86e6e3-6d2d-4b18-8cdb-08dd52a3c952
X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2025 18:15:56.9413 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR84MB3108
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Michael Albinus <michael.albinus@HIDDEN> writes:
> Morgan Smith <Morgan.J.Smith@HIDDEN> writes:
>
>> --- /dev/null
>> +++ b/.dir-locals.el
>> @@ -0,0 +1,18 @@
>> +;;; Directory Local Variables -*- no-byte-compile: t -*-
>> +;;; For more information see (info "(emacs) Directory Variables")
>> +
>> +((emacs-lisp-mode . ((checkdoc-package-keywords-flag . t)
>> + (checkdoc-ispell-lisp-words
>> + .
>> + ("ChangeLog" "ChangeLogs" "UTF" "alist" "args"
>> + "armstrong" "backend" "bcc" "bugreport" "cdate" "cedet"
>> + "coreutils" "cygwin" "debbugs" "debian" "el" "emacs"
>> + "etags" "freemail" "fsf" "guix" "gw" "henoch" "hu"
>> + "hyperestraier" "keymap" "magit" "magnus" "maint"
>> + "maintainer" "maintainer's" "mbox" "mboxes" "minibuffer"
>> + "moreinfo" "multibyte" "notabug" "paren" "persistency"
>> + "regexp" "rescan" "rgm" "rmail" "severities" "sexp"
>> + "solaris" "src" "sublist" "submitter" "submitter's"
>> + "subproduct" "subqueries" "subquery" "teardown"
>> + "unarchived" "unibyte" "unreproducible" "url" "util"
>> + "wishlist" "wontfix" "wsdl" "www" "xsd" "zltuz")))))
>
> This is needed for the checkdoc target in make only, isn't it? Shouldn't
> we activate it for just this case?
>
Ya this seems a little inelegant. See the attached patch for an attempt
to do this a different way.
>> --- a/Makefile
>> +++ b/Makefile
>> +checkdoc: $(SOURCE) $(TESTSOURCE)
>> + @$(EMACS) -Q --batch "--eval=(setq enable-local-variables :all \
>> + checkdoc-spellcheck-documentation-flag t)" \
>> + -L . $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")")
>
> Do we need '-L .'?
We do not!
>
> Best regards, Michael.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v2-0004-Makefile-Add-target-to-run-checkdoc-on-all-files.patch
From 9d6fc20715ae9a13a82811bf7b3b3469e060bd45 Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:52:35 -0500
Subject: [PATCH v2 4/5] Makefile: Add target to run checkdoc on all files
* Makefile: Add target to run checkdoc on all files.
* test/debbugs-checkdoc-config.el: New file.
---
Makefile | 5 +++-
test/debbugs-checkdoc-config.el | 50 +++++++++++++++++++++++++++++++++
2 files changed, 54 insertions(+), 1 deletion(-)
create mode 100644 test/debbugs-checkdoc-config.el
diff --git a/Makefile b/Makefile
index eec1c65a14..8ed6a917fe 100644
--- a/Makefile
+++ b/Makefile
@@ -8,7 +8,7 @@ TESTTARGET=$(patsubst %.el,%.elc,$(TESTSOURCE))
INFOMANUALS=debbugs.info debbugs-ug.info
-.PHONY: all build check clean
+.PHONY: all build check clean checkdoc
.PRECIOUS: %.elc
%.elc: %.el
@@ -26,6 +26,9 @@ doc: $(INFOMANUALS)
build: $(TARGET)
+checkdoc: $(SOURCE) $(TESTSOURCE)
+ @$(EMACS) -Q --batch -l test/debbugs-checkdoc-config.el $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")")
+
check: build $(TESTTARGET)
@$(EMACS) -Q --batch -L . -L ./test $(foreach file,$(TESTSOURCE), -l $(file)) -f ert-run-tests-batch-and-exit
diff --git a/test/debbugs-checkdoc-config.el b/test/debbugs-checkdoc-config.el
new file mode 100644
index 0000000000..d09b1adfe5
--- /dev/null
+++ b/test/debbugs-checkdoc-config.el
@@ -0,0 +1,50 @@
+;;; debbugs-checkdoc-config.el --- Configuration for running checkdoc on debbugs -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;;; Code:
+
+(defvar checkdoc-package-keywords-flag)
+(defvar checkdoc-spellcheck-documentation-flag)
+(defvar checkdoc-ispell-lisp-words)
+
+(with-eval-after-load "checkdoc"
+ (setq checkdoc-package-keywords-flag t)
+ (setq checkdoc-spellcheck-documentation-flag t)
+ (setq checkdoc-ispell-lisp-words
+ '("ChangeLog" "ChangeLogs" "UTF" "alist" "args"
+ "armstrong" "backend" "bcc" "bugreport" "cdate" "cedet"
+ "coreutils" "cygwin" "debbugs" "debian" "el" "emacs"
+ "etags" "freemail" "fsf" "guix" "gw" "henoch" "hu"
+ "hyperestraier" "keymap" "magit" "magnus" "maint"
+ "maintainer" "maintainer's" "mbox" "mboxes" "minibuffer"
+ "moreinfo" "multibyte" "notabug" "paren" "persistency"
+ "regexp" "rescan" "rgm" "rmail" "severities" "sexp"
+ "solaris" "src" "sublist" "submitter" "submitter's"
+ "subproduct" "subqueries" "subquery" "teardown"
+ "unarchived" "unibyte" "unreproducible" "url" "util"
+ "wishlist" "wontfix" "wsdl" "www" "xsd" "zltuz")))
+
+(provide 'debbugs-checkdoc-config)
+
+;;; debbugs-checkdoc-config.el ends here
--
2.48.1
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at 76446) by debbugs.gnu.org; 21 Feb 2025 18:12:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 21 13:12:08 2025
Received: from localhost ([127.0.0.1]:35291 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tlXVO-0003FX-SQ
for submit <at> debbugs.gnu.org; Fri, 21 Feb 2025 13:12:08 -0500
Received: from mail-mw2nam10olkn2100.outbound.protection.outlook.com
([40.92.42.100]:26081 helo=NAM10-MW2-obe.outbound.protection.outlook.com)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.j.smith@HIDDEN>)
id 1tlXVK-0003Da-Jz
for 76446 <at> debbugs.gnu.org; Fri, 21 Feb 2025 13:12:04 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=bkgJfoBLYhTWPhwhc+oGRDotsgiPC0yTwG+tc9HM2+x6G4ypStDmZfjvERQePuhMZ5SGePTgEKSDmW14bGbEDEFNSoaoDv05Wd2zOfoeFROcrcSBnHpuBIJJfPs9Uoh0Y3CTGnLb144Hym3ggquj8p/nomtX0HNpPVNCCblRaTFW6wJ02G316Z1rK7aPLl5XOVdCmvVKxbXoCIbzebietUQnFbtFsUNWEl+hufhNVUyMT7xoqvEWv1oIiFtrTt7cyUl2PLKwShZl8Aa/axX6IDMSjnKgAe6rOlsIIccaOQ/u3ALES7iYS0kaDhq7PBncgeHw2H6yxCprNrNNZA/alw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=VuSHEhvv1wqOf16/xs3w1vowOYr/qw3sDXU7a5242/E=;
b=YpL55+WCP7PrIUkacCNacQVMmaEP4mIDFRTePmdxrRAcjepeNTtkkpr2Lhxz0Hk0MYuEjMPNQIFrGmgm1eXlq1TofjYsp4TLLYrD91QPnCqTLHcGeY/xSLDbT7cieDi9dXGVqLYYb7VEhwqtBkanP2aXnUJInWmG0MuugjvdfB7I1zsY0unIMr130OTJ7FqWMdbZPTr3MXpGa70Dy/tAyKLrrwD9T15lFVi3Qi8Px6VAiF2ZOTpv5BSXHPAdayBZFZgqOlxBXGqvymuffHvuHt2CD+Tqt+ecXFkwHGtwYzRtVqAnsGqSigMeSHFM3L157lrEmjYmEAvuFOnImWJ0jw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=VuSHEhvv1wqOf16/xs3w1vowOYr/qw3sDXU7a5242/E=;
b=mI850TO076JRtuJLh8wl5ekv+kv9G/TLHfBLYYsdiclTgFQ1J+McFPR2+xhxAfKkg0KWCoN8kAN8dLrEwgFxoIWgXytRgIjDjoEyFKi79kyxgPMt7zDfC+uNfjxM0qTJHDxnD331VYf0hK3L28lfKFr4n/ND2q4d8NgjybhlwpK5cbLcz5eM5We7GeD7o5PrSzI4PgGpfgFyMh1Gja5PX76BWAfR1YxqmujyvzGOZWeH1iHhK+v1c2vKYWyLUy+/UrEEbhNWijfHQyebEhzhjkebme+PxUJh9NNleNNx4Y1gUzSofAp9xnmUEh7RLsGHkAvOK1aAbHIMGyTJG1ex/Q==
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17)
by IA1PR84MB3108.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:208:3e8::9)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.16; Fri, 21 Feb
2025 18:11:55 +0000
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef%4]) with mapi id 15.20.8466.015; Fri, 21 Feb 2025
18:11:54 +0000
From: Morgan Smith <morgan.j.smith@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#76446: 0002-tests-Add-tests-for-debbugs-gnu.patch
In-Reply-To: <87zfifwlxg.fsf@HIDDEN> (Michael Albinus's message of "Fri, 21
Feb 2025 12:56:43 +0100")
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
<87zfifwlxg.fsf@HIDDEN>
X-Hashcash: 1:20:250221:michael.albinus@HIDDEN::rBDXwCqxDgl2oSZR:zS4
X-Hashcash: 1:20:250221:76446 <at> debbugs.gnu.org::uHPlXxQBr0pezHPD:30UE
Date: Fri, 21 Feb 2025 13:11:51 -0500
Message-ID: <CH3PR84MB342460F7CF9FD5B9347BD72AC5C72@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Content-Type: multipart/mixed; boundary="=-=-="
X-ClientProxiedBy: YT3PR01CA0001.CANPRD01.PROD.OUTLOOK.COM
(2603:10b6:b01:86::27) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
(2603:10b6:610:1c4::17)
X-Microsoft-Original-Message-ID: <87pljbdv6g.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|IA1PR84MB3108:EE_
X-MS-Office365-Filtering-Correlation-Id: cc8103a9-ac09-48fc-2dff-08dd52a3390a
X-Microsoft-Antispam: BCL:0;
ARA:14566002|461199028|15080799006|19110799003|6092099012|7092599003|8060799006|5072599009|13095399003|440099028|3412199025;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?EOm3iBv5dModYJv4sb1WOvAQI0rCapmkeZEABvpfPifyae+dRgFl4fe5JPgF?=
=?us-ascii?Q?HRsl5fSZATLCtZOPvFXX5OGyKWDnsf4/+7T0qraPKb85xJXHfypO6yuU35VB?=
=?us-ascii?Q?iXVqDP+XAD+4rufR9Om/caNdyvyn+UmWEG3eKN2gm6aLYwlsPspl4i7iWGB8?=
=?us-ascii?Q?XkWEVIRcjOEyMLVSVNeTUCRCHADlHsz7jKNN4S578iiAbL2KsOCCsmTX3eyV?=
=?us-ascii?Q?8F9AIJfNGmRRY1/05XigXTuhd8TtT5eDoaAA5N4Mi52QNb5qAF6gfTpYT/bw?=
=?us-ascii?Q?C5XOI63zJKj2vCskKJKBnJpDWCR/hAHCjzJX1Opzaqv+b/2/jeZ7/P2Cpk4W?=
=?us-ascii?Q?jauIxfAm98R3AZ4pueCk5Km/Kk8nMaVf2BOfLuFqNlP8TF3/kUkRKjASkd/k?=
=?us-ascii?Q?Gz5Vu8ShoExs94SiYS9dTVmXQ7D6ffzoSGyLsPadKyuToWYNZiwx7WDM8bQ6?=
=?us-ascii?Q?P+bd+JBxSBTjld/qPqOIIBdkNDx3JUccpNjB+toP3K02O9ZPgk2D+0xcuEiU?=
=?us-ascii?Q?4pfBRmhqQ6SfaSlVHVp/7aJFUX564W5hUKh6hqjjkp6jrMnpGmd9xdWwCRxh?=
=?us-ascii?Q?xuu+TWuy2EJ3pkgn4ANSpS+5MFL/7oNPak/R9BpO5MHxpDAhg++ESr2mNdXP?=
=?us-ascii?Q?SGIJWgAVR56rC2g+Y8lMziNvO7dkDzTaBJi0UNvkEHZXU6C7M+pAr1dBa0RF?=
=?us-ascii?Q?5KLBEkd2cUTtcrooXY6mxzPhtkIGkLWsTYgnM9zCYjXgkSCJPCiKDYnL+NpC?=
=?us-ascii?Q?ACWosxBUeCYpT+CVjKvPX6a67Z29sCIsAOyJHXm3FTG5oYxVOnBPjuP9AuaS?=
=?us-ascii?Q?YY9I6qKWUxAZpXX/GaY7qU9QI8vcz/hnkWVv5JxrwoJDoSXoBPZ55BRzmML/?=
=?us-ascii?Q?iCsLV1TvgXziBgjC7WcB7cUwSMWXXzc4LVnQMl23iO76rR06sn7cXezUwB6d?=
=?us-ascii?Q?xc5bR0w221LHhWut2y8z8IWrWNbWmK5WU2VEkHCZqxxmmsCM6UIqFKPzbUVL?=
=?us-ascii?Q?hecejJUw+Isx9q7fV/k24GqU/V0PwDhCK/PTz42Gxe7mGIbCnzeDrnEwf/Gr?=
=?us-ascii?Q?LIBPyPlHoSGBhUC56WNmSyquKbYq9M13s/Bf/Vk/hnaWXm3isEwlyx5i9VZO?=
=?us-ascii?Q?cfrsJaRo7bMePxUOVfgW4QSyt/FcLD4d9g=3D=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?k8S7/calK14R+qp4kxd1w+VGi7VgQa95GRhzdWpxUSv3UDb6SrpR0z2BJCPq?=
=?us-ascii?Q?6VcFqDcE5DyfHBaDDFo8jtk2NCnL7cdK4kGvCAOx/2//7SLg1JqXe0rl0Epz?=
=?us-ascii?Q?ghpRYlupphBigM0PpVzsvw4MnXDPxBJuGsel+zyvFvxqBzV4f/78fP8Xd28M?=
=?us-ascii?Q?Slm14pm6qlJgVccdtqXQQgU/6Q4uXXPgchxDQ/XZhVGI8l1gKbwYoisueU91?=
=?us-ascii?Q?tvitBllkAoPpngWKgM/dkVAALVJno0cV2r1FmGoTUQInJYJ+Sg8iePggzFrB?=
=?us-ascii?Q?UQLGvex7uP7icyZkwIQdKyszOzDKUoofWcD/IEO/nHQ7jWaqY6bQHLxqqJ1z?=
=?us-ascii?Q?A1RJ98e+Oc5CDh8ncYO5p5kM82SXYdiaBF+NJiYCfP9tJOQBN7xDEj5xjKsW?=
=?us-ascii?Q?6Wm4UFgSWowX2n4jthhHT7Ui0OrHc20G3OorPQ81sMsvEHbJPeWeUZkoFWp9?=
=?us-ascii?Q?TPXDPbqUHb+CFchvHc2CalLbRy1W3d3Z/N0jrY/GvF/+4ZEXnK3GplwN5aMM?=
=?us-ascii?Q?jnrmq1X5ODJVornE8wXcfd4Jj53pBWX4oG4SvhAhEE2wyoJeISOCLxkjEUf6?=
=?us-ascii?Q?waHjBQqrbLVRtAAqM/315Focm0o8oponz6H/NQh9LMgG5P7zLACGUmPW/HyQ?=
=?us-ascii?Q?9wwZFTKQfsey857WeTNxSo+TX7n9fkVf0DGnO2tOW6qsWlukU0ZOAQQC/auY?=
=?us-ascii?Q?3OgLCoHLPSGRRH/9PTuSL9mEDXwBnw6fuLLfT1+wQx2Ykofqt2Ouug/rT7EQ?=
=?us-ascii?Q?yCigqdKDminJ6dNmkf0dz3mtBhDSrqv8c8CbTXt2UxYW+wC7l+nn6Hn3nXoL?=
=?us-ascii?Q?xMrMFsaas+UAL2ZhzATim5piUsSjCfA+nZHIYwEs8eVNZ017s+G4XEcO+qbX?=
=?us-ascii?Q?8/IpuIqbyLGL5cckHVh9xJOHwzPpEbXG/NAVfJY5TGQkdR+aIfwXeq609VlX?=
=?us-ascii?Q?Rpe1kBrUgDVnegDJJaH/Fb+SAx/SUCyrBk9rFRRNyK015fV9i4DFKX7V5Hv9?=
=?us-ascii?Q?7oGEN09Uy1IEjvPoEiqewZ7Mn6fWtUlOESWmTe/4za5bOq+dsUL6pxguj+za?=
=?us-ascii?Q?q4Jcj1mFtMjbI8i6z7qUrI5AEvGOOIED4hGwLRWBAEQuKAkoy/ELO749iWQX?=
=?us-ascii?Q?2BrEqILCdiMuU9L1dp+/46gIEKKpUAfWaSUlKaPSp/01063v2KPh/Q1+ONat?=
=?us-ascii?Q?WgXiBktuSS1ooaJxZfUns8XRnQ878G8TY2UxOlBcflsURDzDGsdCyLFfH0Q/?=
=?us-ascii?Q?umBWYHdW++k0NT52kLUm?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc8103a9-ac09-48fc-2dff-08dd52a3390a
X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2025 18:11:54.8832 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR84MB3108
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Michael Albinus <michael.albinus@HIDDEN> writes:
> Morgan Smith <Morgan.J.Smith@HIDDEN> writes:
>
>> --- /dev/null
>> +++ b/test/debbugs-gnu-tests.el
>> +(require 'debbugs)
>> +(require 'debbugs-gnu)
>> +(require 'debbugs-test-helpers "./test/debbugs-test-helpers")
>
> (require 'debbugs-test-helpers) is sufficient.
>
Done!
>> +(ert-deftest--debbugs debbugs-test-debbugs-gnu-search ()
>> + "Test `debbugs-gnu-search'.
>
> Isn't it rather a test of `debbugs-gnu'?
>
Nope! The intention is to test `debbugs-gnu-search'. In fact I stub out
`debbugs-gnu' with #'list so that I can test how `debbugs-gnu is
being calling by `debbugs-gnu-search''.
>> +Also test `debbugs-gnu-patches' and `debbugs-gnu-tagged' which are
>> +simple wrappers for `debbugs-gnu-search'."
>
> Nope. They are wrappers of `debbugs-gnu'.
Oops! You're right. I have removed those tests.
> Best regards, Michael.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v2-0003-tests-Add-tests-for-debbugs-gnu.patch
From 3bd34242bffce78a908ca66ff1073e304d185fda Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:52:24 -0500
Subject: [PATCH v2 3/5] tests: Add tests for debbugs-gnu
* test/debbugs-gnu-tests.el: New file.
---
test/debbugs-gnu-tests.el | 47 +++++++++++++++++++++++++++++++++++++++
1 file changed, 47 insertions(+)
create mode 100644 test/debbugs-gnu-tests.el
diff --git a/test/debbugs-gnu-tests.el b/test/debbugs-gnu-tests.el
new file mode 100644
index 0000000000..04c445e43b
--- /dev/null
+++ b/test/debbugs-gnu-tests.el
@@ -0,0 +1,47 @@
+;;; debbugs-gnu-tests.el --- tests for debbugs-gnu.el -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;; Please ensure tests don't actually make network calls.
+
+;;; Code:
+
+(require 'debbugs)
+(require 'debbugs-gnu)
+(require 'debbugs-test-helpers)
+
+;;; Tests:
+
+(ert-deftest--debbugs debbugs-test-debbugs-gnu-search ()
+ "Test `debbugs-gnu-search'."
+ (cl-letf (((symbol-function #'debbugs-gnu)
+ #'list))
+ (should
+ (equal '(nil ("guix" "guix-patches") nil)
+ (debbugs-gnu-search "frogs" '((pending . "pending")) nil '("guix" "guix-patches") nil)))
+ (should (equal debbugs-gnu-current-query '((phrase . "frogs"))))
+ (should (equal debbugs-gnu-current-filter '((pending . "pending"))))))
+
+(provide 'debbugs-gnu-tests)
+
+;;; debbugs-gnu-tests.el ends here
--
2.48.1
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at 76446) by debbugs.gnu.org; 21 Feb 2025 18:09:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 21 13:09:07 2025
Received: from localhost ([127.0.0.1]:35218 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tlXSQ-0002jj-SE
for submit <at> debbugs.gnu.org; Fri, 21 Feb 2025 13:09:07 -0500
Received: from mail-mw2nam12olkn2107.outbound.protection.outlook.com
([40.92.23.107]:27777 helo=NAM12-MW2-obe.outbound.protection.outlook.com)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.j.smith@HIDDEN>)
id 1tlXSH-0002h3-31
for 76446 <at> debbugs.gnu.org; Fri, 21 Feb 2025 13:08:55 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=gg/IMvcQiX/UhIp7sjrSDPJTqSEb7QnIILjs276N4NeBiWn8n1DqGXlmUpT2tnB+2vQ6nbR+ja38jqHv4ZRsjEZiBn2/0Nnl/BD++lU/EPEgkEaHdbf7PsIRavGoPPl4rtc09YsTWaq2YLZu7gWwynz7zab9OlwgADz+R2LGPRQ79aFZ6WnrLPbr8VpbairX2QwFjPhSbpK+xzuEUT2q4wM82WZeLdA6SCV9A18vgCPoRh27wllkVEv3GwbvYOyUanR25IdyByglJcZGGsFVpRMJIcUFB2T0ldeFT7lGhB/kGimiSXSWD6MUbfO4dIHibQJeGeI6jzKR1C/uXAfCzA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=S9qROuiRlzQ/v26S0SLWwnd8p47hwsPzEgKXYR0pfag=;
b=ShR9kdCMzXk8+9IIEyyorSd0RCpjKursJtTYnfqJnk45M7hR5akdCDajD3go37xoY7n48qFszJsdAWX4STL7Cvht1mfeYxiSEu0Q+jWFsxFr+/U2gAhCLCY0qr/Z3jiIrCCLIDYXLTQYuYEt+IWFdXdCWixj8YK7pwlew1j3yIkXrblo3qc/uWsvK7dKdDq/yKtZc+2LHbgRIiS4AZMBeG1cA8Xow+Kk5SyudONGWNNW6SZSeXYse73O6b9udI7m/tANbxukbhUmJbE2as1oRZk3nS7yVVcBfpgjT3GzX44wxbVmCtaxQkWXOiFjl8crol5N/GIjjskYEjUpKqN75w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=S9qROuiRlzQ/v26S0SLWwnd8p47hwsPzEgKXYR0pfag=;
b=tZKJqz8vCvjDs4OX8wZurfNjiXh7qI5bZABgwF6EFDKxBAB291VtOkKaLl1ukuiTlIOmvljTtpF0r2O1A00Fzxb125NoDvSXpRgmh74krI6a5ZwtcD18FtIG4epIVLE0DQcjyUuu5ixDMcbdnDVrWIx04KMiOtjTZlS/t+onFIZmo95VilWIrgCxXugIAKk5dqzmSmmRWA73Fa0Ye0TBHjoIuaFfkjNHSADaHoqKwGrZZkpJuX/iyHNrnBNyq4gYwKXtiNd+8PybAC2xzTYnSEhyRkZn+tM5KqNN4piJkxR8w1FZLGMvd/vJ5fg8Ack0lOQBbqa2/6p8sYM+xMp3EQ==
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17)
by SJ0PR84MB1776.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:a03:436::16)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.16; Fri, 21 Feb
2025 18:08:45 +0000
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef%4]) with mapi id 15.20.8466.015; Fri, 21 Feb 2025
18:08:45 +0000
From: Morgan Smith <morgan.j.smith@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#76446:
0001-tests-Move-helper-and-wrapper-functions-into-their-o.patch
In-Reply-To: <874j0ny0pa.fsf@HIDDEN> (Michael Albinus's message of "Fri, 21
Feb 2025 12:52:17 +0100")
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
<874j0ny0pa.fsf@HIDDEN>
X-Hashcash: 1:20:250221:michael.albinus@HIDDEN::pSQbBy57qmMmaW09:rPc
X-Hashcash: 1:20:250221:76446 <at> debbugs.gnu.org::fchVcm5q/0J91mY2:2IlD
Date: Fri, 21 Feb 2025 13:08:40 -0500
Message-ID: <CH3PR84MB3424C014EA66C2F79FDC1E0AC5C72@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Content-Type: multipart/mixed; boundary="=-=-="
X-ClientProxiedBy: YQBPR0101CA0240.CANPRD01.PROD.OUTLOOK.COM
(2603:10b6:c01:66::14) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
(2603:10b6:610:1c4::17)
X-Microsoft-Original-Message-ID: <87tt8ndvbr.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|SJ0PR84MB1776:EE_
X-MS-Office365-Filtering-Correlation-Id: 100f1261-7d70-4777-d9d7-08dd52a2c7dc
X-Microsoft-Antispam: BCL:0;
ARA:14566002|461199028|19110799003|6092099012|7092599003|15080799006|8060799006|5072599009|3412199025|13095399003|440099028|41001999003;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?uas8eIP3nQvMoVLfd52ZIaD1QB8n2j7tkFuvRBRgAH0tEhVIMCqLeiaW59pb?=
=?us-ascii?Q?6odn95rFR2qrMWMj4BKr6Mn5/497ow14aWiyIVdIxxsWT30B07wI6+36361G?=
=?us-ascii?Q?uoUx4PuNvW3vnFbHGVhdc29bhU6lBZA1EPn6OZeO+3qfaUW7XPBDIFTMzsOg?=
=?us-ascii?Q?+X7sO4Twh0t13PnufA4IQzwtegQYU3IoPVsaVTeSlelmWE03APoDLyIUdW8B?=
=?us-ascii?Q?10dmZX3VTt+idlz9Y463DC6b20klv8yQgTbxY3C0L/ZupSYH5u6ExBdEZmUZ?=
=?us-ascii?Q?Cm+OghL8rQwHdAzNIIhuXZiNSvkkaKHZNKDElaytXnfRH9NnlqEPwymFbHvE?=
=?us-ascii?Q?AyySkPZwEPLd1QhUTBX7j48cI0VvC7u9CXDeJ17NspgV9SCNo1WUN6/VXLzp?=
=?us-ascii?Q?h2pWPDEUxDxvqgolKHNTXq9Wcx7Trzq9eHGnFei0mC1bj8XXvZ5Lids7OrbS?=
=?us-ascii?Q?VujhUZjk9aU1xnqvNrOkQKQCuQfulqA1Enoww5n3PepM60d+uHS913NeVRtW?=
=?us-ascii?Q?5lwbCOzHbsXkM3I/u2CFDy3Y7P+kPJI7PnP8W4NQ2Q3fmMeCgvRnBf6kksix?=
=?us-ascii?Q?B/0qtT0fWbqbhmq/+Z6F3uXBLSASk53pHtYa8A/o162nB4uksvxZS4i0U91x?=
=?us-ascii?Q?sbW+riB8HepKUYm+CeTT7rN385W77/9LwMuXF7QDiFty9cQWiBFhUqoSFV8d?=
=?us-ascii?Q?JevGPc1hccR1vRrxlznItqoZLkWUT1PnZQWcjzPexi+gvw4ou3TPzLAHS7Ra?=
=?us-ascii?Q?Tp3nF32pZWRPN3+yiHttRRndKoBK9Rcqygm46R+St8/Zy5SZquzp+TLLQg4m?=
=?us-ascii?Q?IVjk942C/nt9P8oWo3vECBz5eWgSrcVW3Ec1gB1zEDBUJ0ueuw2Db7CV295p?=
=?us-ascii?Q?Pui23seaVuJCNbSkoY3qJfKzm1X5hQZ+dBzyKqyTeIum8p6PrLdD75LzKu6t?=
=?us-ascii?Q?+5JMzOXbV3nKIRV8CTJQQZlSRL1cGb605NfpmkaJWTquPI9UrZr04CsAJoOv?=
=?us-ascii?Q?7R7UDyYz6UrK7iANLC+uoG6575JJ59AiB2BGFuLOpGI6CMY0JvZ92No1vAXm?=
=?us-ascii?Q?k3ZIPFmIwj69dg31KcSvk8in9SJCoXrp7/aoetf4kgb+HOS+IrYvhze4dseK?=
=?us-ascii?Q?EXc91wcxqmvV4Q5oAu6o6/BcGLnFkZU3Ro0cWzA+bPnUNw5Tfe3nDwQ=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3mw1DQAowCheA+Gt1xStBkN9WdiWAQdpKmFvlwK/LBTWkdRQxFrVhEH572Jx?=
=?us-ascii?Q?SmSaBTALMC2O0+5V/oYj+pdJy57pqis4oKT0XZ6YemsSiFvLoh4iCyDEUY8f?=
=?us-ascii?Q?nrLnlmlkRtZd5xoL6fBPtp7gQnKo1nCY44v/zmt9wLuWUMtmlAEAdm+HKeYk?=
=?us-ascii?Q?Wq6fjEw/qmf0v78RdWYMUdka7MUwfv6ycziPG/LXyJzU4Ksefm44mOKORAWh?=
=?us-ascii?Q?iOVCO/Sv9qLVB0oK2quF05tl8UnwA7eWemgdhG6OceHWmTwxFi+6h1nwsK69?=
=?us-ascii?Q?cQYMBfVLHQtoOHlqVyq+GXLoiRwIPaRbQ3zlkUwmiqWdmxsSK7P0FUQ2nJMF?=
=?us-ascii?Q?KctnFVCbtnzcfNWH++XY6Lat6dtNNs3Zl7QSEqjvyRyubgWd83GskL77kKdc?=
=?us-ascii?Q?Zh6Kls8Hf14+OP+LXsPWC/+mUD38FQNNy8AShb2Y3nRvb1HM1FraOA0cDwyz?=
=?us-ascii?Q?ejMvYGBPPSc0gQcaJferNaZFW68tD7bw4U91j+FS4TrP0k3pFijFBR9fdWNC?=
=?us-ascii?Q?/FBrRnlf9jHSX9rM/I35CUaWo5QsGL5m3xl0SbzBy8rXBSLP+FmYozrJDqN/?=
=?us-ascii?Q?yfo0CA1ToNVusreCr8R3iUIX/dn6r6F6kku7BXPS2l7ThT8+c17dv54KWVxY?=
=?us-ascii?Q?SnkegZb6r1/5TJfORyKZMoPFlPF6c/VHYAQbXlThLpN8xEBP3YhrTK/xy4qo?=
=?us-ascii?Q?bQPBcQN81aRFkrROt9V5lcWjT7Fk1orDGRPeojuGhUY4F5C5SROzgJ1PCor0?=
=?us-ascii?Q?P+O+0sByvto3EZGwLinYx8isV+hZsQYLbllfGjN5Ym+UEZYDvy9ONhyqn2cj?=
=?us-ascii?Q?MUEE9GtNCjHG2V3iQiqW6ahGpGh6l11neLqeEV2VLaYsAfiA9sEbshIgE4IB?=
=?us-ascii?Q?IgGZHGMVQQOe3SgipUgyrwM0s5/C+76XSDv/SPREgvzxugGioR1hHN6zSPtt?=
=?us-ascii?Q?7HtCd9dWHPMwZzND4XMpNsV6xPLFBXFRqywXyViTqxq7+ukf95hRLICYz6QF?=
=?us-ascii?Q?dDcZD5X6+CSmAaZUAdmhuH/AFQi77r8taYa05VBuLyfs8O3t9RJPlFE8pn9j?=
=?us-ascii?Q?LhTRWUPBCY0u1zkvLUqQF/ROaVu7vS7xIvrGWjlVK/7ScJosrj/DILsz/cQC?=
=?us-ascii?Q?a6Zo9m7pCHoz4FGPm36EEoqZGMJlzX519rti0PST95ZQ/MbaZCLYG6cI+lYG?=
=?us-ascii?Q?SGN27+o3FHtEZ8NmEA/2YtF2/iRWeRf4apat9qeRhM+KMey98RAAHoQLXJ2B?=
=?us-ascii?Q?0794Zfiy88GKX2el6QkJ?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 100f1261-7d70-4777-d9d7-08dd52a2c7dc
X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2025 18:08:45.1919 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR84MB1776
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Michael Albinus <michael.albinus@HIDDEN> writes:
> Morgan Smith <Morgan.J.Smith@HIDDEN> writes:
>
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -24,7 +24,7 @@ doc: $(INFOMANUALS)
>> build: $(TARGET)
>>
>> check: build $(TESTTARGET)
>> - @$(EMACS) -Q --batch -L . -l $(TESTSOURCE) -f ert-run-tests-batch-and-exit
>> + @$(EMACS) -Q --batch -L . $(foreach file,$(TESTSOURCE), -l $(file)) -f ert-run-tests-batch-and-exit
>
> We might be better with
>
> --8<---------------cut here---------------start------------->8---
> @$(EMACS) -Q --batch -L . -L ./test -l $(TESTSOURCE) -f ert-run-tests-batch-and-exit
> --8<---------------cut here---------------end--------------->8---
>
I did the '-L ./test' part but I kept the foreach.
Without the foreach the command looks like "... -l file1.el file2.el
file3.el ..." and emacs only actually loads the first file. The command
needs to look like "... -l file1.el -l file2.el -l file3.el ..."
>> --- /dev/null
>> +++ b/test/debbugs-test-helpers.el
>> @@ -0,0 +1,146 @@
>> +(defconst debbugs-test--bug-status-soap-return
>> +(defconst debbugs-test--bug-status
>
> Perhaps we should move these data into an ert-resource file (or two).
>
I read the info manual and source code pertaining to 'ert-resource' and
I fail to see any benefit from using it.
>> +(defmacro ert-deftest--debbugs (name args docstring &rest body)
>> + "The same as `ert-deftest' but runs setup and teardown functions."
>> + (declare
>> + (doc-string 3)
>> + (indent 2))
>> + `(ert-deftest ,name ,args ,docstring
>> + (debbugs-test--setup)
>> + ,@body
>> + (debbugs-test--teardown)))
>
> In order to ensure that debbugs-test--teardown is called even in case of
> errors, we could use
>
> (unwind-protect
> (progn
> (debbugs-test--setup)
> ,@body)
> (debbugs-test--teardown))
>
Good catch! Thank you! I don't want to move things and change them at
the same time so now this is two patches.
>> --- a/test/debbugs-tests.el
>> +++ b/test/debbugs-tests.el
>> @@ -27,118 +27,7 @@
>> ;;; Code:
>>
>> (require 'debbugs)
>> +(require 'debbugs-test-helpers "./test/debbugs-test-helpers")
>
> (require 'debbugs-test-helpers) should be sufficient with the proposed
> change in the Makefile.
Done!
>
> Best regards, Michael.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v2-0001-tests-Move-helper-and-wrapper-functions-into-thei.patch
From 310038c998bfcaddebd4144d6d37da6a4d4f6aeb Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:52:03 -0500
Subject: [PATCH v2 1/5] tests: Move helper and wrapper functions into their
own file
* test/debbugs-test-helpers.el: New file.
* test/debbugs-tests.el: Move test helper and wrapper functions into the new
file and require it.
* Makefile(check): Load all files in the test directory.
---
Makefile | 5 +-
test/debbugs-test-helpers.el | 146 +++++++++++++++++++++++++++++++++++
test/debbugs-tests.el | 113 +--------------------------
3 files changed, 151 insertions(+), 113 deletions(-)
create mode 100644 test/debbugs-test-helpers.el
diff --git a/Makefile b/Makefile
index a7b6b0c7f3..eec1c65a14 100644
--- a/Makefile
+++ b/Makefile
@@ -14,6 +14,9 @@ INFOMANUALS=debbugs.info debbugs-ug.info
%.elc: %.el
@$(EMACS) -Q -batch -L . -f batch-byte-compile $<
+test/%.elc: test/%.el
+ @$(EMACS) -Q -batch -L . -L ./test -f batch-byte-compile $<
+
%.info: %.texi
$(MAKEINFO) --error-limit=0 --no-split $< -o $@
@@ -24,7 +27,7 @@ doc: $(INFOMANUALS)
build: $(TARGET)
check: build $(TESTTARGET)
- @$(EMACS) -Q --batch -L . -l $(TESTSOURCE) -f ert-run-tests-batch-and-exit
+ @$(EMACS) -Q --batch -L . -L ./test $(foreach file,$(TESTSOURCE), -l $(file)) -f ert-run-tests-batch-and-exit
clean:
-rm -f $(TARGET) $(TESTTARGET) $(INFOMANUALS)
diff --git a/test/debbugs-test-helpers.el b/test/debbugs-test-helpers.el
new file mode 100644
index 0000000000..f98bab40ed
--- /dev/null
+++ b/test/debbugs-test-helpers.el
@@ -0,0 +1,146 @@
+;;; debbugs-test-helpers.el --- Helpers for testing debbugs -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2024-2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;; Please ensure tests don't actually make network calls.
+
+;;; Code:
+
+(require 'debbugs)
+
+;;; Helper Data:
+
+;; Generated using this:
+;; (soap-invoke debbugs-wsdl debbugs-port "get_status" [64064])
+(defconst debbugs-test--bug-status-soap-return
+ '(((item
+ (key . 64064)
+ (value
+ (package . "emacs") (found_date) (last_modified . 1689593050)
+ (affects) (date . 1686745022) (fixed_versions)
+ (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>")
+ (blocks) (archived . 1) (found) (unarchived) (tags . "patch")
+ (severity . "normal") (location . "archive") (owner) (fixed)
+ (blockedby) (pending . "done") (keywords . "patch") (id . 64064)
+ (found_versions) (mergedwith) (summary) (forwarded)
+ (log_modified . 1689593050)
+ (done . "Michael Albinus <michael.albinus@HIDDEN>")
+ (source . "unknown")
+ (msgid
+ . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
+ (bug_num . 64064) (subject . "[PATCH 0/4] debbugs improvements")
+ (fixed_date)))))
+ "Mock result from `soap-invoke' for bug 64064.")
+
+;; Generated using this:
+;; (debbugs-get-status 64064)
+(defconst debbugs-test--bug-status
+ '(((cache_time . 5000) (source . "unknown") (unarchived)
+ (keywords "patch") (blocks) (pending . "done") (severity . "normal")
+ (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive")
+ (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements")
+ (last_modified . 1689593050) (found) (tags "patch") (package "emacs")
+ (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t)
+ (blockedby) (affects) (mergedwith) (summary) (date . 1686745022)
+ (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded)
+ (msgid
+ . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
+ (owner) (found_versions) (fixed_date) (bug_num . 64064)))
+ "Mock result from `debbugs-get-status' for bug 64064.")
+
+;;; Helper Functions:
+
+(defvar debbugs-test--soap-operation-name nil)
+(defvar debbugs-test--soap-parameters nil)
+(defun debbugs-test--soap-invoke-internal
+ (callback _cbargs _wsdl _service operation-name &rest parameters)
+ "Over-ride for testing."
+ (setq debbugs-test--soap-operation-name operation-name)
+ (setq debbugs-test--soap-parameters parameters)
+ (let ((return
+ (cond ((string-equal operation-name "get_status")
+ debbugs-test--bug-status-soap-return)
+ ((string-equal operation-name "get_usertag")
+ '(((hi))))
+ (t '((0))))))
+ (if callback
+ (progn
+ (funcall callback return)
+ nil)
+ return)))
+
+(defun debbugs-test--override-float-time (func &rest rest)
+ "Override `float-time' for FUNC with args REST."
+ (cl-letf (((symbol-function #'float-time)
+ (lambda (&optional _specified-time) 5000)))
+ (apply func rest)))
+
+(defun debbugs-test--setup ()
+ "Mock network and time functions.
+These mock functions are needed to make the tests reproducible."
+ (setq debbugs-test--soap-operation-name nil)
+ (setq debbugs-test--soap-parameters nil)
+
+ (add-function
+ :override (symbol-function #'soap-invoke-internal)
+ #'debbugs-test--soap-invoke-internal)
+
+ (add-function
+ :around (symbol-function #'debbugs-get-cache)
+ #'debbugs-test--override-float-time)
+
+ (add-function
+ :around (symbol-function #'debbugs-put-cache)
+ #'debbugs-test--override-float-time))
+
+(defun debbugs-test--teardown ()
+ "Restore functions to as they where before."
+ (setq debbugs-test--soap-operation-name nil)
+ (setq debbugs-test--soap-parameters nil)
+
+ (remove-function
+ (symbol-function #'soap-invoke-internal)
+ #'debbugs-test--soap-invoke-internal)
+
+ (remove-function
+ (symbol-function #'debbugs-get-cache)
+ #'debbugs-test--override-float-time)
+
+ (remove-function
+ (symbol-function #'debbugs-put-cache)
+ #'debbugs-test--override-float-time))
+
+(defmacro ert-deftest--debbugs (name args docstring &rest body)
+ "The same as `ert-deftest' but runs setup and teardown functions."
+ (declare
+ (doc-string 3)
+ (indent 2))
+ `(ert-deftest ,name ,args ,docstring
+ (debbugs-test--setup)
+ ,@body
+ (debbugs-test--teardown)))
+
+
+(provide 'debbugs-test-helpers)
+
+;;; debbugs-test-helpers.el ends here
diff --git a/test/debbugs-tests.el b/test/debbugs-tests.el
index f3abea2837..da1b9dffe6 100644
--- a/test/debbugs-tests.el
+++ b/test/debbugs-tests.el
@@ -27,118 +27,7 @@
;;; Code:
(require 'debbugs)
-
-;;; Helper Data:
-
-;; Generated using this:
-;; (soap-invoke debbugs-wsdl debbugs-port "get_status" [64064])
-(defconst debbugs-test--bug-status-soap-return
- '(((item
- (key . 64064)
- (value
- (package . "emacs") (found_date) (last_modified . 1689593050)
- (affects) (date . 1686745022) (fixed_versions)
- (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>")
- (blocks) (archived . 1) (found) (unarchived) (tags . "patch")
- (severity . "normal") (location . "archive") (owner) (fixed)
- (blockedby) (pending . "done") (keywords . "patch") (id . 64064)
- (found_versions) (mergedwith) (summary) (forwarded)
- (log_modified . 1689593050)
- (done . "Michael Albinus <michael.albinus@HIDDEN>")
- (source . "unknown")
- (msgid
- . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
- (bug_num . 64064) (subject . "[PATCH 0/4] debbugs improvements")
- (fixed_date)))))
- "Mock result from `soap-invoke' for bug 64064.")
-
-;; Generated using this:
-;; (debbugs-get-status 64064)
-(defconst debbugs-test--bug-status
- '(((cache_time . 5000) (source . "unknown") (unarchived)
- (keywords "patch") (blocks) (pending . "done") (severity . "normal")
- (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive")
- (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements")
- (last_modified . 1689593050) (found) (tags "patch") (package "emacs")
- (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t)
- (blockedby) (affects) (mergedwith) (summary) (date . 1686745022)
- (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded)
- (msgid
- . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
- (owner) (found_versions) (fixed_date) (bug_num . 64064)))
- "Mock result from `debbugs-get-status' for bug 64064.")
-
-;;; Helper Functions:
-
-(defvar debbugs-test--soap-operation-name nil)
-(defvar debbugs-test--soap-parameters nil)
-(defun debbugs-test--soap-invoke-internal
- (callback _cbargs _wsdl _service operation-name &rest parameters)
- "Over-ride for testing."
- (setq debbugs-test--soap-operation-name operation-name)
- (setq debbugs-test--soap-parameters parameters)
- (let ((return
- (cond ((string-equal operation-name "get_status")
- debbugs-test--bug-status-soap-return)
- ((string-equal operation-name "get_usertag")
- '(((hi))))
- (t '((0))))))
- (if callback
- (progn
- (funcall callback return)
- nil)
- return)))
-
-(defun debbugs-test--override-float-time (func &rest rest)
- "Override `float-time' for FUNC with args REST."
- (cl-letf (((symbol-function #'float-time)
- (lambda (&optional _specified-time) 5000)))
- (apply func rest)))
-
-(defun debbugs-test--setup ()
- "Mock network and time functions.
-These mock functions are needed to make the tests reproducible."
- (setq debbugs-test--soap-operation-name nil)
- (setq debbugs-test--soap-parameters nil)
-
- (add-function
- :override (symbol-function #'soap-invoke-internal)
- #'debbugs-test--soap-invoke-internal)
-
- (add-function
- :around (symbol-function #'debbugs-get-cache)
- #'debbugs-test--override-float-time)
-
- (add-function
- :around (symbol-function #'debbugs-put-cache)
- #'debbugs-test--override-float-time))
-
-(defun debbugs-test--teardown ()
- "Restore functions to as they where before."
- (setq debbugs-test--soap-operation-name nil)
- (setq debbugs-test--soap-parameters nil)
-
- (remove-function
- (symbol-function #'soap-invoke-internal)
- #'debbugs-test--soap-invoke-internal)
-
- (remove-function
- (symbol-function #'debbugs-get-cache)
- #'debbugs-test--override-float-time)
-
- (remove-function
- (symbol-function #'debbugs-put-cache)
- #'debbugs-test--override-float-time))
-
-(defmacro ert-deftest--debbugs (name args docstring &rest body)
- "The same as `ert-deftest' but runs setup and teardown functions."
- (declare
- (doc-string 3)
- (indent 2))
- `(ert-deftest ,name ,args ,docstring
- (debbugs-test--setup)
- ,@body
- (debbugs-test--teardown)))
+(require 'debbugs-test-helpers)
;;; Tests:
--
2.48.1
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v2-0002-tests-Use-unwind-protect-to-ensure-test-cleanup-a.patch
From 1f59c38fb149ec8b5716e89135e9d2fb46c687d9 Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:47:28 -0500
Subject: [PATCH v2 2/5] tests: Use 'unwind-protect' to ensure test cleanup
always occurs
* test/debbugs-test-helpers.el(ert-deftest--debbugs): Use 'unwind-protect'.
---
test/debbugs-test-helpers.el | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/test/debbugs-test-helpers.el b/test/debbugs-test-helpers.el
index f98bab40ed..7ea6f00dce 100644
--- a/test/debbugs-test-helpers.el
+++ b/test/debbugs-test-helpers.el
@@ -136,9 +136,11 @@ These mock functions are needed to make the tests reproducible."
(doc-string 3)
(indent 2))
`(ert-deftest ,name ,args ,docstring
- (debbugs-test--setup)
- ,@body
- (debbugs-test--teardown)))
+ (unwind-protect
+ (progn
+ (debbugs-test--setup)
+ ,@body)
+ (debbugs-test--teardown))))
(provide 'debbugs-test-helpers)
--
2.48.1
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at 76446) by debbugs.gnu.org; 21 Feb 2025 12:03:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 21 07:03:24 2025
Received: from localhost ([127.0.0.1]:55781 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tlRkZ-0006mQ-51
for submit <at> debbugs.gnu.org; Fri, 21 Feb 2025 07:03:24 -0500
Received: from mout.gmx.net ([212.227.17.21]:56869)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>)
id 1tlRjg-0006eC-9K
for 76446 <at> debbugs.gnu.org; Fri, 21 Feb 2025 07:02:31 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de;
s=s31663417; t=1740139341; x=1740744141; i=michael.albinus@HIDDEN;
bh=yi1I1slgDWtyL/djILFTUbaXtNk1pbQ0ZG8BtaVyeBA=;
h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date:
Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding:
content-type:date:from:message-id:mime-version:reply-to:subject:
to;
b=uZ5MJygaOY1j6o6st6XIYOTBaAIjK6/619vIGZxK4kIAOshynPl7BFchXZtb3uqm
OFXjsYl3v3T7TX4Qgf8c2ruOtKN9atcfkGWyEJ/UqPmeOztyqBXR8S89siHWYETYU
65UD1S3oGtoWYqw3d5NslA1eYwtVa+XvObi4430CdEPwO9YUeUFmxCyiWEjNWwJ4P
EWTMI7FSN6YNbi4RLwjWDnkQAKE12zy8CwZDqfi8Xw3+Xpmhr0bRX1sY2oSC+EUra
DVDvOLuqzNZYJJJaN5f5ulKqd3qQmwiwMi4e7JP28X+NhdXiP7dxNdnrukVsZi78K
mtLmAtIRhqeL6ZUghQ==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx105
[212.227.17.168]) with ESMTPSA (Nemesis) id 1N4Qwg-1tMjcZ1cHu-00wvLR; Fri, 21
Feb 2025 13:02:21 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
To: Morgan Smith <Morgan.J.Smith@HIDDEN>
Subject: Re: bug#76446:
0003-Makefile-Add-target-to-run-checkdoc-on-all-files.patch
In-Reply-To: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
Date: Fri, 21 Feb 2025 13:02:20 +0100
Message-ID: <87v7t3wlo3.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:JITi1PrkT1EfKIX4Y5/xWWVtQbImsPkFh8gUTn5Ol/dEE7CNAhR
jaxiZWJiIEsy0MtigiQWHbZYJ26XGkqbXhtCVYYXwouYvrRN+XJqYlS4Dvp3nCnItRV8cX9
/tR1jQFHZ3TPe2+OY+NVWrhtMUx3mvTTQW8bx+L9Nb97fcnSsQZi1dFxYhmoi4oiC3Qs8c8
J82YyxAfsC0z+Vb4XplfA==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:jetl3ntci28=;63zyQCWY0Rd3g0mo+Dv6+3F5GRQ
iq0qIQDEtyCN4d9RqnANtqBewHgucCr5fTDZ8EVDIYNRV0vWb73i2XWxa6dvXF0TF1E0sIE1b
Mhxbh9iAeDLBYFq53lzJQ90blsdDjX8FsfNBQAStO7b4HSECEKByaxMVdiE9xvOUcw+ucc8C9
+lxFFL67W453G/dnH2YgLl/Ugsi3wKK25hVMJgv4yBPveMnVYBEjtNZdg+LzX1TcSOoFv+3rS
yHZPZliOKjTXbbLRBP4dA2kJ0AcvIvBbTkOnGHq8zdAnNoaxp0PNAxapPjlyuHA/+EGbAbsPD
PA8B/8YJdfW+QcafNqXE1u4SRy/bqVSguXyzHk2RhaQdMCmL0LLlRuqooEeVFs8qJZZPKX/kq
MMyr0i2UDmHi9oJcLX3DHPJ4OKI/wRPk/q33KQHFRJXIwfnvTztBJI65/jcsaxW4U9PKDjT/o
XvQUF2oaklGrkHONfrY5hrX+V//wDrPA4PJ+vv47ph79pL+C5jA1UnaHwPXb/9Yu47LSqamrN
xq/hMo/nbp7M+RhdM9fRpqcqA1Cg7Dcb1BaLPq9m+nBpmBm7ScwwGBs1EQNo9fYArHBPZ26tV
jOyXU1Up0m4xfmoi0Lf+4MqnddfJjChxU1i57bgjbWod7HSHJQCt1cybOehVzN2SlOva4bZWm
Wf42ZGnqy4etexthVc0/946aZMYJFarFxj1Sal9H1WAooV+N/SfHELoqdeKVYh7o2+sqng0Yj
UwXEsyyIiScnmhx9/WG90s/48mEwxDx7Vx9ZJeCPgwvQe/Ap7CHT8jU7O6D+mvVweHvvD+Aw0
HdEyHQSSQjrcfpDMxItGiN2kaQxfOvJpXVROwO/P2XATrTqlICBfoNIyXHVLr8et6cRpBQ/ls
165VWVSLUfOF+EI0Ylfbpqv8A1S0ZAc8JXodD4iZ9FtmSeLydwGUySlGxKTBKdH4GR7IhXbaT
lg7jLd9pzYHQnYf1Hg9TU0q8i4YMtmnCOih6dxXReQZBtQzHhsI3Llm9Rdod3N7ps+/LEKNsa
I08Slyeb6GEroLC+5JnfQPgFpky1SgFXQvgXRS/pV/dwn5inT/cLkJpLammIvFGfVHv5M5AXm
tNy3A6ZVjBOYIwr5NrKBKa1xmKUMkYt4rcFV5t1Rq+xujc1JHf4vtBc8fcuPfLWnVRV3mSwBd
AsBBBZX8nDTLC86vtPx8X3UTzc1P4Zqh1cFLJ3CIJrzQLz6wZXAnLiHoxpou0s4Pj/9QTaLJN
FgKfnqyHO+RuOhaYp5AL9dYU06MN3wIymwA15ik5hisekOjTYEm9Hx+zfdSfKgHSOgZJaShCI
I8FyKBRjfC+yMTVWX4fd0IKf4nmqAUCTQ19eGrsY913k9cUFU9XvroAJul/jftw20HVWBTo7O
HsMM/JPe3vLen27+Nisnqr6E4FDlWbK/zUv8l71Z9+pUE0ZoPxHY+yDbBd
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Morgan Smith <Morgan.J.Smith@HIDDEN> writes:
> --- /dev/null
> +++ b/.dir-locals.el
> @@ -0,0 +1,18 @@
> +;;; Directory Local Variables -*- no-byte-compile: t -*-
> +;;; For more information see (info "(emacs) Directory Variables")
> +
> +((emacs-lisp-mode . ((checkdoc-package-keywords-flag . t)
> + (checkdoc-ispell-lisp-words
> + .
> + ("ChangeLog" "ChangeLogs" "UTF" "alist" "args"
> + "armstrong" "backend" "bcc" "bugreport" "cdate" "cedet"
> + "coreutils" "cygwin" "debbugs" "debian" "el" "emacs"
> + "etags" "freemail" "fsf" "guix" "gw" "henoch" "hu"
> + "hyperestraier" "keymap" "magit" "magnus" "maint"
> + "maintainer" "maintainer's" "mbox" "mboxes" "minibuffer"
> + "moreinfo" "multibyte" "notabug" "paren" "persistency"
> + "regexp" "rescan" "rgm" "rmail" "severities" "sexp"
> + "solaris" "src" "sublist" "submitter" "submitter's"
> + "subproduct" "subqueries" "subquery" "teardown"
> + "unarchived" "unibyte" "unreproducible" "url" "util"
> + "wishlist" "wontfix" "wsdl" "www" "xsd" "zltuz")))))
This is needed for the checkdoc target in make only, isn't it? Shouldn't
we activate it for just this case?
> --- a/Makefile
> +++ b/Makefile
> +checkdoc: $(SOURCE) $(TESTSOURCE)
> + @$(EMACS) -Q --batch "--eval=(setq enable-local-variables :all \
> + checkdoc-spellcheck-documentation-flag t)" \
> + -L . $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")")
Do we need '-L .'?
Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.Received: (at 76446) by debbugs.gnu.org; 21 Feb 2025 11:56:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 21 06:56:55 2025 Received: from localhost ([127.0.0.1]:55669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tlReJ-0005rE-0f for submit <at> debbugs.gnu.org; Fri, 21 Feb 2025 06:56:55 -0500 Received: from mout.gmx.net ([212.227.15.15]:51649) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>) id 1tlReG-0005pj-A1 for 76446 <at> debbugs.gnu.org; Fri, 21 Feb 2025 06:56:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1740139004; x=1740743804; i=michael.albinus@HIDDEN; bh=bWKFvvU5kMvUensnc6t6fdiMW1hF7XWYBNBOTUWwuZI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=DcO1k++ipajTZ3Iw7t6XJ+uKjxfV+7lSkxpqksJZ1yOMcwkCzWNXwg7mlcTQ2LXy 5ay/g2Ig0kYumyCzqSJH5PCc1ufaLyp9iB+ditE0qKo3HHpYxF+NlI75mWySx3e2o 6zNHc5fDlnCgyWv6WJYwFa2AIT7cJSJldoIB0PWMkKgZzYlQzBlTcgq6FH9NEFy4i IjglLIycXCKyCXqn2vZCnjZ16uqyXOLlUn0d6pXz+9f63DfzUaDaaVUZcOIqYMqVj SL2dLIk3J/9JxcVjLZmsYThwgCn42gS//x5QXXr2H6+Joj8yEXFZ1IKZUZwaRzjXV 84eNx77ipqVJpBRawA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MVvL5-1tvWEj2pi1-00Z2Ol; Fri, 21 Feb 2025 12:56:44 +0100 From: Michael Albinus <michael.albinus@HIDDEN> To: Morgan Smith <Morgan.J.Smith@HIDDEN> Subject: Re: bug#76446: 0002-tests-Add-tests-for-debbugs-gnu.patch In-Reply-To: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> Date: Fri, 21 Feb 2025 12:56:43 +0100 Message-ID: <87zfifwlxg.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:APjAnCYZQpmVJxVM8krd3RWytGOqbG11xO/+K3Reax2DNiRDU/p IsGC2ohDNHrc2ObDcTbNgZFm5WDECCqVBnkLxPibTAL/1gBDTgR7hQh9mr013+ECEiPKwoA k0+xsT9MKoMvBFdssTkoguf9y6Lc7yX2NYmJy2RtEpnunQfhpkaoaz0cIY4ppmHPkCHccF1 JBByxLTmN/cV/4Xi7M+4Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:DD9Xz0itysY=;0gdOPlZ4hItqtZMwPlNrtjNd/fJ AR51B9SxmGgL5S54z88eGrQoY+NYeGM0kWjH86E61T1tw/HKRimc0yQNHEWUzxP3gJBRD+H0r A1HcgbU2bDRvcMb3yshpW5OEt2yXGZ7ePaQP1jzsNmNo470kZEGCrcumNm5kOT7a+W/5cpkbE 0HJtAO7Eu0ee090pmbMpFVM6FD675o0OnkGYuWkeiXlFam+Yuf22w26Cgj8nrCfI9ajDBEkoQ HTzADT++sc50nipnXIzJQEtBevM6ugi/A6gAA1Xg5ltSs3niarM69yExoCr1yxp77g9apXtrh 6OSHtHbUsrT+9qhTnZaejGvYrag4GJhCTSyFhDiLcj1tulV7ynVB898urQ9jQ92fBF/ul8dJ0 dgaNsVfwjmGJGQ2ardA6Jrf8192CSegtPvZncRSkTXLXnB4VKfwHzd6111K3Ogyz+2U133Yoc W/lhHVO1qnGF2o3moxe0qXQA1kBXxaoq7AIBCC7WBNhVDv9FcalHUet5/EnKhuZ10Tm7RfU7t d3oLR2hxyev6hn4w5X/SZp1MUCkRFk7xTu6iWNQW0M8PsGIeGM4oeDQ7Yg5KtYNpjtRg6hP5X PW6nhH2GaVVhUNUsbJtZvhc+fIbaaIZ6z7VdsQMz9PQDzAHnS8F2OKRKRdE+Jy8GTZP9YE5mD sy10rUTYP6zlLSQsJ+U5FOs/T0taU9aPS01QTXGO/O9tAs6PnUTvdJfIe9lZe0FTHhxmN5XVk XMO+KwE5ITL8GCydYRyM0nHr+/avqWyzMKBtqQzR/Q8+x+7KCTVYnmtaouoK2BlczyjTGkQXJ a5QfLqPbB91Eht0glybXsfC/mP71OfywNeSC2yMQxvxJ1mulJjQbP7sCVnksx9GiCgw5fBGy/ ebr3OrZ3p/zdS/SOxazB+m3VN187EFwTTgAP3ENpC0U3+dhiv6wUMA9uxJQKy4u39l8e1OZKa 7WVpquNmovI8wq87ibqaFPZcuZqftN3yRHXX02HDR69PZtiM09+LdVkQpqXxGgntFDX8WJnD1 EhDrbM3rK9JBvwutfho+9UAjNNx084TqCEpMfFopCjZXpdFjr0D7y7hDpeiYhNWvzYYkS6u1E IinTy7zYgXFwesrsdPkYOh8RAcudmtNP7qfKW77U8okN+jm/vydSxs6ef/G7L3qAPqjvMG0VZ CZD+mk4ss8PdFK8FHEYLw2bb8mGoEl4Nf+tES8Ca813DyyeXGM8Wi0IgPYoB8ytg4RA+INnRf TUIJnxYP4kDM0IJOBQFuTXEV3ks3eqBSVwdb4HD/XRVWv5YHYl2i5rzz3lrkNx/Jdkgfbz2pV rZlJbzWGuGd2HpDxpMESZCLbMvzwZwwkFW1gkIYyZY6KBUsmKhOi+tLajuh6Xua5eH3u98BWG 0x+6vBtJ22KYsh82x0M8+8tZt/lkN/FbCh+MDEKefou4WXMufSh6uiux4T X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76446 Cc: 76446 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Morgan Smith <Morgan.J.Smith@HIDDEN> writes: > --- /dev/null > +++ b/test/debbugs-gnu-tests.el > +(require 'debbugs) > +(require 'debbugs-gnu) > +(require 'debbugs-test-helpers "./test/debbugs-test-helpers") (require 'debbugs-test-helpers) is sufficient. > +(ert-deftest--debbugs debbugs-test-debbugs-gnu-search () > + "Test `debbugs-gnu-search'. Isn't it rather a test of `debbugs-gnu'? > +Also test `debbugs-gnu-patches' and `debbugs-gnu-tagged' which are > +simple wrappers for `debbugs-gnu-search'." Nope. They are wrappers of `debbugs-gnu'. Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at 76446) by debbugs.gnu.org; 21 Feb 2025 11:52:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 21 06:52:31 2025
Received: from localhost ([127.0.0.1]:55597 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tlRa2-0005Bf-2e
for submit <at> debbugs.gnu.org; Fri, 21 Feb 2025 06:52:31 -0500
Received: from mout.gmx.net ([212.227.17.22]:42465)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>)
id 1tlRZz-0005AV-2W
for 76446 <at> debbugs.gnu.org; Fri, 21 Feb 2025 06:52:28 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de;
s=s31663417; t=1740138738; x=1740743538; i=michael.albinus@HIDDEN;
bh=tTaReb9YoGwN5K11wjQJNJWzkDfgadXv+vOh7QJOpF0=;
h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date:
Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc:
content-transfer-encoding:content-type:date:from:message-id:
mime-version:reply-to:subject:to;
b=L0n2M6gMIzZ1I0Hr3bok6gfTkOjlwzvK8Cw2iJSwhm6T22iJnU9kVMfNbecMyhrK
z+wM/gESBcJKixKnQkp251cO1mV0ug2Z2hF6C3PFt+vRbb2SPOrki1zfdWjBAhSqm
g/qkS7Ez198KEsyXnJVOKIJ/7jUEYoOlvDehuuTczsMJs4R6nEVRXCCc+3M45mUSJ
3lpu9bA6yGCEJc1uKuZ8Im9yG76JPIpeB+ncoXzIAgt/KUp72jjlIKiIjQIC8m4hz
inSLLVvsTxG/AG5Ur0ioi2oGZgfuzH2YdF2OrKpebHw9xR+zZXP+EoVjy8Mgf+Yfr
8Y01Kh2FzCOADFElDA==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx104
[212.227.17.168]) with ESMTPSA (Nemesis) id 1MTiTt-1ttJNc3eG5-00Kkyi; Fri, 21
Feb 2025 12:52:17 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
To: Morgan Smith <Morgan.J.Smith@HIDDEN>
Subject: Re: bug#76446:
0001-tests-Move-helper-and-wrapper-functions-into-their-o.patch
In-Reply-To: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
Date: Fri, 21 Feb 2025 12:52:17 +0100
Message-ID: <874j0ny0pa.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:QbUQM9U+BUrgoYCKMrO/pFW+mqqRYMMFo+pyB1F5+llRh2fNWTg
oK8gm/FTs9b0yPizGlHfyX2WZwKmOC9C9gv7/Pc3L/w5GClf0lPVWa6Ag46QO5KUaVtKLXa
1f/rdrCOWE0b3W7ys295mTXub6sql77gXuffz1rQzxJe800j4GYCAb9YFZcgE/HEj3hvMq+
FxWAuBQVGpNN1zIwDS1Zw==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:CYB6Gk+bE/A=;EtCE1DCBeQQpG4yaSP0GG+ge8i+
OcqBN8pzqYBPXvU/bseT2MJ7zqwIeYqpqWueXM7yrgyP7i9SUGjWoNlz5QdvcGNFn1WfILfU7
CqBGLYl1FYc91bJvvKkhNqKcFi/XfY7C1nMwf7aKC+3ghDebYG+uqJSvM5+uodGghzDE3t8uJ
pEYQWTExnvWxvrmKLDN/zXkdFsXoKeWBtwRxbs7RmyvxgsSAjXW9fUgSCoI1KS/K0sJ/HEcsr
qATegq1G7phKcCcuT3e6eRnYpjJczbl16gKAFFW4yQmmmcyfV6ZnljWia+AY0e15w7aR74RFP
W96a3TQcjrUyzOSDEzpRTdfWFVe8I1NzNjbA20sRDlgo5xqUvUd0VAwVUhdqKiBIKoEofiRJ1
stzMELjxRdyLlVFek1eDYv1euqPRRr8FKXaRrBUWs0J/KeiU48bzNYeTglc4MKO+Pryt8SkU9
/YIDnG3aRmyvmOYb6tw9Wy/mRZ5q3KkvORCiP/krqo1C3DwImWutx1ynOLUP+VsYk1562OJWq
0KHqREdFZCDYPNAphI83AN5V+om4RVfWJelpL41dgm1PdUTPco47oh8kk26IwK2uULY/SfKPj
mpzsf6GpIgPacqc3i57cWuUP3LIP/YfZPJiTopjq1l5SoRaTH/QlYp4SwNtSuHSmY7RAxTeb5
JupQTjpY6/+lgYyc+Fl1tuCMdcHdjXymNKhBczR8jlHGBKvtNgfR4HyWWW8sGqUCjxXaayCne
jdGpc4XzH8mAje/y0qP4oFjp8S8p9NemvszNBMgveckjdgfiDjddpsYIRnm0u9BRQaVvJa0t1
QAuj9X4e+WJjm/uUDJH+fXDtlBHerEXBm2dvl1hfePmMWp65GiOlPf8D9CgEWNM1lmAeFmjC5
93xzDfTmw56FavFYTUgTfxZ2MLr9wpztmMvxAuRmqExSwiH7W8wFZ5m0ZgHoBoMtfltii8T+P
R9Nt+xxCsQTwio3cU+vCtJCvevsHa+TnSBBB4U3DzVnzxcRpBF13IdXR0tb2U7k8QYLcDuvsf
3oyYxFmpgPhsAeYW/IqEi8Zp8N0JSFo+A/FmCfP4MOATt5Dmf3nJfQlk9Fb2h8jHR3s7q2y7B
ims2RPvOdPLCow7SRAXrg9NIFior59DAiXYl+4q4EgrzbajumDmjdpV+p7P5tEPqYaKhJGRIG
EFu1N9aLeHkTZaJGI1RKVfbuGAocgYxv20sT21ypJrlkvxBl7INNEG9+J4mgRZft20hI2JXtY
gPINcrS23jotbKaotPXi8stxS2f+GBJxG6C7j+exArtJ/5PHurCaU7SIw0adK7Nt2TlwV9Z6P
Uihz/EipJhZjx0EuReUw8CIKffDh8TgX9e2MkXCpnnc7UozFgmCRB5KOvKYpjEPsoyTYI9ZYQ
Uc1Sly9EYQoy9En8FXqOOOTGtXlSKD2g9duqS9UnKi2zorwqS4phabeHzC
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Morgan Smith <Morgan.J.Smith@HIDDEN> writes:
> --- a/Makefile
> +++ b/Makefile
> @@ -24,7 +24,7 @@ doc: $(INFOMANUALS)
> build: $(TARGET)
>
> check: build $(TESTTARGET)
> - @$(EMACS) -Q --batch -L . -l $(TESTSOURCE) -f ert-run-tests-batch-and-=
exit
> + @$(EMACS) -Q --batch -L . $(foreach file,$(TESTSOURCE), -l $(file)) -f=
ert-run-tests-batch-and-exit
We might be better with
=2D-8<---------------cut here---------------start------------->8---
@$(EMACS) -Q --batch -L . -L ./test -l $(TESTSOURCE) -f ert-run-tests-batc=
h-and-exit
=2D-8<---------------cut here---------------end--------------->8---
> --- /dev/null
> +++ b/test/debbugs-test-helpers.el
> @@ -0,0 +1,146 @@
> +(defconst debbugs-test--bug-status-soap-return
> +(defconst debbugs-test--bug-status
Perhaps we should move these data into an ert-resource file (or two).
> +(defmacro ert-deftest--debbugs (name args docstring &rest body)
> + "The same as `ert-deftest' but runs setup and teardown functions."
> + (declare
> + (doc-string 3)
> + (indent 2))
> + `(ert-deftest ,name ,args ,docstring
> + (debbugs-test--setup)
> + ,@body
> + (debbugs-test--teardown)))
In order to ensure that debbugs-test--teardown is called even in case of
errors, we could use
(unwind-protect
(progn
(debbugs-test--setup)
,@body)
(debbugs-test--teardown))
> --- a/test/debbugs-tests.el
> +++ b/test/debbugs-tests.el
> @@ -27,118 +27,7 @@
> ;;; Code:
>
> (require 'debbugs)
> +(require 'debbugs-test-helpers "./test/debbugs-test-helpers")
(require 'debbugs-test-helpers) should be sufficient with the proposed
change in the Makefile.
Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.Received: (at 76446) by debbugs.gnu.org; 21 Feb 2025 11:41:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 21 06:41:30 2025 Received: from localhost ([127.0.0.1]:55397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tlRPO-0003aJ-0t for submit <at> debbugs.gnu.org; Fri, 21 Feb 2025 06:41:30 -0500 Received: from mout.gmx.net ([212.227.17.20]:35727) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>) id 1tlRPK-0003Z4-Bx for 76446 <at> debbugs.gnu.org; Fri, 21 Feb 2025 06:41:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1740138077; x=1740742877; i=michael.albinus@HIDDEN; bh=0P6wjHR/wN3b5IHn0RSTUWjSK09I3SbCIw7MUpzL65Q=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=p2UOrRReAx6ZYpT4alpdgp0FpKvbwz0xTRocw6w5AWwkF3qVPRLoVxypeRZKDfOO yiS4QEMwhCIEf5/H54UPfPh8LOorwpeojXOhCXVr7xo564y6aI1ToSqlsjSwdKn9L OD6m7+5mhpRY2mHa74s/OfMNn2kW60OlzZ0yOIVIFLkcRllQ2rmELJc+9MZiW9Vv6 Y0bn4U9swFNucrseYv/Xb8l2404ogaFz9mZSAtFNQAm/vHrcs6dYwhHYTIpxKHx+C RmfFYEeSYQemEJ5edg4PwJSdqU++wIRb1SZwQ/NcC96WAOFBcZ/xgjfAGqi6e8dlI rWBV1V0uhHS+E+D2hw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mv2xU-1tTuYP0XPk-011T2s; Fri, 21 Feb 2025 12:41:17 +0100 From: Michael Albinus <michael.albinus@HIDDEN> To: Morgan Smith <Morgan.J.Smith@HIDDEN> Subject: Re: bug#76446: [Patch Debbugs] Infrastructure Improvements In-Reply-To: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> Date: Fri, 21 Feb 2025 12:41:14 +0100 Message-ID: <87bjuvy17p.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:nHk/D7IzASRi6e5H3GtEZbyjBtoE9ata5xlDOHFaFOerHm09dCw S+qLTI8Bk5mW8FJ5nkjTsbkjxcBWBQbgF8i40DIUBPbYXfzu8tJEMyV+nxwm9I/QE6OVFu3 Rx4GfJtR5N0VSio6uQDPx1sO1YtsaOJyR9vJNpsVWYf5Pq8Onfy5Ho9TAUlM4h9FIfYyM4l mcP+GjKtjGbYCaY8TK/oA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:IV9sMUEpCTA=;h+3JbK7Di2abDfccn5Q+z1dndie bazZSY0cGLgVxkn1D5pfwPkSdsSfMpXknp1YFgTUYoDr8qrpnJvhtraxJtpP4sLySkSToic7r a160LZyQST5CuDz+pF6kA2LeQvN56bN35GRdnPDvfb4NcWukAvqyYrjCFpd3gCyLi+gd9P92U dCJM3IBD2JyVv3r8PFyVD3/IQuGq1oSHPN2Dmg7gz0p1ffSFj+aY+Y215vRbWGDUZr5atLeB7 0qYfnDk4N67f+veHlu65ckcOnGvS8Hls3C0WJhXVZ5dqvRJuUU7CmnXM8AD00rXspae3T9wXU cxceN7XRPvmcvnOLpFOSJX5UYnDZsyCi0ghIH0D5VkbJOLygOzSDLxWPqWxVVEqKqds3X0Hf0 b8O07E059IC+9iC/m23p8JlzIG19+bu0XjGtDDYBAV9SUGC6RpNo9e5hhrNzYNVnIhZFJ+x1S RmS1F1mDk7Xpvg1wYxBgkS45YIEfuZ3x2T137oz4g0lM/qg+ZoxPolplD6hDxR1Oj+/HhFtH1 zfCbrwqSWzg5EW3ACGHkI3mncfoUEFSZtdCGKdB3utsBg4Ie8S7CN9tJMPguTCWNGoQD9t/Uf fBAjVq8IllfXjyGsTWd9xcI+Q0g2LDnCasotVG8WZyjoeYEgdYoXgnIQ70w02tqizD8LQF+bd usSoUEgza2LpKLh/0nNOvPS//5sdzkuAQTP66MmuECxqXGoDHwPkyssZFOi7hk6/dGLgJWr2I UL0G0XfxtiBwMqNUE7dD1QmiioQA1Z9WoD/n1SlwndKrf7S5NcrUIIzZf7aMRg1K8bZ2cZCsm e95G3XbkFjt6rofJe6NJWNoSTpWe/6b8k+BHEW0CdxdLg3On5o8j4fNHCmhdfHluhlu4NX9MI vZ/sfrE2aGRRHpvTZgNC3mSdUAd5sqndKrjOjmAz3swH1qNylKa/Qz+n/LJk09IFzdUTkpQsn cG5ajuk5n6ug1BgzBCsZP8kdrJLZfOX2nakVDdGg/Aaidrb4r/y6Z4Bq4lQ0fLHXWYaXZZYkx MHABAwlzHUellpHLQ01WIeU1/0cUnfoyY+IrkIbsF+WKLaAxdSC/9tf0LU6H/Hq9MbgbL3kXa 39A9m2iPyTqEmKt4tD6/IOoTCCMzHwV1t0xJA1UU8zYml1HkBIvtxiZC95rl15iIgNGm4D3Cr Vkcyytusy/goGQakQDGd4hg2tja6ubM24WfVa74veIqpZyGH1zaZ2MonlXU9LbB5Axz3Oimky nDHHFY48PABCir/QJzsW8oHSwEJZtD0fDhMYtB4hmJ40cAv4CNbdZ23Z5ME5dTYQ0V+kokcx8 HZykGP6bl8CtlS1ax6DCQWY340tPPEB9hFH1pJIWq2dBWczyXUZ2oFZa6+9hP3n9j/5yEmCrU ihxLvxg9MdNKtIMNscQWvjyCLf97T03mq6cKzaHJyi0wIV+eOdpmaMcUXx X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76446 Cc: 76446 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Morgan Smith <Morgan.J.Smith@HIDDEN> writes: > Hello! Hi Morgan, > Nothing too exciting in this series. Just adjusting things so we can > split the tests into multiple files. Also adding a makefile target to > run the "checkdoc" stuff with the spell checker enabled. Thanks for this! I'm happy that you's started to provide also a debbugs-gnu-tests.el file. I didn't test the patches yet, starting with my comments on the code reading first. See next messages. > Thanks, > > Morgan Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 20 Feb 2025 19:06:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 20 14:06:30 2025
Received: from localhost ([127.0.0.1]:41073 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tlBsQ-0000NX-Mq
for submit <at> debbugs.gnu.org; Thu, 20 Feb 2025 14:06:30 -0500
Received: from lists.gnu.org ([2001:470:142::17]:37066)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <Morgan.J.Smith@HIDDEN>)
id 1tlBsM-0000M8-Gk
for submit <at> debbugs.gnu.org; Thu, 20 Feb 2025 14:06:24 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <Morgan.J.Smith@HIDDEN>)
id 1tlBsG-0002Cx-No
for bug-gnu-emacs@HIDDEN; Thu, 20 Feb 2025 14:06:16 -0500
Received: from mail-mw2nam12olkn2089.outbound.protection.outlook.com
([40.92.23.89] helo=NAM12-MW2-obe.outbound.protection.outlook.com)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <Morgan.J.Smith@HIDDEN>)
id 1tlBsD-0008V4-Vt
for bug-gnu-emacs@HIDDEN; Thu, 20 Feb 2025 14:06:16 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=hJNiKO/QjWQciX80UX/WwjxtSIYnrELiLOHU0GoQgG75PtEH3yETF7gDaYKUR13aJ7s/qzeeKju8QiLI3HN1+d0drbSZiI/ACP5pCtNnA9sX8f2rjllyFKAzQHmleE9+xdnnotW3BU8Op3JzvGYHBqBjsmgxxKSKMFofKbJRQbsipiTI2Htu6D+V859HAZnfMnimiCC0aSc5UqGahOtZ2WNmNGvgTTX+FLjs4q6uXO1pF23O+2NXBy7G2OhqTMa+f3LkYUBNiGHZPGEn2Ro+xyPEwDTXNw3dLMF5+Nn/vzZkptb2BbxI2VQyG7MwHU159T7JS3jeAUZUzJTONvRO3Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=EnU4czNbLnY+gCbp23Pgl+swggBPBXyAO6+Hn7xgPnA=;
b=X2rbdxDFqcZWJRI4j9t12HX90w0HVcIZ4++UQ+51fVK3AY1YOr4f/a8t1sJPjtBe96Me1GLWYK7fCajGR6YGNZa3CLL2jlnWGX6upOAjwMZgA4hbbY9cZr2//huGBbjtqOSQzn7PIZ5aJag6dLvKoX2do9QuvBX26Uqr9H/J0NDT0XrbKctMfAWkskDfhsWhaaJpPB73iSPocCoYQ6+j8zytI8N+NBKaaebr/7nEoIghaOuNqE+BFUQ2k9asyiMoKEMFR/dLbaCrvUUhwcA5Xod0rSShTbmtcrWExCB9o3LvQPlb70IDqjpS7042ksup52ar5FjeZPVyqaKEYGPd2g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=EnU4czNbLnY+gCbp23Pgl+swggBPBXyAO6+Hn7xgPnA=;
b=LhgAV7TxvnAc35rsGDB0eaVKpG28IFbPgSK08Z6iR//eIzbBhOhQBAnfBDBRJnF9rpQ4HUsjj60AjhQDT7+eHEgeoHbpUX+YPr1NaA2h/aknPh+YFaXoi20zm9loBrlBR6L2W1CvuoNEj+OCG3VT9KXMJBHTBWiWHnANdtJ8f3Wov3B+oRYZuVAf8xvwLj3vZyMxJIO3nNCrCLqKMlAZrkBBkx5KkbN+Pz4dtuFtOSS0UbBfn9sLu8A+QgJqudWtvChE1kgnSRLkhidxmsHKPLI6jdGjnv2qZTpJNFUGB8K1BCzcgbNN8Ow2oHb/LZuv7OlsxeTZ+5in+jCdSFf4zw==
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17)
by MW5PR84MB2298.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1c8::12)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.15; Thu, 20 Feb
2025 19:01:08 +0000
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef%4]) with mapi id 15.20.8466.015; Thu, 20 Feb 2025
19:01:08 +0000
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [Patch Debbugs] Infrastructure Improvements
X-Debbugs-Cc: Michael Albinus <michael.albinus@HIDDEN>
X-Hashcash: 1:20:250220:bug-gnu-emacs@HIDDEN::3sISYf09y7FKnZ7L:bns
Date: Thu, 20 Feb 2025 14:01:03 -0500
Message-ID: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Content-Type: multipart/mixed; boundary="=-=-="
X-ClientProxiedBy: YQBPR0101CA0286.CANPRD01.PROD.OUTLOOK.COM
(2603:10b6:c01:6d::15) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
(2603:10b6:610:1c4::17)
X-Microsoft-Original-Message-ID: <871pvsfnkg.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|MW5PR84MB2298:EE_
X-MS-Office365-Filtering-Correlation-Id: f783aa46-5faf-48c5-e382-08dd51e0eed3
X-Microsoft-Antispam: BCL:0;
ARA:14566002|461199028|15080799006|6092099012|7092599003|8060799006|5072599009|19110799003|440099028|3412199025|13095399003;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5PjCsTk/qT2FV4tbYrMydN30oq9Egqy5TgFeZv/dp2JuVbDYBXIvoBQn6bQW?=
=?us-ascii?Q?QysZ6ugHiwH5haePdAoFGruFGL8/YIMFYzXvNLO0tu+grE2vK5jD7GcWa4cW?=
=?us-ascii?Q?49F9wxJM3/2+VRsaxN/qauBOm+sqZTIdkTyA/OU2MeaDMs0k+ZiyByp4poqg?=
=?us-ascii?Q?IFsxRZ9b38w5rthqjBWO8OdQeljrSngyiCkiGfC2KXLe5DzpO5n9v4PBTqG8?=
=?us-ascii?Q?RM9cbFEg0ZpwO9BcWuOQOmqKJcBnD1XEyGB4JTo2SoJTInnLcMdaTE7UdBCL?=
=?us-ascii?Q?wO1yX9jdjIIqrjYdEL11WdawrjQr1hZTsRtqxE1JFlrSt5mZC2VPepd1c5/q?=
=?us-ascii?Q?PmGST+KbIS1rAymXDyEMJ/pBkBeBh5+FQ13gSF6VVyUQ/tz9fthv51/iIGIA?=
=?us-ascii?Q?ylPYgdp5bu34LuoD89qTGgCxiz7m1jt7KV+SjjctQWR7Nyuk62crYRjGAbhf?=
=?us-ascii?Q?C64iVGg7U5vk/sgy+JOjm1KbolSQ0gfplgOUvK6EiqJIkyYbsGn4uwhAhFlQ?=
=?us-ascii?Q?LS+2zr4DJvR46aWXIBiA8Vu+JmGScjyecz1YVuW7pCr9kLjzoKoKxBkZKMwB?=
=?us-ascii?Q?FwGTBmxkjYF1FgycoCNfuNQbpMklsUiNd9DMgTYWBU/eevelHGUvvijxUCAk?=
=?us-ascii?Q?88lLFkcNjVqy1ANt40RR/lTmRKeehnzngtnXdBWASO2VNp85D34YVT3xxVu4?=
=?us-ascii?Q?i9WaaeLVmj/XcReib15YVPBmcxa/WCXvRv9ejjeYydvO5ZUwxaRuqA2SY0YQ?=
=?us-ascii?Q?HhE1aPCFMMYwQV2O1SZOw299XwDDexSyxr1wpPO4SWSoc/RJWhx7XbPgxY4G?=
=?us-ascii?Q?J8nAEByB/SGx6kB6EHq/goT6/Y2HJinsiiauwEnUi2yOo8hbZ3Kds41o2lqG?=
=?us-ascii?Q?w3wA0s9kpEbiCQwycsTvSFJe2RyFsqq1ZxOqObNpiCm9u7gYQ8UNQUN7zXMO?=
=?us-ascii?Q?GCSGhJ1cMEHmrj2nrBvf58OTlbeDLCuPHeixwtiIl2cO1kSCDP8uGL03ghGs?=
=?us-ascii?Q?4noP+t4gQL18gvVFsu+CI+KKjgd+l/7MlkQ84ZdCiTbJd+/AK44cvBpAY6jb?=
=?us-ascii?Q?5NHQ47BdFHO9rXf6dcKzp0CvTAMYusts3VJG4Sn/+W6KU3/+e/oB74HF/zNw?=
=?us-ascii?Q?O4FKFBTtiY3IEt/m1cckEF0s5yFeQwFo2Q=3D=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?irUcrVFaBcOcxFBcyGFGxUL5EWRrLnAWfDAMWYlVGjP/EfvSWdR+LAcqwsac?=
=?us-ascii?Q?6rmIO76TXUxTkeasBv6ZcGsjf8Y328QUlWAYqk6UeTq442+uQ8WHECESmt3d?=
=?us-ascii?Q?NBOEtpLxxDUECuTC18qyr1p2H+ypuepfxUZRTwdi0muRFPk+bGPOyBTj1AHl?=
=?us-ascii?Q?6JQs7lOU8t47ijBxgzoZS4dqA3yoJmB1ztYnwMCyzIMWB8QDXfJpryZ4VbO8?=
=?us-ascii?Q?ZYksGNAjgdPz1ABS/aCT6TYHB/UH8TClBlxUgZLmzF58ha/NdUWwlxVdPhBm?=
=?us-ascii?Q?1YamHnY/mWISqXe2WtIsB1xCTz+aUnevsqZ1oBQJYZYSZKG3JSil10X5t29X?=
=?us-ascii?Q?WzAJLq+VIfEk3EwMfvjJLgnKepGPY5LimvAaRJ6COo07qAHjvNKxXFnY9UiG?=
=?us-ascii?Q?YH5ZzOL6hFpJfhIwQuDOFkFZdlrvARacjCrjc3KcLl7TBX5wO+rYPbJECyqH?=
=?us-ascii?Q?nuE65FreJnKh/QOuwmb6EW6aOtQ+KuY1ecusvMyBxmSXoEILo8EfF8UXSxkK?=
=?us-ascii?Q?bYKhiMHccL2FrCuUOFwsD1lpVjT8O/y0f+ChC5pzUzp9h3R31O9XGS3fCZmP?=
=?us-ascii?Q?G00tzKi7OTWku0Jhl2pjSmDrLyP+vvEJ2NFQ03qULQhMD1F6sSkh7a2aIJ/8?=
=?us-ascii?Q?M5jVPn5CtMsqWG2smX/PMNuJUvbLHWLcjrTIyEQQAvYU9j1XgB902qApvNL7?=
=?us-ascii?Q?e5mbjwEce023pwwaijS9Ul9Vtg20PQYJbKK/+6Ycbq8wsErGOnktr3zPWviz?=
=?us-ascii?Q?sW3x6S4IdcRLJNp5rcGEJWwKfpz7FJ9ru+muJev0jy79yf3+xy3m6Kd/KG1r?=
=?us-ascii?Q?4/m/As3NN9pkL8SKzJu0AJCsq45irsXnwVf0z9L7ai/gNPtv4lAWEtmGSEFY?=
=?us-ascii?Q?/e4TCFrEFnUqIIcojpIXOHy6ymwLT89SGkOxfgMrJFCRCv3wBl8JDBDkL/hI?=
=?us-ascii?Q?3qXZbLz4DStMcR0dkG/a2/VYdPNHcKy6dEp5N0+MMR3Au9GtJ6DpRMP4fQXR?=
=?us-ascii?Q?8+5jnsGnWcDewhSeZTQWJ79AETJUOpI89v+rY9qGKdXY8lQuOMibilgE814Q?=
=?us-ascii?Q?u+9HXsZGNAAitEyNZ2ctTfPZ+uYpnW6EQvZs1s8PjCnnQIUnMwivT0EGs6Wc?=
=?us-ascii?Q?wELF+5dkW2y/vpm30v39UzcS+pyG0qJjRmgNEl/LD1dnEcLCPLRGotpMoL+V?=
=?us-ascii?Q?eV6HSrnLFkhp9Z4j74MUBUbtO9FsE4MVBPmwK8H/63i8c88MyjxBMeQ0weR+?=
=?us-ascii?Q?PKisynUignAv554jmfEM?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f783aa46-5faf-48c5-e382-08dd51e0eed3
X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2025 19:01:08.3824 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR84MB2298
Received-SPF: pass client-ip=40.92.23.89;
envelope-from=Morgan.J.Smith@HIDDEN;
helo=NAM12-MW2-obe.outbound.protection.outlook.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
--=-=-=
Content-Type: text/plain
Hello!
Nothing too exciting in this series. Just adjusting things so we can
split the tests into multiple files. Also adding a makefile target to
run the "checkdoc" stuff with the spell checker enabled.
Thanks,
Morgan
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-tests-Move-helper-and-wrapper-functions-into-their-o.patch
From 9c73769d4255c072655ff307939098a5dc058f86 Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 14 Feb 2025 16:23:34 -0500
Subject: [PATCH 1/3] tests: Move helper and wrapper functions into their own
file
* test/debbugs-test-helpers.el: New file.
* test/debbugs-tests.el: Move test helper and wrapper functions into the new
file and require it.
* Makefile(check): Load all files in the test directory.
---
Makefile | 2 +-
test/debbugs-test-helpers.el | 146 +++++++++++++++++++++++++++++++++++
test/debbugs-tests.el | 113 +--------------------------
3 files changed, 148 insertions(+), 113 deletions(-)
create mode 100644 test/debbugs-test-helpers.el
diff --git a/Makefile b/Makefile
index a7b6b0c7f3..1ab85d2b64 100644
--- a/Makefile
+++ b/Makefile
@@ -24,7 +24,7 @@ doc: $(INFOMANUALS)
build: $(TARGET)
check: build $(TESTTARGET)
- @$(EMACS) -Q --batch -L . -l $(TESTSOURCE) -f ert-run-tests-batch-and-exit
+ @$(EMACS) -Q --batch -L . $(foreach file,$(TESTSOURCE), -l $(file)) -f ert-run-tests-batch-and-exit
clean:
-rm -f $(TARGET) $(TESTTARGET) $(INFOMANUALS)
diff --git a/test/debbugs-test-helpers.el b/test/debbugs-test-helpers.el
new file mode 100644
index 0000000000..f98bab40ed
--- /dev/null
+++ b/test/debbugs-test-helpers.el
@@ -0,0 +1,146 @@
+;;; debbugs-test-helpers.el --- Helpers for testing debbugs -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2024-2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;; Please ensure tests don't actually make network calls.
+
+;;; Code:
+
+(require 'debbugs)
+
+;;; Helper Data:
+
+;; Generated using this:
+;; (soap-invoke debbugs-wsdl debbugs-port "get_status" [64064])
+(defconst debbugs-test--bug-status-soap-return
+ '(((item
+ (key . 64064)
+ (value
+ (package . "emacs") (found_date) (last_modified . 1689593050)
+ (affects) (date . 1686745022) (fixed_versions)
+ (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>")
+ (blocks) (archived . 1) (found) (unarchived) (tags . "patch")
+ (severity . "normal") (location . "archive") (owner) (fixed)
+ (blockedby) (pending . "done") (keywords . "patch") (id . 64064)
+ (found_versions) (mergedwith) (summary) (forwarded)
+ (log_modified . 1689593050)
+ (done . "Michael Albinus <michael.albinus@HIDDEN>")
+ (source . "unknown")
+ (msgid
+ . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
+ (bug_num . 64064) (subject . "[PATCH 0/4] debbugs improvements")
+ (fixed_date)))))
+ "Mock result from `soap-invoke' for bug 64064.")
+
+;; Generated using this:
+;; (debbugs-get-status 64064)
+(defconst debbugs-test--bug-status
+ '(((cache_time . 5000) (source . "unknown") (unarchived)
+ (keywords "patch") (blocks) (pending . "done") (severity . "normal")
+ (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive")
+ (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements")
+ (last_modified . 1689593050) (found) (tags "patch") (package "emacs")
+ (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t)
+ (blockedby) (affects) (mergedwith) (summary) (date . 1686745022)
+ (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded)
+ (msgid
+ . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
+ (owner) (found_versions) (fixed_date) (bug_num . 64064)))
+ "Mock result from `debbugs-get-status' for bug 64064.")
+
+;;; Helper Functions:
+
+(defvar debbugs-test--soap-operation-name nil)
+(defvar debbugs-test--soap-parameters nil)
+(defun debbugs-test--soap-invoke-internal
+ (callback _cbargs _wsdl _service operation-name &rest parameters)
+ "Over-ride for testing."
+ (setq debbugs-test--soap-operation-name operation-name)
+ (setq debbugs-test--soap-parameters parameters)
+ (let ((return
+ (cond ((string-equal operation-name "get_status")
+ debbugs-test--bug-status-soap-return)
+ ((string-equal operation-name "get_usertag")
+ '(((hi))))
+ (t '((0))))))
+ (if callback
+ (progn
+ (funcall callback return)
+ nil)
+ return)))
+
+(defun debbugs-test--override-float-time (func &rest rest)
+ "Override `float-time' for FUNC with args REST."
+ (cl-letf (((symbol-function #'float-time)
+ (lambda (&optional _specified-time) 5000)))
+ (apply func rest)))
+
+(defun debbugs-test--setup ()
+ "Mock network and time functions.
+These mock functions are needed to make the tests reproducible."
+ (setq debbugs-test--soap-operation-name nil)
+ (setq debbugs-test--soap-parameters nil)
+
+ (add-function
+ :override (symbol-function #'soap-invoke-internal)
+ #'debbugs-test--soap-invoke-internal)
+
+ (add-function
+ :around (symbol-function #'debbugs-get-cache)
+ #'debbugs-test--override-float-time)
+
+ (add-function
+ :around (symbol-function #'debbugs-put-cache)
+ #'debbugs-test--override-float-time))
+
+(defun debbugs-test--teardown ()
+ "Restore functions to as they where before."
+ (setq debbugs-test--soap-operation-name nil)
+ (setq debbugs-test--soap-parameters nil)
+
+ (remove-function
+ (symbol-function #'soap-invoke-internal)
+ #'debbugs-test--soap-invoke-internal)
+
+ (remove-function
+ (symbol-function #'debbugs-get-cache)
+ #'debbugs-test--override-float-time)
+
+ (remove-function
+ (symbol-function #'debbugs-put-cache)
+ #'debbugs-test--override-float-time))
+
+(defmacro ert-deftest--debbugs (name args docstring &rest body)
+ "The same as `ert-deftest' but runs setup and teardown functions."
+ (declare
+ (doc-string 3)
+ (indent 2))
+ `(ert-deftest ,name ,args ,docstring
+ (debbugs-test--setup)
+ ,@body
+ (debbugs-test--teardown)))
+
+
+(provide 'debbugs-test-helpers)
+
+;;; debbugs-test-helpers.el ends here
diff --git a/test/debbugs-tests.el b/test/debbugs-tests.el
index f3abea2837..eb2e8b1768 100644
--- a/test/debbugs-tests.el
+++ b/test/debbugs-tests.el
@@ -27,118 +27,7 @@
;;; Code:
(require 'debbugs)
-
-;;; Helper Data:
-
-;; Generated using this:
-;; (soap-invoke debbugs-wsdl debbugs-port "get_status" [64064])
-(defconst debbugs-test--bug-status-soap-return
- '(((item
- (key . 64064)
- (value
- (package . "emacs") (found_date) (last_modified . 1689593050)
- (affects) (date . 1686745022) (fixed_versions)
- (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>")
- (blocks) (archived . 1) (found) (unarchived) (tags . "patch")
- (severity . "normal") (location . "archive") (owner) (fixed)
- (blockedby) (pending . "done") (keywords . "patch") (id . 64064)
- (found_versions) (mergedwith) (summary) (forwarded)
- (log_modified . 1689593050)
- (done . "Michael Albinus <michael.albinus@HIDDEN>")
- (source . "unknown")
- (msgid
- . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
- (bug_num . 64064) (subject . "[PATCH 0/4] debbugs improvements")
- (fixed_date)))))
- "Mock result from `soap-invoke' for bug 64064.")
-
-;; Generated using this:
-;; (debbugs-get-status 64064)
-(defconst debbugs-test--bug-status
- '(((cache_time . 5000) (source . "unknown") (unarchived)
- (keywords "patch") (blocks) (pending . "done") (severity . "normal")
- (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive")
- (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements")
- (last_modified . 1689593050) (found) (tags "patch") (package "emacs")
- (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t)
- (blockedby) (affects) (mergedwith) (summary) (date . 1686745022)
- (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded)
- (msgid
- . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
- (owner) (found_versions) (fixed_date) (bug_num . 64064)))
- "Mock result from `debbugs-get-status' for bug 64064.")
-
-;;; Helper Functions:
-
-(defvar debbugs-test--soap-operation-name nil)
-(defvar debbugs-test--soap-parameters nil)
-(defun debbugs-test--soap-invoke-internal
- (callback _cbargs _wsdl _service operation-name &rest parameters)
- "Over-ride for testing."
- (setq debbugs-test--soap-operation-name operation-name)
- (setq debbugs-test--soap-parameters parameters)
- (let ((return
- (cond ((string-equal operation-name "get_status")
- debbugs-test--bug-status-soap-return)
- ((string-equal operation-name "get_usertag")
- '(((hi))))
- (t '((0))))))
- (if callback
- (progn
- (funcall callback return)
- nil)
- return)))
-
-(defun debbugs-test--override-float-time (func &rest rest)
- "Override `float-time' for FUNC with args REST."
- (cl-letf (((symbol-function #'float-time)
- (lambda (&optional _specified-time) 5000)))
- (apply func rest)))
-
-(defun debbugs-test--setup ()
- "Mock network and time functions.
-These mock functions are needed to make the tests reproducible."
- (setq debbugs-test--soap-operation-name nil)
- (setq debbugs-test--soap-parameters nil)
-
- (add-function
- :override (symbol-function #'soap-invoke-internal)
- #'debbugs-test--soap-invoke-internal)
-
- (add-function
- :around (symbol-function #'debbugs-get-cache)
- #'debbugs-test--override-float-time)
-
- (add-function
- :around (symbol-function #'debbugs-put-cache)
- #'debbugs-test--override-float-time))
-
-(defun debbugs-test--teardown ()
- "Restore functions to as they where before."
- (setq debbugs-test--soap-operation-name nil)
- (setq debbugs-test--soap-parameters nil)
-
- (remove-function
- (symbol-function #'soap-invoke-internal)
- #'debbugs-test--soap-invoke-internal)
-
- (remove-function
- (symbol-function #'debbugs-get-cache)
- #'debbugs-test--override-float-time)
-
- (remove-function
- (symbol-function #'debbugs-put-cache)
- #'debbugs-test--override-float-time))
-
-(defmacro ert-deftest--debbugs (name args docstring &rest body)
- "The same as `ert-deftest' but runs setup and teardown functions."
- (declare
- (doc-string 3)
- (indent 2))
- `(ert-deftest ,name ,args ,docstring
- (debbugs-test--setup)
- ,@body
- (debbugs-test--teardown)))
+(require 'debbugs-test-helpers "./test/debbugs-test-helpers")
;;; Tests:
--
2.48.1
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0002-tests-Add-tests-for-debbugs-gnu.patch
From b585fc479503e96a42d966f90fbb8d13f4e2d26e Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 14 Feb 2025 16:23:57 -0500
Subject: [PATCH 2/3] tests: Add tests for debbugs-gnu
* test/debbugs-gnu-tests.el: New file.
---
test/debbugs-gnu-tests.el | 60 +++++++++++++++++++++++++++++++++++++++
1 file changed, 60 insertions(+)
create mode 100644 test/debbugs-gnu-tests.el
diff --git a/test/debbugs-gnu-tests.el b/test/debbugs-gnu-tests.el
new file mode 100644
index 0000000000..7b038b7411
--- /dev/null
+++ b/test/debbugs-gnu-tests.el
@@ -0,0 +1,60 @@
+;;; debbugs-gnu-tests.el --- tests for debbugs-gnu.el -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;; Please ensure tests don't actually make network calls.
+
+;;; Code:
+
+(require 'debbugs)
+(require 'debbugs-gnu)
+(require 'debbugs-test-helpers "./test/debbugs-test-helpers")
+
+;;; Tests:
+
+(ert-deftest--debbugs debbugs-test-debbugs-gnu-search ()
+ "Test `debbugs-gnu-search'.
+Also test `debbugs-gnu-patches' and `debbugs-gnu-tagged' which are
+simple wrappers for `debbugs-gnu-search'."
+ (cl-letf (((symbol-function #'debbugs-gnu)
+ #'list))
+
+ (should (equal '(nil ("emacs") nil nil "patch")
+ (debbugs-gnu-patches)))
+ (should (equal debbugs-gnu-current-query nil))
+ (should (equal debbugs-gnu-current-filter nil))
+
+ (should (equal '(("tagged"))
+ (debbugs-gnu-tagged)))
+ (should (equal debbugs-gnu-current-query nil))
+ (should (equal debbugs-gnu-current-filter nil))
+
+ (should
+ (equal '(nil ("guix" "guix-patches") nil)
+ (debbugs-gnu-search "frogs" '((pending . "pending")) nil '("guix" "guix-patches") nil)))
+ (should (equal debbugs-gnu-current-query '((phrase . "frogs"))))
+ (should (equal debbugs-gnu-current-filter '((pending . "pending"))))))
+
+(provide 'debbugs-gnu-tests)
+
+;;; debbugs-gnu-tests.el ends here
--
2.48.1
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0003-Makefile-Add-target-to-run-checkdoc-on-all-files.patch
From 9d8234d59a854b2bfcec37d5ef99c3244ef351f6 Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Thu, 20 Feb 2025 12:55:42 -0500
Subject: [PATCH 3/3] Makefile: Add target to run checkdoc on all files
* Makefile: Add target to run checkdoc on all files.
* .dir-locals.el: Run ispell with checkdoc with some words added to the
dictionary.
---
.dir-locals.el | 18 ++++++++++++++++++
Makefile | 12 +++++++++++-
2 files changed, 29 insertions(+), 1 deletion(-)
create mode 100644 .dir-locals.el
diff --git a/.dir-locals.el b/.dir-locals.el
new file mode 100644
index 0000000000..fa8707345f
--- /dev/null
+++ b/.dir-locals.el
@@ -0,0 +1,18 @@
+;;; Directory Local Variables -*- no-byte-compile: t -*-
+;;; For more information see (info "(emacs) Directory Variables")
+
+((emacs-lisp-mode . ((checkdoc-package-keywords-flag . t)
+ (checkdoc-ispell-lisp-words
+ .
+ ("ChangeLog" "ChangeLogs" "UTF" "alist" "args"
+ "armstrong" "backend" "bcc" "bugreport" "cdate" "cedet"
+ "coreutils" "cygwin" "debbugs" "debian" "el" "emacs"
+ "etags" "freemail" "fsf" "guix" "gw" "henoch" "hu"
+ "hyperestraier" "keymap" "magit" "magnus" "maint"
+ "maintainer" "maintainer's" "mbox" "mboxes" "minibuffer"
+ "moreinfo" "multibyte" "notabug" "paren" "persistency"
+ "regexp" "rescan" "rgm" "rmail" "severities" "sexp"
+ "solaris" "src" "sublist" "submitter" "submitter's"
+ "subproduct" "subqueries" "subquery" "teardown"
+ "unarchived" "unibyte" "unreproducible" "url" "util"
+ "wishlist" "wontfix" "wsdl" "www" "xsd" "zltuz")))))
diff --git a/Makefile b/Makefile
index 1ab85d2b64..3b39b4f692 100644
--- a/Makefile
+++ b/Makefile
@@ -8,7 +8,7 @@ TESTTARGET=$(patsubst %.el,%.elc,$(TESTSOURCE))
INFOMANUALS=debbugs.info debbugs-ug.info
-.PHONY: all build check clean
+.PHONY: all build check clean checkdoc
.PRECIOUS: %.elc
%.elc: %.el
@@ -23,6 +23,16 @@ doc: $(INFOMANUALS)
build: $(TARGET)
+# We need to set `enable-local-variables' to load '.dir-locals.el' while in batch mode.
+# We load '.dir-locals.el' to set the ispell wordlist for checkdoc.
+# We don't set `checkdoc-spellcheck-documentation-flag' in '.dir-locals.el'
+# so that developers don't need to have ispell set up and because flymake
+# doesn't seem to respect the word list.
+checkdoc: $(SOURCE) $(TESTSOURCE)
+ @$(EMACS) -Q --batch "--eval=(setq enable-local-variables :all \
+ checkdoc-spellcheck-documentation-flag t)" \
+ -L . $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")")
+
check: build $(TESTTARGET)
@$(EMACS) -Q --batch -L . $(foreach file,$(TESTSOURCE), -l $(file)) -f ert-run-tests-batch-and-exit
--
2.48.1
--=-=-=--
Morgan Smith <Morgan.J.Smith@HIDDEN>:michael.albinus@HIDDEN, bug-gnu-emacs@HIDDEN.
Full text available.michael.albinus@HIDDEN, bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.