GNU logs - #76473, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#76473: 31.0.50; gnutls_pproc leak
Resent-From: Helmut Eller <eller.helmut@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 21 Feb 2025 15:18:03 +0000
Resent-Message-ID: <handler.76473.B.174015105425376 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 76473 <at> debbugs.gnu.org
From: Helmut Eller <eller.helmut@HIDDEN>
Date: Fri, 21 Feb 2025 16:16:42 +0100
Message-ID: <87o6yv72g5.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2a00:1450:4864:20::32f;
 envelope-from=eller.helmut@HIDDEN; helo=mail-wm1-x32f.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--=-=-=
Content-Type: text/plain

On the features/igc branch, it looks like the process->gnutls_pproc
field is never freed.

This patch would fix that:


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
 filename=0001-Don-t-forget-to-free-process-gnutls_pproc-if-we-HAVE.patch

From d13ef81273c45f60add3a7adbea8274a916f469a Mon Sep 17 00:00:00 2001
From: Helmut Eller <eller.helmut@HIDDEN>
Date: Fri, 21 Feb 2025 15:31:58 +0100
Subject: [PATCH] Don't forget to free process->gnutls_pproc if we HAVE_MPS.

* src/gnutls.c (emacs_gnutls_deinit): Free gnutls_pproc here.
* src/alloc.c (cleanup_vector): Not here.
---
 src/alloc.c  |  7 +------
 src/gnutls.c | 11 +++++++++++
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/src/alloc.c b/src/alloc.c
index 7e74fd53335..74e85a9962b 100644
--- a/src/alloc.c
+++ b/src/alloc.c
@@ -3450,12 +3450,6 @@ cleanup_vector (struct Lisp_Vector *vector)
 	hash_table_allocated_bytes -= bytes;
       }
       break;
-    case PVEC_PROCESS:
-      {
-	struct Lisp_Process *p = PSEUDOVEC_STRUCT (vector, Lisp_Process);
-	xfree (p->gnutls_pproc);
-      }
-      break;
     /* Keep the switch exhaustive.  */
     case PVEC_NORMAL_VECTOR:
     case PVEC_FREE:
@@ -3465,6 +3459,7 @@ cleanup_vector (struct Lisp_Vector *vector)
     case PVEC_WINDOW:
     case PVEC_BOOL_VECTOR:
     case PVEC_BUFFER:
+    case PVEC_PROCESS:
     case PVEC_TERMINAL:
     case PVEC_WINDOW_CONFIGURATION:
     case PVEC_OTHER:
diff --git a/src/gnutls.c b/src/gnutls.c
index 50c6bc67e33..7eaf01f6b6e 100644
--- a/src/gnutls.c
+++ b/src/gnutls.c
@@ -985,6 +985,17 @@ emacs_gnutls_deinit (Lisp_Object proc)
   if (XPROCESS (proc)->gnutls_certificates)
     gnutls_deinit_certificates (XPROCESS (proc));
 
+  struct Lisp_Process *p = XPROCESS (proc);
+  if (p->gnutls_pproc)
+    {
+#ifdef HAVE_MPS
+      igc_xfree (p->gnutls_pproc);
+#else
+      xfree (p->gnutls_pproc);
+#endif
+      p->gnutls_pproc = NULL;
+    }
+
   XPROCESS (proc)->gnutls_p = false;
   return Qt;
 }
-- 
2.39.5


--=-=-=
Content-Type: text/plain


Helmut



In GNU Emacs 31.0.50 (build 10, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.16.0) of 2025-02-21 built on caladan
Repository revision: d13ef81273c45f60add3a7adbea8274a916f469a
Repository branch: fix-gnutls-leak
Windowing system distributor 'The X.Org Foundation', version 11.0.12401004
System Description: Debian GNU/Linux 12 (bookworm)

Configured using:
 'configure --config-cache --enable-checking=all,igc_check_fwd,igc_debug
 --with-mps=debug --with-xpm=ifavailable --with-gif=ifavailable
 --with-native-compilation=no 'CFLAGS=-g -O0 --std=gnu99
 -I/scratch/emacs/mps-install/include -L/scratch/emacs/mps-install/lib''

Configured features:
CAIRO DBUS FREETYPE GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LIBSELINUX
LIBSYSTEMD LIBXML2 MODULES MPS NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND
SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM
XINERAMA XINPUT2 XRANDR GTK3 ZLIB


--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Helmut Eller <eller.helmut@HIDDEN>
Subject: bug#76473: Acknowledgement (31.0.50; gnutls_pproc leak)
Message-ID: <handler.76473.B.174015105425376.ack <at> debbugs.gnu.org>
References: <87o6yv72g5.fsf@HIDDEN>
X-Gnu-PR-Message: ack 76473
X-Gnu-PR-Package: emacs
Reply-To: 76473 <at> debbugs.gnu.org
Date: Fri, 21 Feb 2025 15:18:04 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 76473 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
76473: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76473
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 21 Feb 2025 16:48:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 21 11:48:59 2025
Received: from localhost ([127.0.0.1]:34036 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tlWCw-0003vD-Kd
	for submit <at> debbugs.gnu.org; Fri, 21 Feb 2025 11:48:58 -0500
Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]:56776)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tlWCt-0003ti-OB
 for control <at> debbugs.gnu.org; Fri, 21 Feb 2025 11:48:56 -0500
Received: by mail-ej1-x62a.google.com with SMTP id
 a640c23a62f3a-abbc38adeb1so406449166b.1
 for <control <at> debbugs.gnu.org>; Fri, 21 Feb 2025 08:48:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1740156529; x=1740761329; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=vHDgAkMN3mC8aEzq87asdQ8hSrkwjYUSt0KBWJLveQ4=;
 b=VlX/BYgVl6MNAnYe8ZMCEMHFHggaRf7mJQkYTraIYSl+b1xs6p/RCQmFtH4gIhc0vO
 qn8BIXJy6PLrOkvwc78U5yn3Tb9kT69WKfzeBvQ41plrLsLh/1hKBRRTao4/JdJmYYwG
 FxlRhdG5bjJd7WCa3SBcqdyOVRtky+EPuaBl8treDO1F6PVKKG1dz8Vlj/na3olxtj2V
 iivcbbIpGa3zH3nAz74TqgK0MhGP3NJ4gIQHvAvp/LkNFu0MrKVrU9bAA9wSiipYEmZ2
 jAdiLw+mXrZVah4gZKPr2v0xb2YbjCwBDTPEflmBHea1itDbw5FvGTFu6sQTDtzpvhYz
 C2Jw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1740156529; x=1740761329;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=vHDgAkMN3mC8aEzq87asdQ8hSrkwjYUSt0KBWJLveQ4=;
 b=B9VMMj4eMPWN7/qFMgff9TWFOc4MuFCL7rAEPiu1CtjwiLCDGvAlNbsN0k7txb5odO
 Xq1huSTDcWCb4I+GDbuEznEcRyqlr6ImQgmB1cEc8YZWRiKIrGfPitsojIDhJ/+1Sz8d
 qAksyU9rCajgyWwQfIeREzarUlf8sPkiIFIrZdfjiO5JGgl1ap/bEPgrzvm/cOsyZGZn
 Q8woby+jfczQvSAOU2nhACY+vdQaTULf4ApY3VLtgOCNuFZzT4ttwU/GRyop/PJhdiEp
 E6yfh3GENroSNYAX3BnaCc9WvXTZ3+8k6vcd5My/AuSuxA+JSNy5QeRNXv+byLX65kL4
 mv9A==
X-Gm-Message-State: AOJu0Yy+BXmb5ZB7P8Hg7n6aFoeSOThfORDozDsH41VjLUGLTsOes457
 hFuysHNmS5SuOYaZ8p9I3o9p5rVRIR0aoi46uBAAC2cwmBBiT9MjpCk5n3TEe6cpBSlukhPuqEW
 i9kpfSm4BzgmrxMx+QbQE7Dz9uXLdCCoPTIQ=
X-Gm-Gg: ASbGncsD3VhMwkL/9KFQLk+nqB0JTmCLXP/jnFL4CjJjSzqlLM6l8CAraEg77vL51xV
 TXxTnKpLXvbwoh9fiS4ULmODcQQqo3YByHqvLsx2ELu9Vp5dHjEQTLMUwNUBKYhbVCKD3jsXn3f
 iAWV1KbA0=
X-Google-Smtp-Source: AGHT+IHd6YVT3iR5j58XWgRmog/YkInO/W9rbos98JiRYZdHkiZP376tjq07foYWphhxrA9kQ7Rmtm1AQQDdJuOHx30=
X-Received: by 2002:a17:907:6d12:b0:ab2:c1da:b725 with SMTP id
 a640c23a62f3a-abc09aee607mr461101366b.30.1740156528601; Fri, 21 Feb 2025
 08:48:48 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Fri, 21 Feb 2025 08:48:48 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Fri, 21 Feb 2025 08:48:48 -0800
X-Gm-Features: AWEUYZknpyDxsvDTsQoaKy-d5agvuDZ9y9WTrg9xQElrzx7ZBb2HLkj1Q17Ohns
Message-ID: <CADwFkmm-0NBbVzD8XRQ7ouzCviZ1-A6ORsf5Xmy_=EY2hbi9Gw@HIDDEN>
Subject: 
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  tags 76473 + patch thanks 
 Content analysis details:   (2.0 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [2a00:1450:4864:20:0:0:0:62a listed in]
 [list.dnswl.org]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (stefankangas[at]gmail.com)
 0.0 UNPARSEABLE_RELAY      Informational: message has unparseable relay
 lines 2.0 BLANK_SUBJECT          Subject is present but empty
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)

tags 76473 + patch
thanks

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#76473: 31.0.50; gnutls_pproc leak
Resent-From: Pip Cet <pipcet@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 21 Feb 2025 18:03:02 +0000
Resent-Message-ID: <handler.76473.B76473.17401609706894 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Helmut Eller <eller.helmut@HIDDEN>
Cc: 76473 <at> debbugs.gnu.org
Date: Fri, 21 Feb 2025 18:02:34 +0000
From: Pip Cet <pipcet@HIDDEN>
Message-ID: <87msefrxb5.fsf@HIDDEN>
In-Reply-To: <87o6yv72g5.fsf@HIDDEN>
References: <87o6yv72g5.fsf@HIDDEN>
Feedback-ID: 112775352:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

"Helmut Eller" <eller.helmut@HIDDEN> writes:

> On the features/igc branch, it looks like the process->gnutls_pproc
> field is never freed.

AFAICT, on w32 (which is the only place where it's used), the
process->gnutls_pproc pointer will keep alive the process indefinitely,
so the entire process is never freed.  Right?

> This patch would fix that:

I believe it would!  Is anyone testing the w32/w64 + gnutls combination?

Pip

Last modified: Fri, 21 Feb 2025 18:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.