GNU logs - #76498, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#76498: (ert-deftest) has indentation of 13 by default
Resent-From: Konstantin Kharlamov <Hi-Angel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 23 Feb 2025 10:04:02 +0000
Resent-Message-ID: <handler.76498.B.17403050276708 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 76498 <at> debbugs.gnu.org
Message-ID: <e0f99635b3e744c156e9fb67eeb02abb941e5994.camel@HIDDEN>
From: Konstantin Kharlamov <Hi-Angel@HIDDEN>
Date: Sun, 23 Feb 2025 13:02:59 +0300
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.54.3 
MIME-Version: 1.0
Received-SPF: pass client-ip=2a02:6b8:c02:900:1:45:d181:d100;
 envelope-from=Hi-Angel@HIDDEN; helo=forward100b.mail.yandex.net
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

I'm writing tests for purescript-mode package, and I stumbled upon odd
behavior: `ert-deftest` is spuriously indented to either 2 (expected)
or 13 (unexpected).

After digging into it, I found that if you `emacs -Q some-file-with-
tests.el` and try to indent the second line after `ert-deftest`, you'll
get size of 13. But if you `(require 'ert)` and try again you'll get 2.

This is because, even though `ert-deftest` keyword is declared inside
`lisp-mode.el`, but *indentation size* for it resides instead in
`ert.el`, as part of "declare" statement of `ert-deftest` macro.

This is definitely not expected. First of all, there's no reason for
user to evaluate `(require 'ert)` while working with tests =E2=80=94 you
wouldn't want to experiment with tests in your working Emacs anyway.
Which means you get incorrect indentation and left wondering what's
happening. Second of all, `ert-deftest` as a keyword resides inside
`lisp-mode.el` anyway, so what's the point of having the indentation
set in a different place.

Could we move the indentation size to `lisp-mode.el`, please?

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Konstantin Kharlamov <Hi-Angel@HIDDEN>
Subject: bug#76498: Acknowledgement ((ert-deftest) has indentation of 13
 by default)
Message-ID: <handler.76498.B.17403050276708.ack <at> debbugs.gnu.org>
References: <e0f99635b3e744c156e9fb67eeb02abb941e5994.camel@HIDDEN>
X-Gnu-PR-Message: ack 76498
X-Gnu-PR-Package: emacs
Reply-To: 76498 <at> debbugs.gnu.org
Date: Sun, 23 Feb 2025 10:04:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 76498 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
76498: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76498
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 24 Feb 2025 21:50:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 24 16:50:51 2025
Received: from localhost ([127.0.0.1]:43134 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tmgLj-0002WE-2k
	for submit <at> debbugs.gnu.org; Mon, 24 Feb 2025 16:50:51 -0500
Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:55425)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tmgLg-0002Vw-Fu
 for control <at> debbugs.gnu.org; Mon, 24 Feb 2025 16:50:48 -0500
Received: by mail-ed1-x52b.google.com with SMTP id
 4fb4d7f45d1cf-5ded1395213so8270358a12.2
 for <control <at> debbugs.gnu.org>; Mon, 24 Feb 2025 13:50:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1740433842; x=1741038642; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=HpjBBBhm3U1MoF7v4FB1PtY/qbHJ65+zUdVgXJczvlM=;
 b=APZ/uWdtYZJo/ORp2fwZpHBZe1L3QERP/gLl/oDZ1z/CATZFUQFmqFhX/eO4qdHNM3
 l5uVtznpZzy1RIJhVzbCoqTeYXgAfXcpYEFuJfgTqPvAdqifn0Ik2y1/jmD8MWyh0/QV
 BdgZGcHAzge5JTZwyL72WuVD2n3jYa8LJ54/EFzYBeokLEHUlINzY3waF1aHVu2JD57G
 lsPth6SyZ8uuLVrzTE/dM27TOHkEeS47W06GTWzu3M6dGk9YG8w8t8BAhEnQMOfZOg9r
 98ZwkqF8/MFrodVhlujyf1nH5SikuTY7fiFlzhPYAb2wVThyiIkuPTMM5wSkQMN442zt
 slyA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1740433842; x=1741038642;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=HpjBBBhm3U1MoF7v4FB1PtY/qbHJ65+zUdVgXJczvlM=;
 b=iQAw6it6t+GhMkDlYMDakX4a8HAuX2xuX2cfXFsDFeYOKuoiJD/dk2AinOKBVhWb1t
 bgojnyze5KZCvQh3nmhT4drJy8wP7QCNuYJEyazu0QgPZP6YAYXlQFwfd3HtGp3iSv2l
 3gcl5NXl/6wo0LNDF29XRjH/pognd+Q9DU1nSPHPDbFBXiRaOeVeoyQlVzDjJ95F5Ami
 cwWvuSRmMszy/62K/Ubz9E26Q+cSjmdQDJGPBjmRNzbXScexzP+2SOcTdkRVms2oeXCg
 pS/EiG3KMfx4pl69bmHCHpgsP+CZCEjZ6eIbi30IHv8T65ss4Nmo07wRwNvzGE+A6qwP
 DekQ==
X-Gm-Message-State: AOJu0YwA/8z0VUTHFcFRbfn8duaiitR8CBJuDtXOP3ygWx/xYJwt0DQA
 3MeFAdKfo+trWUl+kQbyYSBAergeCH/rKHTWQe4qYFV2yDaOGXirte6Le/qDsEJ3SBcCLHRUFpY
 LDtnJZEMYPunYYN0eBM1AwLqG+jj/HqGvVGE=
X-Gm-Gg: ASbGncv/c6Fj7SBixaf5cAdOfyw0rP6mSZNCJyX2wzsUahSLjO/oJK+ztaXB/ohTGVy
 wyG0AAK2EoQILKPjWy31KJNLH+lgyIs8GhIM10C7C6NJ2QNbF3s5wHR5Isu/IG8oTV3Zw6ZYDLm
 sWb5IcoKJrXg==
X-Google-Smtp-Source: AGHT+IHhuk/yeyJykfwyDdGnqN2TSMeulzJR1JghmIYH29ewaYCJC0aD5PDP2V5DyG9yIca2kIUmUij4OE+iKydOPUY=
X-Received: by 2002:a05:6402:430d:b0:5e1:9725:bb3e with SMTP id
 4fb4d7f45d1cf-5e44ba3fdc4mr758095a12.28.1740433842147; Mon, 24 Feb 2025
 13:50:42 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Mon, 24 Feb 2025 21:50:40 +0000
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Mon, 24 Feb 2025 21:50:40 +0000
X-Gm-Features: AWEUYZkmyBZi2BIXzUlhMkSfeKufOMj_PQEYpA8oKsPoiyafEUOztL0wC31TYNI
Message-ID: <CADwFkmmdRUeMpxaYd=HvGB8KNx2Q+95tx8sLDDi7StciAUxA-w@HIDDEN>
Subject: control message for bug #76498
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 76498 minor
quit

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#76498: (ert-deftest) has indentation of 13 by default
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 02 Mar 2025 12:46:02 +0000
Resent-Message-ID: <handler.76498.B76498.174091954423008 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Konstantin Kharlamov <Hi-Angel@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 76498 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <e0f99635b3e744c156e9fb67eeb02abb941e5994.camel@HIDDEN>
References: <e0f99635b3e744c156e9fb67eeb02abb941e5994.camel@HIDDEN>
MIME-Version: 1.0
Date: Sun, 2 Mar 2025 04:45:32 -0800
Message-ID: <CADwFkmm_edvNs8_VWN_RaY=DEnCLDpOxfu26PUoWL7BabvG-jQ@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Konstantin Kharlamov <Hi-Angel@HIDDEN> writes:

> I'm writing tests for purescript-mode package, and I stumbled upon odd
> behavior: `ert-deftest` is spuriously indented to either 2 (expected)
> or 13 (unexpected).
>
> After digging into it, I found that if you `emacs -Q some-file-with-
> tests.el` and try to indent the second line after `ert-deftest`, you'll
> get size of 13. But if you `(require 'ert)` and try again you'll get 2.
>
> This is because, even though `ert-deftest` keyword is declared inside
> `lisp-mode.el`, but *indentation size* for it resides instead in
> `ert.el`, as part of "declare" statement of `ert-deftest` macro.
>
> This is definitely not expected. First of all, there's no reason for
> user to evaluate `(require 'ert)` while working with tests =E2=80=94 you
> wouldn't want to experiment with tests in your working Emacs anyway.
> Which means you get incorrect indentation and left wondering what's
> happening. Second of all, `ert-deftest` as a keyword resides inside
> `lisp-mode.el` anyway, so what's the point of having the indentation
> set in a different place.
>
> Could we move the indentation size to `lisp-mode.el`, please?

I think this is a more general problem that applies to basically any
macro.  Instead of fixing this locally just for that one macro, maybe we
should make autoload pick up on that automatically (for autoloaded
macros)?

Eli, Stefan, WDYT?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#76498: (ert-deftest) has indentation of 13 by default
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 02 Mar 2025 13:44:02 +0000
Resent-Message-ID: <handler.76498.B76498.174092303311531 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 76498
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: 76498 <at> debbugs.gnu.org, monnier@HIDDEN, Hi-Angel@HIDDEN
Received: via spool by 76498-submit <at> debbugs.gnu.org id=B76498.174092303311531
          (code B ref 76498); Sun, 02 Mar 2025 13:44:02 +0000
Received: (at 76498) by debbugs.gnu.org; 2 Mar 2025 13:43:53 +0000
Received: from localhost ([127.0.0.1]:56067 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tojbk-0002zv-Uv
	for submit <at> debbugs.gnu.org; Sun, 02 Mar 2025 08:43:53 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:57192)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tojbi-0002zR-59
 for 76498 <at> debbugs.gnu.org; Sun, 02 Mar 2025 08:43:51 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tojbc-0006bk-CR; Sun, 02 Mar 2025 08:43:44 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=LDQvG8Twj9hrqjGftJY38rxZCwvZcxs/XOWt/LUmLhc=; b=sgsA1vxEdVC8/BLvl5oB
 CkSuTs1wE+poxdmnUNPe+H/fZTi2NHoepLrQBy6emqKI8asG2iQkpmhIgv7nxKaVRP+xzwdmtZFZ3
 KserVFdJYAl1XFOLSc7T/5FfcHZmYEFwPnoqDHdvh995Epv2K3f27JrtE7i11I21gTCKLJ7N7oler
 RzfJ7et7A73ryD2dQRm2CdIlSUN2gNY4TqzeXTdhK/eqJEdEaVzn9zLB5HCUURWjDk2fmT0ty+h/w
 jpHBVZFGj7fJ/8F312NKFQVEaPhWVcX4AODxjF+Uav5Mmx3yFAx6Yl0sCv1ET2olG+94eaIHSO/ja
 WpQGkchnoMNcww==;
Date: Sun, 02 Mar 2025 15:43:42 +0200
Message-Id: <864j0bo8dt.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CADwFkmm_edvNs8_VWN_RaY=DEnCLDpOxfu26PUoWL7BabvG-jQ@HIDDEN>
 (message from Stefan Kangas on Sun, 2 Mar 2025 04:45:32 -0800)
References: <e0f99635b3e744c156e9fb67eeb02abb941e5994.camel@HIDDEN>
 <CADwFkmm_edvNs8_VWN_RaY=DEnCLDpOxfu26PUoWL7BabvG-jQ@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Kangas <stefankangas@HIDDEN>
> Date: Sun, 2 Mar 2025 04:45:32 -0800
> Cc: 76498 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, 
> 	Stefan Monnier <monnier@HIDDEN>
> 
> Konstantin Kharlamov <Hi-Angel@HIDDEN> writes:
> 
> > I'm writing tests for purescript-mode package, and I stumbled upon odd
> > behavior: `ert-deftest` is spuriously indented to either 2 (expected)
> > or 13 (unexpected).
> >
> > After digging into it, I found that if you `emacs -Q some-file-with-
> > tests.el` and try to indent the second line after `ert-deftest`, you'll
> > get size of 13. But if you `(require 'ert)` and try again you'll get 2.
> >
> > This is because, even though `ert-deftest` keyword is declared inside
> > `lisp-mode.el`, but *indentation size* for it resides instead in
> > `ert.el`, as part of "declare" statement of `ert-deftest` macro.
> >
> > This is definitely not expected. First of all, there's no reason for
> > user to evaluate `(require 'ert)` while working with tests — you
> > wouldn't want to experiment with tests in your working Emacs anyway.
> > Which means you get incorrect indentation and left wondering what's
> > happening. Second of all, `ert-deftest` as a keyword resides inside
> > `lisp-mode.el` anyway, so what's the point of having the indentation
> > set in a different place.
> >
> > Could we move the indentation size to `lisp-mode.el`, please?
> 
> I think this is a more general problem that applies to basically any
> macro.  Instead of fixing this locally just for that one macro, maybe we
> should make autoload pick up on that automatically (for autoloaded
> macros)?
> 
> Eli, Stefan, WDYT?

I have no opinion on this (and don't understand the OP's use case in
the first place: does he want Emacs to know about ERT-sepcific macros
without loading ert??), sorry.

Last modified: Sun, 2 Mar 2025 13:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.