GNU logs - #76572, boring messages

Message sent to liliana.prikler@HIDDEN, maxim.cournoyer@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#76572] [PATCH 0/4] Fixes for gnome-shell-extension-gsconnect
Resent-From: aurtzy <aurtzy@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: liliana.prikler@HIDDEN, maxim.cournoyer@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN
Resent-Date: Tue, 25 Feb 2025 23:27:01 +0000
Resent-Message-ID: <handler.76572.B.17405260043826 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 76572 <at> debbugs.gnu.org
Cc: aurtzy <aurtzy@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Vivien Kraus <vivien@HIDDEN>
From: aurtzy <aurtzy@HIDDEN>
Date: Tue, 25 Feb 2025 18:21:48 -0500
Message-ID: <cover.1740522373.git.aurtzy@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::f33;
 envelope-from=aurtzy@HIDDEN; helo=mail-qv1-xf33.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Hello!

This patch series addresses issues with GSConnect generally not working.

I've been mainly testing this on the gnome-team branch (no relation to
the issues, which have been present in master), but I can confirm that
these patches don't break the main branch (guix pull still works), and
gnome-shell-extension-gsconnect still builds there.

Cheers,

aurtzy

aurtzy (4):
  gnu: gnome-shell-extension-gsconnect: Fix search path patching.
  gnu: gnome-shell-extension-gsconnect: Wrap gsconnect-preferences.
  gnu: gnome-shell-extension-gsconnect: Patch shebangs with gjs.
  gnu: gnome-shell-extension-gsconnect: Fix paths in additional desktop
    file.

 gnu/packages/gnome-xyz.scm | 45 ++++++++++++++++++++++++++++----------
 1 file changed, 34 insertions(+), 11 deletions(-)


base-commit: 8bc831325a905dbd9015739b58e3a5138d2217da
-- 
2.48.1

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: aurtzy <aurtzy@HIDDEN>
Subject: bug#76572: Acknowledgement ([PATCH 0/4] Fixes for gnome-shell-extension-gsconnect)
Message-ID: <handler.76572.B.17405260043826.ack <at> debbugs.gnu.org>
References: <cover.1740522373.git.aurtzy@HIDDEN>
X-Gnu-PR-Message: ack 76572
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 76572 <at> debbugs.gnu.org
Date: Tue, 25 Feb 2025 23:27:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Liliana Marie Prikler <liliana.prikler@HIDDEN>, Maxim Cournoyer <maxim=
.cournoyer@HIDDEN>, Vivien Kraus <vivien@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 76572 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
76572: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76572
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to aurtzy@HIDDEN, liliana.prikler@HIDDEN, maxim.cournoyer@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#76572] [PATCH 1/4] gnu: gnome-shell-extension-gsconnect: Fix search path patching.
Resent-From: aurtzy <aurtzy@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: aurtzy@HIDDEN, liliana.prikler@HIDDEN, maxim.cournoyer@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN
Resent-Date: Tue, 25 Feb 2025 23:36:01 +0000
Resent-Message-ID: <handler.76572.B76572.174052651717341 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 76572 <at> debbugs.gnu.org
Cc: aurtzy <aurtzy@HIDDEN>, aurtzy <aurtzy@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Vivien Kraus <vivien@HIDDEN>
From: aurtzy <aurtzy@HIDDEN>
Date: Tue, 25 Feb 2025 18:34:21 -0500
Message-ID: <89f5b7271c9568ffd58a61748a010510b3e9ee58.1740522373.git.aurtzy@HIDDEN>
In-Reply-To: <cover.1740522373.git.aurtzy@HIDDEN>
References: <cover.1740522373.git.aurtzy@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

* gnu/packages/gnome-xyz.scm (gnome-shell-extension-gsconnect):
[arguments]<#:phases>: Fix 'fix-paths phase substitutions no longer applying.

Change-Id: I99aa0204c1dfad836aed62261d2ffc0c75366510
---
 gnu/packages/gnome-xyz.scm | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index f975926e94..8c1c000feb 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2022 Sughosha <sughosha@HIDDEN>
 ;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
 ;;; Copyright © 2023 Eidvilas Markevičius <markeviciuseidvilas@HIDDEN>
+;;; Copyright © 2025 aurtzy <aurtzy@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -772,12 +773,15 @@ (define-public gnome-shell-extension-gsconnect
                   (("gapplication") gapplication))
                 (for-each
                  (lambda (file)
-                   (substitute* file
-                     (("'use strict';")
-                      (string-append "'use strict';\n\n"
-                                     "'" gi-typelib-path "'.split(':').forEach("
-                                     "path => imports.gi.GIRepository.Repository."
-                                     "prepend_search_path(path));"))))
+                   (with-atomic-file-replacement
+                    file
+                    (lambda (input output)
+                      (format output "~a"
+                              (string-append
+                               "'" gi-typelib-path "'.split(':').forEach("
+                               "path => imports.gi.GIRepository.Repository."
+                               "prepend_search_path(path));\n"))
+                      (dump-port input output))))
                  '("src/extension.js" "src/prefs.js")))))
           (add-after 'install 'wrap-daemons
             (lambda _
-- 
2.48.1

Message sent to aurtzy@HIDDEN, liliana.prikler@HIDDEN, maxim.cournoyer@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#76572] [PATCH 2/4] gnu: gnome-shell-extension-gsconnect: Wrap gsconnect-preferences.
Resent-From: aurtzy <aurtzy@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: aurtzy@HIDDEN, liliana.prikler@HIDDEN, maxim.cournoyer@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN
Resent-Date: Tue, 25 Feb 2025 23:36:02 +0000
Resent-Message-ID: <handler.76572.B76572.174052652317364 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 76572 <at> debbugs.gnu.org
Cc: aurtzy <aurtzy@HIDDEN>, aurtzy <aurtzy@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Vivien Kraus <vivien@HIDDEN>
From: aurtzy <aurtzy@HIDDEN>
Date: Tue, 25 Feb 2025 18:34:22 -0500
Message-ID: <88100c77035f4d0a2e7749b4a7902525e8f63c77.1740522373.git.aurtzy@HIDDEN>
In-Reply-To: <cover.1740522373.git.aurtzy@HIDDEN>
References: <cover.1740522373.git.aurtzy@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

This fixes an error when attempting to open the gsconnect-preferences
application due to Typelib files not being found.

* gnu/packages/gnome-xyz.scm (gnome-shell-extension-gsconnect):
[arguments]<#:phases>: Wrap gsconnect-preferences with GI_TYPELIB_PATH
environment variable.  Rename 'wrap-daemons phase to 'wrap-programs.

Change-Id: Ib330766d46dba00a7c68fa3956b28223f07000f8
---
 gnu/packages/gnome-xyz.scm | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 8c1c000feb..0a785193c4 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -783,13 +783,16 @@ (define-public gnome-shell-extension-gsconnect
                                "prepend_search_path(path));\n"))
                       (dump-port input output))))
                  '("src/extension.js" "src/prefs.js")))))
-          (add-after 'install 'wrap-daemons
+          (add-after 'install 'wrap-programs
             (lambda _
               (let* ((out #$output)
-                     (service-dir
-                      (string-append out "/share/gnome-shell/extensions"
-                                     "/gsconnect@HIDDEN/service"))
+                     (gsconnect-dir (string-append
+                                     out "/share/gnome-shell/extensions"
+                                     "/gsconnect@HIDDEN"))
+                     (service-dir (string-append gsconnect-dir "/service"))
                      (gi-typelib-path (getenv "GI_TYPELIB_PATH")))
+                (wrap-program (string-append gsconnect-dir "/gsconnect-preferences")
+                  `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))
                 (wrap-program (string-append service-dir "/daemon.js")
                   `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))))))
     (inputs
-- 
2.48.1

Message sent to aurtzy@HIDDEN, liliana.prikler@HIDDEN, maxim.cournoyer@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#76572] [PATCH 3/4] gnu: gnome-shell-extension-gsconnect: Patch shebangs with gjs.
Resent-From: aurtzy <aurtzy@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: aurtzy@HIDDEN, liliana.prikler@HIDDEN, maxim.cournoyer@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN
Resent-Date: Tue, 25 Feb 2025 23:36:02 +0000
Resent-Message-ID: <handler.76572.B76572.174052652317373 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 76572
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 76572 <at> debbugs.gnu.org
Cc: aurtzy <aurtzy@HIDDEN>, aurtzy <aurtzy@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Vivien Kraus <vivien@HIDDEN>
X-Debbugs-Original-Xcc: aurtzy <aurtzy@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Vivien Kraus <vivien@HIDDEN>
Received: via spool by 76572-submit <at> debbugs.gnu.org id=B76572.174052652317373
          (code B ref 76572); Tue, 25 Feb 2025 23:36:02 +0000
Received: (at 76572) by debbugs.gnu.org; 25 Feb 2025 23:35:23 +0000
Received: from localhost ([127.0.0.1]:49074 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tn4SR-0004W3-Ce
	for submit <at> debbugs.gnu.org; Tue, 25 Feb 2025 18:35:23 -0500
Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]:60614)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <aurtzy@HIDDEN>) id 1tn4SL-0004VK-6z
 for 76572 <at> debbugs.gnu.org; Tue, 25 Feb 2025 18:35:17 -0500
Received: by mail-qk1-x72f.google.com with SMTP id
 af79cd13be357-7c0b0ca6742so661457485a.0
 for <76572 <at> debbugs.gnu.org>; Tue, 25 Feb 2025 15:35:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1740526511; x=1741131311; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=bugHtWulAYpuG1+h9bWK6hXEwxlgocak3dRwfrUapYc=;
 b=U1IJMIYwh4N1zx0xotIAtbu0m89dzzzgG7PfaRSTdHCeDjmCsO7AZ5KRjkfIm6an5y
 ss+M0KqwB6S3tnE0QGb1V+hpGB3scD+c+/Y9CctaD6T1WeSV8wFRlctJgDHgXxLtqxRT
 buuOP95OedDH8UFuM6UXKKmNiAlW3cphiCbLHQzKNE4LRORHjNaNUFklJBKS5rXx0nM3
 S4sidykpxULljHawy44A8ORGZqX4FIXcjaMoCHgGHuphPvRWtzZB/7Sywz+P4AkAdNNw
 adCEenKhIzGr9HsMeXMFqRvYFtXxLKPUqeLjxjxCHm2vhduP1nFP2qUh2kdJE19Rf01M
 wQzA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1740526511; x=1741131311;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=bugHtWulAYpuG1+h9bWK6hXEwxlgocak3dRwfrUapYc=;
 b=o0C01r5DQW8fqSdLVZMwBTPVdaQt7jkC0qsGicwkq8kRalM1sQXZqyBj4k4Qo+pr8M
 tY8TNPUtLHz0ZF7qPCCTVYzYDHv9Nh2df/hrFD9mNsRrbee3UzmJLBcQQhJ0FYRA1UjV
 lcZQYc1961HInfnU/HkLGfsVaNQtBp1wcc2FKWX0EHh/ml29icXYlG5ozCs9MvN5d9fs
 bfSPZgoG94T6lwM/u+Gi7D7caGMup5UTU7WX95dv1Od6XuDDAi37I5Bch5a22VHkoPic
 kaIiqKqgR7RQbuz9l8IfWb/SKKJeBQHYmF64+4mxtPiCnRX0amGdxAf7tsxmPtNSGMtl
 a3JQ==
X-Gm-Message-State: AOJu0YwO38S6U/zlfsLE2t/mvh9jlrljutvtXkayz6Kn2Rz/LyNCJ65w
 IPx6i9/qpI7dQTdciHvrNdzHRMBDF8a6G0UZ47wGiLWhkNOODLuAydmFuA==
X-Gm-Gg: ASbGncsOtws83sF45JgF/wCoQQtE+MGj6FlbkENpFKLv03tC17tZZNEscFB8rGEWkkf
 VFlBOzp2e7DoeC5mftQ/w6W/9tzGRfX9Clmk+vps71CSUGo28XjDyEZf0ZwB1zCsVbIRFFV9WEk
 PwM43ywX/mhC4GzM+BoEHFOe8Jo8g+G7DjzQKAn0SuLRskrGoN3n8pcerGuWWwns1rsN4lPXTzQ
 QLy6VZnM0rg8iQ0hGv8bXp/FTR2vx+MU/1ICLW24jfG+rpkIOCXiBevrHN6sGb8kfko95tJxvNB
 OjzM6om/4MGlQYWb6fX4
X-Google-Smtp-Source: AGHT+IExvWxCi+Gqjjt+3G8gDWEMup3/4kcQ7j5vwDRS4gNzivh55l+IUohQH8VsuM96lLvh8MS6ag==
X-Received: by 2002:a05:620a:3190:b0:7c0:a1ca:93b6 with SMTP id
 af79cd13be357-7c247fe196bmr199108185a.50.1740526511244; 
 Tue, 25 Feb 2025 15:35:11 -0800 (PST)
Received: from localhost.localdomain ([2600:4808:a053:1800::4448])
 by smtp.gmail.com with ESMTPSA id
 af79cd13be357-7c23c327238sm166538485a.67.2025.02.25.15.35.10
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 25 Feb 2025 15:35:10 -0800 (PST)
From: aurtzy <aurtzy@HIDDEN>
Date: Tue, 25 Feb 2025 18:34:23 -0500
Message-ID: <1dfdb01b26950651265cb6281eb5766a0f111091.1740522373.git.aurtzy@HIDDEN>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <cover.1740522373.git.aurtzy@HIDDEN>
References: <cover.1740522373.git.aurtzy@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

The 'patch-shebangs phase does not handle shebangs of the form
"/usr/bin/env -S", so we manually patch them to fix a not-found error.

* gnu/packages/gnome-xyz.scm (gnome-shell-extension-gsconnect):
[arguments]<#:phases>: Add 'patch-gjs-shebangs phase to patch shebangs using
"/usr/bin/env -S" to execute gjs.

Change-Id: I6b84474e4976484f1203b7cf78fe5e882694cd22
---
 gnu/packages/gnome-xyz.scm | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 0a785193c4..abcbe2c9f9 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -765,6 +765,18 @@ (define-public gnome-shell-extension-gsconnect
                  "gtk_update_icon_cache: false")
                 (("update_desktop_database: true")
                  "update_desktop_database: false"))))
+          (add-after 'unpack 'patch-gjs-shebangs
+            (lambda* (#:key inputs #:allow-other-keys)
+              (for-each
+               (lambda (file)
+                 (substitute* file
+                   (("^#!.*$")
+                    (string-append "#!" (which "gjs") " -m"))))
+               '("installed-tests/minijasmine"
+                 "src/gsconnect-preferences"
+                 "src/service/nativeMessagingHost.js"
+                 "src/service/daemon.js"
+                 "webextension/gettext.js"))))
           (add-before 'configure 'fix-paths
             (lambda* (#:key inputs #:allow-other-keys)
               (let ((gapplication (search-input-file inputs "/bin/gapplication"))
-- 
2.48.1

Message sent to aurtzy@HIDDEN, liliana.prikler@HIDDEN, maxim.cournoyer@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#76572] [PATCH 4/4] gnu: gnome-shell-extension-gsconnect: Fix paths in additional desktop file.
Resent-From: aurtzy <aurtzy@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: aurtzy@HIDDEN, liliana.prikler@HIDDEN, maxim.cournoyer@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN
Resent-Date: Tue, 25 Feb 2025 23:36:03 +0000
Resent-Message-ID: <handler.76572.B76572.174052653717410 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 76572
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 76572 <at> debbugs.gnu.org
Cc: aurtzy <aurtzy@HIDDEN>, aurtzy <aurtzy@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Vivien Kraus <vivien@HIDDEN>
X-Debbugs-Original-Xcc: aurtzy <aurtzy@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Vivien Kraus <vivien@HIDDEN>
Received: via spool by 76572-submit <at> debbugs.gnu.org id=B76572.174052653717410
          (code B ref 76572); Tue, 25 Feb 2025 23:36:03 +0000
Received: (at 76572) by debbugs.gnu.org; 25 Feb 2025 23:35:37 +0000
Received: from localhost ([127.0.0.1]:49077 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tn4Sf-0004Wj-3Y
	for submit <at> debbugs.gnu.org; Tue, 25 Feb 2025 18:35:37 -0500
Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]:43505)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <aurtzy@HIDDEN>) id 1tn4SN-0004VN-M0
 for 76572 <at> debbugs.gnu.org; Tue, 25 Feb 2025 18:35:25 -0500
Received: by mail-qk1-x735.google.com with SMTP id
 af79cd13be357-7c0a974d433so32018085a.1
 for <76572 <at> debbugs.gnu.org>; Tue, 25 Feb 2025 15:35:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1740526514; x=1741131314; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=Dck3Q0Mwzruj9tOm4OVDml44XINI0Fo+p5Dam9S25UA=;
 b=W5SnHHGDfNVCiXVBn6e6arqTGJlEEiFqKTPS6RM88vCGH8QbDKl+bDCXMCRogyUYEG
 RmpfYtVLBSaqVAudbgXa7ffzOsyg9kmZ1UjhhNKhNExeAQe3ij7u88KJUiqtuQk1XwR8
 xoY7RTRTQmKjWNyZLB1cTLoUzYM3zIizeZyYXWf3c8/Fl5wz4ieDVWI5jml7wcZylVu0
 qDfh3RGxFH0NJniKw4/oD7CM3THXG9rzTM49IslViHo0lDW5dspNWjyV496kR5MLpRlu
 tYxRt7FCpM/qKMmAbLONkFTL/Bk0zpq1EIHbNY/nq6WgNJqZWsqv5qbQg+OSIV4oBtN0
 imlQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1740526514; x=1741131314;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=Dck3Q0Mwzruj9tOm4OVDml44XINI0Fo+p5Dam9S25UA=;
 b=sO0RMZwCucgNtzg94I7UBey3jjxOJR6VjDs6U3g5Y1pxwNtUw3qTmkt1OZ8zXzqn/I
 E1gfjPM6NmTuoA34RCf4m4Kl+ptJTMVS7BFIPd9paPbeHIHEcnqIDQPV+sad+YPESBqh
 p7xFglfFZS60VHGD77c4QkfheEhND397iNM9Fo8LjZCwM1MimBJsJ+dtHPiv+gEMFxjC
 qhRxy5rDlZD/uEWRRyrUtVPZY98hi5qim55kF7SZ02sA5onCvALQDdfFTMwYZE/M+dRZ
 bu0Ca4a3vyZCaKpuHrkgk9k15TPc9m8qemJk7stlA5gBBw6VnjCAAy6SRbjutIyrzTam
 RLfw==
X-Gm-Message-State: AOJu0YxnhykBQO+Rq07P7C68pfY7f5Qp4a86gKtc3qMylgpOOIJHqfmr
 Ii2oRres2TzRoUoLJcttKvv3+7f/hq+KMsr6BaGxuCkxIz4Ze+cdSNpzaQ==
X-Gm-Gg: ASbGncsBFt44Y7sN1CfT9ALYqV/PIRffP2z3iob2jffr+itFuN6bDzTaFDZU34hzIP0
 ysQLitfPCj4PywEy1EltqENqrUAD2aFBVmod4Odm2N2oN+pMOHs4wU5JcenDHealiWqnVBGXaeD
 RNok6PzzUsQATQxYxFz/H/mHgz1OCoOLk4U3E6UwR/WCd420mHM3MvoQGnJm9FzReR38ZAAlIop
 PBVfV71JIQeV6GkCqkAg65OY/Blk6veuXKZDTwYrGlDiUTEnVqzZe7PPSf2bRnRlBD8D8jbXqnq
 IaCsYfxw5DYs8miepgN2
X-Google-Smtp-Source: AGHT+IHl6pGtiAXxhUtZvRre2yDGiQoxFZ1OUunL3mrvRBLiYJbePM9fD828xpNJu18s0tE2N3YAEA==
X-Received: by 2002:a05:620a:1aa5:b0:7c0:b220:3502 with SMTP id
 af79cd13be357-7c0cf0e2e9emr2638060285a.4.1740526513657; 
 Tue, 25 Feb 2025 15:35:13 -0800 (PST)
Received: from localhost.localdomain ([2600:4808:a053:1800::4448])
 by smtp.gmail.com with ESMTPSA id
 af79cd13be357-7c23c327238sm166538485a.67.2025.02.25.15.35.12
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 25 Feb 2025 15:35:12 -0800 (PST)
From: aurtzy <aurtzy@HIDDEN>
Date: Tue, 25 Feb 2025 18:34:24 -0500
Message-ID: <4656de9a71919aed426cf4658aba6ec699c9b18f.1740522373.git.aurtzy@HIDDEN>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <cover.1740522373.git.aurtzy@HIDDEN>
References: <cover.1740522373.git.aurtzy@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 2.8 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: This fixes the gsconnect preferences button ("Mobile
 Settings")
 in the top-right quick-access menu not opening the preferences application.
 The window icon also displays properly with this commit. *
 gnu/packages/gnome-xyz.scm
 (gnome-shell-extension-gsconnect): [arguments]<#:phases>: Patch gapplication
 path in an additional desktop file in 'fix-paths phase. 
 Content analysis details:   (2.8 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [2607:f8b0:4864:20:0:0:0:735 listed in]
 [list.dnswl.org]
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (aurtzy[at]gmail.com)
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 2.8 MANY_SUBDOM            Lots and lots of subdomain parts in a URI
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

This fixes the gsconnect preferences button ("Mobile Settings") in the
top-right quick-access menu not opening the preferences application.  The
window icon also displays properly with this commit.

* gnu/packages/gnome-xyz.scm (gnome-shell-extension-gsconnect):
[arguments]<#:phases>: Patch gapplication path in an additional desktop file
in 'fix-paths phase.

Change-Id: I6b84474e4976484f1203b7cf78fe5e882694cd22
---
 gnu/packages/gnome-xyz.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index abcbe2c9f9..d011ae51d0 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -781,8 +781,12 @@ (define-public gnome-shell-extension-gsconnect
             (lambda* (#:key inputs #:allow-other-keys)
               (let ((gapplication (search-input-file inputs "/bin/gapplication"))
                     (gi-typelib-path (getenv "GI_TYPELIB_PATH")))
-                (substitute* "data/org.gnome.Shell.Extensions.GSConnect.desktop.in"
-                  (("gapplication") gapplication))
+                (for-each
+                 (lambda (file)
+                   (substitute* file
+                     (("gapplication") gapplication)))
+                 '("data/org.gnome.Shell.Extensions.GSConnect.desktop.in"
+                   "data/org.gnome.Shell.Extensions.GSConnect.Preferences.desktop.in"))
                 (for-each
                  (lambda (file)
                    (with-atomic-file-replacement
-- 
2.48.1

Last modified: Tue, 25 Feb 2025 23:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.