GNU bug report logs - #76697
gdk-pixbuf GDK_PIXBUF_MODULE_FILES search path breaks some packages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76697 in the body.
You can then email your comments to 76697 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
To: bug-guix <at> gnu.org
Subject: gdk-pixbuf GDK_PIXBUF_MODULE_FILES search path breaks some packages
Date: Sun, 02 Mar 2025 19:57:47 -0500

I tried to reopen this bug instead of making a new one but I guess it's
archived or something? bug#75795

Changing the search-path-specification of gdk-pixbuf has broken the
build of transmission as this phase now errors out:

=========
(wrap-program (string-append #$output:gui "/bin/transmission-gtk")
  ;; Wrapping GDK_PIXBUF_MODULE_FILE allows Transmission to load
  ;; its own icons in pure environments.
  `("GDK_PIXBUF_MODULE_FILE" =
    (,(getenv "GDK_PIXBUF_MODULE_FILE"))))
=========

Doing a quick search it looks like there at least 10 packages that need
to be adjusted

Message #10 received at 76697-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Cc: Vivien Kraus <vivien <at> planete-kraus.eu>,
 宋文武 <iyzsong <at> member.fsf.org>, 76697-done <at> debbugs.gnu.org,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: bug#76697: gdk-pixbuf GDK_PIXBUF_MODULE_FILES search path
 breaks some packages
Date: Mon, 03 Mar 2025 12:59:16 +0800

Morgan Smith <Morgan.J.Smith <at> outlook.com> writes:

> I tried to reopen this bug instead of making a new one but I guess it's
> archived or something? bug#75795
>
> Changing the search-path-specification of gdk-pixbuf has broken the
> build of transmission as this phase now errors out:
>
> =========
> (wrap-program (string-append #$output:gui "/bin/transmission-gtk")
>   ;; Wrapping GDK_PIXBUF_MODULE_FILE allows Transmission to load
>   ;; its own icons in pure environments.
>   `("GDK_PIXBUF_MODULE_FILE" =
>     (,(getenv "GDK_PIXBUF_MODULE_FILE"))))
> =========
>
> Doing a quick search it looks like there at least 10 packages that need
> to be adjusted

Hello, I had pushed fixes for transmission and xournalpp.  Other using
glib-or-gtk or meson build system still works as GDK_PIXBUF_MODULE_FILE
was set in the generate-gdk-pixbuf-loaders-cache-file phase.

Wrap binaries with GUIX_GDK_PIXBUF_MODULE_FILES is not ideal currently,
since it would contain duplicated loaders from cache files.  After we
remove the generate-gdk-pixbuf-loaders-cache-file phase, we can wrap
with GUIX_GDK_PIXBUF_MODULE_FILES, which should mostly only contains
gdk-pixbuf and librsvg.

Thanks.

Message #13 received at 76697 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Cc: Vivien Kraus <vivien <at> planete-kraus.eu>,
 宋文武 <iyzsong <at> member.fsf.org>, 76697 <at> debbugs.gnu.org
Subject: Re: bug#76697: gdk-pixbuf GDK_PIXBUF_MODULE_FILES search path
 breaks some packages
Date: Tue, 04 Mar 2025 09:36:31 +0900

Hi Morgan,

Morgan Smith <Morgan.J.Smith <at> outlook.com> writes:

> I tried to reopen this bug instead of making a new one but I guess it's
> archived or something? bug#75795

Yes, after a while issues get archived and become comment-only.  There's
an 'unarchive' action for Debbugs along a 'reopen', which can be used
like so at the top of the email body, making sure to cc 'GNU Debbugs
<control <at> debbugs.gnu.org>' to act on it:

--8<---------------cut here---------------start------------->8---
unarchive 75697
reopen 75697
quit
--8<---------------cut here---------------end--------------->8---

> Changing the search-path-specification of gdk-pixbuf has broken the
> build of transmission as this phase now errors out:
>
> =========
> (wrap-program (string-append #$output:gui "/bin/transmission-gtk")
>   ;; Wrapping GDK_PIXBUF_MODULE_FILE allows Transmission to load
>   ;; its own icons in pure environments.
>   `("GDK_PIXBUF_MODULE_FILE" =
>     (,(getenv "GDK_PIXBUF_MODULE_FILE"))))
> =========
>
> Doing a quick search it looks like there at least 10 packages that need
> to be adjusted

Thanks for reporting that.  So could the adjustments needed simply be
made with just:

--8<---------------cut here---------------start------------->8---
git grep -l GDK_PIXBUF_MODULE_FILE |
  xargs sed 's/GDK_PIXBUF_MODULE_FILE/s/GDK_PIXBUF_MODULE_FILES/' -i
--8<---------------cut here---------------end--------------->8---

?

-- 
Maxim

Message #16 received at 76697-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 宋文武 <iyzsong <at> envs.net>
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>,
 宋文武 <iyzsong <at> member.fsf.org>, 76697-done <at> debbugs.gnu.org,
 Vivien Kraus <vivien <at> planete-kraus.eu>
Subject: Re: bug#76697: gdk-pixbuf GDK_PIXBUF_MODULE_FILES search path
 breaks some packages
Date: Tue, 04 Mar 2025 09:37:12 +0900

Hi,

宋文武 <iyzsong <at> envs.net> writes:

> Morgan Smith <Morgan.J.Smith <at> outlook.com> writes:
>
>> I tried to reopen this bug instead of making a new one but I guess it's
>> archived or something? bug#75795
>>
>> Changing the search-path-specification of gdk-pixbuf has broken the
>> build of transmission as this phase now errors out:
>>
>> =========
>> (wrap-program (string-append #$output:gui "/bin/transmission-gtk")
>>   ;; Wrapping GDK_PIXBUF_MODULE_FILE allows Transmission to load
>>   ;; its own icons in pure environments.
>>   `("GDK_PIXBUF_MODULE_FILE" =
>>     (,(getenv "GDK_PIXBUF_MODULE_FILE"))))
>> =========
>>
>> Doing a quick search it looks like there at least 10 packages that need
>> to be adjusted
>
> Hello, I had pushed fixes for transmission and xournalpp.  Other using
> glib-or-gtk or meson build system still works as GDK_PIXBUF_MODULE_FILE
> was set in the generate-gdk-pixbuf-loaders-cache-file phase.
>
> Wrap binaries with GUIX_GDK_PIXBUF_MODULE_FILES is not ideal currently,
> since it would contain duplicated loaders from cache files.  After we
> remove the generate-gdk-pixbuf-loaders-cache-file phase, we can wrap
> with GUIX_GDK_PIXBUF_MODULE_FILES, which should mostly only contains
> gdk-pixbuf and librsvg.

Thanks for the explanation and acting on the report!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.