GNU bug report logs - #76770
[PATCH] gnu: lua: compile with readline support

Previous Next

To reply to this bug, email your comments to 76770 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: kimapr <kimapr <at> mail.ru>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: lua: compile with readline support
Date: Wed, 5 Mar 2025 17:37:00 +0000

* gnu/packages/lua.scm (lua)[arguments]: change target to
  "linux-readline".
---
 gnu/packages/lua.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/lua.scm b/gnu/packages/lua.scm
index 4c65bcbf12..b3d4cbf5d2 100644
--- a/gnu/packages/lua.scm
+++ b/gnu/packages/lua.scm
@@ -109,7 +109,7 @@ (define-public lua
              (string-append "CC=" ,(cc-for-target))
              (string-append "SYSLIBS=-L" (assoc-ref %build-inputs
"readline")
                             "/lib")
-             "linux")
+             "linux-readline")
        #:phases
        (modify-phases %standard-phases
          (delete 'configure)
-- 
2.47.1

Message #8 received at 76770 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: kimapr <kimapr <at> mail.ru>, 76770 <at> debbugs.gnu.org
Subject: Re: [bug#76770] [PATCH] gnu: lua: compile with readline support
Date: Mon, 10 Mar 2025 15:46:48 -0700

[Message part 1 (text/plain, inline)]

On 2025-03-05, kimapr wrote:
> * gnu/packages/lua.scm (lua)[arguments]: change target to
>   "linux-readline".
> ---
>  gnu/packages/lua.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/lua.scm b/gnu/packages/lua.scm
> index 4c65bcbf12..b3d4cbf5d2 100644
> --- a/gnu/packages/lua.scm
> +++ b/gnu/packages/lua.scm
> @@ -109,7 +109,7 @@ (define-public lua
>               (string-append "CC=" ,(cc-for-target))
>               (string-append "SYSLIBS=-L" (assoc-ref %build-inputs
> "readline")
>                              "/lib")
> -             "linux")
> +             "linux-readline")
>         #:phases
>         (modify-phases %standard-phases
>           (delete 'configure)
> -- 
> 2.47.1

Patch was slightly malformed for some reason, but being a one-liner, was
easy to apply manually!

At first glance, it increases the results from guix size only slightly
from 77.0MB to 84.4MB, and has a smallish number of dependents...

But lua <at> 5.1 lua <at> 5.2 and lua <at> 5.3 inherit from lua, so the impact is much
larger than a quick glance suggests (especially lua <at> 5.3):

    $ guix refresh --list-dependent lua <at> 5.1 lua <at> 5.2 lua <at> 5.3 lua <at> 5.4
    Building the following 359 packages would ensure 604 dependent
    packages are rebuilt: grafx2 <at> 2.4 hedgewars <at> 1.0.2 btanks <at> 0.9.8083
    crawl-tiles <at> 0.32.1 fillets-ng <at> 1.0.1 ...

I did successfully build lua <at> 5.4 and it's four dependents.

https://guix.gnu.org/manual/devel/en/guix.html#Managing-Patches-and-Branches

  Changes which affect more than 300 dependent packages (see Invoking guix
  refresh) should first be pushed to a topic branch other than master

Would it make sense to exclude the older versions from the change? Then
it could go to the git master banch, in my opinion.


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 76770 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: kimapr <kimapr <at> mail.ru>, 76770 <at> debbugs.gnu.org
Subject: Re: [bug#76770] [PATCH] gnu: lua: compile with readline support
Date: Mon, 10 Mar 2025 16:34:44 -0700

[Message part 1 (text/plain, inline)]

On 2025-03-10, Vagrant Cascadian wrote:
> On 2025-03-05, kimapr wrote:
> At first glance, it increases the results from guix size only slightly
> from 77.0MB to 84.4MB, and has a smallish number of dependents...
>
> But lua <at> 5.1 lua <at> 5.2 and lua <at> 5.3 inherit from lua, so the impact is much
> larger than a quick glance suggests (especially lua <at> 5.3):

Oops, I had this slightly wrong... lua-5.1, lua-5.2 and lua-5.4 inherit
from lua (which is effectively lua <at> 5.3).

> Would it make sense to exclude the older versions from the change? Then
> it could go to the git master banch, in my opinion.

In fact versions 5.1, 5.2 and 5.3 do not support this option passed to
make at all, and fail to build with the patch applied!

I just checked that lua <at> 5.3, lua <at> 5.2 and lua <at> 5.1 all do support
readline, so it is only lua <at> 5.4 that does not currently have readline
support.

So the patch needs to be re-worked ot only apply to lua-5.4. But then
should be able to be pushed directly as it does not have many
dependents.


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.