Received: (at 76978) by debbugs.gnu.org; 19 Mar 2025 20:46:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 19 16:46:04 2025 Received: from localhost ([127.0.0.1]:53364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tv0Id-00031U-Td for submit <at> debbugs.gnu.org; Wed, 19 Mar 2025 16:46:04 -0400 Received: from mail-vk1-xa2b.google.com ([2607:f8b0:4864:20::a2b]:58509) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1tv0Ib-00030j-Rz for 76978 <at> debbugs.gnu.org; Wed, 19 Mar 2025 16:46:02 -0400 Received: by mail-vk1-xa2b.google.com with SMTP id 71dfb90a1353d-5240317b3e0so53523e0c.0 for <76978 <at> debbugs.gnu.org>; Wed, 19 Mar 2025 13:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742417156; x=1743021956; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NzkUGiiQtFV0kQTZe7xMrnrosT4VilHzVfGnJWvVgZs=; b=ObGrCwp2dsC0IaYskhmiE2rDosfONWDpBtj/4RdkMQd34gyhbaGcxqPUI2YzsCX3w8 ZX0Vhz7sKTtLTyp95oWbawwBPNZYW+T/TDad4ZAI4l0ePFz7SQh6IwDjDYjBBSvJDNYC Ye1O+5rL7uO2NVqQR7RtNbx3mNZWm6uZe7bfFAw4/jVC1KKMm33flACkfk3IUySkB36i vtk7TKvJW1IiH4fy8PdFoThh/P8Bj6C/0wyNbvsBRrh8X4jtsV72EqXZiiNvqDwwj9bO R3cH6VmrQoSKJ4x6abpzfe/xheIAdS4FkYkZO5r96qA2TbvnsT+4t5cy/r7Wn93+mCJW x7lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742417156; x=1743021956; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NzkUGiiQtFV0kQTZe7xMrnrosT4VilHzVfGnJWvVgZs=; b=ecg+2+CUUCbGIiBKEBmsHgK7ULPok6I4Rro+WYAF6jKS0NhcHwZrN5NbittoGHquan BCzl1e/GBm5NQj+qlwgsOhq48+g3kf8xs11gfNEkS5AjTNCHm/Otve+usxtr8uXON8E5 vnNSdu5asey/9Fx9gTus8dgPEE4x6j6NlCD0s1z8YmUIGzXcA8EPomZJDze8Py060fn1 iycGBGlp/HOTiqZEoT8Rrz4REFhooM/fI5auv3dmzU6sL//Ta6FZ4ntDwrC/A0Tj0pN1 LXodQp43QriZL96oHADlg7u6wiCKmymRbrt6BKwT51lIZxtCmHbr+xd4F0fecCKkYKIw RnKw== X-Forwarded-Encrypted: i=1; AJvYcCWwMlae8WxYtasZUt83a9bcpURkc64FSFuELSiNp1AVz2w/euOZzVVGmQShn9MXsOGucq0IWQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw7sgeOVZYbvvNlbCuS+kI6CQBcY0XQmRd9df4XpCcLHbbJ5mxW GExv3z6c39AkKeFALsJ71U5MC5OGqh6fnbL4YGcElbZyY/+FR8MtW8gJDttLj9QJR0SWx1OgP8u ZgyRkzUsV6JDflKQolli98ND004w= X-Gm-Gg: ASbGncv3YrA3ra57/eQ2bvx3mH4mKxwUT1JtHN3g3NvhZHMehyXsQA8Wdc8q4NkynyT n/FA+GRx1KcxeSQJiY7iJia3wO6tk5bYDT322wZKrLosBB1TkXvFHeyyO+eVD1g1qHushmHwj5a 0f1itMhVEnzcDx9N13+uP5M3Tr7F3G1qf9gW9zluCdWjqU2eILYVAomOtmO1mm X-Google-Smtp-Source: AGHT+IFv5ond0Wrbw+AQwJIwsURXlFjVBDPsSRRGUi06fKWvinV+WUWE4yX2DiHMOpEM0YD1mtW01sScH9Gze8GV3fc= X-Received: by 2002:a05:6122:d9d:b0:520:3536:feb5 with SMTP id 71dfb90a1353d-525963ddeb2mr824309e0c.11.1742417156255; Wed, 19 Mar 2025 13:45:56 -0700 (PDT) MIME-Version: 1.0 References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN> <87ecyxxqe6.fsf@HIDDEN> <87iko9qffi.fsf@HIDDEN> <87v7s9w1au.fsf@HIDDEN> <87wmcmdyt3.fsf@HIDDEN> <87a59i6lyo.fsf@HIDDEN> <jwvjz8masyr.fsf-monnier+emacs@HIDDEN> <87frj9gbp2.fsf@HIDDEN> <jwvr02tafzh.fsf-monnier+emacs@HIDDEN> <871putdymf.fsf@HIDDEN> <jwva59hvzuu.fsf-monnier+emacs@HIDDEN> <CAN+1Hbp=3X=M0sFk+rsqdn3St96KX=rH0oXqznFApv9bKcif6g@HIDDEN> <jwvldt093er.fsf-monnier+emacs@HIDDEN> <CAN+1HboT7Mut0L4bEFTJcWt420ndFZ-e1uu51SZCyR7aLs7xjQ@HIDDEN> In-Reply-To: <CAN+1HboT7Mut0L4bEFTJcWt420ndFZ-e1uu51SZCyR7aLs7xjQ@HIDDEN> From: Ship Mints <shipmints@HIDDEN> Date: Wed, 19 Mar 2025 16:45:44 -0400 X-Gm-Features: AQ5f1Jomg2KlEgqgg6JfV_M0GK1Eb14XS4XMo_mXwrBw_OFgLFlYEldGW52sjxE Message-ID: <CAN+1Hbp2GZbzmp9yOEWNeXwWoNsmUC2pfsStQX0st_YFjzudVw@HIDDEN> Subject: Re: bug#76978: [PATCH] package.el: Add built-in version check and loaded package marking To: Stefan Monnier <monnier@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000a638ed0630b81b4c" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76978 Cc: 76978 <at> debbugs.gnu.org, david <davidimagid@HIDDEN>, Philip Kaludercic <philipk@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000a638ed0630b81b4c Content-Type: text/plain; charset="UTF-8" No On Wed, Mar 19, 2025 at 16:36 Ship Mints <shipmints@HIDDEN> wrote: > > On Wed, Mar 19, 2025 at 16:26 Stefan Monnier <monnier@HIDDEN> > wrote: > >> > With the patch in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76568 >> > duplicates will be harder to install. >> >> They're still easy to have (e.g. install some packages system-wide and >> then let the users install other versions in their home dir), and that's >> a good thing: we want to support setups with several versions installed >> at the same time. Of course, users usually don't want that, so it's >> good to make sure it doesn't happen by accident. In any case, my >> question was simply to confirm that I understood correctly the >> information that's displayed. > > > Maybe I should change the patch to prompt for allowing a dupe install if > that's what someone wants? > Hmm. Maybe it already does. Not at my computer. > --000000000000a638ed0630b81b4c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto">No<br><div class=3D"gmail_quote gmail_quote_container"><d= iv dir=3D"ltr" class=3D"gmail_attr">On Wed, Mar 19, 2025 at 16:36 Ship Mint= s <<a href=3D"mailto:shipmints@HIDDEN">shipmints@HIDDEN</a>> wr= ote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;= border-left:1px #ccc solid;padding-left:1ex"><div><br><div class=3D"gmail_q= uote"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Mar 19, 2025 at 16:26 S= tefan Monnier <<a href=3D"mailto:monnier@HIDDEN" target=3D"_bl= ank">monnier@HIDDEN</a>> wrote:<br></div><blockquote class=3D"= gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-= left:1ex" dir=3D"auto">> With the patch in <a href=3D"https://debbugs.gn= u.org/cgi/bugreport.cgi?bug=3D76568" rel=3D"noreferrer" target=3D"_blank">h= ttps://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76568</a><br> > duplicates will be harder to install.<br> <br> They're still easy to have (e.g. install some packages system-wide and<= br> then let the users install other versions in their home dir), and that'= s<br> a good thing: we want to support setups with several versions installed<br> at the same time.=C2=A0 Of course, users usually don't want that, so it= 's<br> good to make sure it doesn't happen by accident.=C2=A0 In any case, my<= br> question was simply to confirm that I understood correctly the<br> information that's displayed.</blockquote><div dir=3D"auto"><br></div><= div dir=3D"auto">Maybe I should change the patch to prompt for allowing a d= upe install if that's what someone wants?</div></div></div></blockquote= ><div dir=3D"auto"><br></div><div dir=3D"auto">Hmm. Maybe it already does. = Not at my computer.=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"m= argin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div cla= ss=3D"gmail_quote"><div dir=3D"auto"></div></div></div> </blockquote></div></div> --000000000000a638ed0630b81b4c--
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.Received: (at 76978) by debbugs.gnu.org; 19 Mar 2025 20:37:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 19 16:37:14 2025 Received: from localhost ([127.0.0.1]:53330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tv0A5-0002Xw-O8 for submit <at> debbugs.gnu.org; Wed, 19 Mar 2025 16:37:14 -0400 Received: from mail-vk1-xa31.google.com ([2607:f8b0:4864:20::a31]:52634) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1tv0A2-0002Xh-TA for 76978 <at> debbugs.gnu.org; Wed, 19 Mar 2025 16:37:11 -0400 Received: by mail-vk1-xa31.google.com with SMTP id 71dfb90a1353d-5242f137a1eso45897e0c.1 for <76978 <at> debbugs.gnu.org>; Wed, 19 Mar 2025 13:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742416625; x=1743021425; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rA84msCA8rwYHIZszU2ZubjeJjpUA+NtimF084QnQWc=; b=G3WapZDG73PzvmATtPU+JtRIEitFgQLX6ln8hESQAo0bIAQLeKWsgtqppBjK8oBdHT Yke6f0Hao3gwD6DnKyXcEKlX19i/uZMleHiUziQkyHwPOxx0cvW0Cg+hHCGww/FHyoUO UzgGpaPq3E8/03PFnwPEyBfgL28y5fYk9r0iCS/vtXq1S2wZOeCtb4F/sSzU5XsELal5 F/0chg64c7HrMQg1pDEFHAy2jE1Krtw6w0mWm2f8iEJZLvWni8aynhWZdRf+w90+AO89 xoR5xpTIdmcv0wVTvxaKvK5abf9r1ihkHghXZ8+XagSfy6bsDnbi64vgoZXXTQ7sWOHX 7Ogw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742416625; x=1743021425; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rA84msCA8rwYHIZszU2ZubjeJjpUA+NtimF084QnQWc=; b=AXESBLAZeEAkDzRxYnSDOT/MZTDZIC7skObyFOogNi5frNGcOHzKVZQUreKIgIlmQ6 w6nrKtCZXTjEN/O361aQjlJ7VpJZRnjzuabmrlfWp+HDsUD4t3Zju5zxQ8ieSU2aHzAK vp4f1vCopeLydmfDITWeLeTP6Y/N4D2v4QTyg7/mWqqZontq2n6phnWfOhL11e6UrCt+ zPBrVTE/heteT7vzeCJL7pf8kKDlWe4hqdN66l2RxzEvtCf3X0J6tvT4VJx0aPpW0cMk O0XBxjHxGRrO4CaJKjDVbeHk7NY5ig2dowfY2YwcIqoOv+FyNo8vC4nVUEcLs1s3Eedg 7rgw== X-Forwarded-Encrypted: i=1; AJvYcCXbIguzZ3+Iq5lXL7GcUNnisod5SASrJL84N9hvQp3Yr9tZ1Fbs5oj1WjlKuui/ccrCnl0ROQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzlOZEY8eeghIgx+LuOlsEB9Qwt2dSyazLykiRmnp91ZWwFH26c ZJDhrFVPxjuTgDaPF3a1NZMGYM4hyyVFORLidJlzzYZkqdrdIeIG6/9sFAiOVuy0moLsIlI0uz5 aNQLjdEREG3GTHAgJYN8FaYQrxDs= X-Gm-Gg: ASbGncv5IhxFqdiMHvVwuEyhUaEEhzEatpLCVMqtExJK9IExuWch5H/NqSusPXYY1t6 qz1vlx8YF6v9xnmTNjAL9w47RXwCNEgzwx4mNGD0+Kv+KD6hzRdzcYa4YmG85fsl2gIW4zZmxzE 76CSxcSb/MrfhgLsHXykhhJ1jYGOj7TRyJ0kNFTa4OeuddVvPJHll9DODNCUei X-Google-Smtp-Source: AGHT+IGMShhQY///BNm/nZ/VqIJ0jPHq9z3UZ/QciyVR290m91USJM37RBB/jGCLgda9+llq4/jn6yZ+KLTPhCeapL8= X-Received: by 2002:a05:6102:54a5:b0:4c1:9439:f70 with SMTP id ada2fe7eead31-4c4ec639cdcmr3765645137.6.1742416625023; Wed, 19 Mar 2025 13:37:05 -0700 (PDT) MIME-Version: 1.0 References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN> <87ecyxxqe6.fsf@HIDDEN> <87iko9qffi.fsf@HIDDEN> <87v7s9w1au.fsf@HIDDEN> <87wmcmdyt3.fsf@HIDDEN> <87a59i6lyo.fsf@HIDDEN> <jwvjz8masyr.fsf-monnier+emacs@HIDDEN> <87frj9gbp2.fsf@HIDDEN> <jwvr02tafzh.fsf-monnier+emacs@HIDDEN> <871putdymf.fsf@HIDDEN> <jwva59hvzuu.fsf-monnier+emacs@HIDDEN> <CAN+1Hbp=3X=M0sFk+rsqdn3St96KX=rH0oXqznFApv9bKcif6g@HIDDEN> <jwvldt093er.fsf-monnier+emacs@HIDDEN> In-Reply-To: <jwvldt093er.fsf-monnier+emacs@HIDDEN> From: Ship Mints <shipmints@HIDDEN> Date: Wed, 19 Mar 2025 16:36:54 -0400 X-Gm-Features: AQ5f1JpQTXVfLvc1flwyrOeHTAaQnkcLXMolC2Q6zfO2LBj3op6bLzHSxHCzosU Message-ID: <CAN+1HboT7Mut0L4bEFTJcWt420ndFZ-e1uu51SZCyR7aLs7xjQ@HIDDEN> Subject: Re: bug#76978: [PATCH] package.el: Add built-in version check and loaded package marking To: Stefan Monnier <monnier@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000fc3f950630b7fb15" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76978 Cc: 76978 <at> debbugs.gnu.org, david <davidimagid@HIDDEN>, Philip Kaludercic <philipk@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000fc3f950630b7fb15 Content-Type: text/plain; charset="UTF-8" On Wed, Mar 19, 2025 at 16:26 Stefan Monnier <monnier@HIDDEN> wrote: > > With the patch in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76568 > > duplicates will be harder to install. > > They're still easy to have (e.g. install some packages system-wide and > then let the users install other versions in their home dir), and that's > a good thing: we want to support setups with several versions installed > at the same time. Of course, users usually don't want that, so it's > good to make sure it doesn't happen by accident. In any case, my > question was simply to confirm that I understood correctly the > information that's displayed. Maybe I should change the patch to prompt for allowing a dupe install if that's what someone wants? --000000000000fc3f950630b7fb15 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div><br><div class=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" = class=3D"gmail_attr">On Wed, Mar 19, 2025 at 16:26 Stefan Monnier <<a hr= ef=3D"mailto:monnier@HIDDEN">monnier@HIDDEN</a>> wro= te:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;b= order-left:1px #ccc solid;padding-left:1ex" dir=3D"auto">> With the patc= h in <a href=3D"https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76568" rel= =3D"noreferrer" target=3D"_blank">https://debbugs.gnu.org/cgi/bugreport.cgi= ?bug=3D76568</a><br> > duplicates will be harder to install.<br> <br> They're still easy to have (e.g. install some packages system-wide and<= br> then let the users install other versions in their home dir), and that'= s<br> a good thing: we want to support setups with several versions installed<br> at the same time.=C2=A0 Of course, users usually don't want that, so it= 's<br> good to make sure it doesn't happen by accident.=C2=A0 In any case, my<= br> question was simply to confirm that I understood correctly the<br> information that's displayed.</blockquote><div dir=3D"auto"><br></div><= div dir=3D"auto">Maybe I should change the patch to prompt for allowing a d= upe install if that's what someone wants?</div></div></div> --000000000000fc3f950630b7fb15--
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.
Received: (at 76978) by debbugs.gnu.org; 19 Mar 2025 20:26:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 19 16:26:15 2025
Received: from localhost ([127.0.0.1]:53314 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tuzzT-00021M-DX
for submit <at> debbugs.gnu.org; Wed, 19 Mar 2025 16:26:15 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60528)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1tuzzO-000211-2O
for 76978 <at> debbugs.gnu.org; Wed, 19 Mar 2025 16:26:13 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AEB76805C1;
Wed, 19 Mar 2025 16:26:03 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1742415961;
bh=HEBzpLkCogqqxy3gxYL0TLUzW5EwGpBIxY9TGI/7Shc=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=PrGEkqrYmbpP9xGN+v2UKapx32NPqrynbSzkZS7LafheMmBCSuKry1veTS7Lpn3jt
JHk+eNvWKKzz8+LzAMK0HWOSrDr+6F7nzObOtnhSJg9DBC7TJ/AkDjYU9bJF7h82Ry
YW5hcAvTDQqFUZon/gKw0Pkq3OLPXkFS3Ztypgr1ITDzQ6ZrwHvqmXnP3BD9GBUO8i
iS81gFZdJoqQvnFm62ttLyrYJiEr2pspMX6NyFkNjrU4/yqLeFzPGlOZ/jEFtzCwGb
eobIZbvCNVQ32e/rlia+UCukllin8IEXCh0a5RZ6CSIvfNuFsZdDnbPapWwW4GAPV+
b8SCfx6/pv3Eg==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E36D480599;
Wed, 19 Mar 2025 16:26:01 -0400 (EDT)
Received: from alfajor (modemcable005.21-80-70.mc.videotron.ca [70.80.21.5])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B23D0120661;
Wed, 19 Mar 2025 16:26:01 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Ship Mints <shipmints@HIDDEN>
Subject: Re: bug#76978: [PATCH] package.el: Add built-in version check and
loaded package marking
In-Reply-To: <CAN+1Hbp=3X=M0sFk+rsqdn3St96KX=rH0oXqznFApv9bKcif6g@HIDDEN>
Message-ID: <jwvldt093er.fsf-monnier+emacs@HIDDEN>
References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN>
<87ecyxxqe6.fsf@HIDDEN> <87iko9qffi.fsf@HIDDEN>
<87v7s9w1au.fsf@HIDDEN> <87wmcmdyt3.fsf@HIDDEN>
<87a59i6lyo.fsf@HIDDEN> <jwvjz8masyr.fsf-monnier+emacs@HIDDEN>
<87frj9gbp2.fsf@HIDDEN> <jwvr02tafzh.fsf-monnier+emacs@HIDDEN>
<871putdymf.fsf@HIDDEN> <jwva59hvzuu.fsf-monnier+emacs@HIDDEN>
<CAN+1Hbp=3X=M0sFk+rsqdn3St96KX=rH0oXqznFApv9bKcif6g@HIDDEN>
Date: Wed, 19 Mar 2025 16:26:01 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.191 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 76978
Cc: 76978 <at> debbugs.gnu.org, david <davidimagid@HIDDEN>,
Philip Kaludercic <philipk@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> With the patch in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76568
> duplicates will be harder to install.
They're still easy to have (e.g. install some packages system-wide and
then let the users install other versions in their home dir), and that's
a good thing: we want to support setups with several versions installed
at the same time. Of course, users usually don't want that, so it's
good to make sure it doesn't happen by accident. In any case, my
question was simply to confirm that I understood correctly the
information that's displayed.
Stefan
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.Received: (at 76978) by debbugs.gnu.org; 19 Mar 2025 17:25:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 19 13:25:54 2025 Received: from localhost ([127.0.0.1]:52962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tuxAw-0006tR-7Z for submit <at> debbugs.gnu.org; Wed, 19 Mar 2025 13:25:54 -0400 Received: from mail-vk1-xa31.google.com ([2607:f8b0:4864:20::a31]:51698) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <davidimagid@HIDDEN>) id 1tuxAt-0006t9-4s for 76978 <at> debbugs.gnu.org; Wed, 19 Mar 2025 13:25:52 -0400 Received: by mail-vk1-xa31.google.com with SMTP id 71dfb90a1353d-523d8c024dfso3013266e0c.3 for <76978 <at> debbugs.gnu.org>; Wed, 19 Mar 2025 10:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742405145; x=1743009945; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7n2pPrD9W0ofHz+4MzsHKxyG30Bq0rJW9Ra5SK9h4vY=; b=A1Nnyzq59AFds9ACMIIKuM0TZA5KY2nKcyRFZz38lyPkSk+dy8Y5mHgFkzh2KSoWXC W6NqopAbkGGTv5T+juuHAls53hcrDHLqaQubZnjwu6Ej8Ttax4/FCTyF771CWLetbr0C h5yA7ecPOgV0EhAC2Yu6SC9FM0WTqKFC/GOv8DQgl8Se2qs0iQxZptply+LbfVVCQuYc NzP2RlPsDDhkyk/XLT6iht9fM7wcOfDZyVkM+lwj02AJ+oPxwo94/t8bc/UUvJpKcT3X a32eVUgYNoBjmm/d6rDEFCKSSM+WhzwMscenoRE0uEfFzvbUbRRYXi4+asoSL1kPjqPQ 5yRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742405145; x=1743009945; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7n2pPrD9W0ofHz+4MzsHKxyG30Bq0rJW9Ra5SK9h4vY=; b=fGw7Jm1kCZHY9qwgthl/WzKvOfXa+PDvK6Pe83v31Q/zUPwQm2nNx/IFBMRI2CJMlB n08IacmJ9MEOr7+kF4Z6VM7L5jbXuCMoNTflCmaRq5fN2Hj0U9SbwHe8uoM8W8jK46Hf jKoI0p+qeD/Y0IcJnAO+oMYKyZ8H/XEec7SbjzCw1Pky78rtVmDrpWf14BJJtR+In0mL S82MIpsTFhwgiuqmUFghp8zyC4iHy9MYhej5ap8Oaie3yOsmtIgEKdRmYoKHpwDviNmZ HraxZL/B21vNAL22Umxbjf+nZIkKRX7sZro6B099IeUScED5+cHjMeZFmkLoQzL8DcXs Do+g== X-Forwarded-Encrypted: i=1; AJvYcCWAgjC6cDHKhgej0x9/ddifV8lygMCMjHdxo8McItjV7xdlWIsAsZ0CqdMQ9NztmPb/4w0Lqg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwfKjQPhD01TyoaCCiOukKJdTv023PTl448bO0gPA4CDtsovyBj dxmTThAcSzYZK61p1c9nxntdl2YzxI9KR1KfL4omRX/s7Rt+qck3 X-Gm-Gg: ASbGncul5VM2VY+tsoV4AWevp5e3kBNx1FZYAjEQaHSgMTHZIjJKk7HKFOuwlUnjyYz WD9SXrniAZiDnBV7o1cGEqbgzHiSMmgoRODbjwqhq4HVVZBMA6aLkh4OMh8W74KXCtAy/TVR2k5 Aoy4UMix1Q48gViPMCPHD1+whJUMDEsYQjJ1EfLLgI0ym5wgsD/3++RqMMqYvGx+w101Oj/WctY YQKMWC/aUvjnEN+yRCQJr4IK1q2ipzeKbmLikXpE14uLEvXhb+sAfXwDwA3Jbc3oC0ZMknkmNt/ 1lV9B6cHrXsm4bL1QCYciMl4EY6KEr6PfWla+5c= X-Google-Smtp-Source: AGHT+IH0EGB+OGWzZ6BaPco/tLXjW8nQoEHp8BnkMfEyYUSU3XLtCIudSh54mZJZkvPyevu4fVOzGg== X-Received: by 2002:a05:6122:d20:b0:51f:405e:866e with SMTP id 71dfb90a1353d-52589160a83mr2886865e0c.1.1742405145439; Wed, 19 Mar 2025 10:25:45 -0700 (PDT) Received: from fedora ([190.153.11.22]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5243a5d753bsm2539074e0c.28.2025.03.19.10.25.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Mar 2025 10:25:44 -0700 (PDT) From: david <davidimagid@HIDDEN> To: Philip Kaludercic <philipk@HIDDEN> Subject: Re: [PATCH] package.el: Add built-in version check and loaded package marking In-Reply-To: <87r02tezof.fsf@HIDDEN> References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN> <87ecyxxqe6.fsf@HIDDEN> <87iko9qffi.fsf@HIDDEN> <87v7s9w1au.fsf@HIDDEN> <87wmcmdyt3.fsf@HIDDEN> <87a59i6lyo.fsf@HIDDEN> <jwvjz8masyr.fsf-monnier+emacs@HIDDEN> <87frj9gbp2.fsf@HIDDEN> <jwvr02tafzh.fsf-monnier+emacs@HIDDEN> <871putdymf.fsf@HIDDEN> <jwva59hvzuu.fsf-monnier+emacs@HIDDEN> <87r02tezof.fsf@HIDDEN> User-Agent: mu4e 1.12.8; emacs 31.0.50 Date: Wed, 19 Mar 2025 13:25:35 -0400 Message-ID: <87zfhhgcfk.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76978 Cc: 76978 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Philip Kaludercic <philipk@HIDDEN> writes: > Stefan Monnier <monnier@HIDDEN> writes: > >>> Package marginalia is installed. >>> >>> Status: Installed in =E2=80=98marginalia-2.0/=E2=80=99. Delete >>> Version: 2.0 >>> Commit: c51fd9e4d4258543e0cd8dedda941789163bec5a >>> ... >>> Other versions: 1.8 (installed), 2.0 (gnu, activated), 20250317.1632 (m= elpa). >> >> IIUC this is a package for which you have two versions installed (1.8 >> and 2.0), right? >> >> That looks good. > > What confuses me is that the non-installed version is activated? Should > we perhaps add `display-local-help' annotations to explain what is meant? The version 2.0 is indeed installed, as shown by the "Status" line. This is the help buffer displayed when calling `describe-package` on the GNU ELPA version 2.0 of Marginalia. I am still working on the patch to improve how this information is displayed, ensuring it is clear and avoids confusion. Suggestions like renaming "Other versions" to "All versions" and adding contextual explanations are being considered.
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.Received: (at 76978) by debbugs.gnu.org; 19 Mar 2025 16:46:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 19 12:46:35 2025 Received: from localhost ([127.0.0.1]:52815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tuwYs-0004sk-T1 for submit <at> debbugs.gnu.org; Wed, 19 Mar 2025 12:46:35 -0400 Received: from mout02.posteo.de ([185.67.36.66]:58511) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <philipk@HIDDEN>) id 1tuwYq-0004sQ-8T for 76978 <at> debbugs.gnu.org; Wed, 19 Mar 2025 12:46:33 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 7C98E240103 for <76978 <at> debbugs.gnu.org>; Wed, 19 Mar 2025 17:46:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1742402786; bh=Sf+1rMj4FyMLpYV0VjT/UCyllL4qAIfo5QT18e/fZLw=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=ZaLQh7JDesWrwY609KqynPKWexVbUBoO2pyMYmnO3OGZadC2g/N9yS+tuqnanqfna j+an6EQK1rEvGJ+75CawUkZvsVbIYpsBSL0Hs5TqAi2uyGZ3L2OAsCKOEUuK6Dd+F9 O2nqG+OXg3MM49HGP6JFrabB3c6G52dF8WjuxzLVDDfSJJuWdWS1VDsg1AvNm1Hkth iNqSrhbf+sFa5NINkY8SYDG4F9vOjAsAn3vcB+i39o9mgv6egespxDA4EVo3QghFBs ExFTrSPwiZ9CmULcR6ot3kd+Np2N2vUkkjzRDgBOJ6Z+VGxFDaMy4RDyDedmpJ0Nj7 uy+MfNCJg9JWg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4ZHvjs1V0Sz6tlh; Wed, 19 Mar 2025 17:46:25 +0100 (CET) From: Philip Kaludercic <philipk@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> Subject: Re: [PATCH] package.el: Add built-in version check and loaded package marking In-Reply-To: <jwva59hvzuu.fsf-monnier+emacs@HIDDEN> References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN> <87ecyxxqe6.fsf@HIDDEN> <87iko9qffi.fsf@HIDDEN> <87v7s9w1au.fsf@HIDDEN> <87wmcmdyt3.fsf@HIDDEN> <87a59i6lyo.fsf@HIDDEN> <jwvjz8masyr.fsf-monnier+emacs@HIDDEN> <87frj9gbp2.fsf@HIDDEN> <jwvr02tafzh.fsf-monnier+emacs@HIDDEN> <871putdymf.fsf@HIDDEN> <jwva59hvzuu.fsf-monnier+emacs@HIDDEN> Autocrypt: addr=philipk@HIDDEN; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Wed, 19 Mar 2025 16:46:24 +0000 Message-ID: <87r02tezof.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76978 Cc: david <davidimagid@HIDDEN>, 76978 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Stefan Monnier <monnier@HIDDEN> writes: >> Package marginalia is installed. >> >> Status: Installed in =E2=80=98marginalia-2.0/=E2=80=99. Delete >> Version: 2.0 >> Commit: c51fd9e4d4258543e0cd8dedda941789163bec5a >> ... >> Other versions: 1.8 (installed), 2.0 (gnu, activated), 20250317.1632 (me= lpa). > > IIUC this is a package for which you have two versions installed (1.8 > and 2.0), right? > > That looks good. What confuses me is that the non-installed version is activated? Should we perhaps add `display-local-help' annotations to explain what is meant?
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.Received: (at 76978) by debbugs.gnu.org; 19 Mar 2025 15:32:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 19 11:32:39 2025 Received: from localhost ([127.0.0.1]:52411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tuvPG-0007jt-Gd for submit <at> debbugs.gnu.org; Wed, 19 Mar 2025 11:32:39 -0400 Received: from mail-vk1-xa2a.google.com ([2607:f8b0:4864:20::a2a]:53662) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <davidimagid@HIDDEN>) id 1tuvP8-0007ht-BK for 76978 <at> debbugs.gnu.org; Wed, 19 Mar 2025 11:32:27 -0400 Received: by mail-vk1-xa2a.google.com with SMTP id 71dfb90a1353d-523edc385caso2491710e0c.3 for <76978 <at> debbugs.gnu.org>; Wed, 19 Mar 2025 08:32:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742398340; x=1743003140; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ymfTqDpeVxluCzQuK4sK1Z7qweBxIZrUoSpiUeVQIkg=; b=KUy8c/7jaR4sz1slRCaA5eXto7Vw+PXHCSEUO9TBPC49xr4QhWW7DTPVCdujoOK5Fu 3IOH3iWzIkWpn4Jxan4jKEbEBvUfPZ53rpjp18SC4scu2rJxiSfQD95L+nPpsKJgCtPY DV4IcaoeQZo4nWzE3D7gYvqRJw8gFKRxDszoc2Qrwegt2TMhRKQJA0nNpybbH0AiaDit Yg7KmNzNkFKyn3d7jGjJpQVOylLzJM6Hw+aCVr2PW9RjJz5bgpcL9PW7TRHgo4ug27sd ph79hABfN5GbIzCKqxEy6eNYYvwHpDtXP3HhqALLnehm2meqJ+aIyoeqxlAFftrlstkB 34hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742398340; x=1743003140; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ymfTqDpeVxluCzQuK4sK1Z7qweBxIZrUoSpiUeVQIkg=; b=kmaSNKkTFuKNub7KDgqaLprXRO5vkRY/a5pjHtGgAEmtxQ/zkux+DOuZCxCWHNd7xX kd46/wwQ0Vv2L/f06sKhUk3pJdmP4FP0CwlzGefwL4ZGNDZSwCKLAMfivrS6JtRsEdHn M7fXagfK95sZBmZOr0E81J3LXhyvhVMhZf/+OdjaFCtP3jT/lm9CcC35SIED0vhjnh2X idEHmwhwBYOUX38c2f9h3Kl2tD2xvUO7VBwEjd/Cjq+Uak+C5OhSre2dyH+6DQKFkuAd 0JnrjCOZt1sb2maCOGY8LSclKzYWZSkfUDkrGngqDOA3dA93p3E8spYfMDANKPCum38n Hr/w== X-Forwarded-Encrypted: i=1; AJvYcCVSTwuVePe+kh1R/ScAPNM785k0SuRe3aBoqk2/x0zy4b0BUOb3Df8LAO8a2MB+hQIMXmxcIA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzyQ8nZGNS0hjMpNcZbS5VprnYl/1JR5ASk3NuBY2Jj/SfgzTVD 6q+Ivha6B1pdVtZitldYhU2Q9x418+gc9RDKagjqytYcfsu5sINo X-Gm-Gg: ASbGncsGbBvBoFUdIimx3Unbr7adL69ReKUuprgBcp935sUGvQs6vI6E4vdW072B6Z3 QngFWrlFV0iC79VGlob00sIfHr8phZLn8dvE/Hu4nDC5VFiqOOEVlZLbjhiXbBSaoePWxnJSfxg zQjKVvcMr8VIXLbNfqIO8yaOPAlbae+QrKJNuVrkdEhaWxsO+YFyBwo2UngBUd3iYSrrLX2v4gq YABGTOBXnqqWD2KJm9f00ziVtPWe3gCgistYNRGpignzKcXIV6ThnOtrZIX7MSGZ6ey6uqnca7+ RGXyfx17KLWJka3ir3r1PqbRiL5TI6tCfHRCjC8= X-Google-Smtp-Source: AGHT+IGISMBPFSbDg6Vc+4MitLO6yarpMZ9Pcu7RLB6Tc3Z+VpszeI6lJ8HXQ8JvmmrZJ5VBugzI5g== X-Received: by 2002:a05:6122:488e:b0:520:60c2:3fd with SMTP id 71dfb90a1353d-5258919145dmr2653053e0c.3.1742398338347; Wed, 19 Mar 2025 08:32:18 -0700 (PDT) Received: from fedora ([190.153.11.22]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5258b0a93d8sm293581e0c.14.2025.03.19.08.32.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Mar 2025 08:32:17 -0700 (PDT) From: david <davidimagid@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> Subject: Re: [PATCH] package.el: Add built-in version check and loaded package marking In-Reply-To: <jwva59hvzuu.fsf-monnier+emacs@HIDDEN> References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN> <87ecyxxqe6.fsf@HIDDEN> <87iko9qffi.fsf@HIDDEN> <87v7s9w1au.fsf@HIDDEN> <87wmcmdyt3.fsf@HIDDEN> <87a59i6lyo.fsf@HIDDEN> <jwvjz8masyr.fsf-monnier+emacs@HIDDEN> <87frj9gbp2.fsf@HIDDEN> <jwvr02tafzh.fsf-monnier+emacs@HIDDEN> <871putdymf.fsf@HIDDEN> <jwva59hvzuu.fsf-monnier+emacs@HIDDEN> User-Agent: mu4e 1.12.8; emacs 31.0.50 Date: Wed, 19 Mar 2025 11:32:08 -0400 Message-ID: <87ecyt3ukn.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76978 Cc: Philip Kaludercic <philipk@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 76978 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Monnier <monnier@HIDDEN> writes: >> Package marginalia is installed. >> >> Status: Installed in =E2=80=98marginalia-2.0/=E2=80=99. Delete >> Version: 2.0 >> Commit: c51fd9e4d4258543e0cd8dedda941789163bec5a >> ... >> Other versions: 1.8 (installed), 2.0 (gnu, activated), 20250317.1632 (me= lpa). > > IIUC this is a package for which you have two versions installed (1.8 > and 2.0), right? > Yes, correct. > That looks good. > >> Package faceup is installed. >> >> Status: Installed in =E2=80=98faceup-20170925.1946/=E2=80=99, >> shadowing a built-in package (unsigned). Delete >> Version: 20170925.1946 >> Commit: 6c92dad56a133e14e7b27831e1bcf9b3a71ff154 >> ... >> Other versions: 20170925.1946 (melpa, activated), 0.0.6 (built-in). >> >> Note on the package "faceup." It is interesting that a built-in >> package, when installed via `package-install` and with MELPA added to >> `package-archives`, can update to a version from MELPA (no GNU ELPA >> version is available for this package). > > (Non)GNU ELPA is not treated specially, so yes, that's very much expected. > > BTW, maybe "Other versions:" should be changed to "All versions:", since > it includes the currently shown version. We could also try and skip the > currently shown version, but I'm not sure it would be an improvement > (and would require displaying the corresponding info elsewhere). > Yes, we could change "Other versions" to "All versions". Keeping the current version in the list is useful because it allows viewing the archive of the installed package. Additionally, when using `describe-package`, it may not be obvious which version is current, especially if it is not activated. That's why it's important to clearly mark which version is "activated". In my case, when a version is "activated", it always matches the version in the `load-path` and the one shown by `locate-library`. There is still room for improvement in the patch. So far, we have implemented a check to propose updates for built-in packages only if the new version is greater than the current one. We have also added the "activated" marker for the package in the `load-path`. It is not perfect and could be improved, but I believe it is better than what we currently have in the master branch. The `package.el` code, particularly in `describe-package-1`, is quite complex and ad hoc in my opinion. It could benefit from modularization and abstraction of certain logic, such as creating private helper functions to make the code more maintainable and reusable. However, that would be the scope of another patch.
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.Received: (at 76978) by debbugs.gnu.org; 19 Mar 2025 15:05:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 19 11:05:23 2025 Received: from localhost ([127.0.0.1]:52202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tuuyr-0003nw-A1 for submit <at> debbugs.gnu.org; Wed, 19 Mar 2025 11:05:23 -0400 Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]:43213) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1tuuwx-0003SK-AR for 76978 <at> debbugs.gnu.org; Wed, 19 Mar 2025 11:03:24 -0400 Received: by mail-ot1-x32c.google.com with SMTP id 46e09a7af769-72bceb93f2fso430604a34.0 for <76978 <at> debbugs.gnu.org>; Wed, 19 Mar 2025 08:03:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742396593; x=1743001393; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3EDZuX/SWcSCHWO/rdu0wfO6FD7mYGYMkVIWI/nZXh8=; b=nWE7ZKc9t2TEnNBPc2ywPAux03qFbqC87bWDoA6Y8hxDQSHkbepjsFtLY6PnP1qOSZ GKjUyJeCyMUY5SytxwDC+eJ5IYQWxvdNvMhD0xupTW7vpsmwSZp5UOBausXoPNSq/aSA g0mzfgLBP55MoWqpwisgnOck8KIrTt6FNRwMsO9nHQOp+hTakSQceOATzMS4+97Dxj9J KtXoRwQohLrBRwYbX2YJBnTnNHNpG061DkAmwGOVEiF6saWYoXV2mVX/q2Q48eGQ41q9 gW9KfxOlwH7YkhxkRPwuorZLzSyAXW6a7T1vXMNjMgfU/e/Esfb2TO94K2KXLvC3VkM5 bGqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742396593; x=1743001393; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3EDZuX/SWcSCHWO/rdu0wfO6FD7mYGYMkVIWI/nZXh8=; b=Q6Qxb6uDrwv7TaMTH/3Qx6dEbU8peJctu0ZhgPUIN3wpRaPEmil4/MzAfNptoGJlEz 6TS5WQEHISDjFtS5k9ASVla9F6YiyzE/ymYLJIjHn6HE53PEOHEY/F8keEuAVxneyOgX DXo+cFV5YRNi8Rkuri7xjez3oIm8W151anmZApQhdUPFdRUADJvHZWTcfejQNqovewyh ygU9+2MEMv1SbyPabkUY1EHmVXgo3wPX2XO982c6ylEg1V0jbQNdHKrWRQQzPjPbUN6y VnsdU0Wb61qCdjzMcrGJLf7NeKTNmClxYD0dm4ksmtntFdacfBFkWbNMOhCkSW+OlcOi G0nQ== X-Forwarded-Encrypted: i=1; AJvYcCUyQ8+aEYzF5n/5Sg9n6K1JTEFTu+JO22devvv/gD1acW0RlzQCHbWuOSNf9ns2Q7fNOwn3hw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzmGyebaKbq4ZQzXj+m73s+9/mbbuPHHr62wBlm/tjY/eyIllNg fHyLP/y2ypfAzKFeBoA52l29hSk63OgwfeGOUt8N54FDFBRfGF+c9J2ZEBdYpUKuHIe2NTc88kc 5KMvF/nxrHDp/LTZuewdNl1w/BSM= X-Gm-Gg: ASbGncskMaCsJ8DLQebB0g7K8H6h1SxYuAZ3lOXCxYPdznFZB4tV9i0aoJhsDs6qCQA xTyiyykYWbgOqq782vKs6KTKe2De4aOvCnWP1jOIXb5sKx0y5MHti1p+CQVFhl46cJ75P4Zqikc 6a9YEfJ9NKD03tQu3tweFALEcEyg== X-Google-Smtp-Source: AGHT+IFj1dvopGIttMHo/F9lmLuoGazrg6JteowI9jwjjaWToTx8zz6dqkY2F+emiyv4jBDa4LSWMa+K4YgWbXPrHw8= X-Received: by 2002:a05:6358:94a1:b0:1da:5ae3:88cc with SMTP id e5c5f4694b2df-1df669a07demr17323555d.0.1742396593172; Wed, 19 Mar 2025 08:03:13 -0700 (PDT) MIME-Version: 1.0 References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN> <87ecyxxqe6.fsf@HIDDEN> <87iko9qffi.fsf@HIDDEN> <87v7s9w1au.fsf@HIDDEN> <87wmcmdyt3.fsf@HIDDEN> <87a59i6lyo.fsf@HIDDEN> <jwvjz8masyr.fsf-monnier+emacs@HIDDEN> <87frj9gbp2.fsf@HIDDEN> <jwvr02tafzh.fsf-monnier+emacs@HIDDEN> <871putdymf.fsf@HIDDEN> <jwva59hvzuu.fsf-monnier+emacs@HIDDEN> In-Reply-To: <jwva59hvzuu.fsf-monnier+emacs@HIDDEN> From: Ship Mints <shipmints@HIDDEN> Date: Wed, 19 Mar 2025 11:03:00 -0400 X-Gm-Features: AQ5f1JpeqmM-Gaj073qiRQZqLod-RqSq-Vgo2fl7iwgFZYlpmoubQjk9y5H4DGI Message-ID: <CAN+1Hbp=3X=M0sFk+rsqdn3St96KX=rH0oXqznFApv9bKcif6g@HIDDEN> Subject: Re: bug#76978: [PATCH] package.el: Add built-in version check and loaded package marking To: Stefan Monnier <monnier@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000fe7f390630b351c0" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76978 Cc: 76978 <at> debbugs.gnu.org, david <davidimagid@HIDDEN>, Philip Kaludercic <philipk@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000fe7f390630b351c0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 19, 2025 at 10:59=E2=80=AFAM Stefan Monnier via Bug reports for= GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs@HIDDEN> wrote: > > Package marginalia is installed. > > > > Status: Installed in =E2=80=98marginalia-2.0/=E2=80=99. Delete > > Version: 2.0 > > Commit: c51fd9e4d4258543e0cd8dedda941789163bec5a > > ... > > Other versions: 1.8 (installed), 2.0 (gnu, activated), 20250317.1632 > (melpa). > > IIUC this is a package for which you have two versions installed (1.8 > and 2.0), right? > With the patch in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76568 duplicates will be harder to install. --000000000000fe7f390630b351c0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon= t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">= On Wed, Mar 19, 2025 at 10:59=E2=80=AFAM Stefan Monnier via Bug reports for= GNU Emacs, the Swiss army knife of text editors <<a href=3D"mailto:bug-= gnu-emacs@HIDDEN">bug-gnu-emacs@HIDDEN</a>> wrote:</span></div></div><= div class=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gmail_= quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,= 204);padding-left:1ex">> Package marginalia is installed.<br> ><br> >=C2=A0 =C2=A0 =C2=A0 Status: Installed in =E2=80=98marginalia-2.0/=E2= =80=99. Delete<br> >=C2=A0 =C2=A0 =C2=A0Version: 2.0<br> >=C2=A0 =C2=A0 =C2=A0 Commit: c51fd9e4d4258543e0cd8dedda941789163bec5a<b= r> >=C2=A0 =C2=A0 =C2=A0 ...<br> > Other versions: 1.8 (installed), 2.0 (gnu, activated), 20250317.1632 (= melpa).<br> <br> IIUC this is a package for which you have two versions installed (1.8<br> and 2.0), right?<br></blockquote><div><br></div><div class=3D"gmail_default= " style=3D"font-family:monospace">With the patch in=C2=A0<a href=3D"https:/= /debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76568">https://debbugs.gnu.org/cgi= /bugreport.cgi?bug=3D76568</a>=C2=A0duplicates will be harder to install.</= div></div></div> --000000000000fe7f390630b351c0--
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.
Received: (at 76978) by debbugs.gnu.org; 19 Mar 2025 14:57:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 19 10:57:05 2025
Received: from localhost ([127.0.0.1]:52131 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tuuqu-0002SO-AB
for submit <at> debbugs.gnu.org; Wed, 19 Mar 2025 10:57:05 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38262)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1tuupe-0002Hy-Ii
for 76978 <at> debbugs.gnu.org; Wed, 19 Mar 2025 10:55:49 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 02C3B10004C;
Wed, 19 Mar 2025 10:55:39 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1742396137;
bh=TwpHekEPgZIbV3qogPguDWCg06feIUcsXSzQ0zm/sTs=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=kwzD9UzsuYXFuZ7GlYVfbqDdy1dy2b3V16HNvShkzpqeRkrlENlIjdAXTPZbsxmb8
wfhgwptsHdkG2MB5yAyG31qVKfcMvoQj9NddsxqgYuyK8Qlq1hVy+gCQAwxlbiSo75
vJTr8FtLZMRXl41mFbEUYn+wqmykxCaMoc59j9LDz9bhpMSffK4kcVgfxIIoqU6AS0
rKDzrMzjrOnyb9cPJrFxHz6n4AZ0UkMhzr1CpQRIee9YsBdRamvaiXSyqGnsrHb+Vp
UCTmV6kllcheRCgIUojFRLWM2Hdv0tGfd0zKQMPA1NkAYATbT4DLZNHadmb7ggJcxy
EEWDtpxVcvTBw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8644A100034;
Wed, 19 Mar 2025 10:55:37 -0400 (EDT)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6C6551200D2;
Wed, 19 Mar 2025 10:55:37 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: david <davidimagid@HIDDEN>
Subject: Re: [PATCH] package.el: Add built-in version check and loaded
package marking
In-Reply-To: <871putdymf.fsf@HIDDEN> (david's message of "Wed, 19 Mar 2025
07:54:32 -0400")
Message-ID: <jwva59hvzuu.fsf-monnier+emacs@HIDDEN>
References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN>
<87ecyxxqe6.fsf@HIDDEN> <87iko9qffi.fsf@HIDDEN>
<87v7s9w1au.fsf@HIDDEN> <87wmcmdyt3.fsf@HIDDEN>
<87a59i6lyo.fsf@HIDDEN> <jwvjz8masyr.fsf-monnier+emacs@HIDDEN>
<87frj9gbp2.fsf@HIDDEN> <jwvr02tafzh.fsf-monnier+emacs@HIDDEN>
<871putdymf.fsf@HIDDEN>
Date: Wed, 19 Mar 2025 10:55:35 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.105 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 76978
Cc: Philip Kaludercic <philipk@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
76978 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Package marginalia is installed.
>
> Status: Installed in =E2=80=98marginalia-2.0/=E2=80=99. Delete
> Version: 2.0
> Commit: c51fd9e4d4258543e0cd8dedda941789163bec5a
> ...
> Other versions: 1.8 (installed), 2.0 (gnu, activated), 20250317.1632 (mel=
pa).
IIUC this is a package for which you have two versions installed (1.8
and 2.0), right?
That looks good.
> Package faceup is installed.
>
> Status: Installed in =E2=80=98faceup-20170925.1946/=E2=80=99,
> shadowing a built-in package (unsigned). Delete
> Version: 20170925.1946
> Commit: 6c92dad56a133e14e7b27831e1bcf9b3a71ff154
> ...
> Other versions: 20170925.1946 (melpa, activated), 0.0.6 (built-in).
>
> Note on the package "faceup." It is interesting that a built-in
> package, when installed via `package-install` and with MELPA added to
> `package-archives`, can update to a version from MELPA (no GNU ELPA
> version is available for this package).
(Non)GNU ELPA is not treated specially, so yes, that's very much expected.
BTW, maybe "Other versions:" should be changed to "All versions:", since
it includes the currently shown version. We could also try and skip the
currently shown version, but I'm not sure it would be an improvement
(and would require displaying the corresponding info elsewhere).
Stefan
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.
Received: (at 76978) by debbugs.gnu.org; 19 Mar 2025 11:54:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 19 07:54:53 2025
Received: from localhost ([127.0.0.1]:49060 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tus0b-0004eE-0t
for submit <at> debbugs.gnu.org; Wed, 19 Mar 2025 07:54:53 -0400
Received: from mail-vk1-xa2e.google.com ([2607:f8b0:4864:20::a2e]:46395)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <davidimagid@HIDDEN>)
id 1tus0W-0004cq-H0
for 76978 <at> debbugs.gnu.org; Wed, 19 Mar 2025 07:54:50 -0400
Received: by mail-vk1-xa2e.google.com with SMTP id
71dfb90a1353d-520847ad493so5917787e0c.1
for <76978 <at> debbugs.gnu.org>; Wed, 19 Mar 2025 04:54:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1742385282; x=1742990082; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:user-agent
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=fmzpN1+s9UAw32lx9RwyYNrB7aAGYJy80NDjn/qAZpY=;
b=HjDLRDfv5sg7camQMJ/pghpMCcBXptCd7nBufaTUeJ7U8DwNW9BZ4AA3FopKCNOmeG
yXxpoW+eKouR2SjEARfCgWP+FXI2zmcYuCYgjS3GAwfwMPve/0wwXwgRGrLZglG5euds
FwGQRMYOAHvQd8Ra5zPbP/ZSTa1kUVBJ2fGoXjX89q8ToowMCAwxAaj55T5//XgzZLBv
zmnbx1RewNQbmuvNWH1SiP2NbC2qnlIpTqyEG+17xHEGyjaYhBmm5FvOcoS8Nh9BXjHu
TCLFzisTcNoBPqM4r9MutOpQi+fJzP9u8XEuYvzzg7tmN/om3PlZyoEmOpQvYbTHhhOT
uyww==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1742385282; x=1742990082;
h=content-transfer-encoding:mime-version:message-id:date:user-agent
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=fmzpN1+s9UAw32lx9RwyYNrB7aAGYJy80NDjn/qAZpY=;
b=ds/cdXHbonoBzbL5yr0plqwr9RNdkQciaq6gRS7smPWAHE6BwMFc4sdmqvQ82VUV+C
Qrl0s0wLkckk5iP++/U3MJS+LoCCfwAzYIXwTO14xv0B2e8/UjYfKOOkxePnBrSXNn2U
3/J0EaDBM0HDuGEPbeULdoJXhyunN0QiEdCxV+4G1r9b3OjPRmkCFzQcROJXkh1or8bm
vef5PVrSxsYlx+OgqOfxg5PEh68/PdJfPIR7l+QTWb/huj3T2xwePDnqJ30YrvDOWt8N
kIir/HKsTArC/FUq/dQ+6hVuCG8L03vPvXMfDszRMGXkcvyxlsUTckHy1vwBGQkRmb68
N61g==
X-Forwarded-Encrypted: i=1;
AJvYcCWVwem7yrg8RNqmPnhn3QEOcBvFLbNa4StUIPhS+03DDbHcTDBq8Tjny9fQsc9hjt3AO1EO2Q==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YxuNW4Fdam4ctEEmbzgod6gAnTmJ13i134Hg91kI/mcSX9fWpfT
qJAXkNvONOZ4to06i2Lhgkw47zYarMBaUB0C2MZHHcpfqXYHLzjm
X-Gm-Gg: ASbGncvkI7hMyUARY3fJJEKofIyMCATlvRU7uZohkzQJ/VRuVj+PFhlzwIQXoqOQVSb
4Km2dYbO4gHPqcbD3g5ou/MAP2jq/OxmpaZSLVMN3ztVFyRFVSkDkYN6oxxEi874JzIOM5miNvB
sWfyopbvDdpwQ65XwQCXGoWC6pTckLQtpHGdV2dNTT2bSq6nlhZWBJ6tXGPV/CxBUbMZl3au02z
EOhsGIwjPDgD7cttVfTpw5c3A+9aC7rPrYXDfRGNxj0vsgjg91GohnWQDU0asq49VLLCLftpgXu
uXwJazfbMgQ2TlRDzB+lJVsgo3MeySsPch+AwNU=
X-Google-Smtp-Source: AGHT+IE3N1qSBukl3WvokAMhdatKnOJrjQTSOS4Vy/FyuzxndNd7c/ANjbRoxv7tWL3LyXeP/T24zg==
X-Received: by 2002:a05:6102:442c:b0:4bb:623:e1f7 with SMTP id
ada2fe7eead31-4c4ec81b54dmr1319743137.16.1742385282600;
Wed, 19 Mar 2025 04:54:42 -0700 (PDT)
Received: from fedora ([190.153.11.22]) by smtp.gmail.com with ESMTPSA id
ada2fe7eead31-4c375141121sm2231648137.20.2025.03.19.04.54.40
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 19 Mar 2025 04:54:41 -0700 (PDT)
From: david <davidimagid@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: [PATCH] package.el: Add built-in version check and loaded
package marking
In-Reply-To: <jwvr02tafzh.fsf-monnier+emacs@HIDDEN>
References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN>
<87ecyxxqe6.fsf@HIDDEN> <87iko9qffi.fsf@HIDDEN>
<87v7s9w1au.fsf@HIDDEN> <87wmcmdyt3.fsf@HIDDEN>
<87a59i6lyo.fsf@HIDDEN> <jwvjz8masyr.fsf-monnier+emacs@HIDDEN>
<87frj9gbp2.fsf@HIDDEN> <jwvr02tafzh.fsf-monnier+emacs@HIDDEN>
User-Agent: mu4e 1.12.8; emacs 31.0.50
Date: Wed, 19 Mar 2025 07:54:32 -0400
Message-ID: <871putdymf.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76978
Cc: Philip Kaludercic <philipk@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
76978 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Stefan Monnier <monnier@HIDDEN> writes:
>
> [...] I do think we want to show which packages are "activated" (or
> "active").
>
I agree. Using "activated," as initially proposed, seems to be the more
appropriate choice.
I will proceed to update the patch based on the latest suggestions and
feedback. Below is an example of how the changes would appear in
`describe-package`:
Package marginalia is installed.
Status: Installed in =E2=80=98marginalia-2.0/=E2=80=99. Delete
Version: 2.0
Commit: c51fd9e4d4258543e0cd8dedda941789163bec5a
...
Other versions: 1.8 (installed), 2.0 (gnu, activated), 20250317.1632 (melpa=
).
Package diff-hl is installed.
Status: Installed in =E2=80=98diff-hl-1.10.0/=E2=80=99. Delete
Version: 1.10.0
Commit: b80ff9b4a772f7ea000e86fbf88175104ddf9557
...
Other versions: 1.10.0 (gnu, activated), 20250317.242 (melpa).
Package track-changes is installed.
Status: Installed in =E2=80=98track-changes-1.4/=E2=80=99. Delete
Version: 1.4
Commit: ffb7d656a2c89f86ccd2de51379de9612c7a4aa3
...
Other versions: 1.4 (gnu, activated), 1.2 (built-in).
Package faceup is installed.
Status: Installed in =E2=80=98faceup-20170925.1946/=E2=80=99,
shadowing a built-in package (unsigned). Delete
Version: 20170925.1946
Commit: 6c92dad56a133e14e7b27831e1bcf9b3a71ff154
...
Other versions: 20170925.1946 (melpa, activated), 0.0.6 (built-in).
Note on the package "faceup." It is interesting that a built-in
package, when installed via `package-install` and with MELPA added to
`package-archives`, can update to a version from MELPA (no GNU ELPA
version is available for this package).
> [...] please contact the FSF clerk and ask them to add the email you
> use habitually (such as the one I'm replying to) to avoid such
> problems in the future.
>
Will do. Thanks.
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.
Received: (at 76978) by debbugs.gnu.org; 19 Mar 2025 03:08:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 18 23:08:55 2025
Received: from localhost ([127.0.0.1]:45428 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tujnb-0000EC-66
for submit <at> debbugs.gnu.org; Tue, 18 Mar 2025 23:08:55 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62363)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1tujnZ-0000Cz-E8
for 76978 <at> debbugs.gnu.org; Tue, 18 Mar 2025 23:08:53 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9D66D444308;
Tue, 18 Mar 2025 23:08:46 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1742353721;
bh=+F0nBO4bcsGHXidhQrZcMP5be8s05/54Yf2BBga5ECk=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=mP+AzQuxI+cyRn2GVhH9xqiB4inXe81ey/OpKia/o5pfMCnsTlkDIGd8d/sB646+Y
hMLqMQ8axbEUN+/vb/el7tJxcFf47JzdpeVD8TUAg9mZupKPzS3QVCY4WUmr4p8/x+
bK6fkb7nVI1LeVZdkh81R+Gp1Z1hN5V2mpdCm7gPL9PoQbzPIZ2DeYYp/CqwVh5A2A
4Wm+pNl+8f71+E/SrKaUxmuTE5twRxZ00BAYDJe29Pr7xLggR3L/XNTViqrqvZuIvU
+lhdMREFK76YgO+6eHz9TfTsg4hbxe67ZiynsfhOPvCSXEmeZUspYIT5bpX2K0nPro
47bQQv8i1h58Q==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 182E54442F5;
Tue, 18 Mar 2025 23:08:41 -0400 (EDT)
Received: from pastel (unknown [104.247.242.5])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CEEB31202FD;
Tue, 18 Mar 2025 23:08:40 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: david <davidimagid@HIDDEN>
Subject: Re: [PATCH] package.el: Add built-in version check and loaded
package marking
In-Reply-To: <87frj9gbp2.fsf@HIDDEN>
Message-ID: <jwvr02tafzh.fsf-monnier+emacs@HIDDEN>
References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN>
<87ecyxxqe6.fsf@HIDDEN> <87iko9qffi.fsf@HIDDEN>
<87v7s9w1au.fsf@HIDDEN> <87wmcmdyt3.fsf@HIDDEN>
<87a59i6lyo.fsf@HIDDEN> <jwvjz8masyr.fsf-monnier+emacs@HIDDEN>
<87frj9gbp2.fsf@HIDDEN>
Date: Tue, 18 Mar 2025 23:08:29 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.391 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 76978
Cc: Philip Kaludercic <philipk@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
76978 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> Hmm... the two terms do not mean the same thing. "Loaded" refers to the
>> package's `.el` files having been `load`ed, whereas "activated" means
>> that the package's directory has been added to `load-path` and its
>> `<PKG>-autoloads.el` file has been loaded.
>>
>> The variable `package-activated-list` keeps track, as the name suggests,
>> of packages that have been activated, not loaded.
>>
> Should we mark packages in "Other versions" as "activated" or "loaded"
> (like the GNU ELPA package Marginalia, which shows "Loaded" when
> calling `locate-library`)?
AFAICT, that shows whether a given file was loaded or not, so "loaded"
sounds like the right term.
> Currently, "Other versions" redundantly includes the described
> package. I aim to improve this by indicating if the package is in
> `load-path`, helping users identify active or loaded packages.
> What do you recommend?
Not sure what is the question, but I do think we want to show which
packages are "activated" (or "active"). "Loaded" would be a lot more
difficult: we have a way to test if a given *file* has been
loaded, but when it comes to a *package* the meaning is not even
clear (it may be that some of its files have been loaded but not all).
I'm not completely sure how to figure that out, tho.
`package-activated-list` only gives the name of the packages but not
their version. In some cases you could look for the `<PKG>-autoloads`
file in `load-history` (and then get the version from the directory name
or from the nearby `<PKG>-pkg.el` file), but that won't work if the
package has been activated via package-quickstart. Maybe we need to
change the package activation to keep more information about the
activated packages.
>> Also, I had questions in my previous review and I haven't seen any
>> answer to them (most importantly about copyright paperwork).
> Yes, I have signed the copyright paperwork.
Great. I can't find your name in the FSF's copyright list, for
some reason. Have you signed very recently (and the FSF's copyright
clerk just hasn't updated the list yet?) or maybe you used another
name/email? In that last case, please contact the FSF clerk and ask them
to add the email you use habitually (such as the one I'm replying to) to
avoid such problems in the future.
Stefan
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.Received: (at 76978) by debbugs.gnu.org; 18 Mar 2025 23:29:29 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 18 19:29:29 2025 Received: from localhost ([127.0.0.1]:43823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tugNE-0007W2-IY for submit <at> debbugs.gnu.org; Tue, 18 Mar 2025 19:29:28 -0400 Received: from mail-ua1-x92d.google.com ([2607:f8b0:4864:20::92d]:47301) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <davidimagid@HIDDEN>) id 1tugNC-0007Uv-AC for 76978 <at> debbugs.gnu.org; Tue, 18 Mar 2025 19:29:27 -0400 Received: by mail-ua1-x92d.google.com with SMTP id a1e0cc1a2514c-86b9d1f7249so5667624241.2 for <76978 <at> debbugs.gnu.org>; Tue, 18 Mar 2025 16:29:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742340560; x=1742945360; darn=debbugs.gnu.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=RLAo+qr29kSOXycIMdSa66y72YhrT466bcsjaM1SY7M=; b=m45WE82Zyvjf1A+o7a2LKyYlBEW5cI7AqEEO5lVVgwZD22BXPgOoenbyvyZvCIDlhK if6YPHPqFikOoVK3EnFC2/NSbZ+AwIv7av2rnn4O14Zhki7d7oYDXcJ+75UFOA0ypmrH qoWex0FMlOwH2ux6PdN0CAUGLcV6OSecpiaCRwlkQjVGfZujR3OZbFCKGp+VrMQv2GKe arChZ9WkTCxpJ7i0KnJWLzkyiH/eHcUjuRWkyKfs1EXsXEpkRgqwMq2f6MCHRRw2bM59 XT9cAFNa7YOeaoDl7rBuDzNzAjd5eOtjvdNs1GsVHBTGF1bYFyq2UfELPHYV9NM+YONZ 5j+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742340560; x=1742945360; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RLAo+qr29kSOXycIMdSa66y72YhrT466bcsjaM1SY7M=; b=LMBob/h8ihuGLzsDMEAE49ox3Wo0g7N3KoaQKRFmyUHvL0Km7oPH78p1S+BP8OONGl hNb9XRCwxI89vQBrz/4KgM1kpA19DShVWNSMdSkui3IH45O9st5NT1Y7nc8rWI+yDASk oWRulMGnnk4rj/JTRp8vnkUOfUmifGJHk1Crku64weaQD/smCdmMZqmUIpVJjNSf2ugF 2RlVON5fX0h5I4mYLWyM6USnds4nX58eyBooJKcB1wKcBDf9tMCEz+DDi1mBVbLWrSEE i5HyzplPDgkJGT5eZPoQN6lg/mFrSyePzN8M4EjiLxcbLX9s85PgcORF/C6vOHHOYaMc uNKQ== X-Forwarded-Encrypted: i=1; AJvYcCWFoGODhiG+GHPJBeeAAO2bzWAbCu7lMB20NSWyK8HdR5jG6RG8Winhq+QFGvsKZkmd0R2vgQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywn2y0KguEXOGSysDoy7Ijsa+aVUF3djzqVqd7yDfxzwGj1Cf2V cc/j1KICbRpAjhXY1uOK5Hy2/8CNKxeHwromHUhvdXpl27/2hMyU X-Gm-Gg: ASbGncv8XUmDEbCTYCAKG9bVLOKbMH+Oqal9j6u8Xwc1G8CXpZX0UmmivAsodaT94S9 6FaUcSSVU8xw6fYcwK2+Z1d+u9a4NdYjWDMjJwiQWM7GtoIUUwlmfGRUZlyjTsQAvXSd2NLQmbL tRwv5y32+aFvIVVoV3FI+sv89RedQ4kqUu3VrJxXR/Ea33peephVoYtlRzEmdqK8zsF6HULHVAo DLJgZ6CrJEelDrrVN/K8UNwf7QRlNo2SY2RVa1gN4uejcSNLUdwUrEFzo86RhO6XHH4dsYyv89i 79YSq4yUtKn1hkhN5Un7IXODnqE4WNyFrhQ0qw== X-Google-Smtp-Source: AGHT+IGEjBuMtLuRd+3FPI4ayIhVfZFfTcfMAUZ04DoyoT3n/LfFso4RVrnFO7xJroWA+AvG3oYzPw== X-Received: by 2002:a05:6102:5f05:b0:4bb:e80b:473d with SMTP id ada2fe7eead31-4c4ec64d058mr553715137.6.1742340560564; Tue, 18 Mar 2025 16:29:20 -0700 (PDT) Received: from fedora ([190.6.18.153]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-4c374ee004dsm2107737137.3.2025.03.18.16.29.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 16:29:19 -0700 (PDT) From: david <davidimagid@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> Subject: Re: [PATCH] package.el: Add built-in version check and loaded package marking In-Reply-To: <jwvjz8masyr.fsf-monnier+emacs@HIDDEN> References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN> <87ecyxxqe6.fsf@HIDDEN> <87iko9qffi.fsf@HIDDEN> <87v7s9w1au.fsf@HIDDEN> <87wmcmdyt3.fsf@HIDDEN> <87a59i6lyo.fsf@HIDDEN> <jwvjz8masyr.fsf-monnier+emacs@HIDDEN> User-Agent: mu4e 1.12.8; emacs 31.0.50 Date: Tue, 18 Mar 2025 19:29:13 -0400 Message-ID: <87frj9gbp2.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76978 Cc: Philip Kaludercic <philipk@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 76978 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Monnier <monnier@HIDDEN> writes: >> I also changed "activated" to "loaded", as the latter is more accurate >> for marking packages in the "Other versions" section. > > Hmm... the two terms do not mean the same thing. "Loaded" refers to the > package's `.el` files having been `load`ed, whereas "activated" means > that the package's directory has been added to `load-path` and its > `<PKG>-autoloads.el` file has been loaded. > > The variable `package-activated-list` keeps track, as the name suggests, > of packages that have been activated, not loaded. > Should we mark packages in "Other versions" as "activated" or "loaded" (like the GNU ELPA package Marginalia, which shows "Loaded" when calling `locate-library`)? Currently, "Other versions" redundantly includes the described package. I aim to improve this by indicating if the package is in `load-path`, helping users identify active or loaded packages. What do you recommend? > > Also, I had questions in my previous review and I haven't seen any > answer to them (most importantly about copyright paperwork). > Yes, I have signed the copyright paperwork. I will carefully review your suggestions and prepare an updated patch addressing them. Thank you for your thorough feedback and for keeping an eye on the patch.
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.
Received: (at 76978) by debbugs.gnu.org; 18 Mar 2025 22:28:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 18 18:28:24 2025
Received: from localhost ([127.0.0.1]:43691 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tufQ7-0007LV-UX
for submit <at> debbugs.gnu.org; Tue, 18 Mar 2025 18:28:24 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:32497)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1tufQ5-0007Kj-07
for 76978 <at> debbugs.gnu.org; Tue, 18 Mar 2025 18:28:21 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EB539100040;
Tue, 18 Mar 2025 18:28:13 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1742336893;
bh=bl+yLuLAVNaBbRVw1ZYdXaOg3h6GE3xYzFzWhUngmdU=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=DP3GQxJnpD7Uyf0FZWZj/B2Tkur3gP+6Djh5wl5tQ44+mNxUD3yfhcIJRdM5nEKHw
9oiY00Q4V6eSfgWnD4cODFZ83mKByDZAyPca2mt9sPR+vK2Mm9Ta9LxDzQ/87zVW05
BDMT8omM3LpZBzZZun+BKN1u81EC62RpKGlW60ir6MBdV/n0wcrU3fbSQaY6zVmTbZ
u1QiKNZRh1+aZrqWsxeQIsD/3nMqgOI2GkKhpeCswxVQ2REA2T4LUx+rY4vKdIOzEU
KMmw3pIgwCyV/2ySG/2AEKpVzjhbSuqKgL3dwogL2SgdFhRRjT1h3rkSf8HhelPmzd
5oYMFwlLxapPw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EEFE110002E;
Tue, 18 Mar 2025 18:28:12 -0400 (EDT)
Received: from pastel (unknown [104.247.242.5])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B3FF912005D;
Tue, 18 Mar 2025 18:28:12 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: david <davidimagid@HIDDEN>
Subject: Re: [PATCH] package.el: Add built-in version check and loaded
package marking
In-Reply-To: <87a59i6lyo.fsf@HIDDEN>
Message-ID: <jwvjz8masyr.fsf-monnier+emacs@HIDDEN>
References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN>
<87ecyxxqe6.fsf@HIDDEN> <87iko9qffi.fsf@HIDDEN>
<87v7s9w1au.fsf@HIDDEN> <87wmcmdyt3.fsf@HIDDEN>
<87a59i6lyo.fsf@HIDDEN>
Date: Tue, 18 Mar 2025 18:28:11 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.363 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 76978
Cc: Philip Kaludercic <philipk@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
76978 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> I also changed "activated" to "loaded", as the latter is more accurate
> for marking packages in the "Other versions" section.
Hmm... the two terms do not mean the same thing. "Loaded" refers to the
package's `.el` files having been `load`ed, whereas "activated" means
that the package's directory has been added to `load-path` and its
`<PKG>-autoloads.el` file has been loaded.
The variable `package-activated-list` keeps track, as the name suggests,
of packages that have been activated, not loaded.
> (package-menu--check-builtin-version): New function to compare
> built-in and available versions.
You can just say "New function" here. =F0=9F=99=82
> + ;; Add built-in packages to the list if the=
y exist.
> + (and-let* ((bi (assq name package--builtins=
)))
> + (list (package--from-builtin bi)))))
> + (other-pkgs (remove desc all-pkgs)))
I didn't see an explanation in the commit message for why you replaced
`delete` with `remove`. AFAICT, `all-pkgs` is a fresh new list so
`delete` looks safe here (as long as we don't use `all-pkgs` later).
> - (from (or (package-desc-archive opkg)
> - (if (stringp dir) "installed" di=
r))))
> + (from (or (package-desc-archive opkg)
> + (if (stringp dir) "installed" "built-in")))
With the current code I see "builtin" displayed. I don't understand
what `dir` does in the current code, but that means I also don't
understand what this change is supposed to do.
> + (format "%s (%s%s)"
> + (if ov
> + (make-text-button
> + (package-version-join ov) nil
> + 'font-lock-face 'link
> + 'follow-link t
> + 'action
> + (lambda (_button)
> + (describe-package opkg)))
> + "n/a")
> + from
> + (if loaded ", loaded" ""))))
> + other-pkgs ", ")
I think when `ov` is nil, we're better off using the same output as
before, i.e. just (format "%s" from). This said, I can't remember when
this can happen.
Also, I had questions in my previous review and I haven't seen any
answer to them (most importantly about copyright paperwork).
Stefan
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.
Received: (at 76978) by debbugs.gnu.org; 18 Mar 2025 21:57:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 18 17:57:57 2025
Received: from localhost ([127.0.0.1]:43651 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tuewe-0002ym-Eo
for submit <at> debbugs.gnu.org; Tue, 18 Mar 2025 17:57:57 -0400
Received: from mail-vk1-xa33.google.com ([2607:f8b0:4864:20::a33]:49287)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <davidimagid@HIDDEN>)
id 1tuewY-0002x4-DI
for 76978 <at> debbugs.gnu.org; Tue, 18 Mar 2025 17:57:54 -0400
Received: by mail-vk1-xa33.google.com with SMTP id
71dfb90a1353d-523dc366e42so2408209e0c.2
for <76978 <at> debbugs.gnu.org>; Tue, 18 Mar 2025 14:57:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1742335064; x=1742939864; darn=debbugs.gnu.org;
h=mime-version:message-id:date:user-agent:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=ip7QahTgc5fJRACSdVX1S1nKmmlLxwwDkWsW0irShnI=;
b=Qhu/tNiREWjJLZqUAJ1JquNk0bfBgT+FG/x0UH2BFSMxKyTzRoyb2Sroe96dLYvdIn
pnDkP1YX/Ao9sYgAQ0SYSE9aP8T9a9OeMTkCNTIJv58EEZ7VFbAifxVVLtTufx2i/WrT
Bhncfcy8K7SOHiWBNXEYAcQt1SLjFtrglqjB5QWk6HEufwS8ZYtjOtyhZf+iqp7kfvur
T8g/GM3chFMnUnTMooJ+mvBM9TcH7/XQ5Jhe/vVHy2L2dTuWii/+9KZaA+nIfVWg2Wh3
6KlwlXMJdaS76tuw95up4EB1VI8W86LnMXmO0qSYGSrM8tjDd96HZd4+6zEw8F4fQ6b0
VkPA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1742335064; x=1742939864;
h=mime-version:message-id:date:user-agent:references:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=ip7QahTgc5fJRACSdVX1S1nKmmlLxwwDkWsW0irShnI=;
b=DiqGAJa4RNy+FQNzEaXJS/QMW7JVBHHlSKvYkeWdK5CR8GPsWlBeMlffEPetDMibOh
M+Ogdr+cT4rCuaJqy9At957eJHajX2QJzYifbEHHwFOiTkX59usQBTkJ0r3EWVuX39M2
OQ3ZyPZoyRT1PFsFS6tiXpH8kGRN2cth2YQx2NyiRRegrq0nHvkZJcu+TsPgfkIQGwaZ
Qo2DeVw+c8cxeHcIG15p0F4NmKwAokBMVEMuxV1uZbaxKV6ziFKUe0lvJtO70JxoRqGM
8MJBsWVtqgp836H5/5Tu5DC7Or7qTR5Vug5a1cSTblu9tK+rSJorYSaMX9ralGxZEsP2
TamQ==
X-Gm-Message-State: AOJu0YzXRkEqC/LIgbl6/97Cmfww7SlaI0xOISgnMbazOZq9Cm9K8ltD
DD8F7FPDStuGBt6bcHGmif/8RTKg699n4EZi2EZYMeLA19wtZhIz
X-Gm-Gg: ASbGncu4aLYYTlORWF30BHpmSlErb+pQJx6RCFLBew7oODYQ1535tmgy++5CjK3fY+/
FDv/eg16bGuDJ6z1wsl6qva+r9Uh15FdC3kTsImuqbIz2lHicSS/vskeBPaEjVdm9ckL41rFhwB
6tlIw4G1PF7gEjVBQw852sklar7y6w6NLKxT2xK2QdxDhG10prF29SyQOMJaV/6Gjz7SM/YAjFc
uAV+zkVp6B8ALAgaKKFJa1/QPvPO9PVKUlsAZHwjdgP2iYr5i/tZj/CcyXX3goQ5ThZ1bZpVZg3
2JRvT0tEfT6ZdVjaTJPECsM16m6/CVsBT4Y21w==
X-Google-Smtp-Source: AGHT+IEmdWbgqRP2nRhfJFUW8ZYVu0lSK76pOrVEGuGKg6ERBp+4BwbwKDU8K4ROfOwyvPN0b+YWTw==
X-Received: by 2002:a05:6102:4189:b0:4c1:a66f:a468 with SMTP id
ada2fe7eead31-4c4ec83db4cmr290661137.22.1742335064556;
Tue, 18 Mar 2025 14:57:44 -0700 (PDT)
Received: from fedora ([190.6.18.153]) by smtp.gmail.com with ESMTPSA id
ada2fe7eead31-4c374ee004dsm2081616137.3.2025.03.18.14.57.42
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 18 Mar 2025 14:57:43 -0700 (PDT)
From: david <davidimagid@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
Subject: [PATCH] package.el: Add built-in version check and loaded package
marking
In-Reply-To: <87wmcmdyt3.fsf@HIDDEN>
References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN>
<87ecyxxqe6.fsf@HIDDEN> <87iko9qffi.fsf@HIDDEN>
<87v7s9w1au.fsf@HIDDEN> <87wmcmdyt3.fsf@HIDDEN>
User-Agent: mu4e 1.12.8; emacs 31.0.50
Date: Tue, 18 Mar 2025 17:57:35 -0400
Message-ID: <87a59i6lyo.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76978
Cc: 76978 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>,
Stefan Monnier <monnier@HIDDEN>,
Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Hello everyone, this is the corrected patch incorporating suggestions
from Philip and Stefan. I also changed "activated" to "loaded", as
the latter is more accurate for marking packages in the "Other
versions" section.
I=E2=80=99m submitting this patch to enhance `describe-package` by adding
information about the currently loaded package and improving the
built-in version check. Since "Other versions" already displays the
current version of the package, I=E2=80=99ve added a "loaded" marker to
indicate which version is loaded in the current Emacs session.
This patch for `package.el` introduces two improvements:
1. The package menu now compares the built-in version of a package
with the available version. If the available version is newer, the
status is set to "available"; otherwise, it is marked as "built-in".
This helps users identify when updates are available for built-in
packages.
2. Packages listed in the "Other versions" section are now marked with
", loaded" if they are currently loaded in the Emacs session. This
provides clarity on which versions are in use.
I=E2=80=99d appreciate your feedback and suggestions for integrating this
corrected patch into the master branch.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-package.el-Add-built-in-version-check-and-loaded-pac.patch
Content-Description: package.el: Add built-in version check and loaded package marking
From 63852636e1461d53ca52e9b135b652ffb33e5fb6 Mon Sep 17 00:00:00 2001
From: dimagid <dimagidve@HIDDEN>
Date: Tue, 18 Mar 2025 13:02:40 -0400
Subject: [PATCH] package.el: Add built-in version check and loaded package
marking
This commit introduces two improvements to package.el:
1. The package menu now compares the built-in version of a package with
the available version. If the available version is newer, the status
is set to "available"; otherwise, it is marked as "built-in". This
helps users identify when updates are available for built-in packages.
2. Packages listed in the "Other versions" section are now marked with
", loaded" if they are currently loaded in the Emacs session. This
provides clarity on which versions are in use.
These changes enhance the user experience by making it easier to
identify updates for built-in packages and track which package
versions are currently loaded.
* lisp/emacs-lisp/package.el (package-menu--print-info-simple): Add
built-in version check and loaded package marking.
(package-menu--check-builtin-version): New function to compare
built-in and available versions.
(describe-package-1): Update logic to mark loaded packages.
---
lisp/emacs-lisp/package.el | 72 ++++++++++++++++++++++++++++----------
1 file changed, 53 insertions(+), 19 deletions(-)
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index b9a8dacab15..186ce8238d7 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2977,26 +2977,36 @@ describe-package-1
(package--print-email-button author)))
(let* ((all-pkgs (append (cdr (assq name package-alist))
(cdr (assq name package-archive-contents))
- (let ((bi (assq name package--builtins)))
- (if bi (list (package--from-builtin bi))))))
- (other-pkgs (delete desc all-pkgs)))
+ ;; Add built-in packages to the list if they exist.
+ (and-let* ((bi (assq name package--builtins)))
+ (list (package--from-builtin bi)))))
+ (other-pkgs (remove desc all-pkgs)))
(when other-pkgs
(package--print-help-section "Other versions"
- (mapconcat (lambda (opkg)
- (let* ((ov (package-desc-version opkg))
- (dir (package-desc-dir opkg))
- (from (or (package-desc-archive opkg)
- (if (stringp dir) "installed" dir))))
- (if (not ov) (format "%s" from)
- (format "%s (%s)"
- (make-text-button (package-version-join ov) nil
- 'font-lock-face 'link
- 'follow-link t
- 'action
- (lambda (_button)
- (describe-package opkg)))
- from))))
- other-pkgs ", ")
+ (mapconcat
+ (lambda (opkg)
+ (let* ((ov (package-desc-version opkg))
+ (dir (package-desc-dir opkg))
+ (from (or (package-desc-archive opkg)
+ (if (stringp dir) "installed" "built-in")))
+ ;; Check if the package is currently loaded and
+ ;; matches the described version.
+ (loaded (and (member (package-desc-name opkg)
+ package-activated-list)
+ (equal ov (package-desc-version desc)))))
+ (format "%s (%s%s)"
+ (if ov
+ (make-text-button
+ (package-version-join ov) nil
+ 'font-lock-face 'link
+ 'follow-link t
+ 'action
+ (lambda (_button)
+ (describe-package opkg)))
+ "n/a")
+ from
+ (if loaded ", loaded" ""))))
+ other-pkgs ", ")
".")))
(insert "\n")
@@ -3640,11 +3650,35 @@ package-status-avail-obso
;;; Package menu printing
+(defun package-menu--check-builtin-version (pkg)
+ "Check if PKG is a built-in package and compare versions.
+Return the appropriate status for PKG."
+ (let* ((status (package-desc-status pkg))
+ (name (package-desc-name pkg))
+ (version (package-desc-version pkg))
+ ;; Check if the package is built-in by looking it up in
+ ;; `package--builtins'.
+ (built-in-pkg (assq name package--builtins))
+ ;; If the package is built-in, get its version.
+ (built-in-version (if built-in-pkg
+ (package-desc-version
+ (package--from-builtin built-in-pkg)))))
+ (cond
+ ((not (and built-in-pkg (equal status "available")))
+ status)
+ ;; If the built-in version is older than the available version,
+ ;; return "available".
+ ((version-list-< built-in-version version)
+ "available")
+ ;; Otherwise, return "built-in".
+ (t
+ "built-in"))))
+
(defun package-menu--print-info-simple (pkg)
"Return a package entry suitable for `tabulated-list-entries'.
PKG is a `package-desc' object.
Return (PKG-DESC [NAME VERSION STATUS DOC])."
- (let* ((status (package-desc-status pkg))
+ (let* ((status (package-menu--check-builtin-version pkg))
(face (pcase status
("built-in" 'package-status-built-in)
("external" 'package-status-external)
--
2.48.1
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.
Received: (at 76978) by debbugs.gnu.org; 18 Mar 2025 18:42:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 18 14:42:36 2025
Received: from localhost ([127.0.0.1]:43249 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tubtZ-0006jY-0e
for submit <at> debbugs.gnu.org; Tue, 18 Mar 2025 14:42:36 -0400
Received: from mout01.posteo.de ([185.67.36.65]:48601)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <philipk@HIDDEN>)
id 1tubtT-0006iE-3u
for 76978 <at> debbugs.gnu.org; Tue, 18 Mar 2025 14:42:29 -0400
Received: from submission (posteo.de [185.67.36.169])
by mout01.posteo.de (Postfix) with ESMTPS id 40A13240028
for <76978 <at> debbugs.gnu.org>; Tue, 18 Mar 2025 19:42:21 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
t=1742323341; bh=0Getxs5mHKA/f13/3jswggqbz0un6bbpYSR9FIGPEkM=;
h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version:
Content-Type:Content-Transfer-Encoding:From;
b=k2mqUqVaLdm91nKTZl6ixQpCcYeWDz2kwpGEAYxomSA0lJNg+FvvpIMQ4X1nektOY
T/PbwdraytDgNaH38H5HYvDnhOPwS+susb6dNotTul2MJT5TOBszMowXxiaJfp8pRi
fqSapBDu3Ogp8b2vGKT9iJIZ1nm/7sX056PNTFcc2B0ryvmmuS4Wcz/T3T+m/vvtM6
/mBRQIoVKniFBmKfgniBItyVgnkyuNuI33E5LGuiKnvhq2cMe4I7MHRXiVKjaoS0gv
DiCvTtULLuskOpVBEgnQIZJqKcwkilpbmmAxKofsfDdMZWkLNICJwMRtiFjGnWChgN
ZlLH/IdiQ4Lvg==
Received: from customer (localhost [127.0.0.1])
by submission (posteo.de) with ESMTPSA id 4ZHLL40yW6z6twr;
Tue, 18 Mar 2025 19:42:20 +0100 (CET)
From: Philip Kaludercic <philipk@HIDDEN>
To: david <davidimagid@HIDDEN>
Subject: Re: [PATCH] package.el: Add built-in version check and active
package marking
In-Reply-To: <87wmcmdyt3.fsf@HIDDEN>
References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN>
<87ecyxxqe6.fsf@HIDDEN> <87iko9qffi.fsf@HIDDEN>
<87v7s9w1au.fsf@HIDDEN> <87wmcmdyt3.fsf@HIDDEN>
Autocrypt: addr=philipk@HIDDEN; keydata=
mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo
aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0
ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI
BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0
mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB
BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE
Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK
NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof
z4oM
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
preference=signencrypt
Date: Tue, 18 Mar 2025 18:42:19 +0000
Message-ID: <87y0x2uqno.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 76978
Cc: 76978 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>,
Stefan Monnier <monnier@HIDDEN>,
Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
david <davidimagid@HIDDEN> writes:
> Hello Philip and Emacs maintainers,
>
> I=E2=80=99m submitting this patch to enhance `describe-package` by adding
> information about the currently activated package and improving the
> built-in version check. Since "Other versions" already displays the
> current version of the package, I=E2=80=99ve added an "activated" marker =
to
> indicate which version is active in the current Emacs session.
>
> This patch for `package.el` introduces two improvements:
>
> 1. Built-in version check: The package menu now compares the built-in
> version of a package with the available version. If the available
> version is newer, the status is set to "available"; otherwise, it is
> marked as "built-in". This helps users identify when updates are
> available for built-in packages.
>
> 2. Activated packages in "Other versions": Packages listed in the
> "Other versions" section are now marked with ", activated" if they are
> currently active in the Emacs session. This makes it clear which
> versions are in use.
>
> I=E2=80=99d appreciate your feedback and suggestions for installing this =
patch
> into the master branch.
>
> Best regards,
> David D.
>
> From 8b552c182a0ba103fcad89f80abd4343b69bef9a Mon Sep 17 00:00:00 2001
> From: dimagid <dimagidve@HIDDEN>
> Date: Tue, 18 Mar 2025 13:02:40 -0400
> Subject: [PATCH] package.el: Add built-in version check and active package
> marking
>
> This commit introduces two improvements:
>
> 1. Built-in version check: The package menu now compares the built-in
> version of a package with the available version. If the available
> version is newer, the status is set to "available"; otherwise, it is
> marked as "built-in". This helps users identify when an update is
> available for built-in packages.
>
> 2. Activated packages in "Other versions": Packages listed in the "Other
> versions" section are now marked with ", activated" if they are
> currently active in the Emacs session. This provides clarity on which
> versions are in use.
Could you rewrite this to fit the commit message style described in
the CONTRIBUTE file?
> ---
> lisp/emacs-lisp/package.el | 72 ++++++++++++++++++++++++++++----------
> 1 file changed, 53 insertions(+), 19 deletions(-)
>
> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
> index b9a8dacab15..7a615be2461 100644
> --- a/lisp/emacs-lisp/package.el
> +++ b/lisp/emacs-lisp/package.el
> @@ -104,7 +104,7 @@
> ;; Vinicius Jose Latorre <viniciusjl.gnu@HIDDEN>
> ;; Phil Hagelberg <phil@HIDDEN>
>=20=20
> -;;; ToDo:
> +;;; TODO:
If possible, avoid unrelated changes in the same patch.
>=20=20
> ;; - putting info dirs at the start of the info path means
> ;; users see a weird ordering of categories. OTOH we want to
> @@ -117,7 +117,6 @@
> ;; - give users a way to view a package's documentation when it
> ;; only appears in the .el
> ;; - use/extend checkdoc so people can tell if their package will work
> -;; - "installed" instead of a blank in the status column
> ;; - tramp needs its files to be compiled in a certain order.
> ;; how to handle this? fix tramp?
> ;; - maybe we need separate .elc directories for various emacs
> @@ -1230,7 +1229,7 @@ package-tar-file-info
> ((filename (tar-header-name (car tar-parse-info))=
))
> (let ((dirname (file-name-directory filename)))
> ;; The first file can be in a subdir: look for th=
e top.
> - (if dirname (loop (directory-file-name dirname))
> + (if dirname (cl-loop (directory-file-name dirname=
))
Watch out, this is not an occurrence of cl-lib's loop, but the function
bound by named-let!
And also, if it were a instance of the old loop, this should be changed
in a separate patch.
> (file-name-as-directory filename)))))
> (desc-file (package--description-file dir-name))
> (tar-desc (tar-get-file-descriptor (concat dir-name desc-file))=
))
> @@ -2977,25 +2976,34 @@ describe-package-1
> (package--print-email-button author)))
> (let* ((all-pkgs (append (cdr (assq name package-alist))
> (cdr (assq name package-archive-contents))
> - (let ((bi (assq name package--builtins)))
> - (if bi (list (package--from-builtin bi)))=
)))
> - (other-pkgs (delete desc all-pkgs)))
> + (when-let* ((bi (assq name package--builtin=
s)))
I would prefer `and-let*' here. Also the change confuses me a bit,
could you clarify what is going on with a comment?
> + (list (package--from-builtin bi)))))
> + (other-pkgs (remove desc all-pkgs)))
> (when other-pkgs
> (package--print-help-section "Other versions"
> (mapconcat (lambda (opkg)
> (let* ((ov (package-desc-version opkg))
> - (dir (package-desc-dir opkg))
> (from (or (package-desc-archive opkg)
> - (if (stringp dir) "installed" di=
r))))
> - (if (not ov) (format "%s" from)
> - (format "%s (%s)"
> - (make-text-button (package-version-jo=
in ov) nil
> - 'font-lock-face 'li=
nk
> - 'follow-link t
> - 'action
> - (lambda (_button)
> - (describe-package=
opkg)))
> - from))))
> + (if (package-desc-dir opkg)
> + "installed" "built-in")))
> + ;; Check if the package is currently activ=
ated and
> + ;; matches the described version.
> + (activated (and (member (package-desc-name=
opkg)
> + package-activated-=
list)
> + (equal ov (package-desc-ve=
rsion desc)))))
> + (format "%s (%s%s)"
> + (if ov
> + (make-text-button (package-version-=
join ov) nil
> + 'font-lock-face '=
link
> + 'follow-link t
> + 'action
> + (lambda (_button)
> + (describe-packa=
ge opkg)))
> + from)
> + from
> + ;; Append ", activated" if the package =
is currently
> + ;; activated.
> + (if activated ", activated" ""))))
Will this formatting be clear, and not cause any confusion if there is a
package called "activated"?
> other-pkgs ", ")
> ".")))
>=20=20
> @@ -3640,11 +3648,37 @@ package-status-avail-obso
>
> ;;; Package menu printing
>=20=20
> +(defun package-menu--check-built-in-version (pkg)
> + "Check if PKG is a built-in package and compare versions.
> +Return the appropriate status for PKG."
> + (let* ((status (package-desc-status pkg))
> + (name (package-desc-name pkg))
> + (version (package-desc-version pkg))
> + ;; Check if the package is built-in by looking it up in
> + ;; `package--builtins'.
> + (built-in-pkg (assq name package--builtins))
> + ;; If the package is built-in, get its version.
> + (built-in-version (if built-in-pkg
> + (package-desc-version
> + (package--from-builtin built-in-pkg)))))
> +
> + ;; If the package is built-in and marked as "available", compare
> + ;; versions.
> + (when (and built-in-pkg
> + (equal status "available"))
> + ;; If the built-in version is older than the available version,
> + ;; keep status as "available". Otherwise, set status to
> + ;; "built-in".
> + (if (version-list-< built-in-version version)
> + (setq status "available")
> + (setq status "built-in")))
> + status))
I think you can simplify the code here by just returning the values
directly:
(cond
((not (and built-in-pkg (equal status "available")))
status)
((version-list-< built-in-version version)
"available")
("built-in"))
> +
> (defun package-menu--print-info-simple (pkg)
> "Return a package entry suitable for `tabulated-list-entries'.
> PKG is a `package-desc' object.
> Return (PKG-DESC [NAME VERSION STATUS DOC])."
> - (let* ((status (package-desc-status pkg))
> + (let* ((status (package-menu--check-built-in-version pkg))
> (face (pcase status
> ("built-in" 'package-status-built-in)
> ("external" 'package-status-external)
> @@ -3676,7 +3710,7 @@ package-menu--print-info-simple
> 'font-lock-face face)
> ,(propertize status 'font-lock-face face)
> ,(propertize (or (package-desc-archive pkg) "")
> - 'font-lock-face face)
> + 'font-lock-face face)
Again, this looks like a unrelated change?
> ,(propertize (package-desc-summary pkg)
> 'font-lock-face 'package-description)])))
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.
Received: (at 76978) by debbugs.gnu.org; 18 Mar 2025 18:34:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 18 14:34:31 2025
Received: from localhost ([127.0.0.1]:43231 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tublk-0005WG-88
for submit <at> debbugs.gnu.org; Tue, 18 Mar 2025 14:34:31 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4592)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1tubli-0005Va-6I
for 76978 <at> debbugs.gnu.org; Tue, 18 Mar 2025 14:34:26 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 67E8B442599;
Tue, 18 Mar 2025 14:34:20 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1742322859;
bh=563q4LX60KH45qMOcRIsZE5Px03aF2Nl0dKC5a/NyF8=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=D+gekcXLAZ2TyY41DRxhv1FSJCSAnWanMtZBCVi2XxIBa0AkBJP/hePwL+CEeN55H
ZxmOEa92g936v6Yqs2c9z5+m/ROldfwf1gcCg5XN3gqujvd+YSNa/yHf/Z+S0JSz2b
oQQkMtZSKbwO+wCssB0z3LXUs0lVbylhSYlrwTd72FSz/cZhrokE7pdw1aDA1318a6
2Dkdn+fQHDy/e2Jvdsp3EdSqXVPjUfKSOZcuuHY42ODyIA3yIL+yLFjioR0uvstl1w
BBUqgl/SgfEwiMxvmT0/PbUqb7WSo+A/7XZl4tPcatIS6ZKoyVd7gUZ382tB8bio5Z
cImKqPUYrocOQ==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1BBFA442595;
Tue, 18 Mar 2025 14:34:19 -0400 (EDT)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0B85012065D;
Tue, 18 Mar 2025 14:34:19 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: david <davidimagid@HIDDEN>
Subject: Re: [PATCH] package.el: Add built-in version check and active
package marking
In-Reply-To: <87wmcmdyt3.fsf@HIDDEN> (david's message of "Tue, 18 Mar 2025
13:38:16 -0400")
Message-ID: <jwv34faxl80.fsf-monnier+emacs@HIDDEN>
References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN>
<87ecyxxqe6.fsf@HIDDEN> <87iko9qffi.fsf@HIDDEN>
<87v7s9w1au.fsf@HIDDEN> <87wmcmdyt3.fsf@HIDDEN>
Date: Tue, 18 Mar 2025 14:34:18 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.212 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 76978
Cc: Philip Kaludercic <philipk@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
76978 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> 1. Built-in version check: The package menu now compares the built-in
> version of a package with the available version. If the available
> version is newer, the status is set to "available"; otherwise, it is
> marked as "built-in". This helps users identify when updates are
> available for built-in packages.
[ I can't remember enough of the details about this
part of the UI to have an opinion on that. ]
> 2. Activated packages in "Other versions": Packages listed in the
> "Other versions" section are now marked with ", activated" if they are
> currently active in the Emacs session. This makes it clear which
> versions are in use.
Nice!
The commit message lacks the ChangeLog-style itemized changes.
See further comments below.
Also, I can't see your name in the list of people who signed the
copyright paperwork. Are you already in the process of doing that?
> @@ -1230,7 +1229,7 @@ package-tar-file-info
> ((filename (tar-header-name (car tar-parse-info))=
))
> (let ((dirname (file-name-directory filename)))
> ;; The first file can be in a subdir: look for th=
e top.
> - (if dirname (loop (directory-file-name dirname))
> + (if dirname (cl-loop (directory-file-name dirname=
))
> (file-name-as-directory filename)))))
> (desc-file (package--description-file dir-name))
> (tar-desc (tar-get-file-descriptor (concat dir-name desc-file))=
))
This doesn't look right: `loop` is a locally defined function.
> (from (or (package-desc-archive opkg)
> - (if (stringp dir) "installed" di=
r))))
> + (if (package-desc-dir opkg)
> + "installed" "built-in")))
Any reason you dropped the `stringp` test?
> + ;; Check if the package is currently activ=
ated and
> + ;; matches the described version.
> + (activated (and (member (package-desc-name=
opkg)
> + package-activated-=
list)
> + (equal ov (package-desc-ve=
rsion desc)))))
`desc` is not necessarily the package that is currently activated, so
I don't understand the `equal` test here.
Also, AFAICT, this goes past the 80 columns limit, please try and change
the layout to stay within 80 columns.
> - (if (not ov) (format "%s" from)
> - (format "%s (%s)"
> - (make-text-button (package-version-jo=
in ov) nil
> - 'font-lock-face 'li=
nk
> - 'follow-link t
> - 'action
> - (lambda (_button)
> - (describe-package=
opkg)))
> - from))))
> + (format "%s (%s%s)"
> + (if ov
> + (make-text-button (package-version-=
join ov) nil
> + 'font-lock-face '=
link
> + 'follow-link t
> + 'action
> + (lambda (_button)
> + (describe-packa=
ge opkg)))
> + from)
> + from
> + ;; Append ", activated" if the package =
is currently
> + ;; activated.
> + (if activated ", activated" ""))))
If `ov` is nil, we'll get FROM displayed twice. =F0=9F=99=81
Stefan
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.
Received: (at 76978) by debbugs.gnu.org; 18 Mar 2025 17:38:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 18 13:38:39 2025
Received: from localhost ([127.0.0.1]:43024 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tuatd-0005lk-UZ
for submit <at> debbugs.gnu.org; Tue, 18 Mar 2025 13:38:39 -0400
Received: from mail-vk1-xa30.google.com ([2607:f8b0:4864:20::a30]:52477)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <davidimagid@HIDDEN>)
id 1tuata-0005l2-Rp
for 76978 <at> debbugs.gnu.org; Tue, 18 Mar 2025 13:38:31 -0400
Received: by mail-vk1-xa30.google.com with SMTP id
71dfb90a1353d-51eb181331bso2920210e0c.0
for <76978 <at> debbugs.gnu.org>; Tue, 18 Mar 2025 10:38:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1742319505; x=1742924305; darn=debbugs.gnu.org;
h=mime-version:message-id:date:user-agent:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=W3yKUk4GZBSLTDu+Fpg9VMboIF8zHySJg/mU1Q4gdAc=;
b=m0u//N7bmUNqSwTIAyFJC9iDoxqkE0vWR/MG0jSUNfCjUkUp3lyde5PhLvvUhCjNyy
XaOCdOME+vkMjc1K4PYTmzYq1FzfVdp12eTFxPNgPlg556QRJ9+YdTD5yTYm8oQnhKcB
PertJiIyfdyE6wFjmd+9ksnaAImiOmwbnTWfmJceC+uaop8bl/99omYq/b4BDPVmiL8h
4S5kVqGx8leEiNUkdzjfRBnQycYBNpEhe+h3HBw4A58BSrtJpWdlpqPzo52VNn6CMnhj
a/SvtULfTDU0s4TFg72ih7wBS5HTdNtNVufaPpDNUIkZf1sXk6Qrh+b8MqA8WmiTA3i6
iCjQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1742319505; x=1742924305;
h=mime-version:message-id:date:user-agent:references:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=W3yKUk4GZBSLTDu+Fpg9VMboIF8zHySJg/mU1Q4gdAc=;
b=i97UlBs75/H4uwqJKVWBA9prpTPjy5LESITqEaVF7jPGwxVtUjuPv8CPuhDSXBK9kN
/2mRjIqvkQx9Hyh7RnvLa2lHnylHA19HGn7ueJ7FLPhLgjxGX8l1X57NLAUP3UexQsMU
JL4lEzZzo/rKfV8tCQwCic45R8skPC4M/vqL7ruA9VeVw9ES30bADr8bormPT7E7sDqf
KBaxprnV9Ycb9gFIZ30EQvVH2CXJSxTgPJ1kl7JaMZ83vk66An4pa2AmH9hSo+56Czld
MylAB4c2kw79THzuc855nSm/OWK6zQsRyAD8bZchLDmiM5xmIglbSLNeUZT2FTj3gpqJ
mLag==
X-Gm-Message-State: AOJu0Yxqaok2SjXNYsK+I6GprGcuWsm7DdG3e7AWKf7wqWsYy0n66dfU
NudfZV6Hws7k4wiQy9m19y2rGMT2zdk3EX7s00yhLNFDIyMrdbNW
X-Gm-Gg: ASbGncsxWd6yQGwvThyP3im2IdIPozbjWEI7dqzM3MpmX9vNKGsdiPZnV5PrzjQOqVs
N0FXtNn+ph/vo0s+jLTtpEWKFTsTUzFTlHTa/HxJVkWWT6lnjD7AZj/f1enZkr3xqsgUxLSQn8p
4HdCNkAwBYLuwV/fQOdEudZrumXhlZK70TmKecwUxz7Ujl4mwd1DLQYxnQQpP3UkqCMGjyf0H3m
AILTdfIOKNSgvse2p708jUMN6von6vFrBMD7s8Cv8ZNSBTxCs5r/L6oXsEwiQQLS2OJR0O7AI2k
OHORmWD1nIvkGuuY6THzRgFjsT2/TSNHpCEALg==
X-Google-Smtp-Source: AGHT+IFhFovvCJwuwcbK5DUOUcUeD2lYH/tbHglmo0LXOdS+rjp3s5jQqU5vqURToUWiePjR0cvuzg==
X-Received: by 2002:a05:6122:489a:b0:520:3987:ce0b with SMTP id
71dfb90a1353d-52449872c90mr13612199e0c.2.1742319504959;
Tue, 18 Mar 2025 10:38:24 -0700 (PDT)
Received: from fedora ([190.6.18.153]) by smtp.gmail.com with ESMTPSA id
71dfb90a1353d-5243a5a1f2fsm2142408e0c.14.2025.03.18.10.38.23
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 18 Mar 2025 10:38:24 -0700 (PDT)
From: david <davidimagid@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
Subject: [PATCH] package.el: Add built-in version check and active package
marking
In-Reply-To: <87v7s9w1au.fsf@HIDDEN>
References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN>
<87ecyxxqe6.fsf@HIDDEN> <87iko9qffi.fsf@HIDDEN>
<87v7s9w1au.fsf@HIDDEN>
User-Agent: mu4e 1.12.8; emacs 31.0.50
Date: Tue, 18 Mar 2025 13:38:16 -0400
Message-ID: <87wmcmdyt3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76978
Cc: 76978 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>,
Stefan Monnier <monnier@HIDDEN>,
Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Hello Philip and Emacs maintainers,
I=E2=80=99m submitting this patch to enhance `describe-package` by adding
information about the currently activated package and improving the
built-in version check. Since "Other versions" already displays the
current version of the package, I=E2=80=99ve added an "activated" marker to
indicate which version is active in the current Emacs session.
This patch for `package.el` introduces two improvements:
1. Built-in version check: The package menu now compares the built-in
version of a package with the available version. If the available
version is newer, the status is set to "available"; otherwise, it is
marked as "built-in". This helps users identify when updates are
available for built-in packages.
2. Activated packages in "Other versions": Packages listed in the
"Other versions" section are now marked with ", activated" if they are
currently active in the Emacs session. This makes it clear which
versions are in use.
I=E2=80=99d appreciate your feedback and suggestions for installing this pa=
tch
into the master branch.
Best regards,
David D.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-package.el-Add-built-in-version-check-and-active-pac.patch
Content-Description: package.el: Add built-in version check and active package marking
From 8b552c182a0ba103fcad89f80abd4343b69bef9a Mon Sep 17 00:00:00 2001
From: dimagid <dimagidve@HIDDEN>
Date: Tue, 18 Mar 2025 13:02:40 -0400
Subject: [PATCH] package.el: Add built-in version check and active package
marking
This commit introduces two improvements:
1. Built-in version check: The package menu now compares the built-in
version of a package with the available version. If the available
version is newer, the status is set to "available"; otherwise, it is
marked as "built-in". This helps users identify when an update is
available for built-in packages.
2. Activated packages in "Other versions": Packages listed in the "Other
versions" section are now marked with ", activated" if they are
currently active in the Emacs session. This provides clarity on which
versions are in use.
---
lisp/emacs-lisp/package.el | 72 ++++++++++++++++++++++++++++----------
1 file changed, 53 insertions(+), 19 deletions(-)
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index b9a8dacab15..7a615be2461 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -104,7 +104,7 @@
;; Vinicius Jose Latorre <viniciusjl.gnu@HIDDEN>
;; Phil Hagelberg <phil@HIDDEN>
-;;; ToDo:
+;;; TODO:
;; - putting info dirs at the start of the info path means
;; users see a weird ordering of categories. OTOH we want to
@@ -117,7 +117,6 @@
;; - give users a way to view a package's documentation when it
;; only appears in the .el
;; - use/extend checkdoc so people can tell if their package will work
-;; - "installed" instead of a blank in the status column
;; - tramp needs its files to be compiled in a certain order.
;; how to handle this? fix tramp?
;; - maybe we need separate .elc directories for various emacs
@@ -1230,7 +1229,7 @@ package-tar-file-info
((filename (tar-header-name (car tar-parse-info))))
(let ((dirname (file-name-directory filename)))
;; The first file can be in a subdir: look for the top.
- (if dirname (loop (directory-file-name dirname))
+ (if dirname (cl-loop (directory-file-name dirname))
(file-name-as-directory filename)))))
(desc-file (package--description-file dir-name))
(tar-desc (tar-get-file-descriptor (concat dir-name desc-file))))
@@ -2977,25 +2976,34 @@ describe-package-1
(package--print-email-button author)))
(let* ((all-pkgs (append (cdr (assq name package-alist))
(cdr (assq name package-archive-contents))
- (let ((bi (assq name package--builtins)))
- (if bi (list (package--from-builtin bi))))))
- (other-pkgs (delete desc all-pkgs)))
+ (when-let* ((bi (assq name package--builtins)))
+ (list (package--from-builtin bi)))))
+ (other-pkgs (remove desc all-pkgs)))
(when other-pkgs
(package--print-help-section "Other versions"
(mapconcat (lambda (opkg)
(let* ((ov (package-desc-version opkg))
- (dir (package-desc-dir opkg))
(from (or (package-desc-archive opkg)
- (if (stringp dir) "installed" dir))))
- (if (not ov) (format "%s" from)
- (format "%s (%s)"
- (make-text-button (package-version-join ov) nil
- 'font-lock-face 'link
- 'follow-link t
- 'action
- (lambda (_button)
- (describe-package opkg)))
- from))))
+ (if (package-desc-dir opkg)
+ "installed" "built-in")))
+ ;; Check if the package is currently activated and
+ ;; matches the described version.
+ (activated (and (member (package-desc-name opkg)
+ package-activated-list)
+ (equal ov (package-desc-version desc)))))
+ (format "%s (%s%s)"
+ (if ov
+ (make-text-button (package-version-join ov) nil
+ 'font-lock-face 'link
+ 'follow-link t
+ 'action
+ (lambda (_button)
+ (describe-package opkg)))
+ from)
+ from
+ ;; Append ", activated" if the package is currently
+ ;; activated.
+ (if activated ", activated" ""))))
other-pkgs ", ")
".")))
@@ -3640,11 +3648,37 @@ package-status-avail-obso
;;; Package menu printing
+(defun package-menu--check-built-in-version (pkg)
+ "Check if PKG is a built-in package and compare versions.
+Return the appropriate status for PKG."
+ (let* ((status (package-desc-status pkg))
+ (name (package-desc-name pkg))
+ (version (package-desc-version pkg))
+ ;; Check if the package is built-in by looking it up in
+ ;; `package--builtins'.
+ (built-in-pkg (assq name package--builtins))
+ ;; If the package is built-in, get its version.
+ (built-in-version (if built-in-pkg
+ (package-desc-version
+ (package--from-builtin built-in-pkg)))))
+
+ ;; If the package is built-in and marked as "available", compare
+ ;; versions.
+ (when (and built-in-pkg
+ (equal status "available"))
+ ;; If the built-in version is older than the available version,
+ ;; keep status as "available". Otherwise, set status to
+ ;; "built-in".
+ (if (version-list-< built-in-version version)
+ (setq status "available")
+ (setq status "built-in")))
+ status))
+
(defun package-menu--print-info-simple (pkg)
"Return a package entry suitable for `tabulated-list-entries'.
PKG is a `package-desc' object.
Return (PKG-DESC [NAME VERSION STATUS DOC])."
- (let* ((status (package-desc-status pkg))
+ (let* ((status (package-menu--check-built-in-version pkg))
(face (pcase status
("built-in" 'package-status-built-in)
("external" 'package-status-external)
@@ -3676,7 +3710,7 @@ package-menu--print-info-simple
'font-lock-face face)
,(propertize status 'font-lock-face face)
,(propertize (or (package-desc-archive pkg) "")
- 'font-lock-face face)
+ 'font-lock-face face)
,(propertize (package-desc-summary pkg)
'font-lock-face 'package-description)])))
--
2.48.1
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.Received: (at 76978) by debbugs.gnu.org; 16 Mar 2025 13:30:29 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 16 09:30:29 2025 Received: from localhost ([127.0.0.1]:46181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tto4T-0004XO-2D for submit <at> debbugs.gnu.org; Sun, 16 Mar 2025 09:30:29 -0400 Received: from mout01.posteo.de ([185.67.36.65]:42763) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <philipk@HIDDEN>) id 1tto4Q-0004VU-1L for 76978 <at> debbugs.gnu.org; Sun, 16 Mar 2025 09:30:27 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id DCFEF240027 for <76978 <at> debbugs.gnu.org>; Sun, 16 Mar 2025 14:30:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1742131818; bh=hUWp9L67S0jUAGDCE9imcSYufwLGmAvYaxQdvqrluj4=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=L/MD6oLyDtn+5hS1/HOsH2tznLXPWl6Lh2s87/Lw5iG8mjE1kp20ZaJXm+gbR3Woc 2C2C8VFHu8WKWSwvZogY4c5wn0Du7fBbO9O23+Pam6YFQ5f6387axsvPetFDIhgg2s /vO/Ho1Uwfpi2VzskK5eLLr41jLLqBAdfdL8dX2RZZesY3U8OpWWndjN3NuQVStlWF P300w2cVPvsb+IPZ39Cx9uTY1yC9g2ZfnDKIDYysZ9oCBPeSZoRx5qyJPZFCaibhAh B4NeO1KqRrCS9hxX4nrQp1QAdPm/4VJZQld34/JCha4EAmcZ7pbG8NjIe971cdncTf 8uUlHft3a8/8g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4ZFzVx2LbPz6tsb; Sun, 16 Mar 2025 14:30:17 +0100 (CET) From: Philip Kaludercic <philipk@HIDDEN> To: david <davidimagid@HIDDEN> Subject: Re: bug#76978: 31.0.50; Archive information not displayed for installed packages in *Packages* buffer In-Reply-To: <87iko9qffi.fsf@HIDDEN> References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN> <87ecyxxqe6.fsf@HIDDEN> <87iko9qffi.fsf@HIDDEN> Autocrypt: addr=philipk@HIDDEN; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Sun, 16 Mar 2025 13:30:17 +0000 Message-ID: <87v7s9w1au.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76978 Cc: 76978 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) david <davidimagid@HIDDEN> writes: > Philip Kaludercic <philipk@HIDDEN> writes: > >> (Tip: When creating a bug report that you assume specific people are >> interested in, adding a X-Debuggs-CC header will send the people a >> message and add them directly to the CCs.) >> > Got it, thanks for the tip! > >> david <davidimagid@HIDDEN> writes: >> >>> When a package is installed or is a dependency, the "Archive" column in >>> the *Packages* buffer does not display the archive information. This >>> happens because the function `describe-package-1` in `package.el` skips >>> the Archive section for installed packages due to the following >>> conditional check: >>> >>> (unless (and pkg-dir (not archive)) ; Installed pkgs don't have archive. >>> (package--print-help-section "Archive" >>> (or archive "n/a"))) >>> >>> The expected behavior is that the "Archive" column should display the >>> archive name (e.g., "gnu", "nongnu", "other unofficial archive") for >>> packages in the installed or dependency status. This would be helpful >>> because: >>> >>> 1. Traceability: It would allow users to easily identify the source archive >>> of a package, which is useful for debugging, auditing, and understanding >>> the package's origin. >>> >>> 2. Security: It would provide users with additional context about the >>> package's source, helping them make informed decisions about the code >>> they use. >>> >>> 3. Consistency: Archive information is part of the package metadata, and >>> displaying it consistently would improve the user experience by making >>> this information readily available. >>> >>> Currently, the archive information is not displayed for installed or >>> dependency packages, which makes it harder to track the source of these >>> packages. This behavior is implemented in the `describe-package-1` >>> function in `package.el`, starting around line 2890. A review of this >>> behavior would be appreciated to ensure users have access to this helpful >>> metadata. >> >> As mentioned in another thread, my suggestion to solve this issue is to >> track the installation-source in the `package-desc-extras' plist. This >> seems to be the least invasive approach I can think of, which should be >> simple to implement. >> >> The question then is how and where to display the installation-source?. >> > Agreed, storing the source in `package-desc-extras` is clean and > practical. Displaying it in the "Archive" column makes sense. As long as it doesn't get cramped, that should be fine. Mentioning it in the describe-package buffer would be useful as well. > Is there > a development branch for `package.el`, or should I create a feature > branch from `master`? There is no special branch, master is fine. Thanks!
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.
Received: (at 76978) by debbugs.gnu.org; 16 Mar 2025 13:22:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 16 09:22:09 2025
Received: from localhost ([127.0.0.1]:46119 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ttnwP-000353-DR
for submit <at> debbugs.gnu.org; Sun, 16 Mar 2025 09:22:09 -0400
Received: from mail-vk1-xa36.google.com ([2607:f8b0:4864:20::a36]:47248)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <davidimagid@HIDDEN>)
id 1ttnwM-00033p-Ot
for 76978 <at> debbugs.gnu.org; Sun, 16 Mar 2025 09:22:07 -0400
Received: by mail-vk1-xa36.google.com with SMTP id
71dfb90a1353d-52403e39a23so3169076e0c.2
for <76978 <at> debbugs.gnu.org>; Sun, 16 Mar 2025 06:22:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1742131321; x=1742736121; darn=debbugs.gnu.org;
h=mime-version:message-id:date:user-agent:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=7ucw9tF0GNSh0dUKL0VHamqamj+noWjR2uPGK+17XQY=;
b=k2pKQEw5g//dZD5cNzlLfcjf5FJZXW5XZwm9wRpqf1gvdXViw6OwPayItXlUPebh1N
FMi4qCytgvBWcrLUCBPG5NGxH+VRR1aP/3+QrmzLcqS/1+jFiaVKNs2gITSBUsDjUA9u
v9lE9lzGER2ubiojVqxIYxVJwHfBakEEAkOfA4W6bnghXntIfw+vo+XAmMyRHLsrkoXX
tVvyX/nPimqDzaoW/c6wpFy9MNwlvQv0Vah6koUmni8EA9YdNF6ZWimVJkRuDCcRIGLg
BQZNIHflF01n5uQP1AR5JoaX9VmKQ8ITQP06qdHd2k3lUZbR6JeV7XqTk1NeFTC/h4Zs
umYQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1742131321; x=1742736121;
h=mime-version:message-id:date:user-agent:references:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=7ucw9tF0GNSh0dUKL0VHamqamj+noWjR2uPGK+17XQY=;
b=N1Eo1n8nJiA00iHuc4amYYF/PcYWp7zc4SxloAJOy/ARdQyRTz68q5pQvyni0GOZVG
HXEt8KduNZTHc01GpwGm/LZMhjK0m+HYt1UNg9ZxuPto1OQ6PqknijD1AGbY8ulgLvrT
lXwNJUA37623YTdkNpZaPbEv9ZpxMJVizvaZaV105laZIRPcC8u5VGClyRCKqSYZUW0V
2EL9uZNzw3qbaem7dhqw83S9Cz36POxgcSXVh3tqVtG3hO6LShIjeeACxByVk05GnCIq
6eHgHwMhHM2GKmT038F13VyO18VeZXzrCXeTRdAYzyjIT4oft9iIesXewrCp19yvtvoG
xZzQ==
X-Gm-Message-State: AOJu0YzJb4IihCmP+QM6xKsC0+kDGVMMgDty+JEngGU0sD1ZQNqrjg7m
I58rY0XCiV+6KF3MQIUsyhPw0lVQxjFx3m7rQ5UzOetZCQY9E1WD0uj1Cg==
X-Gm-Gg: ASbGnctaQLdB/Wj3923eDBWR4bTT/NmkgPmphQIJcFJzVY2AXFmpRqfA6WMdoT9qnV9
CnwvCGHWf34pwpzxA9vP8DyAJSPHQvxZtY5CzXLj5v5Q5G15ASht//6P8AXBv2rNcXwDrStjfMy
7yszjIYK+kj74xYHPcYAhch6U0TSg3J3Z2iPj32uF35YJItcPaOtg0Fla0xAPBnW/IRcoGl9gkp
OJY20IUmXBZqTWfddX4miAhpGn4v1BspX814yjOy48zakkv0NjhpLmSPYv8HGAMykdOpzlEbd5j
XxhqW2AC0tzpLEgJwfCzY7WYel+4Avc6JWuqYxaf
X-Google-Smtp-Source: AGHT+IEElALJj7xkFCpthH/y6VtkTib5PIXR6Zr/oZkZTFkL04ZlQzqEC84nbWTIunpwqgJg2lrt7w==
X-Received: by 2002:a05:6122:8d6:b0:523:e2bd:b937 with SMTP id
71dfb90a1353d-5244989f8c3mr5987800e0c.3.1742131320834;
Sun, 16 Mar 2025 06:22:00 -0700 (PDT)
Received: from fedora ([190.153.17.169]) by smtp.gmail.com with ESMTPSA id
71dfb90a1353d-5243a581ecfsm1240474e0c.2.2025.03.16.06.21.58
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 16 Mar 2025 06:21:59 -0700 (PDT)
From: david <davidimagid@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
Subject: Re: bug#76978: 31.0.50; Archive information not displayed for
installed packages in *Packages* buffer
In-Reply-To: <87ecyxxqe6.fsf@HIDDEN>
References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN>
<87ecyxxqe6.fsf@HIDDEN>
User-Agent: mu4e 1.12.8; emacs 31.0.50
Date: Sun, 16 Mar 2025 09:21:37 -0400
Message-ID: <87iko9qffi.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 3.6 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Philip Kaludercic writes: > (Tip: When creating a bug report
that you assume specific people are > interested in, adding a X-Debuggs-CC
header will send the people a > message and add them directly to the CCs.)
> Got it, thank [...]
Content analysis details: (3.6 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS
[190.153.17.169 listed in zen.spamhaus.org]
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (davidimagid[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [2607:f8b0:4864:20:0:0:0:a36 listed in]
[list.dnswl.org]
X-Debbugs-Envelope-To: 76978
Cc: 76978 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.6 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Philip Kaludercic writes: > (Tip: When creating a bug report
that you assume specific people are > interested in, adding a X-Debuggs-CC
header will send the people a > message and add them directly to the CCs.)
> Got it, thank [...]
Content analysis details: (2.6 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS
[190.153.17.169 listed in zen.spamhaus.org]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[2607:f8b0:4864:20:0:0:0:a36 listed in]
[list.dnswl.org]
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (davidimagid[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
Philip Kaludercic <philipk@HIDDEN> writes:
> (Tip: When creating a bug report that you assume specific people are
> interested in, adding a X-Debuggs-CC header will send the people a
> message and add them directly to the CCs.)
>
Got it, thanks for the tip!
> david <davidimagid@HIDDEN> writes:
>
>> When a package is installed or is a dependency, the "Archive" column in
>> the *Packages* buffer does not display the archive information. This
>> happens because the function `describe-package-1` in `package.el` skips
>> the Archive section for installed packages due to the following
>> conditional check:
>>
>> (unless (and pkg-dir (not archive)) ; Installed pkgs don't have archive.
>> (package--print-help-section "Archive"
>> (or archive "n/a")))
>>
>> The expected behavior is that the "Archive" column should display the
>> archive name (e.g., "gnu", "nongnu", "other unofficial archive") for
>> packages in the installed or dependency status. This would be helpful
>> because:
>>
>> 1. Traceability: It would allow users to easily identify the source archive
>> of a package, which is useful for debugging, auditing, and understanding
>> the package's origin.
>>
>> 2. Security: It would provide users with additional context about the
>> package's source, helping them make informed decisions about the code
>> they use.
>>
>> 3. Consistency: Archive information is part of the package metadata, and
>> displaying it consistently would improve the user experience by making
>> this information readily available.
>>
>> Currently, the archive information is not displayed for installed or
>> dependency packages, which makes it harder to track the source of these
>> packages. This behavior is implemented in the `describe-package-1`
>> function in `package.el`, starting around line 2890. A review of this
>> behavior would be appreciated to ensure users have access to this helpful
>> metadata.
>
> As mentioned in another thread, my suggestion to solve this issue is to
> track the installation-source in the `package-desc-extras' plist. This
> seems to be the least invasive approach I can think of, which should be
> simple to implement.
>
> The question then is how and where to display the installation-source?.
>
Agreed, storing the source in `package-desc-extras` is clean and
practical. Displaying it in the "Archive" column makes sense. Is there
a development branch for `package.el`, or should I create a feature
branch from `master`?
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.Received: (at 76978) by debbugs.gnu.org; 16 Mar 2025 09:43:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 16 05:43:12 2025 Received: from localhost ([127.0.0.1]:45480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ttkWW-0001mo-8m for submit <at> debbugs.gnu.org; Sun, 16 Mar 2025 05:43:12 -0400 Received: from mout02.posteo.de ([185.67.36.66]:51159) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <philipk@HIDDEN>) id 1ttkWR-0001lO-Vq for 76978 <at> debbugs.gnu.org; Sun, 16 Mar 2025 05:43:10 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E803B240101 for <76978 <at> debbugs.gnu.org>; Sun, 16 Mar 2025 10:42:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1742118180; bh=hyuSons8CI+uz+XCnlcuIq1NayO2DYvRWSuMjTMQXQs=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=gmLkrrhPAZtQ8k7uKr5SLoA2WIOceEJfXLaLXrCVHIm7fzECGFPWspQJQde+/NGk5 xiaV3oKgVAS6iZN0IeDwG7PYZP4rNtGFoF9ZuS/Koe36oU8pdfquPnIdy0PxyQtDAm cuw8Tmvak35rhJq4ICwvJdCQaQ5Ejco/YP+pUQ+hbRUqChDrNIyG8JvPQrl76w6aZB 7NJDaKuAckokygMjLHxmpybnfIXUKvZAV4nSsCmhMKGuE6mimDT9+S3OWuX0Bat/gp JmlWSStJ1p5uWLzla7fnWFuQZV4I51KN8jqimyzi3pu2B90aozxZvvbmnEexNP4o3L khKUWtHKh4evQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4ZFtSg1YX2z9rxD; Sun, 16 Mar 2025 10:42:57 +0100 (CET) From: Philip Kaludercic <philipk@HIDDEN> To: david <davidimagid@HIDDEN> Subject: Re: bug#76978: 31.0.50; Archive information not displayed for installed packages in *Packages* buffer In-Reply-To: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN> References: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN> Autocrypt: addr=philipk@HIDDEN; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Sun, 16 Mar 2025 09:42:57 +0000 Message-ID: <87ecyxxqe6.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76978 Cc: 76978 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) (Tip: When creating a bug report that you assume specific people are interested in, adding a X-Debuggs-CC header will send the people a message and add them directly to the CCs.) david <davidimagid@HIDDEN> writes: > When a package is installed or is a dependency, the "Archive" column in > the *Packages* buffer does not display the archive information. This > happens because the function `describe-package-1` in `package.el` skips > the Archive section for installed packages due to the following > conditional check: > > (unless (and pkg-dir (not archive)) ; Installed pkgs don't have archive. > (package--print-help-section "Archive" > (or archive "n/a"))) > > The expected behavior is that the "Archive" column should display the > archive name (e.g., "gnu", "nongnu", "other unofficial archive") for > packages in the installed or dependency status. This would be helpful > because: > > 1. Traceability: It would allow users to easily identify the source archive > of a package, which is useful for debugging, auditing, and understanding > the package's origin. > > 2. Security: It would provide users with additional context about the > package's source, helping them make informed decisions about the code > they use. > > 3. Consistency: Archive information is part of the package metadata, and > displaying it consistently would improve the user experience by making > this information readily available. > > Currently, the archive information is not displayed for installed or > dependency packages, which makes it harder to track the source of these > packages. This behavior is implemented in the `describe-package-1` > function in `package.el`, starting around line 2890. A review of this > behavior would be appreciated to ensure users have access to this helpful > metadata. As mentioned in another thread, my suggestion to solve this issue is to track the installation-source in the `package-desc-extras' plist. This seems to be the least invasive approach I can think of, which should be simple to implement. The question then is how and where to display the installation-source?. > > In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version > 3.24.43, cairo version 1.18.2) of 2025-02-26 built on fedora > Repository revision: 8c165834913bb0dca214acc4b82ba1d9d4ac0a82 > Repository branch: master > System Description: Fedora Linux 41 (Workstation Edition) > > Configured using: > 'configure --with-imagemagick --with-pgtk --with-tree-sitter > --with-mailutils --with-sound=yes --with-pdumper=yes > --with-dumping=pdumper --with-file-notification=yes' > > Configured features: > ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ > IMAGEMAGICK JPEG LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES > NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 > THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB > > Important settings: > value of $LANG: en_US.UTF-8 > value of $XMODIFIERS: @im=ibus > locale-coding-system: utf-8-unix > > Major mode: Lisp Interaction > > Minor modes in effect: > tooltip-mode: t > global-eldoc-mode: t > eldoc-mode: t > show-paren-mode: t > electric-indent-mode: t > mouse-wheel-mode: t > tool-bar-mode: t > menu-bar-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > blink-cursor-mode: t > minibuffer-regexp-mode: t > line-number-mode: t > indent-tabs-mode: t > transient-mark-mode: t > auto-composition-mode: t > auto-encryption-mode: t > auto-compression-mode: t > > Load-path shadows: > None found. > > Features: > (shadow sort mail-extr emacsbug lisp-mnt mm-archive message sendmail > yank-media dired dired-loaddefs rfc822 mml mml-sec epa derived gnus-util > time-date mailabbrev gmm-utils mailheader mm-decode mm-bodies mm-encode > mail-utils mule-util cus-edit pp cus-start cus-load wid-edit gnutls > network-stream url-cache url-http url-auth mail-parse rfc2231 rfc2047 > rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm puny compile > text-property-search comint ansi-osc ansi-color ring comp-run > comp-common rx epg rfc6068 epg-config display-line-numbers finder-inf > package browse-url xdg url url-proxy url-privacy url-expand url-methods > url-history url-cookie generate-lisp-file url-domsuf url-util mailcap > url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs icons > password-cache json subr-x map byte-opt gv bytecomp byte-compile > url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren > electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel > term/pgtk-win pgtk-win term/common-win touch-screen pgtk-dnd tool-bar > dnd fontset image regexp-opt fringe tabulated-list replace newcomment > text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow > isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax > font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic > indonesian philippine cham georgian utf-8-lang misc-lang vietnamese > tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek > romanian slovak czech european ethiopic indian cyrillic chinese > composite emoji-zwj charscript charprop case-table epa-hook > jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs > theme-loaddefs faces cus-face macroexp files window text-properties > overlay sha1 md5 base64 format env code-pages mule custom widget keymap > hashtable-print-readable backquote threads dbusbind inotify > dynamic-setting system-font-setting font-render-setting cairo gtk pgtk > multi-tty move-toolbar make-network-process tty-child-frames > native-compile emacs) > > Memory information: > ((conses 16 309513 44932) (symbols 48 11458 0) (strings 32 55510 3235) > (string-bytes 1 1431141) (vectors 16 20605) > (vector-slots 8 250601 12665) (floats 8 225 47) > (intervals 56 25047 0) (buffers 992 12))
bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 12 Mar 2025 13:24:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 12 09:24:04 2025
Received: from localhost ([127.0.0.1]:47951 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tsM43-00073E-3C
for submit <at> debbugs.gnu.org; Wed, 12 Mar 2025 09:24:03 -0400
Received: from lists.gnu.org ([2001:470:142::17]:52700)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <davidimagid@HIDDEN>)
id 1tsM3y-00072a-D4
for submit <at> debbugs.gnu.org; Wed, 12 Mar 2025 09:23:59 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <davidimagid@HIDDEN>)
id 1tsM3q-0005Ow-Il
for bug-gnu-emacs@HIDDEN; Wed, 12 Mar 2025 09:23:50 -0400
Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <davidimagid@HIDDEN>)
id 1tsM3n-0001mk-NH
for bug-gnu-emacs@HIDDEN; Wed, 12 Mar 2025 09:23:50 -0400
Received: by mail-ed1-x52d.google.com with SMTP id
4fb4d7f45d1cf-5e5c9662131so10208357a12.3
for <bug-gnu-emacs@HIDDEN>; Wed, 12 Mar 2025 06:23:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1741785825; x=1742390625; darn=gnu.org;
h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
:date:message-id:reply-to;
bh=ze2W8AmqY3WfdAxG0RniftWqloO2P5r8wqmP1OUXETQ=;
b=eZGxLmHcOKcqrfNYpjcXVloxZ2UOgxdFyfca0pS3fi9VQf9XPbSMmQms8SZE58Om9u
lZPRFX6uqVsMU84gDc1LL+Q9k6c5S4ir9o+fu/GQnSic6slrzftf5RHyeYHbfRPTIi3b
+Fk2+tTLVI7NYZkjHAjYjnu+81Pf2R5Ec1H+xB9DCNHQHMicds28tU+vjgV4/xjUMnM5
xG0wlfQx7MHVDYwnCe16FLU7pvuowcIhmbcDm3B6MgXsaFC+Qeb1Ja0asHvNv3XD2qLQ
CqtjIynCi8YHNQZ5lrWPeUAWmsUi9ONs7gZJkBVTK6SFBusZyZv23OC64Q4gOnygUmW9
GyEA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1741785825; x=1742390625;
h=to:subject:message-id:date:from:mime-version:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=ze2W8AmqY3WfdAxG0RniftWqloO2P5r8wqmP1OUXETQ=;
b=lv+MJ9sCzJduwIQ3GVqPeGriyO+7HnZwBvv3O+wep31EWJ9ZkyyGuTzzfCJd9Y3yHJ
xeZQPyIzVan0TPv3mZhf6cqaT6UUV7Oo0ujqXb6kqcbUzAZF8PwSTOvg3GMDLzUMh9md
U3kFwJ5zEX/85d7H80yCoP4U3pI9g1yfmR4q8rKN3ix4QiouU+PApjilx/8a4cMI8OT8
sCoLEmBa5zOONaXmxyU4cU5q62G8/2IngT8EOf4rPV5dconhr5ibdORJIgZrFTSQmKFk
eCCrpzn39FuSTgimR/bK/UGmahWlAoraDJhDGHt/bb5mtyXNWc2czdh+B2MvbLHVNsWQ
eS7Q==
X-Gm-Message-State: AOJu0YwuDluCDd7Yg+uNWSNjUlWVvEdeYAcN2fGPTcLcmUXmaqY8x2iK
3XqW5lqE+2cVqjmcsFaApPBNLdTpYqxrBWQkGlAppR7FWoHowSRkTlfRW9xqEToXE+qcM01Oo3h
Id8/B3vetz2XSs4c9cv4jDYbYL8VCihRA
X-Gm-Gg: ASbGncu1NZ8H4aR8dYiaezGwmQ5ConKqDy2m9K1L8GLqopgJrpLGPARnvg75I4GFVi2
mH02OlvbgzpqnOe5mdjN2tvuUOcabxfYQAG6YnnMcBltNjWLpTbTRfvdiwZkvN2HkmuqMD6rla4
S56XZqTa+5iGJWCVep+zVMVFPV
X-Google-Smtp-Source: AGHT+IHr7F6ZhSLcLAMfbD7VliS4CNjRNeZdpIkZk9KdOec9sEHrZGM+2P8Dn7zlbt/J9xhUwqR8EFchGc8rcuMMOXI=
X-Received: by 2002:a05:6402:34c6:b0:5e6:6407:3b23 with SMTP id
4fb4d7f45d1cf-5e664073f14mr15626293a12.21.1741785824383; Wed, 12 Mar 2025
06:23:44 -0700 (PDT)
MIME-Version: 1.0
From: david <davidimagid@HIDDEN>
Date: Wed, 12 Mar 2025 09:23:32 -0400
X-Gm-Features: AQ5f1JouSvE1Zq9YZn2Au5iQ9f-SMgQ3WRGN-Lm1liPXh52RjjOrE_n-owctG14
Message-ID: <CAL6FEzzNrdS-5YaL9x3UQf-uXmZJPRegooUNDPRAcmuDFDvQtw@HIDDEN>
Subject: 31.0.50; Archive information not displayed for installed packages in
*Packages* buffer
To: bug-gnu-emacs@HIDDEN
Content-Type: multipart/alternative; boundary="000000000000565b370630251de5"
Received-SPF: pass client-ip=2a00:1450:4864:20::52d;
envelope-from=davidimagid@HIDDEN; helo=mail-ed1-x52d.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
--000000000000565b370630251de5
Content-Type: text/plain; charset="UTF-8"
When a package is installed or is a dependency, the "Archive" column in
the *Packages* buffer does not display the archive information. This
happens because the function `describe-package-1` in `package.el` skips
the Archive section for installed packages due to the following
conditional check:
(unless (and pkg-dir (not archive)) ; Installed pkgs don't have archive.
(package--print-help-section "Archive"
(or archive "n/a")))
The expected behavior is that the "Archive" column should display the
archive name (e.g., "gnu", "nongnu", "other unofficial archive") for
packages in the installed or dependency status. This would be helpful
because:
1. Traceability: It would allow users to easily identify the source archive
of a package, which is useful for debugging, auditing, and understanding
the package's origin.
2. Security: It would provide users with additional context about the
package's source, helping them make informed decisions about the code
they use.
3. Consistency: Archive information is part of the package metadata, and
displaying it consistently would improve the user experience by making
this information readily available.
Currently, the archive information is not displayed for installed or
dependency packages, which makes it harder to track the source of these
packages. This behavior is implemented in the `describe-package-1`
function in `package.el`, starting around line 2890. A review of this
behavior would be appreciated to ensure users have access to this helpful
metadata.
In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.43, cairo version 1.18.2) of 2025-02-26 built on fedora
Repository revision: 8c165834913bb0dca214acc4b82ba1d9d4ac0a82
Repository branch: master
System Description: Fedora Linux 41 (Workstation Edition)
Configured using:
'configure --with-imagemagick --with-pgtk --with-tree-sitter
--with-mailutils --with-sound=yes --with-pdumper=yes
--with-dumping=pdumper --with-file-notification=yes'
Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ
IMAGEMAGICK JPEG LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES
NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3
THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB
Important settings:
value of $LANG: en_US.UTF-8
value of $XMODIFIERS: @im=ibus
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
eldoc-mode: t
show-paren-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
minibuffer-regexp-mode: t
line-number-mode: t
indent-tabs-mode: t
transient-mark-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug lisp-mnt mm-archive message sendmail
yank-media dired dired-loaddefs rfc822 mml mml-sec epa derived gnus-util
time-date mailabbrev gmm-utils mailheader mm-decode mm-bodies mm-encode
mail-utils mule-util cus-edit pp cus-start cus-load wid-edit gnutls
network-stream url-cache url-http url-auth mail-parse rfc2231 rfc2047
rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm puny compile
text-property-search comint ansi-osc ansi-color ring comp-run
comp-common rx epg rfc6068 epg-config display-line-numbers finder-inf
package browse-url xdg url url-proxy url-privacy url-expand url-methods
url-history url-cookie generate-lisp-file url-domsuf url-util mailcap
url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs icons
password-cache json subr-x map byte-opt gv bytecomp byte-compile
url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/pgtk-win pgtk-win term/common-win touch-screen pgtk-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify
dynamic-setting system-font-setting font-render-setting cairo gtk pgtk
multi-tty move-toolbar make-network-process tty-child-frames
native-compile emacs)
Memory information:
((conses 16 309513 44932) (symbols 48 11458 0) (strings 32 55510 3235)
(string-bytes 1 1431141) (vectors 16 20605)
(vector-slots 8 250601 12665) (floats 8 225 47)
(intervals 56 25047 0) (buffers 992 12))
--
David
--000000000000565b370630251de5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div>When a package is installed or is a dependency, the &=
quot;Archive" column in<br>the *Packages* buffer does not display the =
archive information.=C2=A0 This<br>happens because the function `describe-p=
ackage-1` in `package.el` skips<br>the Archive section for installed packag=
es due to the following<br>conditional check:<br><br>(unless (and pkg-dir (=
not archive)) ; Installed pkgs don't have archive.<br>=C2=A0 (package--=
print-help-section "Archive"<br>=C2=A0 =C2=A0 (or archive "n=
/a")))<br><br>The expected behavior is that the "Archive" co=
lumn should display the<br>archive name (e.g., "gnu", "nongn=
u", "other unofficial archive") for<br>packages in the insta=
lled or dependency status.=C2=A0 This would be helpful<br>because:<br><br>1=
. Traceability: It would allow users to easily identify the source archive<=
br>=C2=A0 =C2=A0of a package, which is useful for debugging, auditing, and =
understanding<br>=C2=A0 =C2=A0the package's origin.<br><br>2. Security:=
It would provide users with additional context about the<br>=C2=A0 =C2=A0p=
ackage's source, helping them make informed decisions about the code<br=
>=C2=A0 =C2=A0they use.<br><br>3. Consistency: Archive information is part =
of the package metadata, and<br>=C2=A0 =C2=A0displaying it consistently wou=
ld improve the user experience by making<br>=C2=A0 =C2=A0this information r=
eadily available.<br><br>Currently, the archive information is not displaye=
d for installed or<br>dependency packages, which makes it harder to track t=
he source of these<br>packages.=C2=A0 This behavior is implemented in the `=
describe-package-1`<br>function in `package.el`, starting around line 2890.=
=C2=A0 A review of this<br>behavior would be appreciated to ensure users ha=
ve access to this helpful<br>metadata.<br><br><br>In GNU Emacs 31.0.50 (bui=
ld 1, x86_64-pc-linux-gnu, GTK+ Version<br>=C2=A03.24.43, cairo version 1.1=
8.2) of 2025-02-26 built on fedora<br>Repository revision: 8c165834913bb0dc=
a214acc4b82ba1d9d4ac0a82<br>Repository branch: master<br>System Description=
: Fedora Linux 41 (Workstation Edition)<br><br>Configured using:<br>=C2=A0&=
#39;configure --with-imagemagick --with-pgtk --with-tree-sitter<br>=C2=A0--=
with-mailutils --with-sound=3Dyes --with-pdumper=3Dyes<br>=C2=A0--with-dump=
ing=3Dpdumper --with-file-notification=3Dyes'<br><br>Configured feature=
s:<br>ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ<br=
>IMAGEMAGICK JPEG LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES<br>NATIVE_CO=
MP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3<br>THREADS TI=
FF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB<br><br>Important sett=
ings:<br>=C2=A0 value of $LANG: en_US.UTF-8<br>=C2=A0 value of $XMODIFIERS:=
@im=3Dibus<br>=C2=A0 locale-coding-system: utf-8-unix<br><br>Major mode: L=
isp Interaction<br><br>Minor modes in effect:<br>=C2=A0 tooltip-mode: t<br>=
=C2=A0 global-eldoc-mode: t<br>=C2=A0 eldoc-mode: t<br>=C2=A0 show-paren-mo=
de: t<br>=C2=A0 electric-indent-mode: t<br>=C2=A0 mouse-wheel-mode: t<br>=
=C2=A0 tool-bar-mode: t<br>=C2=A0 menu-bar-mode: t<br>=C2=A0 file-name-shad=
ow-mode: t<br>=C2=A0 global-font-lock-mode: t<br>=C2=A0 font-lock-mode: t<b=
r>=C2=A0 blink-cursor-mode: t<br>=C2=A0 minibuffer-regexp-mode: t<br>=C2=A0=
line-number-mode: t<br>=C2=A0 indent-tabs-mode: t<br>=C2=A0 transient-mark=
-mode: t<br>=C2=A0 auto-composition-mode: t<br>=C2=A0 auto-encryption-mode:=
t<br>=C2=A0 auto-compression-mode: t<br><br>Load-path shadows:<br>None fou=
nd.<br><br>Features:<br>(shadow sort mail-extr emacsbug lisp-mnt mm-archive=
message sendmail<br>yank-media dired dired-loaddefs rfc822 mml mml-sec epa=
derived gnus-util<br>time-date mailabbrev gmm-utils mailheader mm-decode m=
m-bodies mm-encode<br>mail-utils mule-util cus-edit pp cus-start cus-load w=
id-edit gnutls<br>network-stream url-cache url-http url-auth mail-parse rfc=
2231 rfc2047<br>rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm puny compi=
le<br>text-property-search comint ansi-osc ansi-color ring comp-run<br>comp=
-common rx epg rfc6068 epg-config display-line-numbers finder-inf<br>packag=
e browse-url xdg url url-proxy url-privacy url-expand url-methods<br>url-hi=
story url-cookie generate-lisp-file url-domsuf url-util mailcap<br>url-hand=
lers url-parse auth-source cl-seq eieio eieio-core cl-macs icons<br>passwor=
d-cache json subr-x map byte-opt gv bytecomp byte-compile<br>url-vars cl-lo=
addefs cl-lib rmc iso-transl tooltip cconv eldoc paren<br>electric uniquify=
ediff-hook vc-hooks lisp-float-type elisp-mode mwheel<br>term/pgtk-win pgt=
k-win term/common-win touch-screen pgtk-dnd tool-bar<br>dnd fontset image r=
egexp-opt fringe tabulated-list replace newcomment<br>text-mode lisp-mode p=
rog-mode register page tab-bar menu-bar rfn-eshadow<br>isearch easymenu tim=
er select scroll-bar mouse jit-lock font-lock syntax<br>font-core term/tty-=
colors frame minibuffer nadvice seq simple cl-generic<br>indonesian philipp=
ine cham georgian utf-8-lang misc-lang vietnamese<br>tibetan thai tai-viet =
lao korean japanese eucjp-ms cp51932 hebrew greek<br>romanian slovak czech =
european ethiopic indian cyrillic chinese<br>composite emoji-zwj charscript=
charprop case-table epa-hook<br>jka-cmpr-hook help abbrev obarray oclosure=
cl-preloaded button loaddefs<br>theme-loaddefs faces cus-face macroexp fil=
es window text-properties<br>overlay sha1 md5 base64 format env code-pages =
mule custom widget keymap<br>hashtable-print-readable backquote threads dbu=
sbind inotify<br>dynamic-setting system-font-setting font-render-setting ca=
iro gtk pgtk<br>multi-tty move-toolbar make-network-process tty-child-frame=
s<br>native-compile emacs)<br><br>Memory information:<br>((conses 16 309513=
44932) (symbols 48 11458 0) (strings 32 55510 3235)<br>=C2=A0(string-bytes=
1 1431141) (vectors 16 20605)<br>=C2=A0(vector-slots 8 250601 12665) (floa=
ts 8 225 47)<br>=C2=A0(intervals 56 25047 0) (buffers 992 12))<br><div clas=
s=3D"gmail_default" style=3D"font-size:large"><span style=3D"font-size:smal=
l">=C2=A0</span></div></div><span class=3D"gmail_signature_prefix">-- </spa=
n><br><div dir=3D"ltr" class=3D"gmail_signature" data-smartmail=3D"gmail_si=
gnature"><div dir=3D"ltr">David</div></div></div>
--000000000000565b370630251de5--
david <davidimagid@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#76978; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.