GNU logs - #77016, boring messages

Message sent to larsi@HIDDEN, bug-gnu-emacs@HIDDEN:

Subject: bug#77016: [PATCH] Use region as suggested URI in eww by default
Resent-From: Manuel Giraud <manuel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: larsi@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 14 Mar 2025 17:14:02 +0000
Resent-Message-ID: <handler.77016.B.17419724239781 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77016 <at> debbugs.gnu.org
Cc: Lars Magne Ingebrigtsen <larsi@HIDDEN>
From: Manuel Giraud <manuel@HIDDEN>
Date: Fri, 14 Mar 2025 18:13:18 +0100
Message-ID: <875xkbpmc1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@HIDDEN;
 helo=ledu-giraud.fr
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

--=-=-=
Content-Type: text/plain

Tags: patch

Hi,

Here is a patch for eww.  It adds the current region on top of the
suggested URI.  This way when reading a page in eww, one can select a
region and hit "M-RET" to open a new window (or tab) with a web search
for this selection.  WDYT?


In GNU Emacs 31.0.50 (build 38, x86_64-unknown-openbsd7.7, X toolkit) of
 2025-03-14 built on computer
Repository revision: 1437fc2bca2e42cd2a28754bbb4d9ac1403b87b7
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101016
System Description: OpenBSD computer 7.7 GENERIC.MP#593 amd64

Configured using:
 'configure CC=egcc CPPFLAGS=-I/usr/local/include
 LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs
 --bindir=/home/manuel/bin --with-x-toolkit=lucid
 --with-toolkit-scroll-bars=no --without-cairo
 --without-compress-install'


--=-=-=
Content-Type: text/patch
Content-Disposition: attachment;
 filename=0001-Use-region-as-suggested-URI-in-eww-by-default.patch

From 49ca25f051ea4d87542204049e0eff25ea6bdbed Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@HIDDEN>
Date: Fri, 14 Mar 2025 18:03:20 +0100
Subject: [PATCH] Use region as suggested URI in eww by default

* lisp/net/eww.el (eww-region): New function to extract the
selected region.
(eww-suggest-uris): Use it first as suggested URI.
---
 lisp/net/eww.el | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index caee50a712f..02583da4399 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -104,7 +104,8 @@ eww-download-directory
 
 ;;;###autoload
 (defcustom eww-suggest-uris
-  '(eww-links-at-point
+  '(eww-region
+    eww-links-at-point
     thing-at-point-url-at-point
     eww-current-url
     eww-bookmark-urls)
@@ -1106,6 +1107,11 @@ eww-current-url
   "Return URI of the Web page the current EWW buffer is visiting."
   (plist-get eww-data :url))
 
+(defun eww-region ()
+  "Return the current region content if there is one."
+  (when (use-region-p)
+    (buffer-substring (region-beginning) (region-end))))
+
 (defun eww-links-at-point ()
   "Return list of URIs, if any, linked at point."
   (seq-filter #'stringp
-- 
2.48.1


--=-=-=
Content-Type: text/plain

-- 
Manuel Giraud

--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Manuel Giraud <manuel@HIDDEN>
Subject: bug#77016: Acknowledgement ([PATCH] Use region as suggested URI
 in eww by default)
Message-ID: <handler.77016.B.17419724239781.ack <at> debbugs.gnu.org>
References: <875xkbpmc1.fsf@HIDDEN>
X-Gnu-PR-Message: ack 77016
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 77016 <at> debbugs.gnu.org
Date: Fri, 14 Mar 2025 17:14:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Lars Magne Ingebrigtsen <larsi@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 77016 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
77016: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77016
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77016: [PATCH] Use region as suggested URI in eww by default
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 14 Mar 2025 19:05:02 +0000
Resent-Message-ID: <handler.77016.B77016.174197909431844 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Manuel Giraud <manuel@HIDDEN>, 77016 <at> debbugs.gnu.org
Cc: Lars Magne Ingebrigtsen <larsi@HIDDEN>
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <875xkbpmc1.fsf@HIDDEN>
References: <875xkbpmc1.fsf@HIDDEN>
MIME-Version: 1.0
Date: Fri, 14 Mar 2025 12:04:42 -0700
Message-ID: <CADwFkm=2U=mez9mDG5XGZfyETP_HVGnE1tHukBzpus_zFGz-Dw@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Manuel Giraud <manuel@HIDDEN> writes:

> Here is a patch for eww.  It adds the current region on top of the
> suggested URI.  This way when reading a page in eww, one can select a
> region and hit "M-RET" to open a new window (or tab) with a web search
> for this selection.  WDYT?

This is a change in behavior, and I can see that it would be useful to
some users.  However, there are many reasons why one would _not_ want
this behavior by default, and it feels risky to have this level of DWIM
by default.

I think it should be optional and/or behind a prompt.

This should be documented in NEWS.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 15 Mar 2025 12:02:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 15 08:02:05 2025
Received: from localhost ([127.0.0.1]:39457 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ttQDM-0008Dj-5w
	for submit <at> debbugs.gnu.org; Sat, 15 Mar 2025 08:02:04 -0400
Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:48426)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1ttQCH-00089D-8Q
 for control <at> debbugs.gnu.org; Sat, 15 Mar 2025 08:00:57 -0400
Received: by mail-ed1-x52b.google.com with SMTP id
 4fb4d7f45d1cf-5e5e34f4e89so5294551a12.1
 for <control <at> debbugs.gnu.org>; Sat, 15 Mar 2025 05:00:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1742040051; x=1742644851; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=w6UyMHd2CErbbDLM5e/rDoMHUu+jl4w5S1skFMWtIqs=;
 b=h7rh/TZGznmMz+1XD94/Q/Jt3MOvZO326c9hPCw+cy39LLZxE3v8a3WrGKb2J4W7Vv
 GR2yFIT+SbBWhCWQTvQBb5vHr/WNbjsddkj+8VVS1++471C6+m5YRR8Dq1vbWxAK4tqE
 F9xFXhOPUoUiZIp7Qh7HqEAkHroPlC+t47TdsZAS3OZJS1+N22bqQKvZ2lmYuTS8ihHS
 oCm4QQ9JvUNDQaZjMkOaZrZJoohdjH2qZw7BtEgnkLqi4lKM6cjl98hqeO7daCB7Jgbc
 W4HNzudeJTCytkBX1RGlVPN3SFQIZGJkM95a2vBmSje8NQAOuk5pTBwRExhYfNxbZHme
 yTAw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1742040051; x=1742644851;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=w6UyMHd2CErbbDLM5e/rDoMHUu+jl4w5S1skFMWtIqs=;
 b=JE8KweMjjbelV+uF9rGt0YpGXt7oncG5oP+eQ2t3pGugNUz3TWAbJe3PUX8ZZebxve
 PGfauxByeEfLFPrYqgwgfsKxGuHXV+AF3ZrzTf+LVHNpm2Os7T6E4D6pPjsUtK9tN0gs
 2ZBEGq0LuEp+gi6eH1a8CI6ScmvfXQzAR2OCYHwc1b1RsC4Zg/ZYWiK+DJZ0qHaXJ4yR
 oz8A7pT9yXr8/SNCI/IWEmc6xtC6jklf9H6bSBqca0tPyJKjJF9gD4hyIjXIymUzelpo
 6/WNhkSiwpT2meGKS+PUzTal0qKLUjD/74NMrbH2U2vGekefv09qwJgDnyeJR2pNbWj+
 nmZw==
X-Gm-Message-State: AOJu0Yw/s6Qyk4ICbW/839EAMnML3vUzDg7AF5IZjt8YtKnB/zJUlMwQ
 8463OkSWSv8FrZG1bhy+SXyEqUMmEgXkYU6OpJPdiXSHt763lgK85Nj7ULi/III1frnyhWmbm3m
 GIZ9Br+kKYAPPAOLezbgG1YuqqcZEO5l+RLQ=
X-Gm-Gg: ASbGncsnRAiOGZUb+sxELaamCorXwkqNS1SeEz2e7LqR1HucDTj+B+U2C7jVXzDa9h2
 PARaTJjmk086VHtOamUztHUPc/nBj41AWlAyjs3aKsWFyMhfDfLEo6oFfw66L2r1vujxW7pwUXH
 4A04eVK9kVLMuzoB7BS8/TZJ7qWqEO
X-Google-Smtp-Source: AGHT+IHqVrXgMLFySJ1pxlLNUAy4GU4m/BPkhDYKnkASZ0u1EIl5mqmXb4hnv/MSwIqodDNrTUOZ7+hgA+v7nGngNHY=
X-Received: by 2002:a05:6402:35cb:b0:5e4:a88a:64e with SMTP id
 4fb4d7f45d1cf-5e89f34482fmr6809601a12.5.1742040051155; Sat, 15 Mar 2025
 05:00:51 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sat, 15 Mar 2025 07:00:50 -0500
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Sat, 15 Mar 2025 07:00:50 -0500
X-Gm-Features: AQ5f1JrXk74_cQ7COrUSoKKgq4IXXW57QsqagYtm_AXVi3Bv_TDHe5Og-pcBJt4
Message-ID: <CADwFkmk+y_gqk3o3FBt7DK=5-VxZs4TXRX6MQ_P8yJEY0vRKdw@HIDDEN>
Subject: control message for bug #77016
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 77016 wishlist
quit

Last modified: Sat, 15 Mar 2025 12:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.