GNU logs - #77038, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#77038] [PATCH 0/3] Update uftrace to v0.17 and enable its tests
Resent-From: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 15 Mar 2025 16:09:02 +0000
Resent-Message-ID: <handler.77038.B.174205492119026 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77038 <at> debbugs.gnu.org
Cc: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
From: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
Date: Sat, 15 Mar 2025 14:44:48 +0100
Message-ID: <20250315134450.3310411-1-necto.ne@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::629;
 envelope-from=necto.ne@HIDDEN; helo=mail-ej1-x629.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Mailman-Approved-At: Sat, 15 Mar 2025 12:08:38 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Date: Sat, 15 Mar 2025 13:25:17 +0100
Message-ID: <cover.1742041517.git.necto.ne@HIDDEN>
base-commit: 92124591eedf27e988c84f75acd4b4d99ff43122
From de35530f377cc2bcc3a68efa55d28ee3e42703fb Mon Sep 17 00:00:00 2001
This patch series takes care of updating uftrace to the most recent version
v0.17 and enables the run of all tests, not just the unit tests. To that end I
had to also add explicit dependencies on python and luajit because some tests
test this optional functionality.

uftrace loads the libpython and libluajit libraries dynamically with dlload,
which fails to find them in the user .guix-profile, so their /gnu/store paths
have to be hardcoded at the build stage. I made these depencencies, which are
arguable rather large, optional in a sense that a user can define a package
variant that excludes them and it will build properly. Let me know if there is
a better way to manage optional dependencies.

 gnu/packages/instrumentation.scm             | 67 ++++++++++++++------
 gnu/packages/patches/uftrace-fix-tests.patch | 32 ++++++++++
 2 files changed, 79 insertions(+), 20 deletions(-)
 create mode 100644 gnu/packages/patches/uftrace-fix-tests.patch

Arseniy Zaostrovnykh (3):
  gnu: uftrace: Enable python and lua scripting and fix tests
  gnu: uftrace: Update to 0.17
  gnu: uftrace: Make python and luajit inputs optional


-- 
2.48.1

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
Subject: bug#77038: Acknowledgement ([PATCH 0/3] Update uftrace to v0.17
 and enable its tests)
Message-ID: <handler.77038.B.174205492119026.ack <at> debbugs.gnu.org>
References: <20250315134450.3310411-1-necto.ne@HIDDEN>
X-Gnu-PR-Message: ack 77038
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 77038 <at> debbugs.gnu.org
Date: Sat, 15 Mar 2025 16:09:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 77038 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
77038: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77038
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#77038] [PATCH 1/3] gnu: uftrace: Enable python and lua scripting and fix tests
Resent-From: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 16 Mar 2025 12:10:07 +0000
Resent-Message-ID: <handler.77038.B77038.17421269622163 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77038 <at> debbugs.gnu.org
Cc: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
From: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
Date: Sat, 15 Mar 2025 18:56:25 +0100
Message-ID: <b7bc801fa232e4c8d12a721704bc534dde587b35.1742041517.git.necto.ne@HIDDEN>
In-Reply-To: <cover.1742041517.git.necto.ne@HIDDEN>
References: <cover.1742041517.git.necto.ne@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

* gnu/packages/patches/uftrace-fix-tests.patch: New file
* gnu/packages/instrumentation.scm (uftrace): Enable scripting & fix tests
    [source]: use the new patch to fix some stale expectations
    <#:phases>: Adjust shebang embedded in onf of the tests and remove
    tests that expect network capability
    [inputs]: add python and luajit to enable uftrace script

Change-Id: Id3047753a1bb1e41e637004b4b8e4a4865bb3188
---
 gnu/packages/instrumentation.scm             | 34 +++++++++++++----
 gnu/packages/patches/uftrace-fix-tests.patch | 40 ++++++++++++++++++++
 2 files changed, 66 insertions(+), 8 deletions(-)
 create mode 100644 gnu/packages/patches/uftrace-fix-tests.patch

diff --git a/gnu/packages/instrumentation.scm b/gnu/packages/instrumentation.scm
index b42aaa2e2f..b2d65f790e 100644
--- a/gnu/packages/instrumentation.scm
+++ b/gnu/packages/instrumentation.scm
@@ -577,7 +577,8 @@ (define-public uftrace
                     (commit (string-append "v" version))))
               (file-name (git-file-name name version))
               (sha256
-               (base32 "0gk0hv3rnf5czvazz1prg21rf9qlniz42g5b389n8a29hqj4q6xr"))))
+               (base32 "0gk0hv3rnf5czvazz1prg21rf9qlniz42g5b389n8a29hqj4q6xr"))
+              (patches (search-patches "uftrace-fix-tests.patch"))))
     (build-system gnu-build-system)
     (arguments
      (list
@@ -587,10 +588,7 @@ (define-public uftrace
       #:make-flags
       #~(list
          (string-append "CC=" #$(cc-for-target)))
-      ;; runtest hangs at some point -- probably due to
-      ;; failed socket connection -- but we want to keep the
-      ;; unit tests.  Change the target to "test" when fixed.
-      #:test-target "unittest"
+      #:test-target "test"
       #:phases
       #~(modify-phases %standard-phases
           (replace 'configure
@@ -606,13 +604,34 @@ (define-public uftrace
                 (when target
                   (setenv "CROSS_COMPILE" (string-append target "-"))))
               (setenv "SHELL" (which "sh"))
+              (let ((python #$(this-package-input "python"))
+                    (luajit #$(this-package-input "luajit")))
+                (setenv "LDFLAGS" (string-append "-Wl," "-rpath=" python "/lib"
+                                                 ":" luajit "/lib")))
               (invoke "./configure"
                       (string-append "--prefix="
-                                     #$output)))))))
+                                     #$output))))
+          (add-before 'check 'fix-shebang
+            (lambda* (#:key inputs #:allow-other-keys)
+              (substitute* "tests/t220_trace_script.py"
+                (("/bin/sh")
+                 (search-input-file inputs "bin/sh")))))
+          (add-after 'unpack 'delete-network-tests
+            (lambda _
+              ;; These tests require network capability (localhost)
+              (for-each delete-file
+                        '("tests/t141_recv_basic.py"
+                          "tests/t142_recv_multi.py"
+                          "tests/t143_recv_kernel.py"
+                          "tests/t150_recv_event.py"
+                          "tests/t151_recv_runcmd.py"
+                          "tests/t167_recv_sched.py")))))))
     (inputs
      (list capstone
            elfutils
            libunwind
+           python ;; libpython3.10.so for python scripting
+           luajit ;; libluajit-5.1.so for lua scripting
            ncurses))
     (native-inputs
      (list luajit
@@ -625,6 +644,5 @@ (define-public uftrace
 programs written in C/C++.  It is heavily inspired by the ftrace framework of
 the Linux kernel, while supporting userspace programs.  It supports various
 kind of commands and filters to help analysis of the program execution and
-performance.  It provides the command @command{uftrace}.  User that want to do
-scripting need to install python-3 or luajit in their profile.")
+performance.  It provides the command @command{uftrace}.")
     (license license:gpl2)))
diff --git a/gnu/packages/patches/uftrace-fix-tests.patch b/gnu/packages/patches/uftrace-fix-tests.patch
new file mode 100644
index 0000000000..c95610e308
--- /dev/null
+++ b/gnu/packages/patches/uftrace-fix-tests.patch
@@ -0,0 +1,40 @@
+Adjust test expectations to match the guix platform
+--- a/tests/t192_lib_name.py
++++ b/tests/t192_lib_name.py
+@@ -44,4 +44,4 @@ class TestCase(TestBase):
+         ver = v.split('\n')[0].split(') ')[1]
+         ver.strip()
+ 
+-        return re.sub("libc-[\d.]+.so", "libc-%s.so" % ver, result)
++        return re.sub("libc-2.26.so", "libc.so.6", result)
+--- a/tests/t251_exception4.py
++++ b/tests/t251_exception4.py
+@@ -5,16 +5,18 @@ from runtest import TestBase
+ class TestCase(TestBase):
+     def __init__(self):
+         TestBase.__init__(self, 'libexcept-main', lang='C++', result="""
+-# DURATION    TID     FUNCTION
+-            [423633] | main() {
+-            [423633] |   XXX::XXX() {
+-  30.679 us [423633] |     XXX::XXX();
+-  31.490 us [423633] |   } /* XXX::XXX */
+-            [423633] |   YYY::YYY() {
+-   0.509 us [423633] |     __cxa_allocate_exception();
+-   0.541 us [423633] |     std::runtime_error::runtime_error();
+-   5.670 us [423633] |   } /* YYY::YYY */
+-  42.354 us [423633] | } /* main */
++# DURATION     TID     FUNCTION
++            [ 39887] | main() {
++            [ 39887] |   XXX::XXX() {
++  35.591 us [ 39887] |     XXX::XXX();
++  36.215 us [ 39887] |   } /* XXX::XXX */
++   5.617 us [ 39887] |   std::runtime_error::~runtime_error();
++            [ 39887] |   YYY::YYY() {
++   0.291 us [ 39887] |     __cxa_allocate_exception();
++   0.399 us [ 39887] |     std::runtime_error::runtime_error();
++   3.683 us [ 39887] |   } /* YYY::YYY */
++   0.122 us [ 39887] |   std::runtime_error::~runtime_error();
++  48.809 us [ 39887] | } /* main */
+ """)
+ 
+     def build(self, name, cflags='', ldflags=''):
-- 
2.48.1

Message sent to guix-patches@HIDDEN:

Subject: [bug#77038] [PATCH 2/3] gnu: uftrace: Update to 0.17
Resent-From: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 16 Mar 2025 12:10:09 +0000
Resent-Message-ID: <handler.77038.B77038.17421269632180 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77038 <at> debbugs.gnu.org
Cc: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
From: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
Date: Sat, 15 Mar 2025 18:56:26 +0100
Message-ID: <d4e61a9e53ca31e607597e04366d0271f23caaf3.1742041517.git.necto.ne@HIDDEN>
In-Reply-To: <cover.1742041517.git.necto.ne@HIDDEN>
References: <cover.1742041517.git.necto.ne@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

* gnu/packages/instrumentation.scm (uftrace): Update to 0.17
* gnu/packages/patches/uftrace-fix-tests.patch: Drop the patch for
t192_lib_name.py that has been fixed in the mean time

Change-Id: I80dc540adabbbbbec8ac5f0c096e7e973e230b27
---
 gnu/packages/instrumentation.scm             | 4 ++--
 gnu/packages/patches/uftrace-fix-tests.patch | 8 --------
 2 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/instrumentation.scm b/gnu/packages/instrumentation.scm
index b2d65f790e..05e74b6f4f 100644
--- a/gnu/packages/instrumentation.scm
+++ b/gnu/packages/instrumentation.scm
@@ -569,7 +569,7 @@ (define-public systemtap
 (define-public uftrace
   (package
     (name "uftrace")
-    (version "0.11")
+    (version "0.17")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -577,7 +577,7 @@ (define-public uftrace
                     (commit (string-append "v" version))))
               (file-name (git-file-name name version))
               (sha256
-               (base32 "0gk0hv3rnf5czvazz1prg21rf9qlniz42g5b389n8a29hqj4q6xr"))
+               (base32 "0p1iy70hc4vl3j16j9vvlh5amvk06l3m35iic2crpavm240dw7y7"))
               (patches (search-patches "uftrace-fix-tests.patch"))))
     (build-system gnu-build-system)
     (arguments
diff --git a/gnu/packages/patches/uftrace-fix-tests.patch b/gnu/packages/patches/uftrace-fix-tests.patch
index c95610e308..0253ed2616 100644
--- a/gnu/packages/patches/uftrace-fix-tests.patch
+++ b/gnu/packages/patches/uftrace-fix-tests.patch
@@ -1,12 +1,4 @@
 Adjust test expectations to match the guix platform
---- a/tests/t192_lib_name.py
-+++ b/tests/t192_lib_name.py
-@@ -44,4 +44,4 @@ class TestCase(TestBase):
-         ver = v.split('\n')[0].split(') ')[1]
-         ver.strip()
- 
--        return re.sub("libc-[\d.]+.so", "libc-%s.so" % ver, result)
-+        return re.sub("libc-2.26.so", "libc.so.6", result)
 --- a/tests/t251_exception4.py
 +++ b/tests/t251_exception4.py
 @@ -5,16 +5,18 @@ from runtest import TestBase
-- 
2.48.1

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#77038] [PATCH 3/3] gnu: uftrace: Make python and luajit inputs optional
Resent-From: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 16 Mar 2025 12:10:11 +0000
Resent-Message-ID: <handler.77038.B77038.17421269642189 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77038
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 77038 <at> debbugs.gnu.org
Cc: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
Received: via spool by 77038-submit <at> debbugs.gnu.org id=B77038.17421269642189
          (code B ref 77038); Sun, 16 Mar 2025 12:10:11 +0000
Received: (at 77038) by debbugs.gnu.org; 16 Mar 2025 12:09:24 +0000
Received: from localhost ([127.0.0.1]:45903 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ttmnz-0000Z6-9p
	for submit <at> debbugs.gnu.org; Sun, 16 Mar 2025 08:09:24 -0400
Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:57764)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <necto.ne@HIDDEN>)
 id 1ttVkx-0002DV-Gd
 for 77038 <at> debbugs.gnu.org; Sat, 15 Mar 2025 13:57:08 -0400
Received: by mail-ed1-x52b.google.com with SMTP id
 4fb4d7f45d1cf-5e5e22e6ed2so4703326a12.3
 for <77038 <at> debbugs.gnu.org>; Sat, 15 Mar 2025 10:57:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1742061421; x=1742666221; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=d2BeiAFMJ+dkgYmp+Sn8YOnyiRMzhfUoryD/a2RhrtU=;
 b=E5uuOL3UBvh8L0UvoV5yQgucnee6CuX40vZdOoF0RkVKhgS6XtIrx1NiBQQiWCnejB
 3NJn2l83x3BaVp8M8ijarurzcQDjWudunMQbOOE0nqsAQ7RYFVs/FJf+MPugjeCmPydP
 oYUH9fPzE9J0FVELSbxkTn1xmtfGiwX/9WGro45ICf+rUf5moegIgKccWCPmTJmHd1QH
 S1AiJ1+CAZmWnQfEPAVzvwpx+KxAFMykjC3uDm6P5bcPZD1T2q/EY9Wvsb44gLzVsA8a
 ZU0hrJOMxTkFKyGgHQYz9oYk3SZXj0Pseb9INXCU6GNjv7QqAUVA6cIVHpCECNLyoe7D
 A9aw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1742061421; x=1742666221;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=d2BeiAFMJ+dkgYmp+Sn8YOnyiRMzhfUoryD/a2RhrtU=;
 b=F0C6GPjTTOD3JVAVe96GcCmJvLrAHlph1XIHHaEkbfMzot040TRmTk7DWGNZDOEJhk
 8sLntutux/+gJbmiQh7CctacXfqzRykTKJv5dU9GlixtBcdVd/m7iT5OaWP5HVbAvSyr
 39Q4Tp+VT9l7GO7PCXuuUwfoIkgtw5nqnRF2iDcO/7o+PkrDBxxtucpFIsTdckxVozMX
 PTEQaBrgRxibIkIlDjAwpcG8E5IzDKyTalyjo5fE8Dy+i0js0SK/Z5kLFF7+x+UzgxgY
 7pH4Z3o4PhSq7BIoeq8UDVmkNxHnX5YzYGigHC5JERWpPT/47rcZjIr+x+bvvRvzpZuK
 qjQQ==
X-Gm-Message-State: AOJu0Yw9Xuy6oaLNNYr/y9jHNB7OGiMmSQN9zEcL12j0JECTgROpYKf+
 bMjeEUEHtKRGKBDglzGadrDQLfCk8t4zKCfwUinU+RfZDtY/bwrigirmyHbs
X-Gm-Gg: ASbGnct1b0KQ80+06uQLodgNh1tqs041HGO1i83C/hl5CXdI2j4lZ/pcBQdv+oVMDut
 8oznwIEOllH666wfMB9r/Yj5I2pZIqTOvTXpUplLUTjkVgJo4rZMMvYBTUm+3dO+XwhrC1ulA9Q
 lSwzg9OBcP9n275bj6bo2oFHVkHO8cg5IUnakhT4BkweCR6HoWgXIE7rUbh4EPeYjsME7bvUoaV
 EjYf8FYTNhgM1t7aL6Zy3slSsv/y1Sp1AegdC/WHCfN1+mrFKUpO/d2BwzvD5WTtfRusXIsrPmB
 oWlh6XU87q1DpqjYUEbZ9uYo2v4OQIQeMNwg
X-Google-Smtp-Source: AGHT+IGJyjaEkn3nVYPcCe52IsJNUwCZ8pGOX/FU1Oav5+KRlm3qnwnsEzpsuL0VVJhcvOuAx+zo/A==
X-Received: by 2002:a05:6402:348d:b0:5de:cbed:c955 with SMTP id
 4fb4d7f45d1cf-5e89fa5252bmr8105885a12.17.1742061420979; 
 Sat, 15 Mar 2025 10:57:00 -0700 (PDT)
Received: from frame.. ([2a04:ee41:82:f4e6:77fe:705:8fce:6f1])
 by smtp.gmail.com with ESMTPSA id
 4fb4d7f45d1cf-5e8169bcdb3sm3558220a12.43.2025.03.15.10.56.59
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 15 Mar 2025 10:57:00 -0700 (PDT)
From: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
Date: Sat, 15 Mar 2025 18:56:27 +0100
Message-ID: <de35530f377cc2bcc3a68efa55d28ee3e42703fb.1742041517.git.necto.ne@HIDDEN>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <cover.1742041517.git.necto.ne@HIDDEN>
References: <cover.1742041517.git.necto.ne@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Mailman-Approved-At: Sun, 16 Mar 2025 08:09:18 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

gnu/packages/instrumentation.scm (uftrace): Make scripting inputs
optional. If user removes these inputs they will still be able to enjoy
uftrace except for the scripting part.

Change-Id: Ice8f9ce8aba38322ff34a38f112512186bd98c1d
---
 gnu/packages/instrumentation.scm | 47 +++++++++++++++++++-------------
 1 file changed, 28 insertions(+), 19 deletions(-)

diff --git a/gnu/packages/instrumentation.scm b/gnu/packages/instrumentation.scm
index 05e74b6f4f..09314519a9 100644
--- a/gnu/packages/instrumentation.scm
+++ b/gnu/packages/instrumentation.scm
@@ -604,10 +604,22 @@ (define-public uftrace
                 (when target
                   (setenv "CROSS_COMPILE" (string-append target "-"))))
               (setenv "SHELL" (which "sh"))
-              (let ((python #$(this-package-input "python"))
-                    (luajit #$(this-package-input "luajit")))
-                (setenv "LDFLAGS" (string-append "-Wl," "-rpath=" python "/lib"
-                                                 ":" luajit "/lib")))
+              (let* ((python #$(this-package-input "python"))
+                     (luajit #$(this-package-input "luajit"))
+                     (libs (cond
+                             ((and python luajit)
+                              (list "-Wl,-rpath="
+                                    python
+                                    "/lib"
+                                    ":"
+                                    luajit
+                                    "/lib"))
+                             (python (list "-Wl,-rpath=" python "/lib"))
+                             (luajit (list "-Wl,-rpath=" luajit "/lib"))
+                             (#t #f))))
+                (when libs
+                  (setenv "LDFLAGS"
+                          (apply string-append libs))))
               (invoke "./configure"
                       (string-append "--prefix="
                                      #$output))))
@@ -616,7 +628,7 @@ (define-public uftrace
               (substitute* "tests/t220_trace_script.py"
                 (("/bin/sh")
                  (search-input-file inputs "bin/sh")))))
-          (add-after 'unpack 'delete-network-tests
+          (add-before 'check 'delete-network-tests
             (lambda _
               ;; These tests require network capability (localhost)
               (for-each delete-file
@@ -626,23 +638,20 @@ (define-public uftrace
                           "tests/t150_recv_event.py"
                           "tests/t151_recv_runcmd.py"
                           "tests/t167_recv_sched.py")))))))
-    (inputs
-     (list capstone
-           elfutils
-           libunwind
-           python ;; libpython3.10.so for python scripting
-           luajit ;; libluajit-5.1.so for lua scripting
-           ncurses))
-    (native-inputs
-     (list luajit
-           pandoc
-           pkg-config
-           python-wrapper))
+    (inputs (list capstone
+                  elfutils
+                  libunwind
+                  python ;(optional) libpython3.10.so for python scripting
+                  luajit ;(optional) libluajit-5.1.so for lua scripting
+                  ncurses))
+    (native-inputs (list luajit pandoc pkg-config python-wrapper))
     (home-page "https://github.com/namhyung/uftrace")
     (synopsis "Function graph tracer for C/C++/Rust")
-    (description "uftrace is a tool for tracing and analyzing the execution of
+    (description
+     "uftrace is a tool for tracing and analyzing the execution of
 programs written in C/C++.  It is heavily inspired by the ftrace framework of
 the Linux kernel, while supporting userspace programs.  It supports various
 kind of commands and filters to help analysis of the program execution and
-performance.  It provides the command @command{uftrace}.")
+performance.  It provides the command @command{uftrace}.  By default, it is
+bundled with python-3 and luajit that you can delete in a package variant.")
     (license license:gpl2)))
-- 
2.48.1

Message sent:

MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: bug#77038: closed ([PATCH 0/3] Update uftrace to v0.17 and enable
 its tests)
CC: tracker <at> debbugs.gnu.org
Message-ID: <handler.77038.D77038.174360563616532.ackdone <at> debbugs.gnu.org>
References: <87friqbonl.fsf@HIDDEN>
 <20250315134450.3310411-1-necto.ne@HIDDEN>
X-Gnu-PR-Message: closed 77038
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Date: Wed, 02 Apr 2025 14:54:02 +0000
Content-Type: multipart/mixed; boundary="----------=_1743605642-16558-0"

This is a multi-part message in MIME format...

------------=_1743605642-16558-0
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf-8

Your message dated Wed, 02 Apr 2025 16:53:34 +0200
with message-id <87friqbonl.fsf@HIDDEN>
and subject line Re: [bug#77038] [PATCH 0/3] Update uftrace to v0.17 and en=
able its tests
has caused the debbugs.gnu.org bug report #77038,
regarding [PATCH 0/3] Update uftrace to v0.17 and enable its tests
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@HIDDEN)


--=20
77038: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77038
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

------------=_1743605642-16558-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at submit) by debbugs.gnu.org; 15 Mar 2025 16:08:41 +0000
Received: from localhost ([127.0.0.1]:43266 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ttU40-0004wd-CI
	for submit <at> debbugs.gnu.org; Sat, 15 Mar 2025 12:08:41 -0400
Received: from lists.gnu.org ([2001:470:142::17]:33002)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <necto.ne@HIDDEN>)
 id 1ttRp3-0003df-39
 for submit <at> debbugs.gnu.org; Sat, 15 Mar 2025 09:45:07 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <necto.ne@HIDDEN>)
 id 1ttRov-0004XK-C2
 for guix-patches@HIDDEN; Sat, 15 Mar 2025 09:44:57 -0400
Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <necto.ne@HIDDEN>)
 id 1ttRot-0007ia-OO
 for guix-patches@HIDDEN; Sat, 15 Mar 2025 09:44:57 -0400
Received: by mail-ej1-x629.google.com with SMTP id
 a640c23a62f3a-aaeec07b705so471873066b.2
 for <guix-patches@HIDDEN>; Sat, 15 Mar 2025 06:44:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1742046293; x=1742651093; darn=gnu.org;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=h4uPEb8vHe69+7b6Lt8oHzJWfVzpIHOhGzlYtBSdOAQ=;
 b=XAUO2ue/WBp2czrLwHiXuQGC1SNA3BW+Z276G0v/kr444aCOVtzbdlgckxOS5AHSIa
 KtKuj7ixl1JASU1yFcn2MLeCP4cKjgSbxr3jM3EaXZYXMJICsWAipe64WxTfLTqELZ6V
 G4nzHYee7OxrgW2fLjJ0S3ZjFX5mRjULPGVRd0Oh3AtTq20abrL8oqDBczS7tBtrQj84
 NfJosogaTWPZ/Bud2zZ9v9amscCTISqZXWOsOWyH/XlDDWrTQ+HMsQUG52BP5GdLuqpq
 cB7jLe/Kmgq83D1rmB8o4HCFDIInUdCCxhNX9EVVi51dcWuyGNEXi9uXPRAVHh7gBf6W
 H/ZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1742046293; x=1742651093;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=h4uPEb8vHe69+7b6Lt8oHzJWfVzpIHOhGzlYtBSdOAQ=;
 b=Q5Grwi7f3siLZUr9RRE2um5mz5Gg/2Q1OnK+0mT+2AoTjY/i5DMJgtn192z+aLa9FM
 0IGMZfbXOjRaThCi2mQefyCGdZxRGWp9DoU50aE/oOXOTB28+fxCNPLG37BaYB/LdPd5
 2kKRJYYcldRcseAv3um95SS/JcrZ8+y6XMUMW8OtvF3LT/wMHUAu1EL12siyw2ZqvUGs
 2TF2bynjSkIo/X53y/9O5iPIdSgpjr+4e60wFmJ13/yz07FXO1pGaG6wzEqt8FhF4zwV
 Z6DHNLHsYzF8CmdjJ9jYOLF/C6zYEb60UZ7PsajS4Yc8Dq2b+dpEg+divmg0QlEkshmO
 W/TQ==
X-Gm-Message-State: AOJu0YzNvOq0aj2J9nkKmAWsxdPMtQubDK+rpnSwbvSZGaaAOVG6ZsKp
 YLJvTOMDe87ad1fB+pyZBTwZU15RFv79eI7P56APm8NiOlS99oK4KrnXpPLy
X-Gm-Gg: ASbGncuV6ztlflsjtYvVcl9Pye/GHC+JajwKzKZC+8+0qwWHlL4jK7Z/h/iY//nFe0C
 dVG3/Fah7jFRqXq1RQito4SyIhpAEBWsQSWTzo0mcu1GNrO1X39s1tGgToOCsgz5hfjbEFEzd3p
 xnj7/oAypevRlk3ZRRfVW6UUO1Krax1TgzUSG2FML4r2g+nZOWi5mMkNWBNtMEqZB23MMbduPzw
 hQQx8gcqImy7u11vfIRFOJH6g0WEZsnqhb2OxVYdhQnSy4k7kLBiDOKSCrF6rhAGvaCNzY9LZh4
 zvToNnBkCi24ARWmBYveESeMhIZ2WnlZqh1j
X-Google-Smtp-Source: AGHT+IEOAStrePucqKrB+/Iro5hGxlFll8heg2Lpejg3j3dirfv7mwgnGNIj21eItw/yAieDw0xyhA==
X-Received: by 2002:a17:907:3f97:b0:ac3:47b1:d210 with SMTP id
 a640c23a62f3a-ac347b1e834mr306749066b.39.1742046293015; 
 Sat, 15 Mar 2025 06:44:53 -0700 (PDT)
Received: from frame.. ([2a04:ee41:82:f4e6:77fe:705:8fce:6f1])
 by smtp.gmail.com with ESMTPSA id
 a640c23a62f3a-ac3149ce7e1sm376118666b.107.2025.03.15.06.44.52
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 15 Mar 2025 06:44:52 -0700 (PDT)
From: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH 0/3] Update uftrace to v0.17 and enable its tests
Date: Sat, 15 Mar 2025 14:44:48 +0100
Message-ID: <20250315134450.3310411-1-necto.ne@HIDDEN>
X-Mailer: git-send-email 2.48.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::629;
 envelope-from=necto.ne@HIDDEN; helo=mail-ej1-x629.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Sat, 15 Mar 2025 12:08:38 -0400
Cc: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Date: Sat, 15 Mar 2025 13:25:17 +0100
Message-ID: <cover.1742041517.git.necto.ne@HIDDEN>
base-commit: 92124591eedf27e988c84f75acd4b4d99ff43122
From de35530f377cc2bcc3a68efa55d28ee3e42703fb Mon Sep 17 00:00:00 2001
This patch series takes care of updating uftrace to the most recent version
v0.17 and enables the run of all tests, not just the unit tests. To that end I
had to also add explicit dependencies on python and luajit because some tests
test this optional functionality.

uftrace loads the libpython and libluajit libraries dynamically with dlload,
which fails to find them in the user .guix-profile, so their /gnu/store paths
have to be hardcoded at the build stage. I made these depencencies, which are
arguable rather large, optional in a sense that a user can define a package
variant that excludes them and it will build properly. Let me know if there is
a better way to manage optional dependencies.

 gnu/packages/instrumentation.scm             | 67 ++++++++++++++------
 gnu/packages/patches/uftrace-fix-tests.patch | 32 ++++++++++
 2 files changed, 79 insertions(+), 20 deletions(-)
 create mode 100644 gnu/packages/patches/uftrace-fix-tests.patch

Arseniy Zaostrovnykh (3):
  gnu: uftrace: Enable python and lua scripting and fix tests
  gnu: uftrace: Update to 0.17
  gnu: uftrace: Make python and luajit inputs optional


-- 
2.48.1



------------=_1743605642-16558-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at 77038-done) by debbugs.gnu.org; 2 Apr 2025 14:53:56 +0000
Received: from localhost ([127.0.0.1]:58877 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tzzTX-0004IW-2m
	for submit <at> debbugs.gnu.org; Wed, 02 Apr 2025 10:53:55 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:44836)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1tzzTT-0004Hx-Ld
 for 77038-done <at> debbugs.gnu.org; Wed, 02 Apr 2025 10:53:52 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1tzzTO-0007Lq-6A; Wed, 02 Apr 2025 10:53:46 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=6cUhDHi0k6rEDsrN/zVaJRHM8L7MSBVfnOy7yZtYyc0=; b=RB2CA6ORmB910/IViRu0
 XlhhNVFgKuQAq2+1sjmNkyOL7qC5adgtEmCMEsBbYH+rc1cTJw2dgp4I9kBBCsYzWlNPct13cwoiA
 vU3XIjQ/N7UEtyO2TCDZ4o/F+FgaHS+hOLQSygk1gFS0n8hlJC7oyiwzMT7PGQ/1Hz2LXAUMQUjBf
 vsKqos24PiguVdNZdLoUn1DClUlhAM494PJY81jR02eQGErEzu+5xOCEUztjBqq98vylax6dFdtnl
 1Hgi1SW680Y7CuFhxeYdKlF6JgAp/x/dBIeRr2+4tStwccMW1iuFPZrTQCvlATR7S8H3kw+91ZanH
 WId1B7fhvfxy0g==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
Subject: Re: [bug#77038] [PATCH 0/3] Update uftrace to v0.17 and enable its
 tests
In-Reply-To: <20250315134450.3310411-1-necto.ne@HIDDEN> (Arseniy
 Zaostrovnykh's message of "Sat, 15 Mar 2025 14:44:48 +0100")
References: <20250315134450.3310411-1-necto.ne@HIDDEN>
Date: Wed, 02 Apr 2025 16:53:34 +0200
Message-ID: <87friqbonl.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 77038-done
Cc: 77038-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

Arseniy Zaostrovnykh <necto.ne@HIDDEN> skribis:

>   gnu: uftrace: Enable python and lua scripting and fix tests
>   gnu: uftrace: Update to 0.17
>   gnu: uftrace: Make python and luajit inputs optional

Applied.  I modified the first patch to add =E2=80=98uftrace-fix-tests.patc=
h=E2=80=99 to
=E2=80=98gnu/local.mk=E2=80=99.

Thanks!

Ludo=E2=80=99.


------------=_1743605642-16558-0--

Message sent:

MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
Subject: bug#77038: closed (Re: [bug#77038] [PATCH 0/3] Update uftrace to
 v0.17 and enable its tests)
Message-ID: <handler.77038.D77038.174360563616532.notifdone <at> debbugs.gnu.org>
References: <87friqbonl.fsf@HIDDEN>
 <20250315134450.3310411-1-necto.ne@HIDDEN>
X-Gnu-PR-Message: they-closed 77038
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 77038 <at> debbugs.gnu.org
Date: Wed, 02 Apr 2025 14:54:02 +0000
Content-Type: multipart/mixed; boundary="----------=_1743605642-16558-1"

This is a multi-part message in MIME format...

------------=_1743605642-16558-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Your bug report

#77038: [PATCH 0/3] Update uftrace to v0.17 and enable its tests

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 77038 <at> debbugs.gnu.org.

--=20
77038: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77038
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

------------=_1743605642-16558-1
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at 77038-done) by debbugs.gnu.org; 2 Apr 2025 14:53:56 +0000
Received: from localhost ([127.0.0.1]:58877 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tzzTX-0004IW-2m
	for submit <at> debbugs.gnu.org; Wed, 02 Apr 2025 10:53:55 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:44836)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1tzzTT-0004Hx-Ld
 for 77038-done <at> debbugs.gnu.org; Wed, 02 Apr 2025 10:53:52 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1tzzTO-0007Lq-6A; Wed, 02 Apr 2025 10:53:46 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=6cUhDHi0k6rEDsrN/zVaJRHM8L7MSBVfnOy7yZtYyc0=; b=RB2CA6ORmB910/IViRu0
 XlhhNVFgKuQAq2+1sjmNkyOL7qC5adgtEmCMEsBbYH+rc1cTJw2dgp4I9kBBCsYzWlNPct13cwoiA
 vU3XIjQ/N7UEtyO2TCDZ4o/F+FgaHS+hOLQSygk1gFS0n8hlJC7oyiwzMT7PGQ/1Hz2LXAUMQUjBf
 vsKqos24PiguVdNZdLoUn1DClUlhAM494PJY81jR02eQGErEzu+5xOCEUztjBqq98vylax6dFdtnl
 1Hgi1SW680Y7CuFhxeYdKlF6JgAp/x/dBIeRr2+4tStwccMW1iuFPZrTQCvlATR7S8H3kw+91ZanH
 WId1B7fhvfxy0g==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
Subject: Re: [bug#77038] [PATCH 0/3] Update uftrace to v0.17 and enable its
 tests
In-Reply-To: <20250315134450.3310411-1-necto.ne@HIDDEN> (Arseniy
 Zaostrovnykh's message of "Sat, 15 Mar 2025 14:44:48 +0100")
References: <20250315134450.3310411-1-necto.ne@HIDDEN>
Date: Wed, 02 Apr 2025 16:53:34 +0200
Message-ID: <87friqbonl.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 77038-done
Cc: 77038-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

Arseniy Zaostrovnykh <necto.ne@HIDDEN> skribis:

>   gnu: uftrace: Enable python and lua scripting and fix tests
>   gnu: uftrace: Update to 0.17
>   gnu: uftrace: Make python and luajit inputs optional

Applied.  I modified the first patch to add =E2=80=98uftrace-fix-tests.patc=
h=E2=80=99 to
=E2=80=98gnu/local.mk=E2=80=99.

Thanks!

Ludo=E2=80=99.


------------=_1743605642-16558-1
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at submit) by debbugs.gnu.org; 15 Mar 2025 16:08:41 +0000
Received: from localhost ([127.0.0.1]:43266 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ttU40-0004wd-CI
	for submit <at> debbugs.gnu.org; Sat, 15 Mar 2025 12:08:41 -0400
Received: from lists.gnu.org ([2001:470:142::17]:33002)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <necto.ne@HIDDEN>)
 id 1ttRp3-0003df-39
 for submit <at> debbugs.gnu.org; Sat, 15 Mar 2025 09:45:07 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <necto.ne@HIDDEN>)
 id 1ttRov-0004XK-C2
 for guix-patches@HIDDEN; Sat, 15 Mar 2025 09:44:57 -0400
Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <necto.ne@HIDDEN>)
 id 1ttRot-0007ia-OO
 for guix-patches@HIDDEN; Sat, 15 Mar 2025 09:44:57 -0400
Received: by mail-ej1-x629.google.com with SMTP id
 a640c23a62f3a-aaeec07b705so471873066b.2
 for <guix-patches@HIDDEN>; Sat, 15 Mar 2025 06:44:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1742046293; x=1742651093; darn=gnu.org;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=h4uPEb8vHe69+7b6Lt8oHzJWfVzpIHOhGzlYtBSdOAQ=;
 b=XAUO2ue/WBp2czrLwHiXuQGC1SNA3BW+Z276G0v/kr444aCOVtzbdlgckxOS5AHSIa
 KtKuj7ixl1JASU1yFcn2MLeCP4cKjgSbxr3jM3EaXZYXMJICsWAipe64WxTfLTqELZ6V
 G4nzHYee7OxrgW2fLjJ0S3ZjFX5mRjULPGVRd0Oh3AtTq20abrL8oqDBczS7tBtrQj84
 NfJosogaTWPZ/Bud2zZ9v9amscCTISqZXWOsOWyH/XlDDWrTQ+HMsQUG52BP5GdLuqpq
 cB7jLe/Kmgq83D1rmB8o4HCFDIInUdCCxhNX9EVVi51dcWuyGNEXi9uXPRAVHh7gBf6W
 H/ZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1742046293; x=1742651093;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=h4uPEb8vHe69+7b6Lt8oHzJWfVzpIHOhGzlYtBSdOAQ=;
 b=Q5Grwi7f3siLZUr9RRE2um5mz5Gg/2Q1OnK+0mT+2AoTjY/i5DMJgtn192z+aLa9FM
 0IGMZfbXOjRaThCi2mQefyCGdZxRGWp9DoU50aE/oOXOTB28+fxCNPLG37BaYB/LdPd5
 2kKRJYYcldRcseAv3um95SS/JcrZ8+y6XMUMW8OtvF3LT/wMHUAu1EL12siyw2ZqvUGs
 2TF2bynjSkIo/X53y/9O5iPIdSgpjr+4e60wFmJ13/yz07FXO1pGaG6wzEqt8FhF4zwV
 Z6DHNLHsYzF8CmdjJ9jYOLF/C6zYEb60UZ7PsajS4Yc8Dq2b+dpEg+divmg0QlEkshmO
 W/TQ==
X-Gm-Message-State: AOJu0YzNvOq0aj2J9nkKmAWsxdPMtQubDK+rpnSwbvSZGaaAOVG6ZsKp
 YLJvTOMDe87ad1fB+pyZBTwZU15RFv79eI7P56APm8NiOlS99oK4KrnXpPLy
X-Gm-Gg: ASbGncuV6ztlflsjtYvVcl9Pye/GHC+JajwKzKZC+8+0qwWHlL4jK7Z/h/iY//nFe0C
 dVG3/Fah7jFRqXq1RQito4SyIhpAEBWsQSWTzo0mcu1GNrO1X39s1tGgToOCsgz5hfjbEFEzd3p
 xnj7/oAypevRlk3ZRRfVW6UUO1Krax1TgzUSG2FML4r2g+nZOWi5mMkNWBNtMEqZB23MMbduPzw
 hQQx8gcqImy7u11vfIRFOJH6g0WEZsnqhb2OxVYdhQnSy4k7kLBiDOKSCrF6rhAGvaCNzY9LZh4
 zvToNnBkCi24ARWmBYveESeMhIZ2WnlZqh1j
X-Google-Smtp-Source: AGHT+IEOAStrePucqKrB+/Iro5hGxlFll8heg2Lpejg3j3dirfv7mwgnGNIj21eItw/yAieDw0xyhA==
X-Received: by 2002:a17:907:3f97:b0:ac3:47b1:d210 with SMTP id
 a640c23a62f3a-ac347b1e834mr306749066b.39.1742046293015; 
 Sat, 15 Mar 2025 06:44:53 -0700 (PDT)
Received: from frame.. ([2a04:ee41:82:f4e6:77fe:705:8fce:6f1])
 by smtp.gmail.com with ESMTPSA id
 a640c23a62f3a-ac3149ce7e1sm376118666b.107.2025.03.15.06.44.52
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 15 Mar 2025 06:44:52 -0700 (PDT)
From: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH 0/3] Update uftrace to v0.17 and enable its tests
Date: Sat, 15 Mar 2025 14:44:48 +0100
Message-ID: <20250315134450.3310411-1-necto.ne@HIDDEN>
X-Mailer: git-send-email 2.48.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::629;
 envelope-from=necto.ne@HIDDEN; helo=mail-ej1-x629.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Sat, 15 Mar 2025 12:08:38 -0400
Cc: Arseniy Zaostrovnykh <necto.ne@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Date: Sat, 15 Mar 2025 13:25:17 +0100
Message-ID: <cover.1742041517.git.necto.ne@HIDDEN>
base-commit: 92124591eedf27e988c84f75acd4b4d99ff43122
From de35530f377cc2bcc3a68efa55d28ee3e42703fb Mon Sep 17 00:00:00 2001
This patch series takes care of updating uftrace to the most recent version
v0.17 and enables the run of all tests, not just the unit tests. To that end I
had to also add explicit dependencies on python and luajit because some tests
test this optional functionality.

uftrace loads the libpython and libluajit libraries dynamically with dlload,
which fails to find them in the user .guix-profile, so their /gnu/store paths
have to be hardcoded at the build stage. I made these depencencies, which are
arguable rather large, optional in a sense that a user can define a package
variant that excludes them and it will build properly. Let me know if there is
a better way to manage optional dependencies.

 gnu/packages/instrumentation.scm             | 67 ++++++++++++++------
 gnu/packages/patches/uftrace-fix-tests.patch | 32 ++++++++++
 2 files changed, 79 insertions(+), 20 deletions(-)
 create mode 100644 gnu/packages/patches/uftrace-fix-tests.patch

Arseniy Zaostrovnykh (3):
  gnu: uftrace: Enable python and lua scripting and fix tests
  gnu: uftrace: Update to 0.17
  gnu: uftrace: Make python and luajit inputs optional


-- 
2.48.1



------------=_1743605642-16558-1--

Last modified: Wed, 2 Apr 2025 15:00:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.