Received: (at 77058) by debbugs.gnu.org; 30 Mar 2025 16:57:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 30 12:57:53 2025
Received: from localhost ([127.0.0.1]:37961 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tyvyr-0002Fv-0w
for submit <at> debbugs.gnu.org; Sun, 30 Mar 2025 12:57:53 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6114)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1tyvyo-0002Fg-IZ
for 77058 <at> debbugs.gnu.org; Sun, 30 Mar 2025 12:57:51 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 59C9B100045;
Sun, 30 Mar 2025 12:57:44 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1743353859;
bh=MEoZKuUO62WZX9cvCMTOUJAnSA6NrIzhRDgi9z+TC5s=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=pFvSOJC7iLxZSGnZ6m5RUsryt04OHWtvvpgTHfOhQYW62cHeQRWGR1QPG4fTN4sMw
HzPi7puYbiWrHnLMTBPKMF2v6fgM2iF/gzW9rspMI5nfgynKKXA4XSsQMJn4mmW0R+
iThWylFe3Q4MXSyEbA/h5uxu/N8Wxumm3rPVsYOhRBQzS6p/aiGld+kh4f/nly25d4
dC6yidTAh2eFeBVQQy8pdAGksFDvLgYx3hWvEEIOfEZW4BDiCmCOtzQkzqwA/hPFT/
7JXLkvAGE7P7x3N59be+ONbHJXa57hJMMofdLeURqx6cTcLH+skxQnTG4wUqksjtVt
CyBY3DtDDUqpw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9101110002E;
Sun, 30 Mar 2025 12:57:39 -0400 (EDT)
Received: from pastel (unknown [104.247.242.5])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5A7BE1202F7;
Sun, 30 Mar 2025 12:57:39 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: okamsn@HIDDEN
Subject: Re: bug#77058: [PATCH] Add cl-with-accessors
In-Reply-To: <ec78bdac-4f2c-4dc8-8d94-49023d636e33@HIDDEN>
Message-ID: <jwvcydybgwx.fsf-monnier+emacs@HIDDEN>
References: <4d1b2975-b3ea-427e-a991-3e5123807677@HIDDEN>
<jwvpliexr8c.fsf-monnier+emacs@HIDDEN> <86r02g6pod.fsf@HIDDEN>
<m1zfh3ddz6.fsf@HIDDEN>
<ec78bdac-4f2c-4dc8-8d94-49023d636e33@HIDDEN>
Date: Sun, 30 Mar 2025 12:57:38 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.380 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
KAM_SHORT 0.001 Use of a URL Shortener for very short URL
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 77058
Cc: Eli Zaretskii <eliz@HIDDEN>, Daniel Colascione <dancol@HIDDEN>,
77058 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> You could get away from the need for compile-time visible of classes
>> by switching from cl-symbol-macrolet to a custom expander function
>> (which is how cl-symbol-macrolet itself is implemented), but I was
>> too lazy.
I don't think this comment by Daniel was about your code but about his.
At least, AFAICT, your code already does not need compile-time
visibility of classes (it's not even specific to classes at all).
> I wrote `cl-with-accessors' with `cl-symbol-macrolet' because the
> definition at http://clhs.lisp.se/Body/m_w_acce.htm used
> `symbol-macrolet'. Do you believe that it should be done differently or
> be more like what you wrote?
While it's often simpler to forgo `cl-macrolet` and directly call
`macroexpand-all` instead, the implementation of `cl-symbol-macrolet` is
significantly more delicate, so the use of `cl-symbol-macrolet` is the
right choice here.
> + (_
> + (error "Malformed `cl-with-accessors' binding: %s" b))))
This should be `%S` rather than `%s`.
Stefan
bug-gnu-emacs@HIDDEN:bug#77058; Package emacs.
Full text available.Received: (at 77058) by debbugs.gnu.org; 29 Mar 2025 23:57:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 29 19:57:09 2025 Received: from localhost ([127.0.0.1]:33478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tyg32-0000iy-4l for submit <at> debbugs.gnu.org; Sat, 29 Mar 2025 19:57:08 -0400 Received: from mail-24416.protonmail.ch ([109.224.244.16]:40275) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <okamsn@HIDDEN>) id 1tyg2w-0000iI-5e for 77058 <at> debbugs.gnu.org; Sat, 29 Mar 2025 19:57:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1743292614; x=1743551814; bh=5YYTw0JB8MUA2N2sKhgjWVQN1BTrEYHsOsZC2BG6KAQ=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=QzhGCgGGjnwA5UdbdypXqs4RPIEaCBcb6zfKHJCW8jr0ZwQ6JIAyxmTT4Y4fjagg/ 3kyXwUHU7fw9k8261PdCsfvji2ffR7wla1Lpce4SkOmN+wRDAkLr46CmPFWmORHrFH Rm4tdcv50EXXpocmCbMGgMH3+vnd3LvcnP3XQeGXRfj0vA9fZu36NbZeBWAiPtRrES Kqx/1wpxER58HDGbyeioUGaohyEkebufsDlramteOgAKV1taUz9P68qn2gMbNThMD5 qUmh42y2sDfzRc/JS9t47q/L7i4JfBXne2rFFoISdJjerMZtswUjz2iUbmuj+x+nYm M/6HF5Hgg8nbg== Date: Sat, 29 Mar 2025 23:56:48 +0000 To: Daniel Colascione <dancol@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> From: okamsn@HIDDEN Subject: Re: bug#77058: [PATCH] Add cl-with-accessors Message-ID: <ec78bdac-4f2c-4dc8-8d94-49023d636e33@HIDDEN> In-Reply-To: <m1zfh3ddz6.fsf@HIDDEN> References: <4d1b2975-b3ea-427e-a991-3e5123807677@HIDDEN> <jwvpliexr8c.fsf-monnier+emacs@HIDDEN> <86r02g6pod.fsf@HIDDEN> <m1zfh3ddz6.fsf@HIDDEN> Feedback-ID: 25935600:user:proton X-Pm-Message-ID: 423f13e45a140d8748143a745ef9167df3bbf8bb MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1=_Utzq8cTNTAqFDff765Ix9uibS0ikd1NVRF09bu24As" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77058 Cc: 77058 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --b1=_Utzq8cTNTAqFDff765Ix9uibS0ikd1NVRF09bu24As Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, I apologize for missing Stefan's response. Daniel Colascione wrote: > Eli Zaretskii <eliz@HIDDEN> writes: >=20 >> Ping! Okamsn, would you like to submit an updated patch? >> >>> Stefan Monnier wrote:>>>> Also, in the test=20 `cl-lib-struct-accessors' in >>>> test/lisp/emacs-lisp/cl-lib-tests.el, it checks for the keyword >>>> `:readonly', but the documented keyword is `:read-only'. Is this a >>>> typo, or was this intentional? >>> >>> I'd go with "typo". I've added a separate patch file to change it from `:readonly' to=20 `:read-only'. >>> It'd be worthwhile to mention that it also works with accessors of othe= r >>> objects than structs, e.g. `car`, or `process-filter`. >>> ... >>> so maybe it's worth mentioning `with-slots` (which arguably should be >>> moved to `cl-lib`). I've mentioned `with-slots' and that `cl-with-accessors' works with `car'. >>> I think this should be moved to a CL-Lib subsection in the >>> "package-specific changes" section. Done. I did not move the entry about `cl-type-of'. I see that it is=20 written in C. >>> I'd use `VAR` or `SYMBOL` rather than `SYMBOL-NAME`. >>> Probably similarly use `ACCESSOR` rather than `ACCESSOR-NAME`. >>> ... >>> Should be lower case `&rest` on this last line. >>> ... >>> I think `place` is wrong here. `(person-age FOO)` is a "place" but >>> `person-age` is not (or, well, it is but not the right one: when taken >>> as a place it refers to the variable, not the accessor). >>> I think it should just be `symbolp`. >>> ... >>> Please use the same format as other similar warnings we have, such as: >>> I've made these changes. I changed SYMBOL-NAME to NAME to be consistent=20 with `cl-symbol-macrolet'. > ... > You could get away from> the need for compile-time visible of classes=20 by switching from > cl-symbol-macrolet to a custom expander function (which is how > cl-symbol-macrolet itself is implemented), but I was too lazy. Daniel, I wrote `cl-with-accessors' with `cl-symbol-macrolet' because the=20 definition at http://clhs.lisp.se/Body/m_w_acce.htm used=20 `symbol-macrolet'. Do you believe that it should be done differently or=20 be more like what you wrote? Thank you. --b1=_Utzq8cTNTAqFDff765Ix9uibS0ikd1NVRF09bu24As Content-Type: text/x-patch; charset=UTF-8; name=v3-0001-Fix-typo-in-test-of-read-only-cl-defstruct-slot.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=v3-0001-Fix-typo-in-test-of-read-only-cl-defstruct-slot.patch RnJvbSAyODc3ZWE0Y2M1NDQwMjUzNWVkYjZmNWQ4ZDUwYTJhN2FlMWM3OWNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFYXJsIEh5YXR0IDxva2Ftc25AcHJvdG9ubWFpbC5jb20+CkRh dGU6IFNhdCwgMjkgTWFyIDIwMjUgMTc6MzA6NDggLTA0MDAKU3ViamVjdDogW1BBVENIIHYzIDEv Ml0gRml4IHR5cG8gaW4gdGVzdCBvZiByZWFkLW9ubHkgY2wtZGVmc3RydWN0IHNsb3QuCgoqIHRl c3QvbGlzcC9lbWFjcy1saXNwL2NsLWxpYi10ZXN0cy5lbCAobXlzdHJ1Y3QpCihjbC1saWItc3Ry dWN0LWFjY2Vzc29ycyk6IFVzZSAiOnJlYWQtb25seSIgaW5zdGVhZCBvZiAiOnJlYWRvbmx5Ii4K CiogdGVzdC9saXNwL2VtYWNzLWxpc3AvY2wtbGliLXRlc3RzLmVsIChjbC1saWItc3RydWN0LWFj Y2Vzc29ycyk6ClRlc3QgdXNpbmcgYHNldGYnIG9uIHJlYWQtb25seSBhY2Nlc3NvciB0byBtYWtl IHN1cmUgdGhlIGNvcnJlY3Qga2V5d29yZAppcyB1c2VkLgotLS0KIHRlc3QvbGlzcC9lbWFjcy1s aXNwL2NsLWxpYi10ZXN0cy5lbCB8IDUgKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlv bnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VtYWNzLWxpc3Av Y2wtbGliLXRlc3RzLmVsIGIvdGVzdC9saXNwL2VtYWNzLWxpc3AvY2wtbGliLXRlc3RzLmVsCmlu ZGV4IGE5YzcxZmE1ODA4Li5lZDdjOGI1OThlYSAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL2VtYWNz LWxpc3AvY2wtbGliLXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2NsLWxpYi10 ZXN0cy5lbApAQCAtMjA5LDcgKzIwOSw3IEBAIGNsLWxpYi1lbXB0eS1rZXlhcmdzCiAgICAgICAg ICAgICAgICAoOmNvbnN0cnVjdG9yIGNsLWxpYi0tY29uLTEgKCZhdXggKGFiYyAxKSkpCiAgICAg ICAgICAgICAgICAoOmNvbnN0cnVjdG9yIGNsLWxpYi0tY29uLTIgKCZvcHRpb25hbCBkZWYpICJD b25zdHJ1Y3RvciBkb2NzdHJpbmcuIikpCiAgICJHZW5lcmFsIGRvY3N0cmluZy4iCi0gIChhYmMg NSA6cmVhZG9ubHkgdCkgKGRlZiBuaWwpKQorICAoYWJjIDUgOnJlYWQtb25seSB0KSAoZGVmIG5p bCkpCiAoZXJ0LWRlZnRlc3QgY2wtbGliLXN0cnVjdC1hY2Nlc3NvcnMgKCkKICAgKGxldCAoKHgg KG1ha2UtbXlzdHJ1Y3QgOmFiYyAxIDpkZWYgMikpKQogICAgIChzaG91bGQgKGVxbCAoY2wtc3Ry dWN0LXNsb3QtdmFsdWUgJ215c3RydWN0ICdhYmMgeCkgMSkpCkBAIC0yMTgsOCArMjE4LDkgQEAg Y2wtbGliLXN0cnVjdC1hY2Nlc3NvcnMKICAgICAoc2hvdWxkIChlcWwgKGNsLXN0cnVjdC1zbG90 LXZhbHVlICdteXN0cnVjdCAnZGVmIHgpIC0xKSkKICAgICAoc2hvdWxkIChlcWwgKGNsLXN0cnVj dC1zbG90LW9mZnNldCAnbXlzdHJ1Y3QgJ2FiYykgMSkpCiAgICAgKHNob3VsZC1lcnJvciAoY2wt c3RydWN0LXNsb3Qtb2Zmc2V0ICdteXN0cnVjdCAnbWFyeXBvcHBpbnMpKQorICAgIChzaG91bGQt ZXJyb3IgKHNldGYgKG15c3RydWN0LWFiYyB4KSAzKSkKICAgICAoc2hvdWxkIChwY2FzZSAoY2wt c3RydWN0LXNsb3QtaW5mbyAnbXlzdHJ1Y3QpCi0gICAgICAgICAgICAgIChgKChjbC10YWctc2xv dCkgKGFiYyA1IDpyZWFkb25seSB0KQorICAgICAgICAgICAgICAoYCgoY2wtdGFnLXNsb3QpIChh YmMgNSA6cmVhZC1vbmx5IHQpCiAgICAgICAgICAgICAgICAgIChkZWYgLiAsKG9yICduaWwgJyhu aWwpKSkpCiAgICAgICAgICAgICAgICB0KSkpKSkKIChlcnQtZGVmdGVzdCBjbC1saWItc3RydWN0 LWNvbnN0cnVjdG9ycyAoKQotLSAKMi40My4wCgo= --b1=_Utzq8cTNTAqFDff765Ix9uibS0ikd1NVRF09bu24As Content-Type: text/x-patch; charset=UTF-8; name=v3-0002-Add-cl-with-accessors.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=v3-0002-Add-cl-with-accessors.patch RnJvbSAwZmFkMjUyNDkwNjc0YzNhYmVhOGUzYWIzZjMzMDQ0ZTJhNWU2NTUxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFYXJsIEh5YXR0IDxva2Ftc25AcHJvdG9ubWFpbC5jb20+CkRh dGU6IFdlZCwgMTIgTWFyIDIwMjUgMjM6MDE6NDkgLTA0MDAKU3ViamVjdDogW1BBVENIIHYzIDIv Ml0gQWRkIGNsLXdpdGgtYWNjZXNzb3JzCgoqIGRvYy9taXNjL2NsLnRleGkgKFN0cnVjdHVyZXMp OiBNZW50aW9uIHRoZSBuZXcgbWFjcm8uCiogbGlzcC9lbWFjcy1saXNwL2NsLW1hY3MuZWwgKGNs LXdpdGgtYWNjZXNzb3JzKTogQWRkIHRoZSBtYWNyby4KKiB0ZXN0L2xpc3AvZW1hY3MtbGlzcC9j bC1saWItdGVzdHMuZWwgKGNsLWxpYi1zdHJ1Y3Qtd2l0aC1hY2Nlc3NvcnMpOgpUZXN0IHRoZSBt YWNyby4KKiBldGMvTkVXUyAoTmV3IG1hY3JvICdjbC13aXRoLWFjY2Vzc29ycycuKTogTWVudGlv biB0aGUgbWFjcm8uCgpUaGlzIG1hY3JvIGlzIHVzZWZ1bCB3aGVuIG1ha2luZyByZXBlYXRlZCB1 c2Ugb2YgYSBzdHJ1Y3R1cmVzIGFjY2Vzc29yCmZ1bmN0aW9ucywgc3VjaCBhcyByZWFkaW5nIGZy b20gYSBzbG90IGFuZCB0aGVuIHdyaXRpbmcgdG8gYSBzbG90LiAgSXQKaXMgc2ltaWxhciB0byAn d2l0aC1zbG90cycgZnJvbSBFSUVJTywgYnV0IHVzZXMgYWNjZXNzb3IgZnVuY3Rpb25zCmluc3Rl YWQgb2Ygc2xvdCBuYW1lcy4KLS0tCiBkb2MvbWlzYy9jbC50ZXhpICAgICAgICAgICAgICAgICAg ICAgfCA0OSArKysrKysrKysrKysrKysrKysrKysrKysrKysrCiBldGMvTkVXUyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgfCAxMCArKysrKysKIGxpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLmVs ICAgICAgICAgICB8IDQ0ICsrKysrKysrKysrKysrKysrKysrKysrKysKIHRlc3QvbGlzcC9lbWFj cy1saXNwL2NsLWxpYi10ZXN0cy5lbCB8IDE0ICsrKysrKysrCiA0IGZpbGVzIGNoYW5nZWQsIDEx NyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZG9jL21pc2MvY2wudGV4aSBiL2RvYy9taXNj L2NsLnRleGkKaW5kZXggNDhiOGVhMDljNjUuLmU0NWJmOGNiMGNhIDEwMDY0NAotLS0gYS9kb2Mv bWlzYy9jbC50ZXhpCisrKyBiL2RvYy9taXNjL2NsLnRleGkKQEAgLTQyMjUsNiArNDIyNSw1NSBA QCBTdHJ1Y3R1cmVzCiAKIE90aGVyIHNsb3Qgb3B0aW9ucyBhcmUgY3VycmVudGx5IGlnbm9yZWQu CiAKK0BkZWZtYWMgY2wtd2l0aC1hY2Nlc3NvcnMgbmFtZSBiaW5kaW5ncyBib2R5QGRvdHt9CitZ b3UgY2FuIHVzZSBAY29kZXtjbC13aXRoLWFjY2Vzc29yc30gdG8gbGV4aWNhbGx5IGRlZmluZSBz eW1ib2xzIGFzCitleHByZXNzaW9ucyBjYWxsaW5nIHRoZSBnaXZlbiBhY2Nlc3NvciBmdW5jdGlv bnMgb24gYSBzaW5nbGUgaW5zdGFuY2Ugb2YKK2Egc3RydWN0dXJlIG9yIGNsYXNzIGRlZmluZWQg YnkgQGNvZGV7Y2wtZGVmc3RydWN0fSBvciBAY29kZXtkZWZjbGFzc30KKyhAcHhyZWZ7ZWllaW99 KS4gIFRoaXMgY2FuIHNpbXBsaWZ5IGNvZGUgdGhhdCByZXBlYXRlZGx5IGFjY2Vzc2VzIHNsb3Rz LgorV2l0aCBpdCwgeW91IGNhbiB1c2UgQGNvZGV7c2V0Zn0gYW5kIEBjb2Rle3NldHF9IG9uIHRo ZSBzeW1ib2xzIGxpa2UKK25vcm1hbCB2YXJpYWJsZXMsIG1vZGlmeWluZyB0aGUgdmFsdWVzIGlu IHRoZSBzdHJ1Y3R1cmUuICBVbmxpa2UgdGhlCittYWNybyBAY29kZXt3aXRoLXNsb3RzfSAoQHB4 cmVme0FjY2Vzc2luZyBTbG90cywsLGVpZWlvLEVJRUlPfSksIGJlY2F1c2UKK3RoZSBzeW1ib2wg ZXhwYW5kcyB0byBhIGZ1bmN0aW9uIGNhbGwsIEBjb2Rle2NsLXdpdGgtYWNjZXNzb3JzfSBjYW4g YmUKK3VzZWQgd2l0aCBhbnkgZ2VuZXJhbGl6ZWQgdmFyaWFibGUgdGhhdCBjYW4gdGFrZSBhIHNp bmdsZSBhcmd1bWVudCwgc3VjaAorYXMgQGNvZGV7Y2wtZmlyc3R9IGFuZCBAY29kZXtjbC1yZXN0 fS4KK0BlbmQgZGVmbWFjCisKK0BleGFtcGxlCis7OyBVc2luZyBhY2Nlc3NvcnMgd2l0aCBsb25n LCBjbGVhciBuYW1lcyB3aXRob3V0IHRoZSBtYWNybzoKKyhkZWZ1biBpbnRlcm5hbC1ub3JtYWxp emF0aW9uIChwZXJzb24pCisgICJDb3JyZWN0IHRoZSB2YWx1ZXMgb2YgdGhlIHNsb3RzIGluIFBF UlNPTiB0byBiZSBhcyBleHBlY3RlZC4iCisgIDs7IENoZWNrIHRoZSB2YWx1ZXMgb2YgdGhlIHN0 cnVjdHVyZToKKyAgKHdoZW4gKGVxdWFsIChwZXJzb24tb3B0aW9uYWwtc2Vjb25kYXJ5LWRhdGEg cGVyc29uKSAiIikKKyAgICAoc2V0ZiAocGVyc29uLW9wdGlvbmFsLXNlY29uZGFyeS1kYXRhIHBl cnNvbikgbmlsKSkKKyAgKHdoZW4gKG51bGwgKHBlcnNvbi1hY2Nlc3Mtc2V0dGluZ3MgcGVyc29u KSkKKyAgICAoc2V0ZiAocGVyc29uLWFjY2Vzcy1zZXR0aW5ncyBwZXJzb24pICdkZWZhdWx0KSkK KyAgKHdoZW4gKDwgKGxvbmctYWNjZXNzb3ItbmFtZS10aGF0LWNhbi1iZWNvbWUtdW5yZWFkYWJs ZS13aGVuLXJlcGVhdGVkCisgICAgICAgICAgICBwZXJzb24pCisgICAgICAgICAgIDkpCisgICAg KGNsLWluY2YgKGxvbmctYWNjZXNzb3ItbmFtZS10aGF0LWNhbi1iZWNvbWUtdW5yZWFkYWJsZS13 aGVuLXJlcGVhdGVkCisgICAgICAgICAgICAgIHBlcnNvbikKKyAgICAgICAgICAgICAxMDApKQor ICA7OyBBbmQgc28gb24gYmVmb3JlIHJldHVybmluZyB0aGUgc3RydWN0dXJlOgorICBwZXJzb24p CisKKzs7IFVzaW5nIGFjY2Vzc29ycyB3aXRoIGxvbmcsIGNsZWFyIG5hbWVzIHdpdGggdGhlIG1h Y3JvOgorKGRlZnVuIGludGVybmFsLW5vcm1hbGl6YXRpb24gKHBlcnNvbikKKyAgIkNvcnJlY3Qg dGhlIHZhbHVlcyBvZiB0aGUgc2xvdHMgaW4gUEVSU09OIHRvIGJlIGFzIGV4cGVjdGVkLiIKKyAg KGNsLXdpdGgtYWNjZXNzb3JzICgoc2Vjb25kYXJ5LWRhdGEgcGVyc29uLW9wdGlvbmFsLXNlY29u ZGFyeS1kYXRhKQorICAgICAgICAgICAgICAgICAgICAgIChhY2Nlc3Mtc2V0dGluZ3MgcGVyc29u LWFjY2Vzcy1zZXR0aW5ncykKKyAgICAgICAgICAgICAgICAgICAgICAoc2hvcnQtbmFtZSBwZXJz b24tbXVjaC1sb25nZXItYWNjZXNzb3ItbmFtZSkpCisgICAgICBwZXJzb24KKyAgICA7OyBDaGVj ayB0aGUgdmFsdWVzIG9mIHRoZSBzdHJ1Y3R1cmU6CisgICAgKHdoZW4gKGVxdWFsIHNlY29uZGFy eS1kYXRhICIiKQorICAgICAgKHNldGYgc2Vjb25kYXJ5LWRhdGEgbmlsKSkKKyAgICAod2hlbiAo bnVsbCBhY2Nlc3Mtc2V0dGluZ3MpCisgICAgICAoc2V0ZiBhY2Nlc3Mtc2V0dGluZ3MgJ2RlZmF1 bHQpKQorICAgICh3aGVuICg8IHNob3J0LW5hbWUgOSkKKyAgICAgIChjbC1pbmNmIHNob3J0LW5h bWUgMTAwKSkKKyAgICA7OyBBbmQgc28gb24gYmVmb3JlIHJldHVybmluZyB0aGUgc3RydWN0dXJl OgorICAgIHBlcnNvbikpCitAZW5kIGV4YW1wbGUKKwogRm9yIG9ic2N1cmUgaGlzdG9yaWNhbCBy ZWFzb25zLCBzdHJ1Y3R1cmUgb3B0aW9ucyB0YWtlIGEgZGlmZmVyZW50CiBmb3JtIHRoYW4gc2xv dCBvcHRpb25zLiAgQSBzdHJ1Y3R1cmUgb3B0aW9uIGlzIGVpdGhlciBhIGtleXdvcmQKIHN5bWJv bCwgb3IgYSBsaXN0IGJlZ2lubmluZyB3aXRoIGEga2V5d29yZCBzeW1ib2wgcG9zc2libHkgZm9s bG93ZWQKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggMzFhMGM0OTM4YWQu LjY2MjgwYjhjOWFlIDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtMjA5 Miw2ICsyMDkyLDE2IEBAIHRoYXQgaXMsIGJ1ZmZlcnMgbm90IHZpc2l0aW5nIGEgZmlsZSBhbmQg d2hvc2UgbmFtZXMgc3RhcnQgd2l0aCBhIHNwYWNlLgogUHJldmlvdXNseSwgc3VjaCBidWZmZXJz IHdlcmUgbmV2ZXIgc2hvd24uICBUaGlzIGNvbW1hbmQgaXMgYm91bmQgdG8gJ0knCiBpbiBCdWZm ZXIgTWVudSBtb2RlLgogCisqKiBDTC1MaWIKKworKysrCisqKiogTmV3IG1hY3JvICdjbC13aXRo LWFjY2Vzc29ycycuCitUaGlzIG1hY3JvIGlzIHNpbWlsYXIgdG8gJ3dpdGgtc2xvdHMnLCBidXQg dXNlcyBhY2Nlc3NvciBmdW5jdGlvbnMKK2luc3RlYWQgb2Ygc2xvdCBuYW1lcy4gIEl0IGlzIHVz ZWZ1bCB3aGVuIHNsb3RzJyBhY2Nlc3NvciBmdW5jdGlvbnMgYXJlCit1c2VkIHJlcGVhdGVkbHks IHN1Y2ggYXMgcmVhZGluZyBmcm9tIGEgc2xvdCBhbmQgdGhlbiB3cml0aW5nIHRvIHRoYXQKK3Ns b3QuICBTeW1ib2wgbWFjcm9zIGFyZSBjcmVhdGVkIGZvciB0aGUgYWNjZXNzb3IgZnVuY3Rpb25z IHVzaW5nCisnY2wtc3ltYm9sLW1hY3JvbGV0Jywgc28gdGhhdCB0aGV5IGNhbiBiZSB1c2VkIHdp dGggJ3NldHEnIGFuZCAnc2V0ZicuCisKICoqIE1pc2NlbGxhbmVvdXMKIAogKysrCmRpZmYgLS1n aXQgYS9saXNwL2VtYWNzLWxpc3AvY2wtbWFjcy5lbCBiL2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNz LmVsCmluZGV4IGIwN2E4ODFiYTQ4Li44ZjFkYzcxMjhjMiAxMDA2NDQKLS0tIGEvbGlzcC9lbWFj cy1saXNwL2NsLW1hY3MuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL2NsLW1hY3MuZWwKQEAgLTI1 NDQsNiArMjU0NCw1MCBAQCBjbC1vbmNlLW9ubHkKICAgICAgICAgICAgICAgICAgICAgICAgICAg Y29sbGVjdCBgKCwoY2FyIG5hbWUpICxnZW5zeW0pKQogICAgICAgICAgICAgICxAYm9keSkpKSkp CiAKKzs7OyMjI2F1dG9sb2FkCisoZGVmbWFjcm8gY2wtd2l0aC1hY2Nlc3NvcnMgKGJpbmRpbmdz IGluc3RhbmNlICZyZXN0IGJvZHkpCisgICJVc2UgQklORElOR1MgYXMgZnVuY3Rpb24gY2FsbHMg b24gSU5TVEFOQ0UgaW5zaWRlIEJPRFkuCisKK1RoaXMgbWFjcm8gaGVscHMgd2hlbiB3cml0aW5n IGNvZGUgdGhhdCBtYWtlcyByZXBlYXRlZCB1c2Ugb2YgdGhlCithY2Nlc3NvciBmdW5jdGlvbnMg b2YgYSBzdHJ1Y3R1cmUgb3Igb2JqZWN0IGluc3RhbmNlLCBzdWNoIGFzIHRob3NlCitjcmVhdGVk IGJ5IGBjbC1kZWZzdHJ1Y3QnIGFuZCBgZGVmY2xhc3MnLgorCitCSU5ESU5HUyBpcyBhIGxpc3Qg b2YgKE5BTUUgQUNDRVNTT1IpIHBhaXJzLiAgSW5zaWRlIEJPRFksIE5BTUUgaXMKK3RyZWF0ZWQg YXMgdGhlIGZ1bmN0aW9uIGNhbGwgKEFDQ0VTU09SIElOU1RBTkNFKSB1c2luZworYGNsLXN5bWJv bC1tYWNyb2xldCcuICBOQU1FIGNhbiBiZSB1c2VkIHdpdGggYHNldGYnIGFuZCBgc2V0cScgYXMg YQorZ2VuZXJhbGl6ZWQgdmFyaWFibGUuICBCZWNhdXNlIG9mIGhvdyB0aGUgYWNjZXNzb3IgaXMg dXNlZCwKK2BjbC13aXRoLWFjY2Vzc29ycycgY2FuIGJlIHVzZWQgd2l0aCBhbnkgZ2VuZXJhbGl6 ZWQgdmFyaWFibGUgdGhhdCBjYW4KK3Rha2UgYSBzaW5nbGUgYXJndW1lbnQsIHN1Y2ggYXMgYGNh cicgYW5kIGBjZHInLgorCitTZWUgYWxzbyB0aGUgbWFjcm8gYHdpdGgtc2xvdHMnIGRlc2NyaWJl ZCBpbiB0aGUgSW5mbworbm9kZSBgKGVpZWlvKUFjY2Vzc2luZyBTbG90cycsIHdoaWNoIGlzIHNp bWlsYXIsIGJ1dCB1c2VzIHNsb3QgbmFtZXMKK2luc3RlYWQgb2YgYWNjZXNzb3IgZnVuY3Rpb25z LgorCitcKGZuICgoTkFNRSBBQ0NFU1NPUikgLi4uKSBJTlNUQU5DRSAmcmVzdCBCT0RZKSIKKyAg KGRlY2xhcmUgKGRlYnVnIFsoJnJlc3QgKHN5bWJvbHAgc3ltYm9scCkpIGZvcm0gYm9keV0pCisg ICAgICAgICAgIChpbmRlbnQgMikpCisgIChjb25kICgobnVsbCBib2R5KQorICAgICAgICAgKG1h Y3JvZXhwLXdhcm4tYW5kLXJldHVybiAiYGNsLXdpdGgtYWNjZXNzb3JzJyB1c2VkIHdpdGggZW1w dHkgYm9keSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbmlsICdlbXB0eS1i b2R5KSkKKyAgICAgICAgKChudWxsIGJpbmRpbmdzKQorICAgICAgICAgKG1hY3JvZXhwLXdhcm4t YW5kLXJldHVybiAiYGNsLXdpdGgtYWNjZXNzb3JzJyB1c2VkIHdpdGhvdXQgYWNjZXNzb3JzIgor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobWFjcm9leHAtcHJvZ24gYm9keSkK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ3N1c3BpY2lvdXMpKQorICAgICAg ICAodAorICAgICAgICAgKGNsLW9uY2Utb25seSAoaW5zdGFuY2UpCisgICAgICAgICAgIChsZXQg KChzeW1ib2wtbWFjcm9zKSkKKyAgICAgICAgICAgICAoZG9saXN0IChiIGJpbmRpbmdzKQorICAg ICAgICAgICAgICAgKHBjYXNlIGIKKyAgICAgICAgICAgICAgICAgKGAoLChhbmQgKHByZWQgc3lt Ym9scCkgdmFyKQorICAgICAgICAgICAgICAgICAgICAsKGFuZCAocHJlZCBzeW1ib2xwKSBhY2Nl c3NvcikpCisgICAgICAgICAgICAgICAgICAocHVzaCBgKCx2YXIgKCxhY2Nlc3NvciAsaW5zdGFu Y2UpKQorICAgICAgICAgICAgICAgICAgICAgICAgc3ltYm9sLW1hY3JvcykpCisgICAgICAgICAg ICAgICAgIChfCisgICAgICAgICAgICAgICAgICAoZXJyb3IgIk1hbGZvcm1lZCBgY2wtd2l0aC1h Y2Nlc3NvcnMnIGJpbmRpbmc6ICVzIiBiKSkpKQorICAgICAgICAgICAgIGAoY2wtc3ltYm9sLW1h Y3JvbGV0CisgICAgICAgICAgICAgICAgICAsc3ltYm9sLW1hY3JvcworICAgICAgICAgICAgICAg ICxAYm9keSkpKSkpKQorCiA7OzsgTXVsdGlwbGUgdmFsdWVzLgogCiA7OzsjIyNhdXRvbG9hZApk aWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VtYWNzLWxpc3AvY2wtbGliLXRlc3RzLmVsIGIvdGVzdC9s aXNwL2VtYWNzLWxpc3AvY2wtbGliLXRlc3RzLmVsCmluZGV4IGVkN2M4YjU5OGVhLi44MjM1Njlm YzE4ZiAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL2VtYWNzLWxpc3AvY2wtbGliLXRlc3RzLmVsCisr KyBiL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2NsLWxpYi10ZXN0cy5lbApAQCAtMjI4LDYgKzIyOCwy MCBAQCBjbC1saWItc3RydWN0LWNvbnN0cnVjdG9ycwogICAgICAgICAgICAgICAgICAgICAgICAg KGRvY3VtZW50YXRpb24gJ2NsLWxpYi0tY29uLTIgdCkpKQogICAoc2hvdWxkIChteXN0cnVjdC1w IChjbC1saWItLWNvbi0xKSkpCiAgIChzaG91bGQgKG15c3RydWN0LXAgKGNsLWxpYi0tY29uLTIp KSkpCisoZXJ0LWRlZnRlc3QgY2wtbGliLXN0cnVjdC13aXRoLWFjY2Vzc29ycyAoKQorICAobGV0 ICgoeCAobWFrZS1teXN0cnVjdCA6YWJjIDEgOmRlZiAyKSkpCisgICAgKGNsLXdpdGgtYWNjZXNz b3JzICgoYWJjIG15c3RydWN0LWFiYykKKyAgICAgICAgICAgICAgICAgICAgICAgIChkZWYgbXlz dHJ1Y3QtZGVmKSkKKyAgICAgICAgeAorICAgICAgKHNob3VsZCAoPSBhYmMgMSkpCisgICAgICAo c2hvdWxkLWVycm9yIChzZXRmIGFiYyA5OSkpCisgICAgICAoc2hvdWxkICg9IGRlZiAyKSkKKyAg ICAgIChzZXRmIGRlZiAzKQorICAgICAgKHNob3VsZCAoPSBkZWYgMykpCisgICAgICAoc2V0cSBk ZWYgNCkKKyAgICAgIChzaG91bGQgKD0gZGVmIDQpKSkKKyAgICAoc2hvdWxkICg9IDQgKG15c3Ry dWN0LWRlZiB4KSkpCisgICAgKHNob3VsZCAoPSAxIChteXN0cnVjdC1hYmMgeCkpKSkpCiAKIChl cnQtZGVmdGVzdCBjbC1saWItYXJnbGlzdC1wZXJmb3JtYW5jZSAoKQogICA7OyBBbiBgJmF1eCcg c2hvdWxkIG5vdCBjYXVzZSBsYW1iZGEncyBhcmdsaXN0IHRvIGJlIHR1cm5lZCBpbnRvIGFuICZy ZXN0Ci0tIAoyLjQzLjAKCg== --b1=_Utzq8cTNTAqFDff765Ix9uibS0ikd1NVRF09bu24As--
bug-gnu-emacs@HIDDEN:bug#77058; Package emacs.
Full text available.
Received: (at 77058) by debbugs.gnu.org; 29 Mar 2025 16:00:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 29 12:00:16 2025
Received: from localhost ([127.0.0.1]:60939 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tyYbY-0001WF-1S
for submit <at> debbugs.gnu.org; Sat, 29 Mar 2025 12:00:16 -0400
Received: from dancol.org ([2600:3c01:e000:3d8::1]:47994)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <dancol@HIDDEN>) id 1tyYbV-0001W3-F5
for 77058 <at> debbugs.gnu.org; Sat, 29 Mar 2025 12:00:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org;
s=x;
h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:
Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
List-Post:List-Owner:List-Archive;
bh=vIc4jNeWafAwaOtAk4TppYbhJxMyZISSeUJ1XdnQS5k=; b=PFRGh42GthXRwfoRe+GzNQOv8o
bPshy9IG1Z4fadxtCMDwzZ9wNVTZliUXxWj3Mfs5en+7pdaAGDwBICa/oFxtfFfrFAufLZn2ZXj5h
icSebtd6eYrTKjbFQOt0T96ohzgRY5mc2NSdWUpFu6yd83DipOfK2JY3wia4hg4+mH8kRjIoAUwP1
HvIMFpiyk3EKctRK5+da5JpsJeanW2S+ikRsGfZh7tuwS4r1x6hvao9BDag703cu9Lvs7oz5SDmJX
sShAZfRXMo+mRRrsRWuGe5B52JSh55KSQP3gTzdE0Hb7lermuznTNV0JzQ+FiLLWAfdjPJussrcrF
wLyfy/XA==;
Received: from dancol by dancol.org with local (Exim 4.96)
(envelope-from <dancol@HIDDEN>) id 1tyYaq-004QfI-2f;
Sat, 29 Mar 2025 11:59:32 -0400
From: Daniel Colascione <dancol@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#77058: [PATCH] Add cl-with-accessors
In-Reply-To: <86r02g6pod.fsf@HIDDEN>
References: <4d1b2975-b3ea-427e-a991-3e5123807677@HIDDEN>
<jwvpliexr8c.fsf-monnier+emacs@HIDDEN> <86r02g6pod.fsf@HIDDEN>
User-Agent: mu4e 1.12.8; emacs 31.0.50
Date: Sat, 29 Mar 2025 11:59:57 -0400
Message-ID: <m1zfh3ddz6.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 77058
Cc: okamsn@HIDDEN, 77058 <at> debbugs.gnu.org,
Stefan Monnier <monnier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Eli Zaretskii <eliz@HIDDEN> writes:
> Ping! Okamsn, would you like to submit an updated patch?
>
>> Cc: 77058 <at> debbugs.gnu.org
>> Date: Tue, 18 Mar 2025 12:19:56 -0400
>> From: Stefan Monnier via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>>
>> > The attached patch adds the macro `cl-with-accessors'. This macro uses
>> > `cl-symbol-macrolet' to treat a symbol like a use of an accessor
>> > function, such as those made by `cl-defstruct' and `cl-defclass'. This
>> > can be helpful when using repeated calls to read and write with the
>> > functions.
>>
>> Thanks. See comments below.
>>
>> > Also, in the test `cl-lib-struct-accessors' in
>> > test/lisp/emacs-lisp/cl-lib-tests.el, it checks for the keyword
>> > `:readonly', but the documented keyword is `:read-only'. Is this a
>> > typo, or was this intentional?
>>
>> I'd go with "typo".
>>
>> > --- a/doc/misc/cl.texi
>> > +++ b/doc/misc/cl.texi
>> > @@ -4225,6 +4225,19 @@ Structures
>> >
>> > Other slot options are currently ignored.
>> >
>> > +The macro @code{cl-with-accessors} can simplify code that repeatedly
>> > +accesses slots.
>> > +
>> > +@example
>> > +(defun add-one-year (person)
>> > + (cl-with-accessors ((age person-age))
>> > + person
>> > + (if (null age)
>> > + (error "Age is missing")
>> > + (cl-incf age)))
>> > + person)
>> > +@end example
>>
>> It'd be worthwhile to mention that it also works with accessors of other
>> objects than structs, e.g. `car`, or `process-filter`.
>>
>> Of course, any EIEIO user would rewrite the above to:
>>
>> (defun add-one-year (person)
>> (with-slots (age) person
>> (if (null age)
>> (error "Age is missing")
>> (cl-incf age)))
>> person)
>>
>> so maybe it's worth mentioning `with-slots` (which arguably should be
>> moved to `cl-lib`).
>>
>> > --- a/etc/NEWS
>> > +++ b/etc/NEWS
>> > @@ -2496,6 +2496,13 @@ This function is like 'type-of' except that it sometimes returns
>> > a more precise type. For example, for nil and t it returns 'null'
>> > and 'boolean' respectively, instead of just 'symbol'.
>> >
>> > +** New macro 'cl-with-accessors'
>> > +This macro is similar to 'map-let', but works with structures and their
>> > +accessors functions. It is useful when slots' accessor functions are
>> > +use repeatedly, such as reading from a slot and then writing to that
>> > +slot. Symbol macros are created for the accessor functions using
>> > +'cl-symbol-macrolet', so that they can be used with 'setq' and 'setf'.
>>
>> I think this should be moved to a CL-Lib subsection in the
>> "package-specific changes" section.
>>
>> > +;;;###autoload
>> > +(defmacro cl-with-accessors (bindings instance &rest body)
>> > + "Generate code using symbols as accessing expressions for INSTANCE inside BODY.
>> > +
>> > +This macro helps when writing code that makes repeated use of the
>> > +accessor functions of a structure or object instance, such as those
>> > +created by `cl-defstruct' and `defclass'.
>> > +
>> > +Inside BODY, SYMBOL-NAME is treated as the function call (ACCESSOR-NAME
>> > +INSTANCE) using `cl-symbol-macrolet'. SYMBOL-NAME can be used with
>> > +`setf' and `setq' as a generalized variable.
>>
>> I'd use `VAR` or `SYMBOL` rather than `SYMBOL-NAME`.
>> Probably similarly use `ACCESSOR` rather than `ACCESSOR-NAME`.
>>
>> > +\(fn ((SYMBOL-NAME ACCESSOR-NAME) ...) INSTANCE &REST BODY)"
>>
>> Should be lower case `&rest` on this last line.
>>
>> > + (declare (debug [(&rest (symbolp place)) form body])
>> > + (indent 2))
>>
>> I think `place` is wrong here. `(person-age FOO)` is a "place" but
>> `person-age` is not (or, well, it is but not the right one: when taken
>> as a place it refers to the variable, not the accessor).
>> I think it should just be `symbolp`.
>>
>> > + (cond ((null body)
>> > + (macroexp-warn-and-return "No body given" nil 'empty-body))
>>
>> Please use the same format as other similar warnings we have, such as:
>>
>> (format-message "`unless' with empty body")
>>
>>
>> - Stefan
Cool patch!
I really hate repeating myself in code, so I've been working with a
variant of the idea. It looks like this:
(cl-defmacro jr2-with-slots
((prefix object &optional (class nil class-specified))
&rest body)
"Convenience macro for field access.
In (jr2-with-slots (OBJECT TYPE) BODY..)
Make OBJECT->[SLOT] available in BODY as a generic place referencing
SLOT in OBJECT, which must be a symbol and evaluate to an object of type
TYPE, which must be a `defclass'-ed class name.
The definition of TYPE must be visible to the compiler and so must be
evaluated at both compile time and run time. Use the `jr2-defclass'
macro to automatically make the class definition
available appropriately.
For example:
(jr2-defclass my-class () ((foo) (bar)))
(cl-defmethod initialize-instance :around
((this my-class) &optional _slots)
(jr2-with-slots (this my-class)
(+ this->foo this->bar)))
In this specific case, though, prefer writing (jr2-defmethod ...), which
automatically adds a `jr2-with-slots'.
Within the lexical scope of BODY, the special forms (boundp*
OBJECT->[SLOT]) and (makunbound* OBJECT->[SLOT]) refer to EIEIO
slot-boundedness of SLOT in OBJECT.
Instead of (OBJECT TYPE), you can write (PREFIX OBJECT TYPE), in which
case the slot access symbols are PREFIX[SLOT] and OBJECT need not be
a symbol. For example:
(jr2-with-slots (foo-> (get-foo) my-foo) foo->field)
\(fn (OBJECT TYPE) &rest BODY)"
(declare (indent 1)
(debug (jr2--with-slots-spec body)))
(unless class-specified
(cl-psetf
prefix (intern (format "%s->" (cl-the symbol prefix)))
object prefix
class object))
(unless (class-p class)
(signal 'wrong-type-argument
(list (format
(concat
"%s is not a class: did you forget to make it "
"available at compile time, e.g. by writing it with "
"`jr2-defclass' or wrapping it with `eval-and-compile'?")
class))))
(let* ((slot-info
(cl-loop
for slot in (eieio-class-slots class)
for slot-name = (eieio-slot-descriptor-name slot)
for accessor-name =
(intern (concat (symbol-name prefix) (symbol-name slot-name)))
collect `(,accessor-name ,slot-name)))
;; Generate helpful symbol name for cl-assert
(object-sym (gensym
(if (symbolp object)
(format "#%s#" object) "jr2--object"))))
`(cl-macrolet ((boundp* (form)
(jr2--rewrite-slot-access 'slot-boundp form))
(makunbound* (form)
(jr2--rewrite-slot-access 'slot-makeunbound form)))
(cl-symbol-macrolet
,(cl-loop
for (accessor-name slot-name) in slot-info
collect `(,accessor-name (slot-value ,object-sym ',slot-name)))
(let ((,object-sym ,object))
(cl-check-type ,object-sym ,class)
,@body)))))
(cl-defmacro jr2-with-slots* (specs &rest body)
"Like `jr2-with-slots' but with a list of specifications instead of
just one."
(declare (indent 1) (debug (([&rest jr2--with-slots-spec]) def-body)))
(if (null specs)
(macroexp-progn body)
`(jr2-with-slots ,(car specs)
(jr2-with-slots* ,(cdr specs) ,@body))))
(eval-and-compile
(defun jr2--extract-kw-arg-names (kw-args)
(cl-loop
for arg in kw-args
if (memq arg '(&allow-other-keys)) do (ignore arg)
else if (and (symbolp arg) (string-prefix-p "&" (symbol-name arg)))
do (error "unknown &-directive %S" arg)
else collect (intern (concat ":"
(symbol-name
(cl-the (and symbol (not null))
(or (car-safe arg) arg))))))))
I have various other macros that work with the system, e.g. a
jr2-defmethod. Overall effect is you can write code like this:
(jr2-defclass my-class () (a :type integer))
...
(jr2-defmethod my-method ((this my-class) b)
(+ this->a b))
Look ma, no repetition!
Now, I realize the arrow syntax isn't everyone's cup of tea, but it's
legible and concise --- moreso than oref IMHO. You could get away from
the need for compile-time visible of classes by switching from
cl-symbol-macrolet to a custom expander function (which is how
cl-symbol-macrolet itself is implemented), but I was too lazy.
bug-gnu-emacs@HIDDEN:bug#77058; Package emacs.
Full text available.
Received: (at 77058) by debbugs.gnu.org; 29 Mar 2025 11:29:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 29 07:29:16 2025
Received: from localhost ([127.0.0.1]:57280 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tyUNH-0002cz-Bx
for submit <at> debbugs.gnu.org; Sat, 29 Mar 2025 07:29:15 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:36132)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tyUNF-0002cg-Gs
for 77058 <at> debbugs.gnu.org; Sat, 29 Mar 2025 07:29:13 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1tyUN9-000591-LS; Sat, 29 Mar 2025 07:29:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=RIG4r6Clbz9e2BhPAkbybGvpFLR/L/rhGtaE4iG5Bvc=; b=ouSPFjmBk/w6
dRQY1FJ6qU8V4srvsQRpR7xIA7pCRCHn0bSN9LNAoeCv8+wtTeFBud90H2QMvQdRVd3P56isiyzq6
K6cB0zzLMJcg1cBdH5aB8X/w6yidKn7dI1mqkRxRUSvHfCLkOWOuRsaZR05FbU58t2dJOPokZOxYh
NVcInBj5LleF0ZxhVSoJuafCyjjmOoPWnyoodtSilNaM9rcIMXi7xYghmLjxbmDo5OEiJdJYoH1xg
R2qDDnyvGjF6SkvAOyPKZNKM+r3aHVMgaavKA4xbZDKHVCkFjICTyzpDjlMryXFxy1Dv88PwTZCi+
LsRlhve9p6mSuBTbKaolsQ==;
Date: Sat, 29 Mar 2025 14:29:06 +0300
Message-Id: <86r02g6pod.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: okamsn@HIDDEN, Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <jwvpliexr8c.fsf-monnier+emacs@HIDDEN> (bug-gnu-emacs@HIDDEN)
Subject: Re: bug#77058: [PATCH] Add cl-with-accessors
References: <4d1b2975-b3ea-427e-a991-3e5123807677@HIDDEN>
<jwvpliexr8c.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 77058
Cc: 77058 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Ping! Okamsn, would you like to submit an updated patch?
> Cc: 77058 <at> debbugs.gnu.org
> Date: Tue, 18 Mar 2025 12:19:56 -0400
> From: Stefan Monnier via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>
> > The attached patch adds the macro `cl-with-accessors'. This macro uses
> > `cl-symbol-macrolet' to treat a symbol like a use of an accessor
> > function, such as those made by `cl-defstruct' and `cl-defclass'. This
> > can be helpful when using repeated calls to read and write with the
> > functions.
>
> Thanks. See comments below.
>
> > Also, in the test `cl-lib-struct-accessors' in
> > test/lisp/emacs-lisp/cl-lib-tests.el, it checks for the keyword
> > `:readonly', but the documented keyword is `:read-only'. Is this a
> > typo, or was this intentional?
>
> I'd go with "typo".
>
> > --- a/doc/misc/cl.texi
> > +++ b/doc/misc/cl.texi
> > @@ -4225,6 +4225,19 @@ Structures
> >
> > Other slot options are currently ignored.
> >
> > +The macro @code{cl-with-accessors} can simplify code that repeatedly
> > +accesses slots.
> > +
> > +@example
> > +(defun add-one-year (person)
> > + (cl-with-accessors ((age person-age))
> > + person
> > + (if (null age)
> > + (error "Age is missing")
> > + (cl-incf age)))
> > + person)
> > +@end example
>
> It'd be worthwhile to mention that it also works with accessors of other
> objects than structs, e.g. `car`, or `process-filter`.
>
> Of course, any EIEIO user would rewrite the above to:
>
> (defun add-one-year (person)
> (with-slots (age) person
> (if (null age)
> (error "Age is missing")
> (cl-incf age)))
> person)
>
> so maybe it's worth mentioning `with-slots` (which arguably should be
> moved to `cl-lib`).
>
> > --- a/etc/NEWS
> > +++ b/etc/NEWS
> > @@ -2496,6 +2496,13 @@ This function is like 'type-of' except that it sometimes returns
> > a more precise type. For example, for nil and t it returns 'null'
> > and 'boolean' respectively, instead of just 'symbol'.
> >
> > +** New macro 'cl-with-accessors'
> > +This macro is similar to 'map-let', but works with structures and their
> > +accessors functions. It is useful when slots' accessor functions are
> > +use repeatedly, such as reading from a slot and then writing to that
> > +slot. Symbol macros are created for the accessor functions using
> > +'cl-symbol-macrolet', so that they can be used with 'setq' and 'setf'.
>
> I think this should be moved to a CL-Lib subsection in the
> "package-specific changes" section.
>
> > +;;;###autoload
> > +(defmacro cl-with-accessors (bindings instance &rest body)
> > + "Generate code using symbols as accessing expressions for INSTANCE inside BODY.
> > +
> > +This macro helps when writing code that makes repeated use of the
> > +accessor functions of a structure or object instance, such as those
> > +created by `cl-defstruct' and `defclass'.
> > +
> > +Inside BODY, SYMBOL-NAME is treated as the function call (ACCESSOR-NAME
> > +INSTANCE) using `cl-symbol-macrolet'. SYMBOL-NAME can be used with
> > +`setf' and `setq' as a generalized variable.
>
> I'd use `VAR` or `SYMBOL` rather than `SYMBOL-NAME`.
> Probably similarly use `ACCESSOR` rather than `ACCESSOR-NAME`.
>
> > +\(fn ((SYMBOL-NAME ACCESSOR-NAME) ...) INSTANCE &REST BODY)"
>
> Should be lower case `&rest` on this last line.
>
> > + (declare (debug [(&rest (symbolp place)) form body])
> > + (indent 2))
>
> I think `place` is wrong here. `(person-age FOO)` is a "place" but
> `person-age` is not (or, well, it is but not the right one: when taken
> as a place it refers to the variable, not the accessor).
> I think it should just be `symbolp`.
>
> > + (cond ((null body)
> > + (macroexp-warn-and-return "No body given" nil 'empty-body))
>
> Please use the same format as other similar warnings we have, such as:
>
> (format-message "`unless' with empty body")
>
>
> - Stefan
>
>
>
>
>
bug-gnu-emacs@HIDDEN:bug#77058; Package emacs.
Full text available.
Received: (at 77058) by debbugs.gnu.org; 18 Mar 2025 16:20:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 18 12:20:18 2025
Received: from localhost ([127.0.0.1]:42664 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tuZft-0003qF-T1
for submit <at> debbugs.gnu.org; Tue, 18 Mar 2025 12:20:18 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:40558)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1tuZfn-0003kS-4P
for 77058 <at> debbugs.gnu.org; Tue, 18 Mar 2025 12:20:15 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id CC4C6442518;
Tue, 18 Mar 2025 12:20:04 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1742314803;
bh=Pjn313fdr/n/sSSfs4JaiiMOmkp6ndNmbyQglvfaotA=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=Cj50bRKcVICIUdJbdos7b0Ey9eQjqwZjgp7Wp9IxRxl9jdJfaSTdIH/TUfrrL9PDE
XJzmIb1TJ52k0Q/xWpgtRtK5saewTiqwVU1QX5oMjNVeB0igc2Cr02CaymFQcWnZr+
uyscUrjDCvg8cEI/CLoNGMspdPxyVn35JokdreAbyWXSCT1UV0FASZ6luOPtIirqeA
Lm1JjDjjAga0c+xzjxuVn/UKctS559pPr0SD7waAirr5HdmfHriM5DVhPswes6VLGI
t35s1L6aGriIQcw6I4zKmiBMhgMasDAFewMuv/oiZ95PC0WW4Qov0I7+rNj+uTWiTX
daRBQM9nSsNyA==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7130C44250D;
Tue, 18 Mar 2025 12:20:03 -0400 (EDT)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 637121206FF;
Tue, 18 Mar 2025 12:20:03 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Okamsn <okamsn@HIDDEN>
Subject: Re: bug#77058: [PATCH] Add cl-with-accessors
In-Reply-To: <4d1b2975-b3ea-427e-a991-3e5123807677@HIDDEN>
(okamsn@HIDDEN's message of "Sun, 16 Mar 2025 18:23:25 +0000")
Message-ID: <jwvpliexr8c.fsf-monnier+emacs@HIDDEN>
References: <4d1b2975-b3ea-427e-a991-3e5123807677@HIDDEN>
Date: Tue, 18 Mar 2025 12:19:56 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.539 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
KAM_STOCKGEN 1.5 Email Contains Generic Pump & Dump Stock Tip
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 77058
Cc: 77058 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> The attached patch adds the macro `cl-with-accessors'. This macro uses
> `cl-symbol-macrolet' to treat a symbol like a use of an accessor
> function, such as those made by `cl-defstruct' and `cl-defclass'. This
> can be helpful when using repeated calls to read and write with the
> functions.
Thanks. See comments below.
> Also, in the test `cl-lib-struct-accessors' in
> test/lisp/emacs-lisp/cl-lib-tests.el, it checks for the keyword
> `:readonly', but the documented keyword is `:read-only'. Is this a
> typo, or was this intentional?
I'd go with "typo".
> --- a/doc/misc/cl.texi
> +++ b/doc/misc/cl.texi
> @@ -4225,6 +4225,19 @@ Structures
>
> Other slot options are currently ignored.
>
> +The macro @code{cl-with-accessors} can simplify code that repeatedly
> +accesses slots.
> +
> +@example
> +(defun add-one-year (person)
> + (cl-with-accessors ((age person-age))
> + person
> + (if (null age)
> + (error "Age is missing")
> + (cl-incf age)))
> + person)
> +@end example
It'd be worthwhile to mention that it also works with accessors of other
objects than structs, e.g. `car`, or `process-filter`.
Of course, any EIEIO user would rewrite the above to:
(defun add-one-year (person)
(with-slots (age) person
(if (null age)
(error "Age is missing")
(cl-incf age)))
person)
so maybe it's worth mentioning `with-slots` (which arguably should be
moved to `cl-lib`).
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -2496,6 +2496,13 @@ This function is like 'type-of' except that it sometimes returns
> a more precise type. For example, for nil and t it returns 'null'
> and 'boolean' respectively, instead of just 'symbol'.
>
> +** New macro 'cl-with-accessors'
> +This macro is similar to 'map-let', but works with structures and their
> +accessors functions. It is useful when slots' accessor functions are
> +use repeatedly, such as reading from a slot and then writing to that
> +slot. Symbol macros are created for the accessor functions using
> +'cl-symbol-macrolet', so that they can be used with 'setq' and 'setf'.
I think this should be moved to a CL-Lib subsection in the
"package-specific changes" section.
> +;;;###autoload
> +(defmacro cl-with-accessors (bindings instance &rest body)
> + "Generate code using symbols as accessing expressions for INSTANCE inside BODY.
> +
> +This macro helps when writing code that makes repeated use of the
> +accessor functions of a structure or object instance, such as those
> +created by `cl-defstruct' and `defclass'.
> +
> +Inside BODY, SYMBOL-NAME is treated as the function call (ACCESSOR-NAME
> +INSTANCE) using `cl-symbol-macrolet'. SYMBOL-NAME can be used with
> +`setf' and `setq' as a generalized variable.
I'd use `VAR` or `SYMBOL` rather than `SYMBOL-NAME`.
Probably similarly use `ACCESSOR` rather than `ACCESSOR-NAME`.
> +\(fn ((SYMBOL-NAME ACCESSOR-NAME) ...) INSTANCE &REST BODY)"
Should be lower case `&rest` on this last line.
> + (declare (debug [(&rest (symbolp place)) form body])
> + (indent 2))
I think `place` is wrong here. `(person-age FOO)` is a "place" but
`person-age` is not (or, well, it is but not the right one: when taken
as a place it refers to the variable, not the accessor).
I think it should just be `symbolp`.
> + (cond ((null body)
> + (macroexp-warn-and-return "No body given" nil 'empty-body))
Please use the same format as other similar warnings we have, such as:
(format-message "`unless' with empty body")
- Stefan
bug-gnu-emacs@HIDDEN:bug#77058; Package emacs.
Full text available.
Received: (at 77058) by debbugs.gnu.org; 17 Mar 2025 12:10:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 17 08:10:27 2025
Received: from localhost ([127.0.0.1]:56358 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tu9IX-0001YC-6z
for submit <at> debbugs.gnu.org; Mon, 17 Mar 2025 08:10:26 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:59894)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tu9IS-0001TT-7K
for 77058 <at> debbugs.gnu.org; Mon, 17 Mar 2025 08:10:22 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1tu9IJ-0002Qf-QW; Mon, 17 Mar 2025 08:10:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=vUtxCGcu3Yegg6Yzzyvr0x0NVg6Z3jpQrzkMzkWM4ws=; b=jg48/MqZBnXL
SupgaJqLnQ1XbjgmU5d0+Wc9tsFTCvw7tAj15QsrBv1QCOPqhtKQuKjgn176jMahO/Vwv3AEyhvF2
bEAZ6mJJ5Kiw2ETjv9YP4sYV+kOOa33psjNotmmhBL0nHmv9r/3rd82hFZraQ+Kz6k4uaVLPktUt0
50iol1PKeseAZ++T+IOOKkipoCnp0Kt4KJuik7j7RDjY85No28xGpKCbY8/D8pbrymAHp7fosH3bU
S9OPupk0KSp+PuWgCCPGmxP4yy7Q5WRUmQTeeyvU2QiOhJPGiuZw1Iy+GwQRMMY/8CNwmoEfbNwHf
fMyOOqqKHpuPJhov3tdO5g==;
Date: Mon, 17 Mar 2025 14:09:04 +0200
Message-Id: <86y0x3svtr.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Okamsn <okamsn@HIDDEN>, Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <4d1b2975-b3ea-427e-a991-3e5123807677@HIDDEN>
(bug-gnu-emacs@HIDDEN)
Subject: Re: bug#77058: [PATCH] Add cl-with-accessors
References: <4d1b2975-b3ea-427e-a991-3e5123807677@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 77058
Cc: 77058 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Date: Sun, 16 Mar 2025 18:23:25 +0000
> From: Okamsn via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>
> The attached patch adds the macro `cl-with-accessors'. This macro uses
> `cl-symbol-macrolet' to treat a symbol like a use of an accessor
> function, such as those made by `cl-defstruct' and `cl-defclass'. This
> can be helpful when using repeated calls to read and write with the
> functions.
>
> It is based on the description at
> https://www.lispworks.com/documentation/HyperSpec/Body/m_w_acce.htm
>
> Also, in the test `cl-lib-struct-accessors' in
> test/lisp/emacs-lisp/cl-lib-tests.el, it checks for the keyword
> `:readonly', but the documented keyword is `:read-only'. Is this a
> typo, or was this intentional?
Thanks, I added Stefan to the discussion in the hope that he might
have comments.
A few comments about the documentation parts of the patch below.
> --- a/doc/misc/cl.texi
> +++ b/doc/misc/cl.texi
> @@ -4225,6 +4225,19 @@ Structures
>
> Other slot options are currently ignored.
>
> +The macro @code{cl-with-accessors} can simplify code that repeatedly
> +accesses slots.
This macro should be documented using @defmac, and the description
should be more detailed, at least as detailed as the doc string.
Since you say the macro simplifies some typical usage patterns, it
would be good to show how it does so, perhaps by showing an example of
code without the macro, and then the same code using the macro.
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -2496,6 +2496,13 @@ This function is like 'type-of' except that it sometimes returns
> a more precise type. For example, for nil and t it returns 'null'
> and 'boolean' respectively, instead of just 'symbol'.
>
> +** New macro 'cl-with-accessors'
This should end in a period.
Also, since the necessary changes to the manual are included, the NEWS
entry should be marked with "+++" (see the explanation at the top of
NEWS).
> +This macro is similar to 'map-let', but works with structures and their
> +accessors functions. It is useful when slots' accessor functions are
> +use repeatedly, such as reading from a slot and then writing to that
^^^
"used"
> +(defmacro cl-with-accessors (bindings instance &rest body)
> + "Generate code using symbols as accessing expressions for INSTANCE inside BODY.
It is best to reference all of the mandatory arguments in the first
line. In this case, BINDINGS is not mentioned, not even in the rest
of the doc string.
bug-gnu-emacs@HIDDEN:bug#77058; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 16 Mar 2025 18:24:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 16 14:24:09 2025 Received: from localhost ([127.0.0.1]:50679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ttsee-0003JR-N1 for submit <at> debbugs.gnu.org; Sun, 16 Mar 2025 14:24:09 -0400 Received: from lists.gnu.org ([2001:470:142::17]:45052) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <okamsn@HIDDEN>) id 1ttsec-0003If-MH for submit <at> debbugs.gnu.org; Sun, 16 Mar 2025 14:24:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <okamsn@HIDDEN>) id 1ttseM-0000DK-Q9 for bug-gnu-emacs@HIDDEN; Sun, 16 Mar 2025 14:23:51 -0400 Received: from mail-0301.mail-europe.com ([188.165.51.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <okamsn@HIDDEN>) id 1ttseH-0000DU-G1 for bug-gnu-emacs@HIDDEN; Sun, 16 Mar 2025 14:23:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1742149413; x=1742408613; bh=i28Sr8wKA99YCdUdh5/zGBYu2O12zxmBFlEdtqeXCZY=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector: List-Unsubscribe:List-Unsubscribe-Post; b=QwpHukVa9sahwxw/40oeg+aRuQIs54hPhI7YKb99Vf7aQfTEegGZ+JMtGUSVT0NvB Kk9jXixIXnk5dbhpEiyg8i4uKxvLj1dsoAPlaEUV1R1bP3TzTcnnIlBxYmc+u60E9g fWcyX6BSOM6O6Se6pQBVYnXZ4CPbp/YL2lrM9rJZHazQk8y9OV4ETVQnIruZheai6l 51IbeUPOqYRfddRj/yzXVozZgi8s4woh+uxd+exVDQ4obBkQKgxMswVLNbVGa095U8 RAsbyMq9yLJC1a6GT3T0Uy0+9d1UOdGNc2JzCW9l2sZbMTQCCPTIFJoiokPQj7ZiGi bCzXRb3UHQxNA== Date: Sun, 16 Mar 2025 18:23:25 +0000 To: Emacs Bugs List <bug-gnu-emacs@HIDDEN> From: Okamsn <okamsn@HIDDEN> Subject: [PATCH] Add cl-with-accessors Message-ID: <4d1b2975-b3ea-427e-a991-3e5123807677@HIDDEN> Feedback-ID: 25935600:user:proton X-Pm-Message-ID: bcdb09c4efeec51a34b3ad72c36cca63eb7922d4 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1=_DQHwCFIWMN4rAIKZ3g6fJN8lfZ6OVCHPB3xVJXuQj8" Received-SPF: pass client-ip=188.165.51.139; envelope-from=okamsn@HIDDEN; helo=mail-0301.mail-europe.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) --b1=_DQHwCFIWMN4rAIKZ3g6fJN8lfZ6OVCHPB3xVJXuQj8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, The attached patch adds the macro `cl-with-accessors'. This macro uses=20 `cl-symbol-macrolet' to treat a symbol like a use of an accessor=20 function, such as those made by `cl-defstruct' and `cl-defclass'. This=20 can be helpful when using repeated calls to read and write with the=20 functions. It is based on the description at https://www.lispworks.com/documentation/HyperSpec/Body/m_w_acce.htm Also, in the test `cl-lib-struct-accessors' in=20 test/lisp/emacs-lisp/cl-lib-tests.el, it checks for the keyword=20 `:readonly', but the documented keyword is `:read-only'. Is this a=20 typo, or was this intentional? Thank you. --b1=_DQHwCFIWMN4rAIKZ3g6fJN8lfZ6OVCHPB3xVJXuQj8 Content-Type: text/x-patch; charset=UTF-8; name=0001-Add-cl-with-accessors.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Add-cl-with-accessors.patch RnJvbSAxMmYxOGI4MjIyYzk0M2VjOTA2NjllZmQ0MjU2Y2YzYWFlOGYwYmI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFYXJsIEh5YXR0IDxva2Ftc25AcHJvdG9ubWFpbC5jb20+CkRh dGU6IFdlZCwgMTIgTWFyIDIwMjUgMjM6MDE6NDkgLTA0MDAKU3ViamVjdDogW1BBVENIXSBBZGQg Y2wtd2l0aC1hY2Nlc3NvcnMKCiogZG9jL21pc2MvY2wudGV4aSAoU3RydWN0dXJlcyk6IE1lbnRp b24gdGhlIG5ldyBtYWNyby4KKiBsaXNwL2VtYWNzLWxpc3AvY2wtbWFjcy5lbCAoY2wtd2l0aC1h Y2Nlc3NvcnMpOiBBZGQgdGhlIG1hY3JvLgoqIHRlc3QvbGlzcC9lbWFjcy1saXNwL2NsLWxpYi10 ZXN0cy5lbCAoY2wtbGliLXN0cnVjdC13aXRoLWFjY2Vzc29ycyk6ClRlc3QgdGhlIG1hY3JvLgoq IGV0Yy9ORVdTIChOZXcgbWFjcm8gJ2NsLXdpdGgtYWNjZXNzb3JzJyk6IE1lbnRpb24gdGhlIG1h Y3JvLgoKVGhpcyBtYWNybyBpcyB1c2VmdWwgd2hlbiBtYWtpbmcgcmVwZWF0ZWQgdXNlIG9mIGEg c3RydWN0dXJlcyBhY2Nlc3NvcgpmdW5jdGlvbnMsIHN1Y2ggYXMgcmVhZGluZyBmcm9tIGEgc2xv dCBhbmQgdGhlbiB3cml0aW5nIHRvIGEgc2xvdC4KLS0tCiBkb2MvbWlzYy9jbC50ZXhpICAgICAg ICAgICAgICAgICAgICAgfCAxMyArKysrKysrKysrKysrCiBldGMvTkVXUyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgNyArKysrKysrCiBsaXNwL2VtYWNzLWxpc3AvY2wtbWFjcy5lbCAg ICAgICAgICAgfCAyNyArKysrKysrKysrKysrKysrKysrKysrKysrKysKIHRlc3QvbGlzcC9lbWFj cy1saXNwL2NsLWxpYi10ZXN0cy5lbCB8IDEyICsrKysrKysrKysrKwogNCBmaWxlcyBjaGFuZ2Vk LCA1OSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZG9jL21pc2MvY2wudGV4aSBiL2RvYy9t aXNjL2NsLnRleGkKaW5kZXggNDhiOGVhMDljNjUuLmFlMTA3M2U5MDMyIDEwMDY0NAotLS0gYS9k b2MvbWlzYy9jbC50ZXhpCisrKyBiL2RvYy9taXNjL2NsLnRleGkKQEAgLTQyMjUsNiArNDIyNSwx OSBAQCBTdHJ1Y3R1cmVzCiAKIE90aGVyIHNsb3Qgb3B0aW9ucyBhcmUgY3VycmVudGx5IGlnbm9y ZWQuCiAKK1RoZSBtYWNybyBAY29kZXtjbC13aXRoLWFjY2Vzc29yc30gY2FuIHNpbXBsaWZ5IGNv ZGUgdGhhdCByZXBlYXRlZGx5CithY2Nlc3NlcyBzbG90cy4KKworQGV4YW1wbGUKKyhkZWZ1biBh ZGQtb25lLXllYXIgKHBlcnNvbikKKyAgKGNsLXdpdGgtYWNjZXNzb3JzICgoYWdlIHBlcnNvbi1h Z2UpKQorICAgICAgcGVyc29uCisgICAgKGlmIChudWxsIGFnZSkKKyAgICAgICAgKGVycm9yICJB Z2UgaXMgbWlzc2luZyIpCisgICAgICAoY2wtaW5jZiBhZ2UpKSkKKyAgcGVyc29uKQorQGVuZCBl eGFtcGxlCisKIEZvciBvYnNjdXJlIGhpc3RvcmljYWwgcmVhc29ucywgc3RydWN0dXJlIG9wdGlv bnMgdGFrZSBhIGRpZmZlcmVudAogZm9ybSB0aGFuIHNsb3Qgb3B0aW9ucy4gIEEgc3RydWN0dXJl IG9wdGlvbiBpcyBlaXRoZXIgYSBrZXl3b3JkCiBzeW1ib2wsIG9yIGEgbGlzdCBiZWdpbm5pbmcg d2l0aCBhIGtleXdvcmQgc3ltYm9sIHBvc3NpYmx5IGZvbGxvd2VkCmRpZmYgLS1naXQgYS9ldGMv TkVXUyBiL2V0Yy9ORVdTCmluZGV4IDMxYTBjNDkzOGFkLi5kNDg1NWEwYmNjZCAxMDA2NDQKLS0t IGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTI0OTYsNiArMjQ5NiwxMyBAQCBUaGlzIGZ1 bmN0aW9uIGlzIGxpa2UgJ3R5cGUtb2YnIGV4Y2VwdCB0aGF0IGl0IHNvbWV0aW1lcyByZXR1cm5z CiBhIG1vcmUgcHJlY2lzZSB0eXBlLiAgRm9yIGV4YW1wbGUsIGZvciBuaWwgYW5kIHQgaXQgcmV0 dXJucyAnbnVsbCcKIGFuZCAnYm9vbGVhbicgcmVzcGVjdGl2ZWx5LCBpbnN0ZWFkIG9mIGp1c3Qg J3N5bWJvbCcuCiAKKyoqIE5ldyBtYWNybyAnY2wtd2l0aC1hY2Nlc3NvcnMnCitUaGlzIG1hY3Jv IGlzIHNpbWlsYXIgdG8gJ21hcC1sZXQnLCBidXQgd29ya3Mgd2l0aCBzdHJ1Y3R1cmVzIGFuZCB0 aGVpcgorYWNjZXNzb3JzIGZ1bmN0aW9ucy4gIEl0IGlzIHVzZWZ1bCB3aGVuIHNsb3RzJyBhY2Nl c3NvciBmdW5jdGlvbnMgYXJlCit1c2UgcmVwZWF0ZWRseSwgc3VjaCBhcyByZWFkaW5nIGZyb20g YSBzbG90IGFuZCB0aGVuIHdyaXRpbmcgdG8gdGhhdAorc2xvdC4gIFN5bWJvbCBtYWNyb3MgYXJl IGNyZWF0ZWQgZm9yIHRoZSBhY2Nlc3NvciBmdW5jdGlvbnMgdXNpbmcKKydjbC1zeW1ib2wtbWFj cm9sZXQnLCBzbyB0aGF0IHRoZXkgY2FuIGJlIHVzZWQgd2l0aCAnc2V0cScgYW5kICdzZXRmJy4K KwogKysrCiAqKiBOZXcgZnVuY3Rpb25zICdwcmltaXRpdmUtZnVuY3Rpb24tcCcgYW5kICdjbC1m dW5jdGlvbnAnLgogJ3ByaW1pdGl2ZS1mdW5jdGlvbi1wJyBpcyBsaWtlICdzdWJyLXByaW1pdGl2 ZS1wJyBleGNlcHQgdGhhdCBpdCByZXR1cm5zCmRpZmYgLS1naXQgYS9saXNwL2VtYWNzLWxpc3Av Y2wtbWFjcy5lbCBiL2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLmVsCmluZGV4IGIwN2E4ODFiYTQ4 Li4yZTEzMjc3NWI5ZSAxMDA2NDQKLS0tIGEvbGlzcC9lbWFjcy1saXNwL2NsLW1hY3MuZWwKKysr IGIvbGlzcC9lbWFjcy1saXNwL2NsLW1hY3MuZWwKQEAgLTI1NDQsNiArMjU0NCwzMyBAQCBjbC1v bmNlLW9ubHkKICAgICAgICAgICAgICAgICAgICAgICAgICAgY29sbGVjdCBgKCwoY2FyIG5hbWUp ICxnZW5zeW0pKQogICAgICAgICAgICAgICxAYm9keSkpKSkpCiAKKzs7OyMjI2F1dG9sb2FkCiso ZGVmbWFjcm8gY2wtd2l0aC1hY2Nlc3NvcnMgKGJpbmRpbmdzIGluc3RhbmNlICZyZXN0IGJvZHkp CisgICJHZW5lcmF0ZSBjb2RlIHVzaW5nIHN5bWJvbHMgYXMgYWNjZXNzaW5nIGV4cHJlc3Npb25z IGZvciBJTlNUQU5DRSBpbnNpZGUgQk9EWS4KKworVGhpcyBtYWNybyBoZWxwcyB3aGVuIHdyaXRp bmcgY29kZSB0aGF0IG1ha2VzIHJlcGVhdGVkIHVzZSBvZiB0aGUKK2FjY2Vzc29yIGZ1bmN0aW9u cyBvZiBhIHN0cnVjdHVyZSBvciBvYmplY3QgaW5zdGFuY2UsIHN1Y2ggYXMgdGhvc2UKK2NyZWF0 ZWQgYnkgYGNsLWRlZnN0cnVjdCcgYW5kIGBkZWZjbGFzcycuCisKK0luc2lkZSBCT0RZLCBTWU1C T0wtTkFNRSBpcyB0cmVhdGVkIGFzIHRoZSBmdW5jdGlvbiBjYWxsIChBQ0NFU1NPUi1OQU1FCitJ TlNUQU5DRSkgdXNpbmcgYGNsLXN5bWJvbC1tYWNyb2xldCcuICBTWU1CT0wtTkFNRSBjYW4gYmUg dXNlZCB3aXRoCitgc2V0ZicgYW5kIGBzZXRxJyBhcyBhIGdlbmVyYWxpemVkIHZhcmlhYmxlLgor CitcKGZuICgoU1lNQk9MLU5BTUUgQUNDRVNTT1ItTkFNRSkgLi4uKSBJTlNUQU5DRSAmUkVTVCBC T0RZKSIKKyAgKGRlY2xhcmUgKGRlYnVnIFsoJnJlc3QgKHN5bWJvbHAgcGxhY2UpKSBmb3JtIGJv ZHldKQorICAgICAgICAgICAoaW5kZW50IDIpKQorICAoY29uZCAoKG51bGwgYm9keSkKKyAgICAg ICAgIChtYWNyb2V4cC13YXJuLWFuZC1yZXR1cm4gIk5vIGJvZHkgZ2l2ZW4iIG5pbCAnZW1wdHkt Ym9keSkpCisgICAgICAgICgobnVsbCBiaW5kaW5ncykKKyAgICAgICAgIChtYWNyb2V4cC13YXJu LWFuZC1yZXR1cm4gIk5vIGJpbmRpbmdzIGdpdmVuIgorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAobWFjcm9leHAtcHJvZ24gYm9keSkKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgJ3N1c3BpY2lvdXMpKQorICAgICAgICAodAorICAgICAgICAgKGNsLW9uY2Ut b25seSAoaW5zdGFuY2UpCisgICAgICAgICAgIGAoY2wtc3ltYm9sLW1hY3JvbGV0ICwoY2wtbG9v cCBmb3IgKHZhciBwbGFjZSkgaW4gYmluZGluZ3MKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGNvbGxlY3QgYCgsdmFyICgscGxhY2UgLGluc3RhbmNlKSkpCisgICAg ICAgICAgICAgICxAYm9keSkpKSkpCisKIDs7OyBNdWx0aXBsZSB2YWx1ZXMuCiAKIDs7OyMjI2F1 dG9sb2FkCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZW1hY3MtbGlzcC9jbC1saWItdGVzdHMuZWwg Yi90ZXN0L2xpc3AvZW1hY3MtbGlzcC9jbC1saWItdGVzdHMuZWwKaW5kZXggYTljNzFmYTU4MDgu LjRkYjY4NGI0ZGI3IDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZW1hY3MtbGlzcC9jbC1saWItdGVz dHMuZWwKKysrIGIvdGVzdC9saXNwL2VtYWNzLWxpc3AvY2wtbGliLXRlc3RzLmVsCkBAIC0yMjcs NiArMjI3LDE4IEBAIGNsLWxpYi1zdHJ1Y3QtY29uc3RydWN0b3JzCiAgICAgICAgICAgICAgICAg ICAgICAgICAoZG9jdW1lbnRhdGlvbiAnY2wtbGliLS1jb24tMiB0KSkpCiAgIChzaG91bGQgKG15 c3RydWN0LXAgKGNsLWxpYi0tY29uLTEpKSkKICAgKHNob3VsZCAobXlzdHJ1Y3QtcCAoY2wtbGli LS1jb24tMikpKSkKKyhlcnQtZGVmdGVzdCBjbC1saWItc3RydWN0LXdpdGgtYWNjZXNzb3JzICgp CisgIChsZXQgKCh4IChtYWtlLW15c3RydWN0IDphYmMgMSA6ZGVmIDIpKSkKKyAgICAoY2wtd2l0 aC1hY2Nlc3NvcnMgKChhYmMgbXlzdHJ1Y3QtYWJjKQorICAgICAgICAgICAgICAgICAgICAgICAg KGRlZiBteXN0cnVjdC1kZWYpKQorICAgICAgICB4CisgICAgICAoc2hvdWxkICg9IGFiYyAxKSkK KyAgICAgIChzaG91bGQgKD0gZGVmIDIpKQorICAgICAgKHNldGYgZGVmIDMpCisgICAgICAoc2hv dWxkICg9IGRlZiAzKSkKKyAgICAgIChzZXRxIGRlZiA0KQorICAgICAgKHNob3VsZCAoPSBkZWYg NCkpKQorICAgIChzaG91bGQgKD0gNCAobXlzdHJ1Y3QtZGVmIHgpKSkpKQogCiAoZXJ0LWRlZnRl c3QgY2wtbGliLWFyZ2xpc3QtcGVyZm9ybWFuY2UgKCkKICAgOzsgQW4gYCZhdXgnIHNob3VsZCBu b3QgY2F1c2UgbGFtYmRhJ3MgYXJnbGlzdCB0byBiZSB0dXJuZWQgaW50byBhbiAmcmVzdAotLSAK Mi40My4wCgo= --b1=_DQHwCFIWMN4rAIKZ3g6fJN8lfZ6OVCHPB3xVJXuQj8--
Okamsn <okamsn@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#77058; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.