GNU bug report logs - #77083
31.0.50; submit-emacs-patch doesn't work in compressed lisp files

Previous Next

To reply to this bug, email your comments to 77083 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; submit-emacs-patch doesn't work in compressed lisp files
Date: Mon, 17 Mar 2025 14:37:04 -0600

[Message part 1 (text/plain, inline)]

When Emacs was compiled with compress-install, using =submit-emacs-patch=
gives an error because it search for maintainer address in =file.el=
instead =file.el.gz=.

In GNU Emacs 31.0.50 (build 1, x86_64-redhat-linux-gnu, GTK+ Version
 3.24.43, cairo version 1.18.2) of 2025-03-16 built on
 bd673d7b71834db996f6e93e913b9ec3
System Description: Fedora Linux 41 (Workstation Edition)

[Message part 2 (text/html, inline)]

[Message part 3 (text/plain, inline)]

-- 
                                          - E.G via GNU Emacs and Org.

Message #8 received at 77083 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>,
 Philip Kaludercic <philipk <at> posteo.net>
Cc: 77083 <at> debbugs.gnu.org
Subject: Re: bug#77083: 31.0.50;
 submit-emacs-patch doesn't work in compressed lisp files
Date: Tue, 18 Mar 2025 14:21:32 +0200

> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
> Date: Mon, 17 Mar 2025 14:37:04 -0600
> 
> When Emacs was compiled with compress-install, using submit-emacs-patch gives an error because it
> search for maintainer address in file.el instead file.el.gz. 

Thanks, but this lacks details, IMO.  AFAIU, submit-emacs-patch gleans
source file names from the patch file you are about to submit, and it
expands each file name in the patch against source-directory, before
looking them up for their maintainers.  In the source tree (if you
still have it around) the files are not compressed.  OTOH, if your
patch names files by their absolute file name (in which case
source-directory is not used), and the files are compressed in the
installation tree, then how did you produce the patch from compressed
files in the first place in a way that names the files without the .gz
extensions?

IOW, please show an example of a patch that could be used to reproduce
this issue and the recipe to reproduce, and please tell whether you do
or don't have the Emacs source tree pointed to by source-directory.
Or maybe I'm missing something obvious, in which case please point out
what I missed.

Thanks.

P.S. I added Philip to the discussion, since he made the relevant
change in emacsbug.el.

Message #11 received at 77083 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Elijah Gabe Pérez <eg642616 <at> gmail.com>,
 77083 <at> debbugs.gnu.org
Subject: Re: bug#77083: 31.0.50; submit-emacs-patch doesn't work in
 compressed lisp files
Date: Tue, 18 Mar 2025 17:53:39 +0000

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
>> Date: Mon, 17 Mar 2025 14:37:04 -0600
>> 
>> When Emacs was compiled with compress-install, using submit-emacs-patch gives an error because it
>> search for maintainer address in file.el instead file.el.gz. 
>
> Thanks, but this lacks details, IMO.  AFAIU, submit-emacs-patch gleans
> source file names from the patch file you are about to submit, and it
> expands each file name in the patch against source-directory, before
> looking them up for their maintainers.  In the source tree (if you
> still have it around) the files are not compressed.  OTOH, if your
> patch names files by their absolute file name (in which case
> source-directory is not used), and the files are compressed in the
> installation tree, then how did you produce the patch from compressed
> files in the first place in a way that names the files without the .gz
> extensions?
>
> IOW, please show an example of a patch that could be used to reproduce
> this issue and the recipe to reproduce, and please tell whether you do
> or don't have the Emacs source tree pointed to by source-directory.
> Or maybe I'm missing something obvious, in which case please point out
> what I missed.

I would also be interested in the specific error being raised.  It might
be that the following check could suffice to fix the issue:

[Message part 2 (text/plain, inline)]

diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el
index babfd2e68ae..ad6f1b7a58b 100644
--- a/lisp/mail/emacsbug.el
+++ b/lisp/mail/emacsbug.el
@@ -543,10 +543,11 @@ submit-emacs-patch
                  (with-temp-buffer
                    (insert-file-contents file)
                    (while (search-forward-regexp "^\\+\\{3\\} ./\\(.*\\)" nil t)
-                     (push (expand-file-name
-                            (match-string-no-properties 1)
-                            source-directory)
-                           files)))
+                     (let ((file (expand-file-name
+                                  (match-string-no-properties 1)
+                                  source-directory)))
+                       (when (file-readable-p file)
+                         (push file files)))))
                  (mapcan
                   (lambda (patch)
                     (seq-remove

[Message part 3 (text/plain, inline)]

> Thanks.
>
> P.S. I added Philip to the discussion, since he made the relevant
> change in emacsbug.el.

Message #14 received at 77083 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Philip Kaludercic <philipk <at> posteo.net>, 77083 <at> debbugs.gnu.org
Subject: Re: bug#77083: 31.0.50; submit-emacs-patch doesn't work in
 compressed lisp files
Date: Tue, 18 Mar 2025 12:50:56 -0600

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
>> Date: Mon, 17 Mar 2025 14:37:04 -0600

>> When Emacs was compiled with compress-install, using submit-emacs-patch gives an error because it
>> search for maintainer address in file.el instead file.el.gz. 

> Thanks, but this lacks details, IMO.  AFAIU, submit-emacs-patch gleans
> source file names from the patch file you are about to submit, and it
> expands each file name in the patch against source-directory, before
> looking them up for their maintainers.  In the source tree (if you
> still have it around) the files are not compressed.  OTOH, if your
> patch names files by their absolute file name (in which case
> source-directory is not used), and the files are compressed in the
> installation tree, then how did you produce the patch from compressed
> files in the first place in a way that names the files without the .gz
> extensions?

My emacs-git directory (where i use to contribute) doesn't have the lisp
files compressed, it seems that submit-emacs-patch search in
source-directory (which i have it pointing to /usr/share/emacs/31.0.50/)
for lisp.el, however my installed emacs was built with compress-install
which i have lisp.el.gz instead.

> IOW, please show an example of a patch that could be used to reproduce
> this issue and the recipe to reproduce,

Sure, here is:


Steps to reproduce:
1. emacs -Q
2. eval: (setq source-directory "/usr/share/emacs/31.0.50/")
3. M-x submit-emacs-patch RET /path/to/test.patch RET RET

and should display mail/message buffer with this

#+begin_example
  To: bug-gnu-emacs <at> gnu.org
  Subject: 
  From:
  X-Debbugs-Cc: --text follows this line--
#+end_example

and give an error:

#+begin_example
  Opening input file: The file or directory does not exist, /usr/share/emacs/31.0.50/lisp/simple.el
#+end_example

> and please tell whether you do or don't have the Emacs source tree
> pointed to by source-directory.

I have source-directory pointing to /usr/share/emacs/31.0.50/, changing
it to my emacs-git directory path fix this.

However I haven't found any documentation about this variable and
changing its value, so I see it very dangerous do it.

> Or maybe I'm missing something obvious, in which case please point out
> what I missed.

You didn't miss anything, I think I've explained enough.

[Message part 2 (text/html, inline)]

[test.patch (text/x-patch, attachment)]

[Message part 4 (text/plain, inline)]

-- 
                                          - E.G via GNU Emacs and Org.

Message #17 received at 77083 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: philipk <at> posteo.net, 77083 <at> debbugs.gnu.org
Subject: Re: bug#77083: 31.0.50; submit-emacs-patch doesn't work in
 compressed lisp files
Date: Tue, 18 Mar 2025 22:52:57 +0200

> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
> Cc: Philip Kaludercic <philipk <at> posteo.net>,  77083 <at> debbugs.gnu.org
> Date: Tue, 18 Mar 2025 12:50:56 -0600
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
>  From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
>  Date: Mon, 17 Mar 2025 14:37:04 -0600
> 
>  When Emacs was compiled with compress-install, using submit-emacs-patch gives an error because it
>  search for maintainer address in file.el instead file.el.gz.
> 
>  Thanks, but this lacks details, IMO. AFAIU, submit-emacs-patch gleans
>  source file names from the patch file you are about to submit, and it
>  expands each file name in the patch against source-directory, before
>  looking them up for their maintainers. In the source tree (if you
>  still have it around) the files are not compressed. OTOH, if your
>  patch names files by their absolute file name (in which case
>  source-directory is not used), and the files are compressed in the
>  installation tree, then how did you produce the patch from compressed
>  files in the first place in a way that names the files without the .gz
>  extensions?
> 
> My emacs-git directory (where i use to contribute) doesn't have the lisp
> files compressed, it seems that submit-emacs-patch search in
> source-directory (which i have it pointing to usr/share/emacs/31.0.50)
> for lisp.el, however my installed emacs was built with compress-install
> which i have lisp.el.gz instead.
> 
>  IOW, please show an example of a patch that could be used to reproduce
>  this issue and the recipe to reproduce,
> 
> Sure, here is:
> 
> Steps to reproduce:
> 
> 1 emacs -Q
> 2 eval: (setq source-directory "usr/share/emacs/31.0.50")
> 3 M-x submit-emacs-patch RET /path/to/test.patch RET RET
> 
> and should display mail/message buffer with this
> 
> 
> To: bug-gnu-emacs <at> gnu.org
> Subject: 
> From:
> X-Debbugs-Cc: --text follows this line--
> 
> and give an error:
> 
> 
> Opening input file: The file or directory does not exist, /usr/share/emacs/31.0.50/lisp/simple.el
> 
>  and please tell whether you do or don't have the Emacs source tree
>  pointed to by source-directory.
> 
> I have source-directory pointing to usr/share/emacs/31.0.50, changing
> it to my emacs-git directory path fix this.

So the problem in your case is not that the files are compressed, the
problem is that the source tree doesn't exist on that system?  In that
case, I believe the patch suggested by Philip up-thread will solve
this.  Can you try it?

Thanks.

Message #20 received at 77083 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: philipk <at> posteo.net, 77083 <at> debbugs.gnu.org
Subject: Re: bug#77083: 31.0.50; submit-emacs-patch doesn't work in
 compressed lisp files
Date: Tue, 18 Mar 2025 15:31:31 -0600

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

> So the problem in your case is not that the files are compressed, the
> problem is that the source tree doesn't exist on that system?  In that
> case, I believe the patch suggested by Philip up-thread will solve
> this.  Can you try it?

Yeah, I've tried it and it solves this issue.
However, maintainer address is not inserted in X-Debbugs-Cc:.

Maybe Should i set source-directory to my emacs-git path in my config?

Or there should be a defcustom instead using source-directory?

Something like this?
#+begin_src emacs-lisp
  (defcustom submit-emacs-patch-src-path source-directory
    "Path to Emacs source directory for submit patch."
    :type 'string)
#+end_src

[Message part 2 (text/html, inline)]

[Message part 3 (text/plain, inline)]

-- 
                                          - E.G via GNU Emacs and Org.

Message #23 received at 77083 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: philipk <at> posteo.net, 77083 <at> debbugs.gnu.org
Subject: Re: bug#77083: 31.0.50; submit-emacs-patch doesn't work in
 compressed lisp files
Date: Wed, 19 Mar 2025 14:20:56 +0200

> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
> Cc: philipk <at> posteo.net,  77083 <at> debbugs.gnu.org
> Date: Tue, 18 Mar 2025 15:31:31 -0600
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
>  So the problem in your case is not that the files are compressed, the
>  problem is that the source tree doesn't exist on that system? In that
>  case, I believe the patch suggested by Philip up-thread will solve
>  this. Can you try it?
> 
> Yeah, I've tried it and it solves this issue.

Then I think Philip should install that change.

> However, maintainer address is not inserted in X-Debbugs-Cc:.

If you don't have the source tree with the file which you are
patching, how do you expect Emacs to find the maintainer?

> Maybe Should i set source-directory to my emacs-git path in my config?

You can set it to any directory where you have the Emacs source tree.

> Or there should be a defcustom instead using source-directory?

I don't think we want a defcustom in this case, no.  The doc string of
source-directory already says not to rely on its being there.

Message #26 received at 77083 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: philipk <at> posteo.net, 77083 <at> debbugs.gnu.org
Subject: Re: bug#77083: 31.0.50; submit-emacs-patch doesn't work in
 compressed lisp files
Date: Wed, 19 Mar 2025 11:18:35 -0600

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
>> Cc: philipk <at> posteo.net,  77083 <at> debbugs.gnu.org
>> Date: Tue, 18 Mar 2025 15:31:31 -0600

>> Eli Zaretskii <eliz <at> gnu.org> writes:

>> Maybe Should i set source-directory to my emacs-git path in my config?

> You can set it to any directory where you have the Emacs source tree.

Ok, then this can be closed.
Thanks.

[Message part 2 (text/html, inline)]

[Message part 3 (text/plain, inline)]

-- 
- E.G via GNU Emacs and Org.

Message #29 received at 77083 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: philipk <at> posteo.net, 77083 <at> debbugs.gnu.org
Subject: Re: bug#77083: 31.0.50; submit-emacs-patch doesn't work in
 compressed lisp files
Date: Wed, 19 Mar 2025 19:20:14 +0200

> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
> Cc: philipk <at> posteo.net,  77083 <at> debbugs.gnu.org
> Date: Wed, 19 Mar 2025 11:18:35 -0600
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
>  From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
>  Cc: philipk <at> posteo.net, 77083 <at> debbugs.gnu.org
>  Date: Tue, 18 Mar 2025 15:31:31 -0600
> 
>  Eli Zaretskii <eliz <at> gnu.org> writes:
> 
>  Maybe Should i set source-directory to my emacs-git path in my config?
> 
>  You can set it to any directory where you have the Emacs source tree.
> 
> Ok, then this can be closed.

After Philip installs his patch, sure.

Message #34 received at 77083-done <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Elijah Gabe Pérez <eg642616 <at> gmail.com>,
 77083-done <at> debbugs.gnu.org
Subject: Re: bug#77083: 31.0.50; submit-emacs-patch doesn't work in
 compressed lisp files
Date: Wed, 19 Mar 2025 17:35:56 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
>> Cc: philipk <at> posteo.net,  77083 <at> debbugs.gnu.org
>> Date: Wed, 19 Mar 2025 11:18:35 -0600
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>>  From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
>>  Cc: philipk <at> posteo.net, 77083 <at> debbugs.gnu.org
>>  Date: Tue, 18 Mar 2025 15:31:31 -0600
>> 
>>  Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>>  Maybe Should i set source-directory to my emacs-git path in my config?
>> 
>>  You can set it to any directory where you have the Emacs source tree.
>> 
>> Ok, then this can be closed.
>
> After Philip installs his patch, sure.

Done :)

Thanks for the report Elijah, and your help in testing the patch!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.