GNU logs - #77090, boring messages


Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#77090] Patch to add linux-libre mnt/reform variant
Resent-From: Vagrant Cascadian <vagrant@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 18 Mar 2025 01:23:04 +0000
Resent-Message-ID: <handler.77090.B.174226092421673 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 77090
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: 77090 <at> debbugs.gnu.org
Cc: w@HIDDEN, leo@HIDDEN
X-Debbugs-Original-To: guix-patches@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.174226092421673
          (code B ref -1); Tue, 18 Mar 2025 01:23:04 +0000
Received: (at submit) by debbugs.gnu.org; 18 Mar 2025 01:22:04 +0000
Received: from localhost ([127.0.0.1]:33710 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tuLeY-0005cZ-HH
	for submit <at> debbugs.gnu.org; Mon, 17 Mar 2025 21:22:03 -0400
Received: from lists.gnu.org ([2001:470:142::17]:36736)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <vagrant@HIDDEN>)
 id 1tuLeU-0005ar-GF
 for submit <at> debbugs.gnu.org; Mon, 17 Mar 2025 21:21:56 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <vagrant@HIDDEN>)
 id 1tuLeG-0001SU-UE
 for guix-patches@HIDDEN; Mon, 17 Mar 2025 21:21:42 -0400
Received: from cascadia.aikidev.net ([173.255.214.101])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <vagrant@HIDDEN>)
 id 1tuLeD-0004fs-9U
 for guix-patches@HIDDEN; Mon, 17 Mar 2025 21:21:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org;
 s=1.vagrant.user; t=1742260893;
 bh=0awHsJs9KgIIKe7psndb23ZhV7k81o/yw8KSk1y2hnM=;
 h=From:To:Cc:Subject:Date:From;
 b=O8kFC/t2YYT94Pv/yfuCm01WR1MzxC/kKSgrFB6pW0GbgnGNNTREoWHHU1VwIQNFK
 PaoGCR9ILZjKtNEYCbfl35O4Rk4tRFlemUI66B2pU/14779Gmor1xVynOYgrGu9Kid
 f2K8vcb27QqxSV67DfW0HyLDcQqQYzDs6cXFGZEw2ETba4U6MvYLl9pWZBWqj1rmSa
 butx0DpweOIIcesFdLucGMfTWJcMCm/YSaT92PHcDnHpRqpf0zRvu8xayoD+8cTz8f
 YM56KjB5dvtcvZB2+sUVgHg4sRuSXAcGCU1SPNwvLiJT4FD7AGxGHZpJuLUeG0LfCQ
 sFnWMcNdNn90Q==
Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50])
 by cascadia.aikidev.net (Postfix) with ESMTPSA id 095C6131;
 Mon, 17 Mar 2025 18:21:33 -0700 (PDT)
From: Vagrant Cascadian <vagrant@HIDDEN>
Date: Mon, 17 Mar 2025 18:21:27 -0700
Message-ID: <874izrm8vc.fsf@wireframe>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Received-SPF: none client-ip=173.255.214.101; envelope-from=vagrant@HIDDEN;
 helo=cascadia.aikidev.net
X-Spam_score_int: -23
X-Spam_score: -2.4
X-Spam_bar: --
X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.335,
 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=
Content-Type: text/plain

The attached patch adds a kernel variant for mnt/reform systems.

  https://mntre.com/reform.html

I have boot tested it on a MNT/Reform2 rk3588 using Guix System, though
it may also work on other MNT/Reform variants to some degree.

Worked well enough to use sway as a desktop environment and run
librewolf while compiling it's own kernel (in ~37 minutes, on one test
build)!

Working hardware:

Built-in LCD Display
Keyboard
Trackball
USB
NVMe
SD
eMMC
serial
8 CPU cores (with frequency scaling, 4@HIDDEN & 4@HIDDEN)
32GB of ram!

Flaky hardware:

Ethernet (workarounds available, may require updated libgpiod package)

Unsupported or untested hardware:

Wifi (DEBLOBBED, though uses mPCIe, so other cards are possible)
Sound (may need workarounds, untested)
HDMI output (untested)
Battery monitoring (requires out-of-tree module, workaround is
                    monitoring battery status on built-in OLED display!)


It does pull in a fair number of patches; Some patches have already
landed in linux-next in some form (device-tree for MNT/Reform rk3588),
and some others are on their way upstream.


Any suggestions on a better way to implement 'appy-reform-patches ... I
struggled for days trying to figure out how to get them applied in
(source (patches ... or (source (snippet ... but ultimately implementing
as a phase was the only way I could get it to work.

Is "patch --force" really a good idea? It seems a common pattern in
other packages that manually implement a patching phase, but reading the
patch manpage suggests it might potentially ignore patches failing to
apply in some cases.


I already have some ideas how to simplify the 'copy-reform-dts-files
phase (e.g. by moving the files into the right place in
reform-debian-packages to require less fiddly bits in the phase).


The 'adjust-makefiles-with-new-dtb phase could reasonably be implemented
as a regular patch instead of a few (substitute* ... calls.


Suggestions are very much welcome, especially with my very limited guile
skills. Took me several days to figure some of these out, mostly staring
at inscrutible guile tracebacks, and persistently trying again, so bear
with me!

Thanks!

live well,
  vagrant

--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=0001-gnu-Add-linux-arm64-libre-mnt-reform.patch
Content-Transfer-Encoding: quoted-printable

From=203807eae28acff4181817867914c5837556655e10 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@HIDDEN>
Date: Wed, 12 Mar 2025 19:03:50 -0700
Subject: [PATCH] gnu: Add linux-libre-arm64-mnt-reform.

* gnu/packages/linux.scm (linux-libre-arm64-mnt-reform): New variable.
(reform-debian-packages): New variable.

Change-Id: I61fa18de361f2ea576608c329d168df03e163d83
=2D--
 gnu/packages/linux.scm | 307 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 307 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index b0dc6cbcfd..193dfd1b34 100644
=2D-- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -1463,6 +1463,313 @@ (define-public linux-libre-arm64-honeycomb
                         ("CONFIG_VHOST_VDPA" . m))
                       (default-extra-linux-options linux-libre-lts-version=
))))
=20
+(define-public reform-debian-packages
+  (package
+    (name "reform-debian-packages")
+    (version "278f964619e597bf0b3aae67fef52bb541bc89e6")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://source.mnt.re/reform/reform-debian-packages.git=
")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "19phz43ar2p9w0rq2pgzjx8zbxy2hppjbprvw95dvbkm8a20gv5v"))))
+    (build-system copy-build-system)
+    (arguments
+     (list ;; #:tests? #f                  ; no tests
+           #:install-plan
+           #~'(("linux/patches6.12/" "/patches")
+               ("linux/" "/dts" #:include-regexp ("\\.dts$"))
+               ("linux/config" "config")
+             )))
+    (home-page "https://source.mnt.re/reform/reform-debian-packages")
+    (synopsis "Linux kernel patches and device-trees used for MNT Reform s=
ystems")
+    (description
+     "Linux kernel patches and device-trees used for the MNT Reform system=
s")
+=20=20=20=20
+    ;; FSFAP GPL-2.0 GPL-2.0+ GPL-2.0-only (GPL-2.0-only OR BSD-2-Clause)
+    ;; GPL-2.0-only OR BSD-2-Clause (GPL-2.0 OR BSD-2-Clause) GPL-2.0-or-l=
ater
+    ;; GPL-2.0 or MIT (GPL-2.0+ OR MIT) (GPL-3.0 OR BSD-2-Clause) MIT
+    (license
+     (list
+      license:bsd-2
+      license:gpl2
+      license:gpl2+
+      license:gpl3
+      ;; license:mit
+      ;; license:FSFAP
+      ))))
+
+(define-public linux-libre-arm64-mnt-reform
+  ;; Kernel for use on the MNT/Reform laptops
+  ;; https://mntre.com/reform.html
+  (let ((base (make-linux-libre* linux-libre-6.12-version
+                     linux-libre-6.12-gnu-revision
+                     linux-libre-6.12-source
+                     '("aarch64-linux")
+                     #:extra-version "arm64-mnt-reform"
+                     #:extra-options
+                     ;; https://source.mnt.re/reform/reform-debian-package=
s/-/blob/main/linux/config
+                     (append
+                      `(("CONFIG_DRM_LVDS_CODEC" . m)
+                        ("CONFIG_DRM_CDNS_MHDP8546" . m)
+                        ("CONFIG_DRM_CDNS_HDMI_CEC" . m)
+                        ("CONFIG_DRM_IMX_CDNS_MHDP" . m)
+                        ("CONFIG_DRM_IMX_DCSS" . m)
+                        ("CONFIG_PHY_FSL_IMX8MQ_HDPTX" . m)
+                        ("CONFIG_DRM_PANEL_LVDS" . m)
+                        ("CONFIG_I2C_IMX_LPI2C" . m)
+                        ("CONFIG_I2C_MUX_REG" . m)
+                        ("CONFIG_INTERCONNECT_IMX" . #true)
+                        ("CONFIG_INTERCONNECT_IMX8MQ" . #true)
+                        ("CONFIG_MFD_WM8994" . m)
+                        ("CONFIG_MUX_GPIO" . m)
+                        ("CONFIG_MUX_MMIO" . m)
+                        ("CONFIG_RTC_DRV_PCF8523" . m)
+                        ("CONFIG_USB_EHCI_FSL" . m)
+                        ("CONFIG_NO_HZ_IDLE" . #true)
+                        ("CONFIG_SND_SOC_FSL_MICFIL" . m)
+                        ("CONFIG_SND_IMX_SOC" . m)
+                        ("CONFIG_SND_SOC_FSL_ASOC_CARD" . m)
+                        ("CONFIG_SND_SOC_IMX_AUDMIX" . m)
+                        ("CONFIG_SND_SOC_IMX_HDMI" . m)
+                        ("CONFIG_INPUT_JOYSTICK" . #true)
+                        ("CONFIG_JOYSTICK_XPAD" . m)
+                        ("CONFIG_JOYSTICK_XPAD_FF" . #true)
+                        ("CONFIG_JOYSTICK_XPAD_LEDS" . #true)
+                        ("CONFIG_INTERCONNECT_IMX8MP" . #true)
+                        ("CONFIG_SND_SOC_FSL_ASRC" . #true)
+                        ("CONFIG_DRM_IMX_LCDIF" . #true)
+                        ("CONFIG_DRM_IMX8MP_DW_HDMI_BRIDGE" . #true)
+                        ("CONFIG_DRM_IMX8MP_HDMI_PVI" . #true)
+                        ("CONFIG_IMX8MM_THERMAL" . #true)
+                        ("CONFIG_IMX2_WDT" . #true)
+                        ("CONFIG_DRM_SAMSUNG_DSIM" . #true)
+                        ("CONFIG_PHY_FSL_SAMSUNG_HDMI_PHY" . #true)
+                        ("CONFIG_DRM" . #true)
+                        ("CONFIG_DRM_PANEL_MNT_POCKET_REFORM" . #true)
+                        ("CONFIG_IMX8M_BLK_CTRL" . #true)
+                        ("CONFIG_IMX_GPCV2_PM_DOMAINS" . #true)
+                        ("CONFIG_DRM_DISPLAY_CONNECTOR" . #true)
+                        ("CONFIG_DRM_FSL_LDB" . #true)
+                        ("CONFIG_BACKLIGHT_CLASS_DEVICE" . #true)
+                        ("CONFIG_BACKLIGHT_PWM" . #true)
+                        ("CONFIG_BACKLIGHT_GPIO" . #true)
+                        ("CONFIG_BACKLIGHT_LED" . #true)
+                        ("CONFIG_CPU_FREQ_GOV_PERFORMANCE" . #true)
+                        ("CONFIG_CPU_FREQ_GOV_POWERSAVE" . #true)
+                        ("CONFIG_CPU_FREQ_GOV_USERSPACE" . #true)
+                        ("CONFIG_CPU_FREQ_GOV_ONDEMAND" . #true)
+                        ("CONFIG_CPU_FREQ_GOV_CONSERVATIVE" . #true)
+                        ("CONFIG_CPU_FREQ_GOV_SCHEDUTIL" . #true)
+                        ("CONFIG_ARM_IMX_CPUFREQ_DT" . #true)
+                        ("CONFIG_ARM_IMX_BUS_DEVFREQ" . #true)
+                        ("CONFIG_IMX_IRQSTEER" . #true)
+                        ("CONFIG_PCI_MESON" . #true)
+                        ("CONFIG_DWMAC_MESON" . #true)
+                        ("CONFIG_MDIO_BUS_MUX_MESON_G12A" . #true)
+                        ("CONFIG_I2C_MESON" . #true)
+                        ("CONFIG_PWM_MESON" . #true)
+                        ("CONFIG_USB_DWC3_MESON_G12A" . #true)
+                        ("CONFIG_MMC_MESON_GX" . #true)
+                        ("CONFIG_MMC_MESON_MX_SDIO" . #true)
+                        ("CONFIG_MESON_DDR_PMU" . #true)
+                        ("CONFIG_RTW88_8822CS" . m)
+                        ("CONFIG_PWM_FSL_FTM" . #true)
+                        ("CONFIG_FSL_RCPM" . #true)
+                        ("CONFIG_ARM_ROCKCHIP_CPUFREQ" . m)
+                        ("CONFIG_DRM_PANTHOR" . m)
+                        ("CONFIG_NVMEM_ROCKCHIP_OTP" . #true)
+                        ("CONFIG_PHY_ROCKCHIP_SAMSUNG_HDPTX" . m)
+                        ("CONFIG_PHY_ROCKCHIP_USBDP" . m)
+                        ("CONFIG_ROCKCHIP_INNO_HDMI" . #true)
+                        ("CONFIG_ROCKCHIP_LVDS" . #true)
+                        ("CONFIG_ROCKCHIP_REGULATOR_COUPLER" . #true)
+                        ("CONFIG_SPI_ROCKCHIP" . #true)
+                        ("CONFIG_SPI_ROCKCHIP_SFC" . m)
+                        ("CONFIG_ARM_SCMI_CPUFREQ" . m)
+                        ("CONFIG_PHY_ROCKCHIP_SAMSUNG_DCPHY" . m)
+                        ("CONFIG_VIDEO_ROCKCHIP_VDEC2" . m)
+                        ("CONFIG_ROCKCHIP_DW_HDMI_QP" . #true)
+                        ("CONFIG_ROCKCHIP_DW_MIPI_DSI" . #true))
+                      (default-extra-linux-options linux-libre-6.12-versio=
n)))))
+    (package
+      (inherit base)
+      (inputs (list reform-debian-packages))
+      (arguments
+       (substitute-keyword-arguments
+           (package-arguments base)
+         ((#:phases phases)
+          #~(modify-phases #$phases
+              (add-after 'unpack 'apply-reform-patches
+                (lambda* (#:key inputs #:allow-other-keys)
+                  (for-each (lambda (patch)
+                              (invoke "patch" "-p1" "--force" "-i"
+                                      (search-input-file
+                                       inputs
+                                       (string-append "patches/" patch))))
+                            (list
+                             "imx8mp-mnt-pocket-reform/2ghz/0001-imx8mp-2g=
hz-clk.patch"
+                             "imx8mp-mnt-pocket-reform/2ghz/0002-imx8mp-2g=
hz-opp.patch"
+                             "imx8mp-mnt-pocket-reform/audio/0000-revert-c=
rashy-audiomix-pm-support.patch"
+                             "imx8mp-mnt-pocket-reform/mmc-sdio/0001-sdhci=
-add-no-sd-uhs-sdr104-devicetree-property.patch"
+                             "imx8mp-mnt-pocket-reform/mmc-sdio/0002-Durin=
g-the-card-init-the-host-side-sometimes-may-nee.patch"
+                             "imx8mp-mnt-pocket-reform/mmc-sdio/0003-USDHC=
-IP-has-one-limitation-the-tuning-circuit-can-t.patch"
+                             "imx8mp-mnt-pocket-reform/pocket-panel/0001-v=
5-add-multi-display-panel-driver.patch"
+                             "imx8mp-mnt-reform2/0001-sn65dsi86-use-hs-clo=
ck-of-samsung-dsim-host-directly.patch"
+                             "imx8mp-mnt-reform2/0002-lcdif-dont-exceed-de=
sired-pixel-clock.patch"
+                             "imx8mq-mnt-reform2/0001-nwl-dsi-fixup-mode-o=
nly-for-LCDIF-input-not-DCSS.patch"
+                             "imx8mq-mnt-reform2/0002-pci-imx6-add-support=
-for-internal-refclk-imx8mq.patch"
+                             "imx8mq-mnt-reform2/0003-lcdif-fix-pcie-inter=
ference.patch"
+                             "imx8mq-mnt-reform2/0004-mnt4002-imx-gpcv2-wa=
ke-smccc.patch.patch"
+                             ;; Does not apply, needs further investigation
+                             ;; "imx8mq-mnt-reform2/v19_20241126_sandor_yu=
_initial_support_cadence_mhdp8501_hdmi_dp_for_i_mx8mq.mbx"
+                             "ls1028a-mnt-reform2/0000-dtsi-add-hdptx.patc=
h"
+                             "meson-g12b-bananapi-cm4-mnt-pocket-reform/00=
01-a311d-viu-fifo-lines-config.patch"
+                             "meson-g12b-bananapi-cm4-mnt-pocket-reform/00=
02-a311d-viu-fifo-lines-config-header.patch"
+                             "meson-g12b-bananapi-cm4-mnt-pocket-reform/00=
03-tlv320aic31xx-add-1228800hz-support.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0001-Rev=
ert-drm-bridge-synopsys-dw-mipi-dsi-enable-EoTp-b.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0011-dw-=
mipi-dsi-phy-stop-wait-time.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0012-inn=
olux-n125hce-gn1-timing-tweaks.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0013-mes=
on-viu-hold-fifo-lines.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0014-mes=
on-venc-sync.patch.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0015-mes=
on-dw-mipi-dsi-sync-invert.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0016-sn6=
5dsi86-burst-mode-support.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0018-sn6=
5dsi86-never-turn-off.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0020-LOC=
AL-ALSA-Assign-internal-PCM-chmap-ELD-IEC958-kctl.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0021-HAC=
K-of-partial-revert-of-fdt.c-changes.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0022-add=
-bt-and-eth-resets.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0023-sdi=
o-pullups.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0024-sdi=
o-improve-wifi-speed.patch"
+                             "rk3588-mnt-reform2/0001-regulator-Add-of_reg=
ulator_get_optional-for-pure-DT-.patch"
+                             "rk3588-mnt-reform2/0001-scripts-package-buil=
ddeb-allow-hooks-also-in-usr-sha.patch"
+                             "rk3588-mnt-reform2/0002-regulator-Add-devres=
-version-of-of_regulator_get_opt.patch"
+                             "rk3588-mnt-reform2/0004-arm64-dts-rockchip-r=
k3588-rock5b-add-USB-C-support.patch"
+                             "rk3588-mnt-reform2/0005-math.h-add-DIV_ROUND=
_UP_NO_OVERFLOW.patch"
+                             "rk3588-mnt-reform2/0006-clk-divider-Fix-divi=
sor-masking-on-64-bit-platforms.patch"
+                             "rk3588-mnt-reform2/0007-clk-composite-replac=
e-open-coded-abs_diff.patch"
+                             "rk3588-mnt-reform2/0008-clk-rockchip-support=
-clocks-registered-late.patch"
+                             "rk3588-mnt-reform2/0009-clk-rockchip-rk3588-=
register-GATE_LINK-later.patch"
+                             "rk3588-mnt-reform2/0010-clk-rockchip-expose-=
rockchip_clk_set_lookup.patch"
+                             "rk3588-mnt-reform2/0011-clk-rockchip-impleme=
nt-linked-gate-clock-support.patch"
+                             "rk3588-mnt-reform2/0012-clk-rockchip-rk3588-=
drop-RK3588_LINKED_CLK.patch"
+                             "rk3588-mnt-reform2/0013-arm64-dts-rockchip-r=
k3588-evb1-add-bluetooth-rfkill.patch"
+                             "rk3588-mnt-reform2/0014-arm64-dts-rockchip-r=
k3588-evb1-improve-PCIe-ethernet.patch"
+                             "rk3588-mnt-reform2/0015-arm64-dts-rockchip-S=
low-down-EMMC-a-bit-to-keep-IO-s.patch"
+                             "rk3588-mnt-reform2/0016-vop2-Add-clock-reset=
s-support.patch"
+                             "rk3588-mnt-reform2/0017-arm64-dts-rockchip-A=
dd-VOP-clock-resets-for-rk3588s.patch"
+                             "rk3588-mnt-reform2/0018-dt-bindings-display-=
vop2-Add-VP-clock-resets.patch"
+                             "rk3588-mnt-reform2/0019-media-v4l2-ctrls-cor=
e-Set-frame_mbs_only_flag-by-def.patch"
+                             "rk3588-mnt-reform2/0020-media-rockchip-Move-=
H264-CABAC-table-to-header-file.patch"
+                             "rk3588-mnt-reform2/0021-media-rockchip-Intro=
duce-the-rkvdec2-driver.patch"
+                             "rk3588-mnt-reform2/0022-media-dt-bindings-ro=
ckchip-Document-RK3588-Video-Dec.patch"
+                             "rk3588-mnt-reform2/0023-arm64-dts-rockchip-A=
dd-rkvdec2-Video-Decoder-on-rk35.patch"
+                             "rk3588-mnt-reform2/0024-arm64-defconfig-enab=
le-Rockchip-RK3588-video-decoder.patch"
+                             "rk3588-mnt-reform2/0025-mfd-rk8xx-Fix-shutdo=
wn-handler.patch"
+                             "rk3588-mnt-reform2/0026-WIP-phy-phy-rockchip=
-samsung-hdptx-Add-FRL-EARC-supp.patch"
+                             "rk3588-mnt-reform2/0027-TESTING-phy-phy-rock=
chip-samsung-hdptx-Add-verbose-l.patch"
+                             "rk3588-mnt-reform2/0028-WIP-dt-bindings-disp=
lay-rockchip-drm-Add-optional-cl.patch"
+                             "rk3588-mnt-reform2/0029-WIP-drm-rockchip-vop=
2-Improve-display-modes-handling.patch"
+                             "rk3588-mnt-reform2/0030-arm64-dts-rockchip-A=
dd-HDMI0-bridge-to-rk3588.patch"
+                             "rk3588-mnt-reform2/0031-arm64-dts-rockchip-E=
nable-HDMI0-on-rock-5b.patch"
+                             "rk3588-mnt-reform2/0032-arm64-dts-rockchip-E=
nable-HDMI0-on-rk3588-evb1.patch"
+                             "rk3588-mnt-reform2/0033-WIP-arm64-dts-rockch=
ip-Enable-HDMI0-PHY-clk-provider.patch"
+                             "rk3588-mnt-reform2/0034-WIP-arm64-dts-rockch=
ip-Make-use-of-HDMI0-PHY-PLL-on-.patch"
+                             "rk3588-mnt-reform2/0035-WIP-arm64-dts-rockch=
ip-Make-use-of-HDMI0-PHY-PLL-on-.patch"
+                             "rk3588-mnt-reform2/0036-dt-bindings-display-=
bridge-Add-schema-for-Synopsys-D.patch"
+                             "rk3588-mnt-reform2/0037-dt-bindings-display-=
rockchip-Add-schema-for-RK3588-H.patch"
+                             "rk3588-mnt-reform2/0038-drm-bridge-synopsys-=
Add-DW-HDMI-QP-TX-controller-dri.patch"
+                             "rk3588-mnt-reform2/0039-drm-rockchip-Add-bas=
ic-RK3588-HDMI-output-support.patch"
+                             "rk3588-mnt-reform2/0040-arm64-defconfig-Enab=
le-Rockchip-extensions-for-Synop.patch"
+                             "rk3588-mnt-reform2/0041-MAINTAINERS-Add-entr=
y-for-Synopsys-DesignWare-HDMI-R.patch"
+                             "rk3588-mnt-reform2/0042-dt-bindings-media-Do=
cument-bindings-for-HDMI-RX-Cont.patch"
+                             "rk3588-mnt-reform2/0043-arm64-dts-rockchip-A=
dd-device-tree-support-for-HDMI-.patch"
+                             "rk3588-mnt-reform2/0044-media-platform-synop=
sys-Add-support-for-HDMI-input-d.patch"
+                             "rk3588-mnt-reform2/0045-arm64-defconfig-Enab=
le-Synopsys-HDMI-receiver.patch"
+                             "rk3588-mnt-reform2/0046-arm64-dts-rockchip-E=
nable-HDMI-receiver-on-rock-5b.patch"
+                             "rk3588-mnt-reform2/0047-arm64-dts-rockchip-E=
nable-HDMI-receiver-on-RK3588-EV.patch"
+                             "rk3588-mnt-reform2/0048-arm64-defconfig-Enab=
le-default-EDID-for-Synopsys-HDM.patch"
+                             "rk3588-mnt-reform2/0049-regulator-Add-devm_-=
of_regulator_get.patch"
+                             "rk3588-mnt-reform2/0050-pmdomain-rockchip-cl=
eanup-mutex-handling-in-rockchip.patch"
+                             "rk3588-mnt-reform2/0051-pmdomain-rockchip-fo=
rward-rockchip_do_pmu_set_power_.patch"
+                             "rk3588-mnt-reform2/0052-pmdomain-rockchip-re=
duce-indentation-in-rockchip_pd_.patch"
+                             "rk3588-mnt-reform2/0053-dt-bindings-power-ro=
ckchip-add-regulator-support.patch"
+                             "rk3588-mnt-reform2/0054-pmdomain-rockchip-ad=
d-regulator-support.patch"
+                             "rk3588-mnt-reform2/0055-arm64-dts-rockchip-A=
dd-GPU-power-domain-regulator-de.patch"
+                             "rk3588-mnt-reform2/0056-dt-bindings-net-wire=
less-brcm4329-fmac-add-pci14e4-4.patch"
+                             "rk3588-mnt-reform2/0057-dt-bindings-net-wire=
less-brcm4329-fmac-add-clock-des.patch"
+                             "rk3588-mnt-reform2/0058-wifi-brcmfmac-Add-op=
tional-lpo-clock-enable-support.patch"
+                             ;; does not apply cleanly due to DEBLOBBING
+                             ;; "rk3588-mnt-reform2/0059-wifi-brcmfmac-add=
-flag-for-random-seed-during-firmwa.patch"
+                             "rk3588-mnt-reform2/0060-arm64-dts-rockchip-r=
k3588-evb1-add-WLAN-controller.patch"
+                             "rk3588-mnt-reform2/0061-arm64-dts-rockchip-a=
dd-and-enable-gpu-node-for-Radxa.patch"
+                             "rk3588-mnt-reform2/0062-arm64-dts-rockchip-E=
nable-HDMI0-on-rock-5a.patch"
+                             "rk3588-mnt-reform2/0100-rk3588-dtsi-add-hdmi=
1-controller.patch"
+                             "rk3588-mnt-reform2/0102-drm-panthor-Actually=
-suspend-IRQs-in-the-unplug-path.patch"
+                             "rk3588-mnt-reform2/3001-display-rockchip-add=
-schema-for-rk3588-hdmi-tx.patch"
+                             "rk3588-mnt-reform2/4000-mnt-rk3588-dual-hdmi=
-qp-rockchip.patch"
+                             "rk3588-mnt-reform2/4001-mnt-rk3588-dual-hdmi=
-vop2-pll.patch"
+                             "rk3588-mnt-reform2/5001-rk3588-dsi2-driver.p=
atch"
+                             "rk3588-mnt-reform2/5002-rk3588-dsi-dts-nodes=
.patch"
+                             "rk3588-mnt-reform2/5100-modernize-hdmi1-in-d=
tsi.patch"
+                             "rk3588-mnt-reform2/5110-hdptx-crash-workarou=
nd.patch"
+                             "rk3588-mnt-reform2/5200-drm-rockchip-Set-dma=
-mask-to-64-bit.patch"))))
+              ;; FIXME do not needlessly copy all dts files into all direc=
tories
+              (add-after 'apply-reform-patches 'copy-reform-dts-files
+			 (lambda* (#:key inputs #:allow-other-keys)
+				  (for-each (lambda (dts)
+					      (for-each (lambda (subarch)
+							  (copy-file
+							   (search-input-file
+							    inputs
+							    (string-append "/dts/" dts))
+							   (string-append (string-append "arch/arm64/boot/dts/" subarch) dt=
s)))
+							(list
+							 "rockchip/"
+							 "freescale/"
+							 "amlogic/"
+							 )))
+
+					    (list
+					     ;; rockchip
+					     "rk3588-mnt-reform2.dts"
+					     "rk3588-mnt-pocket-reform.dts"
+					     "rk3588-mnt-reform-next.dts"
+					     ;; freescale
+					     "fsl-ls1028a-mnt-reform2.dts"
+					     "imx8mq-mnt-reform2-hdmi.dts"
+					     "imx8mp-mnt-pocket-reform.dts"
+					     "imx8mq-mnt-reform2.dts"
+					     "imx8mp-mnt-reform2.dts"
+					     ;; amlogic
+					     "meson-g12b-bananapi-cm4-mnt-pocket-reform.dts"
+					     "meson-g12b-bananapi-cm4-mnt-reform2.dts"
+					     ))))
+              (add-after 'apply-reform-patches 'adjust-makefiles-with-new-=
dtb
+                (lambda _
+                  (substitute* "arch/arm64/boot/dts/amlogic/Makefile"
+                    (("meson-g12b-bananapi-cm4-mnt-reform2.dtb")
+                     "meson-g12b-bananapi-cm4-mnt-reform2.dtb
+dtb-$(CONFIG_ARCH_MESON) +=3D meson-g12b-bananapi-cm4-mnt-pocket-reform.dt=
b"))
+                  (substitute* "arch/arm64/boot/dts/freescale/Makefile"
+                    (("fsl-ls1028a-rdb.dtb")
+                     "fsl-ls1028a-rdb.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) +=3D fsl-ls1028a-mnt-reform2.dtb"))
+                  (substitute* "arch/arm64/boot/dts/freescale/Makefile"
+                    (("imx8mq-mnt-reform2.dtb")
+                      "imx8mq-mnt-reform2.dtb
+dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-mnt-reform2.dtb
+dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-mnt-pocket-reform.dtb
+dtb-$(CONFIG_ARCH_MXC) +=3D imx8mq-mnt-reform2-hdmi.dtb"))
+                  (substitute* "arch/arm64/boot/dts/rockchip/Makefile"
+                    (("rk3588-rock-5b.dtb")
+                     "rk3588-rock-5b.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588-mnt-reform2.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588-mnt-reform-next.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588-mnt-pocket-reform.dtb")))))))))))
+
 (define-public linux-libre-riscv64-generic
   (make-linux-libre* linux-libre-version
                      linux-libre-gnu-revision

base-commit: 11eb2c0ffc9a08166ec8cb8874e323bba2e74557
=2D-=20
2.39.5


--=-=-=--

--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZ9jKlwAKCRDcUY/If5cW
qrMYAQCafusuaAsiwLIqjy4kNfgNOJ6395GqwuhSIPXhpBFm7AEA08+Isa6a/tDr
C2eHGNlcuVhZBbWqHDazT/nVLA1WKAU=
=sNLF
-----END PGP SIGNATURE-----
--==-=-=--




Message sent:


Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Vagrant Cascadian <vagrant@HIDDEN>
Subject: bug#77090: Acknowledgement (Patch to add linux-libre mnt/reform
 variant)
Message-ID: <handler.77090.B.174226092421673.ack <at> debbugs.gnu.org>
References: <874izrm8vc.fsf@wireframe>
X-Gnu-PR-Message: ack 77090
X-Gnu-PR-Package: guix-patches
Reply-To: 77090 <at> debbugs.gnu.org
Date: Tue, 18 Mar 2025 01:23:05 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 77090 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
77090: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77090
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems


Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#77090] Patch to add linux-libre mnt/reform variant
Resent-From: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 18 Mar 2025 13:21:02 +0000
Resent-Message-ID: <handler.77090.B77090.174230401213837 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77090
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: Vagrant Cascadian <vagrant@HIDDEN>
Cc: w@HIDDEN, 77090 <at> debbugs.gnu.org, leo@HIDDEN
Received: via spool by 77090-submit <at> debbugs.gnu.org id=B77090.174230401213837
          (code B ref 77090); Tue, 18 Mar 2025 13:21:02 +0000
Received: (at 77090) by debbugs.gnu.org; 18 Mar 2025 13:20:12 +0000
Received: from localhost ([127.0.0.1]:38704 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tuWra-0003ak-Mo
	for submit <at> debbugs.gnu.org; Tue, 18 Mar 2025 09:20:11 -0400
Received: from relay.yourmailgateway.de ([188.68.61.107]:33395)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <pelzflorian@HIDDEN>)
 id 1tuWrW-0003Zp-Bw
 for 77090 <at> debbugs.gnu.org; Tue, 18 Mar 2025 09:20:08 -0400
Received: from mors-relay-8405.netcup.net (localhost [127.0.0.1])
 by mors-relay-8405.netcup.net (Postfix) with ESMTPS id 4ZHCBD2QCyz70wg;
 Tue, 18 Mar 2025 14:20:04 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pelzflorian.de;
 s=key2; t=1742304004;
 bh=deMbgd6NYmJyTECTzn4VEqlfUSwCR7d5p9O8luy0OZ0=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=MvnWIxHgtqlUtEkLy3tsiCOzM4Zz9umRWjDQnNafIJD6RsDeUIlIL3D1J29AP02bR
 Py2185SYQwiq8NiIX2/xnvWkskp0HwUrZssmPjDF60HpUstdc3aRbTsqsHRHb/yoJI
 sPCjxJJUETTkyWlkjaMvdUQ2kCATCnWRy2i/RlneOxZu9oZVBAJo+hAOf9JWjpzq5l
 UNDbdTiPps4X441rzgkiYSXY4IrU2i/UzX+q3zJplOYC7ksY5HzsNSCVrtqkFolHpF
 jVeLA9b5zIqQV6LDQ0BZAEZPsi0lys/r6kMcm0zbVf263qd9Gm3SAqpq6maOsLJt87
 oBUxUWeL+yjnw==
Received: from policy02-mors.netcup.net (unknown [46.38.225.35])
 by mors-relay-8405.netcup.net (Postfix) with ESMTPS id 4ZHCBD1kJkz70v4;
 Tue, 18 Mar 2025 14:20:04 +0100 (CET)
Received: from mxe217.netcup.net (unknown [10.243.12.53])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by policy02-mors.netcup.net (Postfix) with ESMTPS id 4ZHCBC1gtFz8sZf;
 Tue, 18 Mar 2025 14:20:01 +0100 (CET)
Received: from florianhp (ipb21a5dbf.dynamic.kabel-deutschland.de
 [178.26.93.191])
 by mxe217.netcup.net (Postfix) with ESMTPSA id AE16A84A68;
 Tue, 18 Mar 2025 14:19:53 +0100 (CET)
From: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
In-Reply-To: <874izrm8vc.fsf@wireframe> (Vagrant Cascadian's message of "Mon, 
 17 Mar 2025 18:21:27 -0700")
References: <874izrm8vc.fsf@wireframe>
Date: Tue, 18 Mar 2025 14:20:22 +0100
Message-ID: <87ldt2wk4p.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Rspamd-Server: rspamd-worker-8404
X-Rspamd-Queue-Id: AE16A84A68
X-NC-CID: ajTTunwvMrmhcBvy1yqxEOzhOkM7KK23K1PWsft3L/LbIKXunq0+T1np
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Well; I tested linux-libre-arm64-mnt-reform on my Orange Pi 5 Plus
with Armbian=E2=80=99s U-Boot; as expected your kernel runs as good/bad as
linux-libre-arm64-generic there.  Of course is a different machine,
but it does use RK3588.

Orange Pi still has flaky Ethernet despite patches.  You described it
as flaky as well, though.  Ethernet works on some boots, as before.
Maybe the patches you put in do help on the MNT Reform, though.

USB3 is still broken.  I do not own a MIPI DSI phone/tablet display,
apparently laptop display for MNT Reform, which should work, I guess,
with appropriate device tree settings, which I guess your patches do
for MNT Reform.  Perhaps also your kernel patches.

As far as I understand, HDMI on Orange Pi 5 Plus would require the
blob
<https://web.git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmwar=
e.git/tree/rockchip/dptx.bin>.
It seems likely that the MNT Reform RK3588 uses the CPU=E2=80=99s HDMI for
external displays as well, maybe, don=E2=80=99t know.

I have not reviewed the suitability nor license of patches.  Is it the
same license as that of the project to which each patch had been sent?

I have not run guix style nor lint and do not want to judge the Scheme
code style.

Regards,
Florian




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#77090] Patch to add linux-libre mnt/reform variant
Resent-From: Vagrant Cascadian <vagrant@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 18 Mar 2025 17:51:02 +0000
Resent-Message-ID: <handler.77090.B77090.174232022628746 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77090
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
Cc: w@HIDDEN, 77090 <at> debbugs.gnu.org, leo@HIDDEN
Received: via spool by 77090-submit <at> debbugs.gnu.org id=B77090.174232022628746
          (code B ref 77090); Tue, 18 Mar 2025 17:51:02 +0000
Received: (at 77090) by debbugs.gnu.org; 18 Mar 2025 17:50:26 +0000
Received: from localhost ([127.0.0.1]:43064 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tub52-0007Sp-IC
	for submit <at> debbugs.gnu.org; Tue, 18 Mar 2025 13:50:25 -0400
Received: from cascadia.aikidev.net ([2600:3c01:e000:267:0:a171:de7:c]:51054)
 by debbugs.gnu.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2)
 (envelope-from <vagrant@HIDDEN>) id 1tub4y-0007N9-H1
 for 77090 <at> debbugs.gnu.org; Tue, 18 Mar 2025 13:50:18 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org;
 s=1.vagrant.user; t=1742320209;
 bh=r1soVhWUCS/5wl2yR+3O5nk5BIUeacA5JcQZvxOA7d8=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=pW2U0kYzBtybcsvjt4jbPL2o1C1oA8EipecqGWxibIgFT7melYr8W45LD7UbHVf5y
 mh+aeBhc/WJ7Ltsqf2VEUoJREM6BMiCYu+JlB4KVn5pMXgzBCigq5juDaxlA9Vfwwm
 y0GvGojz6t8Z7ryRHkLlONF1aBuHnT+d6h+Puz0JQZJoPIB4/3WsPb+0GopxewqDR+
 HDmHoextGlxG8DoRuG+w23fLguKbod28NFcHGBDX0fwR399Sdh9PRW+dYKC9zOIdSN
 fDR2/PnjuHpsmCTc8iRAK0inCjBEdqGPBcvqgkEH/QoqHnrzdkNQlyoAynTuCdNbW4
 0Rp/DrDjAtvcw==
Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50])
 by cascadia.aikidev.net (Postfix) with ESMTPSA id AB80046;
 Tue, 18 Mar 2025 10:50:09 -0700 (PDT)
From: Vagrant Cascadian <vagrant@HIDDEN>
In-Reply-To: <87ldt2wk4p.fsf@HIDDEN>
References: <874izrm8vc.fsf@wireframe> <87ldt2wk4p.fsf@HIDDEN>
Date: Tue, 18 Mar 2025 10:49:34 -0700
Message-ID: <87msdikz4h.fsf@wireframe>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 2025-03-18, pelzflorian (Florian Pelz) wrote:
> Well; I tested linux-libre-arm64-mnt-reform on my Orange Pi 5 Plus
> with Armbian=E2=80=99s U-Boot; as expected your kernel runs as good/bad as
> linux-libre-arm64-generic there.  Of course is a different machine,
> but it does use RK3588.

Interesting! I think all the rk3588 specific patches are actually
indirectly from collabora's work on rk3588; a quick glance at some of
the patch names makes it clear they are not actually all mnt/reform
specific. I suspect with each kernel version those patches will be
fewer.

I am most interested in the rk3588 patches, which is the largest current
patchset, but the imx8mq, imx8mp, ls1028a and meson-g12b are other
variants produced by mnt/reform, and require fewer patches to
upstream. I have no idea how many of each are out there in the wild, and
I suspect new ones are focused on rk3588, largely because it outperforms
all the others. There is also a RISC-V core option.

A comparison of all the current module options:

  https://mntre.com/modularity.html


> Orange Pi still has flaky Ethernet despite patches.  You described it
> as flaky as well, though.  Ethernet works on some boots, as before.
> Maybe the patches you put in do help on the MNT Reform, though.

The kernal patches alone are not sufficient, the workaround for
mnt/reform rk3588 requires a newer libgpiod than present in guix
currently:

  https://source.mnt.re/reform/reform-tools/-/blob/main/bin/reform-hw-setup=
?ref_type=3Dheads#L57

Maybe that or something similar would also works on the Orange PI 5
Plus?


> USB3 is still broken.  I do not own a MIPI DSI phone/tablet display,
> apparently laptop display for MNT Reform, which should work, I guess,
> with appropriate device tree settings, which I guess your patches do
> for MNT Reform.  Perhaps also your kernel patches.

Right. I hope, anyways. I have not specifically tested USB-3 devices,
but definitely USB-2 and maybe USB-1...


> As far as I understand, HDMI on Orange Pi 5 Plus would require the
> blob
> <https://web.git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmw=
are.git/tree/rockchip/dptx.bin>.
> It seems likely that the MNT Reform RK3588 uses the CPU=E2=80=99s HDMI for
> external displays as well, maybe, don=E2=80=99t know.

It does not mention it on the modularity page listed above (only the DDR
issues), so what I need to do is boot it and try out HDMI output with
linux-libre and not firmware installed and see... :)


> I have not reviewed the suitability nor license of patches.  Is it the
> same license as that of the project to which each patch had been sent?

Ah, good reminder, I did a sloppy job with the license field of
reform-debian-packages. Most of the patches have clearly defined
SPDX-License-Identifier fields:

+    ;; FSFAP GPL-2.0 GPL-2.0+ GPL-2.0-only (GPL-2.0-only OR BSD-2-Clause)
+    ;; GPL-2.0-only OR BSD-2-Clause (GPL-2.0 OR BSD-2-Clause) GPL-2.0-or-l=
ater
+    ;; GPL-2.0 or MIT (GPL-2.0+ OR MIT) (GPL-3.0 OR BSD-2-Clause) MIT

Obviously all the GPL-2 and GPL-3 permutations are good, and the others
look good to my eye as well:

https://spdx.org/licenses/FSFAP.html
https://spdx.org/licenses/MIT.html
https://spdx.org/licenses/BSD-2-Clause.html


> I have not run guix style nor lint

Oh, but I probably should try those... good reminder!


> and do not want to judge the Scheme code style.

I am begging for a little bit of judgement here, but if you are not game
at the moment hopefully someone else can. :)


Thanks for taking the kernel for a spin and leaving some good comments!


live well,
  vagrant

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZ9myLwAKCRDcUY/If5cW
qie6AP4taCWn/1hv3fEtslxTbhuCVDV5e9ctIvi+en59mp/YxwEAvvpn0KOG9l7E
U9eguTbaPfYdQa4LFDnDSRx129CFGwY=
=3W9b
-----END PGP SIGNATURE-----
--=-=-=--




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#77090] Patch to add linux-libre mnt/reform variant
Resent-From: Vagrant Cascadian <vagrant@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 18 Mar 2025 23:22:02 +0000
Resent-Message-ID: <handler.77090.B77090.174234010324735 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77090
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
Cc: w@HIDDEN, 77090 <at> debbugs.gnu.org, leo@HIDDEN
Received: via spool by 77090-submit <at> debbugs.gnu.org id=B77090.174234010324735
          (code B ref 77090); Tue, 18 Mar 2025 23:22:02 +0000
Received: (at 77090) by debbugs.gnu.org; 18 Mar 2025 23:21:43 +0000
Received: from localhost ([127.0.0.1]:43806 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tugFj-0006Qt-3T
	for submit <at> debbugs.gnu.org; Tue, 18 Mar 2025 19:21:43 -0400
Received: from cascadia.aikidev.net ([173.255.214.101]:51562)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <vagrant@HIDDEN>)
 id 1tugFg-0006Pd-Cq
 for 77090 <at> debbugs.gnu.org; Tue, 18 Mar 2025 19:21:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org;
 s=1.vagrant.user; t=1742340093;
 bh=h3GX4FnEO6Ft+EQhKu8wtWtacc0J0EkNs/2CX8DTEJY=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=eMM02EYkpThj6BnOJo87BcTtHkQRq8HF59kiJGOuSbhhtqYGu3yJ/FOx/lxt7Wnu/
 WI8sBOUEaL8VwsKCBL28FTQhm1q++9ps6T8Zuc7v5enXMLHMLJtzRcfNNNwf7UQU2l
 61CIrA9XwtNeiWvVT/QpBJL7iN7qKqkVvUHq7XNGKSB33wFavM5LA1RXebRoyvj4YJ
 8VOND5zbYJ2nQvrCjAwpvhvb3LtTedwaqk0wqYjzGygXhEWabhD8kKEXs/VfSt/hv0
 S7FyF+8YK3CL2ZAfOmZdKnlugPobBKU3+IEeygkvTXxtZ5VMLpKnwfNnJUwC5qj7mX
 c2dF/YL03noVw==
Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50])
 by cascadia.aikidev.net (Postfix) with ESMTPSA id 9E4C546;
 Tue, 18 Mar 2025 16:21:33 -0700 (PDT)
From: Vagrant Cascadian <vagrant@HIDDEN>
In-Reply-To: <87msdikz4h.fsf@wireframe>
References: <874izrm8vc.fsf@wireframe> <87ldt2wk4p.fsf@HIDDEN>
 <87msdikz4h.fsf@wireframe>
Date: Tue, 18 Mar 2025 16:21:28 -0700
Message-ID: <875xk6kjrb.fsf@wireframe>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 2025-03-18, Vagrant Cascadian wrote:
> On 2025-03-18, pelzflorian (Florian Pelz) wrote:
>> As far as I understand, HDMI on Orange Pi 5 Plus would require the
>> blob
>> <https://web.git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firm=
ware.git/tree/rockchip/dptx.bin>.
>> It seems likely that the MNT Reform RK3588 uses the CPU=E2=80=99s HDMI f=
or
>> external displays as well, maybe, don=E2=80=99t know.
>
> It does not mention it on the modularity page listed above (only the DDR
> issues), so what I need to do is boot it and try out HDMI output with
> linux-libre and not firmware installed and see... :)

Confirmed that at least basic HDMI output on the MNT/Reform rk3588 works
without binary blobs; it shows on both screens at boot and sway detects
the 2nd display and sets it up without me having to do anything.

Maybe there is some optional functionality (DRM anti-features?) that is
missing without the blob?

live well,
  vagrant

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZ9n/+AAKCRDcUY/If5cW
qjUaAP9pYILGccZzXuLXaqNspO9ZKxk88VjtrHsGvabKoixZLAEAuBMrcfu1A8Wi
/30f64tSVcaDWAloqesqKzk8WdLy8wI=
=aK/c
-----END PGP SIGNATURE-----
--=-=-=--




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#77090] Patch to add linux-libre mnt/reform variant
Resent-From: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 19 Mar 2025 10:56:02 +0000
Resent-Message-ID: <handler.77090.B77090.174238174214415 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77090
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: Vagrant Cascadian <vagrant@HIDDEN>
Cc: w@HIDDEN, 77090 <at> debbugs.gnu.org, leo@HIDDEN
Received: via spool by 77090-submit <at> debbugs.gnu.org id=B77090.174238174214415
          (code B ref 77090); Wed, 19 Mar 2025 10:56:02 +0000
Received: (at 77090) by debbugs.gnu.org; 19 Mar 2025 10:55:42 +0000
Received: from localhost ([127.0.0.1]:48713 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tur5J-0003kR-Uz
	for submit <at> debbugs.gnu.org; Wed, 19 Mar 2025 06:55:42 -0400
Received: from relay.yourmailgateway.de ([185.244.194.184]:37743)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <pelzflorian@HIDDEN>)
 id 1tur5H-0003kG-5F
 for 77090 <at> debbugs.gnu.org; Wed, 19 Mar 2025 06:55:40 -0400
Received: from relay01-mors.netcup.net (localhost [127.0.0.1])
 by relay01-mors.netcup.net (Postfix) with ESMTPS id 4ZHlx44gfyz94mr;
 Wed, 19 Mar 2025 11:55:36 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pelzflorian.de;
 s=key2; t=1742381736;
 bh=I9/1p2tSZoIM7CyQ0ymDtHqEAdTle74j9AdTPiYmXKQ=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=eA1I2AG/S7Lw1KF92kZlQsuQqKYvDk6eY+qpV+bs8BusjauJl7VIXRKuAK0REbm6o
 51Ri9cUdqh/Cr9peXEfqBEZDJeXTC2YQiroQ8g1+xl4qjddzb1iQlEpRSyHR36H1vA
 Llz14GH1EpMhzyw2E6y0bU7nTZvVMfd/hfp9WXoufGN8wu0umzEk4WGnYlDzYiRfYM
 Yoy6TTANlpEdXhP6YmhP10obX1u6sfxvCKDG2PyFJSQMxykWcperZIb57M9b6GiwXz
 6J0j65e0CdJayR/262lKJ78UnfU16mZMcbCJ+AjwdTR+MrcCCdLnoqIQ3SRmo9PJxR
 6Q8oKPdDAbyvg==
Received: from policy02-mors.netcup.net (unknown [46.38.225.35])
 by relay01-mors.netcup.net (Postfix) with ESMTPS id 4ZHlx43zzgz7vdK;
 Wed, 19 Mar 2025 11:55:36 +0100 (CET)
Received: from mxe217.netcup.net (unknown [10.243.12.53])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by policy02-mors.netcup.net (Postfix) with ESMTPS id 4ZHlx36mrjz8svF;
 Wed, 19 Mar 2025 11:55:34 +0100 (CET)
Received: from florianhp (ipb21a5dbf.dynamic.kabel-deutschland.de
 [178.26.93.191])
 by mxe217.netcup.net (Postfix) with ESMTPSA id 1A26484AF7;
 Wed, 19 Mar 2025 11:55:26 +0100 (CET)
From: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
In-Reply-To: <874izrm8vc.fsf@wireframe> (Vagrant Cascadian's message of "Mon, 
 17 Mar 2025 18:21:27 -0700")
References: <874izrm8vc.fsf@wireframe>
Date: Wed, 19 Mar 2025 11:55:56 +0100
Message-ID: <87msdhjnlv.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Rspamd-Server: rspamd-worker-8404
X-Rspamd-Queue-Id: 1A26484AF7
X-NC-CID: lsALujSlI5V2UM/71kmfSOvrZ+HVxsUXR8iZkgMxRF2jCoiZA+pVPjel
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Vagrant Cascadian <vagrant@HIDDEN> writes:
> The attached patch adds a kernel variant for mnt/reform systems.
>
>   https://mntre.com/reform.html
>
> I have boot tested it on a MNT/Reform2 rk3588 using Guix System, though
> it may also work on other MNT/Reform variants to some degree.

Oops, only now have I understood the MNT/Reform modularity means there
can be many =E2=80=9Cprocessor modules=E2=80=9D and you made this
linux-arm64-libre-mnt-reform to support them all.

Could you make this clear in a package synopsis, description?

Regards,
Florian




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#77090] Patch to add linux-libre mnt/reform variant
Resent-From: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 19 Mar 2025 11:06:02 +0000
Resent-Message-ID: <handler.77090.B77090.174238231018261 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77090
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: Vagrant Cascadian <vagrant@HIDDEN>
Cc: w@HIDDEN, 77090 <at> debbugs.gnu.org, leo@HIDDEN
Received: via spool by 77090-submit <at> debbugs.gnu.org id=B77090.174238231018261
          (code B ref 77090); Wed, 19 Mar 2025 11:06:02 +0000
Received: (at 77090) by debbugs.gnu.org; 19 Mar 2025 11:05:10 +0000
Received: from localhost ([127.0.0.1]:48763 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1turET-0004kG-Hw
	for submit <at> debbugs.gnu.org; Wed, 19 Mar 2025 07:05:09 -0400
Received: from relay.yourmailgateway.de ([188.68.63.98]:60867)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <pelzflorian@HIDDEN>)
 id 1turEQ-0004gR-Hl
 for 77090 <at> debbugs.gnu.org; Wed, 19 Mar 2025 07:05:07 -0400
Received: from mors-relay-2501.netcup.net (localhost [127.0.0.1])
 by mors-relay-2501.netcup.net (Postfix) with ESMTPS id 4ZHm805nL1z64qM;
 Wed, 19 Mar 2025 12:05:04 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pelzflorian.de;
 s=key2; t=1742382304;
 bh=5GPlqY089dcTpCbn+9YulJB+Oqv843WeNi/sK4c0FBo=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=kpv8qjPeYp52PcbjRTcsSuJWOrEeTaQplLRT3WKEEQLkpMTPf/Q7z92mCyGG1LWSb
 3bndwFJpitXf+EkKeWNK8xrQRquo7DJ5T3wggofZRmlWCQb2erSbdzX3qG2Ux44HPz
 RiO1vBtCWNlx/UX1kQaZ7JzcHuBA//7/PoRFm7RjNORa8bO1NND/v8Gc8GH4Dbm/u3
 E6QTWfMgMNOZ+s8EldVsFoBpS1mIGiDtfYgInpaGb7iO8FuiAbvxUjZirdKm6CF0lT
 k5r15n/8s5IJ0hAsU/5GqOATMxccTijmCPofgp39U8+NDIprfdxU6+UdTQVJnalwi5
 BLdhQWWmHyV7A==
Received: from policy01-mors.netcup.net (unknown [46.38.225.35])
 by mors-relay-2501.netcup.net (Postfix) with ESMTPS id 4ZHm80556Gz4xLQ;
 Wed, 19 Mar 2025 12:05:04 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at policy01-mors.netcup.net
X-Spam-Flag: NO
X-Spam-Score: -2.9
X-Spam-Level: 
X-Spam-Status: No, score=-2.9 required=6.31 tests=[ALL_TRUSTED=-1,
 BAYES_00=-1.9] autolearn=ham autolearn_force=no
Received: from mxe217.netcup.net (unknown [10.243.12.53])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by policy01-mors.netcup.net (Postfix) with ESMTPS id 4ZHm7y44slz8scb;
 Wed, 19 Mar 2025 12:05:01 +0100 (CET)
Received: from florianhp (ipb21a5dbf.dynamic.kabel-deutschland.de
 [178.26.93.191])
 by mxe217.netcup.net (Postfix) with ESMTPSA id 52E0184AF7;
 Wed, 19 Mar 2025 12:04:54 +0100 (CET)
From: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
In-Reply-To: <875xk6kjrb.fsf@wireframe> (Vagrant Cascadian's message of "Tue, 
 18 Mar 2025 16:21:28 -0700")
References: <874izrm8vc.fsf@wireframe> <87ldt2wk4p.fsf@HIDDEN>
 <87msdikz4h.fsf@wireframe> <875xk6kjrb.fsf@wireframe>
Date: Wed, 19 Mar 2025 12:05:23 +0100
Message-ID: <87iko5jn64.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Rspamd-Server: rspamd-worker-8404
X-Rspamd-Queue-Id: 52E0184AF7
X-NC-CID: nVwykE8nZs/J/xNmGYfcMBBixaWPfHFrvrAHLh/VtitcG20yRP2xPfh5
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Vagrant Cascadian <vagrant@HIDDEN> writes:
> Confirmed that at least basic HDMI output on the MNT/Reform rk3588 works
> without binary blobs; it shows on both screens at boot and sway detects
> the 2nd display and sets it up without me having to do anything.

Wow, yes, it seems to me your working HDMI of MNT/Reform rk3588 really
is the RK3588=E2=80=99s HDMI.  Wrongly did I think RK3588=E2=80=99s HDMI wo=
rked only
through Synopsys DesignWare DPTX controller blob.  Apparently not;
apparently HDMI could be made to work on my Orange Pi somehow, too, if I
tried harder.

Thanks for correcting my view.

Regards,
Florian




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#77090] Patch to add linux-libre mnt/reform variant
Resent-From: Vagrant Cascadian <vagrant@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 19 Mar 2025 20:41:02 +0000
Resent-Message-ID: <handler.77090.B77090.174241685010588 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77090
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
Cc: w@HIDDEN, 77090 <at> debbugs.gnu.org, leo@HIDDEN
Received: via spool by 77090-submit <at> debbugs.gnu.org id=B77090.174241685010588
          (code B ref 77090); Wed, 19 Mar 2025 20:41:02 +0000
Received: (at 77090) by debbugs.gnu.org; 19 Mar 2025 20:40:50 +0000
Received: from localhost ([127.0.0.1]:53340 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tv0DY-0002kd-Rh
	for submit <at> debbugs.gnu.org; Wed, 19 Mar 2025 16:40:49 -0400
Received: from cascadia.aikidev.net ([2600:3c01:e000:267:0:a171:de7:c]:45152)
 by debbugs.gnu.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2)
 (envelope-from <vagrant@HIDDEN>) id 1tv0DV-0002kL-Ho
 for 77090 <at> debbugs.gnu.org; Wed, 19 Mar 2025 16:40:46 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org;
 s=1.vagrant.user; t=1742416838;
 bh=JiltGzjvzLpqC3u26y+6rBfDhp6Goljd0XX+VKtXIs4=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=Gqu+sBwpHs2vuLab4e4Yzxf1NyfgsKDRrLcj17XDSkhaatI/K2b1hashhHNn7T1Rq
 UZ9RB+JrAe5/6sL/hKXcloax+8h5jJCX5qhMx91N4n48SXYJyexQ0JUUtPC93bEg10
 442nyKm763Agsn/XL9+H7m/YPpA7aU2AUHBhFmUb2RBAKpz3m9ae1SajnJ0Y0FXbU1
 mH3dzC9HB9ErtmylbaplQN3hCXv4efLhF1h8+xUE0RdzKb6B7NXvKJFGgMh/MI5l14
 3hVbduigkk8m6nfVoioRiL9Se+GPVhQPM9vXqAftX3EoCwBEJ4pxAxL6pbTjqVLqBF
 PTMbGRTAA+fCg==
Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50])
 by cascadia.aikidev.net (Postfix) with ESMTPSA id 9ADE62A22;
 Wed, 19 Mar 2025 13:40:38 -0700 (PDT)
From: Vagrant Cascadian <vagrant@HIDDEN>
In-Reply-To: <87msdhjnlv.fsf@HIDDEN>
References: <874izrm8vc.fsf@wireframe> <87msdhjnlv.fsf@HIDDEN>
Date: Wed, 19 Mar 2025 13:40:33 -0700
Message-ID: <87y0x0kb3y.fsf@wireframe>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 2025-03-19, pelzflorian (Florian Pelz) wrote:
> Vagrant Cascadian <vagrant@HIDDEN> writes:
>> The attached patch adds a kernel variant for mnt/reform systems.
>>
>>   https://mntre.com/reform.html
>>
>> I have boot tested it on a MNT/Reform2 rk3588 using Guix System, though
>> it may also work on other MNT/Reform variants to some degree.
>
> Oops, only now have I understood the MNT/Reform modularity means there
> can be many =E2=80=9Cprocessor modules=E2=80=9D and you made this
> linux-arm64-libre-mnt-reform to support them all.
>
> Could you make this clear in a package synopsis, description?

Thanks for the suggestion!

I implemented a bare minimal description/synopsis update, but on
re-reading what you suggested again it could probably be elaborated on
to more explicitly mention the variants with different CPU modules...

Attached is a v2 of the patch that includes some of those suggestions
and other improvements.

Summary of changes since v0:

reform-debian-packages:
* apply guix style
* drop useless commented out #:tests?
* clean up comments around licenses
* install .dts files in vendor-specific directories

linux-libre-arm64-mnt-reform:
* apply guix style (except keep #true instead of #t, seriously!)
* do not use --force when applying patches
* simplify 'copy-reform-dts-files phase
* extend description and synopsis to mention mnt/reform systems

live well,
  vagrant

--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=v2-0001-gnu-Add-linux-libre-arm64-mnt-reform.patch
Content-Transfer-Encoding: quoted-printable

From=20f6980be7bc497134ea754856af3b5133c26f5d7a Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@HIDDEN>
Date: Wed, 19 Mar 2025 13:01:00 -0700
Subject: [PATCH v2] gnu: Add linux-libre-arm64-mnt-reform.

* gnu/packages/linux.scm (linux-libre-arm64-mnt-reform): New variable.
(reform-debian-packages): New variable.

Change-Id: I61fa18de361f2ea576608c329d168df03e163d83

Changes since v0:

reform-debian-packages:
* apply guix style
* drop useless commented out #:tests?
* clean up comments around licenses
* install .dts files in vendor-specific directories

linux-libre-arm64-mnt-reform:
* apply guix style (except keep #true instead of #t, seriously!)
* do not use --force when applying patches
* simplify 'copy-reform-dts-files phase
* extend description and synopsis to mention mnt/reform systems
=2D--
 gnu/packages/linux.scm | 299 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 299 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index b0dc6cbcfd..c3cbe2a8d3 100644
=2D-- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -1463,6 +1463,305 @@ (define-public linux-libre-arm64-honeycomb
                         ("CONFIG_VHOST_VDPA" . m))
                       (default-extra-linux-options linux-libre-lts-version=
))))
=20
+(define-public reform-debian-packages
+  (package
+    (name "reform-debian-packages")
+    (version "278f964619e597bf0b3aae67fef52bb541bc89e6")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://source.mnt.re/reform/reform-debian-packages.git=
")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "19phz43ar2p9w0rq2pgzjx8zbxy2hppjbprvw95dvbkm8a20gv5v"))))
+    (build-system copy-build-system)
+    (arguments
+     (list
+      #:install-plan
+      #~'(("linux/patches6.12/" "/patches")
+          ("linux/" "/dts/amlogic"
+           #:include-regexp ("meson.*\\.dts$"))
+          ("linux/" "/dts/freescale"
+           #:include-regexp ("imx8.*\\.dts$"))
+          ("linux/" "/dts/freescale"
+           #:include-regexp ("fsl.*\\.dts$"))
+          ("linux/" "/dts/rockchip"
+           #:include-regexp ("rk3588.*\\.dts$"))
+          ("linux/config" "config"))))
+    (home-page "https://source.mnt.re/reform/reform-debian-packages")
+    (synopsis
+     "Linux kernel patches and device-trees used for MNT Reform systems")
+    (description
+     "Linux kernel patches and device-trees used for the MNT Reform system=
s")
+    (license (list
+              ;; FIXME license:mit
+              ;; FIXME license:FSFAP
+              license:bsd-2
+              license:gpl2
+              license:gpl2+
+              license:gpl3))))
+
+(define-public linux-libre-arm64-mnt-reform
+  ;; Kernel for use on the MNT/Reform systems
+  ;; https://mntre.com/reform.html
+  (let ((base (make-linux-libre* linux-libre-6.12-version
+                                 linux-libre-6.12-gnu-revision
+                                 linux-libre-6.12-source
+                                 '("aarch64-linux")
+                                 #:extra-version "arm64-mnt-reform"
+                                 #:extra-options
+                                 ;; https://source.mnt.re/reform/reform-de=
bian-packages/-/blob/main/linux/config
+                                 (append `(("CONFIG_DRM_LVDS_CODEC" . m)
+                                           ("CONFIG_DRM_CDNS_MHDP8546" . m)
+                                           ("CONFIG_DRM_CDNS_HDMI_CEC" . m)
+                                           ("CONFIG_DRM_IMX_CDNS_MHDP" . m)
+                                           ("CONFIG_DRM_IMX_DCSS" . m)
+                                           ("CONFIG_PHY_FSL_IMX8MQ_HDPTX" =
. m)
+                                           ("CONFIG_DRM_PANEL_LVDS" . m)
+                                           ("CONFIG_I2C_IMX_LPI2C" . m)
+                                           ("CONFIG_I2C_MUX_REG" . m)
+                                           ("CONFIG_INTERCONNECT_IMX" . #t=
rue)
+                                           ("CONFIG_INTERCONNECT_IMX8MQ" .=
 #true)
+                                           ("CONFIG_MFD_WM8994" . m)
+                                           ("CONFIG_MUX_GPIO" . m)
+                                           ("CONFIG_MUX_MMIO" . m)
+                                           ("CONFIG_RTC_DRV_PCF8523" . m)
+                                           ("CONFIG_USB_EHCI_FSL" . m)
+                                           ("CONFIG_NO_HZ_IDLE" . #true)
+                                           ("CONFIG_SND_SOC_FSL_MICFIL" . =
m)
+                                           ("CONFIG_SND_IMX_SOC" . m)
+                                           ("CONFIG_SND_SOC_FSL_ASOC_CARD"=
 . m)
+                                           ("CONFIG_SND_SOC_IMX_AUDMIX" . =
m)
+                                           ("CONFIG_SND_SOC_IMX_HDMI" . m)
+                                           ("CONFIG_INPUT_JOYSTICK" . #tru=
e)
+                                           ("CONFIG_JOYSTICK_XPAD" . m)
+                                           ("CONFIG_JOYSTICK_XPAD_FF" . #t=
rue)
+                                           ("CONFIG_JOYSTICK_XPAD_LEDS" . =
#true)
+                                           ("CONFIG_INTERCONNECT_IMX8MP" .=
 #true)
+                                           ("CONFIG_SND_SOC_FSL_ASRC" . #t=
rue)
+                                           ("CONFIG_DRM_IMX_LCDIF" . #true)
+                                           ("CONFIG_DRM_IMX8MP_DW_HDMI_BRI=
DGE" . #true)
+                                           ("CONFIG_DRM_IMX8MP_HDMI_PVI" .=
 #true)
+                                           ("CONFIG_IMX8MM_THERMAL" . #tru=
e)
+                                           ("CONFIG_IMX2_WDT" . #true)
+                                           ("CONFIG_DRM_SAMSUNG_DSIM" . #t=
rue)
+                                           ("CONFIG_PHY_FSL_SAMSUNG_HDMI_P=
HY" . #true)
+                                           ("CONFIG_DRM" . #true)
+                                           ("CONFIG_DRM_PANEL_MNT_POCKET_R=
EFORM" . #true)
+                                           ("CONFIG_IMX8M_BLK_CTRL" . #tru=
e)
+                                           ("CONFIG_IMX_GPCV2_PM_DOMAINS" =
. #true)
+                                           ("CONFIG_DRM_DISPLAY_CONNECTOR"=
 . #true)
+                                           ("CONFIG_DRM_FSL_LDB" . #true)
+                                           ("CONFIG_BACKLIGHT_CLASS_DEVICE=
" . #true)
+                                           ("CONFIG_BACKLIGHT_PWM" . #true)
+                                           ("CONFIG_BACKLIGHT_GPIO" . #tru=
e)
+                                           ("CONFIG_BACKLIGHT_LED" . #true)
+                                           ("CONFIG_CPU_FREQ_GOV_PERFORMAN=
CE" . #true)
+                                           ("CONFIG_CPU_FREQ_GOV_POWERSAVE=
" . #true)
+                                           ("CONFIG_CPU_FREQ_GOV_USERSPACE=
" . #true)
+                                           ("CONFIG_CPU_FREQ_GOV_ONDEMAND"=
 . #true)
+                                           ("CONFIG_CPU_FREQ_GOV_CONSERVAT=
IVE" . #true)
+                                           ("CONFIG_CPU_FREQ_GOV_SCHEDUTIL=
" . #true)
+                                           ("CONFIG_ARM_IMX_CPUFREQ_DT" . =
#true)
+                                           ("CONFIG_ARM_IMX_BUS_DEVFREQ" .=
 #true)
+                                           ("CONFIG_IMX_IRQSTEER" . #true)
+                                           ("CONFIG_PCI_MESON" . #true)
+                                           ("CONFIG_DWMAC_MESON" . #true)
+                                           ("CONFIG_MDIO_BUS_MUX_MESON_G12=
A" . #true)
+                                           ("CONFIG_I2C_MESON" . #true)
+                                           ("CONFIG_PWM_MESON" . #true)
+                                           ("CONFIG_USB_DWC3_MESON_G12A" .=
 #true)
+                                           ("CONFIG_MMC_MESON_GX" . #true)
+                                           ("CONFIG_MMC_MESON_MX_SDIO" . #=
true)
+                                           ("CONFIG_MESON_DDR_PMU" . #true)
+                                           ("CONFIG_RTW88_8822CS" . m)
+                                           ("CONFIG_PWM_FSL_FTM" . #true)
+                                           ("CONFIG_FSL_RCPM" . #true)
+                                           ("CONFIG_ARM_ROCKCHIP_CPUFREQ" =
. m)
+                                           ("CONFIG_DRM_PANTHOR" . m)
+                                           ("CONFIG_NVMEM_ROCKCHIP_OTP" . =
#true)
+                                           ("CONFIG_PHY_ROCKCHIP_SAMSUNG_H=
DPTX" . m)
+                                           ("CONFIG_PHY_ROCKCHIP_USBDP" . =
m)
+                                           ("CONFIG_ROCKCHIP_INNO_HDMI" . =
#true)
+                                           ("CONFIG_ROCKCHIP_LVDS" . #true)
+                                           ("CONFIG_ROCKCHIP_REGULATOR_COU=
PLER" . #true)
+                                           ("CONFIG_SPI_ROCKCHIP" . #true)
+                                           ("CONFIG_SPI_ROCKCHIP_SFC" . m)
+                                           ("CONFIG_ARM_SCMI_CPUFREQ" . m)
+                                           ("CONFIG_PHY_ROCKCHIP_SAMSUNG_D=
CPHY" . m)
+                                           ("CONFIG_VIDEO_ROCKCHIP_VDEC2" =
. m)
+                                           ("CONFIG_ROCKCHIP_DW_HDMI_QP" .=
 #true)
+                                           ("CONFIG_ROCKCHIP_DW_MIPI_DSI" =
. #true))
+                                         (default-extra-linux-options
+                                          linux-libre-6.12-version)))))
+    (package
+      (inherit base)
+      (inputs (list reform-debian-packages))
+      (synopsis (string-append (package-synopsis base)
+                               " for MNT/Reform systems"))
+      (description (string-append (package-description base)
+                    "  Configuration options and patches have been applied=
 for use with MNT/Reform systems."))
+      (arguments
+       (substitute-keyword-arguments (package-arguments base)
+         ((#:phases phases)
+          #~(modify-phases #$phases
+              (add-after 'unpack 'apply-reform-patches
+                (lambda* (#:key inputs #:allow-other-keys)
+                  (for-each (lambda (patch)
+                              (invoke "patch" "-p1" "-i"
+                                      (search-input-file inputs
+                                                         (string-append
+                                                          "patches/" patch=
))))
+                            (list
+                             "imx8mp-mnt-pocket-reform/2ghz/0001-imx8mp-2g=
hz-clk.patch"
+                             "imx8mp-mnt-pocket-reform/2ghz/0002-imx8mp-2g=
hz-opp.patch"
+                             "imx8mp-mnt-pocket-reform/audio/0000-revert-c=
rashy-audiomix-pm-support.patch"
+                             "imx8mp-mnt-pocket-reform/mmc-sdio/0001-sdhci=
-add-no-sd-uhs-sdr104-devicetree-property.patch"
+                             "imx8mp-mnt-pocket-reform/mmc-sdio/0002-Durin=
g-the-card-init-the-host-side-sometimes-may-nee.patch"
+                             "imx8mp-mnt-pocket-reform/mmc-sdio/0003-USDHC=
-IP-has-one-limitation-the-tuning-circuit-can-t.patch"
+                             "imx8mp-mnt-pocket-reform/pocket-panel/0001-v=
5-add-multi-display-panel-driver.patch"
+                             "imx8mp-mnt-reform2/0001-sn65dsi86-use-hs-clo=
ck-of-samsung-dsim-host-directly.patch"
+                             "imx8mp-mnt-reform2/0002-lcdif-dont-exceed-de=
sired-pixel-clock.patch"
+                             "imx8mq-mnt-reform2/0001-nwl-dsi-fixup-mode-o=
nly-for-LCDIF-input-not-DCSS.patch"
+                             "imx8mq-mnt-reform2/0002-pci-imx6-add-support=
-for-internal-refclk-imx8mq.patch"
+                             "imx8mq-mnt-reform2/0003-lcdif-fix-pcie-inter=
ference.patch"
+                             "imx8mq-mnt-reform2/0004-mnt4002-imx-gpcv2-wa=
ke-smccc.patch.patch"
+                             ;; Does not apply, needs further investigation
+                             ;; "imx8mq-mnt-reform2/v19_20241126_sandor_yu=
_initial_support_cadence_mhdp8501_hdmi_dp_for_i_mx8mq.mbx"
+                             "ls1028a-mnt-reform2/0000-dtsi-add-hdptx.patc=
h"
+                             "meson-g12b-bananapi-cm4-mnt-pocket-reform/00=
01-a311d-viu-fifo-lines-config.patch"
+                             "meson-g12b-bananapi-cm4-mnt-pocket-reform/00=
02-a311d-viu-fifo-lines-config-header.patch"
+                             "meson-g12b-bananapi-cm4-mnt-pocket-reform/00=
03-tlv320aic31xx-add-1228800hz-support.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0001-Rev=
ert-drm-bridge-synopsys-dw-mipi-dsi-enable-EoTp-b.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0011-dw-=
mipi-dsi-phy-stop-wait-time.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0012-inn=
olux-n125hce-gn1-timing-tweaks.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0013-mes=
on-viu-hold-fifo-lines.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0014-mes=
on-venc-sync.patch.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0015-mes=
on-dw-mipi-dsi-sync-invert.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0016-sn6=
5dsi86-burst-mode-support.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0018-sn6=
5dsi86-never-turn-off.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0020-LOC=
AL-ALSA-Assign-internal-PCM-chmap-ELD-IEC958-kctl.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0021-HAC=
K-of-partial-revert-of-fdt.c-changes.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0022-add=
-bt-and-eth-resets.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0023-sdi=
o-pullups.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0024-sdi=
o-improve-wifi-speed.patch"
+                             "rk3588-mnt-reform2/0001-regulator-Add-of_reg=
ulator_get_optional-for-pure-DT-.patch"
+                             "rk3588-mnt-reform2/0001-scripts-package-buil=
ddeb-allow-hooks-also-in-usr-sha.patch"
+                             "rk3588-mnt-reform2/0002-regulator-Add-devres=
-version-of-of_regulator_get_opt.patch"
+                             "rk3588-mnt-reform2/0004-arm64-dts-rockchip-r=
k3588-rock5b-add-USB-C-support.patch"
+                             "rk3588-mnt-reform2/0005-math.h-add-DIV_ROUND=
_UP_NO_OVERFLOW.patch"
+                             "rk3588-mnt-reform2/0006-clk-divider-Fix-divi=
sor-masking-on-64-bit-platforms.patch"
+                             "rk3588-mnt-reform2/0007-clk-composite-replac=
e-open-coded-abs_diff.patch"
+                             "rk3588-mnt-reform2/0008-clk-rockchip-support=
-clocks-registered-late.patch"
+                             "rk3588-mnt-reform2/0009-clk-rockchip-rk3588-=
register-GATE_LINK-later.patch"
+                             "rk3588-mnt-reform2/0010-clk-rockchip-expose-=
rockchip_clk_set_lookup.patch"
+                             "rk3588-mnt-reform2/0011-clk-rockchip-impleme=
nt-linked-gate-clock-support.patch"
+                             "rk3588-mnt-reform2/0012-clk-rockchip-rk3588-=
drop-RK3588_LINKED_CLK.patch"
+                             "rk3588-mnt-reform2/0013-arm64-dts-rockchip-r=
k3588-evb1-add-bluetooth-rfkill.patch"
+                             "rk3588-mnt-reform2/0014-arm64-dts-rockchip-r=
k3588-evb1-improve-PCIe-ethernet.patch"
+                             "rk3588-mnt-reform2/0015-arm64-dts-rockchip-S=
low-down-EMMC-a-bit-to-keep-IO-s.patch"
+                             "rk3588-mnt-reform2/0016-vop2-Add-clock-reset=
s-support.patch"
+                             "rk3588-mnt-reform2/0017-arm64-dts-rockchip-A=
dd-VOP-clock-resets-for-rk3588s.patch"
+                             "rk3588-mnt-reform2/0018-dt-bindings-display-=
vop2-Add-VP-clock-resets.patch"
+                             "rk3588-mnt-reform2/0019-media-v4l2-ctrls-cor=
e-Set-frame_mbs_only_flag-by-def.patch"
+                             "rk3588-mnt-reform2/0020-media-rockchip-Move-=
H264-CABAC-table-to-header-file.patch"
+                             "rk3588-mnt-reform2/0021-media-rockchip-Intro=
duce-the-rkvdec2-driver.patch"
+                             "rk3588-mnt-reform2/0022-media-dt-bindings-ro=
ckchip-Document-RK3588-Video-Dec.patch"
+                             "rk3588-mnt-reform2/0023-arm64-dts-rockchip-A=
dd-rkvdec2-Video-Decoder-on-rk35.patch"
+                             "rk3588-mnt-reform2/0024-arm64-defconfig-enab=
le-Rockchip-RK3588-video-decoder.patch"
+                             "rk3588-mnt-reform2/0025-mfd-rk8xx-Fix-shutdo=
wn-handler.patch"
+                             "rk3588-mnt-reform2/0026-WIP-phy-phy-rockchip=
-samsung-hdptx-Add-FRL-EARC-supp.patch"
+                             "rk3588-mnt-reform2/0027-TESTING-phy-phy-rock=
chip-samsung-hdptx-Add-verbose-l.patch"
+                             "rk3588-mnt-reform2/0028-WIP-dt-bindings-disp=
lay-rockchip-drm-Add-optional-cl.patch"
+                             "rk3588-mnt-reform2/0029-WIP-drm-rockchip-vop=
2-Improve-display-modes-handling.patch"
+                             "rk3588-mnt-reform2/0030-arm64-dts-rockchip-A=
dd-HDMI0-bridge-to-rk3588.patch"
+                             "rk3588-mnt-reform2/0031-arm64-dts-rockchip-E=
nable-HDMI0-on-rock-5b.patch"
+                             "rk3588-mnt-reform2/0032-arm64-dts-rockchip-E=
nable-HDMI0-on-rk3588-evb1.patch"
+                             "rk3588-mnt-reform2/0033-WIP-arm64-dts-rockch=
ip-Enable-HDMI0-PHY-clk-provider.patch"
+                             "rk3588-mnt-reform2/0034-WIP-arm64-dts-rockch=
ip-Make-use-of-HDMI0-PHY-PLL-on-.patch"
+                             "rk3588-mnt-reform2/0035-WIP-arm64-dts-rockch=
ip-Make-use-of-HDMI0-PHY-PLL-on-.patch"
+                             "rk3588-mnt-reform2/0036-dt-bindings-display-=
bridge-Add-schema-for-Synopsys-D.patch"
+                             "rk3588-mnt-reform2/0037-dt-bindings-display-=
rockchip-Add-schema-for-RK3588-H.patch"
+                             "rk3588-mnt-reform2/0038-drm-bridge-synopsys-=
Add-DW-HDMI-QP-TX-controller-dri.patch"
+                             "rk3588-mnt-reform2/0039-drm-rockchip-Add-bas=
ic-RK3588-HDMI-output-support.patch"
+                             "rk3588-mnt-reform2/0040-arm64-defconfig-Enab=
le-Rockchip-extensions-for-Synop.patch"
+                             "rk3588-mnt-reform2/0041-MAINTAINERS-Add-entr=
y-for-Synopsys-DesignWare-HDMI-R.patch"
+                             "rk3588-mnt-reform2/0042-dt-bindings-media-Do=
cument-bindings-for-HDMI-RX-Cont.patch"
+                             "rk3588-mnt-reform2/0043-arm64-dts-rockchip-A=
dd-device-tree-support-for-HDMI-.patch"
+                             "rk3588-mnt-reform2/0044-media-platform-synop=
sys-Add-support-for-HDMI-input-d.patch"
+                             "rk3588-mnt-reform2/0045-arm64-defconfig-Enab=
le-Synopsys-HDMI-receiver.patch"
+                             "rk3588-mnt-reform2/0046-arm64-dts-rockchip-E=
nable-HDMI-receiver-on-rock-5b.patch"
+                             "rk3588-mnt-reform2/0047-arm64-dts-rockchip-E=
nable-HDMI-receiver-on-RK3588-EV.patch"
+                             "rk3588-mnt-reform2/0048-arm64-defconfig-Enab=
le-default-EDID-for-Synopsys-HDM.patch"
+                             "rk3588-mnt-reform2/0049-regulator-Add-devm_-=
of_regulator_get.patch"
+                             "rk3588-mnt-reform2/0050-pmdomain-rockchip-cl=
eanup-mutex-handling-in-rockchip.patch"
+                             "rk3588-mnt-reform2/0051-pmdomain-rockchip-fo=
rward-rockchip_do_pmu_set_power_.patch"
+                             "rk3588-mnt-reform2/0052-pmdomain-rockchip-re=
duce-indentation-in-rockchip_pd_.patch"
+                             "rk3588-mnt-reform2/0053-dt-bindings-power-ro=
ckchip-add-regulator-support.patch"
+                             "rk3588-mnt-reform2/0054-pmdomain-rockchip-ad=
d-regulator-support.patch"
+                             "rk3588-mnt-reform2/0055-arm64-dts-rockchip-A=
dd-GPU-power-domain-regulator-de.patch"
+                             "rk3588-mnt-reform2/0056-dt-bindings-net-wire=
less-brcm4329-fmac-add-pci14e4-4.patch"
+                             "rk3588-mnt-reform2/0057-dt-bindings-net-wire=
less-brcm4329-fmac-add-clock-des.patch"
+                             "rk3588-mnt-reform2/0058-wifi-brcmfmac-Add-op=
tional-lpo-clock-enable-support.patch"
+                             ;; does not apply cleanly due to DEBLOBBING
+                             ;; "rk3588-mnt-reform2/0059-wifi-brcmfmac-add=
-flag-for-random-seed-during-firmwa.patch"
+                             "rk3588-mnt-reform2/0060-arm64-dts-rockchip-r=
k3588-evb1-add-WLAN-controller.patch"
+                             "rk3588-mnt-reform2/0061-arm64-dts-rockchip-a=
dd-and-enable-gpu-node-for-Radxa.patch"
+                             "rk3588-mnt-reform2/0062-arm64-dts-rockchip-E=
nable-HDMI0-on-rock-5a.patch"
+                             "rk3588-mnt-reform2/0100-rk3588-dtsi-add-hdmi=
1-controller.patch"
+                             "rk3588-mnt-reform2/0102-drm-panthor-Actually=
-suspend-IRQs-in-the-unplug-path.patch"
+                             "rk3588-mnt-reform2/3001-display-rockchip-add=
-schema-for-rk3588-hdmi-tx.patch"
+                             "rk3588-mnt-reform2/4000-mnt-rk3588-dual-hdmi=
-qp-rockchip.patch"
+                             "rk3588-mnt-reform2/4001-mnt-rk3588-dual-hdmi=
-vop2-pll.patch"
+                             "rk3588-mnt-reform2/5001-rk3588-dsi2-driver.p=
atch"
+                             "rk3588-mnt-reform2/5002-rk3588-dsi-dts-nodes=
.patch"
+                             "rk3588-mnt-reform2/5100-modernize-hdmi1-in-d=
tsi.patch"
+                             "rk3588-mnt-reform2/5110-hdptx-crash-workarou=
nd.patch"
+                             "rk3588-mnt-reform2/5200-drm-rockchip-Set-dma=
-mask-to-64-bit.patch"))))
+              (add-after 'apply-reform-patches 'copy-reform-dts-files
+                (lambda* (#:key inputs #:allow-other-keys)
+                  (for-each (lambda (dts)
+                              (copy-file (search-input-file inputs
+                                                            (string-append
+                                                             "/dts/" dts))
+                                         (string-append "arch/arm64/boot/d=
ts/"
+                                          dts)))
+                            (list
+                             "amlogic/meson-g12b-bananapi-cm4-mnt-pocket-r=
eform.dts"
+                             "amlogic/meson-g12b-bananapi-cm4-mnt-reform2.=
dts"
+                             "freescale/fsl-ls1028a-mnt-reform2.dts"
+                             "freescale/imx8mp-mnt-pocket-reform.dts"
+                             "freescale/imx8mp-mnt-reform2.dts"
+                             "freescale/imx8mq-mnt-reform2-hdmi.dts"
+                             "freescale/imx8mq-mnt-reform2.dts"
+                             "rockchip/rk3588-mnt-pocket-reform.dts"
+                             "rockchip/rk3588-mnt-reform-next.dts"
+                             "rockchip/rk3588-mnt-reform2.dts"))))
+              (add-after 'apply-reform-patches 'adjust-makefiles-with-new-=
dtb
+                (lambda _
+                  (substitute* "arch/arm64/boot/dts/amlogic/Makefile"
+                    (("meson-g12b-bananapi-cm4-mnt-reform2.dtb")
+                     "meson-g12b-bananapi-cm4-mnt-reform2.dtb
+dtb-$(CONFIG_ARCH_MESON) +=3D meson-g12b-bananapi-cm4-mnt-pocket-reform.dt=
b"))
+                  (substitute* "arch/arm64/boot/dts/freescale/Makefile"
+                    (("fsl-ls1028a-rdb.dtb")
+                     "fsl-ls1028a-rdb.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) +=3D fsl-ls1028a-mnt-reform2.dtb"))
+                  (substitute* "arch/arm64/boot/dts/freescale/Makefile"
+                    (("imx8mq-mnt-reform2.dtb")
+                     "imx8mq-mnt-reform2.dtb
+dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-mnt-reform2.dtb
+dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-mnt-pocket-reform.dtb
+dtb-$(CONFIG_ARCH_MXC) +=3D imx8mq-mnt-reform2-hdmi.dtb"))
+                  (substitute* "arch/arm64/boot/dts/rockchip/Makefile"
+                    (("rk3588-rock-5b.dtb")
+                     "rk3588-rock-5b.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588-mnt-reform2.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588-mnt-reform-next.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588-mnt-pocket-reform.dtb")))))))))))
+
 (define-public linux-libre-riscv64-generic
   (make-linux-libre* linux-libre-version
                      linux-libre-gnu-revision

base-commit: 1890807c87917b13c202ff1d9cba1a107cb5c3f9
=2D-=20
2.39.5


--=-=-=--

--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZ9srwQAKCRDcUY/If5cW
ql6QAQCXTN4juXGjtH+o4ABFLSaEXYVFgrLl68UazUbZHIpfdAD7BQIiNR4If4A7
k7e8r+GkCZK/hykbeqX08ZT2+/lzBAg=
=DUlG
-----END PGP SIGNATURE-----
--==-=-=--




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#77090] Patch to add linux-libre mnt/reform variant
Resent-From: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 22 Mar 2025 18:02:02 +0000
Resent-Message-ID: <handler.77090.B77090.174266647023009 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77090
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: Vagrant Cascadian <vagrant@HIDDEN>
Cc: w@HIDDEN, 77090 <at> debbugs.gnu.org, leo@HIDDEN
Received: via spool by 77090-submit <at> debbugs.gnu.org id=B77090.174266647023009
          (code B ref 77090); Sat, 22 Mar 2025 18:02:02 +0000
Received: (at 77090) by debbugs.gnu.org; 22 Mar 2025 18:01:10 +0000
Received: from localhost ([127.0.0.1]:45364 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tw39c-0005yv-Fx
	for submit <at> debbugs.gnu.org; Sat, 22 Mar 2025 14:01:09 -0400
Received: from relay.yourmailgateway.de ([46.38.247.119]:50763)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <pelzflorian@HIDDEN>)
 id 1tw39Y-0005xy-MT
 for 77090 <at> debbugs.gnu.org; Sat, 22 Mar 2025 14:01:02 -0400
Received: from mors-relay-8404.netcup.net (localhost [127.0.0.1])
 by mors-relay-8404.netcup.net (Postfix) with ESMTPS id 4ZKnDV53ywz831K;
 Sat, 22 Mar 2025 19:00:58 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pelzflorian.de;
 s=key2; t=1742666458;
 bh=aQ7xJiiV+vK4Gvap0sEsx9MjQPdv9pbCEG3vN/mbLEg=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=hnlytYYo3UhicVQbUlVKGiJ7EiErqT3otCZKk1vryAL/xpeHjnNK8jv5D9GxuszZh
 6Pno2OtIiYJGXNaa+gC82AG2ndx1A8UXNsGkj5wbvLM7g4GbDPryCm1Dk2W2+41EpV
 +EkztYQfwmVHeXkXKqYO9gTxxfOZmDOX9CStLz+hqsSs5aFwkHW1SIOGGGoS752Rsj
 UHgRt0bh47/iQHmkuPJmcuqr9yPO2zFnVI7mz9WQEMpARlpY54/RWyiJZyeMbN4uvA
 XJQrQk83xDJ91uUmG/yOE2GriYFgVbnVMXSdPlwovBgqDxfF1Q+rk4s/dYpoJ7LLAK
 DDojU2oKVc3xw==
Received: from policy02-mors.netcup.net (unknown [46.38.225.35])
 by mors-relay-8404.netcup.net (Postfix) with ESMTPS id 4ZKnDV4hTVz4xHf;
 Sat, 22 Mar 2025 19:00:58 +0100 (CET)
Received: from mxe217.netcup.net (unknown [10.243.12.53])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by policy02-mors.netcup.net (Postfix) with ESMTPS id 4ZKnDV1JpFz8sZf;
 Sat, 22 Mar 2025 19:00:57 +0100 (CET)
Received: from florianhp (ipb21a5dbf.dynamic.kabel-deutschland.de
 [178.26.93.191])
 by mxe217.netcup.net (Postfix) with ESMTPSA id 6F55884684;
 Sat, 22 Mar 2025 19:00:50 +0100 (CET)
From: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
In-Reply-To: <87y0x0kb3y.fsf@wireframe> (Vagrant Cascadian's message of "Wed, 
 19 Mar 2025 13:40:33 -0700")
References: <874izrm8vc.fsf@wireframe> <87msdhjnlv.fsf@HIDDEN>
 <87y0x0kb3y.fsf@wireframe>
Date: Sat, 22 Mar 2025 19:01:21 +0100
Message-ID: <87sen5x7v2.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Rspamd-Server: rspamd-worker-8404
X-Rspamd-Queue-Id: 6F55884684
X-NC-CID: cFm964h5lLIJOiEH4aVMEVCy+qBOXfT7d79Hv7ciPAok/63UFBQy+Q8W
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Thank you Vagrant for this work.

Vagrant Cascadian <vagrant@HIDDEN> writes:
> +    (version "278f964619e597bf0b3aae67fef52bb541bc89e6")

This is a bad version; newer versions are not increasing.

The commit 278f964619e597bf0b3aae67fef52bb541bc89e6 you use for
reform-debian-packages is no longer the most recent commit.  Which commit
should we use?

We may need to remove the reprepro.sh (see end of this e-mail),

Vagrant Cascadian <vagrant@HIDDEN> writes:
> +    (license (list
> +              ;; FIXME license:mit
> +              ;; FIXME license:FSFAP
> +              license:bsd-2
> +              license:gpl2
> +              license:gpl2+
> +              license:gpl3))))

Likely should be
(list license:gpl2
      license:gpl2+
      license:gpl3+
      license:x11
      license:expat
      license:fsf-free)

I do not know where in your list, license:bsd-2 comes from.  Possibly
license:bsd-2 is correct for some file, too?

https://source.mnt.re/reform/reform-debian-packages/-/blob/main/patches/bmap-tools?ref_type=head
is license:gpl2, because bmaptools is and it is from a pull request to it.

https://source.mnt.re/reform/reform-debian-packages/-/blob/main/patches/ffmpeg?ref_type=heads
ffmpeg is  license:gpl2+

https://source.mnt.re/reform/reform-debian-packages/-/blob/main/patches/flash-kernel?ref_type=heads
is not copyright-worthy, but anyway
flash-kernel script is license:gpl2+

https://source.mnt.re/reform/reform-debian-packages/-/blob/main/patches/mesa?ref_type=heads
Mesa has license:x11.
License:x11 is the MIT license.

(define x11
  (license "X11"
           "http://directory.fsf.org/wiki/License:X11"
           "https://www.gnu.org/licenses/license-list#X11License"))

<https://directory.fsf.org/wiki/License:X11>
is the same as the license header <https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/src/panfrost/lib/pan_layout.c>

https://source.mnt.re/reform/reform-debian-packages/-/blob/main/patches/reform-tools?ref_type=heads
I find <https://salsa.debian.org/reform-team/reform-tools>
which is license:gpl3+

https://source.mnt.re/reform/reform-debian-packages/-/blob/main/patches/u-boot-menu?ref_type=heads
is <https://salsa.debian.org/debian/u-boot-menu>
appears to be license:gpl2 or license:gpl2+

https://source.mnt.re/reform/reform-debian-packages/-/blob/main/build_custom.sh?ref_type=heads
https://source.mnt.re/reform/reform-debian-packages/-/blob/main/common.sh?ref_type=heads
https://source.mnt.re/reform/reform-debian-packages/-/blob/main/setup.sh?ref_type=heads
is # SPDX-License-Identifier: MIT
is <https://spdx.org/licenses/MIT.html>
is <https://directory.fsf.org/wiki/License:Expat>
is license:expat

https://source.mnt.re/reform/reform-debian-packages/-/blob/main/filter-output?ref_type=heads
is # SPDX-License-Identifier: FSFAP
guix/import/utils.scm maps with %spdx-license-identifiers this way:
("FSFAP" . license:fsf-free)

https://source.mnt.re/reform/reform-debian-packages/-/blob/main/reprepro.sh?ref_type=heads
has no license :(
Remove it in an origin snippet?
Though you also do not use this tiny script.

I have not looked at the linux patches, but likely gpl2 or another
of the above GPL versions.

Regards,
Florian




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#77090] Patch to add linux-libre mnt/reform variant
Resent-From: Vagrant Cascadian <vagrant@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 22 Mar 2025 18:59:02 +0000
Resent-Message-ID: <handler.77090.B77090.174266993020191 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77090
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
Cc: w@HIDDEN, 77090 <at> debbugs.gnu.org, leo@HIDDEN
Received: via spool by 77090-submit <at> debbugs.gnu.org id=B77090.174266993020191
          (code B ref 77090); Sat, 22 Mar 2025 18:59:02 +0000
Received: (at 77090) by debbugs.gnu.org; 22 Mar 2025 18:58:50 +0000
Received: from localhost ([127.0.0.1]:45471 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tw43T-0005FG-SO
	for submit <at> debbugs.gnu.org; Sat, 22 Mar 2025 14:58:49 -0400
Received: from cascadia.aikidev.net ([173.255.214.101]:48554)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <vagrant@HIDDEN>)
 id 1tw43Q-0005Ea-0y
 for 77090 <at> debbugs.gnu.org; Sat, 22 Mar 2025 14:58:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org;
 s=1.vagrant.user; t=1742669916;
 bh=UNIgHiLLLejvfFLw520mT5WdhmM+NHoRV2i+L+YFAk0=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=GzoiPi5A5v2jI/jMqY/0LimO17xzx4EF3ULIovh90mW+uzHfc7pjYwneMl1PmUdSX
 cJ2R0thMcSAH9ilfUkWjSOz22oQ2kychnUBnagg8NaWirFxHIuW6HdVxDR5qvZ/sgO
 oB7rzODezz/wMPPLoWEzDWhIqgZzidunsVN2cMs97fdD3c5kLZ/7dZbfF4AH+VfMQm
 0RrB+Jc6KbSHah815/KNoSra9rAyfaTgMVY7JnuN0aH+J4AEbMmyytWJJbMAlKyw+Q
 N8psmer3rjHJjRybrhNQ2xJud+OGq0CRJNyNIfPEZtP7p7088JFowEvUtqWdimg2yO
 Sa1uxXBxeskpw==
Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50])
 by cascadia.aikidev.net (Postfix) with ESMTPSA id 8FE2F5BA8;
 Sat, 22 Mar 2025 11:58:36 -0700 (PDT)
From: Vagrant Cascadian <vagrant@HIDDEN>
In-Reply-To: <87sen5x7v2.fsf@HIDDEN>
References: <874izrm8vc.fsf@wireframe> <87msdhjnlv.fsf@HIDDEN>
 <87y0x0kb3y.fsf@wireframe> <87sen5x7v2.fsf@HIDDEN>
Date: Sat, 22 Mar 2025 11:58:31 -0700
Message-ID: <87ecyoki3s.fsf@wireframe>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain

On 2025-03-22, pelzflorian (Florian Pelz) wrote:
> Thank you Vagrant for this work.

And thanks for the review! :)


> Vagrant Cascadian <vagrant@HIDDEN> writes:
>> +    (version "278f964619e597bf0b3aae67fef52bb541bc89e6")
>
> This is a bad version; newer versions are not increasing.

Yeah, I wondered about this... did not think it mattered too much
because it just ships some patch files used as an input; it is not a
package someone is likely to include in a profile where the version
would matter. Might be a case for using (define ... instead of
(define-public ... of course I can make up a more meaningful
git-commit-hash derived version if we absolutely must... :)


> The commit 278f964619e597bf0b3aae67fef52bb541bc89e6 you use for
> reform-debian-packages is no longer the most recent commit.  Which commit
> should we use?

Current head is probably also fine (seems to have one new or updated
patch to the relevent kernel patches which might require adjusting patch
phase), but that was the commit I tested so far.


> Vagrant Cascadian <vagrant@HIDDEN> writes:
>> +    (license (list
>> +              ;; FIXME license:mit
>> +              ;; FIXME license:FSFAP
>> +              license:bsd-2
>> +              license:gpl2
>> +              license:gpl2+
>> +              license:gpl3))))
>
> Likely should be
> (list license:gpl2
>       license:gpl2+
>       license:gpl3+
>       license:x11
>       license:expat
>       license:fsf-free)

Sounds plausible to me. :)

FWIW, I am also fine with dropping anything outside of linux/ in a
snippet, if it makes the licensing simpler, as we really use none of
the other files.


> I do not know where in your list, license:bsd-2 comes from.  Possibly
> license:bsd-2 is correct for some file, too?

Most .dts related files in linux are dual-licensed under GPL and one of
various permissive licenses ... (e.g. GPL-2* OR BSD|MIT|X11).

  $ git grep SPDX linux/patches6.12/ | grep BSD
  linux/patches6.12/imx8mq-mnt-reform2/v19_20241126_sandor_yu_initial_support_cadence_mhdp8501_hdmi_dp_for_i_mx8mq.mbx:+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
  linux/patches6.12/imx8mq-mnt-reform2/v19_20241126_sandor_yu_initial_support_cadence_mhdp8501_hdmi_dp_for_i_mx8mq.mbx:+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
  linux/patches6.12/rk3588-mnt-reform2/0036-dt-bindings-display-bridge-Add-schema-for-Synopsys-D.patch:+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
  linux/patches6.12/rk3588-mnt-reform2/0037-dt-bindings-display-rockchip-Add-schema-for-RK3588-H.patch:+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
  linux/patches6.12/rk3588-mnt-reform2/0042-dt-bindings-media-Document-bindings-for-HDMI-RX-Cont.patch:+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
  linux/patches6.12/rk3588-mnt-reform2/3001-display-rockchip-add-schema-for-rk3588-hdmi-tx.patch:+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
  linux/patches6.12/rk3588-mnt-reform2/5001-rk3588-dsi2-driver.patch:+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)


> https://source.mnt.re/reform/reform-debian-packages/-/blob/main/patches/mesa?ref_type=heads
> Mesa has license:x11.
> License:x11 is the MIT license.
>
> (define x11
>   (license "X11"
>            "http://directory.fsf.org/wiki/License:X11"
>            "https://www.gnu.org/licenses/license-list#X11License"))
>
> <https://directory.fsf.org/wiki/License:X11>
> is the same as the license header
> <https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/src/panfrost/lib/pan_layout.c

That's good to know. I am a little less familiar with GNU licensing
conventions, mostly coming from Debian, while not totally different,
have some different conventional takes.


> https://source.mnt.re/reform/reform-debian-packages/-/blob/main/build_custom.sh?ref_type=heads
> https://source.mnt.re/reform/reform-debian-packages/-/blob/main/common.sh?ref_type=heads
> https://source.mnt.re/reform/reform-debian-packages/-/blob/main/setup.sh?ref_type=heads
> is # SPDX-License-Identifier: MIT
> is <https://spdx.org/licenses/MIT.html>
> is <https://directory.fsf.org/wiki/License:Expat>
> is license:expat

Also useful, thanks!


> https://source.mnt.re/reform/reform-debian-packages/-/blob/main/filter-output?ref_type=heads
> is # SPDX-License-Identifier: FSFAP
> guix/import/utils.scm maps with %spdx-license-identifiers this way:
> ("FSFAP" . license:fsf-free)

Great!


> https://source.mnt.re/reform/reform-debian-packages/-/blob/main/reprepro.sh?ref_type=heads
> has no license :(
> Remove it in an origin snippet?
> Though you also do not use this tiny script.

I can probably get upstream to fix that, but we also do not need it at
all.


> I have not looked at the linux patches, but likely gpl2 or another
> of the above GPL versions.

I focused on linux/patches6.12 mainly, as those were the ones I am
actually using, and other than the device-tree patches that are
dual-licensed, likely all the rest should be gpl2 or gpl2+.


live well,
  vagrant

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZ98IVwAKCRDcUY/If5cW
qh3KAPwK34PtVPV1pL7A51ml6nmNHLTxpD7VwKnDf3aDcn3seAD8D+yp4UVdR0dR
BM8kP8ns4SlpcBtAV4ZeMZBHrN3qdQ0=
=kzt9
-----END PGP SIGNATURE-----
--=-=-=--




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#77090] Patch to add linux-libre mnt/reform variant
Resent-From: Vagrant Cascadian <vagrant@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 22 Mar 2025 23:35:01 +0000
Resent-Message-ID: <handler.77090.B77090.17426864547946 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77090
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
Cc: w@HIDDEN, 77090 <at> debbugs.gnu.org, leo@HIDDEN
Received: via spool by 77090-submit <at> debbugs.gnu.org id=B77090.17426864547946
          (code B ref 77090); Sat, 22 Mar 2025 23:35:01 +0000
Received: (at 77090) by debbugs.gnu.org; 22 Mar 2025 23:34:14 +0000
Received: from localhost ([127.0.0.1]:46197 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tw8M0-000245-Ny
	for submit <at> debbugs.gnu.org; Sat, 22 Mar 2025 19:34:13 -0400
Received: from cascadia.aikidev.net ([173.255.214.101]:49350)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <vagrant@HIDDEN>)
 id 1tw8Lw-00022R-P3
 for 77090 <at> debbugs.gnu.org; Sat, 22 Mar 2025 19:34:11 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org;
 s=1.vagrant.user; t=1742686440;
 bh=/YW645zAVf4F0PX03mci85iqw5MEcAmjNtkgSWUPzwk=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=b+kLfL9j9nS/lcW+0ERs9px4aQQVF5rXRTukDsBvxrxq6gZlYvhKVwMIARz/lCnxs
 4vJO/cxVJbojQxOoJzHnTkoq+DgSp2chLKc83F9hj9G9ebq0mPfk1pVxdGUTtAVIyV
 CaNSoq+io5emaA2Akjm4JbEf4m7O8M8eTx3OgKOUprIobJArjUN6/APellKJIEp66y
 IFbLX3FyuTQ70Ct6CfTMzGYz8pwkXR7ZMQeQ6llk+FD9z+NKx6H0pftv2DdLXHRuFU
 ogwEGUEA/p8EXl6bO5DxmQAU2fkMGFfWZz6quz5FTmNK2/GIajBAUBc6lWvrI5gLaP
 5F+lQIVGwcG9g==
Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50])
 by cascadia.aikidev.net (Postfix) with ESMTPSA id CF4AA8B;
 Sat, 22 Mar 2025 16:34:00 -0700 (PDT)
From: Vagrant Cascadian <vagrant@HIDDEN>
In-Reply-To: <87ecyoki3s.fsf@wireframe>
References: <874izrm8vc.fsf@wireframe> <87msdhjnlv.fsf@HIDDEN>
 <87y0x0kb3y.fsf@wireframe> <87sen5x7v2.fsf@HIDDEN>
 <87ecyoki3s.fsf@wireframe>
Date: Sat, 22 Mar 2025 16:33:55 -0700
Message-ID: <878qowk5cs.fsf@wireframe>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=
Content-Type: text/plain

On 2025-03-22, Vagrant Cascadian wrote:
> On 2025-03-22, pelzflorian (Florian Pelz) wrote:
>> Vagrant Cascadian <vagrant@HIDDEN> writes:
>>> +    (version "278f964619e597bf0b3aae67fef52bb541bc89e6")
>>
>> This is a bad version; newer versions are not increasing.
>
> Yeah, I wondered about this... did not think it mattered too much
> because it just ships some patch files used as an input; it is not a
> package someone is likely to include in a profile where the version
> would matter. Might be a case for using (define ... instead of
> (define-public ... of course I can make up a more meaningful
> git-commit-hash derived version if we absolutely must... :)

Used a version based on the output from git describe.


>> The commit 278f964619e597bf0b3aae67fef52bb541bc89e6 you use for
>> reform-debian-packages is no longer the most recent commit.  Which commit
>> should we use?
>
> Current head is probably also fine (seems to have one new or updated
> patch to the relevent kernel patches which might require adjusting patch
> phase), but that was the commit I tested so far.

Updated to the latest commit, which updated one of the patches (but did
not change names, so no further updates needed in the packaging.


>> Vagrant Cascadian <vagrant@HIDDEN> writes:
>>> +    (license (list
>>> +              ;; FIXME license:mit
>>> +              ;; FIXME license:FSFAP
>>> +              license:bsd-2
>>> +              license:gpl2
>>> +              license:gpl2+
>>> +              license:gpl3))))
>>
>> Likely should be
>> (list license:gpl2
>>       license:gpl2+
>>       license:gpl3+
>>       license:x11
>>       license:expat
>>       license:fsf-free)
>
> Sounds plausible to me. :)

I incorporated all these; they seem consistent with my observations,
although fsf-free required arguments.


>> https://source.mnt.re/reform/reform-debian-packages/-/blob/main/reprepro.sh?ref_type=heads
>> has no license :(
>> Remove it in an origin snippet?
>> Though you also do not use this tiny script.
>
> I can probably get upstream to fix that, but we also do not need it at
> all.

Working on submitting the issue upstream...

Changes since v2:

reform-debian-packages:
* Update to 2023-07-10-318-g85274b8.
* Update license field.

linux-libre-arm64-mnt-reform:
* Add ATH9K wireless to configuration.

live well,
  vagrant

--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=v3-0001-gnu-Add-linux-libre-arm64-mnt-reform.patch
Content-Transfer-Encoding: quoted-printable

From=209101ce682ed1ffaa7f34dba22c197f96a4696363 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@HIDDEN>
Date: Wed, 19 Mar 2025 13:01:00 -0700
Subject: [PATCH v3] gnu: Add linux-libre-arm64-mnt-reform.

* gnu/packages/linux.scm (linux-libre-arm64-mnt-reform): New variable.
(reform-debian-packages): New variable.

Change-Id: I61fa18de361f2ea576608c329d168df03e163d83

Changes since v2:

reform-debian-packages:
* Update to 2023-07-10-318-g85274b8.
* Update  license field.

linux-libre-arm64-mnt-reform:
* Add ATH9K wireless to configuration.

Changes since v0:

reform-debian-packages:
* apply guix style
* drop useless commented out #:tests?
* clean up comments around licenses
* install .dts files in vendor-specific directories

linux-libre-arm64-mnt-reform:
* apply guix style (except keep #true instead of #t, seriously!)
* do not use --force when applying patches
* simplify 'copy-reform-dts-files phase
* extend description and synopsis to mention mnt/reform systems
=2D--
 gnu/packages/linux.scm | 306 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 306 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 1417925dc8..16a2484c90 100644
=2D-- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -1463,6 +1463,312 @@ (define-public linux-libre-arm64-honeycomb
                         ("CONFIG_VHOST_VDPA" . m))
                       (default-extra-linux-options linux-libre-lts-version=
))))
=20
+(define-public reform-debian-packages
+  (package
+    (name "reform-debian-packages")
+    (version "2023-07-10-318-g85274b8")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://source.mnt.re/reform/reform-debian-packages.git=
")
+             (commit "85274b83eb057dafd367b3ae04a16ce6c11dff69")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1scg5mq6pig7bd2vnkj9ay4q5n7rnwlq0mn7q2brr5gr79g15yld"))))
+    (build-system copy-build-system)
+    (arguments
+     (list
+      #:install-plan
+      #~'(("linux/patches6.12/" "/patches")
+          ("linux/" "/dts/amlogic"
+           #:include-regexp ("meson.*\\.dts$"))
+          ("linux/" "/dts/freescale"
+           #:include-regexp ("imx8.*\\.dts$"))
+          ("linux/" "/dts/freescale"
+           #:include-regexp ("fsl.*\\.dts$"))
+          ("linux/" "/dts/rockchip"
+           #:include-regexp ("rk3588.*\\.dts$"))
+          ("linux/config" "config"))))
+    (home-page "https://source.mnt.re/reform/reform-debian-packages")
+    (synopsis
+     "Linux kernel patches and device-trees used for MNT Reform systems")
+    (description
+     "Linux kernel patches and device-trees used for the MNT Reform system=
s")
+    (license (list
+              (license:fsf-free "file://filter-output" "# SPDX-License-Ide=
ntifier: FSFAP
+# Copying and distribution of this file, with or without modification, are
+# permitted in any medium without royalty provided the copyright notice and
+# this notice are preserved. This file is offered as-is, without any warra=
nty.")
+              license:bsd-2
+              license:expat
+              license:gpl2
+              license:gpl2+
+              license:gpl3
+              license:x11))))
+
+(define-public linux-libre-arm64-mnt-reform
+  ;; Kernel for use on the MNT/Reform systems
+  ;; https://mntre.com/reform.html
+  (let ((base (make-linux-libre* linux-libre-6.12-version
+                                 linux-libre-6.12-gnu-revision
+                                 linux-libre-6.12-source
+                                 '("aarch64-linux")
+                                 #:extra-version "arm64-mnt-reform"
+                                 #:extra-options
+                                 ;; https://source.mnt.re/reform/reform-de=
bian-packages/-/blob/main/linux/config
+                                 (append `(("CONFIG_DRM_LVDS_CODEC" . m)
+                                           ("CONFIG_DRM_CDNS_MHDP8546" . m)
+                                           ("CONFIG_DRM_CDNS_HDMI_CEC" . m)
+                                           ("CONFIG_DRM_IMX_CDNS_MHDP" . m)
+                                           ("CONFIG_DRM_IMX_DCSS" . m)
+                                           ("CONFIG_PHY_FSL_IMX8MQ_HDPTX" =
. m)
+                                           ("CONFIG_DRM_PANEL_LVDS" . m)
+                                           ("CONFIG_I2C_IMX_LPI2C" . m)
+                                           ("CONFIG_I2C_MUX_REG" . m)
+                                           ("CONFIG_INTERCONNECT_IMX" . #t=
rue)
+                                           ("CONFIG_INTERCONNECT_IMX8MQ" .=
 #true)
+                                           ("CONFIG_MFD_WM8994" . m)
+                                           ("CONFIG_MUX_GPIO" . m)
+                                           ("CONFIG_MUX_MMIO" . m)
+                                           ("CONFIG_RTC_DRV_PCF8523" . m)
+                                           ("CONFIG_USB_EHCI_FSL" . m)
+                                           ("CONFIG_NO_HZ_IDLE" . #true)
+                                           ("CONFIG_SND_SOC_FSL_MICFIL" . =
m)
+                                           ("CONFIG_SND_IMX_SOC" . m)
+                                           ("CONFIG_SND_SOC_FSL_ASOC_CARD"=
 . m)
+                                           ("CONFIG_SND_SOC_IMX_AUDMIX" . =
m)
+                                           ("CONFIG_SND_SOC_IMX_HDMI" . m)
+                                           ("CONFIG_INPUT_JOYSTICK" . #tru=
e)
+                                           ("CONFIG_JOYSTICK_XPAD" . m)
+                                           ("CONFIG_JOYSTICK_XPAD_FF" . #t=
rue)
+                                           ("CONFIG_JOYSTICK_XPAD_LEDS" . =
#true)
+                                           ("CONFIG_INTERCONNECT_IMX8MP" .=
 #true)
+                                           ("CONFIG_SND_SOC_FSL_ASRC" . #t=
rue)
+                                           ("CONFIG_DRM_IMX_LCDIF" . #true)
+                                           ("CONFIG_DRM_IMX8MP_DW_HDMI_BRI=
DGE" . #true)
+                                           ("CONFIG_DRM_IMX8MP_HDMI_PVI" .=
 #true)
+                                           ("CONFIG_IMX8MM_THERMAL" . #tru=
e)
+                                           ("CONFIG_IMX2_WDT" . #true)
+                                           ("CONFIG_DRM_SAMSUNG_DSIM" . #t=
rue)
+                                           ("CONFIG_PHY_FSL_SAMSUNG_HDMI_P=
HY" . #true)
+                                           ("CONFIG_DRM" . #true)
+                                           ("CONFIG_DRM_PANEL_MNT_POCKET_R=
EFORM" . #true)
+                                           ("CONFIG_IMX8M_BLK_CTRL" . #tru=
e)
+                                           ("CONFIG_IMX_GPCV2_PM_DOMAINS" =
. #true)
+                                           ("CONFIG_DRM_DISPLAY_CONNECTOR"=
 . #true)
+                                           ("CONFIG_DRM_FSL_LDB" . #true)
+                                           ("CONFIG_BACKLIGHT_CLASS_DEVICE=
" . #true)
+                                           ("CONFIG_BACKLIGHT_PWM" . #true)
+                                           ("CONFIG_BACKLIGHT_GPIO" . #tru=
e)
+                                           ("CONFIG_BACKLIGHT_LED" . #true)
+                                           ("CONFIG_CPU_FREQ_GOV_PERFORMAN=
CE" . #true)
+                                           ("CONFIG_CPU_FREQ_GOV_POWERSAVE=
" . #true)
+                                           ("CONFIG_CPU_FREQ_GOV_USERSPACE=
" . #true)
+                                           ("CONFIG_CPU_FREQ_GOV_ONDEMAND"=
 . #true)
+                                           ("CONFIG_CPU_FREQ_GOV_CONSERVAT=
IVE" . #true)
+                                           ("CONFIG_CPU_FREQ_GOV_SCHEDUTIL=
" . #true)
+                                           ("CONFIG_ARM_IMX_CPUFREQ_DT" . =
#true)
+                                           ("CONFIG_ARM_IMX_BUS_DEVFREQ" .=
 #true)
+                                           ("CONFIG_IMX_IRQSTEER" . #true)
+                                           ("CONFIG_PCI_MESON" . #true)
+                                           ("CONFIG_DWMAC_MESON" . #true)
+                                           ("CONFIG_MDIO_BUS_MUX_MESON_G12=
A" . #true)
+                                           ("CONFIG_I2C_MESON" . #true)
+                                           ("CONFIG_PWM_MESON" . #true)
+                                           ("CONFIG_USB_DWC3_MESON_G12A" .=
 #true)
+                                           ("CONFIG_MMC_MESON_GX" . #true)
+                                           ("CONFIG_MMC_MESON_MX_SDIO" . #=
true)
+                                           ("CONFIG_MESON_DDR_PMU" . #true)
+                                           ("CONFIG_RTW88_8822CS" . m)
+                                           ("CONFIG_PWM_FSL_FTM" . #true)
+                                           ("CONFIG_FSL_RCPM" . #true)
+                                           ("CONFIG_ARM_ROCKCHIP_CPUFREQ" =
. m)
+                                           ("CONFIG_DRM_PANTHOR" . m)
+                                           ("CONFIG_NVMEM_ROCKCHIP_OTP" . =
#true)
+                                           ("CONFIG_PHY_ROCKCHIP_SAMSUNG_H=
DPTX" . m)
+                                           ("CONFIG_PHY_ROCKCHIP_USBDP" . =
m)
+                                           ("CONFIG_ROCKCHIP_INNO_HDMI" . =
#true)
+                                           ("CONFIG_ROCKCHIP_LVDS" . #true)
+                                           ("CONFIG_ROCKCHIP_REGULATOR_COU=
PLER" . #true)
+                                           ("CONFIG_SPI_ROCKCHIP" . #true)
+                                           ("CONFIG_SPI_ROCKCHIP_SFC" . m)
+                                           ("CONFIG_ARM_SCMI_CPUFREQ" . m)
+                                           ("CONFIG_PHY_ROCKCHIP_SAMSUNG_D=
CPHY" . m)
+                                           ("CONFIG_VIDEO_ROCKCHIP_VDEC2" =
. m)
+                                           ("CONFIG_ROCKCHIP_DW_HDMI_QP" .=
 #true)
+                                           ("CONFIG_ROCKCHIP_DW_MIPI_DSI" =
. #true)
+                                           ;; Provide support for ath9k wi=
reless
+                                           ("CONFIG_ATH9K" . m)
+                                           ("CONFIG_ATH9K_HTC" . m))
+                                         (default-extra-linux-options
+                                          linux-libre-6.12-version)))))
+    (package
+      (inherit base)
+      (inputs (list reform-debian-packages))
+      (synopsis (string-append (package-synopsis base)
+                               " for MNT/Reform systems"))
+      (description (string-append (package-description base)
+                    "  Configuration options and patches have been applied=
 for use with MNT/Reform systems."))
+      (arguments
+       (substitute-keyword-arguments (package-arguments base)
+         ((#:phases phases)
+          #~(modify-phases #$phases
+              (add-after 'unpack 'apply-reform-patches
+                (lambda* (#:key inputs #:allow-other-keys)
+                  (for-each (lambda (patch)
+                              (invoke "patch" "-p1" "-i"
+                                      (search-input-file inputs
+                                                         (string-append
+                                                          "patches/" patch=
))))
+                            (list
+                             "imx8mp-mnt-pocket-reform/2ghz/0001-imx8mp-2g=
hz-clk.patch"
+                             "imx8mp-mnt-pocket-reform/2ghz/0002-imx8mp-2g=
hz-opp.patch"
+                             "imx8mp-mnt-pocket-reform/audio/0000-revert-c=
rashy-audiomix-pm-support.patch"
+                             "imx8mp-mnt-pocket-reform/mmc-sdio/0001-sdhci=
-add-no-sd-uhs-sdr104-devicetree-property.patch"
+                             "imx8mp-mnt-pocket-reform/mmc-sdio/0002-Durin=
g-the-card-init-the-host-side-sometimes-may-nee.patch"
+                             "imx8mp-mnt-pocket-reform/mmc-sdio/0003-USDHC=
-IP-has-one-limitation-the-tuning-circuit-can-t.patch"
+                             "imx8mp-mnt-pocket-reform/pocket-panel/0001-v=
5-add-multi-display-panel-driver.patch"
+                             "imx8mp-mnt-reform2/0001-sn65dsi86-use-hs-clo=
ck-of-samsung-dsim-host-directly.patch"
+                             "imx8mp-mnt-reform2/0002-lcdif-dont-exceed-de=
sired-pixel-clock.patch"
+                             "imx8mq-mnt-reform2/0001-nwl-dsi-fixup-mode-o=
nly-for-LCDIF-input-not-DCSS.patch"
+                             "imx8mq-mnt-reform2/0002-pci-imx6-add-support=
-for-internal-refclk-imx8mq.patch"
+                             "imx8mq-mnt-reform2/0003-lcdif-fix-pcie-inter=
ference.patch"
+                             "imx8mq-mnt-reform2/0004-mnt4002-imx-gpcv2-wa=
ke-smccc.patch.patch"
+                             ;; Does not apply, needs further investigation
+                             ;; "imx8mq-mnt-reform2/v19_20241126_sandor_yu=
_initial_support_cadence_mhdp8501_hdmi_dp_for_i_mx8mq.mbx"
+                             "ls1028a-mnt-reform2/0000-dtsi-add-hdptx.patc=
h"
+                             "meson-g12b-bananapi-cm4-mnt-pocket-reform/00=
01-a311d-viu-fifo-lines-config.patch"
+                             "meson-g12b-bananapi-cm4-mnt-pocket-reform/00=
02-a311d-viu-fifo-lines-config-header.patch"
+                             "meson-g12b-bananapi-cm4-mnt-pocket-reform/00=
03-tlv320aic31xx-add-1228800hz-support.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0001-Rev=
ert-drm-bridge-synopsys-dw-mipi-dsi-enable-EoTp-b.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0011-dw-=
mipi-dsi-phy-stop-wait-time.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0012-inn=
olux-n125hce-gn1-timing-tweaks.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0013-mes=
on-viu-hold-fifo-lines.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0014-mes=
on-venc-sync.patch.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0015-mes=
on-dw-mipi-dsi-sync-invert.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0016-sn6=
5dsi86-burst-mode-support.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0018-sn6=
5dsi86-never-turn-off.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0020-LOC=
AL-ALSA-Assign-internal-PCM-chmap-ELD-IEC958-kctl.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0021-HAC=
K-of-partial-revert-of-fdt.c-changes.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0022-add=
-bt-and-eth-resets.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0023-sdi=
o-pullups.patch"
+                             "meson-g12b-bananapi-cm4-mnt-reform2/0024-sdi=
o-improve-wifi-speed.patch"
+                             "rk3588-mnt-reform2/0001-regulator-Add-of_reg=
ulator_get_optional-for-pure-DT-.patch"
+                             "rk3588-mnt-reform2/0001-scripts-package-buil=
ddeb-allow-hooks-also-in-usr-sha.patch"
+                             "rk3588-mnt-reform2/0002-regulator-Add-devres=
-version-of-of_regulator_get_opt.patch"
+                             "rk3588-mnt-reform2/0004-arm64-dts-rockchip-r=
k3588-rock5b-add-USB-C-support.patch"
+                             "rk3588-mnt-reform2/0005-math.h-add-DIV_ROUND=
_UP_NO_OVERFLOW.patch"
+                             "rk3588-mnt-reform2/0006-clk-divider-Fix-divi=
sor-masking-on-64-bit-platforms.patch"
+                             "rk3588-mnt-reform2/0007-clk-composite-replac=
e-open-coded-abs_diff.patch"
+                             "rk3588-mnt-reform2/0008-clk-rockchip-support=
-clocks-registered-late.patch"
+                             "rk3588-mnt-reform2/0009-clk-rockchip-rk3588-=
register-GATE_LINK-later.patch"
+                             "rk3588-mnt-reform2/0010-clk-rockchip-expose-=
rockchip_clk_set_lookup.patch"
+                             "rk3588-mnt-reform2/0011-clk-rockchip-impleme=
nt-linked-gate-clock-support.patch"
+                             "rk3588-mnt-reform2/0012-clk-rockchip-rk3588-=
drop-RK3588_LINKED_CLK.patch"
+                             "rk3588-mnt-reform2/0013-arm64-dts-rockchip-r=
k3588-evb1-add-bluetooth-rfkill.patch"
+                             "rk3588-mnt-reform2/0014-arm64-dts-rockchip-r=
k3588-evb1-improve-PCIe-ethernet.patch"
+                             "rk3588-mnt-reform2/0015-arm64-dts-rockchip-S=
low-down-EMMC-a-bit-to-keep-IO-s.patch"
+                             "rk3588-mnt-reform2/0016-vop2-Add-clock-reset=
s-support.patch"
+                             "rk3588-mnt-reform2/0017-arm64-dts-rockchip-A=
dd-VOP-clock-resets-for-rk3588s.patch"
+                             "rk3588-mnt-reform2/0018-dt-bindings-display-=
vop2-Add-VP-clock-resets.patch"
+                             "rk3588-mnt-reform2/0019-media-v4l2-ctrls-cor=
e-Set-frame_mbs_only_flag-by-def.patch"
+                             "rk3588-mnt-reform2/0020-media-rockchip-Move-=
H264-CABAC-table-to-header-file.patch"
+                             "rk3588-mnt-reform2/0021-media-rockchip-Intro=
duce-the-rkvdec2-driver.patch"
+                             "rk3588-mnt-reform2/0022-media-dt-bindings-ro=
ckchip-Document-RK3588-Video-Dec.patch"
+                             "rk3588-mnt-reform2/0023-arm64-dts-rockchip-A=
dd-rkvdec2-Video-Decoder-on-rk35.patch"
+                             "rk3588-mnt-reform2/0024-arm64-defconfig-enab=
le-Rockchip-RK3588-video-decoder.patch"
+                             "rk3588-mnt-reform2/0025-mfd-rk8xx-Fix-shutdo=
wn-handler.patch"
+                             "rk3588-mnt-reform2/0026-WIP-phy-phy-rockchip=
-samsung-hdptx-Add-FRL-EARC-supp.patch"
+                             "rk3588-mnt-reform2/0027-TESTING-phy-phy-rock=
chip-samsung-hdptx-Add-verbose-l.patch"
+                             "rk3588-mnt-reform2/0028-WIP-dt-bindings-disp=
lay-rockchip-drm-Add-optional-cl.patch"
+                             "rk3588-mnt-reform2/0029-WIP-drm-rockchip-vop=
2-Improve-display-modes-handling.patch"
+                             "rk3588-mnt-reform2/0030-arm64-dts-rockchip-A=
dd-HDMI0-bridge-to-rk3588.patch"
+                             "rk3588-mnt-reform2/0031-arm64-dts-rockchip-E=
nable-HDMI0-on-rock-5b.patch"
+                             "rk3588-mnt-reform2/0032-arm64-dts-rockchip-E=
nable-HDMI0-on-rk3588-evb1.patch"
+                             "rk3588-mnt-reform2/0033-WIP-arm64-dts-rockch=
ip-Enable-HDMI0-PHY-clk-provider.patch"
+                             "rk3588-mnt-reform2/0034-WIP-arm64-dts-rockch=
ip-Make-use-of-HDMI0-PHY-PLL-on-.patch"
+                             "rk3588-mnt-reform2/0035-WIP-arm64-dts-rockch=
ip-Make-use-of-HDMI0-PHY-PLL-on-.patch"
+                             "rk3588-mnt-reform2/0036-dt-bindings-display-=
bridge-Add-schema-for-Synopsys-D.patch"
+                             "rk3588-mnt-reform2/0037-dt-bindings-display-=
rockchip-Add-schema-for-RK3588-H.patch"
+                             "rk3588-mnt-reform2/0038-drm-bridge-synopsys-=
Add-DW-HDMI-QP-TX-controller-dri.patch"
+                             "rk3588-mnt-reform2/0039-drm-rockchip-Add-bas=
ic-RK3588-HDMI-output-support.patch"
+                             "rk3588-mnt-reform2/0040-arm64-defconfig-Enab=
le-Rockchip-extensions-for-Synop.patch"
+                             "rk3588-mnt-reform2/0041-MAINTAINERS-Add-entr=
y-for-Synopsys-DesignWare-HDMI-R.patch"
+                             "rk3588-mnt-reform2/0042-dt-bindings-media-Do=
cument-bindings-for-HDMI-RX-Cont.patch"
+                             "rk3588-mnt-reform2/0043-arm64-dts-rockchip-A=
dd-device-tree-support-for-HDMI-.patch"
+                             "rk3588-mnt-reform2/0044-media-platform-synop=
sys-Add-support-for-HDMI-input-d.patch"
+                             "rk3588-mnt-reform2/0045-arm64-defconfig-Enab=
le-Synopsys-HDMI-receiver.patch"
+                             "rk3588-mnt-reform2/0046-arm64-dts-rockchip-E=
nable-HDMI-receiver-on-rock-5b.patch"
+                             "rk3588-mnt-reform2/0047-arm64-dts-rockchip-E=
nable-HDMI-receiver-on-RK3588-EV.patch"
+                             "rk3588-mnt-reform2/0048-arm64-defconfig-Enab=
le-default-EDID-for-Synopsys-HDM.patch"
+                             "rk3588-mnt-reform2/0049-regulator-Add-devm_-=
of_regulator_get.patch"
+                             "rk3588-mnt-reform2/0050-pmdomain-rockchip-cl=
eanup-mutex-handling-in-rockchip.patch"
+                             "rk3588-mnt-reform2/0051-pmdomain-rockchip-fo=
rward-rockchip_do_pmu_set_power_.patch"
+                             "rk3588-mnt-reform2/0052-pmdomain-rockchip-re=
duce-indentation-in-rockchip_pd_.patch"
+                             "rk3588-mnt-reform2/0053-dt-bindings-power-ro=
ckchip-add-regulator-support.patch"
+                             "rk3588-mnt-reform2/0054-pmdomain-rockchip-ad=
d-regulator-support.patch"
+                             "rk3588-mnt-reform2/0055-arm64-dts-rockchip-A=
dd-GPU-power-domain-regulator-de.patch"
+                             "rk3588-mnt-reform2/0056-dt-bindings-net-wire=
less-brcm4329-fmac-add-pci14e4-4.patch"
+                             "rk3588-mnt-reform2/0057-dt-bindings-net-wire=
less-brcm4329-fmac-add-clock-des.patch"
+                             "rk3588-mnt-reform2/0058-wifi-brcmfmac-Add-op=
tional-lpo-clock-enable-support.patch"
+                             ;; does not apply cleanly due to DEBLOBBING
+                             ;; "rk3588-mnt-reform2/0059-wifi-brcmfmac-add=
-flag-for-random-seed-during-firmwa.patch"
+                             "rk3588-mnt-reform2/0060-arm64-dts-rockchip-r=
k3588-evb1-add-WLAN-controller.patch"
+                             "rk3588-mnt-reform2/0061-arm64-dts-rockchip-a=
dd-and-enable-gpu-node-for-Radxa.patch"
+                             "rk3588-mnt-reform2/0062-arm64-dts-rockchip-E=
nable-HDMI0-on-rock-5a.patch"
+                             "rk3588-mnt-reform2/0100-rk3588-dtsi-add-hdmi=
1-controller.patch"
+                             "rk3588-mnt-reform2/0102-drm-panthor-Actually=
-suspend-IRQs-in-the-unplug-path.patch"
+                             "rk3588-mnt-reform2/3001-display-rockchip-add=
-schema-for-rk3588-hdmi-tx.patch"
+                             "rk3588-mnt-reform2/4000-mnt-rk3588-dual-hdmi=
-qp-rockchip.patch"
+                             "rk3588-mnt-reform2/4001-mnt-rk3588-dual-hdmi=
-vop2-pll.patch"
+                             "rk3588-mnt-reform2/5001-rk3588-dsi2-driver.p=
atch"
+                             "rk3588-mnt-reform2/5002-rk3588-dsi-dts-nodes=
.patch"
+                             "rk3588-mnt-reform2/5100-modernize-hdmi1-in-d=
tsi.patch"
+                             "rk3588-mnt-reform2/5110-hdptx-crash-workarou=
nd.patch"
+                             "rk3588-mnt-reform2/5200-drm-rockchip-Set-dma=
-mask-to-64-bit.patch"))))
+              (add-after 'apply-reform-patches 'copy-reform-dts-files
+                (lambda* (#:key inputs #:allow-other-keys)
+                  (for-each (lambda (dts)
+                              (copy-file (search-input-file inputs
+                                                            (string-append
+                                                             "/dts/" dts))
+                                         (string-append "arch/arm64/boot/d=
ts/"
+                                          dts)))
+                            (list
+                             "amlogic/meson-g12b-bananapi-cm4-mnt-pocket-r=
eform.dts"
+                             "amlogic/meson-g12b-bananapi-cm4-mnt-reform2.=
dts"
+                             "freescale/fsl-ls1028a-mnt-reform2.dts"
+                             "freescale/imx8mp-mnt-pocket-reform.dts"
+                             "freescale/imx8mp-mnt-reform2.dts"
+                             "freescale/imx8mq-mnt-reform2-hdmi.dts"
+                             "freescale/imx8mq-mnt-reform2.dts"
+                             "rockchip/rk3588-mnt-pocket-reform.dts"
+                             "rockchip/rk3588-mnt-reform-next.dts"
+                             "rockchip/rk3588-mnt-reform2.dts"))))
+              (add-after 'apply-reform-patches 'adjust-makefiles-with-new-=
dtb
+                (lambda _
+                  (substitute* "arch/arm64/boot/dts/amlogic/Makefile"
+                    (("meson-g12b-bananapi-cm4-mnt-reform2.dtb")
+                     "meson-g12b-bananapi-cm4-mnt-reform2.dtb
+dtb-$(CONFIG_ARCH_MESON) +=3D meson-g12b-bananapi-cm4-mnt-pocket-reform.dt=
b"))
+                  (substitute* "arch/arm64/boot/dts/freescale/Makefile"
+                    (("fsl-ls1028a-rdb.dtb")
+                     "fsl-ls1028a-rdb.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) +=3D fsl-ls1028a-mnt-reform2.dtb"))
+                  (substitute* "arch/arm64/boot/dts/freescale/Makefile"
+                    (("imx8mq-mnt-reform2.dtb")
+                     "imx8mq-mnt-reform2.dtb
+dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-mnt-reform2.dtb
+dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-mnt-pocket-reform.dtb
+dtb-$(CONFIG_ARCH_MXC) +=3D imx8mq-mnt-reform2-hdmi.dtb"))
+                  (substitute* "arch/arm64/boot/dts/rockchip/Makefile"
+                    (("rk3588-rock-5b.dtb")
+                     "rk3588-rock-5b.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588-mnt-reform2.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588-mnt-reform-next.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588-mnt-pocket-reform.dtb")))))))))))
+
 (define-public linux-libre-riscv64-generic
   (make-linux-libre* linux-libre-version
                      linux-libre-gnu-revision

base-commit: 66c44dd6e49b581f33eb98fe764ce75945a0638b
=2D-=20
2.39.5


--=-=-=--

--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZ99I4wAKCRDcUY/If5cW
qgGJAQC8IdquZQccSJnLsy0JZdYsypirwx5KZPoj7MlJxHLU9gD8D2xRD5WPaCgD
jgWR+2ayOM3Iwl9j4sTuTXfAbNDbgAc=
=wn13
-----END PGP SIGNATURE-----
--==-=-=--




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#77090] Patch to add linux-libre mnt/reform variant
Resent-From: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 23 Mar 2025 16:02:03 +0000
Resent-Message-ID: <handler.77090.B77090.174274572013775 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77090
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: Vagrant Cascadian <vagrant@HIDDEN>
Cc: w@HIDDEN, 77090 <at> debbugs.gnu.org, leo@HIDDEN
Received: via spool by 77090-submit <at> debbugs.gnu.org id=B77090.174274572013775
          (code B ref 77090); Sun, 23 Mar 2025 16:02:03 +0000
Received: (at 77090) by debbugs.gnu.org; 23 Mar 2025 16:02:00 +0000
Received: from localhost ([127.0.0.1]:52172 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1twNlt-0003Zh-Jg
	for submit <at> debbugs.gnu.org; Sun, 23 Mar 2025 12:02:00 -0400
Received: from relay.yourmailgateway.de ([188.68.61.103]:52497)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <pelzflorian@HIDDEN>)
 id 1twNlo-0003YV-8r
 for 77090 <at> debbugs.gnu.org; Sun, 23 Mar 2025 12:01:54 -0400
Received: from mors-relay-8403.netcup.net (localhost [127.0.0.1])
 by mors-relay-8403.netcup.net (Postfix) with ESMTPS id 4ZLLXZ2zCMz83kC;
 Sun, 23 Mar 2025 17:01:50 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pelzflorian.de;
 s=key2; t=1742745710;
 bh=kda7G4M+boptCwdnD23xQOgMPw6UBKscos1BmXPoWLc=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=FBFv1WzFrke7jVSqa/geOYVnmlV5hsdh35Jx54V/6h2yB/5Jv2mNslrQ7ZvS6fWeT
 m/8NzXavt1dWQDzS16hJfM8Nm8+SNyLbfBOtuE1qxoer5CYELKBaKjzWavFVj9W5jn
 Mo/e0MIzMBDoJSzKJyOT+SNlKUiUteVprVfsPXEJotgBF7egOXZD0Rs7ECBmW9ArTz
 yCdlnDwf6DfnZsbt1hK3Grt+reABTcWpnE+qmvNMzkepCK4a2P2W4QftC6dOFYIlkK
 sLIeCAKYI68vWZF2qIjpcTnIcwO0N4PF5xULlthTClcl9c9Ml7HC3k1MHBwjHeoqhD
 vyd2a8VhwhO7w==
Received: from policy02-mors.netcup.net (unknown [46.38.225.35])
 by mors-relay-8403.netcup.net (Postfix) with ESMTPS id 4ZLLXZ2cGfz83LF;
 Sun, 23 Mar 2025 17:01:50 +0100 (CET)
Received: from mxe217.netcup.net (unknown [10.243.12.53])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by policy02-mors.netcup.net (Postfix) with ESMTPS id 4ZLLXY3w0Jz8sZj;
 Sun, 23 Mar 2025 17:01:49 +0100 (CET)
Received: from florianhp (ipb21a5dbf.dynamic.kabel-deutschland.de
 [178.26.93.191])
 by mxe217.netcup.net (Postfix) with ESMTPSA id E971084B62;
 Sun, 23 Mar 2025 17:01:41 +0100 (CET)
From: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
In-Reply-To: <878qowk5cs.fsf@wireframe> (Vagrant Cascadian's message of "Sat, 
 22 Mar 2025 16:33:55 -0700")
References: <874izrm8vc.fsf@wireframe> <87msdhjnlv.fsf@HIDDEN>
 <87y0x0kb3y.fsf@wireframe> <87sen5x7v2.fsf@HIDDEN>
 <87ecyoki3s.fsf@wireframe> <878qowk5cs.fsf@wireframe>
Date: Sun, 23 Mar 2025 17:02:13 +0100
Message-ID: <87zfhbu456.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Rspamd-Server: rspamd-worker-8404
X-Rspamd-Queue-Id: E971084B62
X-NC-CID: p7Gv6dXbaE1HpgvOwcWNujAyyDzKAR4ZtlnCqWyLp/v89kSH+4YNUE9c
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Vagrant Cascadian <vagrant@HIDDEN> writes:
> Working on submitting the issue upstream...

Thank you; if you include this license header you made upstream include
(commit
<https://source.mnt.re/reform/reform-debian-packages/-/commit/af0a461d38e13481323f061d9ff6827d1d13873b>),
it LGTM.  Please push.  Although I cannot judge your style of
customizing linux-libre and configuration, but style could be altered
later.

I also have not tested the new v3 kernel, because I have no MNT Reform
and its devicetree, kernel features do nothing for my Orange Pi anyway.
Though its patches might serve as inspiration for fixing devicetree.

Further:

> +              (license:fsf-free "file://filter-output" "# SPDX-License-Identifier: FSFAP
> +# Copying and distribution of this file, with or without modification, are
> +# permitted in any medium without royalty provided the copyright notice and
> +# this notice are preserved. This file is offered as-is, without any warranty.")

When I git grep for license:fsf-free, others do not include the license
in a comment.  But I do not know more.

> +              license:bsd-2

Good!

Regards,
Florian




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#77090] Patch to add linux-libre mnt/reform variant
Resent-From: Vagrant Cascadian <vagrant@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 23 Mar 2025 16:49:02 +0000
Resent-Message-ID: <handler.77090.B77090.174274852731985 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77090
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: "pelzflorian (Florian Pelz)" <pelzflorian@HIDDEN>
Cc: w@HIDDEN, 77090 <at> debbugs.gnu.org, leo@HIDDEN
Received: via spool by 77090-submit <at> debbugs.gnu.org id=B77090.174274852731985
          (code B ref 77090); Sun, 23 Mar 2025 16:49:02 +0000
Received: (at 77090) by debbugs.gnu.org; 23 Mar 2025 16:48:47 +0000
Received: from localhost ([127.0.0.1]:52254 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1twOVD-0008Jo-AY
	for submit <at> debbugs.gnu.org; Sun, 23 Mar 2025 12:48:47 -0400
Received: from cascadia.aikidev.net ([173.255.214.101]:32784)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <vagrant@HIDDEN>)
 id 1twOV8-0008Ik-JG
 for 77090 <at> debbugs.gnu.org; Sun, 23 Mar 2025 12:48:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org;
 s=1.vagrant.user; t=1742748513;
 bh=Z0ug3jYIJREHGpRHKaGV4JeAXFwFSe1on1/4u5i8rAc=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=DYuzeeoRb3qkdj8lyDMfgrfh5Sbu0CbJCgQ2dKlFNsxORuKf56knaZPwMQ1ufsJne
 fKUseim13wWVLsG2szO8WxKNCQX1hFk9KNBdvHiuOzQHfeiRFL3BN3NSjoBzxSQD9F
 HuegW7eIfSlSZBdWKUXxK3/OsPor/gzqiQ43bvqgDsxFz1QwB+DV3y7688WWyo401x
 bupaHNmy3chUfYwCDFE+26SOfvaEL+ncWANy7ZfnLzguOzpOZ5omOLaVLScpNGW+/Y
 2pXeURoZjD8G6pK9gIh6NLf+bjSX6kZDa8sSDJxigbij+Jpi4FTyJoFgaMCYjxWUdU
 qaN/+Y23RzXJA==
Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50])
 by cascadia.aikidev.net (Postfix) with ESMTPSA id 873764888;
 Sun, 23 Mar 2025 09:48:33 -0700 (PDT)
From: Vagrant Cascadian <vagrant@HIDDEN>
In-Reply-To: <87zfhbu456.fsf@HIDDEN>
References: <874izrm8vc.fsf@wireframe> <87msdhjnlv.fsf@HIDDEN>
 <87y0x0kb3y.fsf@wireframe> <87sen5x7v2.fsf@HIDDEN>
 <87ecyoki3s.fsf@wireframe> <878qowk5cs.fsf@wireframe>
 <87zfhbu456.fsf@HIDDEN>
Date: Sun, 23 Mar 2025 09:48:27 -0700
Message-ID: <871punk810.fsf@wireframe>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain

On 2025-03-23, pelzflorian (Florian Pelz) wrote:
> Vagrant Cascadian <vagrant@HIDDEN> writes:
>> Working on submitting the issue upstream...
>
> Thank you; if you include this license header you made upstream include
> (commit
> <https://source.mnt.re/reform/reform-debian-packages/-/commit/af0a461d38e13481323f061d9ff6827d1d13873b>),
> it LGTM.  Please push.

Will in the new upstream version that includes the licensing
clarification, for, well... clarity!

If I understood correctly, you suggested to have
SPDX-License-Identifier: MIT be be represented as license:x11, so that
should already be present in the license field.


> Although I cannot judge your style of
> customizing linux-libre and configuration, but style could be altered
> later.

Fair!


> I also have not tested the new v3 kernel, because I have no MNT Reform
> and its devicetree, kernel features do nothing for my Orange Pi anyway.
> Though its patches might serve as inspiration for fixing devicetree.

Understood! I have tested it on at least the MNT/Reform rk3588, and this
should make it easier for others to attempt on other MNT/Reform
platforms, which it is always easier to provide small patches than test
the whole thing.


> Further:
>
>> +              (license:fsf-free "file://filter-output" "# SPDX-License-Identifier: FSFAP
>> +# Copying and distribution of this file, with or without modification, are
>> +# permitted in any medium without royalty provided the copyright notice and
>> +# this notice are preserved. This file is offered as-is, without any warranty.")
>
> When I git grep for license:fsf-free, others do not include the license
> in a comment.  But I do not know more.

I included the reasonably short "full" text in the comment just to be
clear. It looks like this license comes from gnu.org:

  https://www.gnu.org/prep/maintain/html_node/License-Notices-for-Other-Files.html

And is documented at spdx.org as the "FSF All Permissive License":

  https://spdx.org/licenses/FSFAP.html

Maybe including a link to the gnu.org URL (and/or spdx.org) in the
comment would still be very clear, without triggering the overly long
comment feeling. :)

I think I will include the gnu.org link. We can always improve upon it
later if needed.

Seems like file://filter-output needs to stay, as that includes the
reference to the actual source where the license is declared.


live well,
  vagrant

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZ+A7WwAKCRDcUY/If5cW
qtV+AQCXOA+l6EA5RjCF+XArMKDRGPi/cBvDa7LSITCsvtwG4QD+K2eyovpwu6zb
eGgCSRb2mekpUrqCjlJMBuXgHbEqGAA=
=wQCN
-----END PGP SIGNATURE-----
--=-=-=--





Last modified: Sun, 23 Mar 2025 17:00:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.