GNU bug report logs - #77095
31.0.50; Using fill-region doesn't produce commented lines in yaml-ts-mode

Previous Next

To reply to this bug, email your comments to 77095 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: the_wurfkreuz <the_wurfkreuz <at> proton.me>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 31.0.50;
 Using fill-region doesn't produce commented lines in yaml-ts-mode
Date: Tue, 18 Mar 2025 09:11:54 +0000

[Message part 1 (text/plain, inline)]

It's the same issue as in this bug report #75978, but for yaml-ts-mode. Do i need to provide reproduction steps still?

[Message part 2 (text/html, inline)]

Message #8 received at 77095 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: the_wurfkreuz <the_wurfkreuz <at> proton.me>
Cc: 77095 <at> debbugs.gnu.org
Subject: Re: bug#77095: 31.0.50;
 Using fill-region doesn't produce commented lines in yaml-ts-mode
Date: Tue, 18 Mar 2025 17:30:54 +0000

On Tuesday, March 18th, 2025 at 05:11, the_wurfkreuz via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org> wrote:
> It's the same issue as in this bug report #75978, but for yaml-ts-mode. Do i need to provide reproduction steps still?

Thanks for the report.

If it's the exact same steps (using yaml-ts-mode instead, obviously),
then no need.

I'll try to take a look at this hopefully sometime this week.

Message #11 received at 77095 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: the_wurfkreuz <the_wurfkreuz <at> proton.me>
Cc: 77095 <at> debbugs.gnu.org
Subject: Re: bug#77095: 31.0.50;
 Using fill-region doesn't produce commented lines in yaml-ts-mode
Date: Sat, 22 Mar 2025 20:44:49 +0000

On Tuesday, March 18th, 2025 at 05:11, the_wurfkreuz via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org> wrote:

> It's the same issue as in this bug report #75978, but for yaml-ts-mode. Do i need to provide reproduction steps still?

I followed the instructions listed in #75978 and it works for me as
expected.

I tried on master (commit 2658f4eab96aaad7f52245c2422bbfa51db9b207).

If you see otherwise, please post specific reproduction steps.

Message #14 received at 77095 <at> debbugs.gnu.org (full text, mbox):

From: the_wurfkreuz <the_wurfkreuz <at> proton.me>
To: Randy Taylor <dev <at> rjt.dev>
Cc: 77095 <at> debbugs.gnu.org
Subject: Re: bug#77095: 31.0.50;
 Using fill-region doesn't produce commented lines in yaml-ts-mode
Date: Sun, 23 Mar 2025 05:52:18 +0000

I cleared the scratch buffer and pasted this yaml:

```
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  # some comment aosiertn oairsetn oarisetn oarisetn oarisent oarisetn oa risetn oairsetn
  name: hostpath-pvc-reboot-test
spec:
  accessModes:
    - ReadWriteOnce
  storageClassName: manual-reboot-test
  resources:
    requests:
      storage: 500Mi
```

Then i enabled yaml-ts-mode.
I went to the commented line and did `back-to-indentation`, then `set-mark-command` followed by `move-end-of-line` and `fill-region`.
And this is the result i got:

```
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  # some comment aosiertn oairsetn oarisetn oarisetn oarisent oarisetn
    oa risetn oairsetn
  name: hostpath-pvc-reboot-test
spec:
  accessModes:
    - ReadWriteOnce
  storageClassName: manual-reboot-test
  resources:
    requests:
      storage: 500Mi
```

I expect it to be like this:

```
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  # some comment aosiertn oairsetn oarisetn oarisetn oarisent oarisetn
  # oa risetn oairsetn
  name: hostpath-pvc-reboot-test
spec:
  accessModes:
    - ReadWriteOnce
  storageClassName: manual-reboot-test
  resources:
    requests:
      storage: 500Mi
```

I use emacs from the master branch.


On Saturday, March 22nd, 2025 at 8:44 PM, Randy Taylor <dev <at> rjt.dev> wrote:

> On Tuesday, March 18th, 2025 at 05:11, the_wurfkreuz via "Bug reports for GNU Emacs, the Swiss army knife of text editors" bug-gnu-emacs <at> gnu.org wrote:
> 
> > It's the same issue as in this bug report #75978, but for yaml-ts-mode. Do i need to provide reproduction steps still?
> 
> 
> I followed the instructions listed in #75978 and it works for me as
> expected.
> 
> I tried on master (commit 2658f4eab96aaad7f52245c2422bbfa51db9b207).
> 
> If you see otherwise, please post specific reproduction steps.

Message #17 received at 77095 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: the_wurfkreuz <the_wurfkreuz <at> proton.me>
Cc: dev <at> rjt.dev, 77095 <at> debbugs.gnu.org
Subject: Re: bug#77095: 31.0.50;
 Using fill-region doesn't produce commented lines in yaml-ts-mode
Date: Thu, 03 Apr 2025 10:22:00 +0300

Ping! Randy, any suggestions?

> Cc: 77095 <at> debbugs.gnu.org
> Date: Sun, 23 Mar 2025 05:52:18 +0000
> From:  the_wurfkreuz via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> I cleared the scratch buffer and pasted this yaml:
> 
> ```
> apiVersion: v1
> kind: PersistentVolumeClaim
> metadata:
>   # some comment aosiertn oairsetn oarisetn oarisetn oarisent oarisetn oa risetn oairsetn
>   name: hostpath-pvc-reboot-test
> spec:
>   accessModes:
>     - ReadWriteOnce
>   storageClassName: manual-reboot-test
>   resources:
>     requests:
>       storage: 500Mi
> ```
> 
> Then i enabled yaml-ts-mode.
> I went to the commented line and did `back-to-indentation`, then `set-mark-command` followed by `move-end-of-line` and `fill-region`.
> And this is the result i got:
> 
> ```
> apiVersion: v1
> kind: PersistentVolumeClaim
> metadata:
>   # some comment aosiertn oairsetn oarisetn oarisetn oarisent oarisetn
>     oa risetn oairsetn
>   name: hostpath-pvc-reboot-test
> spec:
>   accessModes:
>     - ReadWriteOnce
>   storageClassName: manual-reboot-test
>   resources:
>     requests:
>       storage: 500Mi
> ```
> 
> I expect it to be like this:
> 
> ```
> apiVersion: v1
> kind: PersistentVolumeClaim
> metadata:
>   # some comment aosiertn oairsetn oarisetn oarisetn oarisent oarisetn
>   # oa risetn oairsetn
>   name: hostpath-pvc-reboot-test
> spec:
>   accessModes:
>     - ReadWriteOnce
>   storageClassName: manual-reboot-test
>   resources:
>     requests:
>       storage: 500Mi
> ```
> 
> I use emacs from the master branch.
> 
> 
> On Saturday, March 22nd, 2025 at 8:44 PM, Randy Taylor <dev <at> rjt.dev> wrote:
> 
> > On Tuesday, March 18th, 2025 at 05:11, the_wurfkreuz via "Bug reports for GNU Emacs, the Swiss army knife of text editors" bug-gnu-emacs <at> gnu.org wrote:
> > 
> > > It's the same issue as in this bug report #75978, but for yaml-ts-mode. Do i need to provide reproduction steps still?
> > 
> > 
> > I followed the instructions listed in #75978 and it works for me as
> > expected.
> > 
> > I tried on master (commit 2658f4eab96aaad7f52245c2422bbfa51db9b207).
> > 
> > If you see otherwise, please post specific reproduction steps.
> 
> 
> 
> 

Message #20 received at 77095 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: the_wurfkreuz <the_wurfkreuz <at> proton.me>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 77095 <at> debbugs.gnu.org
Subject: Re: bug#77095: 31.0.50;
 Using fill-region doesn't produce commented lines in yaml-ts-mode
Date: Sat, 05 Apr 2025 20:21:05 +0000

[Message part 1 (text/plain, inline)]

On Sunday, March 23rd, 2025 at 01:52, the_wurfkreuz <the_wurfkreuz <at> proton.me> wrote:
> 
> 
> I cleared the scratch buffer and pasted this yaml:
> 
> `apiVersion: v1 kind: PersistentVolumeClaim metadata: # some comment aosiertn oairsetn oarisetn oarisetn oarisent oarisetn oa risetn oairsetn name: hostpath-pvc-reboot-test spec: accessModes: - ReadWriteOnce storageClassName: manual-reboot-test resources: requests: storage: 500Mi`
> 
> Then i enabled yaml-ts-mode.
> I went to the commented line and did `back-to-indentation`, then `set-mark-command` followed by `move-end-of-line` and `fill-region`.
> And this is the result i got:
> 
> `apiVersion: v1 kind: PersistentVolumeClaim metadata: # some comment aosiertn oairsetn oarisetn oarisetn oarisent oarisetn oa risetn oairsetn name: hostpath-pvc-reboot-test spec: accessModes: - ReadWriteOnce storageClassName: manual-reboot-test resources: requests: storage: 500Mi`
> 
> I expect it to be like this:
> 
> `apiVersion: v1 kind: PersistentVolumeClaim metadata: # some comment aosiertn oairsetn oarisetn oarisetn oarisent oarisetn # oa risetn oairsetn name: hostpath-pvc-reboot-test spec: accessModes: - ReadWriteOnce storageClassName: manual-reboot-test resources: requests: storage: 500Mi`
> 
> I use emacs from the master branch.
> 

Thanks, and sorry for the delay.

I've attached a patch that fixes it for me.

[0001-Fix-yaml-ts-mode-comment-filling-Bug-77095.patch (text/x-patch, attachment)]

Message #23 received at 77095 <at> debbugs.gnu.org (full text, mbox):

From: the_wurfkreuz <the_wurfkreuz <at> proton.me>
To: Randy Taylor <dev <at> rjt.dev>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 77095 <at> debbugs.gnu.org
Subject: Re: bug#77095: 31.0.50;
 Using fill-region doesn't produce commented lines in yaml-ts-mode
Date: Thu, 10 Apr 2025 07:16:09 +0000

I applied the patch and recompiled emacs. I don't see any changes.

Message #26 received at 77095 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: the_wurfkreuz <the_wurfkreuz <at> proton.me>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 77095 <at> debbugs.gnu.org
Subject: Re: bug#77095: 31.0.50;
 Using fill-region doesn't produce commented lines in yaml-ts-mode
Date: Sat, 12 Apr 2025 20:04:50 +0000

[Message part 1 (text/plain, inline)]

On Thursday, April 10th, 2025 at 03:16, the_wurfkreuz <the_wurfkreuz <at> proton.me> wrote:
> 
> 
> I applied the patch and recompiled emacs. I don't see any changes.

Sorry, I must've turned another mode on or something by mistake. The
previous patch fixed the problem for fill-paragraph, and something
like electric-pair-mode being on fixes it for fill-region, too.

Anyway, I've attached an updated patch that should fix it for fill-region.

[0001-Fix-yaml-ts-mode-comment-filling-Bug-77095.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.