GNU logs - #77096, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77096: 31.0.50; Theme names disappear in customize-themes
Resent-From: Mauro Aranda <maurooaranda@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 18 Mar 2025 09:54:05 +0000
Resent-Message-ID: <handler.77096.B.17422916098091 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77096 <at> debbugs.gnu.org
Message-ID: <82c988b6-5da9-4e80-8bc1-d8a16956a9f0@HIDDEN>
Date: Tue, 18 Mar 2025 06:53:01 -0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
From: Mauro Aranda <maurooaranda@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::62b;
 envelope-from=maurooaranda@HIDDEN; helo=mail-pl1-x62b.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

After emacs -Q:
M-x customize-themes
Select any theme, with the keyboard or with the mouse.
The theme gets activated, but all theme names disappear.


In GNU Emacs 31.0.50 (build 69, x86_64-pc-linux-gnu, GTK+ Version
  3.24.33, cairo version 1.16.0) of 2025-03-18 built on tbb-desktop
Repository revision: 739d18dc41234824f4f01bfaa2313510e2df14a7
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12201001
System Description: Ubuntu 22.04.5 LTS

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINERAMA XINPUT2 XPM XRANDR
GTK3 ZLIB

Important settings:
   value of $LC_MONETARY: es_AR.UTF-8
   value of $LC_NUMERIC: es_AR.UTF-8
   value of $LC_TIME: es_AR.UTF-8
   value of $LANG: en_US.UTF-8
   value of $XMODIFIERS: @im=ibus
   locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
   tooltip-mode: t
   global-eldoc-mode: t
   eldoc-mode: t
   show-paren-mode: t
   electric-indent-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   minibuffer-regexp-mode: t
   line-number-mode: t
   indent-tabs-mode: t
   transient-mark-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug lisp-mnt message mailcap yank-media puny
dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg
rfc6068 epg-config gnus-util text-property-search time-date subr-x
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset
image regexp-opt fringe tabulated-list replace newcomment text-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo gtk
x-toolkit xinput2 x multi-tty move-toolbar make-network-process
tty-child-frames emacs)

Memory information:
((conses 16 39573 10979) (symbols 48 5473 0) (strings 32 12934 2380)
  (string-bytes 1 311205) (vectors 16 9551)
  (vector-slots 8 113960 5194) (floats 8 21 3) (intervals 56 236 0)
  (buffers 992 10))

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Mauro Aranda <maurooaranda@HIDDEN>
Subject: bug#77096: Acknowledgement (31.0.50; Theme names disappear in
 customize-themes)
Message-ID: <handler.77096.B.17422916098091.ack <at> debbugs.gnu.org>
References: <82c988b6-5da9-4e80-8bc1-d8a16956a9f0@HIDDEN>
X-Gnu-PR-Message: ack 77096
X-Gnu-PR-Package: emacs
Reply-To: 77096 <at> debbugs.gnu.org
Date: Tue, 18 Mar 2025 09:54:07 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 77096 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
77096: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77096
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77096: 31.0.50; Theme names disappear in customize-themes
Resent-From: Mauro Aranda <maurooaranda@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 18 Mar 2025 10:07:02 +0000
Resent-Message-ID: <handler.77096.B77096.174229239316572 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77096 <at> debbugs.gnu.org
Content-Type: multipart/mixed; boundary="------------ZE5RtZ0IymbHHl06CiH1QBuO"
Message-ID: <4d0a2b18-07d2-468d-8bcb-6fd77347accb@HIDDEN>
Date: Tue, 18 Mar 2025 07:06:18 -0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Mauro Aranda <maurooaranda@HIDDEN>
References: <82c988b6-5da9-4e80-8bc1-d8a16956a9f0@HIDDEN>
Content-Language: en-US
In-Reply-To: <82c988b6-5da9-4e80-8bc1-d8a16956a9f0@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

This is a multi-part message in MIME format.
--------------ZE5RtZ0IymbHHl06CiH1QBuO
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

This is a result of my changes in:

commit 85113fcda97970bc2468f409278e27d6570fc76f
Author: Mauro Aranda <maurooaranda@HIDDEN>
Date:   Fri Jan 17 17:12:08 2025 -0300

     Prepare markers for insertions inside of a widget

     Recreating child widgets without recreating the parent widget
     may lead to situations where the parent widget doesn't cover its
     children or buttons entirely anymore.  This bug manifests as a
     faulty fontification of children or buttons, for example.
     (Bug#69941)

     * lisp/wid-edit.el (widget--prepare-markers-for-inside-insertion)
     (widget--prepare-markers-for-outside-insertion): New functions.
     (widget-default-create): Use them.

     * test/lisp/wid-edit-tests.el (widget-test-insertion-at-parent-markers)
     (widget-test-insertion-at-parent-markers-2): New tests.


But I don't think there's a bug in the wid-edit.el code, rather it's in
customize-themes.  The layout for a line with a theme is like this:
CHECKBOX BUTTON -- THEME-DESCRIPTION

BUTTON has the theme name as a label, and it disappears after toggling
the checkbox.  The code creates BUTTON as a child of CHECKBOX, so the
code is asking for BUTTON to be contained inside CHECKBOX.  It didn't
happen before because of Bug#69941, but I think that what happens now is
what should happen.  Now, when the checkbox gets recreated, it deletes
its child and never creates it back (the cus-theme.el code should be
responsible of telling it to create it back in that case).

But I don't think BUTTON should be a child of CHECKBOX.  In fact, the
usual thing to do with the Widget library is to make it a sibling.  So I
propose the attached patch.



--------------ZE5RtZ0IymbHHl06CiH1QBuO
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Fix-widget-relationship-in-customize-themes.patch"
Content-Disposition: attachment;
 filename="0001-Fix-widget-relationship-in-customize-themes.patch"
Content-Transfer-Encoding: base64

RnJvbSBhNjZlNWRkNDlhZDk4ODQ2MjY1MTZiNGQ0ZDUxYmM3MmFkMTMyOTQ5IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp
bC5jb20+CkRhdGU6IFR1ZSwgMTggTWFyIDIwMjUgMDc6MDQ6MjIgLTAzMDAKU3ViamVjdDog
W1BBVENIXSBGaXggd2lkZ2V0IHJlbGF0aW9uc2hpcCBpbiBjdXN0b21pemUtdGhlbWVzCgoq
IGxpc3AvY3VzLXRoZW1lLmVsIChjdXN0b21pemUtdGhlbWVzKTogVGhlIHRoZW1lIGJ1dHRv
biBzaG91bGQKYmUgYSBzaWJsaW5nIG9mIHRoZSBjaGVja2JveCB3aWRnZXQsIG5vdCBhIGNo
aWxkLiAgKEJ1ZyM3NzA5NikKLS0tCiBsaXNwL2N1cy10aGVtZS5lbCB8IDEzICsrKysrKyst
LS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0p
CgpkaWZmIC0tZ2l0IGEvbGlzcC9jdXMtdGhlbWUuZWwgYi9saXNwL2N1cy10aGVtZS5lbApp
bmRleCA0NDEyNzBmZjYzYy4uNDFiY2M2NzgzMjIgMTAwNjQ0Ci0tLSBhL2xpc3AvY3VzLXRo
ZW1lLmVsCisrKyBiL2xpc3AvY3VzLXRoZW1lLmVsCkBAIC02NTQsMTIgKzY1NCwxMyBAQCBj
dXN0b21pemUtdGhlbWVzCiAJCQkJICAgIDpoZWxwLWVjaG8gaGVscC1lY2hvCiAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6YWN0aW9uICMnY3VzdG9tLXRoZW1lLWNo
ZWNrYm94LXRvZ2dsZSkpCiAgICAgICAgIChwdXNoIChjb25zIHRoZW1lIHdpZGdldCkgY3Vz
dG9tLS1saXN0ZWQtdGhlbWVzKQotICAgICAgICAod2lkZ2V0LWNyZWF0ZS1jaGlsZC1hbmQt
Y29udmVydCB3aWRnZXQgJ3B1c2gtYnV0dG9uCi0JCQkJICAgICAgICAgOmJ1dHRvbi1mYWNl
LWdldCAnaWdub3JlCi0JCQkJICAgICAgICAgOm1vdXNlLWZhY2UtZ2V0ICdpZ25vcmUKLQkJ
CQkgICAgICAgICA6dmFsdWUgKGZvcm1hdCAiICVzIiB0aGVtZSkKLSAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgOmFjdGlvbiAjJ3dpZGdldC1wYXJlbnQtYWN0
aW9uCi0JCQkJICAgICAgICAgOmhlbHAtZWNobyBoZWxwLWVjaG8pCisgICAgICAgICh3aWRn
ZXQtY3JlYXRlICdwdXNoLWJ1dHRvbgorICAgICAgICAgICAgICAgICAgICAgICA6YnV0dG9u
LWZhY2UtZ2V0ICdpZ25vcmUKKyAgICAgICAgICAgICAgICAgICAgICAgOm1vdXNlLWZhY2Ut
Z2V0ICdpZ25vcmUKKyAgICAgICAgICAgICAgICAgICAgICAgOnZhbHVlIChmb3JtYXQgIiAl
cyIgdGhlbWUpCisgICAgICAgICAgICAgICAgICAgICAgIDphY3Rpb24gKGxhbWJkYSAoX3cg
Jm9wdGlvbmFsIGV2ZW50KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGN1
c3RvbS10aGVtZS1jaGVja2JveC10b2dnbGUgd2lkZ2V0IGV2ZW50KSkKKyAgICAgICAgICAg
ICAgICAgICAgICAgOmhlbHAtZWNobyBoZWxwLWVjaG8pCiAgICAgICAgICh3aWRnZXQtaW5z
ZXJ0ICIgLS0gIgogCQkgICAgICAgKHByb3BlcnRpemUgKGN1c3RvbS10aGVtZS1zdW1tYXJ5
IHRoZW1lKQogCQkJCSAgICdmYWNlICdzaGFkb3cpCi0tIAoyLjM0LjEKCg==

--------------ZE5RtZ0IymbHHl06CiH1QBuO--

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77096: 31.0.50; Theme names disappear in customize-themes
Resent-From: Mauro Aranda <maurooaranda@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 02 Apr 2025 11:13:02 +0000
Resent-Message-ID: <handler.77096.B77096.17435923746225 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77096 <at> debbugs.gnu.org
Message-ID: <72b4fe44-872a-49c0-9653-6eea973b1bb4@HIDDEN>
Date: Wed, 2 Apr 2025 08:12:42 -0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Mauro Aranda <maurooaranda@HIDDEN>
References: <82c988b6-5da9-4e80-8bc1-d8a16956a9f0@HIDDEN>
 <4d0a2b18-07d2-468d-8bcb-6fd77347accb@HIDDEN>
Content-Language: en-US
In-Reply-To: <4d0a2b18-07d2-468d-8bcb-6fd77347accb@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

close 77096
quit


On 18/3/25 07:06, Mauro Aranda wrote:
 > This is a result of my changes in:
 >
 > commit 85113fcda97970bc2468f409278e27d6570fc76f
 > Author: Mauro Aranda <maurooaranda@HIDDEN>
 > Date:   Fri Jan 17 17:12:08 2025 -0300
 >
 >      Prepare markers for insertions inside of a widget
 >
 >      Recreating child widgets without recreating the parent widget
 >      may lead to situations where the parent widget doesn't cover its
 >      children or buttons entirely anymore.  This bug manifests as a
 >      faulty fontification of children or buttons, for example.
 >      (Bug#69941)
 >
 >      * lisp/wid-edit.el (widget--prepare-markers-for-inside-insertion)
 >      (widget--prepare-markers-for-outside-insertion): New functions.
 >      (widget-default-create): Use them.
 >
 >      * test/lisp/wid-edit-tests.el
 > (widget-test-insertion-at-parent-markers)
 >      (widget-test-insertion-at-parent-markers-2): New tests.
 >
 >
 > But I don't think there's a bug in the wid-edit.el code, rather it's in
 > customize-themes.  The layout for a line with a theme is like this:
 > CHECKBOX BUTTON -- THEME-DESCRIPTION
 >
 > BUTTON has the theme name as a label, and it disappears after toggling
 > the checkbox.  The code creates BUTTON as a child of CHECKBOX, so the
 > code is asking for BUTTON to be contained inside CHECKBOX.  It didn't
 > happen before because of Bug#69941, but I think that what happens now is
 > what should happen.  Now, when the checkbox gets recreated, it deletes
 > its child and never creates it back (the cus-theme.el code should be
 > responsible of telling it to create it back in that case).
 >
 > But I don't think BUTTON should be a child of CHECKBOX.  In fact, the
 > usual thing to do with the Widget library is to make it a sibling.  So I
 > propose the attached patch.

Pushed to master.  Closing.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 2 Apr 2025 11:12:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 02 07:12:54 2025
Received: from localhost ([127.0.0.1]:55395 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tzw1e-0001cM-2L
	for submit <at> debbugs.gnu.org; Wed, 02 Apr 2025 07:12:54 -0400
Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:47599)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <maurooaranda@HIDDEN>)
 id 1tzw1b-0001bN-Sf; Wed, 02 Apr 2025 07:12:52 -0400
Received: by mail-pl1-x62f.google.com with SMTP id
 d9443c01a7336-224341bbc1dso110760985ad.3; 
 Wed, 02 Apr 2025 04:12:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1743592365; x=1744197165; darn=debbugs.gnu.org;
 h=content-transfer-encoding:in-reply-to:content-language:references
 :to:from:subject:user-agent:mime-version:date:message-id:from:to:cc
 :subject:date:message-id:reply-to;
 bh=0p5WJ6QHo0N8LfLxY4t7h5FGqec2QHY46GrK7Bp3y/U=;
 b=f3ANIcK8+91YAXvxXsMgHlE55YsB9WZEd+VpV1xcNwUkuwsWe79OIMjFrR0jda7oh0
 giJ6qv25kKSWu6mn4Yi+y0dY8XXZHF40lp6Sj93zHHAx5Yfwn9NtIeBq5IZkoo5yeyYx
 +w9ZvSjfxnOYU6rTh/BmDcRb8uPNSt6m//RJumcB65NCNXwMSaCVwuC9Kzczb/Aggc2l
 7//pd7AFORmOKFhgBCcaAfP8HrGsjLuWnWDc/1Aonu84LAd6TBzDg6YRQTplRkc5IOWW
 hwtRJLrrnnxqMIubpnuSzSdD7l4LtmceDwaijUC2s0oFJvqVcRIHcG7uLeI9qlI1Dcai
 iERw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1743592365; x=1744197165;
 h=content-transfer-encoding:in-reply-to:content-language:references
 :to:from:subject:user-agent:mime-version:date:message-id
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=0p5WJ6QHo0N8LfLxY4t7h5FGqec2QHY46GrK7Bp3y/U=;
 b=oCwNRJz0N/BHH2J8+lAG+FMjr+w01z3SV1JmuQRqNpaaMMMcu9f7MqCKvqkTdVYN84
 F/LDsnK5q7lc79wfbT2+lWkrAIn2VcD5H1pc06XC2c76yiwQnyWxY/38vggcJ6VmqvgR
 dIsx88DGYRRUqzv+pnPpWMvWdN2bqMxqi9bDQFrRJ/MjLJgBp0cwYA0CPu+G7sIrvCAV
 D4wazNy1N8Yjamxwz+rEDq4JSV7zPBTZoh05dm9ekskl+Fv9OTPbzyRhr8Mb88NELfK2
 f0Lvpy5LZS4WxaVKHZ3sJZ4hiWsY9qGQoBSpNZd6NSwQZbsM+1W4SBtiEgHHvbja3J+D
 uuqQ==
X-Forwarded-Encrypted: i=1;
 AJvYcCXqXoTJ/Do7MfD5EDhCkAolJUWniiXyz2aBi/7IVmSKlEmWF6CuRJgl4Ll/V9dQwgcB4OcQRBSM <at> debbugs.gnu.org
X-Gm-Message-State: AOJu0YwqPdYBUeC+PQ33RJgP/5buDoPt74SBE0jloEaEAP/YJ4ZJb5Pc
 JzIaM7azIKsVHvnCU0YArpFi5CZ9WyroMuGb7OcsDGzHRkk2btEHTrNUSWiP
X-Gm-Gg: ASbGncvt1g7kU9/TezSjYFd1C0UArboyFeqNVM4W8vbqE8BcrvouNtutIUsfFya0qwg
 lCrq4gGVdn4fbqqN0IU5GsUZYR8FToZs1D3m59dJUXZ6iLNxc3HSuMiVeHMDxJEgsPWhP+EL1nE
 DQMlD0HHxspCJpJiHjSBR0jH/J7eeaSIZ6nQzFTO5O61k0zp6X42efXlhmK5utdtaZnfkL2Gq7Q
 7YIy9v3faDL9Xbyw8oORKv8vPi4YGFeemKJty5y8JD4Nijm24KCAsG1zXEz9xSTnn2bXgYWK84j
 BOseUpqDtDHZrv4hFD1cieGLDQ9jF+T9NlY2nXux0sDhK9JRBNg=
X-Google-Smtp-Source: AGHT+IERGdJQtXt/wNXek/vVjJxX1qCa59bEtPkgWawPmJbKpdMPKn1QrwE8S4NJWI0RPesQEF/8Cg==
X-Received: by 2002:a17:903:230d:b0:227:e82b:b585 with SMTP id
 d9443c01a7336-2296c6620c7mr25776565ad.20.1743592365382; 
 Wed, 02 Apr 2025 04:12:45 -0700 (PDT)
Received: from [192.168.0.234] ([181.228.33.6])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-73970deeea2sm10619819b3a.21.2025.04.02.04.12.43
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 02 Apr 2025 04:12:44 -0700 (PDT)
Message-ID: <72b4fe44-872a-49c0-9653-6eea973b1bb4@HIDDEN>
Date: Wed, 2 Apr 2025 08:12:42 -0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: bug#77096: 31.0.50; Theme names disappear in customize-themes
From: Mauro Aranda <maurooaranda@HIDDEN>
To: 77096 <at> debbugs.gnu.org
References: <82c988b6-5da9-4e80-8bc1-d8a16956a9f0@HIDDEN>
 <4d0a2b18-07d2-468d-8bcb-6fd77347accb@HIDDEN>
Content-Language: en-US
In-Reply-To: <4d0a2b18-07d2-468d-8bcb-6fd77347accb@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

close 77096
quit


On 18/3/25 07:06, Mauro Aranda wrote:
 > This is a result of my changes in:
 >
 > commit 85113fcda97970bc2468f409278e27d6570fc76f
 > Author: Mauro Aranda <maurooaranda@HIDDEN>
 > Date:   Fri Jan 17 17:12:08 2025 -0300
 >
 >      Prepare markers for insertions inside of a widget
 >
 >      Recreating child widgets without recreating the parent widget
 >      may lead to situations where the parent widget doesn't cover its
 >      children or buttons entirely anymore.  This bug manifests as a
 >      faulty fontification of children or buttons, for example.
 >      (Bug#69941)
 >
 >      * lisp/wid-edit.el (widget--prepare-markers-for-inside-insertion)
 >      (widget--prepare-markers-for-outside-insertion): New functions.
 >      (widget-default-create): Use them.
 >
 >      * test/lisp/wid-edit-tests.el
 > (widget-test-insertion-at-parent-markers)
 >      (widget-test-insertion-at-parent-markers-2): New tests.
 >
 >
 > But I don't think there's a bug in the wid-edit.el code, rather it's in
 > customize-themes.  The layout for a line with a theme is like this:
 > CHECKBOX BUTTON -- THEME-DESCRIPTION
 >
 > BUTTON has the theme name as a label, and it disappears after toggling
 > the checkbox.  The code creates BUTTON as a child of CHECKBOX, so the
 > code is asking for BUTTON to be contained inside CHECKBOX.  It didn't
 > happen before because of Bug#69941, but I think that what happens now is
 > what should happen.  Now, when the checkbox gets recreated, it deletes
 > its child and never creates it back (the cus-theme.el code should be
 > responsible of telling it to create it back in that case).
 >
 > But I don't think BUTTON should be a child of CHECKBOX.  In fact, the
 > usual thing to do with the Widget library is to make it a sibling.  So I
 > propose the attached patch.

Pushed to master.  Closing.

Last modified: Wed, 2 Apr 2025 11:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.