GNU bug report logs - #77100
[PATCH] FIx varnish error on startup

Previous Next

To reply to this bug, email your comments to 77100 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nazar Klovanych <nazarn96 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] FIx varnish error on startup
Date: Tue, 18 Mar 2025 14:30:13 +0200

[Message part 1 (text/plain, inline)]

This fixes the error on varnish startup

[0001-gnu-varnish-Fix-varnish-failed-to-start.patch (application/octet-stream, attachment)]

Message #8 received at 77100 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Nazar Klovanych <nazarn96 <at> gmail.com>
Cc: 77100 <at> debbugs.gnu.org
Subject: Re: [bug#77100] [PATCH] FIx varnish error on startup
Date: Sat, 22 Mar 2025 09:07:03 -0700

Hi Nazar,

Thank you for the patch!  The changes themselves look good to me, 
but the commit subject/message need to be in the expected 
Changelog format and to have typos ("FIx") corrected.  Please see 
(guix)Contributing[1], in particular the "Coding Styles" and 
"Submitting Patches" sections.

Could you please update your patch to meet the Guix coding 
standards, create a second version (`git format-patch -v2 ...'), 
and submit it with `git send-email'?

Thanks,

 -- Ian

[1]: 
https://guix.gnu.org/manual/devel/en/html_node/Contributing.html

Message #11 received at 77100 <at> debbugs.gnu.org (full text, mbox):

From: Nazar Klovanych <nazarn96 <at> gmail.com>
To: 77100 <at> debbugs.gnu.org
Cc: Nazar Klovanych <nazarn96 <at> gmail.com>
Subject: [PATCH v2] gnu: varnish: Fix varnish failed to start
Date: Mon, 24 Mar 2025 13:41:19 +0200

This fixes the error on varnish startup

2025-03-18 08:16:48 localhost shepherd[1]: [varnishd] Info: Working directory not mounted on tmpfs partition
2025-03-18 08:16:48 localhost shepherd[1]: [varnishd] sh: line 1: rm: command not found
2025-03-18 08:16:48 localhost shepherd[1]: [varnishd] Assert error in main(), mgt/mgt_main.c line 876:
---
 gnu/packages/web.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 54f2f75097..37acd2d617 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -6825,7 +6825,9 @@ (define-public varnish
                  (substitute* "bin/varnishd/mgt/mgt_shmem.c"
                    (("rm -rf") (string-append rm " -rf")))
                  (substitute* "bin/varnishtest/vtc_main.c"
-                   (("/bin/rm") rm)))
+                   (("/bin/rm") rm))
+                 (substitute* "bin/varnishd/mgt/mgt_main.c"
+                   (("rm -rf") (string-append rm " -rf"))))
                (substitute* "bin/varnishtest/tests/u00000.vtc"
                  (("/bin/echo") (which "echo")))))
            (add-after 'unpack 'remove-failing-tests

base-commit: 9879a7d75279762c7634f1a585794442ea2f0503
-- 
2.48.1

Message #16 received at 77100-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nazar Klovanych <nazarn96 <at> gmail.com>
Cc: 77100-done <at> debbugs.gnu.org
Subject: Re: bug#77100: [PATCH] FIx varnish error on startup
Date: Sun, 06 Apr 2025 11:42:02 +0200

Hi Nazar,

Nazar Klovanych <nazarn96 <at> gmail.com> skribis:

> This fixes the error on varnish startup
>
> 2025-03-18 08:16:48 localhost shepherd[1]: [varnishd] Info: Working directory not mounted on tmpfs partition
> 2025-03-18 08:16:48 localhost shepherd[1]: [varnishd] sh: line 1: rm: command not found
> 2025-03-18 08:16:48 localhost shepherd[1]: [varnishd] Assert error in main(), mgt/mgt_main.c line 876:

I tweaked the commit log as suggested by Ian and applied it.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.