GNU bug report logs - #77125
[PATCH] igc ; * etc/DEBUG: Fix gdb examples to: call ... (global_igc->arena)

Previous Next

To reply to this bug, email your comments to 77125 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jeremy Bryant <jb <at> jeremybryant.net>
To: bug-gnu-emacs <at> gnu.org, Pip Cet <pipcet <at> protonmail.com>, Eli Zaretskii
 <eliz <at> gnu.org>
Subject: [PATCH] igc ; * etc/DEBUG: Fix gdb examples to: call ...
 (global_igc->arena)
Date: Wed, 19 Mar 2025 22:53:40 +0000

Minor fix to recent revised patch, which was missing the improvement.

global_igc->arena

Message #8 received at 77125 <at> debbugs.gnu.org (full text, mbox):

From: Jeremy Bryant <jb <at> jeremybryant.net>
To: Jeremy Bryant via "Bug reports for GNU Emacs, the Swiss army knife of
 text editors" <bug-gnu-emacs <at> gnu.org>
Cc: pipcet <at> protonmail.com, eliz <at> gnu.org, 77125 <at> debbugs.gnu.org
Subject: Re: bug#77125: [PATCH] igc ; * etc/DEBUG: Fix gdb examples to: call
 ... (global_igc->arena)
Date: Thu, 20 Mar 2025 21:56:36 +0000

[Message part 1 (text/plain, inline)]

Jeremy Bryant via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org> writes:

> Minor fix to recent revised patch, which was missing the improvement.
>
> global_igc->arena

[0001-etc-DEBUG-Fix-gdb-examples-to-call-.-global_igc-aren.patch (text/x-diff, attachment)]

Message #14 received at 77125 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jeremy Bryant <jb <at> jeremybryant.net>
Cc: pipcet <at> protonmail.com, 77125 <at> debbugs.gnu.org
Subject: Re: bug#77125: [PATCH] igc ; * etc/DEBUG: Fix gdb examples to: call
 ... (global_igc->arena)
Date: Fri, 21 Mar 2025 10:30:59 +0200

> From: Jeremy Bryant <jb <at> jeremybryant.net>
> Cc: 77125 <at> debbugs.gnu.org,  pipcet <at> protonmail.com,  eliz <at> gnu.org
> Date: Thu, 20 Mar 2025 21:56:36 +0000
> 
> --- a/etc/DEBUG
> +++ b/etc/DEBUG
> @@ -1382,11 +1382,11 @@ states.  Two of these are important for debugging, the clamped and
>  parked states.  When debugging igc, you can clamp the arena before
>  inspecting memory:
>  
> -     (gdb) call mps_arena_clamp(arena)
> +     (gdb) call mps_arena_clamp(global_igc->arena)
>  
>  and then release it afterwards with:
>  
> -     (gdb) call mps_arena_release(arena)
> +     (gdb) call mps_arena_release(global_igc->arena)

Is it really true that the arena pointer is always global_igc->arena
in Emacs?  If so, I would suggest to tell that separately, because the
GDB calls to functions can have arguments constructed in many
different ways.  Something like

  In Emacs, the arena is usually stored in 'global_igc->arena'.

and leave the examples in their current general form.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.