GNU bug report logs - #77201
[PATCH] guix: substitute-key-authorization: Fix case when acl symlink is broken

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Rutherther <rutherther@HIDDEN>; Keywords: patch; Done: Ludovic Courtès <ludo@HIDDEN>; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 77201-done <at> debbugs.gnu.org:

Received: (at 77201-done) by debbugs.gnu.org; 5 May 2025 15:35:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 05 11:35:04 2025
Received: from localhost ([127.0.0.1]:41761 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uBxqR-0005lI-Lp
	for submit <at> debbugs.gnu.org; Mon, 05 May 2025 11:35:04 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:45498)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1uBxqH-0005iy-FF
 for 77201-done <at> debbugs.gnu.org; Mon, 05 May 2025 11:34:53 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1uBxqB-0001pm-Pe; Mon, 05 May 2025 11:34:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=L3WUtxHQ1lwcSyBkzM5OCYcMYjZWST5/Rtqba+0JRM8=; b=KPMrTc+j+ahI0qFgVB5U
 gl2uELJKffgVrGTjfW0sz0QgT6UkCDxytTpt9VDb9MNkwwVQCh1MaEv4X8lktzIlvSK+K0hLwNwTm
 MaZbf2mpxoB49Y+wvrgA/Za3I9QQvOuKt/LtfaOmTFcVHujxc7O6laTM01Eo17ghtPRTFC9YVjtPd
 27U5nOTN6IodwF50CCMNkf6hUO2aegTywAFqzdDypG1jcT39mKUfyvstIhP2UU/phoNBdMwavfNes
 Tq2rIkXJggGN7aBu2xPY7kDdm+VuCDEu80KedIK5RpQN3Y9zW8jvAlpRmPYtasW8uX5P0GPuDf7dQ
 p5JKN7qtA73N/A==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Rutherther <rutherther@HIDDEN>
Subject: Re: bug#77201: [PATCH] guix: substitute-key-authorization: Fix case
 when acl symlink is broken
In-Reply-To: <bb8060e580fe7e60e3f7edd067d0f35648576e71.1745827664.git.rutherther@HIDDEN>
 (rutherther@HIDDEN's message of "Mon, 28 Apr 2025 10:07:53
 +0200")
References: <f56c393fa6872cb0142564061ee17e5e7f8131cc.1742723299.git.rutherther@HIDDEN>
 <bb8060e580fe7e60e3f7edd067d0f35648576e71.1745827664.git.rutherther@HIDDEN>
Date: Mon, 05 May 2025 12:19:21 +0200
Message-ID: <87jz6v5phy.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.8 (/)
X-Debbugs-Envelope-To: 77201-done
Cc: 77201-done <at> debbugs.gnu.org, Ian Eure <ian@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.2 (/)

Hi,

Rutherther <rutherther@HIDDEN> writes:

> One possible solution for an issue when /etc/guix/acl file exists, but po=
ints
> to a non-existent location. This can for example happen if one is
> reinitializing the system, and remove only /gnu/store and /var/guix, keep=
 the
> rest okay. This is a major advantage of guix as compared to other distros=
 that
> usually need you to reinitialize the whole root partition. But this will =
leave
> the user with acl file pointing to non-existent location. The file-exists?
> procedure will return #f for broken symbolic links.
>
> I think that another reason one would get this issue is, if one was boote=
d in
> a live iso, chrooted, fixing their system. They would switch generations =
to
> one with different acl file, delete other generations gc rooting the orig=
inal
> acl file and then gc. One could do this approach for example when recover=
ing
> from file corruptions in the store, to get rid of the unsubstitutable pat=
hs
> that can't be repaired with guix gc --verify.
>
> This fixes the issue by looking for type of a file through lstat, instead=
 of
> relying on file-exists?. If the symlink is a broken symlink, it is
> removed. Other than that the old behavior is kept:
> - If regular file, back it up
> - If symlink pointing to the store, remove it
> - If symlink not pointing to the store, back it up
>
> * gnu/services/base.scm (substitute-key-authorization): Check if acl file=
 is a
> (broken) symbolic link
>
> Change-Id: I2f8170606b2f4afeea48f04acfd738b04cafc7cf

Applied after changing the terminology from =E2=80=9Cbroken symlink=E2=80=
=9D to
=E2=80=9Cdangling symlink=E2=80=9D, which I think is more widely used (and =
easier to
find while grepping!).

Thanks,
Ludo=E2=80=99.

Notification sent to Rutherther <rutherther@HIDDEN>:
bug acknowledged by developer. Full text available.

Reply sent to Ludovic Courtès <ludo@HIDDEN>:
You have taken responsibility. Full text available.