GNU bug report logs - #77215
31.0.50; enable-theme-functions fires twice after a load-theme

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 23 Mar 2025 17:54:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 23 13:54:30 2025
Received: from localhost ([127.0.0.1]:52528 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1twPWo-0006rG-Be
	for submit <at> debbugs.gnu.org; Sun, 23 Mar 2025 13:54:30 -0400
Received: from lists.gnu.org ([2001:470:142::17]:55162)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <filippo.argiolas@HIDDEN>)
 id 1twPWm-0006qz-1B
 for submit <at> debbugs.gnu.org; Sun, 23 Mar 2025 13:54:28 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <filippo.argiolas@HIDDEN>)
 id 1twPWg-0001GA-2y
 for bug-gnu-emacs@HIDDEN; Sun, 23 Mar 2025 13:54:22 -0400
Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <filippo.argiolas@HIDDEN>)
 id 1twPWe-0004xA-IJ
 for bug-gnu-emacs@HIDDEN; Sun, 23 Mar 2025 13:54:21 -0400
Received: by mail-ed1-x52c.google.com with SMTP id
 4fb4d7f45d1cf-5e6ff035e9aso6813893a12.0
 for <bug-gnu-emacs@HIDDEN>; Sun, 23 Mar 2025 10:54:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1742752457; x=1743357257; darn=gnu.org;
 h=mime-version:message-id:date:cc:subject:to:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=6xBHUSA4p1OtcH1jimlxB3crgN7UUS0CgqYtFOlEZro=;
 b=m9JIR+8Dn0DLoW1qZzMUWTX7M1JQ3OTBc87JIUmaThTCqKoOitlfFkGwE9NqwOBKnd
 rKY5Hsgu+Ewxze+M8ZGwVEYpB5x3lj5WNG1yaQgT+0SeISSykdVPzKTGCq5eMDfZn7p0
 lQ5U01GLFv0MVVPcRzDFgyyQluSVPh0DsLvGlE1M6ceUOYcWg/HI7fSx12j55cFES7zO
 5CoKKidgS8ZCYT+c0+/Z0gwyyaQ4va+nhdZNWEmQ0zTJFYvIXSeLYmJH2X6GW8XXJkAG
 iqXau5KlwwYf/iF5qzKZffCxvcSpFpsE1j0bJLHtWj3o2h3TnJ0yygLH1S6k7ar1C7ti
 2v4A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1742752457; x=1743357257;
 h=mime-version:message-id:date:cc:subject:to:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=6xBHUSA4p1OtcH1jimlxB3crgN7UUS0CgqYtFOlEZro=;
 b=kRwL08dHF5eJ/UTSCREH5yOiv7m5fvnEgmHivczIKLeSdFpnCihXT7uR6odacD9aOL
 FHz0ue7XtZ39GYUhRhsBO6gMdwzxuRO70EB2a7e32bC7gcuzlgQ+Yed4wSlrdcGFAFgh
 KQYNpSVXqL/wIygFSRatn1C3qlzpaawDfcpNiGxIqeUueBikZ/4akgcb5nMbJPpAae8b
 23RxP6zbjrmnyKV816+u996BXXWrz83RtESCxpzcQZbV9MvWEdk3aDgfrXqgEdls48MA
 vZZl9PQnZuL5ILEJxSwN2lo7JwUFHuHz4vZd+VotnjrtnaT1Vb15MfKa7Xbb+dQqjxGm
 T0kw==
X-Gm-Message-State: AOJu0Yz9Rsv8GXTvJ4DqOQh4VfnmwbYeSdnTNdiF6pMwQL6FbSdoHgNP
 NiNP1X2TlbpCLAjLttu1k4NnCu2abqWDuX7FDUwjsqvzCk2Rp1ik4qg2CQ==
X-Gm-Gg: ASbGncsMU/YA5qJdIDVAFtR5nupsM+UWhwOje35/93PUMG1HZeieC6DZzNGL8uiC7pr
 VLjfRxBBwxGqhIVqx6efyy2/BlXQGplAdHTM8u5FA/nACZBQsrQlh0byOXHJUBvv4DNiOup/qG8
 duGid/pe7tdGKOe/SmUdQs9TDjDA1FxrL2WHtE2/NNrjGC31vMfZUPIs0NPDA5wC1r+JppDR78h
 K64H1O6PAUHJ95rmIJqLn9d8drBTyrBVI1evNJJ+VsJqwHAoaPRtyqEmF3cA3LJNY3BCY8KHF/m
 IXBueFKDg0NcBc3z8KiZtXxlS6KSrS11CgH26IyOtmB687yfyqpD6FbRmZK8z+c=
X-Google-Smtp-Source: AGHT+IGSYsuZdy+kd2+BT4wyhZ1OKyOqFZ3lNq0DkQKFC5SMdAMiDVwTCOLTDvNkqJn80DxHlhSY9A==
X-Received: by 2002:a05:6402:27cb:b0:5e7:c773:ae35 with SMTP id
 4fb4d7f45d1cf-5ebcd40bd58mr9511501a12.5.1742752457110; 
 Sun, 23 Mar 2025 10:54:17 -0700 (PDT)
Received: from mba ([151.81.191.82]) by smtp.gmail.com with ESMTPSA id
 4fb4d7f45d1cf-5ebcd0dfcd5sm4757622a12.71.2025.03.23.10.54.15
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 23 Mar 2025 10:54:16 -0700 (PDT)
From: Filippo Argiolas <filippo.argiolas@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 31.0.50; enable-theme-functions fires twice after a load-theme
X-Debbugs-Cc: 
Date: Sun, 23 Mar 2025 18:54:14 +0100
Message-ID: <m2ecyn7hvd.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2a00:1450:4864:20::52c;
 envelope-from=filippo.argiolas@HIDDEN; helo=mail-ed1-x52c.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: Stefan Monnier <monnier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Hi,

I noticed that my `enable-theme-functions' hook always fires twice after
either a `load-theme' or a `enable-theme'.

Problem is `enable-theme' in custom.el always also enables the user
theme to push it on top of the list.

Is this desired?

Technically I'd say it's correct, two enables spark two hooks, buyt from the
user point of view seems a counterintuitive side effect without digging
into the code.

Filippo