GNU bug report logs - #77263
MH-E: want all folder buffers to use $HOME as default-directory

Previous Next

To reply to this bug, email your comments to 77263 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stephen Gildea <stepheng+emacs <at> gildea.com>
To: bug-emacs <at> gnu.org
Subject: MH-E: want all folder buffers to use $HOME as default-directory
Date: Tue, 25 Mar 2025 14:07:33 -0700

Version: 30.1
Severity: wishlist
Tags: patch

An MH-E folder buffer inherits the default-directory of the
buffer you happened to be in when you gave the command 'mh-rmail'.

This seems arbitrary in general, and inconvenient when the
current directory happens to be remote.  With a remote
directory, Emacs tries to do remote things in the background,
and all I'm trying to do is read my (local) email.

The following patch would fix the problem.  It introduces a new
variable 'mh-default-directory', which defaults to $HOME.


diff --git a/lisp/mh-e/mh-e.el b/lisp/mh-e/mh-e.el
index e507996c581..ca829c6cf3c 100644
--- a/lisp/mh-e/mh-e.el
+++ b/lisp/mh-e/mh-e.el
@@ -144,6 +144,9 @@ mh-lib-progs
 ;;;###autoload
 (put 'mh-lib-progs 'risky-local-variable t)
 
+(defvar mh-default-directory "~/"
+  "Default directory for MH-E folder buffers.")
+
 ;; Profile Components
 
 (defvar mh-draft-folder nil
diff --git a/lisp/mh-e/mh-folder.el b/lisp/mh-e/mh-folder.el
index 5009c2c4f98..43b4c98ef01 100644
--- a/lisp/mh-e/mh-folder.el
+++ b/lisp/mh-e/mh-folder.el
@@ -51,9 +51,12 @@ mh-rmail
   (interactive "P")
   (mh-find-path)
   (if arg
-      (call-interactively 'mh-visit-folder)
+      (progn
+        (call-interactively 'mh-visit-folder)
+        (cd-absolute mh-default-directory))
     (unless (get-buffer mh-inbox)
-      (mh-visit-folder mh-inbox (symbol-name mh-unseen-seq)))
+      (mh-visit-folder mh-inbox (symbol-name mh-unseen-seq))
+      (cd-absolute mh-default-directory))
     (mh-inc-folder)))
 
 ;;;###autoload
@@ -67,6 +70,7 @@ mh-nmail
   (mh-find-path)                        ; init mh-inbox
   (if arg
       (call-interactively 'mh-visit-folder)
-    (mh-visit-folder mh-inbox)))
+    (mh-visit-folder mh-inbox))
+  (cd-absolute mh-default-directory))
 
 

Message #8 received at 77263 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stephen Gildea <stepheng+emacs <at> gildea.com>, Bill Wohler <wohler <at> newt.com>
Cc: 77263 <at> debbugs.gnu.org
Subject: Re: bug#77263: MH-E: want all folder buffers to use $HOME as
 default-directory
Date: Wed, 26 Mar 2025 14:16:20 +0200

> From: Stephen Gildea <stepheng+emacs <at> gildea.com>
> Date: Tue, 25 Mar 2025 14:07:33 -0700
> 
> An MH-E folder buffer inherits the default-directory of the
> buffer you happened to be in when you gave the command 'mh-rmail'.
> 
> This seems arbitrary in general, and inconvenient when the
> current directory happens to be remote.  With a remote
> directory, Emacs tries to do remote things in the background,
> and all I'm trying to do is read my (local) email.
> 
> The following patch would fix the problem.  It introduces a new
> variable 'mh-default-directory', which defaults to $HOME.

Bill, any comments?

> --- a/lisp/mh-e/mh-folder.el
> +++ b/lisp/mh-e/mh-folder.el
> @@ -51,9 +51,12 @@ mh-rmail
>    (interactive "P")
>    (mh-find-path)
>    (if arg
> -      (call-interactively 'mh-visit-folder)
> +      (progn
> +        (call-interactively 'mh-visit-folder)
> +        (cd-absolute mh-default-directory))
>      (unless (get-buffer mh-inbox)
> -      (mh-visit-folder mh-inbox (symbol-name mh-unseen-seq)))
> +      (mh-visit-folder mh-inbox (symbol-name mh-unseen-seq))
> +      (cd-absolute mh-default-directory))
>      (mh-inc-folder)))
>  
>  ;;;###autoload
> @@ -67,6 +70,7 @@ mh-nmail
>    (mh-find-path)                        ; init mh-inbox
>    (if arg
>        (call-interactively 'mh-visit-folder)
> -    (mh-visit-folder mh-inbox)))
> +    (mh-visit-folder mh-inbox))
> +  (cd-absolute mh-default-directory))
>  

I wonder if calling cd-absolute here is really a good idea.  That
function could signal an error, and it insists on the directory being
an existing accessible directory.  Is it a good idea to potentially
screw up starting MH-E if the directory happens to be problematic?
Why not simply set the default-directory of the buffer instead?

However, I'm not using MH-E, so feel free to disregard the above.

Thanks.

Message #11 received at 77263 <at> debbugs.gnu.org (full text, mbox):

From: Bill Wohler <wohler <at> newt.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 77263 <at> debbugs.gnu.org, Stephen Gildea <stepheng+emacs <at> gildea.com>
Subject: Re: bug#77263: MH-E: want all folder buffers to use $HOME as
 default-directory
Date: Wed, 26 Mar 2025 08:54:15 -0700

Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Stephen Gildea <stepheng+emacs <at> gildea.com>
> > Date: Tue, 25 Mar 2025 14:07:33 -0700
> > 
> > An MH-E folder buffer inherits the default-directory of the
> > buffer you happened to be in when you gave the command 'mh-rmail'.
> > 
> > This seems arbitrary in general, and inconvenient when the
> > current directory happens to be remote.  With a remote
> > directory, Emacs tries to do remote things in the background,
> > and all I'm trying to do is read my (local) email.
> > 
> > The following patch would fix the problem.  It introduces a new
> > variable 'mh-default-directory', which defaults to $HOME.
> 
> Bill, any comments?
> 
> > --- a/lisp/mh-e/mh-folder.el
> > +++ b/lisp/mh-e/mh-folder.el
> > @@ -51,9 +51,12 @@ mh-rmail
> >    (interactive "P")
> >    (mh-find-path)
> >    (if arg
> > -      (call-interactively 'mh-visit-folder)
> > +      (progn
> > +        (call-interactively 'mh-visit-folder)
> > +        (cd-absolute mh-default-directory))
> >      (unless (get-buffer mh-inbox)
> > -      (mh-visit-folder mh-inbox (symbol-name mh-unseen-seq)))
> > +      (mh-visit-folder mh-inbox (symbol-name mh-unseen-seq))
> > +      (cd-absolute mh-default-directory))
> >      (mh-inc-folder)))
> >  
> >  ;;;###autoload
> > @@ -67,6 +70,7 @@ mh-nmail
> >    (mh-find-path)                        ; init mh-inbox
> >    (if arg
> >        (call-interactively 'mh-visit-folder)
> > -    (mh-visit-folder mh-inbox)))
> > +    (mh-visit-folder mh-inbox))
> > +  (cd-absolute mh-default-directory))
> >  
> 
> I wonder if calling cd-absolute here is really a good idea.  That
> function could signal an error, and it insists on the directory being
> an existing accessible directory.  Is it a good idea to potentially
> screw up starting MH-E if the directory happens to be problematic?
> Why not simply set the default-directory of the buffer instead?

Stefan, Eli raises a good point. I know we've been using M-x cd to work
around the problem, but if setting the default-directory to
mh-default-directory does the trick, I'm all for it. Does Eli's
suggestion work in our context?

> However, I'm not using MH-E, so feel free to disregard the above.
> 
> Thanks.
> 

-- 
Bill Wohler <wohler <at> newt.com> aka <Bill.Wohler <at> nasa.gov>
http://www.newt.com/wohler/, GnuPG ID:610BD9AD

Message #14 received at 77263 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Gildea <stepheng+emacs <at> gildea.com>
To: 77263 <at> debbugs.gnu.org
Cc: Bill Wohler <wohler <at> newt.com>
Subject: Re: bug#77263: MH-E: want all folder buffers to use $HOME as
 default-directory
Date: Wed, 26 Mar 2025 09:22:29 -0700

Eli Zaretskii <eliz <at> gnu.org> wrote:

>   I wonder if calling cd-absolute here is really a good idea.  That
>   function could signal an error, and it insists on the directory being
>   an existing accessible directory.  Is it a good idea to potentially
>   screw up starting MH-E if the directory happens to be problematic?
>   Why not simply set the default-directory of the buffer instead?

I had not realized that 'cd-absolute' had issues when called
from Lisp.  Here is a revised version of my patch:


diff --git a/lisp/mh-e/mh-e.el b/lisp/mh-e/mh-e.el
index e507996c581..f64b02c7bca 100644
--- a/lisp/mh-e/mh-e.el
+++ b/lisp/mh-e/mh-e.el
@@ -144,6 +144,10 @@ mh-lib-progs
 ;;;###autoload
 (put 'mh-lib-progs 'risky-local-variable t)
 
+(defvar mh-default-directory "~/"
+  "Default directory for MH-E folder buffers.
+Set to nil to have MH-E buffers inherit default-directory.")
+
 ;; Profile Components
 
 (defvar mh-draft-folder nil
@@ -438,6 +442,12 @@ mh-list-to-string-1
              (error "Bad element: %s" element))))
     new-list))
 
+(defun mh-set-default-directory ()
+  "Set `default-directory' to `mh-default-directory' unless it is nil."
+  (when (stringp mh-default-directory)
+    (setq default-directory (file-name-as-directory
+                             (expand-file-name mh-default-directory)))))
+
 
 
 ;;; MH-E Process Support
diff --git a/lisp/mh-e/mh-folder.el b/lisp/mh-e/mh-folder.el
index 5009c2c4f98..e0c53724f9c 100644
--- a/lisp/mh-e/mh-folder.el
+++ b/lisp/mh-e/mh-folder.el
@@ -51,9 +51,12 @@ mh-rmail
   (interactive "P")
   (mh-find-path)
   (if arg
-      (call-interactively 'mh-visit-folder)
+      (progn
+        (call-interactively 'mh-visit-folder)
+        (mh-set-default-directory))
     (unless (get-buffer mh-inbox)
-      (mh-visit-folder mh-inbox (symbol-name mh-unseen-seq)))
+      (mh-visit-folder mh-inbox (symbol-name mh-unseen-seq))
+      (mh-set-default-directory))
     (mh-inc-folder)))
 
 ;;;###autoload
@@ -67,6 +70,7 @@ mh-nmail
   (mh-find-path)                        ; init mh-inbox
   (if arg
       (call-interactively 'mh-visit-folder)
-    (mh-visit-folder mh-inbox)))
+    (mh-visit-folder mh-inbox))
+  (mh-set-default-directory))
 
 

Message #17 received at 77263 <at> debbugs.gnu.org (full text, mbox):

From: Bill Wohler <wohler <at> newt.com>
To: Stephen Gildea <stepheng+emacs <at> gildea.com>
Cc: 77263 <at> debbugs.gnu.org
Subject: Re: bug#77263: MH-E: want all folder buffers to use $HOME as
 default-directory
Date: Wed, 26 Mar 2025 20:58:53 -0700

Stephen Gildea <stepheng+emacs <at> gildea.com> wrote:

> Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> >   I wonder if calling cd-absolute here is really a good idea.  That
> >   function could signal an error, and it insists on the directory being
> >   an existing accessible directory.  Is it a good idea to potentially
> >   screw up starting MH-E if the directory happens to be problematic?
> >   Why not simply set the default-directory of the buffer instead?
> 
> I had not realized that 'cd-absolute' had issues when called
> from Lisp.  Here is a revised version of my patch:

I applied this patch and it fixes a long-standing issue I've had with
MH-E. Does this work for you, Eli?

Thanks, Stephen!

> diff --git a/lisp/mh-e/mh-e.el b/lisp/mh-e/mh-e.el
> index e507996c581..f64b02c7bca 100644
> --- a/lisp/mh-e/mh-e.el
> +++ b/lisp/mh-e/mh-e.el
> @@ -144,6 +144,10 @@ mh-lib-progs
>  ;;;###autoload
>  (put 'mh-lib-progs 'risky-local-variable t)
>  
> +(defvar mh-default-directory "~/"
> +  "Default directory for MH-E folder buffers.
> +Set to nil to have MH-E buffers inherit default-directory.")
> +
>  ;; Profile Components
>  
>  (defvar mh-draft-folder nil
> @@ -438,6 +442,12 @@ mh-list-to-string-1
>               (error "Bad element: %s" element))))
>      new-list))
>  
> +(defun mh-set-default-directory ()
> +  "Set `default-directory' to `mh-default-directory' unless it is nil."
> +  (when (stringp mh-default-directory)
> +    (setq default-directory (file-name-as-directory
> +                             (expand-file-name mh-default-directory)))))
> +
>  
>  
>  ;;; MH-E Process Support
> diff --git a/lisp/mh-e/mh-folder.el b/lisp/mh-e/mh-folder.el
> index 5009c2c4f98..e0c53724f9c 100644
> --- a/lisp/mh-e/mh-folder.el
> +++ b/lisp/mh-e/mh-folder.el
> @@ -51,9 +51,12 @@ mh-rmail
>    (interactive "P")
>    (mh-find-path)
>    (if arg
> -      (call-interactively 'mh-visit-folder)
> +      (progn
> +        (call-interactively 'mh-visit-folder)
> +        (mh-set-default-directory))
>      (unless (get-buffer mh-inbox)
> -      (mh-visit-folder mh-inbox (symbol-name mh-unseen-seq)))
> +      (mh-visit-folder mh-inbox (symbol-name mh-unseen-seq))
> +      (mh-set-default-directory))
>      (mh-inc-folder)))
>  
>  ;;;###autoload
> @@ -67,6 +70,7 @@ mh-nmail
>    (mh-find-path)                        ; init mh-inbox
>    (if arg
>        (call-interactively 'mh-visit-folder)
> -    (mh-visit-folder mh-inbox)))
> +    (mh-visit-folder mh-inbox))
> +  (mh-set-default-directory))
>  
>  
> 

-- 
Bill Wohler <wohler <at> newt.com> aka <Bill.Wohler <at> nasa.gov>
http://www.newt.com/wohler/, GnuPG ID:610BD9AD

Message #20 received at 77263 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Bill Wohler <wohler <at> newt.com>
Cc: 77263 <at> debbugs.gnu.org, stepheng+emacs <at> gildea.com
Subject: Re: bug#77263: MH-E: want all folder buffers to use $HOME as
 default-directory
Date: Thu, 27 Mar 2025 09:11:16 +0200

> Cc: 77263 <at> debbugs.gnu.org
> Comments: In-reply-to Stephen Gildea <stepheng+emacs <at> gildea.com>
>  message dated "Wed, 26 Mar 2025 09:22:29 -0700."
> Date: Wed, 26 Mar 2025 20:58:53 -0700
> From:  Bill Wohler via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Stephen Gildea <stepheng+emacs <at> gildea.com> wrote:
> 
> > Eli Zaretskii <eliz <at> gnu.org> wrote:
> > 
> > >   I wonder if calling cd-absolute here is really a good idea.  That
> > >   function could signal an error, and it insists on the directory being
> > >   an existing accessible directory.  Is it a good idea to potentially
> > >   screw up starting MH-E if the directory happens to be problematic?
> > >   Why not simply set the default-directory of the buffer instead?
> > 
> > I had not realized that 'cd-absolute' had issues when called
> > from Lisp.  Here is a revised version of my patch:
> 
> I applied this patch and it fixes a long-standing issue I've had with
> MH-E. Does this work for you, Eli?

Yes, thanks.

Message #25 received at 77263-done <at> debbugs.gnu.org (full text, mbox):

From: Stephen Gildea <stepheng+emacs <at> gildea.com>
To: 77263-done <at> debbugs.gnu.org
Subject: Re: bug#77263: MH-E: want all folder buffers to use $HOME as
 default-directory
Date: Thu, 27 Mar 2025 15:39:19 -0700

I pushed the revised patch earlier today, commit 01f4a0cb6c.

Closing the bug report.

 < Stephen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.