GNU bug report logs - #77269
[PATCH] Add jellyfin-media-player package

Previous Next

To reply to this bug, email your comments to 77269 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Apoorv Singh <apoorvs569 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add jellyfin-media-player package
Date: Wed, 26 Mar 2025 11:37:56 +0530

[0001-Add-jellyfin-media-player-package.patch (text/x-patch, attachment)]

[Message part 2 (text/plain, inline)]

This patch adds jellyfin-media-player package definition.

--
- Apoorv Singh
- Sent from Emacs.

Message #8 received at 77269 <at> debbugs.gnu.org (full text, mbox):

From: 45mg <45mg.writes <at> gmail.com>
To: Apoorv Singh <apoorvs569 <at> gmail.com>, 77269 <at> debbugs.gnu.org
Subject: Re: [bug#77269] [PATCH] Add jellyfin-media-player package
Date: Wed, 26 Mar 2025 11:51:43 +0000

Hi,

Haven't tested this, but thought I'd offer a preliminary review for some
basic stuff:

Apoorv Singh <apoorvs569 <at> gmail.com> writes:

> From ede9e38ba6c0702179654df0ecccdb2aacb11597 Mon Sep 17 00:00:00 2001
> From: apoorv569 <apoorvs569 <at> gmail.com>
> Date: Wed, 26 Mar 2025 10:14:51 +0530
> Subject: [PATCH] Add jellyfin-media-player package
>
> Change-Id: I95e189913e3082e4f63c2f1e7e8f22fe016d9da6
> ---
>  gnu/packages/video.scm | 49 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index 9ad8262b98..d8164dd96f 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -297,6 +297,55 @@ (define (bin command)
>  user has installed.")
>      (license license:gpl3+)))
>  
> +(define-public jellyfin-media-player
> +  (let ((commit "68ddf01ecef766620d4e564cada0a1125840547f")
> +        (revision "0"))
> +    (package
> +     (name "jellyfin-media-player")
> +     (version (git-version "1.12.0" revision commit))
> +     (source
> +      (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/jellyfin/jellyfin-media-player")
> +             (recursive? #t)

I don't see any submodules in the source repo. If there aren't any, you
don't need `recursive?`.

> +             (commit commit)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "0552z343i49nnhw08bifncvgs1cm4zccqwk7g9jy6gnjncs441il"))))
> +     (inputs (list alsa-lib
> +                   freetype
> +                   libxrandr
> +                   mesa
> +                   libx11
> +                   harfbuzz
> +                   qtbase-5
> +                   qtwebengine-5
> +                   qtquickcontrols-5
> +                   qtquickcontrols2-5
> +                   qtwebchannel-5
> +                   qtdeclarative-5
> +                   qtgraphicaleffects
> +                   qtx11extras
> +                   fribidi
> +                   uchardet
> +                   mpv
> +                   sdl2
> +                   libvdpau))

Inputs should generally be sorted in alphabetical order.

> +     (native-inputs (list pkg-config
> +                          python))
> +     (build-system qt-build-system)
> +     (arguments
> +      (list
> +       #:tests? #f ;No test target available
> +       #:build-type "Release"))
> +     (home-page "https://jellyfin.org")
> +     (synopsis "Jellyfin Desktop Client")

It's helpful when the synopsis conveys a bit about what the package
/is/. What is Jellyfin? Perhaps something like 'Server to collect,
manage and stream media' (just a suggestion, maybe you could come up
with something better than that).

> +     (description "Desktop client using jellyfin-web with embedded MPV player.
> +Supports Windows, Mac OS, and Linux. Media plays within the same window
> +using the jellyfin-web interface unlike Jellyfin Desktop. Supports audio passthrough.")

Description should use full sentences.

> +     (license license:gpl2))))
> +
>  (define-public transcode
>    (package
>      (name "transcode")
> -- 
> 2.49.0
>
> This patch adds jellyfin-media-player package definition.
>
> --
> - Apoorv Singh
> - Sent from Emacs.

Message #11 received at 77269 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: 77269 <at> debbugs.gnu.org
Subject: Re: [PATCH] Add jellyfin-media-player package
Date: Wed, 26 Mar 2025 12:07:42 -0700

Hi Apoorv,

I’ve had this packaged for around a year and was just getting 
things updated to submit, but you beat me to it.

Feel free to take any of my definition if it helps your patch!

https://codeberg.org/ieure/atomized-guix/src/branch/main/atomized/packages/video.scm

Thanks,

 -- Ian

Message #14 received at 77269 <at> debbugs.gnu.org (full text, mbox):

From: Apoorv Singh <apoorvs569 <at> gmail.com>
To: 77269 <at> debbugs.gnu.org
Cc: 45mg <45mg.writes <at> gmail.com>
Subject: Re: [bug#77269] [PATCH] Add jellyfin-media-player package
Date: Wed, 02 Apr 2025 12:37:45 +0530

[0001-Add-jellyfin-media-player-package.patch (text/x-patch, attachment)]

[Message part 2 (text/plain, inline)]

Here is the updated patch for jellyfin-media-player.

--
- Apoorv Singh
- Sent from Emacs.

Message #17 received at 77269 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Apoorv Singh <apoorvs569 <at> gmail.com>
Cc: 77269 <at> debbugs.gnu.org, 45mg <45mg.writes <at> gmail.com>
Subject: Re: [bug#77269] [PATCH] Add jellyfin-media-player package
Date: Sun, 20 Apr 2025 21:08:30 -0700

Hi Apoorv,

Apoorv Singh <apoorvs569 <at> gmail.com> writes:

>>From 9fd4a6013f76aa50b910d74d4dd66b4be19cd066 Mon Sep 17 
>>00:00:00 2001
> From: apoorv569 <apoorvs569 <at> gmail.com>
> Date: Wed, 26 Mar 2025 10:14:51 +0530
> Subject: [PATCH] Add jellyfin-media-player package
>
> ---
>  gnu/packages/video.scm | 50 
>  ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index 0ddfc022a9..c9fa5a0e37 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -297,6 +297,56 @@ (define (bin command)
>  user has installed.")
>      (license license:gpl3+)))
>  
> +(define-public jellyfin-media-player
> +  (let ((commit "68ddf01ecef766620d4e564cada0a1125840547f")
> +        (revision "0"))

Why package the snapshot instead of the 1.12.0 release?

> +    (package
> +     (name "jellyfin-media-player")
> +     (version (git-version "1.12.0" revision commit))
> +     (source
> +      (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url 
> "https://github.com/jellyfin/jellyfin-media-player")
> +             (commit commit)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 
> "0552z343i49nnhw08bifncvgs1cm4zccqwk7g9jy6gnjncs441il"))))
> +     (inputs (list alsa-lib
> +                   freetype
> +                   fribidi
> +                   harfbuzz
> +                   libvdpau
> +                   libx11
> +                   libxrandr
> +                   mesa
> +                   mpv
> +                   qtbase-5
> +                   qtdeclarative-5
> +                   qtgraphicaleffects
> +                   qtquickcontrols-5
> +                   qtquickcontrols2-5
> +                   qtx11extras
> +                   qtwebchannel-5
> +                   qtwebengine-5
> +                   sdl2
> +                   uchardet))
> +     (native-inputs (list pkg-config
> +                          python))
> +     (build-system qt-build-system)
> +     (arguments
> +      (list
> +       #:tests? #f ;No test target available
> +       #:build-type "Release"))
> +     (home-page "https://jellyfin.org")
> +     (synopsis "Desktop client for Jellyfin, a media streaming 
> server.")
> +     (description "Jellyfin is a server for managing and stream 
> media.

Probably best to focus on what this package is, rather than the 
server, which isn’t packaged in Guix.

> +It supports Windows, macOS, and Linux.

Please remove this, as it’s not relevant to the Guix package.

> ...Media plays within the same
> +window using the jellyfin-web interface, unlike Jellyfin 
> Desktop.

I’d also remove this, I’m not even sure what it’s saying.  The 
Jellyfin clients page[1] says this is "The official Jellyfin 
desktop client," so I don’t know what "Jellyfin Desktop" refers.

One other thing: this package has code that checks for new 
versions and prompts you to download them.  It should be disabled, 
because updates come from Guix, and these are often used as 
sources of telemetry.

Thanks,

 -- Ian

[1]: https://jellyfin.org/downloads/clients/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.