GNU bug report logs - #77290
[PATCH] gnu: Add emacs-rescript-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77290 in the body.
You can then email your comments to 77290 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: vasilii.smirnov <at> mailbox.org
To: guix-patches <at> gnu.org
Cc: Vasilii Smirnov <vasilii.smirnov <at> mailbox.org>
Subject: [PATCH] gnu: Add emacs-rescript-mode
Date: Wed, 26 Mar 2025 18:15:47 +0100

From: Vasilii Smirnov <vasilii.smirnov <at> mailbox.org>

* gnu/packages/emacs-xyz.scm (emacs-rescript-mode): New variable.

Change-Id: I52fa3e2693f62aa25ec2d97441bc3f191d46ac0b
---
 gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index da30b4776c..8133654138 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3772,6 +3772,27 @@ (define-public emacs-reformatter
 optional minor mode which can apply this command automatically on save.")
     (license license:gpl3+)))
 
+(define-public emacs-rescript-mode
+  (let ((commit "b9dda43cc52cd4a9b384c59fb0cc7a11f0bad230")
+        (revision "0"))
+    (package
+      (name "emacs-rescript-mode")
+      (version (git-version "0.0.0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/jjlee/rescript-mode")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "00pjn683zl5rcmwf86gs4ikxzz82d3rpmicpxhgy2m2xyrfxpz89"))
+                (file-name (git-file-name name version))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/jjlee/rescript-mode")
+      (synopsis "Major mode for editing ReScript")
+      (description "This package provides a major mode for editing ReScript source code.")
+      (license license:gpl3))))
+
 (define-public emacs-language-id
   (package
     (name "emacs-language-id")

base-commit: a9239a769c5611f12061c9a895e4e218b3445e2f
-- 
2.48.1

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: 77290 <at> debbugs.gnu.org, vasilii.smirnov <at> mailbox.org
Subject: Re: [bug#77290] [PATCH] gnu: Add emacs-rescript-mode
Date: Fri, 28 Mar 2025 11:14:42 +0100

[Message part 1 (text/plain, inline)]

Thanks for the patch !

Looks good to me, except for the tests, present in the repo.

Could you please activate testing of explicitly disable it for good
reason, to comply with upcoming default behaviour in emacs packages ?

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 77290 <at> debbugs.gnu.org (full text, mbox):

From: vasilii.smirnov <at> mailbox.org
To: 77290 <at> debbugs.gnu.org
Cc: Vasilii Smirnov <vasilii.smirnov <at> mailbox.org>,
 Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v1] gnu: Add emacs-rescript-mode
Date: Fri, 28 Mar 2025 15:35:13 +0100

From: Vasilii Smirnov <vasilii.smirnov <at> mailbox.org>

* gnu/packages/emacs-xyz.scm (emacs-rescript-mode): New variable.

Change-Id: I52fa3e2693f62aa25ec2d97441bc3f191d46ac0b
---
 gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index da30b4776c..2735527fac 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3772,6 +3772,33 @@ (define-public emacs-reformatter
 optional minor mode which can apply this command automatically on save.")
     (license license:gpl3+)))
 
+(define-public emacs-rescript-mode
+  (let ((commit "b9dda43cc52cd4a9b384c59fb0cc7a11f0bad230")
+        (revision "0"))
+    (package
+      (name "emacs-rescript-mode")
+      (version (git-version "0.0.0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/jjlee/rescript-mode")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "00pjn683zl5rcmwf86gs4ikxzz82d3rpmicpxhgy2m2xyrfxpz89"))
+                (file-name (git-file-name name version))))
+      (build-system emacs-build-system)
+      (arguments
+       (list
+        #:tests? #t
+        #:test-command #~(list "ert-runner")))
+      (native-inputs
+       (list emacs-ert-runner))
+      (home-page "https://github.com/jjlee/rescript-mode")
+      (synopsis "Major mode for editing ReScript")
+      (description "This package provides a major mode for editing ReScript source code.")
+      (license license:gpl3))))
+
 (define-public emacs-language-id
   (package
     (name "emacs-language-id")

base-commit: a9239a769c5611f12061c9a895e4e218b3445e2f
-- 
2.48.1

Message #17 received at 77290 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: vasilii.smirnov <at> mailbox.org
Cc: 77290 <at> debbugs.gnu.org, Cayetano Santos <csantosb <at> inventati.org>
Subject: Re: [bug#77290] [PATCH v1] gnu: Add emacs-rescript-mode
Date: Sat, 29 Mar 2025 08:13:48 -0700

Hi Vasilii,

vasilii.smirnov <at> mailbox.org writes:

> From: Vasilii Smirnov <vasilii.smirnov <at> mailbox.org>
>
> * gnu/packages/emacs-xyz.scm (emacs-rescript-mode): New 
> variable.
>
> Change-Id: I52fa3e2693f62aa25ec2d97441bc3f191d46ac0b
> ---
>  gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm 
> b/gnu/packages/emacs-xyz.scm
> index da30b4776c..2735527fac 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -3772,6 +3772,33 @@ (define-public emacs-reformatter
>  optional minor mode which can apply this command automatically 
>  on save.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-rescript-mode
> +  (let ((commit "b9dda43cc52cd4a9b384c59fb0cc7a11f0bad230")
> +        (revision "0"))
> +    (package
> +      (name "emacs-rescript-mode")
> +      (version (git-version "0.0.0" revision commit))

rescript-mode.el declares a version of 0.1.0, please use that 
instead of 0.0.0.

When you resend the patch, please make sure to send it as version 
2 -- your second patch was sent as version 1, but version 1 is 
implied for patches which don’t declare a version, and multiple 
patches with the same version can be hard to apply.

Thanks,

 -- Ian

Message #20 received at 77290 <at> debbugs.gnu.org (full text, mbox):

From: vasilii.smirnov <at> mailbox.org
To: 77290 <at> debbugs.gnu.org
Cc: Vasilii Smirnov <vasilii.smirnov <at> mailbox.org>,
 Cayetano Santos <csantosb <at> inventati.org>, Ian Eure <ian <at> retrospec.tv>
Subject: [PATCH v2] gnu: Add emacs-rescript-mode
Date: Sat, 29 Mar 2025 19:03:50 +0100

From: Vasilii Smirnov <vasilii.smirnov <at> mailbox.org>

* gnu/packages/emacs-xyz.scm (emacs-rescript-mode): New variable.

Change-Id: I52fa3e2693f62aa25ec2d97441bc3f191d46ac0b
---
 gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index da30b4776c..e2b71bc516 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3772,6 +3772,33 @@ (define-public emacs-reformatter
 optional minor mode which can apply this command automatically on save.")
     (license license:gpl3+)))
 
+(define-public emacs-rescript-mode
+  (let ((commit "b9dda43cc52cd4a9b384c59fb0cc7a11f0bad230")
+        (revision "0"))
+    (package
+      (name "emacs-rescript-mode")
+      (version (git-version "0.1.0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/jjlee/rescript-mode")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "00pjn683zl5rcmwf86gs4ikxzz82d3rpmicpxhgy2m2xyrfxpz89"))
+                (file-name (git-file-name name version))))
+      (build-system emacs-build-system)
+      (arguments
+       (list
+        #:tests? #t
+        #:test-command #~(list "ert-runner")))
+      (native-inputs
+       (list emacs-ert-runner))
+      (home-page "https://github.com/jjlee/rescript-mode")
+      (synopsis "Major mode for editing ReScript")
+      (description "This package provides a major mode for editing ReScript source code.")
+      (license license:gpl3))))
+
 (define-public emacs-language-id
   (package
     (name "emacs-language-id")

base-commit: a9239a769c5611f12061c9a895e4e218b3445e2f
-- 
2.48.1

Message #23 received at 77290 <at> debbugs.gnu.org (full text, mbox):

From: Vasilii Smirnov <vasilii.smirnov <at> mailbox.org>
To: Ian Eure <ian <at> retrospec.tv>
Cc: 77290 <at> debbugs.gnu.org, Cayetano Santos <csantosb <at> inventati.org>
Subject: Re: [bug#77290] [PATCH v1] gnu: Add emacs-rescript-mode
Date: Sat, 29 Mar 2025 19:23:51 +0100

On 3/29/25 16:13, Ian Eure wrote:
> rescript-mode.el declares a version of 0.1.0, please use that instead of
> 0.0.0.

Thanks, I didn't notice the version in the comments. Although, it's been
at "0.1.0" from like the second commit...

> When you resend the patch, please make sure to send it as version 2 --
> your second patch was sent as version 1, but version 1 is implied for
> patches which don’t declare a version, and multiple patches with the
> same version can be hard to apply.

Damn, I always forget where to start from 0 and where from 1. Sorry.

Message #26 received at 77290 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Vasilii Smirnov <vasilii.smirnov <at> mailbox.org>
Cc: 77290 <at> debbugs.gnu.org, Cayetano Santos <csantosb <at> inventati.org>
Subject: Re: [bug#77290] [PATCH v1] gnu: Add emacs-rescript-mode
Date: Sat, 29 Mar 2025 12:08:25 -0700

Hi Vasilii,

Vasilii Smirnov <vasilii.smirnov <at> mailbox.org> writes:

> On 3/29/25 16:13, Ian Eure wrote:
>> rescript-mode.el declares a version of 0.1.0, please use that 
>> instead of
>> 0.0.0.
>
> Thanks, I didn't notice the version in the comments. Although, 
> it's been
> at "0.1.0" from like the second commit...
>
>> When you resend the patch, please make sure to send it as 
>> version 2 --
>> your second patch was sent as version 1, but version 1 is 
>> implied for
>> patches which don’t declare a version, and multiple patches 
>> with the
>> same version can be hard to apply.
>
> Damn, I always forget where to start from 0 and where from 
> 1. Sorry.

Thanks for the quick turnaround.  Pushed as d219e38a41.

-- Ian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.