GNU logs - #77315, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77315: 31.0.50; Crash in Finsert_file_contents, file size changed
Resent-From: Pip Cet <pipcet@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 27 Mar 2025 15:36:02 +0000
Resent-Message-ID: <handler.77315.B.174308970310360 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77315 <at> debbugs.gnu.org
Date: Thu, 27 Mar 2025 15:34:31 +0000
From: Pip Cet <pipcet@HIDDEN>
Message-ID: <8734eyqyho.fsf@HIDDEN>
Feedback-ID: 112775352:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=185.70.43.22; envelope-from=pipcet@HIDDEN;
 helo=mail-4322.protonmail.ch
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

I experienced a crash on the feature/igc branch (unfortunately, with
local modifications) in a long-running session.  I still have the (very
large) coredump file so I can do some limited post-mortem debugging of
the session, but I think I've identified the bug and we can just fix it
instead.

Note that line numbers will probably be off in the backtrace because of
the local modifications.

The crash happened when a buffer showing config.log in an Emacs
directory auto-reverted while I was running ./configure in that
directory in another shell buffer.

After looking at this more closely, I think it's a bug in
Finsert_file_contents, which currently assumes that a call to
emacs_fd_fstat establishes st_size as an upper limit of how many
characters read from the beginning of the file can match the current
buffer.

Most likely, the race window is so small that this happens only very
rarely on the master branch, but feature/igc introduces the occasional
unexpected delay so is more vulnerable to such bugs (see also
bug#74590, which also is most likely explained by a delay introduced by
MPS exposing a previously-latent bug).  However, I believe this isn't
likely to be an MPS-specific bug.

The crash happened in this line/call in fileio.c:

=09  if (overlap > 0)
=09    same_at_end +=3D overlap;
=09  same_at_end_charpos =3D BYTE_TO_CHAR (same_at_end); <<<<<< HERE

=09  /* Arrange to read only the nonmatching middle part of the file.  */
=09  beg_offset +=3D same_at_start - BEGV_BYTE;
=09  end_offset -=3D ZV_BYTE - same_at_end;

At the time:

        same_at_start =3D 38706
        same_at_end =3D 1499444
        overlap =3D 25
        replace_handled =3D false
        giveup_match_end =3D false
        regular =3D true
        coding =3D {

        st =3D {
          st_size =3D 38681,
        }

        current_buffer->text->z_byte =3D 1499420
        end =3D Qnil
        current_buffer->text->gpt =3D 1399068
        current_buffer->text->beg + 38681 =3D "configure:10959: $? =3D 0\nc=
onfigure:10996: result: none needed\n..."

        coding =3D {
          id =3D 1,
          result =3D CODING_RESULT_SUCCESS,
          decoder =3D 0x5555556c7f6c <decode_coding_raw_text>,
          encoder =3D 0x5555556c80c1 <encode_coding_raw_text>
        }

So the BYTE_TO_CHAR failed because same_at_end was out of range after
overlap was added to it.  Given the calculation of overlap as:

=09  overlap =3D (same_at_start - BEGV_BYTE
=09=09     - (same_at_end
=09=09=09+ (! NILP (end) ? end_offset : st.st_size) - ZV_BYTE));

I believe the intention was for same_at_start - BEGV_BYTE never to
exceed st.st_size or end_offset (the two are the same here).  See below
for why I think that the overlap calculation should also subtract
beg_offset from this value.

same_at_start is set here:

=09  int nread =3D emacs_fd_read (fd, read_buf, sizeof read_buf);
=09  int bufpos =3D 0;
=09  while (bufpos < nread && same_at_start < ZV_BYTE
=09=09 && FETCH_BYTE (same_at_start) =3D=3D read_buf[bufpos])
=09    same_at_start++, bufpos++;

which is called some time after:

  if (emacs_fd_fstat (fd, &st) !=3D 0)
    report_file_error ("Input file status", orig_filename);

so it seems entirely possible to me that the file grew by the time we
set same_at_start, leading to the backtrace.

The extra text written appears to have been

    "configure:10959: $? =3D 0\n"

My impression is that overlap should have been calculated as 0 (or a
negative number), not 25, because only one byte matches at the end of
the buffer (which ends in "s\n") and same_at_end was thus, rightfully,
1494419, one less than Z_BYTE =3D ZV_BYTE.

This code is very hard to understand; I believe that's because it
doesn't currently always do the right thing, particularly not if st_size
changes.  However, a preliminary suggestion for fixing this follows:

Let's add an additional condition to the loop counting bytes for
same_at_start, so it never exceeds end_offset - beg_offset + BEGV_BYTE,
and a symmetric condition in the loop counting bytes for same_at_end, so
it never becomes less than ZV_BYTE - (end_offset - beg_offset -
same_at_start + BEGV_BYTE).

This would fix both this bug and what seems to me to be a faulty
calculation, failing to detect an overlap, in the case where beg_offset
is !=3D 0.

IOW, we would fix the overlap calculation and make it so no overlap can
ever happen, after which the overlap code can be removed.

In addition, this code:

      /* If the file matches the buffer completely,
=09 there's no need to replace anything.  */
      if (same_at_start - BEGV_BYTE =3D=3D end_offset - beg_offset)
=09{
=09  emacs_fd_close (fd);
=09  clear_unwind_protect (fd_index);

=09  /* Truncate the buffer to the size of the file.  */
=09  del_range_1 (same_at_start, same_at_end, 0, 0);
=09  goto handled;
=09}

confuses me, because same_at_start and same_at_end are byte positions
and del_range_1 takes character positions.  I expect it's hit very
rarely except when same_at_start =3D=3D same_at_end or same_at_start =3D=3D
BEGV_BYTE =3D=3D BEGV, and del_range_1 is forgiving in these cases.

Backtrace:

#0  terminate_due_to_signal (sig=3D6, backtrace_limit=3D2147483647) at emac=
s.c:425
#1  0x000055555587f71b in die (msg=3D0x555555a597b8 "BUF_BEG_BYTE (b) <=3D =
bytepos && bytepos <=3D BUF_Z_BYTE (b)", file=3D0x555555a5974c "marker.c", =
line=3D330)
    at alloc.c:8064
#2  0x000055555581e011 in buf_bytepos_to_charpos (b=3D0x7ff8ef791a58, bytep=
os=3D1499444) at marker.c:330
#3  0x0000555555829246 in BYTE_TO_CHAR (bytepos=3D1499444) at /home/pip/ema=
cs-20250320/src/buffer.h:1204
#4  0x0000555555833950 in Finsert_file_contents (filename=3D0x7ff8ef797af5,=
 visit=3D0x38, beg=3D0x0, end=3D0x0, replace=3D0xc908) at fileio.c:4547

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Pip Cet <pipcet@HIDDEN>
Subject: bug#77315: Acknowledgement (31.0.50; Crash in Finsert_file_contents,
 file size changed)
Message-ID: <handler.77315.B.174308970310360.ack <at> debbugs.gnu.org>
References: <8734eyqyho.fsf@HIDDEN>
X-Gnu-PR-Message: ack 77315
X-Gnu-PR-Package: emacs
Reply-To: 77315 <at> debbugs.gnu.org
Date: Thu, 27 Mar 2025 15:36:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 77315 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
77315: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77315
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77315: 31.0.50; Crash in Finsert_file_contents, file size changed
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 27 Mar 2025 16:22:04 +0000
Resent-Message-ID: <handler.77315.B77315.17430925056377 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Pip Cet <pipcet@HIDDEN>, Paul Eggert <eggert@HIDDEN>
Cc: 77315 <at> debbugs.gnu.org
Date: Thu, 27 Mar 2025 18:21:31 +0200
Message-Id: <86v7rubg1g.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <8734eyqyho.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN)
References: <8734eyqyho.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Date: Thu, 27 Mar 2025 15:34:31 +0000
> From:  Pip Cet via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> 
> I experienced a crash on the feature/igc branch (unfortunately, with
> local modifications) in a long-running session.  I still have the (very
> large) coredump file so I can do some limited post-mortem debugging of
> the session, but I think I've identified the bug and we can just fix it
> instead.
> 
> Note that line numbers will probably be off in the backtrace because of
> the local modifications.
> 
> The crash happened when a buffer showing config.log in an Emacs
> directory auto-reverted while I was running ./configure in that
> directory in another shell buffer.
> 
> After looking at this more closely, I think it's a bug in
> Finsert_file_contents, which currently assumes that a call to
> emacs_fd_fstat establishes st_size as an upper limit of how many
> characters read from the beginning of the file can match the current
> buffer.
> 
> Most likely, the race window is so small that this happens only very
> rarely on the master branch, but feature/igc introduces the occasional
> unexpected delay so is more vulnerable to such bugs (see also
> bug#74590, which also is most likely explained by a delay introduced by
> MPS exposing a previously-latent bug).  However, I believe this isn't
> likely to be an MPS-specific bug.

Adding Paul to the discussion.

AFAIR, insert-file-contents needs to be completely rewritten to handle
such situations.  If the file is being modified by another program
while we are trying to figure out the overlap (because REPLACE was
no-nil), then I'm not sure I understand how can REPLACE and overlap
work at all, since the data changes under our feet as we go.  So maybe
if we detect that this is happening, we should give up on being smart
and decide that there's no overlap at all.

> The crash happened in this line/call in fileio.c:
> 
> 	  if (overlap > 0)
> 	    same_at_end += overlap;
> 	  same_at_end_charpos = BYTE_TO_CHAR (same_at_end); <<<<<< HERE
> 
> 	  /* Arrange to read only the nonmatching middle part of the file.  */
> 	  beg_offset += same_at_start - BEGV_BYTE;
> 	  end_offset -= ZV_BYTE - same_at_end;
> 
> At the time:
> 
>         same_at_start = 38706
>         same_at_end = 1499444
>         overlap = 25
>         replace_handled = false
>         giveup_match_end = false
>         regular = true
>         coding = {
> 
>         st = {
>           st_size = 38681,
>         }
> 
>         current_buffer->text->z_byte = 1499420
>         end = Qnil
>         current_buffer->text->gpt = 1399068
>         current_buffer->text->beg + 38681 = "configure:10959: $? = 0\nconfigure:10996: result: none needed\n..."
> 
>         coding = {
>           id = 1,
>           result = CODING_RESULT_SUCCESS,
>           decoder = 0x5555556c7f6c <decode_coding_raw_text>,
>           encoder = 0x5555556c80c1 <encode_coding_raw_text>
>         }
> 
> So the BYTE_TO_CHAR failed because same_at_end was out of range after
> overlap was added to it.  Given the calculation of overlap as:
> 
> 	  overlap = (same_at_start - BEGV_BYTE
> 		     - (same_at_end
> 			+ (! NILP (end) ? end_offset : st.st_size) - ZV_BYTE));
> 
> I believe the intention was for same_at_start - BEGV_BYTE never to
> exceed st.st_size or end_offset (the two are the same here).  See below
> for why I think that the overlap calculation should also subtract
> beg_offset from this value.
> 
> same_at_start is set here:
> 
> 	  int nread = emacs_fd_read (fd, read_buf, sizeof read_buf);
> 	  int bufpos = 0;
> 	  while (bufpos < nread && same_at_start < ZV_BYTE
> 		 && FETCH_BYTE (same_at_start) == read_buf[bufpos])
> 	    same_at_start++, bufpos++;
> 
> which is called some time after:
> 
>   if (emacs_fd_fstat (fd, &st) != 0)
>     report_file_error ("Input file status", orig_filename);
> 
> so it seems entirely possible to me that the file grew by the time we
> set same_at_start, leading to the backtrace.
> 
> The extra text written appears to have been
> 
>     "configure:10959: $? = 0\n"
> 
> My impression is that overlap should have been calculated as 0 (or a
> negative number), not 25, because only one byte matches at the end of
> the buffer (which ends in "s\n") and same_at_end was thus, rightfully,
> 1494419, one less than Z_BYTE = ZV_BYTE.
> 
> This code is very hard to understand; I believe that's because it
> doesn't currently always do the right thing, particularly not if st_size
> changes.  However, a preliminary suggestion for fixing this follows:
> 
> Let's add an additional condition to the loop counting bytes for
> same_at_start, so it never exceeds end_offset - beg_offset + BEGV_BYTE,
> and a symmetric condition in the loop counting bytes for same_at_end, so
> it never becomes less than ZV_BYTE - (end_offset - beg_offset -
> same_at_start + BEGV_BYTE).
> 
> This would fix both this bug and what seems to me to be a faulty
> calculation, failing to detect an overlap, in the case where beg_offset
> is != 0.
> 
> IOW, we would fix the overlap calculation and make it so no overlap can
> ever happen, after which the overlap code can be removed.
> 
> In addition, this code:
> 
>       /* If the file matches the buffer completely,
> 	 there's no need to replace anything.  */
>       if (same_at_start - BEGV_BYTE == end_offset - beg_offset)
> 	{
> 	  emacs_fd_close (fd);
> 	  clear_unwind_protect (fd_index);
> 
> 	  /* Truncate the buffer to the size of the file.  */
> 	  del_range_1 (same_at_start, same_at_end, 0, 0);
> 	  goto handled;
> 	}
> 
> confuses me, because same_at_start and same_at_end are byte positions
> and del_range_1 takes character positions.  I expect it's hit very
> rarely except when same_at_start == same_at_end or same_at_start ==
> BEGV_BYTE == BEGV, and del_range_1 is forgiving in these cases.
> 
> Backtrace:
> 
> #0  terminate_due_to_signal (sig=6, backtrace_limit=2147483647) at emacs.c:425
> #1  0x000055555587f71b in die (msg=0x555555a597b8 "BUF_BEG_BYTE (b) <= bytepos && bytepos <= BUF_Z_BYTE (b)", file=0x555555a5974c "marker.c", line=330)
>     at alloc.c:8064
> #2  0x000055555581e011 in buf_bytepos_to_charpos (b=0x7ff8ef791a58, bytepos=1499444) at marker.c:330
> #3  0x0000555555829246 in BYTE_TO_CHAR (bytepos=1499444) at /home/pip/emacs-20250320/src/buffer.h:1204
> #4  0x0000555555833950 in Finsert_file_contents (filename=0x7ff8ef797af5, visit=0x38, beg=0x0, end=0x0, replace=0xc908) at fileio.c:4547
> 
> 
> 
> 
>

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77315: 31.0.50; Crash in Finsert_file_contents, file size changed
Resent-From: Paul Eggert <eggert@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 27 Mar 2025 17:24:02 +0000
Resent-Message-ID: <handler.77315.B77315.174309618432235 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Eli Zaretskii <eliz@HIDDEN>, Pip Cet <pipcet@HIDDEN>
Cc: 77315 <at> debbugs.gnu.org
Message-ID: <324123b5-a4e7-44da-b778-debf71b9efc4@HIDDEN>
Date: Thu, 27 Mar 2025 11:22:48 -0600
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
References: <8734eyqyho.fsf@HIDDEN> <86v7rubg1g.fsf@HIDDEN>
Content-Language: en-US
From: Paul Eggert <eggert@HIDDEN>
In-Reply-To: <86v7rubg1g.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 3/27/25 10:21, Eli Zaretskii wrote:
> AFAIR, insert-file-contents needs to be completely rewritten to handle
> such situations.

I drafted something a while ago along those lines but never got around 
to finish it. I'll try to bump the priority.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#77315: 31.0.50; Crash in Finsert_file_contents, file size changed
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 27 Mar 2025 17:49:02 +0000
Resent-Message-ID: <handler.77315.B77315.174309769621182 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Paul Eggert <eggert@HIDDEN>
Cc: 77315 <at> debbugs.gnu.org, pipcet@HIDDEN
Received: via spool by 77315-submit <at> debbugs.gnu.org id=B77315.174309769621182
          (code B ref 77315); Thu, 27 Mar 2025 17:49:02 +0000
Received: (at 77315) by debbugs.gnu.org; 27 Mar 2025 17:48:16 +0000
Received: from localhost ([127.0.0.1]:51230 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1txrKy-0005Va-5P
	for submit <at> debbugs.gnu.org; Thu, 27 Mar 2025 13:48:16 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:44468)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1txrKu-0005V0-SY
 for 77315 <at> debbugs.gnu.org; Thu, 27 Mar 2025 13:48:13 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1txrKo-0006ys-5j; Thu, 27 Mar 2025 13:48:06 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=Qp4Xh08wU0cu5bG00licI8hDOyGcXnL8R8xBKkWQhUw=; b=Vx8NBJsXTnOf
 SWU9t/QvMcEWn2IMe4t8gvjyO8zmWxf5k60N+6l0NBn6Ql6ym8KlvswxIcygC7svMCL0LeGZZiKN0
 2fyGAyKCUS4ZYgJI7ZI4FQxKbk+XiMxxpSzPsXj4pVfHUaIjBXWixeMVq5O35fx1/79YhwPAW3IzC
 AlEijHGFYF4RBXLnCDcmfPYEg2+74PpPhzBu/SSfAck5CRHFcJoNi0Ze8nMad74pVD3U2FFMh0Dxy
 SfRjdynKnjEdTkY0BJ46rMqowwXvIocJ6voysJnGYkSbrukLYP45112qTckOGRQcmxgHfL5D3ArEA
 sr0DRQPnjI7xCwY3Tkmmmw==;
Date: Thu, 27 Mar 2025 19:48:02 +0200
Message-Id: <86ldsqbc19.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <324123b5-a4e7-44da-b778-debf71b9efc4@HIDDEN> (message from
 Paul Eggert on Thu, 27 Mar 2025 11:22:48 -0600)
References: <8734eyqyho.fsf@HIDDEN> <86v7rubg1g.fsf@HIDDEN>
 <324123b5-a4e7-44da-b778-debf71b9efc4@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Thu, 27 Mar 2025 11:22:48 -0600
> Cc: 77315 <at> debbugs.gnu.org
> From: Paul Eggert <eggert@HIDDEN>
> 
> On 3/27/25 10:21, Eli Zaretskii wrote:
> > AFAIR, insert-file-contents needs to be completely rewritten to handle
> > such situations.
> 
> I drafted something a while ago along those lines but never got around 
> to finish it. I'll try to bump the priority.

Thanks in advance.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#77315: 31.0.50; Crash in Finsert_file_contents, file size changed
Resent-From: Pip Cet <pipcet@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 27 Mar 2025 19:18:01 +0000
Resent-Message-ID: <handler.77315.B77315.174310307923501 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Paul Eggert <eggert@HIDDEN>
Cc: 77315 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 77315-submit <at> debbugs.gnu.org id=B77315.174310307923501
          (code B ref 77315); Thu, 27 Mar 2025 19:18:01 +0000
Received: (at 77315) by debbugs.gnu.org; 27 Mar 2025 19:17:59 +0000
Received: from localhost ([127.0.0.1]:51391 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1txsjn-00066z-1X
	for submit <at> debbugs.gnu.org; Thu, 27 Mar 2025 15:17:59 -0400
Received: from mail-10629.protonmail.ch ([79.135.106.29]:44457)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>)
 id 1txsji-00066h-Qt
 for 77315 <at> debbugs.gnu.org; Thu, 27 Mar 2025 15:17:56 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
 s=protonmail3; t=1743103068; x=1743362268;
 bh=KLX5FrfAuVDFZxN9aeapU/VpRzItjOifOdlV/40Gszk=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
 b=HO8vrQJupOHpNKfxvlr31AEWsaavGDLV5adxWROhYVSp54apnffuzXuAfG0WJjsvT
 F7OHkaKxkOkO1y/zciQScIszuvfqKCDcWoK0i5ZGVXmh4h6W5W0zuFOMdDSePe2Ygb
 bO2vjlXlC9HlhCMgXlNtOnvAncYtJPlnzlK5QRqV9dnsmGUCPON/L+WvzfEVOaOh3v
 UhrQfX+AdIEZCFR3MBgKuazIaffEL1tPCNWe8nT6EfzTF8jEQVD2OnjJ2f2yQgKSWx
 nhkeugTpk9N5ZGhBYJXkDhVrqWi8MC6fjS4LbC3jTP/A7TT/HWBVW2VwPbwBJ4fKD1
 JPWyp04jAMnhQ==
Date: Thu, 27 Mar 2025 19:17:45 +0000
From: Pip Cet <pipcet@HIDDEN>
Message-ID: <871pui8erw.fsf@HIDDEN>
In-Reply-To: <324123b5-a4e7-44da-b778-debf71b9efc4@HIDDEN>
References: <8734eyqyho.fsf@HIDDEN> <86v7rubg1g.fsf@HIDDEN>
 <324123b5-a4e7-44da-b778-debf71b9efc4@HIDDEN>
Feedback-ID: 112775352:user:proton
X-Pm-Message-ID: 6cda6a05804800c142c01a89fd05d35aeffa1aa2
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

"Paul Eggert" <eggert@HIDDEN> writes:

> On 3/27/25 10:21, Eli Zaretskii wrote:
>> AFAIR, insert-file-contents needs to be completely rewritten to handle
>> such situations.
>
> I drafted something a while ago along those lines but never got around
> to finish it. I'll try to bump the priority.

Thank you both!  I'll wait, then.  I'm perfectly happy reading "random"
data if a file is changed while being read, FWIW, but I see no reason to
crash, and it's also somewhat undesirable to throw an error in this
situation.

Pip

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#77315: 31.0.50; Crash in Finsert_file_contents, file size changed
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 13 Apr 2025 07:14:03 +0000
Resent-Message-ID: <handler.77315.B77315.17445283943166 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: eggert@HIDDEN
Cc: 77315 <at> debbugs.gnu.org, pipcet@HIDDEN
Received: via spool by 77315-submit <at> debbugs.gnu.org id=B77315.17445283943166
          (code B ref 77315); Sun, 13 Apr 2025 07:14:03 +0000
Received: (at 77315) by debbugs.gnu.org; 13 Apr 2025 07:13:14 +0000
Received: from localhost ([127.0.0.1]:37847 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u3rWh-0000oe-N8
	for submit <at> debbugs.gnu.org; Sun, 13 Apr 2025 03:13:13 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:60790)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1u3rWc-0000mV-5w
 for 77315 <at> debbugs.gnu.org; Sun, 13 Apr 2025 03:13:08 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1u3rWW-00014C-3Y; Sun, 13 Apr 2025 03:13:00 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=WpOTmM1Eq0ooAp/Z9tkEqsSUegMkT0gq47fZ5TEJE4I=; b=eRrN+um28Xh+
 W5r7myNfhdIzgvP6Yxc3EsITyGwv+vgkJgUmOSPdrQt+PdLobMunxy34wptJgIWm1wwuJ/Sl8Ovwb
 iyf7ZQROUO98ZBP/5Oq76owOzdj8lDeAC8O+qkIMvVZ3AJADZu5MYzSGUXHe90NogdZTWQuceSYgR
 ZO5q71C49yOWwn1HYptFIBNfosGcY3zE4ToOgZLy5pxTX+FTEVOrWOOAC5MJsnKg46Idg/ZEUnpiY
 nP/kougDRWYNmLPuh6FNR7KdKoxVdswdNMHjZaPSk5UZWh8a4gyMZIrb6kCLQB5EeRbkDV4nQJUWY
 5pGpUZxdqF+hOrGrf1RIcw==;
Date: Sun, 13 Apr 2025 10:12:57 +0300
Message-Id: <86tt6slekm.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <86ldsqbc19.fsf@HIDDEN> (message from Eli Zaretskii on Thu, 27
 Mar 2025 19:48:02 +0200)
References: <8734eyqyho.fsf@HIDDEN> <86v7rubg1g.fsf@HIDDEN>
 <324123b5-a4e7-44da-b778-debf71b9efc4@HIDDEN> <86ldsqbc19.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 77315 <at> debbugs.gnu.org, pipcet@HIDDEN
> Date: Thu, 27 Mar 2025 19:48:02 +0200
> From: Eli Zaretskii <eliz@HIDDEN>
> 
> > Date: Thu, 27 Mar 2025 11:22:48 -0600
> > Cc: 77315 <at> debbugs.gnu.org
> > From: Paul Eggert <eggert@HIDDEN>
> > 
> > On 3/27/25 10:21, Eli Zaretskii wrote:
> > > AFAIR, insert-file-contents needs to be completely rewritten to handle
> > > such situations.
> > 
> > I drafted something a while ago along those lines but never got around 
> > to finish it. I'll try to bump the priority.
> 
> Thanks in advance.

Did you have a chance to make some progress in this matter?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#77315: 31.0.50; Crash in Finsert_file_contents, file size changed
Resent-From: Paul Eggert <eggert@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 14 Apr 2025 18:54:02 +0000
Resent-Message-ID: <handler.77315.B77315.174465683014823 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 77315 <at> debbugs.gnu.org, pipcet@HIDDEN
Received: via spool by 77315-submit <at> debbugs.gnu.org id=B77315.174465683014823
          (code B ref 77315); Mon, 14 Apr 2025 18:54:02 +0000
Received: (at 77315) by debbugs.gnu.org; 14 Apr 2025 18:53:50 +0000
Received: from localhost ([127.0.0.1]:49069 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u4OwI-0003r1-AR
	for submit <at> debbugs.gnu.org; Mon, 14 Apr 2025 14:53:50 -0400
Received: from mail.cs.ucla.edu ([131.179.128.66]:44278)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eggert@HIDDEN>)
 id 1u4OwF-0003qf-HD
 for 77315 <at> debbugs.gnu.org; Mon, 14 Apr 2025 14:53:47 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.cs.ucla.edu (Postfix) with ESMTP id 2F8753C01086B;
 Mon, 14 Apr 2025 11:53:41 -0700 (PDT)
Received: from mail.cs.ucla.edu ([127.0.0.1])
 by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP
 id FPuwdc6vSEAs; Mon, 14 Apr 2025 11:53:41 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
 by mail.cs.ucla.edu (Postfix) with ESMTP id DF8073C01086F;
 Mon, 14 Apr 2025 11:53:40 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu DF8073C01086F
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu;
 s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1744656820;
 bh=S3WtbqbB290BaWmZQmFxRFUuq/al68greS7Aam9pcGw=;
 h=Message-ID:Date:MIME-Version:To:From;
 b=mXbGmAukMGPdVwmnugxSwsTtoxaORTNIcUh/JFhTiqL/9rMba5Qj3V5S11xwp5z4A
 4rK55zxftMCvaQlYknvwiLZrOjR4eBnA1lluMEShuL9heD7nXFHYk61UCPpC87zeOO
 tBrrqc++rh41PyNuGa/t2IUcEaGrAhIlhAzoIPQAeTX0jAyYN6KmCDvE8euMrXciXv
 8vNezg3z2oC7H69lHWyz+t92jSqqycEUblWS4jquxRbbmTRjc9kAC8Zcc1HqV9hzD2
 4A1ZVNiw7hwoEBFtvIUTSHGYaugYj0Bui6gBI1/98d0b68bvXCuWJ1sRnVRKgLB8HT
 AWTOgBREu69Wg==
X-Virus-Scanned: amavis at mail.cs.ucla.edu
Received: from mail.cs.ucla.edu ([127.0.0.1])
 by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP
 id 7dU7VqZE5mTf; Mon, 14 Apr 2025 11:53:40 -0700 (PDT)
Received: from [192.168.254.12] (unknown [47.147.225.25])
 by mail.cs.ucla.edu (Postfix) with ESMTPSA id C1A573C01086B;
 Mon, 14 Apr 2025 11:53:40 -0700 (PDT)
Message-ID: <deba4ff5-61db-4c90-999c-b69e0709bdc9@HIDDEN>
Date: Mon, 14 Apr 2025 11:53:40 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
References: <8734eyqyho.fsf@HIDDEN> <86v7rubg1g.fsf@HIDDEN>
 <324123b5-a4e7-44da-b778-debf71b9efc4@HIDDEN> <86ldsqbc19.fsf@HIDDEN>
 <86tt6slekm.fsf@HIDDEN>
Content-Language: en-US
From: Paul Eggert <eggert@HIDDEN>
Organization: UCLA Computer Science Department
In-Reply-To: <86tt6slekm.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 2025-04-13 00:12, Eli Zaretskii wrote:
>>> I drafted something a while ago along those lines but never got around
>>> to finish it. I'll try to bump the priority.
>> Thanks in advance.
> Did you have a chance to make some progress in this matter?

Not yet. Still on my list of things to do (but below filing taxes...).

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#77315: 31.0.50; Crash in Finsert_file_contents, file size changed
Resent-From: Pip Cet <pipcet@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 07 Jun 2025 10:53:02 +0000
Resent-Message-ID: <handler.77315.B77315.174929353426460 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 77315 <at> debbugs.gnu.org, eggert@HIDDEN
Received: via spool by 77315-submit <at> debbugs.gnu.org id=B77315.174929353426460
          (code B ref 77315); Sat, 07 Jun 2025 10:53:02 +0000
Received: (at 77315) by debbugs.gnu.org; 7 Jun 2025 10:52:14 +0000
Received: from localhost ([127.0.0.1]:47115 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uNr9q-0006si-8o
	for submit <at> debbugs.gnu.org; Sat, 07 Jun 2025 06:52:14 -0400
Received: from mail-24417.protonmail.ch ([109.224.244.17]:20043)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>)
 id 1uNr9n-0006sL-LU
 for 77315 <at> debbugs.gnu.org; Sat, 07 Jun 2025 06:52:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
 s=protonmail3; t=1749293525; x=1749552725;
 bh=CPozf+OkbEKXp/LjGrTaDyXtV4RrGQpKKjcjnkbvqdM=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
 b=mY4A5D7/gddsZXSCpO+tJKIFlljcqaHDoPG39EBrGIdjCzXUcje7HDQ49gN8ntEpZ
 Q14xeEl+oiv7IlJIA/l5hksw96jsLOchTC+AzNXLs6lOzvQiBZ13sZualSKVqUaxzO
 hSncr6SMimzRpSlSlwrU9vwUH1ZEiojSA5mnYxekJb1fttuPzOj0nh8xvV2PAXGMi+
 Z+zXSyzLI80d2s68wFZR3Cu596KqJ4pmjWW1AIWdRc5N1qKUwg0OdsBPPL3BOR4fVF
 Bikm+7DqW2voVisNzx6qRe6g1wqoLYXtmXramFWCqKV0JA6cjcPvygPbNm2KabAnJ5
 8My4kvhOOZHxg==
Date: Sat, 07 Jun 2025 10:52:00 +0000
From: Pip Cet <pipcet@HIDDEN>
Message-ID: <87v7p76cz7.fsf@HIDDEN>
In-Reply-To: <86tt6slekm.fsf@HIDDEN>
References: <8734eyqyho.fsf@HIDDEN> <86v7rubg1g.fsf@HIDDEN>
 <324123b5-a4e7-44da-b778-debf71b9efc4@HIDDEN> <86ldsqbc19.fsf@HIDDEN>
 <86tt6slekm.fsf@HIDDEN>
Feedback-ID: 112775352:user:proton
X-Pm-Message-ID: afba6acd902d6984f908c1394a60a043ef1b168b
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

"Eli Zaretskii" <eliz@HIDDEN> writes:

>> Cc: 77315 <at> debbugs.gnu.org, pipcet@HIDDEN
>> Date: Thu, 27 Mar 2025 19:48:02 +0200
>> From: Eli Zaretskii <eliz@HIDDEN>
>>
>> > Date: Thu, 27 Mar 2025 11:22:48 -0600
>> > Cc: 77315 <at> debbugs.gnu.org
>> > From: Paul Eggert <eggert@HIDDEN>
>> >
>> > On 3/27/25 10:21, Eli Zaretskii wrote:
>> > > AFAIR, insert-file-contents needs to be completely rewritten to hand=
le
>> > > such situations.
>> >
>> > I drafted something a while ago along those lines but never got around
>> > to finish it. I'll try to bump the priority.
>>
>> Thanks in advance.
>
> Did you have a chance to make some progress in this matter?

I'm hitting this bug with some regularity (and working around it by
force-returning from Finsert_file_contents in gdb) on the MPS branch.
It's not a problem, but I am occasionally reminded it's still there :-)

Pip

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#77315: 31.0.50; Crash in Finsert_file_contents, file size changed
Resent-From: Paul Eggert <eggert@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 07 Jun 2025 17:25:01 +0000
Resent-Message-ID: <handler.77315.B77315.17493170927940 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Pip Cet <pipcet@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>
Cc: 77315 <at> debbugs.gnu.org
Received: via spool by 77315-submit <at> debbugs.gnu.org id=B77315.17493170927940
          (code B ref 77315); Sat, 07 Jun 2025 17:25:01 +0000
Received: (at 77315) by debbugs.gnu.org; 7 Jun 2025 17:24:52 +0000
Received: from localhost ([127.0.0.1]:49466 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uNxHo-000240-2G
	for submit <at> debbugs.gnu.org; Sat, 07 Jun 2025 13:24:52 -0400
Received: from mail.cs.ucla.edu ([131.179.128.66]:34420)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eggert@HIDDEN>)
 id 1uNxHl-00023m-NN
 for 77315 <at> debbugs.gnu.org; Sat, 07 Jun 2025 13:24:50 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.cs.ucla.edu (Postfix) with ESMTP id 71B183C010860;
 Sat,  7 Jun 2025 10:24:43 -0700 (PDT)
Received: from mail.cs.ucla.edu ([127.0.0.1])
 by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP
 id s2IWx1bczkh2; Sat,  7 Jun 2025 10:24:43 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
 by mail.cs.ucla.edu (Postfix) with ESMTP id 48FB73C0149CF;
 Sat,  7 Jun 2025 10:24:43 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 48FB73C0149CF
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu;
 s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1749317083;
 bh=CuGaPsxkpXfEyNyirOxDSLxZ6hT4JUiIkcscYexQ9ZQ=;
 h=Message-ID:Date:MIME-Version:To:From;
 b=q4C7i3Cnke4oK+Krx28RG8jjWHXxblfJPPgpegUCXzm06vz2ibbAQFejDurrEf8XK
 FtlwRqbc2m4wSeGs6NOTDuPsD8Ga+TqO3Tw3pfkf0lCB1hAQRogjO9YPS+oiVDNp1d
 DMGdZ1rNTfBxJeofxbcHaGhLGkpDQTd4WUp8EvPzVZDK0/53TrIvDSOSuT1sh7QJi7
 nUalCaO69WWA26UZpVdOtKch7o6hnmFZfTO0YygjVhoE7BTqY+PaRzyq5Mih/RyZ5Y
 fmt23PVgoY3yTXYgG4RWJ3YuDljH085UdjnaUxSWDPEUjl+wKU2UJOeloVxLqfMyh1
 Ljnlp/GiE7Cwg==
X-Virus-Scanned: amavis at mail.cs.ucla.edu
Received: from mail.cs.ucla.edu ([127.0.0.1])
 by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP
 id ElFlavh3xocx; Sat,  7 Jun 2025 10:24:43 -0700 (PDT)
Received: from penguin.cs.ucla.edu
 (47-143-215-226.fdr01.snmn.ca.ip.frontiernet.net [47.143.215.226])
 by mail.cs.ucla.edu (Postfix) with ESMTPSA id 27BC93C010860;
 Sat,  7 Jun 2025 10:24:43 -0700 (PDT)
Message-ID: <33a8fa44-7c67-4dec-bbd3-45a7652ef87b@HIDDEN>
Date: Sat, 7 Jun 2025 10:24:42 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
References: <8734eyqyho.fsf@HIDDEN> <86v7rubg1g.fsf@HIDDEN>
 <324123b5-a4e7-44da-b778-debf71b9efc4@HIDDEN> <86ldsqbc19.fsf@HIDDEN>
 <86tt6slekm.fsf@HIDDEN> <87v7p76cz7.fsf@HIDDEN>
Content-Language: en-US
From: Paul Eggert <eggert@HIDDEN>
Organization: UCLA Computer Science Department
In-Reply-To: <87v7p76cz7.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 2025-06-07 03:52, Pip Cet wrote:
> I'm hitting this bug with some regularity (and working around it by
> force-returning from Finsert_file_contents in gdb) on the MPS branch.
> It's not a problem, but I am occasionally reminded it's still there :-)

Yes, sorry, I've been crunched doing real work. I have one issue to 
attend to with GNU 'factor' and then this is my top free-software issue. 
But final exams are next week so it won't happen right away.

Last modified: Sat, 7 Jun 2025 17:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.