GNU logs - #77370, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77370: [PATCH] Improve foldout-exit-fold behavior with negative argument
Resent-From: "Paul D. Nelson" <ultrono@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 29 Mar 2025 21:07:02 +0000
Resent-Message-ID: <handler.77370.B.17432824172352 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77370 <at> debbugs.gnu.org
From: "Paul D. Nelson" <ultrono@HIDDEN>
Date: Sat, 29 Mar 2025 22:06:40 +0100
Message-ID: <uxsg7ttt7beecf.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2a00:1450:4864:20::62e;
 envelope-from=ultrono@HIDDEN; helo=mail-ej1-x62e.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--=-=-=
Content-Type: text/plain

The foldout-* commands, available in outline-minor-mode, give a way to
zoom in and out of "folds", which are subtrees defined by the outline
structure.  To follow along with this email, start by doing
foldout-zoom-subtree (C-c @ C-z) on a subtree (e.g., an elisp defun).

By default, foldout-exit-fold (C-c @ C-x) exits one fold, hides the text
that was in that fold (outline-hide-subtree), moves point to the
heading, and recenters.  When invoked with a negative prefix argument
like C-- C-c @ C-x, the command instead

 (1) exits one fold without hiding the text,

 (2) moves point to the bottom of the fold, and

 (3) recenters.

I think that better behavior would be to skip steps (2) and (3), so that
the point stays put and the window view does not change.

[Step (2) seems incidental rather than by design, so "skip" really means
"counter".]

Advantages of omitting (2) are:

- We don't lose our place when zooming out.

- If we zoom in and zoom out (C-c @ C-z, C-- C-c @ C-x), then point
  doesn't move.

- Consistency with other outline/foldout commands that preserve "point
  being on a heading".

Regarding (3), recentering helps us reorient when hiding an exited fold,
but is disruptive when the text remains visible.

We retain the flexibility to imitate the old behavior using M-> and C-l.

The change could be guarded by a defcustom, but it seems to me like a
clear improvement.  I'd be happy to learn if I missed some scenario
where it is not.

Any feedback would be welcome.

--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-Improve-foldout-exit-fold-with-negative-arg.patch

From a384ca50aeb65c976df6e536d54f96acf1d143d2 Mon Sep 17 00:00:00 2001
From: Paul Nelson <ultrono@HIDDEN>
Date: Sat, 29 Mar 2025 19:07:13 +0100
Subject: [PATCH] Improve foldout-exit-fold with negative arg

* lisp/foldout.el (foldout-exit-fold): When called with a
negative prefix argument (so that the exited fold is not
hidden), preserve the position of point and do not recenter.
---
 etc/NEWS        | 5 +++++
 lisp/foldout.el | 9 ++++++---
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/etc/NEWS b/etc/NEWS
index 1bd2fd6d486..7a3419ee59a 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1367,6 +1367,11 @@ string instead of preprending it and 'tmm-mid-prompt' to said entry.

 ** Foldout

+*** Improved behavior of 'foldout-exit-fold' with negative prefix argument.
+When 'foldout-exit-fold' is called with a negative argument (so that the
+exited fold remains visible), the position of point and window view are
+preserved.
+
 ---
 *** New command 'foldout-widen-to-current-fold'.
 This command widens the view to the current fold level when in a fold,
diff --git a/lisp/foldout.el b/lisp/foldout.el
index fcc5e294561..748f56c0c9c 100644
--- a/lisp/foldout.el
+++ b/lisp/foldout.el
@@ -290,10 +290,10 @@ foldout-exit-fold
   "Return to the ARG'th enclosing fold view.  With ARG = 0 exit all folds.

 Normally causes exited folds to be hidden, but with ARG < 0, -ARG folds are
-exited and text is left visible."
+exited, text is left visible, and point position is preserved."
   (interactive "p")
   (let ((hide-fold t) start-marker end-marker
-	beginning-of-heading end-of-subtree)
+        beginning-of-heading end-of-subtree (original-point (point)))

     ;; check there are some folds to leave
     (if (null foldout-fold-list)
@@ -369,7 +369,10 @@ foldout-exit-fold
 			    (if end-marker
 				(1- (marker-position end-marker))
 			      (point-max)))))
-    (recenter)
+
+    (if hide-fold
+        (recenter)
+      (goto-char original-point))

     ;; update the mode line
     (foldout-update-mode-line)))
-- 
2.39.3 (Apple Git-145)

--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: "Paul D. Nelson" <ultrono@HIDDEN>
Subject: bug#77370: Acknowledgement ([PATCH] Improve foldout-exit-fold
 behavior with negative argument)
Message-ID: <handler.77370.B.17432824172352.ack <at> debbugs.gnu.org>
References: <uxsg7ttt7beecf.fsf@HIDDEN>
X-Gnu-PR-Message: ack 77370
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 77370 <at> debbugs.gnu.org
Date: Sat, 29 Mar 2025 21:07:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 77370 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
77370: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77370
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77370: [PATCH] Improve foldout-exit-fold behavior with negative argument
Resent-From: Paul Nelson <ultrono@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 13 Nov 2025 05:55:02 +0000
Resent-Message-ID: <handler.77370.B77370.176301325312868 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77370 <at> debbugs.gnu.org
MIME-Version: 1.0
References: <uxsg7ttt7beecf.fsf@HIDDEN>
In-Reply-To: <uxsg7ttt7beecf.fsf@HIDDEN>
From: Paul Nelson <ultrono@HIDDEN>
Date: Thu, 13 Nov 2025 06:53:52 +0100
Message-ID: <CAOA-32Mmu1-_ZGTioAHM2e_tZhRHxi8in=V31a2RpFyn7g0f5g@HIDDEN>
Content-Type: multipart/mixed; boundary="00000000000029ba9906437382f8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--00000000000029ba9906437382f8
Content-Type: multipart/alternative; boundary="00000000000029ba9706437382f6"

--00000000000029ba9706437382f6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I thought I'd gently ping on this.  To summarize, when exiting a fold with
a negative argument (to keep the text visible), Emacs currently moves point
to the end of the fold and recenters.  As far as I can tell, this behavior
is an oversight rather than intentional: the recentering is helpful when
hiding text (to reorient), but disruptive when keeping text visible.

The patch preserves point and skips recentering when the fold is kept
visible.  I'd be happy to resubmit as a user option if there are concerns
about changing default behavior, though that seems like overkill for what
appears to be a bug fix.

On Sat, Mar 29, 2025 at 10:07=E2=80=AFPM Paul D. Nelson <ultrono@HIDDEN>=
 wrote:

> The foldout-* commands, available in outline-minor-mode, give a way to
> zoom in and out of "folds", which are subtrees defined by the outline
> structure.  To follow along with this email, start by doing
> foldout-zoom-subtree (C-c @ C-z) on a subtree (e.g., an elisp defun).
>
> By default, foldout-exit-fold (C-c @ C-x) exits one fold, hides the text
> that was in that fold (outline-hide-subtree), moves point to the
> heading, and recenters.  When invoked with a negative prefix argument
> like C-- C-c @ C-x, the command instead
>
>  (1) exits one fold without hiding the text,
>
>  (2) moves point to the bottom of the fold, and
>
>  (3) recenters.
>
> I think that better behavior would be to skip steps (2) and (3), so that
> the point stays put and the window view does not change.
>
> [Step (2) seems incidental rather than by design, so "skip" really means
> "counter".]
>
> Advantages of omitting (2) are:
>
> - We don't lose our place when zooming out.
>
> - If we zoom in and zoom out (C-c @ C-z, C-- C-c @ C-x), then point
>   doesn't move.
>
> - Consistency with other outline/foldout commands that preserve "point
>   being on a heading".
>
> Regarding (3), recentering helps us reorient when hiding an exited fold,
> but is disruptive when the text remains visible.
>
> We retain the flexibility to imitate the old behavior using M-> and C-l.
>
> The change could be guarded by a defcustom, but it seems to me like a
> clear improvement.  I'd be happy to learn if I missed some scenario
> where it is not.
>
> Any feedback would be welcome.
>
>

--00000000000029ba9706437382f6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">I thought I&#39;d gently ping on this.=C2=
=A0 To summarize, when exiting a fold with a negative argument (to keep the=
 text visible), Emacs currently moves point to the end of the fold and rece=
nters.=C2=A0 As far as I can tell, this behavior is an oversight rather tha=
n intentional: the recentering is helpful when hiding text (to reorient), b=
ut disruptive when keeping text visible.<br><br>The patch preserves point a=
nd skips recentering when the fold is kept visible.=C2=A0 I&#39;d be happy =
to resubmit as a user option if there are concerns about changing default b=
ehavior, though that seems like overkill for what appears to be a bug fix.<=
br></div><br><div class=3D"gmail_quote gmail_quote_container"><div dir=3D"l=
tr" class=3D"gmail_attr">On Sat, Mar 29, 2025 at 10:07=E2=80=AFPM Paul D. N=
elson &lt;<a href=3D"mailto:ultrono@HIDDEN">ultrono@HIDDEN</a>&gt; wr=
ote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px=
 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The foldout=
-* commands, available in outline-minor-mode, give a way to<br>
zoom in and out of &quot;folds&quot;, which are subtrees defined by the out=
line<br>
structure.=C2=A0 To follow along with this email, start by doing<br>
foldout-zoom-subtree (C-c @ C-z) on a subtree (e.g., an elisp defun).<br>
<br>
By default, foldout-exit-fold (C-c @ C-x) exits one fold, hides the text<br=
>
that was in that fold (outline-hide-subtree), moves point to the<br>
heading, and recenters.=C2=A0 When invoked with a negative prefix argument<=
br>
like C-- C-c @ C-x, the command instead<br>
<br>
=C2=A0(1) exits one fold without hiding the text,<br>
<br>
=C2=A0(2) moves point to the bottom of the fold, and<br>
<br>
=C2=A0(3) recenters.<br>
<br>
I think that better behavior would be to skip steps (2) and (3), so that<br=
>
the point stays put and the window view does not change.<br>
<br>
[Step (2) seems incidental rather than by design, so &quot;skip&quot; reall=
y means<br>
&quot;counter&quot;.]<br>
<br>
Advantages of omitting (2) are:<br>
<br>
- We don&#39;t lose our place when zooming out.<br>
<br>
- If we zoom in and zoom out (C-c @ C-z, C-- C-c @ C-x), then point<br>
=C2=A0 doesn&#39;t move.<br>
<br>
- Consistency with other outline/foldout commands that preserve &quot;point=
<br>
=C2=A0 being on a heading&quot;.<br>
<br>
Regarding (3), recentering helps us reorient when hiding an exited fold,<br=
>
but is disruptive when the text remains visible.<br>
<br>
We retain the flexibility to imitate the old behavior using M-&gt; and C-l.=
<br>
<br>
The change could be guarded by a defcustom, but it seems to me like a<br>
clear improvement.=C2=A0 I&#39;d be happy to learn if I missed some scenari=
o<br>
where it is not.<br>
<br>
Any feedback would be welcome.<br>
<br>
</blockquote></div></div>

--00000000000029ba9706437382f6--

--00000000000029ba9906437382f8
Content-Type: application/octet-stream; 
	name="0001-Improve-foldout-exit-fold-with-negative-arg.patch"
Content-Disposition: attachment; 
	filename="0001-Improve-foldout-exit-fold-with-negative-arg.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mhx0i5b50>
X-Attachment-Id: f_mhx0i5b50

RnJvbSBhMzg0Y2E1MGFlYjY1Yzk3NmRmNmU1MzZkNTRmOTZhY2YxZDE0M2QyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIE5lbHNvbiA8dWx0cm9ub0BnbWFpbC5jb20+CkRhdGU6
IFNhdCwgMjkgTWFyIDIwMjUgMTk6MDc6MTMgKzAxMDAKU3ViamVjdDogW1BBVENIXSBJbXByb3Zl
IGZvbGRvdXQtZXhpdC1mb2xkIHdpdGggbmVnYXRpdmUgYXJnCgoqIGxpc3AvZm9sZG91dC5lbCAo
Zm9sZG91dC1leGl0LWZvbGQpOiBXaGVuIGNhbGxlZCB3aXRoIGEKbmVnYXRpdmUgcHJlZml4IGFy
Z3VtZW50IChzbyB0aGF0IHRoZSBleGl0ZWQgZm9sZCBpcyBub3QKaGlkZGVuKSwgcHJlc2VydmUg
dGhlIHBvc2l0aW9uIG9mIHBvaW50IGFuZCBkbyBub3QgcmVjZW50ZXIuCi0tLQogZXRjL05FV1Mg
ICAgICAgIHwgNSArKysrKwogbGlzcC9mb2xkb3V0LmVsIHwgOSArKysrKystLS0KIDIgZmlsZXMg
Y2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9l
dGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IDFiZDJmZDZkNDg2Li43YTM0MTllZTU5YSAxMDA2NDQK
LS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTEzNjcsNiArMTM2NywxMSBAQCBzdHJp
bmcgaW5zdGVhZCBvZiBwcmVwcmVuZGluZyBpdCBhbmQgJ3RtbS1taWQtcHJvbXB0JyB0byBzYWlk
IGVudHJ5LgogCiAqKiBGb2xkb3V0CiAKKyoqKiBJbXByb3ZlZCBiZWhhdmlvciBvZiAnZm9sZG91
dC1leGl0LWZvbGQnIHdpdGggbmVnYXRpdmUgcHJlZml4IGFyZ3VtZW50LgorV2hlbiAnZm9sZG91
dC1leGl0LWZvbGQnIGlzIGNhbGxlZCB3aXRoIGEgbmVnYXRpdmUgYXJndW1lbnQgKHNvIHRoYXQg
dGhlCitleGl0ZWQgZm9sZCByZW1haW5zIHZpc2libGUpLCB0aGUgcG9zaXRpb24gb2YgcG9pbnQg
YW5kIHdpbmRvdyB2aWV3IGFyZQorcHJlc2VydmVkLgorCiAtLS0KICoqKiBOZXcgY29tbWFuZCAn
Zm9sZG91dC13aWRlbi10by1jdXJyZW50LWZvbGQnLgogVGhpcyBjb21tYW5kIHdpZGVucyB0aGUg
dmlldyB0byB0aGUgY3VycmVudCBmb2xkIGxldmVsIHdoZW4gaW4gYSBmb2xkLApkaWZmIC0tZ2l0
IGEvbGlzcC9mb2xkb3V0LmVsIGIvbGlzcC9mb2xkb3V0LmVsCmluZGV4IGZjYzVlMjk0NTYxLi43
NDhmNTZjMGM5YyAxMDA2NDQKLS0tIGEvbGlzcC9mb2xkb3V0LmVsCisrKyBiL2xpc3AvZm9sZG91
dC5lbApAQCAtMjkwLDEwICsyOTAsMTAgQEAgZm9sZG91dC1leGl0LWZvbGQKICAgIlJldHVybiB0
byB0aGUgQVJHJ3RoIGVuY2xvc2luZyBmb2xkIHZpZXcuICBXaXRoIEFSRyA9IDAgZXhpdCBhbGwg
Zm9sZHMuCiAKIE5vcm1hbGx5IGNhdXNlcyBleGl0ZWQgZm9sZHMgdG8gYmUgaGlkZGVuLCBidXQg
d2l0aCBBUkcgPCAwLCAtQVJHIGZvbGRzIGFyZQotZXhpdGVkIGFuZCB0ZXh0IGlzIGxlZnQgdmlz
aWJsZS4iCitleGl0ZWQsIHRleHQgaXMgbGVmdCB2aXNpYmxlLCBhbmQgcG9pbnQgcG9zaXRpb24g
aXMgcHJlc2VydmVkLiIKICAgKGludGVyYWN0aXZlICJwIikKICAgKGxldCAoKGhpZGUtZm9sZCB0
KSBzdGFydC1tYXJrZXIgZW5kLW1hcmtlcgotCWJlZ2lubmluZy1vZi1oZWFkaW5nIGVuZC1vZi1z
dWJ0cmVlKQorICAgICAgICBiZWdpbm5pbmctb2YtaGVhZGluZyBlbmQtb2Ytc3VidHJlZSAob3Jp
Z2luYWwtcG9pbnQgKHBvaW50KSkpCiAKICAgICA7OyBjaGVjayB0aGVyZSBhcmUgc29tZSBmb2xk
cyB0byBsZWF2ZQogICAgIChpZiAobnVsbCBmb2xkb3V0LWZvbGQtbGlzdCkKQEAgLTM2OSw3ICsz
NjksMTAgQEAgZm9sZG91dC1leGl0LWZvbGQKIAkJCSAgICAoaWYgZW5kLW1hcmtlcgogCQkJCSgx
LSAobWFya2VyLXBvc2l0aW9uIGVuZC1tYXJrZXIpKQogCQkJICAgICAgKHBvaW50LW1heCkpKSkp
Ci0gICAgKHJlY2VudGVyKQorCisgICAgKGlmIGhpZGUtZm9sZAorICAgICAgICAocmVjZW50ZXIp
CisgICAgICAoZ290by1jaGFyIG9yaWdpbmFsLXBvaW50KSkKIAogICAgIDs7IHVwZGF0ZSB0aGUg
bW9kZSBsaW5lCiAgICAgKGZvbGRvdXQtdXBkYXRlLW1vZGUtbGluZSkpKQotLSAKMi4zOS4zIChB
cHBsZSBHaXQtMTQ1KQoK
--00000000000029ba9906437382f8--

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77370: [PATCH] Improve foldout-exit-fold behavior with negative argument
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 15 Nov 2025 10:33:01 +0000
Resent-Message-ID: <handler.77370.B77370.176320276531468 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Paul Nelson <ultrono@HIDDEN>, Juri Linkov <juri@HIDDEN>
Cc: 77370 <at> debbugs.gnu.org
Date: Sat, 15 Nov 2025 12:32:35 +0200
Message-Id: <86ikfboabg.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CAOA-32Mmu1-_ZGTioAHM2e_tZhRHxi8in=V31a2RpFyn7g0f5g@HIDDEN>
 (message from Paul Nelson on Thu, 13 Nov 2025 06:53:52 +0100)
References: <uxsg7ttt7beecf.fsf@HIDDEN>
 <CAOA-32Mmu1-_ZGTioAHM2e_tZhRHxi8in=V31a2RpFyn7g0f5g@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Paul Nelson <ultrono@HIDDEN>
> Date: Thu, 13 Nov 2025 06:53:52 +0100
> 
> I thought I'd gently ping on this.  To summarize, when exiting a fold with a negative argument (to keep the
> text visible), Emacs currently moves point to the end of the fold and recenters.  As far as I can tell, this
> behavior is an oversight rather than intentional: the recentering is helpful when hiding text (to reorient), but
> disruptive when keeping text visible.
> 
> The patch preserves point and skips recentering when the fold is kept visible.  I'd be happy to resubmit as a
> user option if there are concerns about changing default behavior, though that seems like overkill for what
> appears to be a bug fix.

Thanks.

Juri, any comments?  The patch looks like a no-brainer to me.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#77370: [PATCH] Improve foldout-exit-fold behavior with negative argument
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 15 Nov 2025 17:18:01 +0000
Resent-Message-ID: <handler.77370.B77370.176322706314789 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77370
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 77370 <at> debbugs.gnu.org, Paul Nelson <ultrono@HIDDEN>
Received: via spool by 77370-submit <at> debbugs.gnu.org id=B77370.176322706314789
          (code B ref 77370); Sat, 15 Nov 2025 17:18:01 +0000
Received: (at 77370) by debbugs.gnu.org; 15 Nov 2025 17:17:43 +0000
Received: from localhost ([127.0.0.1]:36078 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vKJuA-0003qS-VW
	for submit <at> debbugs.gnu.org; Sat, 15 Nov 2025 12:17:43 -0500
Received: from mout-p-201.mailbox.org ([80.241.56.171]:51274)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>)
 id 1vKJu9-0003qD-1N; Sat, 15 Nov 2025 12:17:41 -0500
Received: from smtp2.mailbox.org (smtp2.mailbox.org
 [IPv6:2001:67c:2050:b231:465::2])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4d810Y0sTnz9sst;
 Sat, 15 Nov 2025 18:17:33 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; 
 t=1763227053;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=E4SbbFfVUXe1uJDwpCaA9N9oPfg5ZLZALVt9lugjWDY=;
 b=H/0RKW8wtvdQtaR7SNF6Vp4VzSWgSiZBYKgF3uim5AlPgDDre/4tKpQd41bFUlhuw3zRko
 21bBs2yWhOcg9342uVUBL4e6NtfTmyQimpjJIjKDlEPd//wLA3175BP4n827v8coS7+364
 XICCXAWpvK1elpWvbQFyd2TphNrDr0RmAwtUQUcqKQ0eFtbDS0twzKcJGVfhWK3vXaJpcp
 utff3XgKwhNerM6MokwNrTz6ZS1ylmQ4iqvlM7/t7XerNABk4GxtMjAdYU8ahUtg3n0yFD
 nl5ISyoe7c7xQNBgFRT0Ef1r+iEqFObYkQMw7epyMNjXPBk+X4eNFsWmjPz9rw==
Authentication-Results: outgoing_mbo_mout; dkim=none;
 spf=pass (outgoing_mbo_mout: domain of juri@HIDDEN designates
 2001:67c:2050:b231:465::2 as permitted sender) smtp.mailfrom=juri@HIDDEN
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <86ikfboabg.fsf@HIDDEN>
Organization: LINKOV.NET
References: <uxsg7ttt7beecf.fsf@HIDDEN>
 <CAOA-32Mmu1-_ZGTioAHM2e_tZhRHxi8in=V31a2RpFyn7g0f5g@HIDDEN>
 <86ikfboabg.fsf@HIDDEN>
Date: Sat, 15 Nov 2025 19:16:41 +0200
Message-ID: <87v7jbrzba.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Rspamd-Queue-Id: 4d810Y0sTnz9sst
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

close 77370 31.0.50
thanks

>> I thought I'd gently ping on this.  To summarize, when exiting a fold with a negative argument (to keep the
>> text visible), Emacs currently moves point to the end of the fold and recenters.  As far as I can tell, this
>> behavior is an oversight rather than intentional: the recentering is helpful when hiding text (to reorient), but
>> disruptive when keeping text visible.
>> 
>> The patch preserves point and skips recentering when the fold is kept visible.  I'd be happy to resubmit as a
>> user option if there are concerns about changing default behavior, though that seems like overkill for what
>> appears to be a bug fix.
>
> Thanks.
>
> Juri, any comments?  The patch looks like a no-brainer to me.

Everything looks correct, so now pushed.  Thanks Paul for the patch.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 15 Nov 2025 17:17:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 15 12:17:43 2025
Received: from localhost ([127.0.0.1]:36080 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vKJuB-0003qU-Cl
	for submit <at> debbugs.gnu.org; Sat, 15 Nov 2025 12:17:43 -0500
Received: from mout-p-201.mailbox.org ([80.241.56.171]:51274)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>)
 id 1vKJu9-0003qD-1N; Sat, 15 Nov 2025 12:17:41 -0500
Received: from smtp2.mailbox.org (smtp2.mailbox.org
 [IPv6:2001:67c:2050:b231:465::2])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4d810Y0sTnz9sst;
 Sat, 15 Nov 2025 18:17:33 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; 
 t=1763227053;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=E4SbbFfVUXe1uJDwpCaA9N9oPfg5ZLZALVt9lugjWDY=;
 b=H/0RKW8wtvdQtaR7SNF6Vp4VzSWgSiZBYKgF3uim5AlPgDDre/4tKpQd41bFUlhuw3zRko
 21bBs2yWhOcg9342uVUBL4e6NtfTmyQimpjJIjKDlEPd//wLA3175BP4n827v8coS7+364
 XICCXAWpvK1elpWvbQFyd2TphNrDr0RmAwtUQUcqKQ0eFtbDS0twzKcJGVfhWK3vXaJpcp
 utff3XgKwhNerM6MokwNrTz6ZS1ylmQ4iqvlM7/t7XerNABk4GxtMjAdYU8ahUtg3n0yFD
 nl5ISyoe7c7xQNBgFRT0Ef1r+iEqFObYkQMw7epyMNjXPBk+X4eNFsWmjPz9rw==
Authentication-Results: outgoing_mbo_mout; dkim=none;
 spf=pass (outgoing_mbo_mout: domain of juri@HIDDEN designates
 2001:67c:2050:b231:465::2 as permitted sender) smtp.mailfrom=juri@HIDDEN
From: Juri Linkov <juri@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#77370: [PATCH] Improve foldout-exit-fold behavior with
 negative argument
In-Reply-To: <86ikfboabg.fsf@HIDDEN>
Organization: LINKOV.NET
References: <uxsg7ttt7beecf.fsf@HIDDEN>
 <CAOA-32Mmu1-_ZGTioAHM2e_tZhRHxi8in=V31a2RpFyn7g0f5g@HIDDEN>
 <86ikfboabg.fsf@HIDDEN>
Date: Sat, 15 Nov 2025 19:16:41 +0200
Message-ID: <87v7jbrzba.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Rspamd-Queue-Id: 4d810Y0sTnz9sst
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: control
Cc: 77370 <at> debbugs.gnu.org, Paul Nelson <ultrono@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

close 77370 31.0.50
thanks

>> I thought I'd gently ping on this.  To summarize, when exiting a fold with a negative argument (to keep the
>> text visible), Emacs currently moves point to the end of the fold and recenters.  As far as I can tell, this
>> behavior is an oversight rather than intentional: the recentering is helpful when hiding text (to reorient), but
>> disruptive when keeping text visible.
>> 
>> The patch preserves point and skips recentering when the fold is kept visible.  I'd be happy to resubmit as a
>> user option if there are concerns about changing default behavior, though that seems like overkill for what
>> appears to be a bug fix.
>
> Thanks.
>
> Juri, any comments?  The patch looks like a no-brainer to me.

Everything looks correct, so now pushed.  Thanks Paul for the patch.

Last modified: Sat, 15 Nov 2025 17:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.