GNU bug report logs - #77397
31.0.50; japanese-replace-region doesn't work

Previous Next

To reply to this bug, email your comments to 77397 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: bug-gnu-emacs <at> gnu.org
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: 31.0.50; japanese-replace-region doesn't work
Date: Mon, 31 Mar 2025 11:56:48 +0900

Hi,

On Sat, 29 Mar 2025 17:58:51 -0400, Stefan Monnier via Mailing list for Emacs changes wrote:
> branch: master
> commit a5126f79a163192947acb18a32e199c588be7c4a
> Merge: b98fe25c2ee 6bcf41c311b
> Author: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Commit: Stefan Monnier <monnier <at> iro.umontreal.ca>

>     Merge remote-tracking branch 'origin/scratch/replace-region-contents'
[...]
>  lisp/language/japan-util.el    |  43 +++++++-----

Functions that use `replace-region-contents' in japan-util.el
now do not work.  Because the 3rd argument SOURCE passed to
`replace-region-contents' may be a character, not a string, in
most cases in japan-util.el.  For instance:

(japanese-hankaku "アイウエオ")
 =>
Debugger entered--Lisp error: (wrong-type-argument (or string buffer vector) 65393)
  replace-region-contents(1 2 65393 0)
 [...]

Maybe changing `replace-region-contents' so to allow a character
as well, or wrapping the 3rd argument passed to
`replace-region-contents' with the `string' function in only
japan-util.el will be the solution.

Thanks.

Message #8 received at 77397 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 77397 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#77397: 31.0.50; japanese-replace-region doesn't work
Date: Mon, 31 Mar 2025 16:58:42 +0300

> Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Date: Mon, 31 Mar 2025 11:56:48 +0900
> From: Katsumi Yamaoka <yamaoka <at> jpl.org>
> 
> Hi,
> 
> On Sat, 29 Mar 2025 17:58:51 -0400, Stefan Monnier via Mailing list for Emacs changes wrote:
> > branch: master
> > commit a5126f79a163192947acb18a32e199c588be7c4a
> > Merge: b98fe25c2ee 6bcf41c311b
> > Author: Stefan Monnier <monnier <at> iro.umontreal.ca>
> > Commit: Stefan Monnier <monnier <at> iro.umontreal.ca>
> 
> >     Merge remote-tracking branch 'origin/scratch/replace-region-contents'
> [...]
> >  lisp/language/japan-util.el    |  43 +++++++-----
> 
> Functions that use `replace-region-contents' in japan-util.el
> now do not work.  Because the 3rd argument SOURCE passed to
> `replace-region-contents' may be a character, not a string, in
> most cases in japan-util.el.  For instance:
> 
> (japanese-hankaku "アイウエオ")
>  =>
> Debugger entered--Lisp error: (wrong-type-argument (or string buffer vector) 65393)
>   replace-region-contents(1 2 65393 0)
>  [...]
> 
> Maybe changing `replace-region-contents' so to allow a character
> as well, or wrapping the 3rd argument passed to
> `replace-region-contents' with the `string' function in only
> japan-util.el will be the solution.

Thanks, I installed a fix.

Message #11 received at 77397 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 77397 <at> debbugs.gnu.org
Subject: Re: 31.0.50; japanese-replace-region doesn't work
Date: Mon, 31 Mar 2025 22:27:52 -0400

> Functions that use `replace-region-contents' in japan-util.el
> now do not work.  Because the 3rd argument SOURCE passed to
> `replace-region-contents' may be a character, not a string, in
> most cases in japan-util.el.  For instance:

Duh!  Thanks, should be fixed now,

> Maybe changing `replace-region-contents' so to allow a character
> as well,

That would make sense for a more primitive `replace-region`, but
I'd rather not add that to the fancier `replace-region-contents` where
that char could end up turned into a (temp) buffer.

> or wrapping the 3rd argument passed to `replace-region-contents' with
> the `string' function in only japan-util.el will be the solution.

That's what I did.
Oh, wait I see Eli beat me to it (and with the exact same patch to boot!).


        Stefan

Message #16 received at 77397-done <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 77397-done <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#77397: 31.0.50; japanese-replace-region doesn't work
Date: Tue, 01 Apr 2025 11:58:39 +0900

On Mon, 31 Mar 2025 16:58:42 +0300, Eli Zaretskii wrote:
> Thanks, I installed a fix.

Thanks, that's TRT.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.