GNU bug report logs - #77404
[PATCH 0/1] PETSc compiler optimization: Pass from -O1 to -O3

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77404 in the body.
You can then email your comments to 77404 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Luca Cirrottola <luca.cirrottola <at> inria.fr>
To: guix-patches <at> gnu.org
Cc: Luca Cirrottola <luca.cirrottola <at> inria.fr>
Subject: [PATCH 0/1] PETSc compiler optimization: Pass from -O1 to -O3
Date: Mon, 31 Mar 2025 12:42:17 +0200

Hello Guix,

I have recently noticed that the "petsc" package raises the following warnings during the configuration phase, showing that the compiler only does O1 optimization for now:

=============================================================================================
                         Configuring PETSc to compile on your system
=============================================================================================
=============================================================================================
                                     ***** WARNING *****
  Using default C optimization flags "-g -O". You might consider manually setting optimal
  optimization flags for your system with COPTFLAGS="optimization flags" see
  config/examples/arch-*-opt.py for examples
=============================================================================================
=============================================================================================
                                     ***** WARNING *****
  Using default Cxx optimization flags "-g". You might consider manually setting optimal
  optimization flags for your system with CXXOPTFLAGS="optimization flags" see
  config/examples/arch-*-opt.py for examples
=============================================================================================
=============================================================================================
                                     ***** WARNING *****
  Using default FC optimization flags "-g -O". You might consider manually setting optimal
  optimization flags for your system with FOPTFLAGS="optimization flags" see
  config/examples/arch-*-opt.py for examples
=============================================================================================

So here is a patch that follows the hints and passes the "-g -O3" flags to the COPTFLAGS, CXXOPTFLAGS and FOPTFLAGS variables.
The package builds successfully on my machine. Some tests fail for both the packages "petsc" and "petsc-openmpi", but these were failing already with the "-O1" flag (so maybe this could be the topic of another issue).
I am looking forward for your review.

Cheers,
Luca

Luca Cirrottola (1):
  Activate higher compiler optimization for PETSc.

 gnu/packages/maths.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)


base-commit: 4b97ae180fc13f7e4818cf48519f8a77c22c7797
-- 
2.34.1

Message #8 received at 77404 <at> debbugs.gnu.org (full text, mbox):

From: Luca Cirrottola <luca.cirrottola <at> inria.fr>
To: 77404 <at> debbugs.gnu.org
Cc: Luca Cirrottola <luca.cirrottola <at> inria.fr>
Subject: [PATCH 1/1] Activate higher compiler optimization for PETSc.
Date: Mon, 31 Mar 2025 12:44:35 +0200

---
 gnu/packages/maths.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 74c486b38a..fd0c940507 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -3658,7 +3658,10 @@ (define-public petsc
       #:test-target "test"
       #:parallel-build? #f             ; build is parallel by default
       #:configure-flags
-      #~(list "--with-mpi=0"
+      #~(list "COPTFLAGS=-g -O3"
+              "CXXOPTFLAGS=-g -O3"
+              "FOPTFLAGS=-g -O3"
+              "--with-mpi=0"
               "--with-openmp=1"
               "--with-openblas=1"
               (string-append "--with-openblas-dir="
-- 
2.34.1

Message #13 received at 77404-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 77404-done <at> debbugs.gnu.org
Cc: Luca Cirrottola <luca.cirrottola <at> inria.fr>
Subject: Close
Date: Mon, 31 Mar 2025 16:06:42 +0200

Hello,

thanks for the patch! I have pushed it after adapting the commit message
to our coding standards.

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.