Received: (at 77439) by debbugs.gnu.org; 4 Apr 2025 06:52:10 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 04 02:52:10 2025 Received: from localhost ([127.0.0.1]:36856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u0auP-0006hU-Oe for submit <at> debbugs.gnu.org; Fri, 04 Apr 2025 02:52:10 -0400 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:61725) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <n.oje.bar@HIDDEN>) id 1u0auJ-0006gd-9N for 77439 <at> debbugs.gnu.org; Fri, 04 Apr 2025 02:52:03 -0400 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5e5c9662131so2796621a12.3 for <77439 <at> debbugs.gnu.org>; Thu, 03 Apr 2025 23:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743749517; x=1744354317; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gxlmA38qBR5gcFP61uOKEkR0VGJcYYfVUuBwWx2UlMA=; b=a3VULFbW5CJIhCP2G4C+Gyvyh/HR7aVp1iHIWf6gSIpKh2TmjXoxBkU32gpMxJRmfI 8opS9z/22e1ZKWJWidpSYaTw9rJS/tpNtgaBpzCYgg1sUD/0+dpf3bpZMQy0slK1r8Ft OL4HXMESfQ5koI3pDR8V2z4vwLnArOYKvvQLLyRCn2n7zrCSZQ+0uptvi8CcPa/aEQX/ vjhDz35IWZSw+HlrjcYeZMqcY/UjS4B2CpyBLhlhuRPxnGOSchjb8u0t5s8ESut7lVf/ doy46xgcdm7j7kUBtRTCCXZH5E3ah5RH5IK7LSod59WF32GFa6B2AGqMkWwPUcKNsb2O e/Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743749517; x=1744354317; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gxlmA38qBR5gcFP61uOKEkR0VGJcYYfVUuBwWx2UlMA=; b=YoekL1xzq789EEXjpbkRxO86jpZh75WjZE+2KONwn9TSgwhruH7PauAyBoLXGy7/VK 9H4La/TodYV7NI3hjaFSzNqxVJJdQiinmUDXYgfmwql6aHaY/2pujZ1wy86hoJiTGycI skcLMlNOJARME74O0XDvZwxoW5qAqt2sCc/kCqhvGlvaXWU8TvF+Abv0QSFnj2byoogY R1ZDwmN2jwgjgz0h8/3QjmshR+jxqYab3rwnCSXz6wXwD2Ttv+HnTNt5Mzaao4YKhnOw yWUNZ/tlaeUJt8S1uf7E2BA7KWYIcjEQJCrrJvyHnIu1R2zbLr79Qi8o91cihYn3gcG8 GTjw== X-Forwarded-Encrypted: i=1; AJvYcCXlmuToml3VyQfyyOAhsh5kTpswdVUHGwwPdcEJ2icfAh0jsX4wSZl2/HqayP59wa3VidFMDw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwWb6Q8b8cAmBVvzh9x9t+nYjQ0EH1n1IOeaxWGKQqRMjSgN2Vh gtbkDCsXn1V5RQMkQEKo5O+04/Bfaj4srUlCVee3hhBjHQP60cyZjwwerJiX/4FS5m7pOUY2Cbg D4R4TaT269NdxKSKwd2+sy30s9DM= X-Gm-Gg: ASbGncsxv7aAFf7pjgw6yp8rMViq8bQbX+LtKqrQALxaxs9UoMRKdUEWweqyOLmSUqE CG9Rl7tgL+knTSX/uj5JDnBPjclRLS8WA9YAUiy2ageHXJV5axKqmBQZ8/1YIn70XMUaAmykf5k uXxyTbSpgqXzOGMtkWm6fAT4IcerqGt09TIlM4SgGdC72+ouelO7hnNTPGKAA= X-Google-Smtp-Source: AGHT+IH2MsmMPWDHbgx0Ki/glfVnBIebcx6VRSiBbP2EA6A0dl0eTA317TsyaKjgSYAuzStg1DmPKVMxF6F6D00hubM= X-Received: by 2002:a17:907:9707:b0:ac7:3912:5ea6 with SMTP id a640c23a62f3a-ac7d6f1ea61mr91056866b.59.1743749516736; Thu, 03 Apr 2025 23:51:56 -0700 (PDT) MIME-Version: 1.0 References: <877c434n0k.fsf@HIDDEN> <CALDnm52TAg320Awe2Fj26jWZKFm6FFJUComTM_Q5DvuPeJB_cg@HIDDEN> <CAPunWhCng9EbZq2kwaTAN7xA1tW4W6Oy07HJjt8rNo-+3yvWsA@HIDDEN> <878qohocfb.fsf@HIDDEN> In-Reply-To: <878qohocfb.fsf@HIDDEN> From: =?UTF-8?Q?Nicol=C3=A1s_Ojeda_B=C3=A4r?= <n.oje.bar@HIDDEN> Date: Fri, 4 Apr 2025 08:51:31 +0200 X-Gm-Features: ATxdqUF8EsCUpLzcvLfKmeBjve7w9AU2uK5IV7151Vtz-YM1vuSKOa1Fa5gzDR8 Message-ID: <CAPunWhCuH_9B-z2LqXTH9828fiQSMxeM=jLrN3Qw0f_ZDuAkNw@HIDDEN> Subject: Re: bug#77439: [PATCH] Eglot: introduce eglot-show-diagnostics-source To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77439 Cc: 77439 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Spencer Baugh <sbaugh@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Thu, Apr 3, 2025 at 10:51=E2=80=AFAM Jo=C3=A3o T=C3=A1vora <joaotavora@g= mail.com> wrote: > > But I'm very sorry if I'm going to disappoint you. I've had a change of > heart. I was thinking about this, and I don't think this customization > belongs in Eglot. Instead, it belongs to Flymake. > > Applying your patch would violate the principle that Eglot as a medium > between LSP and Emacs facilities should not withhold information from > Emacs. OK, makes sense. Give me a few days to chew on this and I'll get back here once I have something. Thanks. Cheers, Nicolas
bug-gnu-emacs@HIDDEN:bug#77439; Package emacs.
Full text available.Received: (at 77439) by debbugs.gnu.org; 3 Apr 2025 08:51:17 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 03 04:51:17 2025 Received: from localhost ([127.0.0.1]:32791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u0GI8-0008QL-G9 for submit <at> debbugs.gnu.org; Thu, 03 Apr 2025 04:51:16 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:50381) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1u0GI4-0008Q4-Tj for 77439 <at> debbugs.gnu.org; Thu, 03 Apr 2025 04:51:13 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-39c31e4c3e5so140644f8f.0 for <77439 <at> debbugs.gnu.org>; Thu, 03 Apr 2025 01:51:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743670266; x=1744275066; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AwEZozb9VzGfEm+cfUCb/KmA4MqCI8qS9joACwJjAHM=; b=V+emju0DmRfr4o8fqJwOLjBsZS3W5fmXAQfUrHvufHxJYKefxlDvtLBsZKfjDbz+zo gxo2oiP0kvUnOmRNh/+mCw6/DcE5MYp2sVcUl1MdvuMnQRRpX1stGEGH72142818DUtF GxDd/rUkKqPNPR0RgVkLgNdA101qrxEehXphQU1z+tHNK3tfxEUD2fzouIZR83r0EZQm kygkHKalHwyhLDXx8y/TmY9cYpo9Du5DNeM9/86gZoE1dyzDZrGM1RpGwk3WM+JuP8zR r+SI8ekqCIjv7u3SV+TMx8w7ZVj/MUdGWWI18lMmJP48pFigeyhAzhg16Yp5IIQoJ5oA 7bLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743670266; x=1744275066; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AwEZozb9VzGfEm+cfUCb/KmA4MqCI8qS9joACwJjAHM=; b=d5TbStRnyaJnh1I3CUNaGcZXLJ4oDD592mIpzOUDaVhqSFaXlPQmTuoYVOHlwHjB5j 41ZT3Zpva3cArP152bw6reW0KTXjdEAojXy0qUEdjraJL72p9Uv/ssqIjH1MokzBxKOM 34H6EJAJf9crZT56FjJFjN+MRb9f7kDp0E2Ye6N0SefkRz0tAoTxiwVmefxr4ls5HAeI WIUJDMP8BMjtG/6mVQ4qHeHIhDxN0Iw/+crxLbXT/JF05LgxJ8V00uyvOMtSmky0Co08 zkzohidaHuJT5CqesysoT8LZLnSsoF4QZHeThH3xoPlwHjCuV1Z9WnGYFxQO5HUN583P I5hg== X-Forwarded-Encrypted: i=1; AJvYcCXvrSVfYkSQ6vSemzTyVkpuUT1Nr0yF3If6ktTkQpteMh4tM8k9btrxgY7PEpNICuw7LewmMg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YywG/v+DBdwdNMo0+54hNh4Qdq2ZJ1nWijY3akH0Ae+ySLCcR3+ 0pI/hE/IgR6Yz4G6iZBHpU6aLaeSQUMiQJwFbtnEpMjwHNbzWXOS X-Gm-Gg: ASbGnctqWns1Lj69hpS023CFwb9V+yuT1s3dCMNiObSWdTfd5i/JV0ZPRxCGJwSJMn2 1InZbQe8i5qe4pDa8suiKICP6NIat/xkkRA64a2YyJb81L6yWuQDluw6lIgR/VmzX4lnqXsSzpQ JYwLNUsAlamrQ1L1iN5K/8kAsh08j9AsRsYl0eL5vKl9kOqdFuoIYwn5zE8BB0LMORixcC8WRXE rie3aG10ESXPDfHg2A+BmmK4BNX3y4p4qK/YHGK7jtcY4ugf3/iYR2yyBWyK743HOVOyMtbFPWI CNR3gAgWa+tsLPX02np441HoXVw/RnTVwQ== X-Google-Smtp-Source: AGHT+IEM8PULPA/+eS1oSDUGIevYgySgFdGvjKfOdBu79odVAS0ImEwGlJ8dnTJZytMUK6pCfdn8FA== X-Received: by 2002:a5d:648d:0:b0:39c:2692:4259 with SMTP id ffacd0b85a97d-39c2f8d5407mr1464272f8f.21.1743670266321; Thu, 03 Apr 2025 01:51:06 -0700 (PDT) Received: from krug ([87.196.73.56]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301a79aasm1201290f8f.35.2025.04.03.01.51.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 01:51:05 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> To: =?utf-8?Q?Nicol=C3=A1s?= Ojeda =?utf-8?Q?B=C3=A4r?= <n.oje.bar@HIDDEN> Subject: Re: bug#77439: [PATCH] Eglot: introduce eglot-show-diagnostics-source In-Reply-To: <CAPunWhCng9EbZq2kwaTAN7xA1tW4W6Oy07HJjt8rNo-+3yvWsA@HIDDEN> References: <877c434n0k.fsf@HIDDEN> <CALDnm52TAg320Awe2Fj26jWZKFm6FFJUComTM_Q5DvuPeJB_cg@HIDDEN> <CAPunWhCng9EbZq2kwaTAN7xA1tW4W6Oy07HJjt8rNo-+3yvWsA@HIDDEN> Date: Thu, 03 Apr 2025 09:51:36 +0100 Message-ID: <878qohocfb.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77439 Cc: 77439 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Spencer Baugh <sbaugh@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Nicol=C3=A1s Ojeda B=C3=A4r <n.oje.bar@HIDDEN> writes: > Dear Jo=C3=A3o, > > Thanks for the quick reply. I'm including here a revised version of the p= atch. > > On Tue, Apr 1, 2025 at 11:46=E2=80=AFPM Jo=C3=A3o T=C3=A1vora <joaotavora= @gmail.com> wrote: >> >> Thanks. The patch looks good and ticks all the boxes. Well almost, >> there are some minor details I didn't tell you about and are easy to mi= ss. >> >> * two spaces between sentences in documentation. > > Fixed, thanks. > >> * the first line of the docstring should be a complete sentence and >> fit in a line when the docstring is formatted with M-q > > Fixed, thanks. > >> * perhaps some other micro things I missed >> * the code used concat to handle the nilness of source/code, this one >> is more explicit. i can live with that though, maybe it's better like t= his. > > OK, I left this part of the code as it is. > >> The most important and boring thing will be to figure out if you need >> a copyright assignment for this contribution. Maybe not, if it counts >> as a "trivial" patch, but you should probably get one started >> regardless. Eli, please advise. > > Actually, I believe I have a copyright assignment on file from long time = ago. Thanks for this patch, as I said, it looks great, exceptionally tidy, and done in record time. But I'm very sorry if I'm going to disappoint you. I've had a change of heart. I was thinking about this, and I don't think this customization belongs in Eglot. Instead, it belongs to Flymake. Applying your patch would violate the principle that Eglot as a medium between LSP and Emacs facilities should not withhold information from Emacs. Also, Flycheck store those things itself from the beginning, and it's a good idea we should copy. And I've been meaning to do it anyway for a long time, now is a good opportunity. So we have to change Flymake somehow so that it becomes aware that diagnostic messages may have three parts: - a source - a code - a message Can they have more than three? Can they have just 2? Are they to be named always "source/code/message" like LSP/Flycheck wants us to? This is where the under/overengineering antennae should stick up. If we accept that it's at most 3, and they have those names, the patch to present to flymake.el is somewhat straightforward: * change the public flymake-make-diagnostic interface to explicitly allow backends to pass in those things. Since it's sadly BOA function, I'd say the best is to overload its TEXT argument, renaming it INFO to allow it to be more a list of (SOURCE CODE MESSAGE) instead of just a string. * change the code around to account for the above. I recommend changing the private flymake--diag struct creating flymake--diag-accessor macros flymake-diagnostic-source and flymake-diagnostic-code. * Introduce a flymake-diagnostic-display-info customization option where the user can say whether what Flymake gives to its associated displaying outlets. Here I suppose your personal preference would be to set this variable to just `(:message). * The same variable could be repurposed for controlling the columns of the flymake-show-diagnostics-buffer tabular display (which would also have to tweak.) * Finally, change Eglot to pass those things in to Flymake. * Bump the Flymake version, change Eglot's Package-Requires to rely on the bumped version. * Update the flymake.texi manual. * Run Flymake unit tests. * Ideally add a new test or two (not neded, but nice) * Change Emacs's etc/NEWS to reflect the Flymake change. * Optionally change Emacs's etc/EGLOT-NEWS to call attention to Eglot making use of this new Flymake capability. Of course, if you think this solution is underengineered and we should have more flexibility, other solutions are possible via a protocol different from flymake-make-diagnostic. Jo=C3=A3o
bug-gnu-emacs@HIDDEN:bug#77439; Package emacs.
Full text available.Received: (at 77439) by debbugs.gnu.org; 2 Apr 2025 06:46:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 02 02:46:18 2025 Received: from localhost ([127.0.0.1]:53982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tzrrd-00084Z-Q8 for submit <at> debbugs.gnu.org; Wed, 02 Apr 2025 02:46:18 -0400 Received: from mail-ot1-x334.google.com ([2607:f8b0:4864:20::334]:51489) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1tzrrb-00083S-Rz for 77439 <at> debbugs.gnu.org; Wed, 02 Apr 2025 02:46:16 -0400 Received: by mail-ot1-x334.google.com with SMTP id 46e09a7af769-72c40235c34so1630636a34.3 for <77439 <at> debbugs.gnu.org>; Tue, 01 Apr 2025 23:46:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743576370; x=1744181170; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fYuvNjbM/K86F6ArRXOxI4w3qLZOr2UpHjlD/TMOJdQ=; b=C86qhEqzUIuoYXoL2pLU/Wc3xL+SOYbQbjxd1ZD9K1jbOzNRgL/Rft6Ww4DHMJcnvY MtWtPBc/ax7+e9dcJDiQsEwukBovfs7YBYfO4Y06gSwhlcREaM1tewRYfkp01eH3D7FD YRq9Qqkih9MU2/kpbkl4B09Vr96Mwyf0ZORCkCTdDrAM5MfNo6x1v4QUV9ZgQcTmWi6Y B52LnOB70w82L21f85GXvVpGBYtSTAS0qEihtH9k3hWCFSfMXVbkIk7np7uphJwI/pLF sFdAmMPy1FtmgisoBqluT7vGQUS/PoH0NxU6EH5SSE3YjtDES9TRi55nCNZIjbn5qsiH Z2nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743576370; x=1744181170; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fYuvNjbM/K86F6ArRXOxI4w3qLZOr2UpHjlD/TMOJdQ=; b=OKqSx9rwLPtqHg1g7nQ9CaFUaa2oQHbSowfDCN3rIuOh/3xnKOTLaDJmH0uafLMEEU Mx0gWM50nUD4G/LYlWkEwTRPNMab6pUhXFMu+D0W7Z0vm4xOTpWnLYjQdkmyO6N7wRD4 /E0YtW+PiP8/wlPi5iac+YLz0aI1f7WA+PoIGq1JbBWibQansBHzLFKXo07HWo+dBRn8 kk19itzYrZWg1E0mooy2GHKitGjq0lw9fUw//vrFRb43qFdCDQ9T4XJxm56tZB9+QkYZ lQY8Z11NesuQaeQOZ8EpWxEGkFCz7ZIswGJrFlaEt3MhvvdlezeBb3fytT2heK7bAqmw tfMQ== X-Forwarded-Encrypted: i=1; AJvYcCWsgyRK951oxq6hxK9UvHui/ki9MqdzlQXXOic3VQmD6r2nSK+fb/SkI+vsHiK1+6REnTrzPw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxrHDhpxEcd0y+9hoBaTbMHdfAX+qGDOmtX4k3mi9f25MGGjQNU UFem/btpBvChUHwJw53Cg4gbnyTavzDTRFI/khhxHX7Qc+4HzIAb53pTi4UHNzE4WvcWTpwWrEl xXxCQBi+de/u6CSjQWkfICxRCnKc= X-Gm-Gg: ASbGncsi9fcaazkaty0j5ESTpCa5iC8A1rScraMxVJNYL8QLJL2VQe/abEEi9NT89YN m+aFc4RKJt7sEHD1cCOAkGxOIBwwg6mZWavRXhuOitnDBymjzucnfp9e7xfOH6CXbHXsuupytE1 DTrsPpITF8doXVjQfIo3u8J31PXHQMhMKakjk/ X-Google-Smtp-Source: AGHT+IGp0guzNGzErHfMd/hGyRLsdd6E3pJmUOhffiUXrqVZRG49NlBdssDXIw47AklHbvsFllKcpFcZB40qU6qEv9I= X-Received: by 2002:a05:6830:6101:b0:72b:9d5e:941c with SMTP id 46e09a7af769-72c637ace9emr10300093a34.13.1743576369906; Tue, 01 Apr 2025 23:46:09 -0700 (PDT) MIME-Version: 1.0 References: <877c434n0k.fsf@HIDDEN> <CALDnm52TAg320Awe2Fj26jWZKFm6FFJUComTM_Q5DvuPeJB_cg@HIDDEN> <CAPunWhCng9EbZq2kwaTAN7xA1tW4W6Oy07HJjt8rNo-+3yvWsA@HIDDEN> In-Reply-To: <CAPunWhCng9EbZq2kwaTAN7xA1tW4W6Oy07HJjt8rNo-+3yvWsA@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Wed, 2 Apr 2025 07:46:30 +0100 X-Gm-Features: AQ5f1Jp-UbHvJVByUpEK2vlCud8WkjPua1NBKmi3d_beUw8wy70IjkODwFlXc9k Message-ID: <CALDnm52P=NGbOeVcxyc0C4mD559=Fpu1PRjNzggkf88tAD1bZQ@HIDDEN> Subject: Re: bug#77439: [PATCH] Eglot: introduce eglot-show-diagnostics-source To: =?UTF-8?Q?Nicol=C3=A1s_Ojeda_B=C3=A4r?= <n.oje.bar@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77439 Cc: 77439 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Wed, Apr 2, 2025 at 7:39=E2=80=AFAM Nicol=C3=A1s Ojeda B=C3=A4r <n.oje.b= ar@HIDDEN> wrote: > > Dear Jo=C3=A3o, > > Thanks for the quick reply. I'm including here a revised version of the p= atch. I'll look into in more detail later and possibly push it. > Actually, I believe I have a copyright assignment on file from long time = ago. > Otherwise, let me know and I'll submit the papers. I see you in the copyright file indeed. Great! Jo=C3=A3o
bug-gnu-emacs@HIDDEN:bug#77439; Package emacs.
Full text available.Received: (at 77439) by debbugs.gnu.org; 2 Apr 2025 06:39:41 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 02 02:39:40 2025 Received: from localhost ([127.0.0.1]:53947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tzrlE-00076L-KL for submit <at> debbugs.gnu.org; Wed, 02 Apr 2025 02:39:40 -0400 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:46103) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <n.oje.bar@HIDDEN>) id 1tzrlB-00075I-Ry for 77439 <at> debbugs.gnu.org; Wed, 02 Apr 2025 02:39:38 -0400 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5e8be1bdb7bso10374354a12.0 for <77439 <at> debbugs.gnu.org>; Tue, 01 Apr 2025 23:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743575972; x=1744180772; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=T/t4nWVgGuJTwzQvzbzZxIxqvdW8OLnixQ9H2sq0Mso=; b=EwXaTEZwZADItPUeaPzEXh1ow8kmuUQdNFKzzhU8L6eDnG/13sy9VFkaH4/Uf4Oqzp mSV4N4JtOJ33C6AO2YHy2iuVcuxTOPoIPSDREhh/VZ2v9JG40RWpIf9vZUv7dXsof93E vZxJ3uaZxC7IyAAQl0ZNShPzeAPSrh2pWb8fd+IRM5SyxQvMXA9GZstH/KaslkQulWMf eD0CIPY8jvRVFho/xEvmPY0hMcEKB12fEr3yMI90aOMx/gvh4dxUb+6PEhjEE/lafw7x zRIxFsgqkpbrtw1KRH1McBMInVRdwCLtxY8wt1bK5XguAUKFpUrGDaHr202MZnEzV3Vm TQTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743575972; x=1744180772; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T/t4nWVgGuJTwzQvzbzZxIxqvdW8OLnixQ9H2sq0Mso=; b=Sl0g/wQ7mNlIKUdcPVs/dx1yd51T8dQdust6p2oI8uQWyfAcszy1AzviAwHPBGhlvW W0A5wp2/Mw1X0Jrj8n/TF4YMgAs0G+lqArkHqjZlcDWIMxWlEmMnt+D+jyvQ0T0dldBu VWH985qE36D4o64YJJsChgRNexKraPPD69QolWA7GiwMKC6cz4M9Y40pQwLU3d4OOvE7 EqBKZ1AHam5xOllCs1YXOEtXlk7NCIR8prRChzgSnb4drRGkJEgq5JMPA2b3YgAH6V8a sC4t3VwS+rkdWPUCYpXjwB+fc53k/nh2yvA5VzBIcHg//1q3D8wu2euiSdtFl4jELupS pdZg== X-Forwarded-Encrypted: i=1; AJvYcCUGC2IzTOk6pmcgbET0zFKQJeHSfLYpxzXMS4LnA8WsgXrFztiV6xebhfHczWisM4HFK5kAlA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwbEX+NNnZvwInjdMvxKcIGLXYitMCRdcKBTrolqWfFNA1j55Wr bVJjYq+W1NOHft/3kKkkXQ4tCWjlCvaJjYOzcgknNkkXU2QUuWRmgmtBXJJojrf/YrXqlNJVcf1 SuNZZvyAjja4hhtaEfxr3qo2+t/s= X-Gm-Gg: ASbGncuFBdpZKdWyA6/cFaB9CXW4v4j7AxJ9yHVZrS1lN62f9c688XF4chpeU9j+bc8 Ely17P4R3wvuR8gLRroqlswSqmy43qdnEhkvc0py9pBy/ZqCmLeKPwsTGXfc61oWXHTPR7LZIqC q0E+Ct2lOr719xmSashIq0OpSp5f2GzsbvJ2sKbpdiU+SdfjCKrGmXXIZIp28B3N5RnsZ2 X-Google-Smtp-Source: AGHT+IG2akzOzckyYroqvcjQpif/fSP0PNix4yF8rsuh5MJ+9QJYsC/8peU+1QO0sCvmNjtzrVHPSBpACduzxagomkU= X-Received: by 2002:a17:907:a08a:b0:ac7:7e2c:68e9 with SMTP id a640c23a62f3a-ac7a173099bmr88635266b.25.1743575971323; Tue, 01 Apr 2025 23:39:31 -0700 (PDT) MIME-Version: 1.0 References: <877c434n0k.fsf@HIDDEN> <CALDnm52TAg320Awe2Fj26jWZKFm6FFJUComTM_Q5DvuPeJB_cg@HIDDEN> In-Reply-To: <CALDnm52TAg320Awe2Fj26jWZKFm6FFJUComTM_Q5DvuPeJB_cg@HIDDEN> From: =?UTF-8?Q?Nicol=C3=A1s_Ojeda_B=C3=A4r?= <n.oje.bar@HIDDEN> Date: Wed, 2 Apr 2025 08:39:04 +0200 X-Gm-Features: AQ5f1Jq5oP56a97CgZ7o94tRUAOE58NZ_poaS1JXGoezi6ZRn9TdPjYpLaSn7Jg Message-ID: <CAPunWhCng9EbZq2kwaTAN7xA1tW4W6Oy07HJjt8rNo-+3yvWsA@HIDDEN> Subject: Re: bug#77439: [PATCH] Eglot: introduce eglot-show-diagnostics-source To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Content-Type: multipart/mixed; boundary="0000000000006933070631c5ea18" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77439 Cc: 77439 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --0000000000006933070631c5ea18 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dear Jo=C3=A3o, Thanks for the quick reply. I'm including here a revised version of the pat= ch. On Tue, Apr 1, 2025 at 11:46=E2=80=AFPM Jo=C3=A3o T=C3=A1vora <joaotavora@g= mail.com> wrote: > > Thanks. The patch looks good and ticks all the boxes. Well almost, > there are some minor details I didn't tell you about and are easy to mis= s. > > * two spaces between sentences in documentation. Fixed, thanks. > * the first line of the docstring should be a complete sentence and > fit in a line when the docstring is formatted with M-q Fixed, thanks. > * perhaps some other micro things I missed > * the code used concat to handle the nilness of source/code, this one > is more explicit. i can live with that though, maybe it's better like th= is. OK, I left this part of the code as it is. > The most important and boring thing will be to figure out if you need > a copyright assignment for this contribution. Maybe not, if it counts > as a "trivial" patch, but you should probably get one started > regardless. Eli, please advise. Actually, I believe I have a copyright assignment on file from long time ag= o. Otherwise, let me know and I'll submit the papers. Thanks! Cheers, Nicolas > Jo=C3=A3o --0000000000006933070631c5ea18 Content-Type: application/octet-stream; name="0001-Eglot-introduce-eglot-show-diagnostics-source.patch" Content-Disposition: attachment; filename="0001-Eglot-introduce-eglot-show-diagnostics-source.patch" Content-Transfer-Encoding: base64 Content-ID: <f_m8zk0os00> X-Attachment-Id: f_m8zk0os00 RnJvbSBhNTdlZWIzNzM2MThhYTliNTZjODk1YmMzYzg3M2VkYTJjNmU2NjcwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Tmljb2w9QzM9QTFzPTIwT2plZGE9MjBCPUMz PUE0cj89IDxuLm9qZS5iYXJAZ21haWwuY29tPgpEYXRlOiBUdWUsIDEgQXByIDIwMjUgMjI6MjQ6 MjEgKzAyMDAKU3ViamVjdDogW1BBVENIXSBFZ2xvdDogaW50cm9kdWNlIGVnbG90LXNob3ctZGlh Z25vc3RpY3Mtc291cmNlCgpTZXR0aW5nIHRoaXMgdmFyaWFibGUgdG8gbmlsIGNhdXNlcyBFZ2xv dCB0byBzdG9wIHByZWZpeGluZyBldmVyeQpkaWFnbm9zdGljIHdpdGggdGhlIG5hbWUgb2YgdGhl IHNvdXJjZSBvZiB0aGUgZGlhZ25vc3RpYy4gIFRoaXMgY2FuIGJlCnVzZWZ1bCB3aGVuIG9ubHkg b25lIHNvdXJjZSBpcyBhY3RpdmUsIHRvIHJlZHVjZSB0aGUgcmVwZXRpdGlvbiBvZiB0aGUKc2Ft ZSBpbmZvcm1hdGlvbiBpbiBldmVyeSBkaWFnbm9zdGljLgoKKiBsaXNwL3Byb2dtb2Rlcy9lZ2xv dC5lbCAoZWdsb3QtaGFuZGxlLW5vdGlmaWNhdGlvbik6IFRha2UgbmV3IHZhcmlhYmxlCiAgaW50 byBhY2NvdW50LgoKKiBkb2MvbWlzYy9lZ2xvdC50ZXhpIChDdXN0b21pemluZyBFZ2xvdCk6IE1l bnRpb24gbmV3IHZhcmlhYmxlLgoKKiBldGMvRUdMT1QtTkVXUzogTWVudGlvbiBuZXcgdmFyaWFi bGUuCi0tLQogZG9jL21pc2MvZWdsb3QudGV4aSAgICAgfCAgNyArKysrKysrCiBldGMvRUdMT1Qt TkVXUyAgICAgICAgICB8ICA3ICsrKysrKysKIGxpc3AvcHJvZ21vZGVzL2VnbG90LmVsIHwgMTMg KysrKysrKysrKysrLQogMyBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL21pc2MvZWdsb3QudGV4aSBiL2RvYy9taXNjL2VnbG90 LnRleGkKaW5kZXggZmFjOTA1NjJmNmIuLjhkNzdiNjY1MGVmIDEwMDY0NAotLS0gYS9kb2MvbWlz Yy9lZ2xvdC50ZXhpCisrKyBiL2RvYy9taXNjL2VnbG90LnRleGkKQEAgLTEwNTAsNiArMTA1MCwx MyBAQCBPdGhlciBWYXJpYWJsZXMKIE5vdGUgdGhhdCB5b3UgY2FuIHN0aWxsIGNvbmZpZ3VyZSB0 aGUgZXhjbHVkZWQgRW1hY3MgZmVhdHVyZXMgbWFudWFsbHkKIHRvIHVzZSBFZ2xvdCBpbiB5b3Vy IEBjb2Rle2VnbG90LW1hbmFnZWQtbW9kZS1ob29rfSBvciB2aWEgc29tZSBvdGhlcgogbWVjaGFu aXNtLgorCitAaXRlbSBlZ2xvdC1zaG93LWRpYWdub3N0aWNzLXNvdXJjZQorVHlwaWNhbGx5IEVn bG90IHByZWZpeGVzIGVhY2ggZGlhZ25vc3RpYyB3aXRoIHRoZSBuYW1lIG9mIGl0cyBzb3VyY2Uu CitIb3dldmVyLCB3aGVuIG9ubHkgb25lIHNvdXJjZSBpcyBhY3RpdmUsIHRoZSBzYW1lIGluZm9y bWF0aW9uIGlzCityZXBlYXRlZCBpbiBhbGwgZGlhZ25vc3RpY3Mgd2hpY2ggbWF5IG5vdCBiZSB1 c2VmdWwuICBJbiB0aGF0IGNhc2UsIHRoaXMKK3ZhcmlhYmxlIGNhbiBiZSBzZXQgdG8gbmlsIHRv IHN1cHJlc3MgdGhlIGFkZGl0aW9uIG9mIHRoaXMgaW5mb3JtYXRpb24KK3RvIGVhY2ggZGlhZ25v c3RpYy4KIEBlbmQgdGFibGUKIAogQG5vZGUgTW9yZSBDdXN0b21pemF0aW9uCmRpZmYgLS1naXQg YS9ldGMvRUdMT1QtTkVXUyBiL2V0Yy9FR0xPVC1ORVdTCmluZGV4IDdiNTNkNTk0M2JhLi5jZDlj MDJhMmM1ZiAxMDA2NDQKLS0tIGEvZXRjL0VHTE9ULU5FV1MKKysrIGIvZXRjL0VHTE9ULU5FV1MK QEAgLTIwLDYgKzIwLDEzIEBAIGh0dHBzOi8vZ2l0aHViLmNvbS9qb2FvdGF2b3JhL2VnbG90L2lz c3Vlcy8xMjM0LgogDAogKiBDaGFuZ2VzIGluIHVwY29taW5nIEVnbG90CiAKKyoqIE5ldyAnZWds b3Qtc2hvdy1kaWFnbm9zdGljcy1zb3VyY2UnIHZhcmlhYmxlCisKK0VnbG90IHR5cGljYWxseSBp bmNsdWRlcyB0aGUgbmFtZSBvZiB0aGUgc291cmNlIG9mIGVhY2ggZGlhZ25vc3RpYworcmVwb3J0 ZWQgYnkgdGhlIExTUCBzZXJ2ZXIuICBTZXR0aW5nIHRoaXMgdmFyaWFibGUgdG8gbmlsIGluaGli aXRzIHRoaXMKK2JlaGF2aW91ciBhbmQgY2FuIGJlIHVzZWZ1bCB3aGVuIG9ubHkgb25lIHNvdXJj ZSBpcyBhY3RpdmUgdG8gYXZvaWQKK3JlcGVhdGluZyB0aGUgc2FtZSBpbmZvcm1hdGlvbiBpbiBl dmVyeSBkaWFnbm9zdGljLgorCiAqKiBTdXBwb3J0IGZvciBjYWxsIGFuZCB0eXBlIGhpZXJhcmNo aWVzCiAKIFRoZSBuZXcgY29tbWFuZHMgJ2VnbG90LXNob3ctdHlwZS1oaWVyYXJjaHknIGFuZApk aWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvZWdsb3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9lZ2xv dC5lbAppbmRleCBjOTM3MjgzMTIyZS4uNDQ0NWY0YTA5MDAgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJv Z21vZGVzL2VnbG90LmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVsCkBAIC01ODEsNiAr NTgxLDEzIEBAIGVnbG90LWFkdmVydGlzZS1jYW5jZWxsYXRpb24KIHNlcnZlcnMuIgogICA6dHlw ZSAnYm9vbGVhbikKIAorKGRlZmN1c3RvbSBlZ2xvdC1zaG93LWRpYWdub3N0aWNzLXNvdXJjZSB0 CisgICJJZiBub24tbmlsLCBFZ2xvdCBwcmVmaXhlcyBlYWNoIGRpYWdub3N0aWNzIHdpdGggdGhl IG5hbWUgb2YgaXRzIHNvdXJjZS4KK1NldCB0byBuaWwgdG8gaW5oaWJpdCB0aGlzIGJlaGF2aW91 ci4gIFRoaXMgbWF5IGJlIHVzZWZ1bCB3aGVuIG9ubHkgb25lCitzb3VyY2UgaXMgYWN0aXZlLCB0 byBhdm9pZCByZXBlYXRpbmcgdGhlIHNhbWUgaW5mb3JtYXRpb24gaW4gZXZlcnkKK2RpYWdub3N0 aWMuIgorICA6dHlwZSAnYm9vbGVhbikKKwogKGRlZmZhY2UgZWdsb3QtY29kZS1hY3Rpb24taW5k aWNhdG9yLWZhY2UKICAgJygodCAoOmluaGVyaXQgZm9udC1sb2NrLWVzY2FwZS1mYWNlIDp3ZWln aHQgYm9sZCkpKQogICAiRmFjZSB1c2VkIGZvciBjb2RlIGFjdGlvbiBzdWdnZXN0aW9ucy4iKQpA QCAtMjY2Nyw3ICsyNjc0LDExIEBAIGVnbG90LWhhbmRsZS1ub3RpZmljYXRpb24KICAgICAgICAg ICAgICAgICAgICAgKCg9IHNldiAyKSAgJ2VnbG90LXdhcm5pbmcpCiAgICAgICAgICAgICAgICAg ICAgICh0ICAgICAgICAgICdlZ2xvdC1ub3RlKSkpCiAgICAgICAgICAgICAobWVzcyAoc291cmNl IGNvZGUgbWVzc2FnZSkKLSAgICAgICAgICAgICAgKGNvbmNhdCBzb3VyY2UgKGFuZCBjb2RlIChm b3JtYXQgIiBbJXNdIiBjb2RlKSkgIjogIiBtZXNzYWdlKSkKKyAgICAgICAgICAgICAgKGxldCAo KHNvdXJjZSAoYW5kIGVnbG90LXNob3ctZGlhZ25vc3RpY3Mtc291cmNlIHNvdXJjZSkpKQorICAg ICAgICAgICAgICAgIChjb25kICgoYW5kIChudWxsIGNvZGUpIChudWxsIHNvdXJjZSkpIG1lc3Nh Z2UpCisgICAgICAgICAgICAgICAgICAgICAgKChudWxsIGNvZGUpIChmb3JtYXQgIiVzOiAlcyIg c291cmNlIG1lc3NhZ2UpKQorICAgICAgICAgICAgICAgICAgICAgICgobnVsbCBzb3VyY2UpIChm b3JtYXQgIlslc106ICVzIiBjb2RlIG1lc3NhZ2UpKQorICAgICAgICAgICAgICAgICAgICAgICh0 IChmb3JtYXQgIiVzIFslc106ICVzIiBzb3VyY2UgY29kZSBtZXNzYWdlKSkpKSkKICAgICAgICAg ICAgIChmaW5kLWl0IChhYnNwYXRoKQogICAgICAgICAgICAgICA7OyBgZmluZC1idWZmZXItdmlz aXRpbmcnIHdvdWxkIGJlIG5hdHVyYWwsIGJ1dCBjYWxscyB0aGUKICAgICAgICAgICAgICAgOzsg cG90ZW50aWFsbHkgc2xvdyBgZmlsZS10cnVlbmFtZScgKGJ1ZyM3MDAzNikuCi0tIAoyLjQ4LjEK Cg== --0000000000006933070631c5ea18--
bug-gnu-emacs@HIDDEN:bug#77439; Package emacs.
Full text available.Received: (at 77439) by debbugs.gnu.org; 1 Apr 2025 21:46:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 01 17:46:48 2025 Received: from localhost ([127.0.0.1]:51869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tzjRY-0007aY-DS for submit <at> debbugs.gnu.org; Tue, 01 Apr 2025 17:46:48 -0400 Received: from mail-oa1-x35.google.com ([2001:4860:4864:20::35]:49258) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1tzjRW-0007ZX-B1 for 77439 <at> debbugs.gnu.org; Tue, 01 Apr 2025 17:46:46 -0400 Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-2c77a5747e0so3498403fac.2 for <77439 <at> debbugs.gnu.org>; Tue, 01 Apr 2025 14:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743544000; x=1744148800; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=j98w4yObF6YOUPDhy2QlUAcVbeuocNDWcT9VtTxWiiM=; b=BB/oj2Sks2Fq/ycHuELOAxGZfCdncuUyhGRUqFW6Krknp9lArMZlDhiZXhOHXrAJYf cTgh+lhdNJO2QHlHftKQz/FK+i1LGyVZ8Sila5TVtD4NtBGofD1CLvmBf14KWa58QiRl btpEBt2iMLiNu8Tk28DhW1qS5BGcawm0tGXfUeeF7dbAFMG4MZ7UZA2VuptohcVUhoJu lJaVvihHm55+NLmLIJVq66Nczw8Qams0dvJiA1MY1UqC7dyxipHgPLUFNpys8PRd/DCB zoBO6TcdKwFjnQ4aKLS7BFTXW5lAcwvDRPmhSwQ4b41zGc0bNQrb2y7qPac5x4k9BEN3 AgGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743544000; x=1744148800; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j98w4yObF6YOUPDhy2QlUAcVbeuocNDWcT9VtTxWiiM=; b=BaTF6Nt1dJf13err3hxPYO9JgkperYZOJxPYpbhTe1N4m5SiH9mdUoxfEfuRiFsnOt 4cYsMdFpGwMvHLgeYQ1OT4EIK5UPjIuTzBFXyGEsiH53Z7+drsroWU7YIJCH5mlaWNI9 Zsqwfo22/mZxaNtamGFSpYJ0b8RH5s/Cpboe/s1frwZswAcNam2nzbtwiO91bBiYYUnH Q+MZ9oSSk7eHoXRUoL7iK/hxEPUDDODMSln7INz9BgR0vCbOjnp73Kgmx9XFPfCI1FCn zRgy4LWQ8UfcNZAmHliSoDBFad7QqkUKo4ihKA3YWFhEPgWtyK3Z9QzaI6Yr5GtsF907 seQw== X-Gm-Message-State: AOJu0YwSuCyzqMoc+JrkXKjWJ8QCv65qEaeiafMqERzspKJXOZci2x21 1MFHD9WahEUcmBtDcNCRTF4TdF1Z1KWUSoXo2wMSy3DJeNE2VgyoMW9mnoza8sW4GZQFDNXsmp6 ejeL7sq4VrkQCJrtnp9HGMXWlbMo= X-Gm-Gg: ASbGncsDa2LLjD27QhMf3QUTekwNkY3srtcZsrowjjecJmPAoKTnf39XrNUccpw7wYn AO+qdqLb5Z7oiQe2qYTOqzjEoSR/fs1kJCFYkEIjgUY6huIrLoXv+ERknuo9Q7RVxrwrpOhS9rE Q6w6k6ljqk6TwKnVfVUZTvVbkIAA== X-Google-Smtp-Source: AGHT+IFV4RNiRE4Q/E1u77j/8hCH3CI5FQ3stxhMcB6PsF67svbuqd71eimcSdUsalZ/zMBd8Ia0XaPk6Vd46HiwpfA= X-Received: by 2002:a05:6871:608c:b0:2c2:30ca:8da1 with SMTP id 586e51a60fabf-2cc60b81f6fmr86814fac.17.1743544000436; Tue, 01 Apr 2025 14:46:40 -0700 (PDT) MIME-Version: 1.0 References: <877c434n0k.fsf@HIDDEN> In-Reply-To: <877c434n0k.fsf@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Tue, 1 Apr 2025 22:47:02 +0100 X-Gm-Features: AQ5f1Jr_iA6HNbZu8R_oj8k8voxgHQRIP_0vJIDDG-SHBimZTzwEjBB7761HVYg Message-ID: <CALDnm52TAg320Awe2Fj26jWZKFm6FFJUComTM_Q5DvuPeJB_cg@HIDDEN> Subject: Re: bug#77439: [PATCH] Eglot: introduce eglot-show-diagnostics-source To: =?UTF-8?Q?Nicol=C3=A1s_Ojeda_B=C3=A4r?= <n.oje.bar@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77439 Cc: 77439 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Tue, Apr 1, 2025 at 9:59=E2=80=AFPM Nicol=C3=A1s Ojeda B=C3=A4r <n.oje.b= ar@HIDDEN> wrote: > > Tags: patch > > Dear developers (Cc: Jo=C3=A3o T=C3=A1vora), > > This small patch introduces a new variable eglot-show-diagnostics-source > which controls whether Eglot prefixes every diagnostic with the name of Thanks. The patch looks good and ticks all the boxes. Well almost, there are some minor details I didn't tell you about and are easy to miss. * two spaces between sentences in documentation. * the first line of the docstring should be a complete sentence and fit in a line when the docstring is formatted with M-q * perhaps some other micro things I missed * the code used concat to handle the nilness of source/code, this one is more explicit. i can live with that though, maybe it's better like this= . The most important and boring thing will be to figure out if you need a copyright assignment for this contribution. Maybe not, if it counts as a "trivial" patch, but you should probably get one started regardless. Eli, please advise. Jo=C3=A3o
bug-gnu-emacs@HIDDEN:bug#77439; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 1 Apr 2025 20:58:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 01 16:58:54 2025
Received: from localhost ([127.0.0.1]:51677 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tzihB-00016Z-5x
for submit <at> debbugs.gnu.org; Tue, 01 Apr 2025 16:58:54 -0400
Received: from lists.gnu.org ([2001:470:142::17]:41532)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <n.oje.bar@HIDDEN>)
id 1tzih8-00015V-N2
for submit <at> debbugs.gnu.org; Tue, 01 Apr 2025 16:58:51 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <n.oje.bar@HIDDEN>)
id 1tzih2-0006vf-E4
for bug-gnu-emacs@HIDDEN; Tue, 01 Apr 2025 16:58:44 -0400
Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <n.oje.bar@HIDDEN>)
id 1tzih0-0008PU-0i
for bug-gnu-emacs@HIDDEN; Tue, 01 Apr 2025 16:58:44 -0400
Received: by mail-wr1-x42e.google.com with SMTP id
ffacd0b85a97d-39c2688619bso595839f8f.1
for <bug-gnu-emacs@HIDDEN>; Tue, 01 Apr 2025 13:58:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1743541117; x=1744145917; darn=gnu.org;
h=mime-version:message-id:date:subject:to:from:from:to:cc:subject
:date:message-id:reply-to;
bh=wouh8e11o7LXyLEf9Uz6hcswFxHGcjKabiAwtWDz/l4=;
b=ExGjPaMonzX0EZjmMyno1eS6RyJYVSmcvRNak7CieoIaDM78vu0umAzI8O9JoVYpEd
KcQrzMHaGMfob4EMpyyKlnav/11z8EvajkwT+nWPW3u/yFXuiffJaYHg0ncmyaH7YR66
60giSJVH+rWkS7JFIU0UL0bljT+H890q3zdP2m4q5RMEYIXi+gKqotv5vcr2/RHpk1kT
E9EhpLk7vN3EPunnv3ArP06kCpaJ4XCrH/WHwSBBCHI3ibheSvV8vmW9Jzy+eS08T/p7
rrchXMRDYJKa4O7qjt5OcUfIx0wV+igcsB6+79+W76bzJyKDai36WstfKoFuIS+3QTgy
oghQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1743541117; x=1744145917;
h=mime-version:message-id:date:subject:to:from:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=wouh8e11o7LXyLEf9Uz6hcswFxHGcjKabiAwtWDz/l4=;
b=a37eYhDd3F4+TPB2kG4BRbKLBoftTQZtI1qNYkJW6h2QyVG84THjezVS3P7Lw26Hh9
c55DxEtLxl1BDaXqqM33B9BwN0Vc5NFyR4LBVpeX9D3WNKKjTCPrywkOnjxeDUV64OmH
JjkpJF4G0efdIgOs8r5ZppnXkN3dhnwUQ/bCNBAb5EAeSXMXa/5gTy8Zjb6c+kpN8fRx
MtBTcIbfLQhRIeSBuh3NNRaYsiTeqJyZ1KMSZby+ZFM6YqAJWE0Rxzitm5gbaHHCZ5uv
gvBXS079XHadH6fodOFGZ2I654R2wL2x8y6lkJKdTPTEcIFlGCtJG4aRzSP4zkfW9Kdy
kjxg==
X-Gm-Message-State: AOJu0Yx29CKuJN6+AF83qWDQHGykLdW4N8Li1cAblrx3szcfEvIVff4m
vjMRUcVnQ06RWwskHgf88wlqJEjoR5BhTi5XUh9ptvVBnumsgG7YMf4BNBPu
X-Gm-Gg: ASbGncviHhfW28cDMzm+XFgljzKwm30hdKSsDjW8FHYmNkztirdUduAM8uPw2VqtlTi
4uOIGBgHDOarC9K/xaqa1BFKCkKNfa8ba9/YkC+N+KUshx1Y+RPFRVXPf2ILd1OvydPtfl+9H20
fxWHcm+NMO84feBD9VsZn6M09mJesBtBOtTWsdR5nShJ/0dujhshqrT3N2jlEJ/BdyzZ0B1hQ4k
ectCBGPk9Ts2g8foXdqeeK2ks554LFcWZuWcOQ3DBfMHMvhkpk/13RdpL0MvIskJ2wyY1nXdQKm
sU0hn//VmI36allYAzEhp8CSTxbI2NMfnQu4IWE69QYpxlboBH+EpbYZTXfvd9zO5uMflA==
X-Google-Smtp-Source: AGHT+IFgH7JeDnrEdfCSEzJul2R8K/FradzECqxM50y1gYP0bcpIsm3dntSdqUVKbFzs9vUFZEZQ+Q==
X-Received: by 2002:a05:6000:1ac8:b0:39c:cc7:3c5f with SMTP id
ffacd0b85a97d-39c2366af22mr3698110f8f.45.1743541116667;
Tue, 01 Apr 2025 13:58:36 -0700 (PDT)
Received: from LEXIFI-L6 (89.91.65.81.rev.sfr.net. [81.65.91.89])
by smtp.gmail.com with ESMTPSA id
5b1f17b1804b1-43ea8d16049sm22241925e9.0.2025.04.01.13.58.35
for <bug-gnu-emacs@HIDDEN>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 01 Apr 2025 13:58:36 -0700 (PDT)
From: =?utf-8?Q?Nicol=C3=A1s_Ojeda_B=C3=A4r?= <n.oje.bar@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] Eglot: introduce eglot-show-diagnostics-source
X-Debbugs-Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
Date: Tue, 01 Apr 2025 22:58:35 +0200
Message-ID: <877c434n0k.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2a00:1450:4864:20::42e;
envelope-from=n.oje.bar@HIDDEN; helo=mail-wr1-x42e.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Tags: patch
Dear developers (Cc: Jo=C3=A3o T=C3=A1vora),
This small patch introduces a new variable eglot-show-diagnostics-source
which controls whether Eglot prefixes every diagnostic with the name of
its source. When only one source is active, this information is not
useful and its repetition for every diagnostic wastes screen real
estate.
This addition has already been discussed (and accepted in principle) in
GitHub:
https://github.com/joaotavora/eglot/issues/1501
I tried to follow the existing conventions for the patch and its
documentation, but this is my first contribution to Emacs, so please do
not hesitate to point out if I missed anything.
I am looking forward to any feedback you may have on this patch. Thanks.
Cheers,
Nicolas
--=-=-=
Content-Type: text/patch
Content-Disposition: attachment;
filename=0001-Eglot-introduce-eglot-show-diagnostics-source.patch
From 14b3e3397d831c319ea865f4bfea81fe1d0dfb75 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nicol=C3=A1s=20Ojeda=20B=C3=A4r?= <n.oje.bar@HIDDEN>
Date: Tue, 1 Apr 2025 22:24:21 +0200
Subject: [PATCH] Eglot: introduce eglot-show-diagnostics-source
Setting this variable to nil causes Eglot to stop prefixing every
diagnostic with the name of the source of the diagnostic. This can be
useful when only one source is active, to reduce the repetition of the
same information in every diagnostic.
* lisp/progmodes/eglot.el (eglot-handle-notification): Take new variable
into account.
* doc/misc/eglot.texi (Customizing Eglot): Mention new variable.
* etc/EGLOT-NEWS: Mention new variable.
---
doc/misc/eglot.texi | 7 +++++++
etc/EGLOT-NEWS | 7 +++++++
lisp/progmodes/eglot.el | 12 +++++++++++-
3 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/doc/misc/eglot.texi b/doc/misc/eglot.texi
index fac90562f6b..f483611541a 100644
--- a/doc/misc/eglot.texi
+++ b/doc/misc/eglot.texi
@@ -1050,6 +1050,13 @@ Other Variables
Note that you can still configure the excluded Emacs features manually
to use Eglot in your @code{eglot-managed-mode-hook} or via some other
mechanism.
+
+@item eglot-show-diagnostics-source
+Typically Eglot prefixes each diagnostic with the name of the source of
+the diagnostic. However, when only one source is active, the same
+information is repeated in all diagnostics which may not be useful. In
+that case, this variable can be set to nil to supress the addition of
+this information to each diagnostic.
@end table
@node More Customization
diff --git a/etc/EGLOT-NEWS b/etc/EGLOT-NEWS
index 7b53d5943ba..125935c001e 100644
--- a/etc/EGLOT-NEWS
+++ b/etc/EGLOT-NEWS
@@ -20,6 +20,13 @@ https://github.com/joaotavora/eglot/issues/1234.
* Changes in upcoming Eglot
+** New 'eglot-show-diagnostics-source' variable
+
+Eglot typically includes the name of the source of each diagnostic
+reported by the LSP server. Setting this variable to nil inhibits this
+behaviour and can be useful when only one source is active to avoid
+repeating the same information in every diagnostic.
+
** Support for call and type hierarchies
The new commands 'eglot-show-type-hierarchy' and
diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index c937283122e..5a367787a8d 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -581,6 +581,12 @@ eglot-advertise-cancellation
servers."
:type 'boolean)
+(defcustom eglot-show-diagnostics-source t
+ "If non-nil, Eglot advertises the source of each diagnostics by
+prefixing the diagnostic with the source name. Set this to nil to
+inhibit this behaviour."
+ :type 'boolean)
+
(defface eglot-code-action-indicator-face
'((t (:inherit font-lock-escape-face :weight bold)))
"Face used for code action suggestions.")
@@ -2667,7 +2673,11 @@ eglot-handle-notification
((= sev 2) 'eglot-warning)
(t 'eglot-note)))
(mess (source code message)
- (concat source (and code (format " [%s]" code)) ": " message))
+ (let ((source (and eglot-show-diagnostics-source source)))
+ (cond ((and (null code) (null source)) message)
+ ((null code) (format "%s: %s" source message))
+ ((null source) (format "[%s]: %s" code message))
+ (t (format "%s [%s]: %s" source code message)))))
(find-it (abspath)
;; `find-buffer-visiting' would be natural, but calls the
;; potentially slow `file-truename' (bug#70036).
--
2.48.1
--=-=-=--
Nicolás Ojeda Bär <n.oje.bar@HIDDEN>:joaotavora@HIDDEN, bug-gnu-emacs@HIDDEN.
Full text available.joaotavora@HIDDEN, bug-gnu-emacs@HIDDEN:bug#77439; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.