GNU bug report logs - #77450
[PATCH] gnu: font-go: Update to 2.010

Previous Next

Package: guix-patches;

Reported by: Kurome <hunt31999 <at> gmail.com>

Date: Wed, 2 Apr 2025 08:11:01 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77450 in the body.
You can then email your comments to 77450 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#77450; Package guix-patches. (Wed, 02 Apr 2025 08:11:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Kurome <hunt31999 <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 02 Apr 2025 08:11:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kurome <hunt31999 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Kurome <hunt31999 <at> gmail.com>
Subject: [PATCH] gnu: font-go: Update to 2.010
Date: Wed,  2 Apr 2025 17:08:06 +0900

Change-Id: I4dd8c14c42fdb3803d6e6ff4d075242621c3abd6
---
 gnu/packages/fonts.scm | 44 +++++++++++++++++++++---------------------
 1 file changed, 22 insertions(+), 22 deletions(-)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 9b329b3f37..b35d5ae583 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -2477,32 +2477,32 @@ (define-public font-space-grotesk
     (license license:silofl1.1)))
 
 (define-public font-go
-  (let ((commit "f03a046406d4d7fbfd4ed29f554da8f6114049fc")
-        (revision "1"))
+  (let ((commit "41969df76e82aeec85fa3821b1e24955ea993001")
+        (revision "2"))
     (package
       (name "font-go")
-      (version (string-append "20170330-" revision "." (string-take commit 7)))
-      (source (origin
-                (file-name (string-append "go-image-" version "-checkout"))
-                (method git-fetch)
-                (uri (git-reference
-                      (url "https://go.googlesource.com/image")
-                      (commit commit)))
-                (sha256
-                 (base32
-                  "1aq6mnjayks55gd9ahavk6jfydlq5lm4xm0xk4pd5sqa74p5p74d"))))
+      (version (git-version "2.010" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://go.googlesource.com/image")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1z7lxkb84ca013ys0pr1bma2zdfzrvqip4yl6s941iyby0xfiyws"))))
       (build-system font-build-system)
       (arguments
-       `(#:license-file-regexp "^(LICENSE|PATENTS)$"
-         #:phases
-         (modify-phases %standard-phases
-           (add-before 'install 'chdir
-             (lambda _
-               (chdir "font/gofont/ttfs")
-               #t))
-           (add-before 'install-license-files 'enter-license-directory
-             (lambda _
-               (chdir "../../.."))))))
+       (list
+        #:license-file-regexp "^(LICENSE|PATENTS)$"
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-before 'install 'chdir
+              (lambda _
+                (chdir "font/gofont/ttfs") #t))
+            (add-before 'install-license-files 'enter-license-directory
+              (lambda _
+                (chdir "../../.."))))))
       (home-page "https://go.dev/blog/go-fonts")
       (synopsis "The Go font family")
       (description
-- 
2.49.0
Information forwarded to guix-patches <at> gnu.org:
bug#77450; Package guix-patches. (Mon, 07 Apr 2025 09:49:02 GMT) Full text and rfc822 format available.

Message #8 received at 77450 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Kurome <hunt31999 <at> gmail.com>
Cc: 77450 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: font-go: Update to 2.010
Date: Mon, 7 Apr 2025 11:48:19 +0200

Hello,

Am Wed, Apr 02, 2025 at 05:08:06PM +0900 schrieb Kurome:
> +      (version (git-version "2.010" revision commit))

your patch leaves me a bit confused. Where does this version number come
from? The commit 41969df76e82aeec85fa3821b1e24955ea993001 mentions it,
but does not set it anywhere in the source code.

I also wonder what happens when we go back in version numbers,
from the year based one to a smaller number. Maybe we should just stay
with years and use 20220616, the date of the commit?

When you change the package writing to gexps etc., this should also be
mentioned in the commit message.

Andreas
Information forwarded to guix-patches <at> gnu.org:
bug#77450; Package guix-patches. (Mon, 07 Apr 2025 12:25:01 GMT) Full text and rfc822 format available.

Message #11 received at 77450 <at> debbugs.gnu.org (full text, mbox):

From: krm sry <hunt31999 <at> gmail.com>
To: Andreas Enge <andreas <at> enge.fr>
Cc: 77450 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: font-go: Update to 2.010
Date: Mon, 7 Apr 2025 21:24:00 +0900

[Message part 1 (text/plain, inline)]
Sorry for sending a bad patch.

Regarding the change in version number, I thought it would be more natural
to use the configured version rather than creating a version number for
convenience. I should have written this in the commit message as well.
Sorry.

I will also rewrite the commit message. I will try to write a better patch.

On Mon, Apr 7, 2025 at 6:48 PM Andreas Enge <andreas <at> enge.fr> wrote:

> Hello,
>
> Am Wed, Apr 02, 2025 at 05:08:06PM +0900 schrieb Kurome:
> > +      (version (git-version "2.010" revision commit))
>
> your patch leaves me a bit confused. Where does this version number come
> from? The commit 41969df76e82aeec85fa3821b1e24955ea993001 mentions it,
> but does not set it anywhere in the source code.
>
> I also wonder what happens when we go back in version numbers,
> from the year based one to a smaller number. Maybe we should just stay
> with years and use 20220616, the date of the commit?
>
> When you change the package writing to gexps etc., this should also be
> mentioned in the commit message.
>
> Andreas
>
>

[Message part 2 (text/html, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#77450; Package guix-patches. (Mon, 07 Apr 2025 12:26:02 GMT) Full text and rfc822 format available.

Message #14 received at 77450 <at> debbugs.gnu.org (full text, mbox):

From: Kurome <hunt31999 <at> gmail.com>
To: 77450 <at> debbugs.gnu.org
Cc: Kurome <hunt31999 <at> gmail.com>
Subject: [PATCH] gnu: font-go: Update to 2.010
Date: Mon,  7 Apr 2025 21:15:13 +0900

Other changes:
* Use git-version
* Adopted version number that was written in the
  41969df76e82aeec85fa3821b1e24955ea993001 commit message.
* Changed to use gexp for arguments

Change-Id: I4dd8c14c42fdb3803d6e6ff4d075242621c3abd6
---
 gnu/packages/fonts.scm | 44 +++++++++++++++++++++---------------------
 1 file changed, 22 insertions(+), 22 deletions(-)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 9b329b3f37..b35d5ae583 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -2477,32 +2477,32 @@ (define-public font-space-grotesk
     (license license:silofl1.1)))
 
 (define-public font-go
-  (let ((commit "f03a046406d4d7fbfd4ed29f554da8f6114049fc")
-        (revision "1"))
+  (let ((commit "41969df76e82aeec85fa3821b1e24955ea993001")
+        (revision "2"))
     (package
       (name "font-go")
-      (version (string-append "20170330-" revision "." (string-take commit 7)))
-      (source (origin
-                (file-name (string-append "go-image-" version "-checkout"))
-                (method git-fetch)
-                (uri (git-reference
-                      (url "https://go.googlesource.com/image")
-                      (commit commit)))
-                (sha256
-                 (base32
-                  "1aq6mnjayks55gd9ahavk6jfydlq5lm4xm0xk4pd5sqa74p5p74d"))))
+      (version (git-version "2.010" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://go.googlesource.com/image")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1z7lxkb84ca013ys0pr1bma2zdfzrvqip4yl6s941iyby0xfiyws"))))
       (build-system font-build-system)
       (arguments
-       `(#:license-file-regexp "^(LICENSE|PATENTS)$"
-         #:phases
-         (modify-phases %standard-phases
-           (add-before 'install 'chdir
-             (lambda _
-               (chdir "font/gofont/ttfs")
-               #t))
-           (add-before 'install-license-files 'enter-license-directory
-             (lambda _
-               (chdir "../../.."))))))
+       (list
+        #:license-file-regexp "^(LICENSE|PATENTS)$"
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-before 'install 'chdir
+              (lambda _
+                (chdir "font/gofont/ttfs") #t))
+            (add-before 'install-license-files 'enter-license-directory
+              (lambda _
+                (chdir "../../.."))))))
       (home-page "https://go.dev/blog/go-fonts")
       (synopsis "The Go font family")
       (description
-- 
2.49.0
Information forwarded to guix-patches <at> gnu.org:
bug#77450; Package guix-patches. (Mon, 07 Apr 2025 12:46:01 GMT) Full text and rfc822 format available.

Message #17 received at 77450 <at> debbugs.gnu.org (full text, mbox):

From: Kurome <hunt31999 <at> gmail.com>
To: 77450 <at> debbugs.gnu.org
Cc: Kurome <hunt31999 <at> gmail.com>
Subject: [PATCH v2] gnu: font-go: Update to 2.010.
Date: Mon,  7 Apr 2025 21:43:44 +0900

* gnu/packages/fonts.scm (font-go): Update to 2.010.

Other changes:
* Use git-version
* Adopted version number that was written in the
  41969df76e82aeec85fa3821b1e24955ea993001 commit message.
* Changed to use gexp for arguments

Change-Id: I4dd8c14c42fdb3803d6e6ff4d075242621c3abd6
---
 gnu/packages/fonts.scm | 44 +++++++++++++++++++++---------------------
 1 file changed, 22 insertions(+), 22 deletions(-)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 9b329b3f37..b35d5ae583 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -2477,32 +2477,32 @@ (define-public font-space-grotesk
     (license license:silofl1.1)))
 
 (define-public font-go
-  (let ((commit "f03a046406d4d7fbfd4ed29f554da8f6114049fc")
-        (revision "1"))
+  (let ((commit "41969df76e82aeec85fa3821b1e24955ea993001")
+        (revision "2"))
     (package
       (name "font-go")
-      (version (string-append "20170330-" revision "." (string-take commit 7)))
-      (source (origin
-                (file-name (string-append "go-image-" version "-checkout"))
-                (method git-fetch)
-                (uri (git-reference
-                      (url "https://go.googlesource.com/image")
-                      (commit commit)))
-                (sha256
-                 (base32
-                  "1aq6mnjayks55gd9ahavk6jfydlq5lm4xm0xk4pd5sqa74p5p74d"))))
+      (version (git-version "2.010" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://go.googlesource.com/image")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1z7lxkb84ca013ys0pr1bma2zdfzrvqip4yl6s941iyby0xfiyws"))))
       (build-system font-build-system)
       (arguments
-       `(#:license-file-regexp "^(LICENSE|PATENTS)$"
-         #:phases
-         (modify-phases %standard-phases
-           (add-before 'install 'chdir
-             (lambda _
-               (chdir "font/gofont/ttfs")
-               #t))
-           (add-before 'install-license-files 'enter-license-directory
-             (lambda _
-               (chdir "../../.."))))))
+       (list
+        #:license-file-regexp "^(LICENSE|PATENTS)$"
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-before 'install 'chdir
+              (lambda _
+                (chdir "font/gofont/ttfs") #t))
+            (add-before 'install-license-files 'enter-license-directory
+              (lambda _
+                (chdir "../../.."))))))
       (home-page "https://go.dev/blog/go-fonts")
       (synopsis "The Go font family")
       (description
-- 
2.49.0
Information forwarded to guix-patches <at> gnu.org:
bug#77450; Package guix-patches. (Mon, 07 Apr 2025 13:39:01 GMT) Full text and rfc822 format available.

Message #20 received at 77450 <at> debbugs.gnu.org (full text, mbox):

From: Kurome <hunt31999 <at> gmail.com>
To: 77450 <at> debbugs.gnu.org
Cc: Kurome <hunt31999 <at> gmail.com>
Subject: [PATCH v3] gnu: font-go: Update to 2.010.
Date: Mon,  7 Apr 2025 22:37:32 +0900

* gnu/packages/fonts.scm (font-go): Update to 2.010.
[version] Use git-version.  Adopted version number that was written in the
41969df76e82aeec85fa3821b1e24955ea993001 commit message.
[arguments] Use G-expression.

Change-Id: I4dd8c14c42fdb3803d6e6ff4d075242621c3abd6
---
 gnu/packages/fonts.scm | 44 +++++++++++++++++++++---------------------
 1 file changed, 22 insertions(+), 22 deletions(-)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 9b329b3f37..b35d5ae583 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -2477,32 +2477,32 @@ (define-public font-space-grotesk
     (license license:silofl1.1)))
 
 (define-public font-go
-  (let ((commit "f03a046406d4d7fbfd4ed29f554da8f6114049fc")
-        (revision "1"))
+  (let ((commit "41969df76e82aeec85fa3821b1e24955ea993001")
+        (revision "2"))
     (package
       (name "font-go")
-      (version (string-append "20170330-" revision "." (string-take commit 7)))
-      (source (origin
-                (file-name (string-append "go-image-" version "-checkout"))
-                (method git-fetch)
-                (uri (git-reference
-                      (url "https://go.googlesource.com/image")
-                      (commit commit)))
-                (sha256
-                 (base32
-                  "1aq6mnjayks55gd9ahavk6jfydlq5lm4xm0xk4pd5sqa74p5p74d"))))
+      (version (git-version "2.010" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://go.googlesource.com/image")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1z7lxkb84ca013ys0pr1bma2zdfzrvqip4yl6s941iyby0xfiyws"))))
       (build-system font-build-system)
       (arguments
-       `(#:license-file-regexp "^(LICENSE|PATENTS)$"
-         #:phases
-         (modify-phases %standard-phases
-           (add-before 'install 'chdir
-             (lambda _
-               (chdir "font/gofont/ttfs")
-               #t))
-           (add-before 'install-license-files 'enter-license-directory
-             (lambda _
-               (chdir "../../.."))))))
+       (list
+        #:license-file-regexp "^(LICENSE|PATENTS)$"
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-before 'install 'chdir
+              (lambda _
+                (chdir "font/gofont/ttfs") #t))
+            (add-before 'install-license-files 'enter-license-directory
+              (lambda _
+                (chdir "../../.."))))))
       (home-page "https://go.dev/blog/go-fonts")
       (synopsis "The Go font family")
       (description
-- 
2.49.0
Reply sent to Christopher Baines <mail <at> cbaines.net>:
You have taken responsibility. (Fri, 11 Apr 2025 11:35:01 GMT) Full text and rfc822 format available.
Notification sent to Kurome <hunt31999 <at> gmail.com>:
bug acknowledged by developer. (Fri, 11 Apr 2025 11:35:02 GMT) Full text and rfc822 format available.

Message #25 received at 77450-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Kurome <hunt31999 <at> gmail.com>
Cc: 77450-done <at> debbugs.gnu.org
Subject: Re: [bug#77450] [PATCH v3] gnu: font-go: Update to 2.010.
Date: Fri, 11 Apr 2025 12:34:23 +0100

[Message part 1 (text/plain, inline)]
Kurome <hunt31999 <at> gmail.com> writes:

> * gnu/packages/fonts.scm (font-go): Update to 2.010.
> [version] Use git-version.  Adopted version number that was written in the
> 41969df76e82aeec85fa3821b1e24955ea993001 commit message.
> [arguments] Use G-expression.
>
> Change-Id: I4dd8c14c42fdb3803d6e6ff4d075242621c3abd6
> ---
>  gnu/packages/fonts.scm | 44 +++++++++++++++++++++---------------------
>  1 file changed, 22 insertions(+), 22 deletions(-)

Thanks both, I've pushed this to master as
2d17db72d8d5c21b9e657f052841b154260998b9.

Chris

[signature.asc (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#77450; Package guix-patches. (Wed, 16 Apr 2025 14:58:03 GMT) Full text and rfc822 format available.

Message #28 received at 77450 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: krm sry <hunt31999 <at> gmail.com>
Cc: Christopher Baines <mail <at> cbaines.net>, 77450 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: font-go: Update to 2.010
Date: Wed, 16 Apr 2025 16:57:08 +0200

Sorry for idling! I am coming back to the issue and see that Chris has
pushed it, thanks a lot!

And also thanks for your numerous contributions, Kurome; I think it has
been a long time since we have seen so many font updates!

Andreas
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 15 May 2025 11:24:09 GMT) Full text and rfc822 format available.
This bug report was last modified today.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.