GNU bug report logs - #77454
30.1.50; *-pkg.el header comment broken on GNU/NonGNU ELPA (devel)

Previous Next

To reply to this bug, email your comments to 77454 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.1.50; *-pkg.el header comment broken on GNU/NonGNU ELPA (devel)
Date: Wed, 02 Apr 2025 12:43:01 +0200

For example the Transient package has this header:

;; Generated package description from .el  -*- transientno-byte-compile: t -*-

Message #8 received at 77454 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: 77454 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>, Philip
 Kaludercic <philipk <at> posteo.net>
Subject: Re: bug#77454: 30.1.50; *-pkg.el header comment broken on
 GNU/NonGNU ELPA (devel)
Date: Thu, 17 Apr 2025 06:11:01 +0200

Daniel Mendler <mail <at> daniel-mendler.de> writes:

> For example the Transient package has this header:
>
> ;; Generated package description from .el  -*- transientno-byte-compile: t -*-

Ping. This problem is still present, for example:

;; Generated package description from mode: lisp-data; .el  -*- corfuno-byte-compile: t -*-

Message #13 received at 77454-done <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 77454-done <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#77454: 30.1.50; *-pkg.el header comment broken on
 GNU/NonGNU ELPA (devel)
Date: Thu, 17 Apr 2025 08:13:56 +0000

[Message part 1 (text/plain, inline)]

Daniel Mendler <mail <at> daniel-mendler.de> writes:

> Daniel Mendler <mail <at> daniel-mendler.de> writes:
>
>> For example the Transient package has this header:
>>
>> ;; Generated package description from .el  -*- transientno-byte-compile: t -*-
>
> Ping. This problem is still present, for example:
>
> ;; Generated package description from mode: lisp-data; .el  -*- corfuno-byte-compile: t -*-

It seems that there was just a swap-o in elpa-admin.el:

[Message part 2 (text/x-patch, inline)]

diff --git a/elpa-admin.el b/elpa-admin.el
index 7e6db3fbf3..9ff01721ab 100644
--- a/elpa-admin.el
+++ b/elpa-admin.el
@@ -1519,12 +1519,12 @@ Rename DIR/ to PKG-VERS/, and return the descriptor."
                  (cdr metadata)))
       (write-region
        (concat (format ";; Generated package description from %s.el  -*- %sno-byte-compile: t -*-\n"
+		       name
 		       (let* ((emacs-req (assq 'emacs requires))
 		              (emacs-vers (car (cadr emacs-req))))
 		         (if (not (and emacs-vers (>= emacs-vers 28)))
 		             ""     ;Need compatibility with Emacs<28.
-		           "mode: lisp-data; "))
-		       name)
+		           "mode: lisp-data; ")))
 	       (prin1-to-string
                 (nconc
                  (list 'define-package

[Message part 3 (text/plain, inline)]

That now generates

;; Generated package description from corfu.el  -*- mode: lisp-data;
   no-byte-compile: t -*-

As this is a serious issue with a simple fix, I'll push the change
myself.  If that was a mistake, anyone can feel free to undo it.

Message #16 received at 77454-done <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 77454-done <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#77454: 30.1.50; *-pkg.el header comment broken on
 GNU/NonGNU ELPA (devel)
Date: Thu, 17 Apr 2025 10:53:36 +0200

Philip Kaludercic <philipk <at> posteo.net> writes:

> Daniel Mendler <mail <at> daniel-mendler.de> writes:
>
>> Daniel Mendler <mail <at> daniel-mendler.de> writes:
>>
>>> For example the Transient package has this header:
>>>
>>> ;; Generated package description from .el  -*- transientno-byte-compile: t -*-
>>
>> Ping. This problem is still present, for example:
>>
>> ;; Generated package description from mode: lisp-data; .el  -*- corfuno-byte-compile: t -*-
>
> It seems that there was just a swap-o in elpa-admin.el:

Indeed.

> As this is a serious issue with a simple fix, I'll push the change
> myself.  If that was a mistake, anyone can feel free to undo it.

Thanks.

Daniel

Message #19 received at 77454-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: Daniel Mendler <mail <at> daniel-mendler.de>, 77454-done <at> debbugs.gnu.org
Subject: Re: bug#77454: 30.1.50; *-pkg.el header comment broken on
 GNU/NonGNU ELPA (devel)
Date: Thu, 17 Apr 2025 11:06:33 -0400

> As this is a serious issue with a simple fix, I'll push the change
> myself.  If that was a mistake, anyone can feel free to undo it.

Thanks Philip, and sorry about the blunder,
I only "grep -l" for lisp-data to check that the test correctly decided
which packages could use `lisp-data-mode`, and completely missed that
the generated text was totally messed up.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.