GNU bug report logs - #77495
[PATCH] Include additional version metadata during Windows install

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77495 in the body.
You can then email your comments to 77495 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Bright <sean <at> seanbright.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Include additional version metadata during Windows install
Date: Thu, 03 Apr 2025 15:11:17 +0000

[Message part 1 (text/plain, inline)]

Hello friends,

I install emacs on Windows using the winget tool. This tool queries
the Windows registry for the current installed version of emacs, but
the NSIS installer does not create the appropriate values resulting in
the current version being reported as 'Unknown.' The attached patch
fixes that and additionally sets the Publisher value to "Free Software
Foundation, Inc."

This prevents winget from reinstalling the same version during every
invocation of 'winget update' but it also improves the appearance of
GNU Emacs in the 'Add or Remove Programs' interface[1].

Kind regards,
Sean

1. https://seanbright.com/emacs-win-metadata.png

[0001-Include-additional-version-metadata-during-Windows-i.patch (text/plain, attachment)]

Message #8 received at 77495 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Sean Bright <sean <at> seanbright.com>, Corwin Brust <corwin <at> bru.st>
Cc: 77495 <at> debbugs.gnu.org
Subject: Re: bug#77495: [PATCH] Include additional version metadata during
 Windows install
Date: Thu, 03 Apr 2025 19:05:40 +0300

> Date: Thu, 03 Apr 2025 15:11:17 +0000
> From: Sean Bright <sean <at> seanbright.com>
> 
> 
> I install emacs on Windows using the winget tool. This tool queries
> the Windows registry for the current installed version of emacs, but
> the NSIS installer does not create the appropriate values resulting in
> the current version being reported as 'Unknown.' The attached patch
> fixes that and additionally sets the Publisher value to "Free Software
> Foundation, Inc."
> 
> This prevents winget from reinstalling the same version during every
> invocation of 'winget update' but it also improves the appearance of
> GNU Emacs in the 'Add or Remove Programs' interface[1].
> 
> Kind regards,
> Sean
> 
> 1. https://seanbright.com/emacs-win-metadata.png

Adding Corwin, who prepares the Windows binaries, to the discussion.

Message #11 received at 77495 <at> debbugs.gnu.org (full text, mbox):

From: Corwin Brust <corwin <at> bru.st>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Sean Bright <sean <at> seanbright.com>, 77495 <at> debbugs.gnu.org
Subject: Re: bug#77495: [PATCH] Include additional version metadata during
 Windows install
Date: Thu, 3 Apr 2025 11:29:28 -0500

On Thu, Apr 3, 2025 at 11:05 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
> > Date: Thu, 03 Apr 2025 15:11:17 +0000
> > From: Sean Bright <sean <at> seanbright.com>
> >
> >
> > the NSIS installer does not create the appropriate values resulting in
> > the current version being reported as 'Unknown.' The attached patch
> > fixes that and additionally sets the Publisher value to "Free Software
> > Foundation, Inc."
> >
> > This prevents winget from reinstalling the same version during every
> > invocation of 'winget update' but it also improves the appearance of
> > GNU Emacs in the 'Add or Remove Programs' interface[1].
> >

Looks great.  I am traveling with only my workplace's equipment with;
I cannot immediately install this. I'll do this weekend if nobody has
already.   Thank you very much, Sean!
> > Kind regards,
> > Sean
> >
> > 1. https://seanbright.com/emacs-win-metadata.png
>
> Adding Corwin, who prepares the Windows binaries, to the discussion.
>

Message #14 received at 77495 <at> debbugs.gnu.org (full text, mbox):

From: Sean Bright <sean <at> seanbright.com>
To: 77495 <at> debbugs.gnu.org
Subject: Re: [PATCH] Include additional version metadata during Windows install
Date: Thu, 03 Apr 2025 16:02:57 +0000

[Message part 1 (text/plain, inline)]

On 4/3/2025 11:11 AM, Sean Bright wrote:
> This prevents winget from reinstalling the same version during every
> invocation of 'winget update' but it also improves the appearance of
> GNU Emacs in the 'Add or Remove Programs' interface.

Updated patch attached that also adds a DisplayIcon property so a
branded icon is displayed in the 'Add or Remove Programs'
interface[1] as well.

Kind regards,
Sean

1. https://seanbright.com/emacs-win-metadata-2.png

[0001-Include-additional-version-metadata-during-Windows-i.patch (text/plain, attachment)]

Message #17 received at 77495 <at> debbugs.gnu.org (full text, mbox):

From: Sean Bright <sean <at> seanbright.com>
To: 77495 <at> debbugs.gnu.org
Subject: Re: [PATCH] Include additional version metadata during Windows install
Date: Sat, 26 Apr 2025 19:07:27 +0000

Hi Corwin,

Anything I can do to help get this over the finish line?

Kind regards,
Sean

Message #22 received at 77495-done <at> debbugs.gnu.org (full text, mbox):

From: Corwin Brust <corwin <at> bru.st>
To: Sean Bright <sean <at> seanbright.com>, 77495-done <at> debbugs.gnu.org
Subject: Re: bug#77495: [PATCH] Include additional version metadata during
 Windows install
Date: Sat, 26 Apr 2025 15:41:09 -0500

On Sat, Apr 26, 2025 at 2:07 PM Sean Bright <sean <at> seanbright.com> wrote:
>
> Anything I can do to help get this over the finish line?
>

Applied and (from what I see) building fine; closing the bug report
with this note but feel free to reopen if you suspect troubles.

Many thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.