Received: (at 77546) by debbugs.gnu.org; 7 Apr 2025 22:44:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 07 18:44:21 2025 Received: from localhost ([127.0.0.1]:57431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u1vCX-0007jg-4n for submit <at> debbugs.gnu.org; Mon, 07 Apr 2025 18:44:21 -0400 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]:56760) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <rahuljuliato@HIDDEN>) id 1u1vCT-0007j3-61 for 77546 <at> debbugs.gnu.org; Mon, 07 Apr 2025 18:44:18 -0400 Received: by mail-qk1-x729.google.com with SMTP id af79cd13be357-7c55500cf80so404859785a.1 for <77546 <at> debbugs.gnu.org>; Mon, 07 Apr 2025 15:44:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744065851; x=1744670651; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GnWAnNERAgsTQjx1b6/6KF+kVQdRz2nUFo/n4LALJ+A=; b=jjmybh5xPmpcmQ2PWD9646gi33vaYu8y6DEKNoLvrgCjrTSvLMv6+OXAPtM+ynWTAH 6eUW0ml2kpIh4zEZ6AAyW2PhFD3xYQkIq1kTdFTLSJt5zgWjA3VefakVSPuCd+MBkDpa F6k1OY4j3wrGArjHTos+I82JM4u2wdvDFWImbgFHjp2lCKxFXZbmh+VDzQl2W7yl5tor REYS2+C+BEd48JTwjqEVuIy0AcIMhzoizrElO8C0LSJCC1RcyCFERzYU3yhHYdiS8sM2 rXeWl/WXp7g8su0fGo2Jb7VD9/gCQ29edlf34RuP2N7xowKTLOJVrIF5hTAsYBBDCWK3 RymA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744065851; x=1744670651; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GnWAnNERAgsTQjx1b6/6KF+kVQdRz2nUFo/n4LALJ+A=; b=HIa0jwq2eQQE/mJQk46ySkXtox+jFtEQTSJSsGUS2NvI4n8X8HE/hF20GiLHucOCHJ 8opuk9MpXtO//ABVwfxaFV97V3QQTKdq89+FG6NxVf2AR88oRsamA84Hfl+5k6HFU6m0 OZPxuWhm2Ix7coc24Zmo30Va7W2HVIwXJ/qIoe7V4LckqhpzsUrPbqed7dT0C2cnDM+c 2l4p+mAyJS/df6FC4jgAFQ5oeObMvxnBzs8vqYlBz5XiPCJXNf4xTd0V1NPWZ1RCCmJD ChHyGuHMVmv5NLNS68syxCLGFZwWqMguaT3Yy+uVA0yzHdXmN3Ci11X9lgpAF2gPhyvk d1Cg== X-Forwarded-Encrypted: i=1; AJvYcCXXTQSFS8yGLY6tShKKi9rMGxmxIcTddP9UqA1z3HNX+Wy12CT7go/3dW1P5WuLr/kVghk/2Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0YytHJWuC17vNq2lG2F/Pxb/fIZyEo/xkU1zhalx7RYWFAUwhG+i prpcZf9dI/ppCwmDGlvFB9XCGn0BdwFov94vQdKUKEbW/ApkVWuokb7Xa+Qq X-Gm-Gg: ASbGncsiJHKnKLlypolidrDauOKRYy8yKJvG3pkl3n5b1KhXqB6Ct1ZkDVaJqPXfXJv 2boNWfbBTHAuTQ9qSFL2lMW7rKOhr+Y6f6bBdNq+gYhv+w4M/qQi7qMAnlHMEZsfWnUjBaT/64S 1PwtlAmxzseqaGYNkDdpRPq7Ne6mn8S4J/P5WvorFKAMxKss9JdwbymBXhpXEnLeSJl3r7ErR5y OdKyacx7j69yWuLuJjZy/7MqUQi9ytpONPRYZ/9soCgUh56D9EwYd0VYXArQOSlXlz4A2uYV3hz LBqNBABkcX7nkYscznzni64SSDF/CNpN/XmgI+pkyU8hYbE1ABhpePtDcN3dsExEFylO X-Google-Smtp-Source: AGHT+IEm3bhzenaO7uUTnJM7qh6zQjXsekFEvqFP5KGTNw2ySfpbqeXjw5y0/To8oY7u1crR9cXzCg== X-Received: by 2002:a05:620a:448e:b0:7c5:4f5f:15b7 with SMTP id af79cd13be357-7c775a0fe04mr1857157385a.21.1744065850696; Mon, 07 Apr 2025 15:44:10 -0700 (PDT) Received: from MacBook-Pro.local ([87.249.134.129]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c76ea9022dsm660597185a.104.2025.04.07.15.44.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 15:44:10 -0700 (PDT) From: Rahul Martim Juliato <rahuljuliato@HIDDEN> X-Google-Original-From: Rahul Martim Juliato <rahul.juliato@HIDDEN> To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Subject: Re: bug#77546: Acknowledgement (Regression in defaults: Re: Enhance 'icomplete-vertical-mode' customization options.) In-Reply-To: <87semk7xnv.fsf@HIDDEN> References: <87iknjuf3a.fsf@HIDDEN> <handler.77546.B.174384564629703.ack <at> debbugs.gnu.org> <CALDnm51VE1b0hH9kn-OHq1CWaAS4=Rw00esO9fNQZFqPbV+oiA@HIDDEN> <m2v7ri8vo2.fsf@HIDDEN> <m2tt72r2k7.fsf@HIDDEN> <CALDnm52QKmOviHa+zV1smOJzUpwWrfgREsruRRUpX=S1yU5NOw@HIDDEN> <87cydpa0jr.fsf@HIDDEN> <m2jz7werv7.fsf@HIDDEN> <87semk7xnv.fsf@HIDDEN> X-PGP-Key: https://www.rahuljuliato.com/rahul_pub_key.asc Date: Mon, 07 Apr 2025 19:44:06 -0300 Message-ID: <m2tt6zh9s9.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77546 Cc: Rahul Martim Juliato <rahuljuliato@HIDDEN>, 77546 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes: > > Ican take a look at this, but please give me a minimal Emacs -Q > recipe to see this icomplete-in-buffer vertical thing working in Sure! I tried to shave it down to basics. Still a bit long though: emacs -Q \ --eval "(setq tab-always-indent 'complete)" \ --eval "(setq icomplete-in-buffer t)" \ --eval "(setq icomplete-prospects-height 10)" \ --eval "(setq icomplete-scroll t)" \ --eval "(setq icomplete-vertical-in-buffer-adjust-list t)" \ --eval "(setq icomplete-vertical-render-prefix-indicator t)" \ --eval "(setq icomplete-vertical-selected-prefix-indicator \"> \")" \ --eval "(setq icomplete-vertical-unselected-prefix-indicator \" \")" \ --eval "(icomplete-mode 1)" \ --eval "(icomplete-vertical-mode 1)" \ --eval "(define-key icomplete-minibuffer-map (kbd \"C-n\") #'icomplete-fo= rward-completions)" \ --eval "(define-key icomplete-minibuffer-map (kbd \"C-p\") #'icomplete-ba= ckward-completions)" \ --eval "(advice-add #'completion-at-point :after #'minibuffer-hide-comple= tions)" I use this, with tab tab to complete and C-p / C-n to scroll the list. You could omit this if you use C-M-i: --eval "(setq tab-always-indent 'copmplete)" And this, as they are new options provided by the patch and these are defau= lts: --eval "(setq icomplete-vertical-selected-prefix-indicator \"> \")" \ --eval "(setq icomplete-vertical-unselected-prefix-indicator \" \")" \= =20=20 This defaults to 2, and will show only one candidate as you described, change at will: --eval "(setq icomplete-prospects-height 10)" \ --=20 Rahul
bug-gnu-emacs@HIDDEN:bug#77546; Package emacs.
Full text available.
Received: (at 77546) by debbugs.gnu.org; 7 Apr 2025 16:18:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 07 12:18:06 2025
Received: from localhost ([127.0.0.1]:56514 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1u1pAj-0002xS-Un
for submit <at> debbugs.gnu.org; Mon, 07 Apr 2025 12:18:06 -0400
Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:59486)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>)
id 1u1pAg-0002wb-RD
for 77546 <at> debbugs.gnu.org; Mon, 07 Apr 2025 12:18:03 -0400
Received: by mail-wr1-x430.google.com with SMTP id
ffacd0b85a97d-3914bc3e01aso2766544f8f.2
for <77546 <at> debbugs.gnu.org>; Mon, 07 Apr 2025 09:18:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1744042676; x=1744647476; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=TYqC1F5Mnwmpz0zdi+KBq+gspzp0qE7lB7xV95rFAz8=;
b=QbZiaDHj8WQCAbXldTNRqgxrLFk2y6BDridJuyN94piUw3YPV4Ccm54FqLuKCHxPea
I20GBasyriClujJXYxRsYuo6JN2vC8WtZIaCEPrRyd7nPGHaEYX4p2oVCnQrnog3GWRn
fzsnWsPPPX3zmMxdmTA/y2jtg3CvZCsQWZtXm1nX70svCcu55n5ddQ6WNpsmrq1BV2CK
m9t+xN22GjY9mdOeIZu20oxu2U0Dr3+9C1cPKSNkN+L1njMJ2umZD5J+S6ptI5KJOaRf
w3BuszxUeKCciqNsBi/GFAE+Fof8q1IBABF3AydNy+WH32YMbY2w90htFPbNybSDglm3
VJOQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1744042676; x=1744647476;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=TYqC1F5Mnwmpz0zdi+KBq+gspzp0qE7lB7xV95rFAz8=;
b=tmKv4g6mXBpun4VL53VgbAjpcyLujHViItVb05rokXkyy/hb75QMKo8lcmf+gUJ59m
TZg2t301ytNFgy97lNrsMzLc47b7jyj78VGQq6wElKjl0o1LC0wx3Bb3l2wpPbKzgAah
td6luQXBCCOmtrr9gwpqkW9AkOw/MUVhNEsZ1doZTjZIzcnCWXli0Q/xQkPX1t/XiaYJ
fU7JANAKuuX5rZtxl0UdGMV04d5BShN2ei19i8Du3DprQcBy0yoI0wSnAad16O08zPvb
OtrmXRcYg6NeHQ2xGpUe2807By2yKodjaIpi1vsEXUfFkcmTdwf56kGqWv4or6EPJEka
brWA==
X-Gm-Message-State: AOJu0Yw6wgXr2D2yyeoY4l+060jTopCVxyffDty5qesuAEZrFPTVvQjm
VBpBhvKSZlhmCZMtP43tlJp8wDTEMKtih1UbryB9T4PoaTo1XvxY7beU3A==
X-Gm-Gg: ASbGncsxdUQmlvGAN21ljtY1k3KrkA+GW9zoz4YDNCJn63HuAy8NZoAPZk5pxDnfGV+
sx4d4UK8NoXyJT6ezp1GwzCifeAQudJreazgdHeKX+4xXAD+pDnK36qrfcW5fPZ3yeN2QHgofia
6JF7qpJFJdhwuQjYWYXqVJfGDSpjU8i1rlFug8ptJN9tw+VzvjsXldCOPCm6rgoXyw7Hz8oxhJ6
P0+Ut5kt/JHf/VTCNwXsx92GyYV2P+g4imDgSFVX7cOZLqHnCnz+x0uBoyycqiCA73DiqcD1/uj
RJ9dc2/WqR9SK33cRnAHaJrp/cZK/o2swCaQJabKNSTL/0vWboe/7tsBBQ0w8w==
X-Google-Smtp-Source: AGHT+IFkixlF6ZAUiXYM8hKV459sdOcdKclwJ81ikPTkNvnu6WVJcduflnz5SAQhOL7R7wqx0cbh3g==
X-Received: by 2002:a5d:5f94:0:b0:390:fb37:1bd with SMTP id
ffacd0b85a97d-39d0de61c04mr12081730f8f.46.1744042675973;
Mon, 07 Apr 2025 09:17:55 -0700 (PDT)
Received: from krug (87-196-75-121.net.novis.pt. [87.196.75.121])
by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-39c301a79aasm12774280f8f.35.2025.04.07.09.17.54
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 07 Apr 2025 09:17:55 -0700 (PDT)
From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
To: Rahul Martim Juliato <rahuljuliato@HIDDEN>
Subject: Re: bug#77546: Acknowledgement (Regression in defaults: Re: Enhance
'icomplete-vertical-mode' customization options.)
In-Reply-To: <m2jz7werv7.fsf@HIDDEN>
References: <87iknjuf3a.fsf@HIDDEN>
<handler.77546.B.174384564629703.ack <at> debbugs.gnu.org>
<CALDnm51VE1b0hH9kn-OHq1CWaAS4=Rw00esO9fNQZFqPbV+oiA@HIDDEN>
<m2v7ri8vo2.fsf@HIDDEN> <m2tt72r2k7.fsf@HIDDEN>
<CALDnm52QKmOviHa+zV1smOJzUpwWrfgREsruRRUpX=S1yU5NOw@HIDDEN>
<87cydpa0jr.fsf@HIDDEN> <m2jz7werv7.fsf@HIDDEN>
Date: Mon, 07 Apr 2025 17:18:28 +0100
Message-ID: <87semk7xnv.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 77546
Cc: 77546 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Rahul Martim Juliato <rahuljuliato@HIDDEN> writes:
> Please feel free to edit my diff, we could:
>
> 1. keep both calls, like I just did in the patch, that are complementary
>
> 2. keep only the second call, and 'live with a very small inconsistency'
>
> 3. try to patch something else and figure out what is causing the race
> condition and how to tackle this.
>
>
> Phew, that's it. Thanks again for taking the time to review these
> changes :)
Ican take a look at this, but please give me a minimal Emacs -Q
recipe to see this icomplete-in-buffer vertical thing working in
practice. I can't really get it to work, or know how to activate it.
(Please no long configs or package installations if you can).
This is what I'm trying, for reference:
emacs -Q \
--eval '(setq icomplete-in-buffer t)' \
-f fido-vertical-mode \
--eval '(setq completion-styles (quote (flex)))' \
--eval '(advice-add (quote completion-at-point) \
:after \
(function minibuffer-hide-completions))'
It seems to do something but I always see just one candidate, no
vertical list to scroll. I've also tried with plain
icomplete-vertical-mode.
Jo=C3=A3o
bug-gnu-emacs@HIDDEN:bug#77546; Package emacs.
Full text available.
Received: (at 77546) by debbugs.gnu.org; 7 Apr 2025 00:29:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 06 20:29:48 2025
Received: from localhost ([127.0.0.1]:50224 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1u1aN1-0001Fn-Rm
for submit <at> debbugs.gnu.org; Sun, 06 Apr 2025 20:29:48 -0400
Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:61785)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <rahuljuliato@HIDDEN>)
id 1u1aMy-0001FF-EX
for 77546 <at> debbugs.gnu.org; Sun, 06 Apr 2025 20:29:45 -0400
Received: by mail-pf1-x42b.google.com with SMTP id
d2e1a72fcca58-73972a54919so3281163b3a.3
for <77546 <at> debbugs.gnu.org>; Sun, 06 Apr 2025 17:29:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1743985777; x=1744590577; darn=debbugs.gnu.org;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=7P84MtwhER1GCehd4tyQSG3++ACb7QeLcaAR9tCszsc=;
b=FxmxW0ZOhW50RP1YUcIQsIwCbvT5ZqXXi/ueuJkg04da1GMNqX1AznbI4xJCyJFf9h
kcm0zMbtmpEUf0wkXsX6oLeO2WC4XMvyIK+UXJ88TS2LMs9YUWrxUTXHZOrL2EEcfC4Y
pUQcnivOy8yqTcNwkjvrYsKiG2tIJEXK82g0ks5IfTsKLGYOc4ANCfbKktnaAACeBUqH
BVrwRp04hmjPaBDF8bQbsd/A6EKiQ8+alYtsjFXAtXH5PZvgjjnVLebrjI0Y/jLVrQvN
gkM8dgflK5kbN8PX/0K3uY3vN7Q3dhh/+d3APn5K2YiBtK1CWESm/pYl976UC9v8M38t
soaA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1743985777; x=1744590577;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=7P84MtwhER1GCehd4tyQSG3++ACb7QeLcaAR9tCszsc=;
b=MskXLGEAWDr1LLDPsgKCpNEp0iioM2MQ83iBUAFRzJ+6NN06VYMlKbWgkqaTYAWnwQ
yFmuwN0sL/jOGkv8nta3aTZSbQ8/MEyPAZI/pcOAgPoWOS/NNVzXI3z8BPCIGM6Kzep2
n4QUqEqCTF91DfMzQDx1UJRi/flNai8R5kxJe9VkOddDPTSQnpXoWt6rH3TdoNz6w7rj
oI4jejhNZKLQ4UKFwfyVVU+VnqOC6JHJmP4zfZWte/egjyEdmH3aDVRrhQJ5nCKNQg1R
1AdTuOH5eBXTHWqqk9hQdJ+gebyTZVUdua0AqFQRC+8juQ5pJDLxZOULHhpBiCdn82gP
AIUw==
X-Forwarded-Encrypted: i=1;
AJvYcCX7KlT6dftSIxI2cECUOPjVaC0nuE4kFL5uALIAJFA87gYZB2fKmY57w/nBUD3qZcs102RYqg==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yz6fL4taSZnq/hok2fqN0vmNSbebtm4yuENlJCi73rZdmd1EPA1
6s3Un0/iiRJxNeZk4FhU6lTs1v9N2krm/cxoa0vAD+0Q4EXJi/AZWlnrkA==
X-Gm-Gg: ASbGnct2b4WxRiI/gSrAPcfl6xLCDi9n6XSG5sVVkQ8l6L+W9tMRDpuWAKPxd4Ub7mq
e3PeuomNxxeOyZnuW/nazJZCj4S0W6dGvBl23Z40LXFUk+JiuP/IKR3v2gReelI4IsPDrREe3mM
31y1YnNEBOYu8lifnux0MtdaDWPt1NXDLZhy78AWoIBOXjezYBK6ZDTj7JxrzvuHb77IMQVMNkp
pphQgPHd1i28un5c3oZcEsamPGXCh/UDNxxWTwPUNF0Omvt99ElPLvYy2DeEz9Ytp8yfUImbiQi
V8j2VsGI3V+hiLtWiXxYKWOyK4DMmHd8TEyC0NP+BohIYGXiusfQnD98ZK2qxBtRnifiI2lHlvx
GQ0Imwrs=
X-Google-Smtp-Source: AGHT+IF+aRwlWU9j7Ref9QD8FBTJflEk1x3BQjVoGNKfYdRDlCYTBzeZM0vbFzHN1thunRCAeGQEYA==
X-Received: by 2002:a05:6a00:44c7:b0:736:34a2:8a23 with SMTP id
d2e1a72fcca58-739e7120149mr12864891b3a.15.1743985777363;
Sun, 06 Apr 2025 17:29:37 -0700 (PDT)
Received: from MacBook-Pro.local ([2804:7f0:9181:5e3f:f8c5:77ab:f0d1:ba03])
by smtp.gmail.com with ESMTPSA id
d2e1a72fcca58-739d97f1c4bsm7196070b3a.70.2025.04.06.17.29.35
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 06 Apr 2025 17:29:36 -0700 (PDT)
From: Rahul Martim Juliato <rahuljuliato@HIDDEN>
X-Google-Original-From: Rahul Martim Juliato <rahul.juliato@HIDDEN>
To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
Subject: Re: bug#77546: Acknowledgement (Regression in defaults: Re: Enhance
'icomplete-vertical-mode' customization options.)
In-Reply-To: <87cydpa0jr.fsf@HIDDEN>
References: <87iknjuf3a.fsf@HIDDEN>
<handler.77546.B.174384564629703.ack <at> debbugs.gnu.org>
<CALDnm51VE1b0hH9kn-OHq1CWaAS4=Rw00esO9fNQZFqPbV+oiA@HIDDEN>
<m2v7ri8vo2.fsf@HIDDEN> <m2tt72r2k7.fsf@HIDDEN>
<CALDnm52QKmOviHa+zV1smOJzUpwWrfgREsruRRUpX=S1yU5NOw@HIDDEN>
<87cydpa0jr.fsf@HIDDEN>
X-PGP-Key: https://www.rahuljuliato.com/rahul_pub_key.asc
Date: Sun, 06 Apr 2025 21:29:32 -0300
Message-ID: <m2jz7werv7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 77546
Cc: Rahul Martim Juliato <rahuljuliato@HIDDEN>, 77546 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes:
> I've pushed the patch with the fix and followed up with a simpler one
> that simply renames internal functions to be shorter and in-line with
> our convention for internal function names (it's icomplete--, not
> icomplete-vertical-- since icomplete-vertical.el doesn't exist).
>
Thanks! Much easiear to read.
> I've also noticed that you didn't update the hand-holding comments of
> icomplete--render-vertical, and that there's a suspicious double call to
> a new icomplete--ensure-visible-lines-inside-buffer function. I'm
> fairly sure this is only relevant for `icomplete--in-region-buffer' but
> I think the code should look like this. Can you try this patch after my
> sig?
>
Yeah it looks like it is duplicated, but there's a silly reason for
it. The first call could be removed with not much trouble. I'll explain
below.
--
I'm attaching another diff where I'm putting togheter some more stuff.
- Removed unecessary ':group' from the newer defcustoms and deffaces
- Made use of 'string-width' instead of lenght, so charts that might
vary on 'length' are proper counted, like "=E2=87=92e=CC=81".
These, together with a proper comenting of
`icomplete--ensure-vertical-completion-list-visible` was also suggested
by Stefan, so I changed your changes a bit trying to explain what I
meant by 'real lines' on
'icomplete--ensure-vertical-completion-list-visible' doc. Stefan told me
there are references to 'screen lines' and 'logical lines' elsewhere, I
tried to adapt this doc to follow this:
```
(defun icomplete--ensure-vertical-completion-list-visible ()
"Ensure the vertical completion list is visible.
Scroll the window so that there are at least `icomplete-prospects-height'
screen lines (i.e., visual lines, including wrapped lines) available
below point. Wrapped lines are counted individually."
````
Now for the good part. I already apologies for the headache.
> I'm
> fairly sure this is only relevant for `icomplete--in-region-buffer' but
Yes, you're right, the use of
`icomplete--ensure-vertical-completion-list-visible` is exclusively for
`icomplete--in-region-buffer`, thanks for removing the `minibufferp`
clause and adding `icomplete--in-region-buffer` where necessary.
In theory we could simply make use of a single entry like:
```
(when (and icomplete-scroll
icomplete--scrolled-completions
(null icomplete--scrolled-past))
;; Here, it should work with only this
(when icomplete--in-region-buffer
(icomplete--ensure-vertical-completion-list-visible))
```
Problem is: there is a small inconsistency here, IF the cursor is
somewhere on the bottom of the buffer, where the list won't fit, and you
try to complete, this will only make it fit if we've scrolled icomplete
before. So, the inconsitence: this will not ajust if needed on the first
time you complete, but from the second forward. Could I live with a
simple C-g, C-M-i once every time I fire Emacs and my first complete
happened to be on the last line (thus needing scrolling)? Sure, but I
also would love not have to do it, so, keep following :)
Ok, so, what about putting it as you suggested, as the first step of
Loopapalooza?
There's some racing condition if we wanna do it here, it will work, but
it will always fire-up twice, moving the buffer way more than needed. I
couldn't figure it out a mean to make this work properly.
That's the reason we're calling it "twice", the first condition will
only fire up if it is the first (non scrolled, non icomplete used)
state.
The second entry is there 'from the second completion' forward.
I tried a plethora of combinations with
`icomplete--scrolled-completions` and friends, the one that covers more
cases without refactoring too much code was this one. This is now
explained on commentaries you can find on the diff.
Also, I fixed some minor bug on your last diff where you called
`icomplete--ensure-vertical-completion-list-visible` without checking
for `icomplete--in-region-buffer` first and icomplete-vertical was
crashing on minibuffer.
Please feel free to edit my diff, we could:
1. keep both calls, like I just did in the patch, that are complementary
2. keep only the second call, and 'live with a very small inconsistency'
3. try to patch something else and figure out what is causing the race
condition and how to tackle this.
Phew, that's it. Thanks again for taking the time to review these
changes :)
--=-=-=
Content-Type: text/x-patch; charset=utf-8
Content-Disposition: attachment; filename=to-joao-icomplete.diff
Content-Transfer-Encoding: quoted-printable
Content-Description: patch to icomplete
lisp/icomplete.el | 60 ++++++++++++++++++++++++++++++++-------------------=
----
1 file changed, 35 insertions(+), 25 deletions(-)
diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index 35842b53e6b..dfc0a9dd0d2 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -118,13 +118,11 @@ icomplete-section
(defface icomplete-vertical-selected-prefix-indicator-face
'((t :inherit font-lock-keyword-face :weight bold :foreground "slate blu=
e"))
"Face used by `icomplete-vertical-selected-prefix-indicator'."
- :group 'icomplete
:version "31.1")
=20
(defface icomplete-vertical-unselected-prefix-indicator-face
'((t :inherit font-lock-keyword-face :weight normal :foreground "gray"))
"Face used by `icomplete-vertical-unselected-prefix-indicator'."
- :group 'icomplete
:version "31.1")
=20
;;;_* User Customization variables
@@ -185,7 +183,6 @@ icomplete-vertical-in-buffer-adjust-list
cursor position when the completion started, not on the first column, as
the default behavior."
:type 'boolean
- :group 'icomplete
:version "31.1")
=20
(defcustom icomplete-vertical-render-prefix-indicator nil
@@ -196,7 +193,6 @@ icomplete-vertical-render-prefix-indicator
remaining of the candidates will receive the indicator controlled
by `icomplete-vertical-unselected-prefix-indicator'."
:type 'boolean
- :group 'icomplete
:version "31.1")
=20
(defcustom icomplete-vertical-selected-prefix-indicator
@@ -210,7 +206,6 @@ icomplete-vertical-selected-prefix-indicator
By default, this is set to \"=C2=BB \" if the character is displayable,
otherwise, it falls back to \"> \"."
:type 'string
- :group 'icomplete
:version "31.1")
=20
(defcustom icomplete-vertical-unselected-prefix-indicator " "
@@ -220,7 +215,6 @@ icomplete-vertical-unselected-prefix-indicator
list. It can be further customized by the face
`icomplete-vertical-unselected-prefix-indicator-face'."
:type 'string
- :group 'icomplete
:version "31.1")
=20
;;;_* Initialization
@@ -890,8 +884,8 @@ icomplete--adjust-lines-for-column
(let* ((column (current-column))
(prefix-indicator-width
(if icomplete-vertical-render-prefix-indicator
- (max (length icomplete-vertical-selected-prefix-indicato=
r)
- (length icomplete-vertical-unselected-prefix-indica=
tor))
+ (max (string-width icomplete-vertical-selected-prefix-in=
dicator)
+ (string-width icomplete-vertical-unselected-prefix-=
indicator))
0))
(wrapped-line (with-current-buffer buffer
(save-excursion
@@ -899,7 +893,7 @@ icomplete--adjust-lines-for-column
(beginning-of-line)
(count-screen-lines (point) (car data)))))
(window-width (+ (window-hscroll) (window-body-width)))
- (longest-line-width (apply #'max (mapcar #'length lines)))
+ (longest-line-width (apply #'max (mapcar #'string-width lines=
)))
(spaces-to-add
(if (> wrapped-line 1)
(- column (* (- wrapped-line 1) (- window-width 5)))
@@ -914,16 +908,16 @@ icomplete--adjust-lines-for-column
lines))
lines))
=20
-(defun icomplete--ensure-visible-lines-inside-buffer ()
- "Ensure the completion list is visible in regular buffers only.
-Scrolls the screen to be at least `icomplete-prospects-height' real lines
-away from the bottom. Counts wrapped lines as real lines."
- (unless (minibufferp)
- (let* ((window-height (window-body-height))
- (current-line (count-screen-lines (window-start) (point)))
- (lines-to-bottom (- window-height current-line)))
- (when (< lines-to-bottom icomplete-prospects-height)
- (scroll-up (- icomplete-prospects-height lines-to-bottom))))))
+(defun icomplete--ensure-vertical-completion-list-visible ()
+ "Ensure the vertical completion list is visible.
+Scroll the window so that there are at least `icomplete-prospects-height'
+screen lines (i.e., visual lines, including wrapped lines) available
+below point. Wrapped lines are counted individually."
+ (let* ((window-height (window-body-height))
+ (current-line (count-screen-lines (window-start) (point)))
+ (lines-to-bottom (- window-height current-line)))
+ (when (< lines-to-bottom icomplete-prospects-height)
+ (scroll-up (- icomplete-prospects-height lines-to-bottom)))))
=20
(defun icomplete--add-indicator-to-selected (comp)
"Add indicator to completion COMP according to its selection state."
@@ -943,7 +937,20 @@ icomplete--render-vertical
(truncate (max-mini-window-lines) 1)))))
;; Welcome to loopapalooza!
;;
- ;; First, be mindful of `icomplete-scroll' and manual scrolls. If
+ ;; First, if the list hasn't been scrolled yet, we check whether the
+ ;; buffer should create some space for it. Such as when opening a
+ ;; buffer, jumping to the last line, and attempting to complete
+ ;; something. The following code will run only ONCE. After
+ ;; opening/closing the complete list for the first time, we call
+ ;; `icomplete--ensure-vertical-completion-list-visible' on the proper
+ ;; place.
+ (when (and icomplete-scroll
+ icomplete--in-region-buffer
+ (not icomplete--scrolled-completions)
+ (not icomplete--scrolled-past))
+ (icomplete--ensure-vertical-completion-list-visible))
+
+ ;; Then, be mindful of `icomplete-scroll' and manual scrolls. If
;; `icomplete--scrolled-completions' and `icomplete--scrolled-past'
;; are:
;;
@@ -953,14 +960,17 @@ icomplete--render-vertical
;; example);
;; - non-nil and nil, respectively, a refiltering took place and we
;; may need to readjust them to the new filtered `comps'.
- (when (and icomplete-scroll
- (not icomplete--scrolled-completions)
- (not icomplete--scrolled-past))
- (icomplete--ensure-visible-lines-inside-buffer))
(when (and icomplete-scroll
icomplete--scrolled-completions
(null icomplete--scrolled-past))
- (icomplete--ensure-visible-lines-inside-buffer)
+
+ ;; This runs on every completion list render except the first (i.e., b=
efore
+ ;; the first scroll occurs). Therefore, the earlier call to
+ ;; `icomplete--ensure-vertical-completion-list-visible' isn't redundan=
t,
+ ;; even though it may appear to be.
+ (when icomplete--in-region-buffer
+ (icomplete--ensure-vertical-completion-list-visible))
+
(cl-loop with preds
for (comp . rest) on comps
when (equal comp (car icomplete--scrolled-completions))
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#77546; Package emacs.
Full text available.
Received: (at 77546) by debbugs.gnu.org; 6 Apr 2025 13:20:33 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 06 09:20:33 2025
Received: from localhost ([127.0.0.1]:46573 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1u1PvN-0003bn-Bp
for submit <at> debbugs.gnu.org; Sun, 06 Apr 2025 09:20:33 -0400
Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:56772)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>)
id 1u1PvK-0003bJ-BW
for 77546 <at> debbugs.gnu.org; Sun, 06 Apr 2025 09:20:30 -0400
Received: by mail-wm1-x32d.google.com with SMTP id
5b1f17b1804b1-43edecbfb94so15623465e9.1
for <77546 <at> debbugs.gnu.org>; Sun, 06 Apr 2025 06:20:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1743945624; x=1744550424; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=f61NOybrGLMSpq7uSQzWBpyuKj/qwu3FxbvP3KwrEbo=;
b=TeGusld4qko3Y5wx7rk0qkQ6MAAg2hNmbCtTOtS+E4ekuFmjG0PZobtga9c3GnAjw1
71KRRAF7X0kg5yNxEB41RA6y60SHjmiFkTZJaWl/qtdr893gIk5Cw6jIT1gR28DeSnR7
mVPyyn+/aWjJAEtkftBi/9Pq/vA2TBPqbEtoA/Od/teCdb2XHhASSCQh6q1xX0zqc6aU
k7G9t4/DgCdU5nKPGgeXHdH0x+ES9dO1V+X8xKOUX8COOLG2gu6ZApbIrL44wau9a49P
toEHNCgQFQ+pEiuMmfj+mP29f9vVt5PIWASV3nEyKLpI0vL9Tz/yX2pIauZSe4/CIH0Y
PDbg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1743945624; x=1744550424;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=f61NOybrGLMSpq7uSQzWBpyuKj/qwu3FxbvP3KwrEbo=;
b=WdFWpFOKrXvzaY1YjXhayB7wQ49kUF2v0E7rP5fdnh+EywFLa01uZROd5ef2n8Yry0
g8zHnIXFFhEkVGm+YZfuJh7X6RO1d6Aur4a8kHHXZKga5L49mMZTVqx7RVMFv0CWWVnD
3M3uhD8gM6mv5n1na6K5ShUKN2uQ/MEdaGUVk0ydlKNci6uxNwRoL8kxk8HHvdqmuT3W
Z8hGkRPfru3jRj3M8QamS1r6z2fS4z5+y519cT9NxTJ+EMGCayxEk03FcX6do+jcgYUb
8/MVuB7KiWfHpG3fGbfiUUX5+Miu6PF7RhbcsvWhGzM3W3XbNvBaDESySPuVkoLZ+pW/
s4xg==
X-Gm-Message-State: AOJu0Yz0BKZ86NyDS4SA7ZnfnTjAbFDiZBAQH364lOSqyh2SgTh5oFyG
kJdvHt15Yd3cNxPMVfR3mxKRqV+trDV9aGqFJ4MMMvP9AU2kNT8oSnr8xQ==
X-Gm-Gg: ASbGncudPcpjfxqzJkV1/LBk9szCLzCGMd27/TzRNYTYb5lk5CbmqWTctlsvw0jFSWr
McNnkGdHa322NHkptCtDZmxqvByD/tS+d0OmjvtIWoDGBs/4kMfSzPZP5yppmSI7oFcPtQR+aYE
MZb/5uDaYX72OCl4ZdcWQXsdPLw44PNeMpoR6bRYSpLUj4hGeKvzxkhq9xQnxIrXitpD3mY9UJh
/PLXROkGYuVgK1od7xV1DR+XZ5jUmhmaI6UGl1zbUCJj/3ul0sRulRgKynH5PEoPXWsyyuYC0NU
L5RGZcqKfjdV9YjkbIw8IWMn7ZGw4Dhwpt/CMRbMniUfS0eMKm+O4wZy4Ikv2Q==
X-Google-Smtp-Source: AGHT+IHHVoJcSRcN1MIdh8pzMdCfkJvrKkLTOHebp/k8x0dXgN/pJK27E+qpHFb+Nn4l33t6Rw/pYA==
X-Received: by 2002:a05:600c:3d98:b0:43d:878c:7c40 with SMTP id
5b1f17b1804b1-43ed0bc78e8mr102276755e9.10.1743945623640;
Sun, 06 Apr 2025 06:20:23 -0700 (PDT)
Received: from krug (87-196-72-236.net.novis.pt. [87.196.72.236])
by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-39c3020d64dsm9567488f8f.70.2025.04.06.06.20.22
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 06 Apr 2025 06:20:23 -0700 (PDT)
From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
To: Rahul Martim Juliato <rahuljuliato@HIDDEN>
Subject: Re: bug#77546: Acknowledgement (Regression in defaults: Re: Enhance
'icomplete-vertical-mode' customization options.)
In-Reply-To: <CALDnm52QKmOviHa+zV1smOJzUpwWrfgREsruRRUpX=S1yU5NOw@HIDDEN>
References: <87iknjuf3a.fsf@HIDDEN>
<handler.77546.B.174384564629703.ack <at> debbugs.gnu.org>
<CALDnm51VE1b0hH9kn-OHq1CWaAS4=Rw00esO9fNQZFqPbV+oiA@HIDDEN>
<m2v7ri8vo2.fsf@HIDDEN> <m2tt72r2k7.fsf@HIDDEN>
<CALDnm52QKmOviHa+zV1smOJzUpwWrfgREsruRRUpX=S1yU5NOw@HIDDEN>
Date: Sun, 06 Apr 2025 14:20:56 +0100
Message-ID: <87cydpa0jr.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 77546
Cc: 77546 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes:
> That's ok. Thanks for confirming and testing. I'll push the patch later a=
nd close this.
I've pushed the patch with the fix and followed up with a simpler one
that simply renames internal functions to be shorter and in-line with
our convention for internal function names (it's icomplete--, not
icomplete-vertical-- since icomplete-vertical.el doesn't exist).
I've also noticed that you didn't update the hand-holding comments of
icomplete--render-vertical, and that there's a suspicious double call to
a new icomplete--ensure-visible-lines-inside-buffer function. I'm
fairly sure this is only relevant for `icomplete--in-region-buffer' but
I think the code should look like this. Can you try this patch after my
sig?
Jo=C3=A3o
diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index 35842b53e6b..481e7164889 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -914,16 +914,15 @@ icomplete--adjust-lines-for-column
lines))
lines))
=20
-(defun icomplete--ensure-visible-lines-inside-buffer ()
- "Ensure the completion list is visible in regular buffers only.
-Scrolls the screen to be at least `icomplete-prospects-height' real lines
+(defun icomplete--ensure-vertical-completion-list-visible ()
+ "Ensure vertical completion list is visible.
+Scroll the screen to be at least `icomplete-prospects-height' real lines
away from the bottom. Counts wrapped lines as real lines."
- (unless (minibufferp)
- (let* ((window-height (window-body-height))
- (current-line (count-screen-lines (window-start) (point)))
- (lines-to-bottom (- window-height current-line)))
- (when (< lines-to-bottom icomplete-prospects-height)
- (scroll-up (- icomplete-prospects-height lines-to-bottom))))))
+ (let* ((window-height (window-body-height))
+ (current-line (count-screen-lines (window-start) (point)))
+ (lines-to-bottom (- window-height current-line)))
+ (when (< lines-to-bottom icomplete-prospects-height)
+ (scroll-up (- icomplete-prospects-height lines-to-bottom)))))
=20
(defun icomplete--add-indicator-to-selected (comp)
"Add indicator to completion COMP according to its selection state."
@@ -943,7 +942,11 @@ icomplete--render-vertical
(truncate (max-mini-window-lines) 1)))))
;; Welcome to loopapalooza!
;;
- ;; First, be mindful of `icomplete-scroll' and manual scrolls. If
+ ;; First, take care of a special case for icomplete--in-region-buffer
+ (when icomplete--in-region-buffer
+ (icomplete--ensure-vertical-completion-list-visible))
+
+ ;; Then, be mindful of `icomplete-scroll' and manual scrolls. If
;; `icomplete--scrolled-completions' and `icomplete--scrolled-past'
;; are:
;;
@@ -953,14 +956,9 @@ icomplete--render-vertical
;; example);
;; - non-nil and nil, respectively, a refiltering took place and we
;; may need to readjust them to the new filtered `comps'.
- (when (and icomplete-scroll
- (not icomplete--scrolled-completions)
- (not icomplete--scrolled-past))
- (icomplete--ensure-visible-lines-inside-buffer))
(when (and icomplete-scroll
icomplete--scrolled-completions
(null icomplete--scrolled-past))
- (icomplete--ensure-visible-lines-inside-buffer)
(cl-loop with preds
for (comp . rest) on comps
when (equal comp (car icomplete--scrolled-completions))
bug-gnu-emacs@HIDDEN:bug#77546; Package emacs.
Full text available.Received: (at 77546) by debbugs.gnu.org; 5 Apr 2025 17:06:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 05 13:06:08 2025 Received: from localhost ([127.0.0.1]:44575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u16y8-0005k1-M4 for submit <at> debbugs.gnu.org; Sat, 05 Apr 2025 13:06:08 -0400 Received: from mail-oa1-x2e.google.com ([2001:4860:4864:20::2e]:53713) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1u16y6-0005jS-Dp for 77546 <at> debbugs.gnu.org; Sat, 05 Apr 2025 13:06:06 -0400 Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-2c873231e7bso1735426fac.3 for <77546 <at> debbugs.gnu.org>; Sat, 05 Apr 2025 10:06:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743872760; x=1744477560; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VxjF0jRSCB3MVKvIZdr33QmGcgjVa0axz4PfkWbVGXc=; b=Vpuj5wpt53xPEIFLjtT25BhJ6tVa6KXhlfQT0ItVKiHYyykcgn8IHq/0vIYJ88Ndae DkKsI8vbQxysooU8K33DuB6haFC7U18FBzvTZBE0P2lBGiPjFF8dNGsefgJ3RGM2t2Cf Vax5I7HRr2O1Y8Qu0Dq8omlo3+/drDwM8J/mLtIW8QccZFN9GM1Kv2TUjsN2lbEiZyXr 0KlZoY4fmcI6X/XY/U9s5lhBIoNkWtAZbxbpt1kGIAtfEm+pW2g2c2BwXCD7iykbHrXQ U3ppNpA+Vcq6ZBt/XAMjCLlRVZFFLBl3Izdqzv9Ydcox2pvKEhGBY0kvYn2Y5aQcwOX0 zdbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743872760; x=1744477560; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VxjF0jRSCB3MVKvIZdr33QmGcgjVa0axz4PfkWbVGXc=; b=DwuX4oDcqGAgu04Y08jmyk4hj+G3BrGAhCFbQVRj4oVWgUjYxzraO58Dp/yQe20D3W eSxaljt7sMyn25OzEWrGC+CNjHrNHmscW6MZ5CCptEU79EABbnjAxxdCzhQVM7zSIYjW y4Hc++PW9h0wD+Anv3JV6/eM6r9R2pDiDn5GDBxtfwWmSRcu9NLe09XF3OqbAYchkWFy xWgkkOTyOTjJvIoQ3iBAy2ddPYtlIcxVa0sKqSWktDU4VZA3IZy3kIQglJCJAKOY5P5O NdhJN33uRt+fp6d8KPqTuXmi0J5jChSZLbimiUzd1w6goPE0chFHF82qTkCm4k4c6zFy +5rQ== X-Gm-Message-State: AOJu0Yyavj8o+7udZicNE7Zsj1rBrsr2aQC3gDQx8yyCde31bUOPip7B KuTKxdISM1/4CivE/uWY7DHVtcjfbtJmd8JleDeY81PNTWvZCNwiXH2wqeRKOoEwjY4mcmW+Aap 2oeuc2mShliD/WXyMRZEEVgvrwHM= X-Gm-Gg: ASbGncubN+Qqx/W91Kday5F+Xvz+PdZ3/NGlSH0BEGI516CEjFDKKEOZjIrn/t8c/bh K9ILR4w+IvCcRPXmL8kLH8ET5496axji8Md5CbQ4xUcP5jtrRDWq9I4iw8uLG8T0Zea5TTju4Rw vmytjOoNGmDO2k0AcP8Tfch7ssAg== X-Google-Smtp-Source: AGHT+IEAY2f/fhx6Ax1+h9lF4n6tPSfjjDBx6uCLqb4bhBQzSYjg+U6Q0+WEkc9EET4QdAY8nsF4pwptKaxtGLyiIbU= X-Received: by 2002:a05:6870:2ce:b0:29e:27b6:bea5 with SMTP id 586e51a60fabf-2cc9e7ec5b8mr3991629fac.25.1743872760222; Sat, 05 Apr 2025 10:06:00 -0700 (PDT) MIME-Version: 1.0 References: <87iknjuf3a.fsf@HIDDEN> <handler.77546.B.174384564629703.ack <at> debbugs.gnu.org> <CALDnm51VE1b0hH9kn-OHq1CWaAS4=Rw00esO9fNQZFqPbV+oiA@HIDDEN> <m2v7ri8vo2.fsf@HIDDEN> <m2tt72r2k7.fsf@HIDDEN> In-Reply-To: <m2tt72r2k7.fsf@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Sat, 5 Apr 2025 18:05:50 +0100 X-Gm-Features: ATxdqUFDyjN-cFwGw7AJiiAqCy5krJ4FABoBVGpS0YB7FTiJokgrrOifN6YEsqI Message-ID: <CALDnm52QKmOviHa+zV1smOJzUpwWrfgREsruRRUpX=S1yU5NOw@HIDDEN> Subject: Re: bug#77546: Acknowledgement (Regression in defaults: Re: Enhance 'icomplete-vertical-mode' customization options.) To: Rahul Martim Juliato <rahuljuliato@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000681ce106320b0446" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77546 Cc: 77546 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000681ce106320b0446 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable That's ok. Thanks for confirming and testing. I'll push the patch later and close this. Jo=C3=A3o T=C3=A1vora On Sat, Apr 5, 2025, 17:33 Rahul Martim Juliato <rahuljuliato@HIDDEN> wrote: > Rahul Martim Juliato <rahuljuliato@HIDDEN> writes: > > > > It looks like this got wrapped by the mail client, just so anyone else > > can copy/paste your diff: > > Small addendum, I feel silly, my copy of your diff was also wrapped. > > Attaching it here :) > > --000000000000681ce106320b0446 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div>That's ok. Thanks for confirming and testing. I&= #39;ll push the patch later and close this.</div><div><br></div><div data-s= martmail=3D"gmail_signature">Jo=C3=A3o T=C3=A1vora</div></div><br><div clas= s=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_att= r">On Sat, Apr 5, 2025, 17:33 Rahul Martim Juliato <<a href=3D"mailto:ra= huljuliato@HIDDEN">rahuljuliato@HIDDEN</a>> wrote:<br></div><block= quote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1= px solid rgb(204,204,204);padding-left:1ex">Rahul Martim Juliato <<a hre= f=3D"mailto:rahuljuliato@HIDDEN" target=3D"_blank" rel=3D"noreferrer">ra= huljuliato@HIDDEN</a>> writes:<br> <br> <br> > It looks like this got wrapped by the mail client, just so anyone else= <br> > can copy/paste your diff:<br> <br> Small addendum, I feel silly, my copy of your diff was also wrapped.<br> <br> Attaching it here :)<br> <br> </blockquote></div> --000000000000681ce106320b0446--
bug-gnu-emacs@HIDDEN:bug#77546; Package emacs.
Full text available.
Received: (at 77546) by debbugs.gnu.org; 5 Apr 2025 16:33:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 05 12:33:26 2025
Received: from localhost ([127.0.0.1]:44513 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1u16SU-00018x-Cz
for submit <at> debbugs.gnu.org; Sat, 05 Apr 2025 12:33:26 -0400
Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]:61523)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <rahuljuliato@HIDDEN>)
id 1u16SS-00018h-44
for 77546 <at> debbugs.gnu.org; Sat, 05 Apr 2025 12:33:24 -0400
Received: by mail-pf1-x42e.google.com with SMTP id
d2e1a72fcca58-736c3e7b390so2746241b3a.2
for <77546 <at> debbugs.gnu.org>; Sat, 05 Apr 2025 09:33:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1743870798; x=1744475598; darn=debbugs.gnu.org;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=46i3aSIE9Nxf5jwQDmANrcB9kPJZJ74pzyKt2S2QAYA=;
b=UVdDtPqgt6/pgDcDkTEItcQ8pf72r8siD+GosycyI1Gpze8wpNTPl46adiZsuEwXLa
b6k7Vx9DtG7yCTaJOp3/lRtDGUpTZxw8vtXSostTXjPqx39MU+itKxqijrtXyIkRhGzs
nB8/DPmGDQz8XXEdlOW9mx8TUSk3Sr2t8/1CIR10RKQFdnGPHL6VST8gHYpKMGHH8Klg
PixSm6bZNF3n4tTHrxEXwx34V38cvshBRGh25ry4p1nP/0Z9mkpizp2HAGEgUArtLzGS
QZTIAcmm9Qu21RjotVVb0xBBWLY+7u9+eXICwjrml6Ct3Map+4jtK7qylC4EV2C+pGcK
LtYg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1743870798; x=1744475598;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=46i3aSIE9Nxf5jwQDmANrcB9kPJZJ74pzyKt2S2QAYA=;
b=J0/XqJd1qlIk9t3tgskFlgAEdZVZJ2nEJz3kF3ye8840f4JYSCiy7yyR6yMaCa7y4Q
GYBq4LxlCWyCyjV6UFKg2RxVxSFmaS6IIQXFPCEE9NsUe7fQUa05u7vQ4ZXdCXnZJ60F
8m4Xf7gRhMhOJ+8oNrpUirvh+1+SYHx+SfoXa12R1+fYdf4waECCvZJxljx2V1YqSPTW
oVdyHK7Q6We2g4ym8i4EwU25SJxc9ssELZ0jN7yzNADd0SiRR0GcsXEXj3gLFKCHrwc/
LMmplC+ckyjPU6cojL/RzxL8TUe1mOv6bV5jJp6QmVJD2TTCejUrgT3wb2oDO3VwVel/
3mlA==
X-Forwarded-Encrypted: i=1;
AJvYcCUbIkqPOGkHPILL5y268miEo+fb8xeDC8tDoVnVQXgPq/5iPYb96yy7yM7P3lpl3rvzGR3HQQ==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YxSkgOggNMzsvvCpnvllzPcs6Fc7K1PJcRhwCRV3EVhDQ0a9Ug4
1KEXG2uzgAC1IzUKOyUkIL4PkfUKcRhG2gDtRHIq/dbrIk6EDGZbSUZ2fQ==
X-Gm-Gg: ASbGncsNbDHtxV4Us3DvgLIjbfMXqccVSwxipGf4fmxQmPaahcuWkwWxiIVKSnimnCq
HVRYaw5mew2z9fCI6Y7dzIuz9bAMAMx35uraxac2oWJh7IqvhSwqKMVF0O3gdrP4G6hexpsdfzo
Q5UPaw03yKitufGBCbWllakDO5kkYj2Mm4iu4Px8z33t7f+3pq88HsJnHWs1OTsYVTK9YBNJXR7
HTvQwcDziJQs4+BjpCT+gZ80+HDWLgdgChpM1KRzH5q4o8+ijAYr5SD+5cUJsrMdiyUh9sI2qeH
QzikUvJuwykgp1N6qEXjuRsFfDGERrgLHihvqXvHBFuZ7COboDUHeOaYcrKUDRePc4VoYOIu5DE
rHcM4Ew8=
X-Google-Smtp-Source: AGHT+IEShSFXT418Yei0kN939dZc3AOE6VPN4t/sNzutj5edUZpftdQE72OGUBjfxSHd/9LRQAxJQw==
X-Received: by 2002:a05:6a00:114f:b0:739:4a30:b902 with SMTP id
d2e1a72fcca58-739e6fbc95emr8957601b3a.2.1743870797435;
Sat, 05 Apr 2025 09:33:17 -0700 (PDT)
Received: from MacBook-Pro.local ([2804:7f0:9181:5e3f:24c7:942a:297c:b481])
by smtp.gmail.com with ESMTPSA id
d2e1a72fcca58-739da0e7258sm5420907b3a.169.2025.04.05.09.33.15
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 05 Apr 2025 09:33:16 -0700 (PDT)
From: Rahul Martim Juliato <rahuljuliato@HIDDEN>
X-Google-Original-From: Rahul Martim Juliato <rahul.juliato@HIDDEN>
To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
Subject: Re: bug#77546: Acknowledgement (Regression in defaults: Re: Enhance
'icomplete-vertical-mode' customization options.)
In-Reply-To: <m2v7ri8vo2.fsf@HIDDEN>
References: <87iknjuf3a.fsf@HIDDEN>
<handler.77546.B.174384564629703.ack <at> debbugs.gnu.org>
<CALDnm51VE1b0hH9kn-OHq1CWaAS4=Rw00esO9fNQZFqPbV+oiA@HIDDEN>
<m2v7ri8vo2.fsf@HIDDEN>
X-PGP-Key: https://www.rahuljuliato.com/rahul_pub_key.asc
Date: Sat, 05 Apr 2025 13:33:12 -0300
Message-ID: <m2tt72r2k7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 77546
Cc: Rahul Martim Juliato <rahuljuliato@HIDDEN>, 77546 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Rahul Martim Juliato <rahuljuliato@HIDDEN> writes:
> It looks like this got wrapped by the mail client, just so anyone else
> can copy/paste your diff:
Small addendum, I feel silly, my copy of your diff was also wrapped.
Attaching it here :)
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=icomplete-joao-tavora-patch.diff
Content-Description: icomplete-patch
diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index d0cc5674ba7..1ccfcc3edf4 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -927,8 +927,7 @@ icomplete-vertical--ensure-visible-lines-inside-buffer
(defun icomplete-vertical--add-indicator-to-selected (comp)
"Add indicators to the selected/unselected COMP completions."
- (if (and icomplete-vertical-render-prefix-indicator
- (get-text-property 0 'icomplete-selected comp))
+ (if (get-text-property 0 'icomplete-selected comp)
(concat (propertize icomplete-vertical-selected-prefix-indicator
'face 'icomplete-vertical-selected-prefix-indicator-face)
comp)
@@ -1012,8 +1011,11 @@ icomplete--render-vertical
;; Serialize completions and section titles into a list
;; of lines to render
(cl-loop
- for (comp prefix suffix section) in tuples
- do (setq comp (icomplete-vertical--add-indicator-to-selected comp))
+ for (comp-no-indicator prefix suffix section) in tuples
+ for comp =
+ (if icomplete-vertical-render-prefix-indicator
+ (icomplete-vertical--add-indicator-to-selected comp-no-indicator)
+ comp-no-indicator)
when section
collect (propertize section 'face 'icomplete-section) into lines-aux
and count 1 into nsections-aux
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#77546; Package emacs.
Full text available.
Received: (at 77546) by debbugs.gnu.org; 5 Apr 2025 15:39:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 05 11:39:39 2025
Received: from localhost ([127.0.0.1]:44373 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1u15cQ-0006v1-OR
for submit <at> debbugs.gnu.org; Sat, 05 Apr 2025 11:39:39 -0400
Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:48636)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <rahuljuliato@HIDDEN>)
id 1u15cO-0006ul-1w
for 77546 <at> debbugs.gnu.org; Sat, 05 Apr 2025 11:39:36 -0400
Received: by mail-pl1-x62a.google.com with SMTP id
d9443c01a7336-224019ad9edso40008235ad.1
for <77546 <at> debbugs.gnu.org>; Sat, 05 Apr 2025 08:39:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1743867569; x=1744472369; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=UTtTnk4QzLn5DOvDfTuZ5nFReCb3rQZwp3st1q/HEFk=;
b=KedS3RAjknpkJkQ1mPrDJAg63QqIc1fU/3kuy87gg6rUGckcRbl8xf3BGsFb4xTmFO
MYaM6mHOQEJqFAjQTcQ+dFnJzL8020xZmBjB5+yvabRKZHRC9x34Fj5XgGiU/Y59fY1b
DsjHSY3UBgNapy+cIFNP85c0f9ICkdPU0Cw7xSnzByD2y5RqfZd6OTaCAUznhZJPwBLs
y4SZvnXylk5UTRmq+Iwf4hosEd9J2QQ45VJpmVJCF7WywEjbjoNEhi8lelwLhiM7BB1B
niqs5QPAEDnuUS4Gd/u47hThTqRxAfkhDEcJcqXK74bd+czifjciZTKu0mnttLIV0372
PWqw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1743867569; x=1744472369;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=UTtTnk4QzLn5DOvDfTuZ5nFReCb3rQZwp3st1q/HEFk=;
b=VyDHJabeq2BOTqTyhkyFUgG+IGfrwIH0ghteMLdZ7p4GWuuuNDwPqD4Lyw8CmEiEqz
d90BISZ7hjD4zyLxN6iQccRTM6dqlXrnZYYAt5cs+L7SDFk8PZNSlAcsZXuzL5fJpAlz
sikidutqckYrMx7NDTWXqMJrVAyp0D4xBkkhEU3mYn1+cQN2GWEigpccszjlOJp+9SNG
6jmXdNAejz9xgxa8MPmCDCMHac6oafZ60sSXF+fOitPJ77+EvUKP/jOWxciqOGY+KXor
41gae9RVkJHD0loeqj0GERgqzeQxk6143vccwzCgnuuvqxCfkoZj4SijUYZJ2RaPRLmC
Vtlg==
X-Gm-Message-State: AOJu0Yy+IdsKtQdmGZxns6hTspLCVrbr+lcYTDAFcy8q+tSAneRxbGIm
NHzuktPB/na3wEQLL5lU16RYEelrES1hpn3usyawTQyZ9BE4KrSIgrTz6g==
X-Gm-Gg: ASbGncu1OgFIQtdMdALnEDcIf6Lt6o6BN575We0D0qmuthVS79C1m7tM40zcr48atIQ
jNEruS2KP3do6OwDhMQvOutkdiBwc3UuBHs0Hab5z2Nj5BUsrZeMQ4NiLPi7C3FFBGrjPspN7UG
OENiMK7DVNU4S+TNLuTKIHoWgI85kastVCpKA3C/0QJ8Jc1DNMFKR2rDJwoWikLOSvBI6V/b8+9
iSiyTx0r6J0IenkiIPsT7h2BLtHlSON2dxhJxvpWJVzkDqN5mL5PCh2rCeXBzBjsvzT/iG784bn
AtG9M3YSwQMTgWhFBqpv/fbcN8ioacA8P4xpCw198PTx1yy9qni89+OHzWTeABfv8OHPxZ+lCbx
GU595ZB86HXSg
X-Google-Smtp-Source: AGHT+IFCmrcIpbkEgmJVdzGPFGCpFAzG3UWiSEr2hb/gr27lLYk3RquvJV24tddIf1fit4qO1I+8NQ==
X-Received: by 2002:a17:902:c941:b0:220:c067:7be0 with SMTP id
d9443c01a7336-22a954f60afmr29974965ad.6.1743867569096;
Sat, 05 Apr 2025 08:39:29 -0700 (PDT)
Received: from MacBook-Pro.local ([2804:7f0:9181:5e3f:352c:8b81:f49c:d56e])
by smtp.gmail.com with ESMTPSA id
41be03b00d2f7-af9bc318707sm4583089a12.17.2025.04.05.08.39.27
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 05 Apr 2025 08:39:28 -0700 (PDT)
From: Rahul Martim Juliato <rahuljuliato@HIDDEN>
X-Google-Original-From: Rahul Martim Juliato <rahul.juliato@HIDDEN>
To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
Subject: Re: bug#77546: Acknowledgement (Regression in defaults: Re: Enhance
'icomplete-vertical-mode' customization options.)
In-Reply-To: <CALDnm51VE1b0hH9kn-OHq1CWaAS4=Rw00esO9fNQZFqPbV+oiA@HIDDEN>
References: <87iknjuf3a.fsf@HIDDEN>
<handler.77546.B.174384564629703.ack <at> debbugs.gnu.org>
<CALDnm51VE1b0hH9kn-OHq1CWaAS4=Rw00esO9fNQZFqPbV+oiA@HIDDEN>
X-PGP-Key: https://www.rahuljuliato.com/rahul_pub_key.asc
Date: Sat, 05 Apr 2025 12:39:25 -0300
Message-ID: <m2v7ri8vo2.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 77546
Cc: 77546 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes:
> This seems to be just a bug in the implementation. This patch
> fixes it (and fixes some odd cl-loop usage as well):
>
>
Nice catch!
Thanks for this patch Jo=C3=A3o, I agree with you the icomplete enhancements
should not touch defaults.
> (concat (propertize icomplete-vertical-selected-prefix-indicator
> 'face
> 'icomplete-vertical-selected-prefix-indicator-face)
> comp)
It looks like this got wrapped by the mail client, just so anyone else
can copy/paste your diff:
diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index d0cc5674ba7..1ccfcc3edf4 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -927,8 +927,7 @@ icomplete-vertical--ensure-visible-lines-inside-buffer
(defun icomplete-vertical--add-indicator-to-selected (comp)
"Add indicators to the selected/unselected COMP completions."
- (if (and icomplete-vertical-render-prefix-indicator
- (get-text-property 0 'icomplete-selected comp))
+ (if (get-text-property 0 'icomplete-selected comp)
(concat (propertize icomplete-vertical-selected-prefix-indicator
'face 'icomplete-vertical-selected-prefix-indica=
tor-face)
comp)
@@ -1012,8 +1011,11 @@ icomplete--render-vertical
;; Serialize completions and section titles into a list
;; of lines to render
(cl-loop
- for (comp prefix suffix section) in tuples
- do (setq comp (icomplete-vertical--add-indicator-to-selected comp))
+ for (comp-no-indicator prefix suffix section) in tuples
+ for comp =3D
+ (if icomplete-vertical-render-prefix-indicator
+ (icomplete-vertical--add-indicator-to-selected comp-no-indicator)
+ comp-no-indicator)
when section
collect (propertize section 'face 'icomplete-section) into lines-aux
and count 1 into nsections-aux
I just tested it and can confirm that the issue you described is fixed,
and the new features still seem to be working as expected.
Could you clarify something else for me?
What=E2=80=99s the usual protocol here? Do we wait for a maintainer to pick=
up
the bug and merge the fix?
Thanks again!
bug-gnu-emacs@HIDDEN:bug#77546; Package emacs.
Full text available.
Received: (at 77546) by debbugs.gnu.org; 5 Apr 2025 12:18:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 05 08:18:11 2025
Received: from localhost ([127.0.0.1]:41848 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1u12TS-0001WH-Nc
for submit <at> debbugs.gnu.org; Sat, 05 Apr 2025 08:18:11 -0400
Received: from mail-oa1-x34.google.com ([2001:4860:4864:20::34]:61508)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>)
id 1u12TR-0001W3-5N
for 77546 <at> debbugs.gnu.org; Sat, 05 Apr 2025 08:18:09 -0400
Received: by mail-oa1-x34.google.com with SMTP id
586e51a60fabf-2a01bcd0143so3503228fac.2
for <77546 <at> debbugs.gnu.org>; Sat, 05 Apr 2025 05:18:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1743855483; x=1744460283; darn=debbugs.gnu.org;
h=to:subject:message-id:date:from:in-reply-to:references:mime-version
:from:to:cc:subject:date:message-id:reply-to;
bh=OmMU77pDW0ikCQRMt2F5fbvLekKmmS4u0Nmp6G+bOYQ=;
b=Xmq1iHzFYLsuwzxN2GsPh/rQLFoIGo0snSSBydnXfHvRQPJCPNUxanf9NMHyoWoijj
g0ho4JqYwpBZ8nx5tBAaPhdu4LeRKhA3Sfm313Ro0ptOdRfNQSKr5MqxmaIdtAmua6SU
/OK3I2yHt54z38BvWukhW9b10D8vLFePgALNB4IMyc0qID1tJ9NuwDxPq2X93cmKEHSF
V4+kW33Kvpkjj1SDrfeCtLxM/BE96RiHMHHuo+BWUtlS9mO/Fnr/wR0k6lteH1pozIJz
HymQi2yqYcjw4sntF/SZaRQKj1zubEC+G+DlN0HrfMeG2GIpwxASPb7wcJiD8o67W4mq
pgog==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1743855483; x=1744460283;
h=to:subject:message-id:date:from:in-reply-to:references:mime-version
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=OmMU77pDW0ikCQRMt2F5fbvLekKmmS4u0Nmp6G+bOYQ=;
b=uI/at3jvXYCgPE5n2zPbV5jVP6lGxKCr4czfZNZDA2yaHfUddkKK77Cc2WEMNKO44n
LCouCXPLMIB7wtWfFRhgyQIeH6L8UhQoz6aAiKqwYSM4LDw6z1aYmpkt2Cb/jvx+04zm
yc9d0woPjvxwkaC007zo9XhkR59S9v9wsZ7nkRgZphWY0Ez5EEHhu6ytI/5TRUQ/2iui
9QmABGx63DhWH07ZZbuBRj2966mgE9L2JrhOCpogU6UbiqRGYY7NTfGrtcrM21ZugcNC
Z0h7jEOySRK5zdcsRfVDrGbTV2iioWLyVGGXHX0FPNmzvccXbDu7VSnBSF1B90pVPro5
r15w==
X-Gm-Message-State: AOJu0YxJd+dMLHv1/XW4MlwO4PN1Jp9/u4HIBcL/spbGHPYvShdSunh2
51Tky9lkI9leog5RcGPxdkPFxInwexa/9bNEoePvlHhv2J3rhXvaluIPQpL1ZaKIcqpXzIyqmvY
H1t8Kc0g/syTvhAueRiviE8FM8hCP/wQb
X-Gm-Gg: ASbGnctRN3Bk78GBL19so0QnxU7uKGpNhASrTNEKrJI77UcGjeiS97TJrdp9Z7EUzXe
FCH2QGscnHN5nhTBZceU6paN3BFWvVoF8/cmOaslKNmssjZWp5A31Ilgp7OvztFaxy70UtQwxPs
4rImwCHE0rgdj0rPoydN4RaoJAYQ==
X-Google-Smtp-Source: AGHT+IFLsZi3fvuMUaR2MEEeTPpHYCCVf5asi0QRcrX6Sfm4CH/nwz0P2gIoblxh6k8gApZURxpQuCQpPqUqsLpRt2Q=
X-Received: by 2002:a05:6871:418e:b0:2bc:69d8:a39e with SMTP id
586e51a60fabf-2cca1c20659mr3608009fac.33.1743855482862; Sat, 05 Apr 2025
05:18:02 -0700 (PDT)
MIME-Version: 1.0
References: <87iknjuf3a.fsf@HIDDEN>
<handler.77546.B.174384564629703.ack <at> debbugs.gnu.org>
In-Reply-To: <handler.77546.B.174384564629703.ack <at> debbugs.gnu.org>
From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
Date: Sat, 5 Apr 2025 13:18:25 +0100
X-Gm-Features: ATxdqUGdVXFC0RHB51-SUCCPaWOruR1h071lNGilH80CBeSTBsBwGPHgedL5vKk
Message-ID: <CALDnm51VE1b0hH9kn-OHq1CWaAS4=Rw00esO9fNQZFqPbV+oiA@HIDDEN>
Subject: Re: bug#77546: Acknowledgement (Regression in defaults: Re: Enhance
'icomplete-vertical-mode' customization options.)
To: 77546 <at> debbugs.gnu.org, rahul.juliato@HIDDEN
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 77546
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
This seems to be just a bug in the implementation. This patch
fixes it (and fixes some odd cl-loop usage as well):
diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index d0cc5674ba7..1ccfcc3edf4 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -927,8 +927,7 @@ icomplete-vertical--ensure-visible-lines-inside-buffer
(defun icomplete-vertical--add-indicator-to-selected (comp)
"Add indicators to the selected/unselected COMP completions."
- (if (and icomplete-vertical-render-prefix-indicator
- (get-text-property 0 'icomplete-selected comp))
+ (if (get-text-property 0 'icomplete-selected comp)
(concat (propertize icomplete-vertical-selected-prefix-indicator
'face
'icomplete-vertical-selected-prefix-indicator-face)
comp)
@@ -1012,8 +1011,11 @@ icomplete--render-vertical
;; Serialize completions and section titles into a list
;; of lines to render
(cl-loop
- for (comp prefix suffix section) in tuples
- do (setq comp (icomplete-vertical--add-indicator-to-selected comp))
+ for (comp-no-indicator prefix suffix section) in tuples
+ for comp =
+ (if icomplete-vertical-render-prefix-indicator
+ (icomplete-vertical--add-indicator-to-selected comp-no-indicator)
+ comp-no-indicator)
when section
collect (propertize section 'face 'icomplete-section) into lines-aux
and count 1 into nsections-aux
bug-gnu-emacs@HIDDEN:bug#77546; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 5 Apr 2025 09:34:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 05 05:34:06 2025
Received: from localhost ([127.0.0.1]:41554 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1u0zuf-0007j1-V2
for submit <at> debbugs.gnu.org; Sat, 05 Apr 2025 05:34:06 -0400
Received: from lists.gnu.org ([2001:470:142::17]:37452)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>)
id 1u0zud-0007iR-BB
for submit <at> debbugs.gnu.org; Sat, 05 Apr 2025 05:34:03 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <joaotavora@HIDDEN>)
id 1u0zuW-0001J8-3Q
for bug-gnu-emacs@HIDDEN; Sat, 05 Apr 2025 05:33:56 -0400
Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <joaotavora@HIDDEN>)
id 1u0zuU-0001yu-Bu
for bug-gnu-emacs@HIDDEN; Sat, 05 Apr 2025 05:33:55 -0400
Received: by mail-wr1-x42d.google.com with SMTP id
ffacd0b85a97d-39c1ee0fd43so2356013f8f.0
for <bug-gnu-emacs@HIDDEN>; Sat, 05 Apr 2025 02:33:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1743845631; x=1744450431; darn=gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=RSZ5fCCY8Klb0akyNIC3JGzDvZG47FhP9ejmUN2228c=;
b=JQTedb17fIwfXiRJCv/pjlLc7vjSyxJGUedoIeYhOEoWplKGn6ONV0RFbMTA5gVU0z
qtg3CftI6X1N0FXofE2hc/3JxjEPkWx0wty/uEKE03mKdCWFOAPTnXa/HeANX+XYQdFi
WS/+BEKr9PyrImQ8Cm2MGPTflKGxR+OpOQ1YH0FJvNbfdCSDd2jx504lQXojVtaJxVw5
CMnEidDEOIUeYGG0O3kv7Mk46pQh33q6/teEFgPgZmG2O5Q1cu6pqUwDw4s/xz9xHrwy
yWucjIfBbz5hRVph0x7ManaRvqwuGfC+G09uKtXXs/7UIf+O9r28uB4E4H6y14gEfxQu
fqiw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1743845631; x=1744450431;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=RSZ5fCCY8Klb0akyNIC3JGzDvZG47FhP9ejmUN2228c=;
b=WPRs+FaRNuwE58Xye1/+TelMWjpZ6iEkpHTP8hkWhVnTr5y42d6XDl8inUjplvdnE3
+BSTviQ1nMU9pgw3BU/y6nFvFjtR81RwbJolDBK+z+Lh5SyldLhgSylW65JeYJmWZvD+
qoCMkNwmv0wyg147ov3RFwiX6+9HayKMzxPbjTR7s6ESRo6yLzPdB1L2rY7d2UqP+Gkf
VKHZcE10E8Vov4hW3gBRf/jWkShtPpSgyYRRqDo7rfP9u++kWw8McR9QQpurjyZm+pg4
+vmpKvAT0Q2nBb91vAZ/nW9wXgFl24Svh1FnRrqOX0pxytDJkNZdpzQyMxSdtkadwwtv
b7+Q==
X-Gm-Message-State: AOJu0YxygmarzdbPp3H9TtB+XctAkC1hSIfyTapKU0zyQHnHOXcvyEeK
cxC7al7NFGTEXwPZklLmRqrVjAD8cz7WAMQV3CCK5eOe5kPzLRr2
X-Gm-Gg: ASbGncs46vVkI/sBEJ6pUX9/xRbY2Z0hX1koldggtzfvjs1zUhCucT90vFhCzES0G9d
iwgkQDmbJ0elrl/0QlG4tBD8HQc7dz7IHHXPCYJhu+aN3q+gCuRwyG0pCMkN7JVxDh6JQYxTcGz
w9/6RgVyYKwJjkqZ/5ST1B8U9w9v8EJt/TwF4SvmNj8rTWn6xvcS6nbmiVF9shE3uJZq0QMXXif
6aUjvtPWJBM41gS9VT+GZ/HMh+E1RtzXfdhfDUULvfNsowqZ74aIAe21jJCQKT8Do1MGdIQNXu2
bCY4mergps0SkqtFLrGtmOYpGldNtcqAkBlirKyM3mW/c0S1X06H/Qdz45EdCQ==
X-Google-Smtp-Source: AGHT+IEKiwzqU6mkYVxYolFSxiAl7TiH4FBBTi+ShoLytihi8ta155j8pz02VIwp6c4B9G2tS3Nx3w==
X-Received: by 2002:a05:6000:220f:b0:391:a43:8bbd with SMTP id
ffacd0b85a97d-39cba933185mr5888163f8f.21.1743845631311;
Sat, 05 Apr 2025 02:33:51 -0700 (PDT)
Received: from krug (87-196-76-109.net.novis.pt. [87.196.76.109])
by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-39c301a79bfsm6567960f8f.36.2025.04.05.02.33.49
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 05 Apr 2025 02:33:50 -0700 (PDT)
From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: Regression in defaults: Re: Enhance 'icomplete-vertical-mode'
customization options.
Date: Sat, 05 Apr 2025 10:34:17 +0100
Message-ID: <87iknjuf3a.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=2a00:1450:4864:20::42d;
envelope-from=joaotavora@HIDDEN; helo=mail-wr1-x42d.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: rahul.juliato@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
Helo Rahul,
Your change introduces a undocumented regression in the default use of
fido-vertical-mode
b98fe25c2ee2ac2d82b337c49d1aa1dfed2417eb is the first bad commit
commit b98fe25c2ee2ac2d82b337c49d1aa1dfed2417eb
Author: Rahul Martim Juliato <rahul.juliato@HIDDEN>
Date: Sat Mar 29 12:55:59 2025 -0300
Enhance 'icomplete-vertical-mode' customization options.
etc/NEWS | 20 +++++++++
lisp/icomplete.el | 123 ++++++++++++++++++++++++++++++++++++++++++++++++++=
++--
2 files changed, 140 insertions(+), 3 deletions(-)
Using simply this recipe
emacs -Q -nw -f fido-vertical-mode -f find-file
You will see that after your change two characters are wasted on the
left side of every candidate displayed in the vertical arrangement.
I have no opinion on the change, except that usually the current
behaviour that's been in Emacs for at least 2 major versions should be
kept, and those wishing to take advantage of the new functionality
should customize accordingly.
So perhaps the default values of the customization options you have
introduced need to be changed, or some changes specific to
fido-vertical-mode have to be introduced.
Thanks,
Jo=C3=A3o
João Távora <joaotavora@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#77546; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.