GNU bug report logs - #77547
[PATCH] gnu: libserialport: Update to 0.1.2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77547 in the body.
You can then email your comments to 77547 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH] gnu: libserialport: Update to 0.1.2.
Date: Sat,  5 Apr 2025 13:27:07 +0200

* gnu/packages/electronics.scm (libserialport): Update to 0.1.2.

Change-Id: I977a2363cf0b1431d1c3247a9dd77c2e562097f5
---
 gnu/packages/electronics.scm | 27 +++++++++++++++------------
 1 file changed, 15 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index ce35b19432..2cb23d6316 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -69,20 +69,23 @@ (define-module (gnu packages electronics)
 (define-public libserialport
   (package
     (name "libserialport")
-    (version "0.1.1")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append
-                    "http://sigrok.org/download/source/libserialport/libserialport-"
-                    version ".tar.gz"))
-              (sha256
-               (base32
-                "17ajlwgvyyrap8z7f16zcs59pksvncwbmd3mzf98wj7zqgczjaja"))))
+    (version "0.1.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "git://sigrok.org/libserialport")
+             (commit (string-append name "-" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0dn10gmm3rwdsiw1psaczb9m52x6cfkfrbywm4f5y8fsmghh7dsy"))))
     (build-system gnu-build-system)
+    (native-inputs (list autoconf automake libtool))
     (home-page "https://sigrok.org/wiki/Libserialport")
-    (synopsis "Library for using serial ports")
-    (description "Libserialport is a minimal shared library written in C that is intended
-to take care of the OS-specific details when writing software that uses serial ports.")
+    (synopsis "Cross-platform library for accessing serial ports")
+    (description
+     "libserialport is a minimal library written in C that is intended to
+take care of the OS-specific details when writing software that uses serial ports.")
     (license license:lgpl3+)))
 
 (define-public libsigrokdecode

base-commit: d473abf0b40fe4bedf9423a6822d067a9a7826cf
-- 
2.49.0

Message #8 received at 77547 <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Ekaitz Zarraga <ekaitz <at> elenq.tech>, 77547 <at> debbugs.gnu.org
Subject: Re: [bug#77547] [PATCH] gnu: libserialport: Update to 0.1.2.
Date: Sun, 06 Apr 2025 14:40:50 +0800

Cayetano Santos <csantosb <at> inventati.org> writes:

> * gnu/packages/electronics.scm (libserialport): Update to 0.1.2.

Hi, the 'origin' and 'native-inputs' changes should also be mentioned in
the change log, ex:

[source]: Switch to git-fetch.
[native-inputs]: Add autoconf, automake, libtool.

> -    (synopsis "Library for using serial ports")
> -    (description "Libserialport is a minimal shared library written in C that is intended
> -to take care of the OS-specific details when writing software that uses serial ports.")
> +    (synopsis "Cross-platform library for accessing serial ports")
> +    (description
> +     "libserialport is a minimal library written in C that is intended to
> +take care of the OS-specific details when writing software that uses serial ports.")

I think there is no need to change the synopsis and description here.

Could you send an update patch, thanks!

Message #11 received at 77547 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 77547 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v2] gnu: libserialport: Update to 0.1.2.
Date: Sun,  6 Apr 2025 09:46:49 +0200

* gnu/packages/electronics.scm (libserialport): Update to 0.1.2.

[source]: Switch to git-fetch.
[native-inputs]: Add autoconf, automake, libtool.

Change-Id: I1666f0a5f643c1fa8ea246f42503732ef5f93331
---
 gnu/packages/electronics.scm | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index ce35b19432..3cff2a8e7b 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -69,16 +69,18 @@ (define-module (gnu packages electronics)
 (define-public libserialport
   (package
     (name "libserialport")
-    (version "0.1.1")
+    (version "0.1.2")
     (source (origin
-              (method url-fetch)
-              (uri (string-append
-                    "http://sigrok.org/download/source/libserialport/libserialport-"
-                    version ".tar.gz"))
+              (method git-fetch)
+              (uri (git-reference
+                    (url "git://sigrok.org/libserialport")
+                    (commit (string-append name "-" version))))
+              (file-name (git-file-name name version))
               (sha256
                (base32
-                "17ajlwgvyyrap8z7f16zcs59pksvncwbmd3mzf98wj7zqgczjaja"))))
+                "0dn10gmm3rwdsiw1psaczb9m52x6cfkfrbywm4f5y8fsmghh7dsy"))))
     (build-system gnu-build-system)
+    (native-inputs (list autoconf automake libtool))
     (home-page "https://sigrok.org/wiki/Libserialport")
     (synopsis "Library for using serial ports")
     (description "Libserialport is a minimal shared library written in C that is intended

base-commit: 80826c6e038997dc47eb455888f0feaa38c08bf5
-- 
2.49.0

Message #14 received at 77547 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 宋文武 <iyzsong <at> envs.net>
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Ekaitz Zarraga <ekaitz <at> elenq.tech>, 77547 <at> debbugs.gnu.org
Subject: Re: [bug#77547] [PATCH] gnu: libserialport: Update to 0.1.2.
Date: Sun, 06 Apr 2025 09:50:09 +0200

[Message part 1 (text/plain, inline)]

>dim. 06 avril 2025 at 14:40, 宋文武 <iyzsong <at> envs.net> wrote:

> I think there is no need to change the synopsis and description here.

These changes reflect the project’s author own readme first lines, which
I find is a nice principle, provided they comply with guix standards, as
in this case.

I remove the change.

> Could you send an update patch, thanks!

Done.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 77547-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 77547-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: libserialport: Update to 0.1.2.
Date: Tue, 8 Apr 2025 11:19:27 +0200

Pushed, thanks!

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.