GNU bug report logs - #77561
[PATCH] gnu: emacs-org-roam: Update to 2.2.2-2.046822b.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77561 in the body.
You can then email your comments to 77561 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH] gnu: emacs-org-roam: Update to 2.2.2-2.046822b.
Date: Sat,  5 Apr 2025 21:24:44 +0200

* gnu/packages/emacs-xyz.scm (emacs-org-roam): Update to 2.2.2-2.046822b.

Change-Id: I91d74b8b5c20d60084849ee0496cc8f1e262ff79
---
 gnu/packages/emacs-xyz.scm | 45 +++++++++++++++-----------------------
 1 file changed, 18 insertions(+), 27 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 9bcf26a021..785266ee08 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -40138,8 +40138,8 @@ (define-public emacs-orca
       (license license:gpl3+))))
 
 (define-public emacs-org-roam
-  (let ((commit "0b9fcbc97b65b349826e63bad89ca121a08fd2be")
-        (revision "1"))
+  (let ((commit "046822b512ffecdee7d110f73dd3a511802ca590")
+        (revision "2"))
     (package
       (name "emacs-org-roam")
       (version (git-version "2.2.2" revision commit))
@@ -40151,15 +40151,23 @@ (define-public emacs-org-roam
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "04vqwrsb71jdb66fkahmxwvx8cssgqamrradbdgp3ygf8alwc7ml"))))
+          (base32 "0jbj48glh0r6fkb0lk1xb9067x2myp3krkw2byycijwdq1nlqzv2"))))
       (build-system emacs-build-system)
       (arguments
        (list
         #:phases
         #~(modify-phases %standard-phases
+            (add-after 'unpack 'make-info
+              (lambda _
+                (invoke "make" "-C" "doc" "info")
+                (copy-file "doc/org-roam.info" "org-roam.info")))
+            (add-after 'make-info 'install-image
+              (lambda* (#:key outputs #:allow-other-keys)
+                (install-file "doc/images/org-ref-citelink.png"
+                              (string-append #$output "/share/info/images"))))
             ;; Move the extensions source files to the top level, which
             ;; is included in the EMACSLOADPATH.
-            (add-after 'unpack 'move-source-files
+            (add-after 'install-image 'move-source-files
               (lambda _
                 (let ((el-files (find-files "./extensions" ".*\\.el$")))
                   (for-each (lambda (f)
@@ -40170,31 +40178,14 @@ (define-public emacs-org-roam
                 (make-file-writable "org-roam-graph.el")
                 (emacs-substitute-variables "org-roam-graph.el"
                   ("org-roam-graph-executable"
-                   (search-input-file inputs "/bin/dot")))))
-            (add-after 'install 'install-image
-              (lambda* (#:key outputs #:allow-other-keys)
-                (install-file "doc/images/org-ref-citelink.png"
-                              (string-append #$output "/share/info/images"))))
-            (add-after 'install-image 'make-info
-              (lambda* (#:key outputs #:allow-other-keys)
-                (with-directory-excursion "doc"
-                  (invoke "makeinfo" "-o" "org-roam.info" "org-roam.texi")
-                  (install-file "org-roam.info"
-                                (string-append #$output "/share/info"))))))))
-      (inputs
-       (list graphviz))
-      (native-inputs
-       (list texinfo))
-      (propagated-inputs
-       (list emacs-dash
-             emacs-emacsql
-             emacs-f
-             emacs-magit
-             emacs-org
-             emacs-s))
+                   (search-input-file inputs "/bin/dot"))))))))
+      (inputs (list graphviz))
+      (native-inputs (list texinfo))
+      (propagated-inputs (list emacs-dash emacs-emacsql emacs-magit))
       (home-page "https://github.com/org-roam/org-roam/")
       (synopsis "Non-hierarchical note-taking with Org mode")
-      (description "Emacs Org Roam is a solution for taking non-hierarchical
+      (description
+       "Emacs Org Roam is a solution for taking non-hierarchical
 notes with Org mode.  Notes are captured without hierarchy and are connected
 by tags.  Notes can be found and created quickly.  Org Roam should also work
 as a plug-and-play solution for anyone already using Org mode for their

base-commit: bcfb283cda1b782129c8a70b69d216b925501185
-- 
2.49.0

Message #8 received at 77561 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>, 77561 <at> debbugs.gnu.org,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>
Subject: Re: [bug#77561] [PATCH] gnu: emacs-org-roam: Update to
 2.2.2-2.046822b.
Date: Sun, 06 Apr 2025 11:03:12 +0800

Hi Cayetano,

On Sun, 06 Apr 2025 03:24:44 +0800,
Cayetano Santos wrote:
>
> * gnu/packages/emacs-xyz.scm (emacs-org-roam): Update to 2.2.2-2.046822b.
>
> Change-Id: I91d74b8b5c20d60084849ee0496cc8f1e262ff79
> ---
>  gnu/packages/emacs-xyz.scm | 45 +++++++++++++++-----------------------
>  1 file changed, 18 insertions(+), 27 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 9bcf26a021..785266ee08 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -40138,8 +40138,8 @@ (define-public emacs-orca
>        (license license:gpl3+))))
>
>  (define-public emacs-org-roam
> -  (let ((commit "0b9fcbc97b65b349826e63bad89ca121a08fd2be")
> -        (revision "1"))
> +  (let ((commit "046822b512ffecdee7d110f73dd3a511802ca590")
> +        (revision "2"))
>      (package
>        (name "emacs-org-roam")
>        (version (git-version "2.2.2" revision commit))
> @@ -40151,15 +40151,23 @@ (define-public emacs-org-roam
>                 (commit commit)))
>           (file-name (git-file-name name version))
>           (sha256
> -          (base32 "04vqwrsb71jdb66fkahmxwvx8cssgqamrradbdgp3ygf8alwc7ml"))))
> +          (base32 "0jbj48glh0r6fkb0lk1xb9067x2myp3krkw2byycijwdq1nlqzv2"))))
>        (build-system emacs-build-system)
>        (arguments
>         (list
>          #:phases
>          #~(modify-phases %standard-phases
> +            (add-after 'unpack 'make-info
> +              (lambda _
> +                (invoke "make" "-C" "doc" "info")
> +                (copy-file "doc/org-roam.info" "org-roam.info")))
> +            (add-after 'make-info 'install-image
> +              (lambda* (#:key outputs #:allow-other-keys)
> +                (install-file "doc/images/org-ref-citelink.png"
> +                              (string-append #$output "/share/info/images"))))
>              ;; Move the extensions source files to the top level, which
>              ;; is included in the EMACSLOADPATH.
> -            (add-after 'unpack 'move-source-files
> +            (add-after 'install-image 'move-source-files
>                (lambda _
>                  (let ((el-files (find-files "./extensions" ".*\\.el$")))
>                    (for-each (lambda (f)
> @@ -40170,31 +40178,14 @@ (define-public emacs-org-roam
>                  (make-file-writable "org-roam-graph.el")
>                  (emacs-substitute-variables "org-roam-graph.el"
>                    ("org-roam-graph-executable"
> -                   (search-input-file inputs "/bin/dot")))))
> -            (add-after 'install 'install-image
> -              (lambda* (#:key outputs #:allow-other-keys)
> -                (install-file "doc/images/org-ref-citelink.png"
> -                              (string-append #$output "/share/info/images"))))
> -            (add-after 'install-image 'make-info
> -              (lambda* (#:key outputs #:allow-other-keys)
> -                (with-directory-excursion "doc"
> -                  (invoke "makeinfo" "-o" "org-roam.info" "org-roam.texi")
> -                  (install-file "org-roam.info"
> -                                (string-append #$output "/share/info"))))))))

Please reflect the change in commit message.

> -      (inputs
> -       (list graphviz))
> -      (native-inputs
> -       (list texinfo))
> -      (propagated-inputs
> -       (list emacs-dash
> -             emacs-emacsql
> -             emacs-f
> -             emacs-magit
> -             emacs-org
> -             emacs-s))
> +                   (search-input-file inputs "/bin/dot"))))))))
> +      (inputs (list graphviz))
> +      (native-inputs (list texinfo))
> +      (propagated-inputs (list emacs-dash emacs-emacsql emacs-magit))

The diff doesn't look good, please make a minimal change and reflect the inputs
change in commit message.

>        (home-page "https://github.com/org-roam/org-roam/")
>        (synopsis "Non-hierarchical note-taking with Org mode")
> -      (description "Emacs Org Roam is a solution for taking non-hierarchical
> +      (description
> +       "Emacs Org Roam is a solution for taking non-hierarchical

This change doesn't seem relevant?

>  notes with Org mode.  Notes are captured without hierarchy and are connected
>  by tags.  Notes can be found and created quickly.  Org Roam should also work
>  as a plug-and-play solution for anyone already using Org mode for their
>
> base-commit: bcfb283cda1b782129c8a70b69d216b925501185
> --
> 2.49.0

Please send a revised patch addressing above issues.

Thanks

Message #11 received at 77561 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 77561 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v2] gnu: emacs-org-roam: Update to 2.2.2-2.046822b.
Date: Sun,  6 Apr 2025 09:40:26 +0200

* gnu/packages/emacs-xyz.scm (emacs-org-roam): Update to 2.2.2-2.046822b.

- Update to recent commit
- Produce info document using provided makefile
- Put stages in order
- Remove unnecessary input dependencies

Change-Id: I70cdd629a92145ad4cf5d965e53ce34f71117c7f
---
 gnu/packages/emacs-xyz.scm | 33 ++++++++++++++-------------------
 1 file changed, 14 insertions(+), 19 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 7c290d0833..022048fa7d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -40163,8 +40163,8 @@ (define-public emacs-orca
       (license license:gpl3+))))
 
 (define-public emacs-org-roam
-  (let ((commit "0b9fcbc97b65b349826e63bad89ca121a08fd2be")
-        (revision "1"))
+  (let ((commit "046822b512ffecdee7d110f73dd3a511802ca590")
+        (revision "2"))
     (package
       (name "emacs-org-roam")
       (version (git-version "2.2.2" revision commit))
@@ -40176,15 +40176,23 @@ (define-public emacs-org-roam
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "04vqwrsb71jdb66fkahmxwvx8cssgqamrradbdgp3ygf8alwc7ml"))))
+          (base32 "0jbj48glh0r6fkb0lk1xb9067x2myp3krkw2byycijwdq1nlqzv2"))))
       (build-system emacs-build-system)
       (arguments
        (list
         #:phases
         #~(modify-phases %standard-phases
+            (add-after 'unpack 'make-info
+              (lambda _
+                (invoke "make" "-C" "doc" "info")
+                (copy-file "doc/org-roam.info" "org-roam.info")))
+            (add-after 'make-info 'install-image
+              (lambda* (#:key outputs #:allow-other-keys)
+                (install-file "doc/images/org-ref-citelink.png"
+                              (string-append #$output "/share/info/images"))))
             ;; Move the extensions source files to the top level, which
             ;; is included in the EMACSLOADPATH.
-            (add-after 'unpack 'move-source-files
+            (add-after 'install-image 'move-source-files
               (lambda _
                 (let ((el-files (find-files "./extensions" ".*\\.el$")))
                   (for-each (lambda (f)
@@ -40195,17 +40203,7 @@ (define-public emacs-org-roam
                 (make-file-writable "org-roam-graph.el")
                 (emacs-substitute-variables "org-roam-graph.el"
                   ("org-roam-graph-executable"
-                   (search-input-file inputs "/bin/dot")))))
-            (add-after 'install 'install-image
-              (lambda* (#:key outputs #:allow-other-keys)
-                (install-file "doc/images/org-ref-citelink.png"
-                              (string-append #$output "/share/info/images"))))
-            (add-after 'install-image 'make-info
-              (lambda* (#:key outputs #:allow-other-keys)
-                (with-directory-excursion "doc"
-                  (invoke "makeinfo" "-o" "org-roam.info" "org-roam.texi")
-                  (install-file "org-roam.info"
-                                (string-append #$output "/share/info"))))))))
+                   (search-input-file inputs "/bin/dot"))))))))
       (inputs
        (list graphviz))
       (native-inputs
@@ -40213,10 +40211,7 @@ (define-public emacs-org-roam
       (propagated-inputs
        (list emacs-dash
              emacs-emacsql
-             emacs-f
-             emacs-magit
-             emacs-org
-             emacs-s))
+             emacs-magit))
       (home-page "https://github.com/org-roam/org-roam/")
       (synopsis "Non-hierarchical note-taking with Org mode")
       (description "Emacs Org Roam is a solution for taking non-hierarchical

base-commit: 80826c6e038997dc47eb455888f0feaa38c08bf5
--
2.49.0

Message #14 received at 77561 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>, 77561 <at> debbugs.gnu.org,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>
Subject: Re: [bug#77561] [PATCH v2] gnu: emacs-org-roam: Update to
 2.2.2-2.046822b.
Date: Mon, 07 Apr 2025 00:05:06 +0800

On Sun, 06 Apr 2025 15:40:26 +0800,
Cayetano Santos wrote:
> 
> * gnu/packages/emacs-xyz.scm (emacs-org-roam): Update to 2.2.2-2.046822b.
> 
> - Update to recent commit
> - Produce info document using provided makefile
> - Put stages in order
> - Remove unnecessary input dependencies

Please write the changelog in the following format:
--8<---------------cut here---------------start------------->8---
[arguments]<#:phases>: ...
[propagated-inputs]: Remove ...
--8<---------------cut here---------------end--------------->8---

In case you didn't know, this changelog style is described in GNU Coding
Standards, ‘info (standards) Change Logs’, though in practice not strictly
followed in Guix.

Message #17 received at 77561 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 77561 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v3] gnu: emacs-org-roam: Update to 2.2.2-2.046822b.
Date: Mon,  7 Apr 2025 08:54:07 +0200

* gnu/packages/emacs-xyz.scm (emacs-org-roam): Update to 2.2.2-2.046822b.

[propagated-inputs]: Remove emacs-f, emacs-org, emacs-s
[arguments]<#:phases>: Produce info document using provided makefile

Change-Id: I70cdd629a92145ad4cf5d965e53ce34f71117c7f
---
 gnu/packages/emacs-xyz.scm | 33 ++++++++++++++-------------------
 1 file changed, 14 insertions(+), 19 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b0ed0fdd0b..fb6e139784 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -40163,8 +40163,8 @@ (define-public emacs-orca
       (license license:gpl3+))))
 
 (define-public emacs-org-roam
-  (let ((commit "0b9fcbc97b65b349826e63bad89ca121a08fd2be")
-        (revision "1"))
+  (let ((commit "046822b512ffecdee7d110f73dd3a511802ca590")
+        (revision "2"))
     (package
       (name "emacs-org-roam")
       (version (git-version "2.2.2" revision commit))
@@ -40176,15 +40176,23 @@ (define-public emacs-org-roam
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "04vqwrsb71jdb66fkahmxwvx8cssgqamrradbdgp3ygf8alwc7ml"))))
+          (base32 "0jbj48glh0r6fkb0lk1xb9067x2myp3krkw2byycijwdq1nlqzv2"))))
       (build-system emacs-build-system)
       (arguments
        (list
         #:phases
         #~(modify-phases %standard-phases
+            (add-after 'unpack 'make-info
+              (lambda _
+                (invoke "make" "-C" "doc" "info")
+                (copy-file "doc/org-roam.info" "org-roam.info")))
+            (add-after 'make-info 'install-image
+              (lambda* (#:key outputs #:allow-other-keys)
+                (install-file "doc/images/org-ref-citelink.png"
+                              (string-append #$output "/share/info/images"))))
             ;; Move the extensions source files to the top level, which
             ;; is included in the EMACSLOADPATH.
-            (add-after 'unpack 'move-source-files
+            (add-after 'install-image 'move-source-files
               (lambda _
                 (let ((el-files (find-files "./extensions" ".*\\.el$")))
                   (for-each (lambda (f)
@@ -40195,17 +40203,7 @@ (define-public emacs-org-roam
                 (make-file-writable "org-roam-graph.el")
                 (emacs-substitute-variables "org-roam-graph.el"
                   ("org-roam-graph-executable"
-                   (search-input-file inputs "/bin/dot")))))
-            (add-after 'install 'install-image
-              (lambda* (#:key outputs #:allow-other-keys)
-                (install-file "doc/images/org-ref-citelink.png"
-                              (string-append #$output "/share/info/images"))))
-            (add-after 'install-image 'make-info
-              (lambda* (#:key outputs #:allow-other-keys)
-                (with-directory-excursion "doc"
-                  (invoke "makeinfo" "-o" "org-roam.info" "org-roam.texi")
-                  (install-file "org-roam.info"
-                                (string-append #$output "/share/info"))))))))
+                   (search-input-file inputs "/bin/dot"))))))))
       (inputs
        (list graphviz))
       (native-inputs
@@ -40213,10 +40211,7 @@ (define-public emacs-org-roam
       (propagated-inputs
        (list emacs-dash
              emacs-emacsql
-             emacs-f
-             emacs-magit
-             emacs-org
-             emacs-s))
+             emacs-magit))
       (home-page "https://github.com/org-roam/org-roam/")
       (synopsis "Non-hierarchical note-taking with Org mode")
       (description "Emacs Org Roam is a solution for taking non-hierarchical

base-commit: 6af680670bf9055b90e6f8b63c4c2ab7b08e7c56
-- 
2.49.0

Message #20 received at 77561 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>, 77561 <at> debbugs.gnu.org,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>
Subject: Re: [bug#77561] [PATCH v3] gnu: emacs-org-roam: Update to
 2.2.2-2.046822b.
Date: Mon, 07 Apr 2025 19:01:25 +0800

On Mon, 07 Apr 2025 14:54:07 +0800,
Cayetano Santos wrote:
>
> * gnu/packages/emacs-xyz.scm (emacs-org-roam): Update to 2.2.2-2.046822b.
>
> [propagated-inputs]: Remove emacs-f, emacs-org, emacs-s
> [arguments]<#:phases>: Produce info document using provided makefile

Remember to end them with ‘.’.

No need for a further revision, I'll add them when I commit this patch.

Message #23 received at 77561 <at> debbugs.gnu.org (full text, mbox):

From: Tor-björn Claesson <tor-bjorn <at> claesson.fi>
To: 77561 <at> debbugs.gnu.org
Date: Tue, 08 Apr 2025 10:25:40 +0300

Thanks for this work, it fixes recent breakage caused by
deprecations in emacs-emacsql 4.3.0.

Cheers!

Message #28 received at 77561-done <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 77561-done <at> debbugs.gnu.org, Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>
Subject: Re: [bug#77561] [PATCH v3] gnu: emacs-org-roam: Update to
 2.2.2-2.046822b.
Date: Wed, 09 Apr 2025 00:10:52 +0800

On Mon, 07 Apr 2025 14:54:07 +0800,
Cayetano Santos wrote:
>
> * gnu/packages/emacs-xyz.scm (emacs-org-roam): Update to 2.2.2-2.046822b.
>
> [propagated-inputs]: Remove emacs-f, emacs-org, emacs-s
> [arguments]<#:phases>: Produce info document using provided makefile
>
> Change-Id: I70cdd629a92145ad4cf5d965e53ce34f71117c7f
> ---
>  gnu/packages/emacs-xyz.scm | 33 ++++++++++++++-------------------
>  1 file changed, 14 insertions(+), 19 deletions(-)

Modified and applied as c133a74dc68297626458e96b640fd6a38d2fc5de, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.