GNU bug report logs - #77568
[PATCH ruby-team 0/3] gnu: ruby-test-unit: Simplify testing.

Previous Next

To reply to this bug, email your comments to 77568 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: gemmaro <gemmaro.dev <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: [PATCH ruby-team 0/3] gnu: ruby-test-unit: Simplify testing.
Date: Sun,  6 Apr 2025 10:35:06 +0900

This simplifies testing of ruby-test-unit and removes redundant dependencies.

gemmaro (3):
  gnu: ruby-test-unit: Simplify testing.
  gnu: ruby-test-unit/minimal: Deprecate the package.
  gnu: ruby-metaclass: Use ruby-test-unit instead of minimal version.

 gnu/packages/ruby.scm | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)


base-commit: ba768e5a27feb6316afa5c4995cefd244e0f0e4b
-- 
2.49.0

Message #8 received at 77568 <at> debbugs.gnu.org (full text, mbox):

From: gemmaro <gemmaro.dev <at> gmail.com>
To: 77568 <at> debbugs.gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: [PATCH ruby-team 1/3] gnu: ruby-test-unit: Simplify testing.
Date: Sun,  6 Apr 2025 10:38:45 +0900

* gnu/packages/ruby.scm (ruby-test-unit): Simplify testing by directly running
the test script and removing redundant native input dependencies.

Change-Id: I8ceb7c46dffade84d00fe6477210d808b3012f60
---
 gnu/packages/ruby.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 2a80d3f4fb..38ba729258 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -5155,10 +5155,16 @@ (define-public ruby-test-unit
                (base32
                 "0w1m432q3y5v9lkak8yyxadak3z17bsp6afni97i4zjdgfz7niz2"))))
     (build-system ruby-build-system)
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (replace 'check
+            (lambda* (#:key tests? #:allow-other-keys)
+              (when tests?
+                (invoke "ruby" "test/run.rb")))))))
     (propagated-inputs
      (list ruby-power-assert))
-    (native-inputs
-     (list bundler ruby-packnga ruby-yard))
     (synopsis "Unit testing framework for Ruby")
     (description "@code{Test::Unit} is unit testing framework for Ruby, based
 on xUnit principles.  These were originally designed by Kent Beck, creator of
-- 
2.49.0

Message #11 received at 77568 <at> debbugs.gnu.org (full text, mbox):

From: gemmaro <gemmaro.dev <at> gmail.com>
To: 77568 <at> debbugs.gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: [PATCH ruby-team 2/3] gnu: ruby-test-unit/minimal: Deprecate the
 package.
Date: Sun,  6 Apr 2025 10:38:46 +0900

* gnu/packages/ruby.scm: Now the ruby-test-unit package works without native
inputs, the minimal version can be deprecated.

Change-Id: I3ba562135d2d27e65a86a9daa6a5d3ca166e6f12
---
 gnu/packages/ruby.scm | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 38ba729258..f183e2dbec 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -5173,15 +5173,10 @@ (define-public ruby-test-unit
     (home-page "https://test-unit.github.io/")
     (license (list license:psfl license:ruby))))
 
+;; The minimal version was made to exclude native inputs.  The ruby-test-unit
+;; package now works without any native inputs.
 (define-public ruby-test-unit/minimal
-  (hidden-package
-   (package
-     (inherit ruby-test-unit)
-     (arguments
-      (ensure-keyword-arguments
-       (package-arguments ruby-test-unit)
-       (list #:tests? #f)))
-     (native-inputs '()))))
+  (deprecated-package "ruby-test-unit/minimal" ruby-test-unit))
 
 (define-public ruby-test-unit-ruby-core
   (package
-- 
2.49.0

Message #14 received at 77568 <at> debbugs.gnu.org (full text, mbox):

From: gemmaro <gemmaro.dev <at> gmail.com>
To: 77568 <at> debbugs.gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: [PATCH ruby-team 3/3] gnu: ruby-metaclass: Use ruby-test-unit instead
 of minimal version.
Date: Sun,  6 Apr 2025 10:38:47 +0900

* gnu/packages/ruby.scm (ruby-metaclass) [native-inputs]:
Replace the deprecated ruby-test-unit/minimal with ruby-test-unit.

Change-Id: I42ac9b493eecaede551681fb47e9e87945f6a0f7
---
 gnu/packages/ruby.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index f183e2dbec..baec9c32ec 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -5328,7 +5328,7 @@ (define-public ruby-metaclass
                                  ,(package-version ruby-test-unit)
                                  "/lib\"")))))))))
     (native-inputs
-     (list bundler ruby-test-unit/minimal))
+     (list bundler ruby-test-unit))
     (synopsis "Ruby library adding metaclass method to all objects")
     (description
      "Metaclass is a Ruby library adding a @code{metaclass} method to all Ruby
-- 
2.49.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.