GNU bug report logs - #77574
[PATCH] .dir-locals.el: Add compile command.

Previous Next

To reply to this bug, email your comments to 77574 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Santos <gabriel.santos.smtp <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
Subject: [PATCH] .dir-locals.el: Add compile command.
Date: Sun,  6 Apr 2025 08:56:45 -0300

Change-Id: I461082926c3d2370bcdead4c75ec8d6c5508c12e
---

Simple compilation command that uses guix shell in case the user doesn't have
all of the necessary dependencies installed.

 .dir-locals.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.dir-locals.el b/.dir-locals.el
index 76c9e12992..296f09bb97 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -4,6 +4,7 @@
   . ((fill-column . 78)
      (tab-width   .  8)
      (sentence-end-double-space . t)
+     (compile-command . "guix shell -D guix -CP -- make")
 
      ;; For use with 'bug-reference-prog-mode'.  Extra bug-reference
      ;; configuration should be done in your Emacs user configuration file;

base-commit: 0e144a0da24a30f86c9fa33c3f3fcfd7ac6e21be
-- 
2.49.0

Message #8 received at 77574 <at> debbugs.gnu.org (full text, mbox):

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
To: Gabriel Santos <gabriel.santos.smtp <at> gmail.com>
Cc: 77574 <at> debbugs.gnu.org, Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
Subject: Re: [bug#77574] [PATCH] .dir-locals.el: Add compile command.
Date: Mon, 07 Apr 2025 17:17:34 -0400

Gabriel Santos <gabriel.santos.smtp <at> gmail.com> writes:

> Change-Id: I461082926c3d2370bcdead4c75ec8d6c5508c12e
> ---
>
> Simple compilation command that uses guix shell in case the user doesn't have
> all of the necessary dependencies installed.

I think this is mostly the correct command (see below) and would love to
see this change as I am manually inserting it all the time.  Thank you
for taking the time to do this!

>
>  .dir-locals.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/.dir-locals.el b/.dir-locals.el
> index 76c9e12992..296f09bb97 100644
> --- a/.dir-locals.el
> +++ b/.dir-locals.el
> @@ -4,6 +4,7 @@
>    . ((fill-column . 78)
>       (tab-width   .  8)
>       (sentence-end-double-space . t)
> +     (compile-command . "guix shell -D guix -CP -- make")

According to the info manual [[info:guix#Building from Git]] the command
should be "guix shell -D guix -CPW -- make" (notice the 'W' switch).

>
>       ;; For use with 'bug-reference-prog-mode'.  Extra bug-reference
>       ;; configuration should be done in your Emacs user configuration file;
>
> base-commit: 0e144a0da24a30f86c9fa33c3f3fcfd7ac6e21be

Message #11 received at 77574 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
To: Morgan Smith <Morgan.J.Smith <at> outlook.com>,
 Gabriel Santos <gabriel.santos.smtp <at> gmail.com>
Cc: 77574 <at> debbugs.gnu.org
Subject: Re: [bug#77574] [PATCH] .dir-locals.el: Add compile command.
Date: Mon, 07 Apr 2025 18:41:45 -0300

>According to the info manual [[info:guix#Building from Git]] the command
>should be "guix shell -D guix -CPW -- make" (notice the 'W' switch).

Yes, I got the command from the manual too, but I've been able
to compile without the "W" flag. Maybe it's because I already
have Guix compiled. I'll do a "make clean" to check.

I'll test this out, and if it's necessary send a v2 with
an added copyright statement (which I didn't add because
my pull didn't catch the copyright commit).

-- 
Gabriel Santos

Message #14 received at 77574 <at> debbugs.gnu.org (full text, mbox):

From: Morgan Smith <morgan.j.smith <at> outlook.com>
To: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
Cc: 77574 <at> debbugs.gnu.org, Gabriel Santos <gabriel.santos.smtp <at> gmail.com>
Subject: Re: [bug#77574] [PATCH] .dir-locals.el: Add compile command.
Date: Mon, 07 Apr 2025 18:06:50 -0400

Gabriel Santos <gabrielsantosdesouza <at> disroot.org> writes:

>>According to the info manual [[info:guix#Building from Git]] the command
>>should be "guix shell -D guix -CPW -- make" (notice the 'W' switch).
>
> Yes, I got the command from the manual too, but I've been able
> to compile without the "W" flag. Maybe it's because I already
> have Guix compiled. I'll do a "make clean" to check.

The 'W' switch is for nested container shenanigans.  I think our tests
("make check" and "make check-system") need it.  As it's very natural to
modify the compile command from a prompt, I imagine many users will
simply append "check" and "check-system" to the default command.

Assuming you can compile without the 'W', I'm not opposed to leaving the
command as is.  However, personally I would add the 'W'.

Message #17 received at 77574 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
To: Morgan Smith <morgan.j.smith <at> outlook.com>
Cc: 77574 <at> debbugs.gnu.org, Gabriel Santos <gabriel.santos.smtp <at> gmail.com>
Subject: Re: [bug#77574] [PATCH] .dir-locals.el: Add compile command.
Date: Mon, 07 Apr 2025 19:16:45 -0300

>The 'W' switch is for nested container shenanigans.  I think our tests
>("make check" and "make check-system") need it. [...]
>Assuming you can compile without the 'W', I'm not opposed to leaving the
>command as is.  However, personally I would add the 'W'.

If it's used by other make commands, and doesn't
impact the regular build process, then it would be
best if I just added it. I thought it was a part of
thhe documentation that hadn't been updated.

Sending a v2 soon.

-- 
Gabriel Santos

Message #20 received at 77574 <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Cc: 77574 <at> debbugs.gnu.org, Gabriel Santos <gabriel.santos.smtp <at> gmail.com>,
 Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
Subject: Re: [bug#77574] [PATCH] .dir-locals.el: Add compile command.
Date: Tue, 08 Apr 2025 00:18:37 +0200

Bit off-topic, but...

Morgan Smith <Morgan.J.Smith <at> outlook.com> writes:

> Gabriel Santos <gabriel.santos.smtp <at> gmail.com> writes:
>
>> Change-Id: I461082926c3d2370bcdead4c75ec8d6c5508c12e
>> ---
>>
>> Simple compilation command that uses guix shell in case the user doesn't have
>> all of the necessary dependencies installed.
>
> I think this is mostly the correct command (see below) and would love to
> see this change as I am manually inserting it all the time.

Let me bring your attention to (emacs)Directory Variables, specifically
to .dir-locals-2.el.  It is very useful in situations like this.

Tomas

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

Message #23 received at 77574 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Santos <gabriel.santos.smtp <at> gmail.com>
To: 77574 <at> debbugs.gnu.org
Cc: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
Subject: [PATCH v2] .dir-locals.el: Add compile command.
Date: Mon,  7 Apr 2025 19:21:07 -0300

Change-Id: I461082926c3d2370bcdead4c75ec8d6c5508c12e
---
 .dir-locals.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.dir-locals.el b/.dir-locals.el
index 69a5d8065e..a09a1d685e 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -17,6 +17,7 @@
 ;;; Copyright © 2024 Tomas Volf <~@wolfsden.cz>
 ;;; Copyright © 2024 Nicolas Graves <ngraves <at> ngraves.fr>
 ;;; Copyright © 2025 David Elsing <david.elsing <at> posteo.net>
+;;; Copyright © 2025 Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
 ;;; This file is part of GNU Guix.
 ;;;
 ;;; GNU Guix is free software; you can redistribute it and/or modify it
@@ -37,6 +38,7 @@
   . ((fill-column . 78)
      (tab-width   .  8)
      (sentence-end-double-space . t)
+     (compile-command . "guix shell -D guix -CPW -- make")
 
      ;; For use with 'bug-reference-prog-mode'.  Extra bug-reference
      ;; configuration should be done in your Emacs user configuration file;

base-commit: 666a6cfd88b3e5106a9180e06ea128db8084be0e
-- 
2.49.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.