GNU bug report logs - #77578
[PATCH] tests: docker-system: Use only guix-daemon service.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Oleg Pykhalov <go.wigust@HIDDEN>; Keywords: patch; dated Sun, 6 Apr 2025 15:09:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 77578 <at> debbugs.gnu.org:


Received: (at 77578) by debbugs.gnu.org; 6 Jun 2025 20:16:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 06 16:16:27 2025
Received: from localhost ([127.0.0.1]:45451 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uNdUI-0006Sz-OH
	for submit <at> debbugs.gnu.org; Fri, 06 Jun 2025 16:16:27 -0400
Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]:53352)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <go.wigust@HIDDEN>)
 id 1uNdUG-0006Sg-QA
 for 77578 <at> debbugs.gnu.org; Fri, 06 Jun 2025 16:16:25 -0400
Received: by mail-lf1-x12b.google.com with SMTP id
 2adb3069b0e04-552206ac67aso2868065e87.2
 for <77578 <at> debbugs.gnu.org>; Fri, 06 Jun 2025 13:16:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1749240978; x=1749845778; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=0tlNOR2Wffg5yVkiwYxA5Y9slAZ2lb+8VkNPEml/e6o=;
 b=VppCS0xjMpPXg1sE7Lo/t0kwB4/PMN8jFHSVy9pYqLxKDdRrftZLJAw43H7jp/tq/a
 pkHfHJfstTSkH0N1uauxSTtMAX5eYic8qadhjtcohMwOE/zPfQC6OFU1ziTQnIxWE367
 btD3vue32Y0QfSQe+Y6kmTbxOhfRrKXf3nBVORTqPQza506gPGo7JfhfkDMEQgzbN6d1
 EGON7EM4McmEbFHC49USDMkAboMbpL5nBlmbLoitQApieVDGamOXqPPpFmKVGO4EsOUg
 xJKzV0Jkg7/BbQjllIj2DTVKlmwNjAeyKefCnDSPR19GjIXoDjwddAxqw/3nPZlwWUVh
 Q/NQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1749240978; x=1749845778;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=0tlNOR2Wffg5yVkiwYxA5Y9slAZ2lb+8VkNPEml/e6o=;
 b=IQ43PB9JYrAePcaE4G7Mb5YRqeC9wndcW7pvTV6I0zYWGpAWOYa7lBwv94a/u1TvQk
 miyj4W6/wM47TD/qWC6D6Rkm4MKeDdVZRjZbnZiNBXUQYYsl608N7BfrM/t8CG0DH14w
 63pcrr7chmtgt7N3OyDSZ00yv+MMek0p0kSEJ0G3yLYIt6QPyP+tQlU0+dLhxW7sTHlm
 iIMkQgHUTIayw8IfsRuEfa3IjS/uvyBa2r/jhh5BBwxuJc74aCdLVj4EqF1VS2bYVMRW
 QaI7lgCM9NFayI+LW36HL2TOgJbb2ILSG0brR51s79K66znffsQEc0/APKYKAZxrkzh3
 zXyw==
X-Gm-Message-State: AOJu0YwyUrsPAzARRbkMoF6pdXEXs88TdUhD++U+yi5Noy+No0qr+mU0
 8ruPEQf0tkFVwK+ZVp9/b1J92x9NlX2TuJgfivZ2dt6j2kCf/0DnpsFq30vnX4UC
X-Gm-Gg: ASbGncvhaSJvCOABxcFX6wDCrC8hAdaW8dRPscis4q88X+7zYvq953vv7+VaU9Q7fkM
 UskN1sgz7+bLAhqM13RGA9GBCn6bxElHr3+W2KHTPGGubtLR3jSXIuMInofaRN7RPKnvstEFczA
 jIBogiNv6Q7E8ynOdySx+4QIoibyv2WXo+P1mkjs1I83dxHhKCty+AsmEOxF2V8+xs6ZQvYGNRh
 /n3lAkPwHojXix3s/JaAowqG8jGEE1qSpeN1lg5dVG00P+ps0az8j7p20b260ALO/wFA67DmfIL
 wB4BEJLlSRLbrjs6Na6rFh5L2if1fa6cssZgD4x2OucY9ygqZLQYXyrCDRZKWbyf/P8=
X-Google-Smtp-Source: AGHT+IFssAHZhYHvPL7n7hlTLCb6/m9w2M4tAE1K3Mo5d/GJMWyk9YRr7M22Lng13RRE+lCJ3rGmAg==
X-Received: by 2002:ac2:53ac:0:b0:553:20f2:2e77 with SMTP id
 2adb3069b0e04-55366e33a1emr998643e87.55.1749240977774; 
 Fri, 06 Jun 2025 13:16:17 -0700 (PDT)
Received: from guixsd.wugi.info ([93.100.15.190])
 by smtp.gmail.com with ESMTPSA id
 2adb3069b0e04-5536772a61esm279118e87.163.2025.06.06.13.16.17
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 06 Jun 2025 13:16:17 -0700 (PDT)
From: Oleg Pykhalov <go.wigust@HIDDEN>
To: 77578 <at> debbugs.gnu.org
Subject: [PATCH 2/2] tests: docker-system: Add network up test.
Date: Fri,  6 Jun 2025 23:15:39 +0300
Message-ID: <20250606201539.2306357-2-go.wigust@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <20250606201539.2306357-1-go.wigust@HIDDEN>
References: <87r002r1m7.fsf@HIDDEN>
 <20250606201539.2306357-1-go.wigust@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 77578
Cc: Oleg Pykhalov <go.wigust@HIDDEN>,
 =?UTF-8?q?Ludovic=20Court=C3=A8s?= <ludo@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Addresses intermittent Docker test failures caused by timing issues where
container-related checks ran before the networking service was fully
initialized. A new "network is up" assertion has been added to explicitly
start and verify the 'networking' service using `marionette-eval`.

* gnu/tests/docker.scm (%test-docker-system): Add "network is up" test.

Change-Id: I0c761ae2ce2e7b398c8f35ea1faf50257193ccc5
Signed-off-by: Oleg Pykhalov <go.wigust@HIDDEN>
---
 gnu/tests/docker.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/tests/docker.scm b/gnu/tests/docker.scm
index 84d604f8d3..c8796e42bb 100644
--- a/gnu/tests/docker.scm
+++ b/gnu/tests/docker.scm
@@ -251,6 +251,13 @@ (define marionette
           (test-runner-current (system-test-runner #$output))
           (test-begin "docker")
 
+          (test-assert "network is up"
+            (marionette-eval
+             '(begin
+                (use-modules (gnu services herd))
+                (start-service 'networking))
+             marionette))
+
           (test-assert "containerd service running"
             (marionette-eval
              '(begin
-- 
2.41.0





Information forwarded to guix-patches@HIDDEN:
bug#77578; Package guix-patches. Full text available.

Message received at 77578 <at> debbugs.gnu.org:


Received: (at 77578) by debbugs.gnu.org; 6 Jun 2025 20:16:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 06 16:16:18 2025
Received: from localhost ([127.0.0.1]:45448 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uNdUA-0006SY-4L
	for submit <at> debbugs.gnu.org; Fri, 06 Jun 2025 16:16:18 -0400
Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:43053)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <go.wigust@HIDDEN>)
 id 1uNdU7-0006SJ-MM
 for 77578 <at> debbugs.gnu.org; Fri, 06 Jun 2025 16:16:16 -0400
Received: by mail-lf1-x136.google.com with SMTP id
 2adb3069b0e04-55324587a53so3391050e87.0
 for <77578 <at> debbugs.gnu.org>; Fri, 06 Jun 2025 13:16:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1749240969; x=1749845769; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=DtOdBCxx1jt3COR2VYr3TH6jO9kjTn0EXaFfIJ09FXo=;
 b=hWlosNAjZvDyXPaRBMBgzp7gOvQPjbtv/EBwvGvm6sdT4I4FMvAdhpMqszpC57dTTv
 U3o+Tn3mDN+/WDTZJKn+UMwxAg8gFqa85rgzm2lp5svfYAcydk3x0vzYEVohgApzFkDF
 oA/UeX7AAg+SvHMF2hFfUVup3Ivyfo83lH8MzbjG2rcn13lRXP6vg+fxLxYcGCo8CWbf
 xzRACsl5sdbF2zRBHKmxJAj0nQYQU5t44pkwkhnBzWIpZABFr6J+oElxAr1zAP42QWxm
 i/3QW+21CrIvI8MoRfq2fk4tk1MGUKH1asq5UgGI1dC74FJeEesqaL1z42uPhFSBgM+X
 k9AQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1749240969; x=1749845769;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=DtOdBCxx1jt3COR2VYr3TH6jO9kjTn0EXaFfIJ09FXo=;
 b=XFjzC1BInKZ0hNwfmizmswo5AIJdj7iifoF+vzDHA17RlQmt4lbykqbjJAjLtgRcWv
 P/uNBVq4TtnP2KqjggHCI+m24UQnUWBrq5+vUXuPSEh7GwBFw98gdX7eBdK92LG9oTpC
 mgwbNn1XC5ZQlYAQ5Nmv13xQ5EuuykJtth2I1Ot6ymkarJJ6o55GUhfj8rppqT1Tnzqf
 NuX8z61xQp/EGOqtTD00i4toY9qzH/ZP2N2pPxNo3LOx3QRE5MYg7ddiIWLhPOLN4omy
 1fovBnKqS1i5LEt8S+Kpxzt3aLi17ulrzVLypqnP9xBpAflh7RNc0hSZZs1sy8s0NNwq
 ppDg==
X-Gm-Message-State: AOJu0YwhEitEnBXcrujEeXfOxZ7DkEQf364cWvSL2IWRK/SJ6/bDHlUK
 HrrDFlht9NSdMWg3inaPRrJ5gxFapU/b1YU6zkINwHcPqFTw9MdujSXYgzKqfpav
X-Gm-Gg: ASbGncu3H81YeHxy9hb2il3ZANwk6ENA5DpUVlTSbFvnjAlKGgVB9H8GoomG+R6Ovha
 Ev7SsfXNQUHJNVqkeryLucBSR7UeAZbCArHPzdKrPBHlmfnpx73DknuvD3vyPDXz6owT1vM+NhX
 hkgYz3BqVQxOBkpqzKntq7AP0Y5kgZKE1+iWXahk82kbymdzbE4bBsKhQsYK4L4H46LL4Kccbvg
 6YrnjWVKvsEBL0Qgedax8Wnp0XBU36vcjyQ0g8eKgoDTchyaS0vwGiLcu5xkoK6ToXObr2VOH0b
 ptmpKB9DqkR8HoMYgMfMLJ5Z4ImZ1mxNihDPmusrjmwpz3/Rd8XlV/23
X-Google-Smtp-Source: AGHT+IFHnJg0DhEZ4c597sCW5hfmzibEDly7bpVeaNoJsel1fXluO/qKvB0z+a0EZrGvopokRk4kDg==
X-Received: by 2002:a05:6512:3f15:b0:553:2375:c6e8 with SMTP id
 2adb3069b0e04-55366bd9a58mr1584136e87.1.1749240968440; 
 Fri, 06 Jun 2025 13:16:08 -0700 (PDT)
Received: from guixsd.wugi.info ([93.100.15.190])
 by smtp.gmail.com with ESMTPSA id
 2adb3069b0e04-5536772a61esm279118e87.163.2025.06.06.13.16.08
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 06 Jun 2025 13:16:08 -0700 (PDT)
From: Oleg Pykhalov <go.wigust@HIDDEN>
To: 77578 <at> debbugs.gnu.org
Subject: [PATCH 1/2] tests: docker-system: Remove unnecessary services from
 Docker image.
Date: Fri,  6 Jun 2025 23:15:38 +0300
Message-ID: <20250606201539.2306357-1-go.wigust@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <87r002r1m7.fsf@HIDDEN>
References: <87r002r1m7.fsf@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 77578
Cc: Oleg Pykhalov <go.wigust@HIDDEN>,
 =?UTF-8?q?Ludovic=20Court=C3=A8s?= <ludo@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

These services aren't needed in containers since:
- udev requires device tree access controlled by the container runtime
- urandom-seed depends on udev service

* gnu/tests/docker.scm (%test-docker-system): Remove udev-service-type,
urandom-seed-service-type.

Change-Id: I2c3f7bc54fa6b5a802c8e16cba6ffae0cd09d4cc
Signed-off-by: Oleg Pykhalov <go.wigust@HIDDEN>
---
 gnu/tests/docker.scm | 26 +++++++++++++++++++-------
 1 file changed, 19 insertions(+), 7 deletions(-)

diff --git a/gnu/tests/docker.scm b/gnu/tests/docker.scm
index 90c8d0f850..84d604f8d3 100644
--- a/gnu/tests/docker.scm
+++ b/gnu/tests/docker.scm
@@ -26,10 +26,12 @@ (define-module (gnu tests docker)
   #:use-module (gnu system image)
   #:use-module (gnu system vm)
   #:use-module (gnu services)
+  #:use-module (gnu services base)
   #:use-module (gnu services dbus)
   #:use-module (gnu services networking)
   #:use-module (gnu services docker)
   #:use-module (gnu services desktop)
+  #:use-module (gnu services shepherd)
   #:use-module (gnu packages)
   #:use-module ((gnu packages base) #:select (glibc))
   #:use-module (gnu packages guile)
@@ -340,13 +342,23 @@ (define %test-docker-system
 docker-image} inside Docker.")
    (value (with-monad %store-monad
             (>>= (lower-object
-                  (system-image (os->image
-                                 (operating-system
-                                   (inherit (simple-operating-system))
-                                   ;; Use locales for a single libc to
-                                   ;; reduce space requirements.
-                                   (locale-libcs (list glibc)))
-                                 #:type docker-image-type)))
+                  (system-image
+                   (os->image
+                    (let ((os (simple-operating-system)))
+                      (operating-system
+                        (inherit os)
+                        ;; Use locales for a single libc to
+                        ;; reduce space requirements.
+                        (locale-libcs (list glibc))
+                        (services
+                         (modify-services (operating-system-user-services os)
+                           ;; Inside a container, the device tree is often
+                           ;; limited and controlled by a container runtime.
+                           (delete udev-service-type)
+                           ;; Seeding urandom rely on devices that are not
+                           ;; available inside the container.
+                           (delete urandom-seed-service-type)))))
+                    #:type docker-image-type)))
                  run-docker-system-test)))))
 
 
-- 
2.41.0





Information forwarded to guix-patches@HIDDEN:
bug#77578; Package guix-patches. Full text available.

Message received at 77578 <at> debbugs.gnu.org:


Received: (at 77578) by debbugs.gnu.org; 2 Jun 2025 09:59:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 02 05:59:37 2025
Received: from localhost ([127.0.0.1]:48546 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uM1xA-0006dd-LQ
	for submit <at> debbugs.gnu.org; Mon, 02 Jun 2025 05:59:37 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:51050)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1uM1x8-0006ce-EK
 for 77578 <at> debbugs.gnu.org; Mon, 02 Jun 2025 05:59:34 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1uM1x3-0002dz-4D; Mon, 02 Jun 2025 05:59:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=cK50Cpaz/JjNJ12wneA35VJAm/I+oZ1iRoBpyQx+EP4=; b=eWxFCouembNNLo9rwgY/
 cHMi1fzeJIKhOkln30HcKTjQLWSiX8ZLXgctHkkI5H3LdhZBqZ2n+yAc84OziV7tgeoBS1HBQz5qX
 T7IbVb2wlgIPDQ28GWJe4B3VEVeKQ1eshwXHDDKoNBNFCCKzVcFc30biQEsWVgfXRBqrS+9dkBR/6
 oetYAhJrdVtD5HRPhdXAkBa4rZJD0oNGE9WYz6p0hxMpTYfeSdgdjnuvgFHWy2wf3YYz1rryYsu4u
 WZIeP++g622NFBYecbuJTP4ykh4UHghSmTDExkjnHZXtYqkjGHLKnIJtR6ZFcem+/gwt99zFpPCGm
 r2N3sjgmWxgeiw==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Oleg Pykhalov <go.wigust@HIDDEN>,  77578 <at> debbugs.gnu.org
Subject: Re: [bug#77578] [PATCH 1/2] tests: docker-system: Remove
 unnecessary services from Docker image.
In-Reply-To: <871pt19y8p.fsf@HIDDEN> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?=
 =?utf-8?Q?s?= message of "Wed, 07 May 2025 00:21:26 +0200")
References: <87v7r49nn2.fsf@HIDDEN>
 <20250418195239.94452-1-go.wigust@HIDDEN> <8734dwfexp.fsf@HIDDEN>
 <871pt19y8p.fsf@HIDDEN>
Date: Mon, 02 Jun 2025 10:25:52 +0200
Message-ID: <87r002r1m7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 77578
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi Oleg,

Ludovic Court=C3=A8s <ludo@HIDDEN> writes:

> Ludovic Court=C3=A8s <ludo@HIDDEN> writes:
>
>>> +                         (modify-services
>>> +                             (append
>>> +                              (operating-system-user-services os)
>>> +                              (list
>>> +                               (service syslog-service-type
>>> +                                        (syslog-configuration
>>> +                                         (extra-options
>>> +                                          '("--rcfile=3D/etc/syslog.co=
nf"
>>> +                                            "--no-forward"
>>> +                                            "--no-unixaf"
>>> +                                            "--no-klog"))))))
>>> +                           ;; 'herd status' is unresponsive. Investiga=
tion
>>> +                           ;; needed to resolve before migrating from =
syslog
>>> +                           ;; logging.
>>> +                           (delete shepherd-system-log-service-type)
>>
>> I think that=E2=80=99s because by default =E2=80=98system-log-service=E2=
=80=99 tries to open
>> /proc/kmsg; it fails in the container, which causes =E2=80=98system-log=
=E2=80=99 to fail
>> to start, and then nothing starts.
>>
>> The solution is to modify =E2=80=98shepherd-system-log-service-type=E2=
=80=99 to set
>> =E2=80=98kernel-log-file=E2=80=99 to #f (similar to =E2=80=98--no-klog=
=E2=80=99 above).
>
> I also pushed a fix in the Shepherd (which will be in 1.0.5) where
> =E2=80=98system-log=E2=80=99 starts even if #:kernel-log-file is inaccess=
ible:
>
>   https://git.savannah.gnu.org/cgit/shepherd.git/commit/?id=3Da54a503b01f=
9da4f6fb49d736dcf90da0fe51f1b

Now that 1.0.5 is out, could we revisit this patch?

TIA,
Ludo=E2=80=99.




Information forwarded to guix-patches@HIDDEN:
bug#77578; Package guix-patches. Full text available.

Message received at 77578 <at> debbugs.gnu.org:


Received: (at 77578) by debbugs.gnu.org; 6 May 2025 22:21:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 06 18:21:58 2025
Received: from localhost ([127.0.0.1]:34950 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uCQfl-0001bA-Mi
	for submit <at> debbugs.gnu.org; Tue, 06 May 2025 18:21:57 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:44640)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1uCQfg-0001aK-1V
 for 77578 <at> debbugs.gnu.org; Tue, 06 May 2025 18:21:52 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1uCQfa-0002hU-EA; Tue, 06 May 2025 18:21:46 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=7W/xx4ekT9kMgSWt8eDMNBPd0RfxTKgAAhrsaSeEL2M=; b=Gnp19PWjMQXDRJ57Z+er
 5q4uGsczbfioQ3l+V9Jt68hswRyzLBAcIo4LcepURKmEpGwLJ77QW4ocpLizrmSroaNUz4iftNlNM
 NVXS6CmuaeKHctnwDLKREvrf79eMzbZR5VXLqLydNI+0ze4L1Gs1JI5px3TWYEHKFpBkfhHfJGqcj
 p+oMvJZv+qHZrFcrKSl2qJCPKt8FGDGGElbrKzcVOjIUN/rQxCOwNCEXb8c3/RI0i50FN33LoEm58
 0seAGzAe0U92O6AG7xWYKRb9GYh/G3o67+wwuZsCddQnNPp9oQULyvFoOyFwI+t6EL02zl2fG58zq
 uoyacpNG/tRiRA==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Oleg Pykhalov <go.wigust@HIDDEN>
Subject: Re: [bug#77578] [PATCH 1/2] tests: docker-system: Remove
 unnecessary services from Docker image.
In-Reply-To: <8734dwfexp.fsf@HIDDEN> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?=
 =?utf-8?Q?s?= message of "Fri, 25 Apr 2025 17:17:54 +0200")
References: <87v7r49nn2.fsf@HIDDEN>
 <20250418195239.94452-1-go.wigust@HIDDEN> <8734dwfexp.fsf@HIDDEN>
Date: Wed, 07 May 2025 00:21:26 +0200
Message-ID: <871pt19y8p.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 77578
Cc: 77578 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

Ludovic Court=C3=A8s <ludo@HIDDEN> writes:

>> +                         (modify-services
>> +                             (append
>> +                              (operating-system-user-services os)
>> +                              (list
>> +                               (service syslog-service-type
>> +                                        (syslog-configuration
>> +                                         (extra-options
>> +                                          '("--rcfile=3D/etc/syslog.con=
f"
>> +                                            "--no-forward"
>> +                                            "--no-unixaf"
>> +                                            "--no-klog"))))))
>> +                           ;; 'herd status' is unresponsive. Investigat=
ion
>> +                           ;; needed to resolve before migrating from s=
yslog
>> +                           ;; logging.
>> +                           (delete shepherd-system-log-service-type)
>
> I think that=E2=80=99s because by default =E2=80=98system-log-service=E2=
=80=99 tries to open
> /proc/kmsg; it fails in the container, which causes =E2=80=98system-log=
=E2=80=99 to fail
> to start, and then nothing starts.
>
> The solution is to modify =E2=80=98shepherd-system-log-service-type=E2=80=
=99 to set
> =E2=80=98kernel-log-file=E2=80=99 to #f (similar to =E2=80=98--no-klog=E2=
=80=99 above).

I also pushed a fix in the Shepherd (which will be in 1.0.5) where
=E2=80=98system-log=E2=80=99 starts even if #:kernel-log-file is inaccessib=
le:

  https://git.savannah.gnu.org/cgit/shepherd.git/commit/?id=3Da54a503b01f9d=
a4f6fb49d736dcf90da0fe51f1b

In the meantime, the solution I proposed above remains necessary.

Ludo=E2=80=99.




Information forwarded to guix-patches@HIDDEN:
bug#77578; Package guix-patches. Full text available.

Message received at 77578 <at> debbugs.gnu.org:


Received: (at 77578) by debbugs.gnu.org; 25 Apr 2025 17:14:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 25 13:14:47 2025
Received: from localhost ([127.0.0.1]:52288 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u8MdS-0008B4-Jc
	for submit <at> debbugs.gnu.org; Fri, 25 Apr 2025 13:14:47 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:40662)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1u8MdQ-0008AA-2n
 for 77578 <at> debbugs.gnu.org; Fri, 25 Apr 2025 13:14:44 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1u8MdK-00017L-Io; Fri, 25 Apr 2025 13:14:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=lnfzbk7/LzPt8o3ipz+pf5up67AjqRBT3AZnnqmtnNQ=; b=lowcHlc9UpzDMftCSlP3
 yvrGSveKUPpPhH6E0TJAXUijlmSu17n4aNI64KbPXuVrNz8cob/8MgiZXBKh9xcp+UYUUtJLZUVsK
 YiStBdqqfq3jUFz6XCpeXg5weflmiye1oWMGbhDEw9Qd+o2cj1IVkbXe6sqwWM0YeuxhsexSLvFAG
 Y3goym9iPD1B32iiIhe0OCCk3X6IquvE5ZGvJSJidj0n3U42Cw6Y46fivxSqS6Pg5DmShIc42nrYD
 Jc4MQnqOqIAbi6NKEJI4hHAPLHqAOYWZIbrs0Md/wXeODo6aPlO9GyHYIOG8RNmukIffXVGXjQAJ/
 49EL532IbVMvCA==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Oleg Pykhalov <go.wigust@HIDDEN>
Subject: Re: [bug#77578] [PATCH 1/2] tests: docker-system: Remove
 unnecessary services from Docker image.
In-Reply-To: <20250418195239.94452-1-go.wigust@HIDDEN> (Oleg Pykhalov's
 message of "Fri, 18 Apr 2025 22:52:38 +0300")
References: <87v7r49nn2.fsf@HIDDEN>
 <20250418195239.94452-1-go.wigust@HIDDEN>
Date: Fri, 25 Apr 2025 17:17:54 +0200
Message-ID: <8734dwfexp.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 77578
Cc: 77578 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

Oleg Pykhalov <go.wigust@HIDDEN> writes:

> 'run-docker-system-test' was hanging during execution of 'herd status' in=
side
> a container. This occurred because '%test-docker-system' specified more
> services than 'gnu/system/examples/docker-image.tmpl', which may have cau=
sed
> conflicts or unexpected behavior.
>
> * gnu/tests/docker.scm (%test-docker-system): Remove
> static-networking-service-type, udev-service-type, urandom-seed-service-t=
ype,
> shepherd-system-log-service-type. Add syslog-service-type.
>
> Change-Id: I2c3f7bc54fa6b5a802c8e16cba6ffae0cd09d4cc
> +                        (services
> +                         (modify-services
> +                             (append
> +                              (operating-system-user-services os)
> +                              (list
> +                               (service syslog-service-type
> +                                        (syslog-configuration
> +                                         (extra-options
> +                                          '("--rcfile=3D/etc/syslog.conf"
> +                                            "--no-forward"
> +                                            "--no-unixaf"
> +                                            "--no-klog"))))))
> +                           ;; 'herd status' is unresponsive. Investigati=
on
> +                           ;; needed to resolve before migrating from sy=
slog
> +                           ;; logging.
> +                           (delete shepherd-system-log-service-type)

I think that=E2=80=99s because by default =E2=80=98system-log-service=E2=80=
=99 tries to open
/proc/kmsg; it fails in the container, which causes =E2=80=98system-log=E2=
=80=99 to fail
to start, and then nothing starts.

The solution is to modify =E2=80=98shepherd-system-log-service-type=E2=80=
=99 to set
=E2=80=98kernel-log-file=E2=80=99 to #f (similar to =E2=80=98--no-klog=E2=
=80=99 above).

> +                           ;; Containers are created with limited privil=
eges
> +                           ;; by default as a security measure. This
> +                           ;; restriction can prevent direct configurati=
on of
> +                           ;; networking or hostname settings, which oft=
en
> +                           ;; require elevated permissions. Container ru=
ntimes
> +                           ;; typically manage these aspects using inter=
nal
> +                           ;; mechanisms and the CNI (Container Network
> +                           ;; Interface) standard, abstracting away much=
 of
> +                           ;; the underlying network configuration.
> +                           (delete static-networking-service-type)
> +
> +                           ;; Inside a container, the device tree is oft=
en
> +                           ;; limited and controlled by a container runt=
ime.
> +                           (delete udev-service-type)
> +                           ;; Seeding urandom rely on devices that are n=
ot
> +                           ;; available inside the container.
> +                           (delete urandom-seed-service-type)))))

I realized that =E2=80=98containerized-operating-system=E2=80=99 already at=
tempts to do
exactly that (it misses udev, urandom, and system-log handling though).

Should we use it here, adjusting it as needed?

Thank you, and apologies for the back-and-forth,
Ludo=E2=80=99.




Information forwarded to guix-patches@HIDDEN:
bug#77578; Package guix-patches. Full text available.

Message received at 77578 <at> debbugs.gnu.org:


Received: (at 77578) by debbugs.gnu.org; 18 Apr 2025 19:54:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 18 15:54:47 2025
Received: from localhost ([127.0.0.1]:52991 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u5rnS-00016K-Gl
	for submit <at> debbugs.gnu.org; Fri, 18 Apr 2025 15:54:47 -0400
Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:51691)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <go.wigust@HIDDEN>)
 id 1u5rn7-00012H-Te
 for 77578 <at> debbugs.gnu.org; Fri, 18 Apr 2025 15:54:27 -0400
Received: by mail-lf1-x135.google.com with SMTP id
 2adb3069b0e04-548409cd2a8so2917896e87.3
 for <77578 <at> debbugs.gnu.org>; Fri, 18 Apr 2025 12:54:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1745006059; x=1745610859; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=xNburNIPyaIBNxgiyIY+db8a2LZtt7a+p+AoFnMQqCw=;
 b=Ek2eTEQRwzwikt3FBH8kFDaU/GJ9vAcc2uENSO5Gy+k1+LEbAbhXsPxcZOwRJj8lIL
 WKde8FDEhUNjvMYeUO42M2zh3gRYorVixj6jycMvWnKiYgWvfq3k6FWti3vc9/g1yzI9
 jBMekYx5Yqbjtzr8eFFjYAutN9ndbldgzADt40d8tfC6zvllNvRwkvd6w0YiUTN1STiN
 P43wBQAAZFSTRTkCrThdbhg5hiU3EJeh2qvXg7Yw5oSWUa72dljEAGCHZuQFBhSd92gg
 biZtRB2p0b05YUEyQbS45M+Zuafdb/e5NPab9+QSlNYkqrnw9IZ551YUfW78MELzwoBf
 N33w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1745006059; x=1745610859;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=xNburNIPyaIBNxgiyIY+db8a2LZtt7a+p+AoFnMQqCw=;
 b=Kx7wmdiPOG1GC9TJCod8y/5I7+5nuepKZkD4pYVmADkd3H7rGkh0ISy4KgFHGZ+dBb
 EuB7WmVOh0NZgMqW3gyDNByz01PIA6kbcYTNK5gDQ9GGArlQ0CbWp+IE34Xi/ySucW2J
 WNiLSC5xuw+lI+3f/1/mEulUq5WPVQLeLhGQnYhl0UAWcG+snG92sBPrvFUzZKTVYDMN
 N3s9wAEgnt/cWcrQbrjN97rpyGK7fuKLfuuClwLp2jWMl09h9F4APLEEyTv1SMKKkAWV
 3WMzL7hbZBotGxnZiKqiVSzZ3gQBM/KsLknAKFKmxW1VeDpkddBLq2ykHkpc6BZZ0pRj
 MREw==
X-Gm-Message-State: AOJu0Yy94Zws0izhqoDDj5YO9k5JfST72pF5eg0DxBX0Oqe4sxpmo9IM
 dHRMYPgcazLIKtx5+no4omiQ6AhQpL2diifwoVUqG79UDwmN8Z5F0UhVjOYk
X-Gm-Gg: ASbGncvom59Y/+CTabz1iwEHvgIH+t2l08tcI0r9vjB66VR9tspdbwUGLtfHZXRQXef
 orcL7Hh/US6KQQRjWq9z1f2o4ZjGq3D1+C6biAwianIq/104YMwi4XpTe8+JCuhbTCTAswM4EvH
 fN8HJLFbYH/TmFAwMhFHxACwca7Q+2f97avFSeFViHDhYdJWkg9gJFrBWp9n0bSOFzUNKGT+cKM
 yeKcMvkZJKcnlDLTqCaC8pMmzIbfoQFKfbXIWS5sbuZrT28VSELRDu6Jh6lcqX1eUIwOl/G4JQS
 ZJw9na/Kva64e/Un3+pEKqe/dvwG3/6SO6Q9JkwaLO9otd4AH+Q=
X-Google-Smtp-Source: AGHT+IF5wo/PsPl1doJwDxYuoKTiL4rEHCG+ZVLFghg7AzxmizluIbY8zcmQ5XgIGY6N1PO844AcGA==
X-Received: by 2002:a05:6512:ac3:b0:54b:e70:3658 with SMTP id
 2adb3069b0e04-54d6e615e52mr717798e87.2.1745006058969; 
 Fri, 18 Apr 2025 12:54:18 -0700 (PDT)
Received: from localhost.localdomain ([93.100.15.190])
 by smtp.gmail.com with ESMTPSA id
 2adb3069b0e04-54d6e540a02sm264956e87.60.2025.04.18.12.54.18
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 18 Apr 2025 12:54:18 -0700 (PDT)
From: Oleg Pykhalov <go.wigust@HIDDEN>
To: 77578 <at> debbugs.gnu.org
Subject: [PATCH 2/2] tests: docker-system: Add network up test.
Date: Fri, 18 Apr 2025 22:52:39 +0300
Message-ID: <20250418195239.94452-2-go.wigust@HIDDEN>
X-Mailer: git-send-email 2.47.1
In-Reply-To: <20250418195239.94452-1-go.wigust@HIDDEN>
References: <87v7r49nn2.fsf@HIDDEN>
 <20250418195239.94452-1-go.wigust@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 77578
Cc: Oleg Pykhalov <go.wigust@HIDDEN>,
 =?UTF-8?q?Ludovic=20Court=C3=A8s?= <ludo@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Addresses intermittent Docker test failures caused by timing issues where
container-related checks ran before the networking service was fully
initialized. A new "network is up" assertion has been added to explicitly
start and verify the 'networking' service using `marionette-eval`.

* gnu/tests/docker.scm (%test-docker-system): Add "network is up" test.

Change-Id: I0c761ae2ce2e7b398c8f35ea1faf50257193ccc5
---
 gnu/tests/docker.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/tests/docker.scm b/gnu/tests/docker.scm
index 3c3995c9b8..540ac76877 100644
--- a/gnu/tests/docker.scm
+++ b/gnu/tests/docker.scm
@@ -252,6 +252,13 @@ (define marionette
           (test-runner-current (system-test-runner #$output))
           (test-begin "docker")
 
+          (test-assert "network is up"
+            (marionette-eval
+             '(begin
+                (use-modules (gnu services herd))
+                (start-service 'networking))
+             marionette))
+
           (test-assert "containerd service running"
             (marionette-eval
              '(begin
-- 
2.47.1





Information forwarded to guix-patches@HIDDEN:
bug#77578; Package guix-patches. Full text available.

Message received at 77578 <at> debbugs.gnu.org:


Received: (at 77578) by debbugs.gnu.org; 18 Apr 2025 19:54:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 18 15:54:05 2025
Received: from localhost ([127.0.0.1]:52988 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u5rmk-0000zV-Ln
	for submit <at> debbugs.gnu.org; Fri, 18 Apr 2025 15:54:05 -0400
Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:42284)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <go.wigust@HIDDEN>)
 id 1u5rmf-0000xi-3J
 for 77578 <at> debbugs.gnu.org; Fri, 18 Apr 2025 15:54:00 -0400
Received: by mail-lf1-x12c.google.com with SMTP id
 2adb3069b0e04-54af20849adso2142642e87.1
 for <77578 <at> debbugs.gnu.org>; Fri, 18 Apr 2025 12:53:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1745006030; x=1745610830; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=Oxn3uQq++2W+vFrfdqZ/UJDpkaRBocTW+B0S/VReh50=;
 b=gERmmL7RDDqY41SA3eld3bMW9uAThzsskJpfjEhk+rJfHiKco2socjF6Jn4foSX4QK
 h6kHWToWIhhAVrvtVmsm2KvUn9WciQR3T8+F5T2hPv4DCeRTXqP/DJxjL50dYVyYmn9I
 0V3kptUyU4dQDuVMNFz4Plx7Gkwf35CKG2HhJ/LJDzV8O+/QjEFA6/fYCc0ssQY36tyK
 i0drqV61MZWDzZPcP3rUtrw19juw0Zbp6s4bHv0lSn25WWXTv5sNH4f4zve/dCeH9PKe
 cnoLyWWK4uTZp3n5KyyMzCFanNLs0VjOHC/g1d8SWOagH3P4LVdwelk3j6/408LljUBv
 mQsA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1745006030; x=1745610830;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=Oxn3uQq++2W+vFrfdqZ/UJDpkaRBocTW+B0S/VReh50=;
 b=NP3ez34NpAOJ5UMOYgjdJ7YIMtPtvTPG+VGjp1nC5BxQQi//jPEkYEWp8QSxu1yX03
 iN/LGiZ7yuxrVzUr6MFBuGfwqyxX6lK2G89WS8sWmzNurA3SlPAOOj+Hyi6XyLaqSyZI
 BLslVybTrjORlHvjiRLVbBmtNFM90WyweD88V2pg/WugHOu048rfG9X7oYtUFUj4ngEq
 i2l0Kzoap31+7WzJUfJdhg3ahbIfRRKQsODmFKRDClvRyO2E01rx2LbSJ/9rLJe6Qt/L
 NwcwUIEfc9uBCmGsWZBchzdjjRAPqQ7SUkZM/2h2ob2ns4MXrVMfPRkjlTneGskAb/nJ
 7nQw==
X-Gm-Message-State: AOJu0YyHjVXF/HLfFrlBBrh48ujD+vSityn74+Z7o+89gQVyL3wo5+iH
 jjQg02zWI2+04y0x6+l5v72xCsSQrpGjv+JYwNB+f9fvA9ztjekk4QT3UbcI
X-Gm-Gg: ASbGnctkHph85s0O2W21rjLz0rVnWBc/46QWIMceCUA5fxovCsCBB8JFKCrJ6wvcohO
 1+Kg2Fpwa/8HNrC+QVLV68V2GNmmyvd+ABmcL89kK4om9X+t2lvWJZlxEF8pN9y1nUTwng86oih
 6e69bNZ96+/bEyS5DuHO/MqYm0bjKcxD/mnZ2cc8sngfEemHz0NRsljGpZvAc6h+dhKKOz8l9Wo
 AnQNqTf/HTz0L1/TEnU6ILXx15lu9NamPfY8i/vyWOMRKmYE06SA9ybsPjTB6wVGNTxqvZV+vch
 TmJ1tIVy3qNWU7MAN6RSCIKQ2Q8J0IXGV4nANI3ExVTkqfoPb5c=
X-Google-Smtp-Source: AGHT+IHpdfv8mQ7Eo7U7Qqj7hBEAnV2AqU0dmiwSC1PqjxotcYwPkogE5F8kumdxd9cEJUn+FIwwPg==
X-Received: by 2002:a05:6512:682:b0:545:2474:2c9b with SMTP id
 2adb3069b0e04-54d6e7e0153mr996584e87.22.1745006029807; 
 Fri, 18 Apr 2025 12:53:49 -0700 (PDT)
Received: from localhost.localdomain ([93.100.15.190])
 by smtp.gmail.com with ESMTPSA id
 2adb3069b0e04-54d6e540a02sm264956e87.60.2025.04.18.12.53.49
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 18 Apr 2025 12:53:49 -0700 (PDT)
From: Oleg Pykhalov <go.wigust@HIDDEN>
To: 77578 <at> debbugs.gnu.org
Subject: [PATCH 1/2] tests: docker-system: Remove unnecessary services from
 Docker image.
Date: Fri, 18 Apr 2025 22:52:38 +0300
Message-ID: <20250418195239.94452-1-go.wigust@HIDDEN>
X-Mailer: git-send-email 2.47.1
In-Reply-To: <87v7r49nn2.fsf@HIDDEN>
References: <87v7r49nn2.fsf@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 77578
Cc: Oleg Pykhalov <go.wigust@HIDDEN>,
 =?UTF-8?q?Ludovic=20Court=C3=A8s?= <ludo@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

'run-docker-system-test' was hanging during execution of 'herd status' inside
a container. This occurred because '%test-docker-system' specified more
services than 'gnu/system/examples/docker-image.tmpl', which may have caused
conflicts or unexpected behavior.

* gnu/tests/docker.scm (%test-docker-system): Remove
static-networking-service-type, udev-service-type, urandom-seed-service-type,
shepherd-system-log-service-type. Add syslog-service-type.

Change-Id: I2c3f7bc54fa6b5a802c8e16cba6ffae0cd09d4cc
---
 gnu/tests/docker.scm | 53 ++++++++++++++++++++++++++++++++++++++------
 1 file changed, 46 insertions(+), 7 deletions(-)

diff --git a/gnu/tests/docker.scm b/gnu/tests/docker.scm
index 90c8d0f850..3c3995c9b8 100644
--- a/gnu/tests/docker.scm
+++ b/gnu/tests/docker.scm
@@ -26,10 +26,13 @@ (define-module (gnu tests docker)
   #:use-module (gnu system image)
   #:use-module (gnu system vm)
   #:use-module (gnu services)
+  #:use-module (gnu services admin)
+  #:use-module (gnu services base)
   #:use-module (gnu services dbus)
   #:use-module (gnu services networking)
   #:use-module (gnu services docker)
   #:use-module (gnu services desktop)
+  #:use-module (gnu services shepherd)
   #:use-module (gnu packages)
   #:use-module ((gnu packages base) #:select (glibc))
   #:use-module (gnu packages guile)
@@ -340,13 +343,49 @@ (define %test-docker-system
 docker-image} inside Docker.")
    (value (with-monad %store-monad
             (>>= (lower-object
-                  (system-image (os->image
-                                 (operating-system
-                                   (inherit (simple-operating-system))
-                                   ;; Use locales for a single libc to
-                                   ;; reduce space requirements.
-                                   (locale-libcs (list glibc)))
-                                 #:type docker-image-type)))
+                  (system-image
+                   (os->image
+                    (let ((os (simple-operating-system)))
+                      (operating-system
+                        (inherit os)
+                        ;; Use locales for a single libc to
+                        ;; reduce space requirements.
+                        (locale-libcs (list glibc))
+                        (services
+                         (modify-services
+                             (append
+                              (operating-system-user-services os)
+                              (list
+                               (service syslog-service-type
+                                        (syslog-configuration
+                                         (extra-options
+                                          '("--rcfile=/etc/syslog.conf"
+                                            "--no-forward"
+                                            "--no-unixaf"
+                                            "--no-klog"))))))
+                           ;; 'herd status' is unresponsive. Investigation
+                           ;; needed to resolve before migrating from syslog
+                           ;; logging.
+                           (delete shepherd-system-log-service-type)
+
+                           ;; Containers are created with limited privileges
+                           ;; by default as a security measure. This
+                           ;; restriction can prevent direct configuration of
+                           ;; networking or hostname settings, which often
+                           ;; require elevated permissions. Container runtimes
+                           ;; typically manage these aspects using internal
+                           ;; mechanisms and the CNI (Container Network
+                           ;; Interface) standard, abstracting away much of
+                           ;; the underlying network configuration.
+                           (delete static-networking-service-type)
+
+                           ;; Inside a container, the device tree is often
+                           ;; limited and controlled by a container runtime.
+                           (delete udev-service-type)
+                           ;; Seeding urandom rely on devices that are not
+                           ;; available inside the container.
+                           (delete urandom-seed-service-type)))))
+                    #:type docker-image-type)))
                  run-docker-system-test)))))
 
 
-- 
2.47.1





Information forwarded to guix-patches@HIDDEN:
bug#77578; Package guix-patches. Full text available.

Message received at 77578 <at> debbugs.gnu.org:


Received: (at 77578) by debbugs.gnu.org; 16 Apr 2025 16:25:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 16 12:25:01 2025
Received: from localhost ([127.0.0.1]:40803 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u55ZK-0007CY-OV
	for submit <at> debbugs.gnu.org; Wed, 16 Apr 2025 12:25:01 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:33612)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1u55Z4-0007AD-HA
 for 77578 <at> debbugs.gnu.org; Wed, 16 Apr 2025 12:24:44 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1u55Yy-00043y-Rw; Wed, 16 Apr 2025 12:24:36 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=On6Dr5n3qrYDJNg3KTAOb+uOgd/4Knoxbz+knD+KMc0=; b=Hji+DO/1E1/4e/zW2NO6
 YC5CVV5dZ0Fk+gms4uyY1/DFAU1fp0J9Dnc1mRWH/0ujdZgzorSwonjVlkST8KbBk+diAbZLhg8U/
 u0nnApaXoUS0tvMu2HA0qbNHEwTr93Usw6GbquT72ye6JPP2Doq+0fl8qExGAxS/PRkPkF+W+BCXF
 oeNY3ASLFPVc0pPl61JrNa5ANUEKvTcNgWJ+xH54YHo2cNjBnU44zyNF5ny8lRCe2ytrQc8NX91Hj
 ssuQ2KVIFJ9YCglA0aTZTdbVbjMM44pFjppfcq0j5v4CTMKkrGakvmiyf2TcmcTosWt2WsibikRMr
 5UwtSD0c6Yq0qg==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Oleg Pykhalov <go.wigust@HIDDEN>
Subject: Re: [bug#77578] [PATCH] tests: docker-system: Use only guix-daemon
 service.
In-Reply-To: <877c3kqkl3.fsf@HIDDEN> (Oleg Pykhalov's message of "Wed, 16
 Apr 2025 16:53:12 +0300")
References: <20250406150701.10549-1-go.wigust@HIDDEN>
 <871pu24r3b.fsf@HIDDEN> <877c3kqkl3.fsf@HIDDEN>
User-Agent: mu4e 1.12.9; emacs 29.4
X-URL: https://people.bordeaux.inria.fr/lcourtes/
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
X-Revolutionary-Date: Septidi 27 Germinal an 233 de la =?utf-8?Q?R=C3=A9vo?=
 =?utf-8?Q?lution=2C?= jour de =?utf-8?Q?l'An=C3=A9mone?=
Date: Wed, 16 Apr 2025 16:39:13 +0200
Message-ID: <87v7r49nn2.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 77578
Cc: 77578 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi Oleg,

Oleg Pykhalov <go.wigust@HIDDEN> writes:

> Ludovic Court=C3=A8s <ludo@HIDDEN> writes:
>
>> Oleg Pykhalov <go.wigust@HIDDEN> skribis:
>>
>>> The test run-docker-system-test was hanging on:
>>>
>>> (docker-cli "exec" container
>>>              "/run/current-system/profile/bin/herd"
>>>              "status")
>>>
>>> This occurred because %test-docker-system specified more services than
>>> gnu/system/examples/docker-image.tmpl, which may have caused conflicts =
or
>>> unexpected behavior.
>>>
>>> * gnu/tests/docker.scm (%test-docker-system): Simplify by using only the
>>> guix-daemon service to prevent test hangs.
>>
>> It=E2=80=99s not clear to me why =E2=80=98herd status=E2=80=99 was block=
ing in the first
>> place=E2=80=94it=E2=80=99s never supposed to happen.  Do you have ideas?
>
> The docker create command creates a container with a limited set of
> privileges by default. These default privileges are insufficient for
> certain configuration tasks such as networking setup or hostname
> configuration.

Oh I see.  Then, what about changing the patch to (1) specifically
remove the one or two services that are problematic, and (2) have the
above in a comment?

Thanks for explaining,
Ludo=E2=80=99.

PS: Would be great to have support for CNI and all this!




Information forwarded to guix-patches@HIDDEN:
bug#77578; Package guix-patches. Full text available.

Message received at 77578 <at> debbugs.gnu.org:


Received: (at 77578) by debbugs.gnu.org; 16 Apr 2025 13:53:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 16 09:53:24 2025
Received: from localhost ([127.0.0.1]:37265 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u53Cd-0005Nv-KN
	for submit <at> debbugs.gnu.org; Wed, 16 Apr 2025 09:53:24 -0400
Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:53464)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <go.wigust@HIDDEN>)
 id 1u53Ca-0005Mw-GI
 for 77578 <at> debbugs.gnu.org; Wed, 16 Apr 2025 09:53:21 -0400
Received: by mail-lf1-x12a.google.com with SMTP id
 2adb3069b0e04-54996d30bfbso6083383e87.2
 for <77578 <at> debbugs.gnu.org>; Wed, 16 Apr 2025 06:53:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1744811594; x=1745416394; darn=debbugs.gnu.org;
 h=mime-version:message-id:date:user-agent:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=QA4Fo4DO1BgOIUdluAHa0/ajPPdfTjMUvDP5dp57xRo=;
 b=VKdtPC/h7BTi8QWnAQC31XmU6j6+8lQewB/YTSemHZvffNkVxMa3miBm/gO1t/kjIZ
 q9X8mVTrnEDI7trme2xISYoX3mC2MFgRAUSwtUFTNow4TQmAuDFHD2Q/bYkADrE+Sst4
 SKWv1OcAZCt3n39gmrHCfbCFmGxq5brQ0jiYXSFnrrYCGqmknRDQYB/PZ29OvLSVKIcq
 mmZUJNoOgIN0rroMgDswt4edGwNlifbpQT2e3E8cJ94zhv2u0gjdk34BTvxKQl93kQ5l
 Bl72U+dy7+SPjBTSyVx+yUcujPfg9Fu6bk59h+wH8g35DiknIrh5sHXRcju0UIgmij7g
 5/8Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1744811594; x=1745416394;
 h=mime-version:message-id:date:user-agent:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=QA4Fo4DO1BgOIUdluAHa0/ajPPdfTjMUvDP5dp57xRo=;
 b=sanvCQTnPWSc0VSkWiYqEBETDapMRO9Z8z1vjTNfvWdV/SQs7dti/+JCJBOeqSxfF0
 qS7nBth1QfF4LOdbIEJYuYTq/VDxDnb6dvWu0teMcurc9l0AzU290LyIK7Hm4TgC/YV+
 tc1MLAG6WQKzupso6QWbpbuqWni10tgRh9i6fxP2CPDoVLdWgxFltapHjZyN90JktrXO
 /YBrJEealzD2iVQGUWuFYLGnk5WzAdujjsfoco0WzPMgnUUWXpw44gw99nVS+gxrV6HK
 jsphLkne4lmDcv8s9ujXUVMNT/P8kysix3qncCamUjZ6N9Jt6mhwUf4pDn1v6a/Az+rQ
 VlZw==
X-Gm-Message-State: AOJu0YzGlm6YMcvvp4Y2d+WAxAgJHotdFS0XKQoZ4qNLMAt9kefRxojK
 BxYXpY2yeoj4TBdO5jCAeF85KLE6wGXOTe1bv5OyU0F0ZtFyJd2Lab/9GNsY
X-Gm-Gg: ASbGncsA5lgtwrBnBlgx898a3+d/CHauAlyJTGR3xbfvtGvblwv0zKXl2n7zrwvYqL+
 SwURgqtnrJFaP1R3IxcT/YC+tTeBrMxlhy+WJbCt8PC+rEX4B4CQfUt/DPWLk6MbC64eL524SSP
 K71l8I93HNMmXCeIsykshe1qB8pVUWo++xULGxy6TKA1SQjlli0GxW44W+T9uLOzM04mGssMUU4
 /RHv2NcxYblz9RiftisZNf51tW5a9UahSLJLDTvh03BLCAhB43Q6FCl9SURWgbYpzjBv3LnSW8k
 RcIxncTNUzKHMTUSWcbOSr1Oj6fSu/4JMBI=
X-Google-Smtp-Source: AGHT+IFIdJ5qsDX3SdESxsOJsEUWgUFPaYEMbuY7RwYP4kWXwCuq73UpjfenQY9BPYKrS/d5Ng1LBQ==
X-Received: by 2002:a05:6512:15a5:b0:545:56c:36c7 with SMTP id
 2adb3069b0e04-54d64aea4admr675258e87.41.1744811593463; 
 Wed, 16 Apr 2025 06:53:13 -0700 (PDT)
Received: from localhost ([93.100.15.190]) by smtp.gmail.com with ESMTPSA id
 2adb3069b0e04-54d3d50259asm1665326e87.158.2025.04.16.06.53.12
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 16 Apr 2025 06:53:12 -0700 (PDT)
From: Oleg Pykhalov <go.wigust@HIDDEN>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: Re: [bug#77578] [PATCH] tests: docker-system: Use only guix-daemon
 service.
In-Reply-To: <871pu24r3b.fsf@HIDDEN> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?=
 =?utf-8?Q?s?= message of "Tue, 08 Apr 2025 17:20:56 +0200")
References: <20250406150701.10549-1-go.wigust@HIDDEN>
 <871pu24r3b.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Date: Wed, 16 Apr 2025 16:53:12 +0300
Message-ID: <877c3kqkl3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 77578
Cc: 77578 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi Ludovic,

Thank you for review.

Ludovic Court=C3=A8s <ludo@HIDDEN> writes:

> Oleg Pykhalov <go.wigust@HIDDEN> skribis:
>
>> The test run-docker-system-test was hanging on:
>>
>> (docker-cli "exec" container
>>              "/run/current-system/profile/bin/herd"
>>              "status")
>>
>> This occurred because %test-docker-system specified more services than
>> gnu/system/examples/docker-image.tmpl, which may have caused conflicts or
>> unexpected behavior.
>>
>> * gnu/tests/docker.scm (%test-docker-system): Simplify by using only the
>> guix-daemon service to prevent test hangs.
>
> It=E2=80=99s not clear to me why =E2=80=98herd status=E2=80=99 was blocki=
ng in the first
> place=E2=80=94it=E2=80=99s never supposed to happen.  Do you have ideas?

The docker create command creates a container with a limited set of
privileges by default. These default privileges are insufficient for
certain configuration tasks such as networking setup or hostname
configuration.

Guix inside the container attempts to configure networking itself,
whereas containerd and other container runtimes typically handle
networking internally or with the help of CNI (Container Network
Interface). I don=E2=80=99t think Guix should configure networking by defau=
lt in
containers, as this is already managed by the runtime.


Adding the --privileged flag to docker create may allow the test to
pass, note that herd status will report a failure for the 'loopback'
service (though this is non-blocking and won't prevent the test from
passing).


Regards,
Oleg.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJIBAEBCgAyFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAmf/tkgUHGdvLndpZ3Vz
dEBnbWFpbC5jb20ACgkQFn+OpQAa+pzASg/9Fd6ejZ6XmT7V49r8Au7Atb5g+5m8
grwr1nc4awGKXpebNJX1TFpelYNfbTi24vAvlcm/YkJYHeWfSQ1yOyG/Fxcvzeen
dUX2kzYA85+CMKubMdITLkaQx52J/4APuT6BRHE7biCbAYUI+iIIQNN4uGYYPtZo
/H0F0DyigyDAXIIq2cw1QPruZglPtfVNjapPKP/Xx6JijHg8DXJmn/r3dWFS1aYN
hyDTFQxFcHUGz8xLnq06rT5z5/qzWVvjOCB2tEsqw+zcRNDdtaqrgQQlCCqkLtHd
4SUjVwSd86Br07NAcGU6+TAsftum7bis1DfReNzRISqdsruAtd9p+qwFogb5Hdon
PqKC8ZxBo3wewaSraoiXCsvKo13OoPE16C0udmaoBWG8B00r2gDD7HfqaNLTDj6J
7NVQ+7a8E8JqnUMGp7yl08z3UFjUfGwl8RqrNHGM4dX7NxEG7S9lLxp/IdgvnEd1
N1RSUQ8OGqo45VZTdnawZjmwYTZI2wbKoQKwlyBFKtbOD4ZjMfe+vT5wwbtVIVun
LLpmxHOKSsRnsNPI3CWyw7CTEZNMGCL4ObYjbqD76ic+6A2xh8XPXqLBslNICNmd
b8UpaBu/Pr9dDrDi3IXSal6MJO1FlB9NRrluRVN4HRtJ6gKpD+D556ygSGTzrL0W
5awH+tNncFRmoTE=
=1M5O
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#77578; Package guix-patches. Full text available.

Message received at 77578 <at> debbugs.gnu.org:


Received: (at 77578) by debbugs.gnu.org; 8 Apr 2025 15:31:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 08 11:31:41 2025
Received: from localhost ([127.0.0.1]:34802 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u2AvM-00008n-SS
	for submit <at> debbugs.gnu.org; Tue, 08 Apr 2025 11:31:41 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:39572)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1u2AvK-000080-JO
 for 77578 <at> debbugs.gnu.org; Tue, 08 Apr 2025 11:31:38 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1u2AvC-0002L3-AR; Tue, 08 Apr 2025 11:31:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=CbZBZx2zypa+7zrr5ZlkAvoYn8BU+41WxQDB1xMVeqg=; b=TZes7NdPD9cLkG8mogLn
 +4cSeWaAbWJNtaEGF0kNz5V01mUwgbmfxZY+ItIPNrLy6qJBiyzAnewzBxzWFWWghMxIo28PaDoKB
 T8J7Li/3eXp1eTfPjvyEzPCdYBAdheEO5fDrUyQOLZjv22VOU7H51YwtqJub/VYpovNIUvgag9yly
 FakwqgZhiuEncUkN8O33q0+tbTZoiNLWhfhMjcqJbFuOLkeKEqNjm/FcHnOdB+/+Wd24DZ52y1uDQ
 IS7nHK70oR815pFFarlSjnlxQFduJWXcD2azDMH5K8KfTtghfSPqxAYfbWna8sD4dUm0oMgScURSV
 /1fSZWV/oAnCrQ==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Oleg Pykhalov <go.wigust@HIDDEN>
Subject: Re: [bug#77578] [PATCH] tests: docker-system: Use only guix-daemon
 service.
In-Reply-To: <20250406150701.10549-1-go.wigust@HIDDEN> (Oleg Pykhalov's
 message of "Sun, 6 Apr 2025 18:07:01 +0300")
References: <20250406150701.10549-1-go.wigust@HIDDEN>
Date: Tue, 08 Apr 2025 17:20:56 +0200
Message-ID: <871pu24r3b.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 77578
Cc: 77578 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Oleg Pykhalov <go.wigust@HIDDEN> skribis:

> The test run-docker-system-test was hanging on:
>
> (docker-cli "exec" container
>              "/run/current-system/profile/bin/herd"
>              "status")
>
> This occurred because %test-docker-system specified more services than
> gnu/system/examples/docker-image.tmpl, which may have caused conflicts or
> unexpected behavior.
>
> * gnu/tests/docker.scm (%test-docker-system): Simplify by using only the
> guix-daemon service to prevent test hangs.

Hi! It=E2=80=99s not clear to me why =E2=80=98herd status=E2=80=99 was bloc=
king in the first
place=E2=80=94it=E2=80=99s never supposed to happen.  Do you have ideas?

Thanks,
Ludo=E2=80=99.




Information forwarded to guix-patches@HIDDEN:
bug#77578; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 6 Apr 2025 15:08:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 06 11:08:03 2025
Received: from localhost ([127.0.0.1]:49130 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u1RbO-00013J-Kg
	for submit <at> debbugs.gnu.org; Sun, 06 Apr 2025 11:08:02 -0400
Received: from lists.gnu.org ([2001:470:142::17]:48378)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <go.wigust@HIDDEN>)
 id 1u1RbM-00011w-M5
 for submit <at> debbugs.gnu.org; Sun, 06 Apr 2025 11:08:01 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <go.wigust@HIDDEN>)
 id 1u1Rb9-0005do-8L
 for guix-patches@HIDDEN; Sun, 06 Apr 2025 11:07:49 -0400
Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <go.wigust@HIDDEN>)
 id 1u1Rb7-0006Kt-Fj
 for guix-patches@HIDDEN; Sun, 06 Apr 2025 11:07:47 -0400
Received: by mail-lf1-x129.google.com with SMTP id
 2adb3069b0e04-54acc04516cso4088779e87.1
 for <guix-patches@HIDDEN>; Sun, 06 Apr 2025 08:07:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1743952061; x=1744556861; darn=gnu.org;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=flIzcGguFCw3SdS3hCq9oCBomWOQvxcYtW7r3ovcms8=;
 b=ZlrNStuKNglJnHndZjctzmPeHOMzBdYMBgOD2rDTygRq1K820TJRaTvr4lwu6QgrqZ
 gQun/TX8KLor4K3srusIdp4i/NxFb/ZOrZCpZEWhfhE//YZI8JSJGgeVNP4RyMiTZpqZ
 2V9iHleSjgQZyVIFlDki8TXSUD012eTmvWKIdOYT3ttVpXb6ZRPzmlJTDGQh392rKI48
 uPMfGvYU2Ju0hmY4Xvh7azu5jWO+DgdhNyJ0AKoS3uxITP32Ssk/xkc9Hg8bnMFDVdfd
 DoYsmWt1ByuASKfgnsTyq/H+fevvGjSB9BNO2uZuW2XVGFcWvvfr1Fl35dJTiAKtNIi9
 CYNA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1743952061; x=1744556861;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=flIzcGguFCw3SdS3hCq9oCBomWOQvxcYtW7r3ovcms8=;
 b=asJLKJdAjJ7jMh8+RlrcTSfEzqr69dzwD+gx9oXiCZU4IgZf3nyaHpTWS4QZ8Ro7gI
 cZ5pSpFJMXnzKiKkKdcP3WSFrJTuCnBBL0POO0g5hAx3y8upYiB+ZdaYpU6i7Pug73IS
 2xmIYUPQWUEDQlpxoAWCjwgCBsoGwhkIL6N3f9EbeWb62oXOaf7Nbc11ZJNyk5pR/iuH
 cfLxqgqELQt8R+YmLz4MYRoQTScRbm+MsAlwap2IL/wDhR6nL/EFJda8gHXoLEDy4xzL
 kEkAhqA3v4EOVjWCi40QFvof6XQiFbDuzeI0pHX9r77DMjBGLJ5QbZIH6PLAVgJqE+oj
 YINg==
X-Gm-Message-State: AOJu0Yzvb99r40cNNI2sVXI/dXsrxab6/AAHnhCE0OfAnj9DRg5j3sXh
 koTiQVbz+v3vjp3lOsRTyLlSn2LWGH2uFZHnEvIt9yC6zwU7qJvX4RvYeKMu
X-Gm-Gg: ASbGnct5jrbdlpb1fDGQq9QHITy+O8s4XzCj27fSMTjxmtxGBMWEqd4OQmtsNWmngr0
 cvMAGgSwwSXHvs8tiuIJQA3PWVH+RbreMZTErC/pWgSDBH5PDRe67rWwAXlkds/FHOSG2Lm++6u
 s420YWf3TnESGTyvX1qfhl0rV7k3JvGLTxnr19TpBBKqgoeE0ym89EWxCMqJCyblOw8Wrzw0mIU
 iQqn1JMwBGel88qumhYwC0dDpYVEuh/KQeIPnt6o7uvVTbHdyYZ7Qu0/sTPen52eelBbzp9DuIc
 rnVTCt1WkngXokvvDs+Qv3+3aUqIpNK9E0atvzfmUzSg52r9BA6CN/I=
X-Google-Smtp-Source: AGHT+IEeavBKMq9W5T+6ov38fd1HRTqGGuyLQai06AYR8zIlqpAuEMrTDE4NhVmZvsKLOKzx7yOQyA==
X-Received: by 2002:a05:6512:3e1d:b0:549:b179:e905 with SMTP id
 2adb3069b0e04-54c297b8043mr1330801e87.9.1743952061120; 
 Sun, 06 Apr 2025 08:07:41 -0700 (PDT)
Received: from localhost.localdomain ([93.100.15.190])
 by smtp.gmail.com with ESMTPSA id
 2adb3069b0e04-54c1e65d785sm991969e87.198.2025.04.06.08.07.40
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 06 Apr 2025 08:07:40 -0700 (PDT)
From: Oleg Pykhalov <go.wigust@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] tests: docker-system: Use only guix-daemon service.
Date: Sun,  6 Apr 2025 18:07:01 +0300
Message-ID: <20250406150701.10549-1-go.wigust@HIDDEN>
X-Mailer: git-send-email 2.47.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::129;
 envelope-from=go.wigust@HIDDEN; helo=mail-lf1-x129.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: Oleg Pykhalov <go.wigust@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

The test run-docker-system-test was hanging on:

(docker-cli "exec" container
             "/run/current-system/profile/bin/herd"
             "status")

This occurred because %test-docker-system specified more services than
gnu/system/examples/docker-image.tmpl, which may have caused conflicts or
unexpected behavior.

* gnu/tests/docker.scm (%test-docker-system): Simplify by using only the
guix-daemon service to prevent test hangs.

Change-Id: I2c3f7bc54fa6b5a802c8e16cba6ffae0cd09d4cc
---
 gnu/tests/docker.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/tests/docker.scm b/gnu/tests/docker.scm
index 90c8d0f850..e528064c2b 100644
--- a/gnu/tests/docker.scm
+++ b/gnu/tests/docker.scm
@@ -26,6 +26,7 @@ (define-module (gnu tests docker)
   #:use-module (gnu system image)
   #:use-module (gnu system vm)
   #:use-module (gnu services)
+  #:use-module (gnu services base)
   #:use-module (gnu services dbus)
   #:use-module (gnu services networking)
   #:use-module (gnu services docker)
@@ -345,7 +346,9 @@ (define %test-docker-system
                                    (inherit (simple-operating-system))
                                    ;; Use locales for a single libc to
                                    ;; reduce space requirements.
-                                   (locale-libcs (list glibc)))
+                                   (locale-libcs (list glibc))
+                                   ;; Guix is all you need!
+                                   (services (list (service guix-service-type))))
                                  #:type docker-image-type)))
                  run-docker-system-test)))))
 
-- 
2.47.1





Acknowledgement sent to Oleg Pykhalov <go.wigust@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#77578; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 6 Jun 2025 20:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.