GNU bug report logs - #77582
[PATCH] services: Make the urandom-seed-service-type return success.

Previous Next

Package: guix-patches;

Reported by: Leo Famulari <leo <at> famulari.name>

Date: Sun, 6 Apr 2025 17:43:02 UTC

Severity: normal

Tags: patch

Done: Leo Famulari <leo <at> famulari.name>

To reply to this bug, email your comments to 77582 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#77582; Package guix-patches. (Sun, 06 Apr 2025 17:43:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Leo Famulari <leo <at> famulari.name>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 06 Apr 2025 17:43:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: Make the urandom-seed-service-type return success.
Date: Sun,  6 Apr 2025 13:41:38 -0400

Reported by nigko on #guix:

https://logs.guix.gnu.org/guix/2025-04-05.log#201718

* gnu/services/base.scm (urandom-seed-shepherd-service): Return #f when
stopped.

Change-Id: I8212508e4a017270e4e9284b43170cd17999e8b4
---
 gnu/services/base.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 9a9dfdb3045..411a2247622 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -673,7 +673,8 @@ (define (urandom-seed-shepherd-service _)
                              (lambda (seed)
                                (put-bytevector seed buf)))
                            (umask previous-umask))
-                         #t)))))
+                         )))
+                   #f))
          (modules `((rnrs bytevectors)
                     (rnrs io ports)
                     ,@%default-modules)))))

base-commit: ada14197fb465c1c90efbc450308c14f077ff167
-- 
2.48.1
Information forwarded to guix-patches <at> gnu.org:
bug#77582; Package guix-patches. (Tue, 08 Apr 2025 15:30:03 GMT) Full text and rfc822 format available.

Message #8 received at 77582 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 77582 <at> debbugs.gnu.org
Subject: Re: [bug#77582] [PATCH] services: Make the
 urandom-seed-service-type return success.
Date: Tue, 08 Apr 2025 17:07:45 +0200

Leo Famulari <leo <at> famulari.name> skribis:

> Reported by nigko on #guix:
>
> https://logs.guix.gnu.org/guix/2025-04-05.log#201718
>
> * gnu/services/base.scm (urandom-seed-shepherd-service): Return #f when
> stopped.
>
> Change-Id: I8212508e4a017270e4e9284b43170cd17999e8b4

LGTM!
Reply sent to Leo Famulari <leo <at> famulari.name>:
You have taken responsibility. (Wed, 09 Apr 2025 00:26:02 GMT) Full text and rfc822 format available.
Notification sent to Leo Famulari <leo <at> famulari.name>:
bug acknowledged by developer. (Wed, 09 Apr 2025 00:26:02 GMT) Full text and rfc822 format available.

Message #13 received at 77582-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 77582-done <at> debbugs.gnu.org
Subject: Re: [bug#77582] [PATCH] services: Make the urandom-seed-service-type
 return success.
Date: Tue, 8 Apr 2025 20:25:49 -0400

On Tue, Apr 08, 2025 at 05:07:45PM +0200, Ludovic Courtès wrote:
> LGTM!
 
Thanks for taking a look! Pushed as
bb4ce5cc4701ddaa08f4b3d9528a4a665c22b4bc
This bug report was last modified 20 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.