GNU bug report logs - #77611
[PATCH] gnu: Remove duplicated package show-me-the-key.

Previous Next

Package: guix-patches;

Reported by: Morgan Smith <Morgan.J.Smith <at> outlook.com>

Date: Mon, 7 Apr 2025 17:24:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

To reply to this bug, email your comments to 77611 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#77611; Package guix-patches. (Mon, 07 Apr 2025 17:24:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Morgan Smith <Morgan.J.Smith <at> outlook.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 07 Apr 2025 17:24:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
To: guix-patches <at> gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH] gnu: Remove duplicated package show-me-the-key.
Date: Mon,  7 Apr 2025 13:17:53 -0400
This package is a duplicate of "showmethekey".  Upstream seems to prefer
naming the package without hyphens in the name.

* gnu/packages/xdisorg.scm (show-me-the-key): Delete variable.

Change-Id: I21daae0826b6fbc5adf6d10a8497099875ae09f1
---
 gnu/packages/xdisorg.scm | 31 -------------------------------
 1 file changed, 31 deletions(-)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index 302c0434ca..6dbfacc895 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -4169,37 +4169,6 @@ (define-public xforms-gl
     (synopsis
      "GUI toolkit for X based on the X11 Xlib library, with OpenGL support")))
 
-(define-public show-me-the-key
-  (package
-    (name "show-me-the-key")
-    (version "1.8.0")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/AlynxZhou/showmethekey/")
-                    (commit (string-append "v" version))))
-              (file-name (git-file-name name version))
-              (sha256 (base32
-                       "1gvrri6kfywxk8hfchc66r6fpwlrcai2j227ib33w6503cx66rl9"))))
-    (build-system meson-build-system)
-    (inputs (list libevdev
-                  libinput
-                  gtk
-                  json-glib-minimal
-                  cairo
-                  pango
-                  libxkbcommon
-                  polkit))
-    (native-inputs (list `(,glib "bin") ; for glib-compile-resources
-                         `(,gtk  "bin") ; for gtk-update-icon-cache
-                         pkg-config))
-    (home-page "https://github.com/AlynxZhou/showmethekey")
-    (synopsis "Screencast tool to display pressed keys")
-    (description "Show Me the Key is a screencast tool to display your keys
-and works under both Xorg and Wayland (via @code{libinput}), inspired by
-@code{python-screenkey}.")
-    (license license:asl2.0)))
-
 (define-public xxkb
   (package
     (name "xxkb")
-- 
2.49.0





Information forwarded to guix-patches <at> gnu.org:
bug#77611; Package guix-patches. (Tue, 08 Apr 2025 15:32:02 GMT) Full text and rfc822 format available.

Message #8 received at 77611 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Cc: 77611 <at> debbugs.gnu.org
Subject: Re: [bug#77611] [PATCH] gnu: Remove duplicated package
 show-me-the-key.
Date: Tue, 08 Apr 2025 17:22:23 +0200
Hi,

Morgan Smith <Morgan.J.Smith <at> outlook.com> skribis:

> This package is a duplicate of "showmethekey".  Upstream seems to prefer
> naming the package without hyphens in the name.
>
> * gnu/packages/xdisorg.scm (show-me-the-key): Delete variable.
>
> Change-Id: I21daae0826b6fbc5adf6d10a8497099875ae09f1

Instead of simply removing it, can you use ‘deprecated-package’ so this
name becomes an alias for the other one?

(You need to do this in the file where ‘showmethekey’ is defined.)

TIA,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#77611; Package guix-patches. (Wed, 09 Apr 2025 15:55:02 GMT) Full text and rfc822 format available.

Message #11 received at 77611 <at> debbugs.gnu.org (full text, mbox):

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
To: 77611 <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>, ludo <at> gnu.org
Subject: [PATCH v2] gnu: Remove duplicated package show-me-the-key.
Date: Wed,  9 Apr 2025 11:53:19 -0400
This package is a duplicate of "showmethekey".  Upstream seems to prefer
naming the package without hyphens in the name.

* gnu/packages/xdisorg.scm (show-me-the-key): Delete variable.
* gnu/packages/video.scm (show-me-the-key): Add as a deprecated alias for
showmethekey.

Change-Id: I21daae0826b6fbc5adf6d10a8497099875ae09f1
---
 gnu/packages/video.scm   |  9 +++++++++
 gnu/packages/xdisorg.scm | 31 -------------------------------
 2 files changed, 9 insertions(+), 31 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 9f18f4dcc2..97be01258b 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -6941,3 +6941,12 @@ (define-public showmethekey
 Users in group ``wheel'' can skip password authentication.")
     (home-page "https://github.com/AlynxZhou/showmethekey")
     (license license:asl2.0)))
+
+(define-public show-me-the-key
+  (deprecated-package "show-me-the-key" showmethekey))
+
+;;;
+;;; Avoid adding new packages to the end of this file. To reduce the chances
+;;; of a merge conflict, place them above by existing packages with similar
+;;; functionality or similar names.
+;;;
diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index 302c0434ca..6dbfacc895 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -4169,37 +4169,6 @@ (define-public xforms-gl
     (synopsis
      "GUI toolkit for X based on the X11 Xlib library, with OpenGL support")))
 
-(define-public show-me-the-key
-  (package
-    (name "show-me-the-key")
-    (version "1.8.0")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/AlynxZhou/showmethekey/")
-                    (commit (string-append "v" version))))
-              (file-name (git-file-name name version))
-              (sha256 (base32
-                       "1gvrri6kfywxk8hfchc66r6fpwlrcai2j227ib33w6503cx66rl9"))))
-    (build-system meson-build-system)
-    (inputs (list libevdev
-                  libinput
-                  gtk
-                  json-glib-minimal
-                  cairo
-                  pango
-                  libxkbcommon
-                  polkit))
-    (native-inputs (list `(,glib "bin") ; for glib-compile-resources
-                         `(,gtk  "bin") ; for gtk-update-icon-cache
-                         pkg-config))
-    (home-page "https://github.com/AlynxZhou/showmethekey")
-    (synopsis "Screencast tool to display pressed keys")
-    (description "Show Me the Key is a screencast tool to display your keys
-and works under both Xorg and Wayland (via @code{libinput}), inspired by
-@code{python-screenkey}.")
-    (license license:asl2.0)))
-
 (define-public xxkb
   (package
     (name "xxkb")

base-commit: f0c0769189d11debf7b237a02695c44c9773d52a
-- 
2.49.0





Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Thu, 10 Apr 2025 20:35:03 GMT) Full text and rfc822 format available.

Notification sent to Morgan Smith <Morgan.J.Smith <at> outlook.com>:
bug acknowledged by developer. (Thu, 10 Apr 2025 20:35:03 GMT) Full text and rfc822 format available.

Message #16 received at 77611-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Cc: 77611-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Remove duplicated package show-me-the-key.
Date: Thu, 10 Apr 2025 21:03:35 +0200
Morgan Smith <Morgan.J.Smith <at> outlook.com> skribis:

> This package is a duplicate of "showmethekey".  Upstream seems to prefer
> naming the package without hyphens in the name.
>
> * gnu/packages/xdisorg.scm (show-me-the-key): Delete variable.
> * gnu/packages/video.scm (show-me-the-key): Add as a deprecated alias for
> showmethekey.
>
> Change-Id: I21daae0826b6fbc5adf6d10a8497099875ae09f1

Applied, thanks!




This bug report was last modified 2 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.