GNU logs - #77621, boring messages

Message sent to bug-coreutils@HIDDEN:

Subject: bug#77621: coreutils-9.6.53-14af8 on OpenBSD 7.6
Resent-From: Bruno Haible <bruno@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Mon, 07 Apr 2025 22:42:02 +0000
Resent-Message-ID: <handler.77621.B.174406569929149 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77621 <at> debbugs.gnu.org, P@HIDDEN
From: Bruno Haible <bruno@HIDDEN>
Date: Tue, 08 Apr 2025 00:41:18 +0200
Message-ID: <1818491.4herOUoSWf@nimes>
Organization: GNU
In-Reply-To: <b255fdb1-503e-4112-a0eb-2a63fd1806f8@HIDDEN>
References: <b255fdb1-503e-4112-a0eb-2a63fd1806f8@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="nextPart2597012.Y4W8hZkJsM"
Content-Transfer-Encoding: 7Bit
Received-SPF: none client-ip=81.169.146.219; envelope-from=bruno@HIDDEN;
 helo=mo4-p00-ob.smtp.rzone.de
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001,
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

This is a multi-part message in MIME format.

--nextPart2597012.Y4W8hZkJsM
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On OpenBSD 7.6 there is a test failure:

FAIL: tests/ls/selinux-segfault

Find attached the log file.

To reproduce the issue, just run

$ src/ls -Z .
Segmentation fault (core dumped)

It crashes at strlen(), due to a NULL argument,
invoked from gobble_file (name = ".", type = arg_directory, inode = 0,
command_line_arg = true, dirname = NULL) at ls.c:3642,
invoked from ls.c:1812.

This reminds me the commit
https://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=915004f403cb25fadb207ddfdbe6a2f43bd44fac
that was supposed to fix the bug reported in
https://lists.gnu.org/archive/html/coreutils/2025-01/msg00051.html

Apparently this bug has reappeared, at least on OpenBSD.

Bruno


--nextPart2597012.Y4W8hZkJsM
Content-Disposition: attachment; filename="openbsd76-test-suite.log"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-log; charset="x-UTF_8J"; name="openbsd76-test-suite.log"

========================================================
   GNU coreutils 9.6.53-14af8: ./tests/test-suite.log
========================================================

# TOTAL: 658
# PASS:  480
# SKIP:  177
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: tests/ls/selinux-segfault
===============================

++ initial_cwd_=/home/bruno/coreutils-9.6.53-14af8/build
+++ testdir_prefix_
+++ printf gt
++ pfx_=gt
+++ mktempd_ /home/bruno/coreutils-9.6.53-14af8/build gt-selinux-segfault.sh.XXXX
+++ case $# in
+++ destdir_=/home/bruno/coreutils-9.6.53-14af8/build
+++ template_=gt-selinux-segfault.sh.XXXX
+++ MAX_TRIES_=4
+++ case $destdir_ in
+++ destdir_slash_=/home/bruno/coreutils-9.6.53-14af8/build/
+++ case $template_ in
++++ unset TMPDIR
+++ d=/home/bruno/coreutils-9.6.53-14af8/build/gt-selinux-segfault.sh.yGIC
+++ case $d in
+++ :
+++ test -d /home/bruno/coreutils-9.6.53-14af8/build/gt-selinux-segfault.sh.yGIC
++++ ls -dgo /home/bruno/coreutils-9.6.53-14af8/build/gt-selinux-segfault.sh.yGIC
+++ perms='drwx------. 2 512 Apr  7 21:51 /home/bruno/coreutils-9.6.53-14af8/build/gt-selinux-segfault.sh.yGIC'
+++ case $perms in
+++ :
+++ echo /home/bruno/coreutils-9.6.53-14af8/build/gt-selinux-segfault.sh.yGIC
+++ return
++ test_dir_=/home/bruno/coreutils-9.6.53-14af8/build/gt-selinux-segfault.sh.yGIC
++ cd /home/bruno/coreutils-9.6.53-14af8/build/gt-selinux-segfault.sh.yGIC
++ case $srcdir in
++ srcdir=../..
++ builddir=..
++ export srcdir builddir
++ gl_init_sh_nl_='
'
++ IFS=' 	
'
++ for sig_ in 1 2 3 13 15
+++ expr 1 + 128
++ eval 'trap '\''Exit 129'\'' 1'
+++ trap 'Exit 129' 1
++ for sig_ in 1 2 3 13 15
+++ expr 2 + 128
++ eval 'trap '\''Exit 130'\'' 2'
+++ trap 'Exit 130' 2
++ for sig_ in 1 2 3 13 15
+++ expr 3 + 128
++ eval 'trap '\''Exit 131'\'' 3'
+++ trap 'Exit 131' 3
++ for sig_ in 1 2 3 13 15
+++ expr 13 + 128
++ eval 'trap '\''Exit 141'\'' 13'
+++ trap 'Exit 141' 13
++ for sig_ in 1 2 3 13 15
+++ expr 15 + 128
++ eval 'trap '\''Exit 143'\'' 15'
+++ trap 'Exit 143' 15
++ saved_IFS=' 	
'
++ IFS=:
++ new_PATH=
++ for dir in $PATH
++ IFS=' 	
'
++ case "$dir" in
++ test -d /home/bruno/coreutils-9.6.53-14af8/build/src/.
++ new_PATH=/home/bruno/coreutils-9.6.53-14af8/build/src
++ for dir in $PATH
++ IFS=' 	
'
++ case "$dir" in
++ test -d /home/bruno/bin/.
++ new_PATH=/home/bruno/coreutils-9.6.53-14af8/build/src:/home/bruno/bin
++ for dir in $PATH
++ IFS=' 	
'
++ case "$dir" in
++ test -d /bin/.
++ new_PATH=/home/bruno/coreutils-9.6.53-14af8/build/src:/home/bruno/bin:/bin
++ for dir in $PATH
++ IFS=' 	
'
++ case "$dir" in
++ test -d /sbin/.
++ new_PATH=/home/bruno/coreutils-9.6.53-14af8/build/src:/home/bruno/bin:/bin:/sbin
++ for dir in $PATH
++ IFS=' 	
'
++ case "$dir" in
++ test -d /usr/bin/.
++ new_PATH=/home/bruno/coreutils-9.6.53-14af8/build/src:/home/bruno/bin:/bin:/sbin:/usr/bin
++ for dir in $PATH
++ IFS=' 	
'
++ case "$dir" in
++ test -d /usr/sbin/.
++ new_PATH=/home/bruno/coreutils-9.6.53-14af8/build/src:/home/bruno/bin:/bin:/sbin:/usr/bin:/usr/sbin
++ for dir in $PATH
++ IFS=' 	
'
++ case "$dir" in
++ test -d /usr/local/bin/.
++ new_PATH=/home/bruno/coreutils-9.6.53-14af8/build/src:/home/bruno/bin:/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin
++ for dir in $PATH
++ IFS=' 	
'
++ case "$dir" in
++ test -d /usr/local/sbin/.
++ new_PATH=/home/bruno/coreutils-9.6.53-14af8/build/src:/home/bruno/bin:/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin
++ IFS=' 	
'
++ PATH=/home/bruno/coreutils-9.6.53-14af8/build/src:/home/bruno/bin:/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin
++ export PATH
++ trap remove_tmp_ EXIT
+ path_prepend_ ./src
+ test 1 '!=' 0
+ path_dir_=./src
+ case $path_dir_ in
+ abs_path_dir_=/home/bruno/coreutils-9.6.53-14af8/build/./src
+ case $abs_path_dir_ in
+ PATH=/home/bruno/coreutils-9.6.53-14af8/build/./src:/home/bruno/coreutils-9.6.53-14af8/build/src:/home/bruno/bin:/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin
+ create_exe_shims_ /home/bruno/coreutils-9.6.53-14af8/build/./src
+ case $EXEEXT in
+ return 0
+ shift
+ test 0 '!=' 0
+ export PATH
+ print_ver_ ls
+ require_built_ ls
+ skip_=no
+ for i in "$@"
+ case " $built_programs " in
+ test no = yes
+ test yes = yes
+ local i
+ for i in $*
+ env ls --version
ls (GNU coreutils) 9.6.53-14af8
Copyright (C) 2025 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Richard M. Stallman and David MacKenzie.
+ f=/proc/sys
+ test -r /proc/sys
+ f=.
+ ls -l .
+ mkdir sedir
+ ln -sf missing sedir/broken
+ returns_ 1 ls -L -R -Z -m sedir
../tests/init.sh: line 612: 79448 Segmentation fault      (core dumped) "$@"
+ fail=1
+ ls -Z .
../tests/ls/selinux-segfault.sh: line 34: 95717 Segmentation fault      (core dumped) ls -Z . > out
+ fail=1
+ Exit 1
+ set +e
+ exit 1
+ exit 1
+ remove_tmp_
+ __st=1
+ cleanup_
+ :
+ test '' = yes
+ cd /home/bruno/coreutils-9.6.53-14af8/build
+ chmod -R u+rwx /home/bruno/coreutils-9.6.53-14af8/build/gt-selinux-segfault.sh.yGIC
+ rm -rf /home/bruno/coreutils-9.6.53-14af8/build/gt-selinux-segfault.sh.yGIC
+ exit 1
FAIL tests/ls/selinux-segfault.sh (exit status: 1)


--nextPart2597012.Y4W8hZkJsM--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Bruno Haible <bruno@HIDDEN>
Subject: bug#77621: Acknowledgement (coreutils-9.6.53-14af8 on OpenBSD 7.6)
Message-ID: <handler.77621.B.174406569929149.ack <at> debbugs.gnu.org>
References: <1818491.4herOUoSWf@nimes>
X-Gnu-PR-Message: ack 77621
X-Gnu-PR-Package: coreutils
Reply-To: 77621 <at> debbugs.gnu.org
Date: Mon, 07 Apr 2025 22:42:03 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-coreutils@HIDDEN

If you wish to submit further information on this problem, please
send it to 77621 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
77621: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77621
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-coreutils@HIDDEN:

Subject: bug#77621: coreutils-9.6.53-14af8 on OpenBSD 7.6
Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady <P@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Mon, 07 Apr 2025 23:07:01 +0000
Resent-Message-ID: <handler.77621.B77621.174406720615608 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Bruno Haible <bruno@HIDDEN>, 77621 <at> debbugs.gnu.org
Message-ID: <8c8425c3-7c21-4a39-ab79-544ec00c2c10@HIDDEN>
Date: Tue, 8 Apr 2025 00:06:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
References: <b255fdb1-503e-4112-a0eb-2a63fd1806f8@HIDDEN>
 <1818491.4herOUoSWf@nimes>
Content-Language: en-US
From: =?UTF-8?Q?P=C3=A1draig?= Brady <P@HIDDEN>
In-Reply-To: <1818491.4herOUoSWf@nimes>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 07/04/2025 23:41, Bruno Haible via GNU coreutils Bug Reports wrote:
> On OpenBSD 7.6 there is a test failure:
> 
> FAIL: tests/ls/selinux-segfault
> 
> Find attached the log file.
> 
> To reproduce the issue, just run
> 
> $ src/ls -Z .
> Segmentation fault (core dumped)
> 
> It crashes at strlen(), due to a NULL argument,
> invoked from gobble_file (name = ".", type = arg_directory, inode = 0,
> command_line_arg = true, dirname = NULL) at ls.c:3642,
> invoked from ls.c:1812.
> 
> This reminds me the commit
> https://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=915004f403cb25fadb207ddfdbe6a2f43bd44fac
> that was supposed to fix the bug reported in
> https://lists.gnu.org/archive/html/coreutils/2025-01/msg00051.html
> 
> Apparently this bug has reappeared, at least on OpenBSD.

I have access to cfarm220.cfarm.net,
so I'll look at this tomorrow.

thanks for testing!

Pádraig

Message sent to bug-coreutils@HIDDEN:

Subject: bug#77621: coreutils-9.6.53-14af8 on OpenBSD 7.6
Resent-From: Paul Eggert <eggert@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Tue, 08 Apr 2025 07:43:01 +0000
Resent-Message-ID: <handler.77621.B77621.17440981244762 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: =?UTF-8?Q?P=C3=A1draig?= Brady <P@HIDDEN>
Cc: 77621 <at> debbugs.gnu.org, Bruno Haible <bruno@HIDDEN>
Message-ID: <452f0c70-d26b-4d15-bef2-062abd4371be@HIDDEN>
Date: Tue, 8 Apr 2025 00:41:51 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
References: <b255fdb1-503e-4112-a0eb-2a63fd1806f8@HIDDEN>
 <1818491.4herOUoSWf@nimes>
 <8c8425c3-7c21-4a39-ab79-544ec00c2c10@HIDDEN>
Content-Language: en-US
From: Paul Eggert <eggert@HIDDEN>
Organization: UCLA Computer Science Department
In-Reply-To: <8c8425c3-7c21-4a39-ab79-544ec00c2c10@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 2025-04-07 16:06, P=C3=A1draig Brady wrote:
> I have access to cfarm220.cfarm.net,
> so I'll look at this tomorrow.

I don't see the problem on cfarm220.cfarm.net with the current coreutils=20
commit (42f6201aa554fde4c78a3c5d0207d85392eb742e), using "./configure &&=20
make -j5 check" . The command "src/ls -Z" does not dump core: it outputs=20
a bunch of file names with "?" before them. "make check" outputs a line:

PASS: tests/ls/selinux-segfault.sh

That is, it does not output a line "FAIL: tests/ls/selinux-segfault", as=20
Bruno reported.

All tests pass, including gnulib tests.

You can temporarily see my build on that machine in the directory=20
~eggert/coreutils-9.6.59-42f62.

Maybe the bug has been fixed since coreutils-9.6.53-14af8?

Message sent to bug-coreutils@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#77621: coreutils-9.6.53-14af8 on OpenBSD 7.6
Resent-From: Bruno Haible <bruno@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Tue, 08 Apr 2025 10:23:02 +0000
Resent-Message-ID: <handler.77621.B77621.174410774220629 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77621
X-GNU-PR-Package: coreutils
X-GNU-PR-Keywords: 
To: =?UTF-8?Q?P=C3=A1draig?= Brady <P@HIDDEN>, Paul Eggert <eggert@HIDDEN>
Cc: 77621 <at> debbugs.gnu.org
Received: via spool by 77621-submit <at> debbugs.gnu.org id=B77621.174410774220629
          (code B ref 77621); Tue, 08 Apr 2025 10:23:02 +0000
Received: (at 77621) by debbugs.gnu.org; 8 Apr 2025 10:22:22 +0000
Received: from localhost ([127.0.0.1]:59214 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u2661-0005Mc-F5
	for submit <at> debbugs.gnu.org; Tue, 08 Apr 2025 06:22:21 -0400
Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.221]:32935)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <bruno@HIDDEN>) id 1u265y-0005ML-Ue
 for 77621 <at> debbugs.gnu.org; Tue, 08 Apr 2025 06:22:20 -0400
ARC-Seal: i=1; a=rsa-sha256; t=1744107736; cv=none;
 d=strato.com; s=strato-dkim-0002;
 b=mkuxdTt2j1gYcApOyWcYKNyyrT1rB8fUqHNXGMppLCPC0tdXCKtxfUTYRJW8TzJypu
 m9EaPPSzs4Qt/xAvV6DtB8ZO8S6eKMU0tcUVj3iAqZJtrbu8qdaNq20J22xxVnb9BOvp
 7VwRjoYPzd//wNLxT/26VmpJBsBZVVsKDCLNqFKUbfssHmvry19GR11yIDavM1NazplW
 Xy8NpTxlDsrR5Zlebxklf9ckcotFtEULyhXx9hj3ukKG0Dtbn551WgBVyxidqEYf+nB+
 lJ35by6DxleE+uKSPzH3vJnQgeWQrQu+50YsmORRDidsKOTV3u8d4absRt2czRuOiyC/
 6JOA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1744107736;
 s=strato-dkim-0002; d=strato.com;
 h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:
 From:Subject:Sender;
 bh=1EiK7qa2SdXcSi4+/0CRhGoz4b2iwISXKFZIOyAHmyw=;
 b=syj/cQ8eyPgRetk5TUTjwzj/nbI2YeBelIFcv5elphsTRdohDtTatb0CTf1JjgBdzy
 KgsHNM/Vel2bZbcyaIb6WdhdJsX9dWDkG4EEFu9Ou4P1DquGDrjUHCUQJIk02hwwMaWh
 gN2xmf9vv12uzFSh1UG2elPDvR/G29oPJj/tU9pwW+l3ZutEYSbxrVyZaEfNT0nuaJsk
 CWqS64zaCfAW4HwLawB6gJM6vS1xehLkdAF2Bd5Uvs9H0MIes/yhyKeoQ0c0pyvDpcqn
 vscMA8IKo1c0i+HuwY/PgcoViQxJ1YdmyCbuNOgt2BqigNvAET5qCOENMFARupqk1/dX
 rMgA==
ARC-Authentication-Results: i=1; strato.com;
    arc=none;
    dkim=none
X-RZG-CLASS-ID: mo00
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1744107736;
 s=strato-dkim-0002; d=clisp.org;
 h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:
 From:Subject:Sender;
 bh=1EiK7qa2SdXcSi4+/0CRhGoz4b2iwISXKFZIOyAHmyw=;
 b=thjm7uDubcoZIg0o+48bYRFx3LTGegOfYFenibaeUfg1GA9VNoDqlBzCtIKKuPa9rb
 L2qV3VFRphP+gCXCRAd/BIB34CCYXqW10CzVk/hjc4u/aCPvtG7zlPVC8xBFkThNoypt
 eS1WdtZsFOIQSmzP6bu3pNDYyA1LQp/qGwbJvJi8kOsd3LbbZORyAi9D/wPP4ecfY7uN
 Q/JHCERgvcPaMX3vg1LxYaLfk7mkVxqTl5BU8MaDenQt7PMbcOmpbwYBU/84/qgZtSyN
 nuJHqyl6X+J6RmVyXHrf7/JaPqMOl9Lr71+bn29ZAwOSVyeZxsr2VKMCUYX0mvOXrRQi
 aqfA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1744107736;
 s=strato-dkim-0003; d=clisp.org;
 h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:
 From:Subject:Sender;
 bh=1EiK7qa2SdXcSi4+/0CRhGoz4b2iwISXKFZIOyAHmyw=;
 b=ypbrcR1QC1dOclSeC8tizvJTIeDU8zArpISbKPbFVD08/vydaxAYjxy7ENznSQ7pWP
 LhFGwrG8OZirW08WdKCg==
X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlLnY4jECd2hdUURIbZgL8PX2QiTuZ3cdB8X/nqmmcFTvhkvcyS6W4Yb9/mO9QBnQI"
Received: from nimes.localnet by smtp.strato.de (RZmta 51.3.0 AUTH)
 with ESMTPSA id N7dcf8138AMFRCL
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))
 (Client did not present a certificate);
 Tue, 8 Apr 2025 12:22:15 +0200 (CEST)
From: Bruno Haible <bruno@HIDDEN>
Date: Tue, 08 Apr 2025 12:22:15 +0200
Message-ID: <3740239.bqPgKRP4r2@nimes>
Organization: GNU
In-Reply-To: <452f0c70-d26b-4d15-bef2-062abd4371be@HIDDEN>
References: <b255fdb1-503e-4112-a0eb-2a63fd1806f8@HIDDEN>
 <8c8425c3-7c21-4a39-ab79-544ec00c2c10@HIDDEN>
 <452f0c70-d26b-4d15-bef2-062abd4371be@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="nextPart1812898.A0I09U8b9p"
Content-Transfer-Encoding: 7Bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

This is a multi-part message in MIME format.

--nextPart1812898.A0I09U8b9p
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

Paul Eggert wrote:
> I don't see the problem on cfarm220.cfarm.net with the current coreutils

That's because you are not on the /dev/wd0a disk on that machine.

What I see by single-stepping through "ls -Z ." in gdb is:
1. f->scontext gets set to "?".
2. Upon the first entry to function file_has_aclinfo_cache,
   all 4 variables
     static int unsupported_return;
     static char *unsupported_scontext;
     static int unsupported_scontext_err;
     static dev_t unsupported_device;
   are 0 or NULL, respectively. (As expected, since it's the first call
   to this function.)
   f->stat.st_dev is 0 (since "." is on the /dev/wd0a disk and this device
   has major and minor number both 0).
   Thus the condition (f->stat_ok && f->stat.st_dev == unsupported_device)
   evaluates to true, and four lines later, in
     ai->scontext = unsupported_scontext;
   an scontext gets set to NULL.

The fix is obviously to ignore these 4 static variables if they have not
been initialized. Done through the attached patch, which fixes the crash.


--nextPart1812898.A0I09U8b9p
Content-Disposition: attachment;
 filename="0001-ls-Fix-crash-of-ls-Z-.-on-OpenBSD-s-dev-wd0a-disk.patch"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="x-UTF_8J";
 name="0001-ls-Fix-crash-of-ls-Z-.-on-OpenBSD-s-dev-wd0a-disk.patch"

From 6cab0a182e3034b4533bcfe73fef74af37cc723d Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@HIDDEN>
Date: Tue, 8 Apr 2025 12:14:29 +0200
Subject: [PATCH] ls: Fix crash of "ls -Z ." on OpenBSD's /dev/wd0a disk

* src/ls.c (file_has_aclinfo_cache): Add new static variable
'unsupported_cached'. Don't assume that device 0 never occurs.
---
 src/ls.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/ls.c b/src/ls.c
index 6690f7747..de5a1ae2b 100644
--- a/src/ls.c
+++ b/src/ls.c
@@ -3309,12 +3309,13 @@ file_has_aclinfo_cache (char const *file, struct fileinfo *f,
 {
   /* st_dev and associated info for the most recently processed device
      for which file_has_aclinfo failed indicating lack of support.  */
+  static bool unsupported_cached /* = false */;
   static int unsupported_return;
   static char *unsupported_scontext;
   static int unsupported_scontext_err;
   static dev_t unsupported_device;
 
-  if (f->stat_ok && f->stat.st_dev == unsupported_device)
+  if (f->stat_ok && unsupported_cached && f->stat.st_dev == unsupported_device)
     {
       ai->buf = ai->u.__gl_acl_ch;
       ai->size = 0;
@@ -3330,6 +3331,7 @@ file_has_aclinfo_cache (char const *file, struct fileinfo *f,
   if (f->stat_ok && n <= 0 && !acl_errno_valid (err)
       && (!(flags & ACL_GET_SCONTEXT) || !acl_errno_valid (ai->scontext_err)))
     {
+      unsupported_cached = true;
       unsupported_return = n;
       unsupported_scontext = ai->scontext;
       unsupported_scontext_err = ai->scontext_err;
-- 
2.43.0


--nextPart1812898.A0I09U8b9p--

Last modified: Tue, 8 Apr 2025 10:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.