GNU bug report logs - #77643
[PATCH] gnu: nano: Fix cross-compiling.

Previous Next

To reply to this bug, email your comments to 77643 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: guix-patches <at> gnu.org,
	andreas <at> enge.fr,
	z572 <at> z572.online
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH] gnu: nano: Fix cross-compiling.
Date: Tue,  8 Apr 2025 06:39:29 -0700

* gnu/packages/text-editors.scm (nano)[arguments]<#:configure-flags>: When
cross-compiling, add "ac_cv_func_strcasecmp=yes"
"gl_cv_func_strcasecmp_works=yes".

Change-Id: Ie024ebdba51efe01ab41872f85479525851e3e3a
---
 gnu/packages/text-editors.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index 08af5e33a32..99216e61786 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -1002,6 +1002,11 @@ (define-public nano
       (sha256
        (base32 "13b2iqmbx5vcyd0rnvvc9l8l79q6665r4xx6gvc28mnmpci95ljs"))))
     (build-system gnu-build-system)
+    (arguments
+     `(,@(if (%current-target-system)
+        ; fix for crosscompiling; on GNU system strcasecmp always works
+       `(#:configure-flags (list "ac_cv_func_strcasecmp=yes" "gl_cv_func_strcasecmp_works=yes"))
+       '())))
     (inputs
      (list gettext-minimal ncurses))
     (home-page "https://www.nano-editor.org/")

base-commit: 1dab24555a494beb3db5a335c675f07043e77f1c
-- 
2.43.0

Message #8 received at 77643 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Z572 <z572 <at> z572.online>
Cc: 77643 <at> debbugs.gnu.org, Andreas Enge <andreas <at> enge.fr>,
 77466-done <at> debbugs.gnu.org
Subject: Re: [bug#77466] [PATCH] gnu: nano: Update to 8.4.
Date: Tue, 8 Apr 2025 06:43:21 -0700

patch for fixing this as https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77643

On Tue, Apr 8, 2025 at 5:03 AM Z572 <z572 <at> z572.online> wrote:
>
> Andy Tai <atai <at> atai.org> writes:
>
> > OK, the nano maintainer did not put the source tar gz file at the
> > usual location at first. I did send him email. Maybe he add it later.
> >
> > On Mon, Apr 7, 2025 at 4:35 AM Andreas Enge <andreas <at> enge.fr> wrote:
> >>
> >> Hello Andy,
> >>
> >> your patch has passed QA. However, there is no reason to change the source
> >> location, even more so since it is a GNU package. So I have done a
> >>    ./pre-inst-env guix refresh -u nano
> >> on my end and pushed the resulting patch (this also verifies the gnupg
> >> signature, and shows the same hash as you give).
> >>
> >> Andreas
> >>
>
> Hi, after updating this version, the cross compilation fails. Can you
> take a look?

Message #13 received at 77643-done <at> debbugs.gnu.org (full text, mbox):

From: Z572 <z572 <at> z572.online>
To: Andy Tai <atai <at> atai.org>
Cc: 77643-done <at> debbugs.gnu.org, andreas <at> enge.fr
Subject: Re: [bug#77643] [PATCH] gnu: nano: Fix cross-compiling.
Date: Tue, 08 Apr 2025 22:37:54 +0800

[Message part 1 (text/plain, inline)]

Andy Tai <atai <at> atai.org> writes:

> * gnu/packages/text-editors.scm (nano)[arguments]<#:configure-flags>: When
> cross-compiling, add "ac_cv_func_strcasecmp=yes"
> "gl_cv_func_strcasecmp_works=yes".
>
> Change-Id: Ie024ebdba51efe01ab41872f85479525851e3e3a
> ---
>  gnu/packages/text-editors.scm | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
> index 08af5e33a32..99216e61786 100644
> --- a/gnu/packages/text-editors.scm
> +++ b/gnu/packages/text-editors.scm
> @@ -1002,6 +1002,11 @@ (define-public nano
>        (sha256
>         (base32 "13b2iqmbx5vcyd0rnvvc9l8l79q6665r4xx6gvc28mnmpci95ljs"))))
>      (build-system gnu-build-system)
> +    (arguments
> +     `(,@(if (%current-target-system)
> +        ; fix for crosscompiling; on GNU system strcasecmp always works
> +       `(#:configure-flags (list "ac_cv_func_strcasecmp=yes" "gl_cv_func_strcasecmp_works=yes"))
> +       '())))

adjust to use gexp.

>      (inputs
>       (list gettext-minimal ncurses))
>      (home-page "https://www.nano-editor.org/")
>
> base-commit: 1dab24555a494beb3db5a335c675f07043e77f1c
pushed, closing.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.