GNU bug report logs - #77682
[PATCH 0/2] Restore the Orca screen reader.

Previous Next

To reply to this bug, email your comments to 77682 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noelopez <at> free.fr>
To: guix-patches <at> gnu.org
Cc: Noé Lopez <noelopez <at> free.fr>
Subject: [PATCH 0/2] Restore the Orca screen reader.
Date: Wed,  9 Apr 2025 23:45:44 +0200

Hi,

As reported in <https://issues.guix.gnu.org/77669>, the GNOME Orca screen
reader is failing to find the liblouis library and the xkbcomp path leading to
missing functionality like the configuration window.

The xkbcomp path is simply because the fix was being applied to the wrong file
(caller moved), and the liblouis wasn’t using the full library path.

I think these patches are important to keep Guix accessible so a review would
be very appreciated.

Have a nice day,
Noé

Noé Lopez (2):
  gnu: liblouis: Fix library path for python extension.
  gnu: orca: Fix xkbcomp path.

 gnu/packages/gnome.scm    | 2 +-
 gnu/packages/language.scm | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)


base-commit: 224d7732c1544ae653c91732c6dbd3a12f160951
-- 
2.49.0

Message #8 received at 77682 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noelopez <at> free.fr>
To: 77682 <at> debbugs.gnu.org
Cc: Noé Lopez <noelopez <at> free.fr>
Subject: [PATCH 1/2] gnu: liblouis: Fix library path for python extension.
Date: Wed,  9 Apr 2025 23:49:42 +0200

This changes the extension to load the library from its absolute path instead
of just with its name, which wouldn’t work.

Fixes <https://issues.guix.gnu.org/77669>.

* gnu/packages/language.scm (liblouis): Add fix-python-lib-path phase.

Change-Id: Icdd476eed5a77ddb93c437ec4d92c79bf2db7bce
---
 gnu/packages/language.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/language.scm b/gnu/packages/language.scm
index a6011bfce2..13957e12a0 100644
--- a/gnu/packages/language.scm
+++ b/gnu/packages/language.scm
@@ -351,6 +351,12 @@ (define-public liblouis
       #:configure-flags #~(list "--disable-static" "--enable-ucs4")
       #:phases
       #~(modify-phases %standard-phases
+          (add-after 'unpack 'fix-python-lib-path
+            (lambda _
+              (with-directory-excursion "python"
+                (substitute* "louis/__init__.py.in"
+                  (("###LIBLOUIS_SONAME###")
+                   (string-append #$output "/lib/###LIBLOUIS_SONAME###"))))))
           (add-after 'install 'install-python-extension
             (lambda _
               (with-directory-excursion "python"
-- 
2.49.0

Message #11 received at 77682 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noelopez <at> free.fr>
To: 77682 <at> debbugs.gnu.org
Cc: Noé Lopez <noelopez <at> free.fr>
Subject: [PATCH 2/2] gnu: orca: Fix xkbcomp path.
Date: Wed,  9 Apr 2025 23:49:43 +0200

The calling code was moved to a different file where substitute* was not
changing it.

* gnu/packages/gnome.scm (orca): Change file for xkbcomp substitution.

Change-Id: I92751b0fd639042007e956b234b9f248845a3970
---
 gnu/packages/gnome.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 59c923d433..6251b1aa2c 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -11672,7 +11672,7 @@ (define-public orca
                              (assoc-ref inputs "xkbcomp") "/bin/xkbcomp"))
                    (pgrep (string-append
                            (assoc-ref inputs "procps") "/bin/pgrep")))
-               (substitute* "src/orca/orca.py"
+               (substitute* "src/orca/orca_modifier_manager.py"
                  (("'xkbcomp'") (format #f "'~a'" xkbcomp)))
                (substitute* "src/orca/debug.py"
                  (("'pgrep %s'")
-- 
2.49.0

Message #16 received at 77682-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Noé Lopez <noelopez <at> free.fr>, 
 77682-done <at> debbugs.gnu.org
Cc: vivien <at> planete-kraus.eu, rw-flurando <at> inventati.org,
 maxim.cournoyer <at> gmail.com
Subject: Re: [bug#77682] [PATCH 0/2] Restore the Orca screen reader.
Date: Sun, 13 Apr 2025 18:35:42 +0200

Am Mittwoch, dem 09.04.2025 um 23:45 +0200 schrieb Noé Lopez:
> Hi,
> 
> As reported in <https://issues.guix.gnu.org/77669>, the GNOME Orca
> screen reader is failing to find the liblouis library and the xkbcomp
> path leading to missing functionality like the configuration window.
> 
> The xkbcomp path is simply because the fix was being applied to the
> wrong file (caller moved), and the liblouis wasn’t using the full
> library path.
> 
> I think these patches are important to keep Guix accessible so a
> review would be very appreciated.
> 
> Have a nice day,
> Noé
> 
> Noé Lopez (2):
>   gnu: liblouis: Fix library path for python extension.
>   gnu: orca: Fix xkbcomp path.
Pushed.

Thanks

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.