GNU bug report logs - #77694
[PATCH] gnu: emacs-emms: Activate tests and build info.

Previous Next

Package: guix-patches;

Reported by: Cayetano Santos <csantosb <at> inventati.org>

Date: Thu, 10 Apr 2025 09:27:02 UTC

Severity: normal

Tags: patch

Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

To reply to this bug, email your comments to 77694 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to andrew <at> trop.in, csantosb <at> inventati.org, divya <at> subvertising.org, hako <at> ultrarare.space, ian <at> retrospec.tv, cox.katherine.e+guix <at> gmail.com, liliana.prikler <at> gmail.com, guix-patches <at> gnu.org:
bug#77694; Package guix-patches. (Thu, 10 Apr 2025 09:27:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Cayetano Santos <csantosb <at> inventati.org>:
New bug report received and forwarded. Copy sent to andrew <at> trop.in, csantosb <at> inventati.org, divya <at> subvertising.org, hako <at> ultrarare.space, ian <at> retrospec.tv, cox.katherine.e+guix <at> gmail.com, liliana.prikler <at> gmail.com, guix-patches <at> gnu.org. (Thu, 10 Apr 2025 09:27:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH] gnu: emacs-emms: Activate tests and build info.
Date: Thu, 10 Apr 2025 11:25:22 +0200
* gnu/packages/emacs-xyz.scm (emacs-emms): Activate tests and build info.

Change-Id: I232dd25a30156374d5e12f73948b26b6b274cc54
---
 gnu/packages/emacs-xyz.scm | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 421b9b4cfa..c1e9951098 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -4160,8 +4160,23 @@ (define-public emacs-emms
     (name "emacs-emms")
     (build-system emacs-build-system)
     (arguments
-     `(#:phases
+     `(#:tests? #t
+       #:test-command
+       (list "emacs" "-Q" "--batch"
+             "--eval=(cd \"test/\")"
+             "-l" "emms-tests.el"
+             "-l" "emms-info-native-tests.el"
+             "-l" "emms-info-native-ogg-tests.el"
+             "-l" "emms-info-native-mp3-tests.el"
+             "-l" "emms-info-native-flac-tests.el"
+             "-l" "emms-info-native-vorbis-tests.el"
+             "-f" "ert-run-tests-batch-and-exit")
+       #:phases
        (modify-phases %standard-phases
+         (add-before 'install 'make-info
+           (lambda _
+             (invoke "make" "-C" "doc" "all")
+             (rename-file "doc/emms.info" "emms.info")))
          (add-after 'unpack 'set-external-programs
            ;; Specify the absolute file names of the various programs
            ;; so that everything works out-of-the-box. (tinytag missing)
@@ -4205,6 +4220,7 @@ (define-public emacs-emms
                   (string-append "\"" vorbiscomment "\"")))
                (substitute* "emms-info-exiftool.el"
                  (("\"exiftool\"") (string-append "\"" exiftool "\"")))))))))
+    (native-inputs (list texinfo))
     (inputs
      (list emacs-emms-print-metadata
            alsa-utils

base-commit: 2934de1447f87b361608ef3a2a756b8a5d2f42e6
-- 
2.49.0





Reply sent to Liliana Marie Prikler <liliana.prikler <at> gmail.com>:
You have taken responsibility. (Sun, 13 Apr 2025 16:30:05 GMT) Full text and rfc822 format available.

Notification sent to Cayetano Santos <csantosb <at> inventati.org>:
bug acknowledged by developer. (Sun, 13 Apr 2025 16:30:05 GMT) Full text and rfc822 format available.

Message #10 received at 77694-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>, 77694-done <at> debbugs.gnu.org, 
 77692-done <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Hilton Chain <hako <at> ultrarare.space>, Ian Eure <ian <at> retrospec.tv>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#77694] [PATCH] gnu: emacs-emms: Activate tests and build
 info.
Date: Sun, 13 Apr 2025 18:29:46 +0200
Am Donnerstag, dem 10.04.2025 um 11:25 +0200 schrieb Cayetano Santos:
> * gnu/packages/emacs-xyz.scm (emacs-emms): Activate tests and build
> info.
> 
> Change-Id: I232dd25a30156374d5e12f73948b26b6b274cc54
> ---
Pushed both this and 77692.

Cheers




This bug report was last modified 20 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.