GNU bug report logs - #77743
[PATCH] gnu: astronomy: Add sunwait 0.9.1.

Previous Next

To reply to this bug, email your comments to 77743 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Ziltener <dziltener <at> lyrion.ch>
To: guix-patches <at> gnu.org
Cc: Daniel Ziltener <dziltener <at> lyrion.ch>
Subject: [PATCH] gnu: astronomy: Add sunwait 0.9.1.
Date: Fri, 11 Apr 2025 16:24:45 +0200

---
 gnu/packages/astronomy.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index dfe1a7d6aa..ad43b40ebc 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -8313,6 +8313,38 @@ (define-public sunclock
 Moon position, etc.")
       (license license:gpl2+))))
 
+(define-public sunwait
+  (package
+    (name "sunwait")
+    (version "0.9.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url "https://github.com/risacher/sunwait")
+         (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0mzc8bb7zzl1ch3v7w08vw2v50yjxvr7phyb78njpq89wy6hsrxz"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:tests? #f
+      #:make-flags
+      #~(list (string-append "CC=" #$(cc-for-target)))
+      #:phases
+      #~(modify-phases %standard-phases
+          (delete 'configure)
+          (replace 'install
+            (lambda _
+              (install-file "sunwait"
+                            (string-append #$output "/bin")))))))
+    (home-page "https://github.com/risacher/sunwait")
+    (synopsis "Sunwait calculates sunrise or sunset times.")
+    (description "Sunwait calculates sunrise or sunset times with civil, nautical, astronomical and custom twilights.")
+    (license license:gpl3)))
+
 (define-public swarp
   (package
     (name "swarp")
-- 
2.49.0

Message #8 received at 77743 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Daniel Ziltener <dziltener <at> lyrion.ch>
Cc: 77743 <at> debbugs.gnu.org, Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: Re: [PATCH] gnu: astronomy: Add sunwait 0.9.1.
Date: Fri, 11 Apr 2025 17:57:12 +0200

Hello,

cc-ing our astronomy guru on a package submission that should interest him :)

Andreas

Message #11 received at 77743 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 77743 <at> debbugs.gnu.org
Cc: andreas <at> enge.fr, dziltener <at> lyrion.ch
Subject: [PATCH] gnu: astronomy: Add sunwait 0.9.1.
Date: Sat, 12 Apr 2025 09:22:05 +0100

[Message part 1 (text/plain, inline)]

Hi,

Thanks for tagging ^.^

I've skimmed the project on GitHub and looks like a small pet project of
the person working in "United States Department of Defense" :-). 

It's reasonably small to have a code review and maybe useful for astro
hobbyists.

Some notes on packaging:

Please add commit message (see any commit pushed to Guix for inspiration).

--8<---------------cut here---------------start------------->8---
+      #:tests? #f

+          (delete 'configure)
--8<---------------cut here---------------end--------------->8---
Please explain in comment string why we skip test and delete configure as
literal as "no tests provided", "no configure provided" etc.

--8<---------------cut here---------------start------------->8---
+    (synopsis "Sunwait calculates sunrise or sunset times.")
--8<---------------cut here---------------end--------------->8---
No full stop (dot) in synopsis (use "guix lint <package-name>" to pick
up such small issues)

License looks correct but it the latest release was in 2022, issue
tracker is alive and the author is responsive, which is a good sign.

Otherwise it's LGFM for me, let's check v2?

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.