GNU bug report logs - #77782
[PATCH 1/2] gnu: Remove mozjs-102.

Previous Next

To reply to this bug, email your comments to 77782 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: guix-patches <at> gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>
Subject: [PATCH 1/2] gnu: Remove mozjs-102.
Date: Sun, 13 Apr 2025 23:35:32 +0800

It fails to build and has no dependent packages.

* gnu/packages/gnuzilla.scm (mozjs-102): Delete variable.

Change-Id: I16f67810fddd338b5e55a61b57975a83426bdf54
---
 gnu/packages/gnuzilla.scm | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index f4a912d8d5..76d5ab1d29 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -256,22 +256,6 @@ (define-public mozjs
 in C/C++.")
     (license license:mpl2.0))) ; and others for some files
 
-(define-public mozjs-102
-  (package
-    (inherit mozjs)
-    (name "mozjs")
-    (version "102.2.0")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "https://ftp.mozilla.org/pub/firefox"
-                                  "/releases/" version "esr/source/firefox-"
-                                  version "esr.source.tar.xz"))
-              (sha256
-               (base32
-                "1zwpgis7py1bf8p88pz3mpai6a02qrdb8ww2fa9kxxdl9b8r2k81"))))
-    (inputs (modify-inputs (package-inputs mozjs)
-              (replace "icu4c" icu4c-71)))))
-
 (define-public mozjs-78
   (package
     (inherit mozjs)

base-commit: 94e7afbb557d3f2709072bf2bf58618293ca7fbd
-- 
2.49.0

Message #8 received at 77782 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: 77782 <at> debbugs.gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>
Subject: [PATCH 2/2] gnu: mozjs: Work around DST affected tests.
Date: Sun, 13 Apr 2025 23:38:54 +0800

* gnu/packages/gnuzilla.scm (mozjs)[arguments]<#:phases>: Use UTC for timezone
related tests.

Change-Id: I480c78d208ccecda8a5467461a0e5c7228262f9d
---
 gnu/packages/gnuzilla.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 76d5ab1d29..6bcff1c348 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -178,6 +178,10 @@ (define-public mozjs
                   ((".*killed process should not have exitStatus.*")
                    ""))
 
+                ;; FIXME: Affected by DST.
+                (substitute* "non262/Date/15.9.5.7.js"
+                  (("PST") "UTC"))
+
                 ;; This was fixed sometime between 102.15.1 and 115.11.0.
                 ;; These tests are supposed to be skipped on all 64-bit systems.
                 #$@(if (target-riscv64?)
-- 
2.49.0

Message #11 received at 77782 <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: André Batista <nandre <at> riseup.net>,
 Mark H Weaver <mhw <at> netris.org>, 77782 <at> debbugs.gnu.org,
 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>, Ian Eure <ian <at> retrospec.tv>
Subject: Re: [bug#77782] [PATCH 2/2] gnu: mozjs: Work around DST affected
 tests.
Date: Mon, 14 Apr 2025 00:12:45 +0200

On Sun, Apr 13 2025, Hilton Chain wrote:

> * gnu/packages/gnuzilla.scm (mozjs)[arguments]<#:phases>: Use UTC for timezone
> related tests.
>
> Change-Id: I480c78d208ccecda8a5467461a0e5c7228262f9d
> ---
>  gnu/packages/gnuzilla.scm | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
> index 76d5ab1d29..6bcff1c348 100644
> --- a/gnu/packages/gnuzilla.scm
> +++ b/gnu/packages/gnuzilla.scm
> @@ -178,6 +178,10 @@ (define-public mozjs
>                    ((".*killed process should not have exitStatus.*")
>                     ""))
>  
> +                ;; FIXME: Affected by DST.
> +                (substitute* "non262/Date/15.9.5.7.js"
> +                  (("PST") "UTC"))
> +
>                  ;; This was fixed sometime between 102.15.1 and 115.11.0.
>                  ;; These tests are supposed to be skipped on all 64-bit systems.
>                  #$@(if (target-riscv64?)

Hello!  Could you please explain a bit more what this patch fixes?

Thanks,
Clément

Message #14 received at 77782 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: Clément Lassieur <clement <at> lassieur.org>
Cc: André Batista <nandre <at> riseup.net>,
 Mark H Weaver <mhw <at> netris.org>, 77782 <at> debbugs.gnu.org,
 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>, Ian Eure <ian <at> retrospec.tv>
Subject: Re: [bug#77782] [PATCH 2/2] gnu: mozjs: Work around DST affected
 tests.
Date: Mon, 14 Apr 2025 09:46:06 +0800

On Mon, 14 Apr 2025 06:12:45 +0800,
Clément Lassieur wrote:
>
> On Sun, Apr 13 2025, Hilton Chain wrote:
>
> > * gnu/packages/gnuzilla.scm (mozjs)[arguments]<#:phases>: Use UTC for timezone
> > related tests.
> >
> > Change-Id: I480c78d208ccecda8a5467461a0e5c7228262f9d
> > ---
> >  gnu/packages/gnuzilla.scm | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
> > index 76d5ab1d29..6bcff1c348 100644
> > --- a/gnu/packages/gnuzilla.scm
> > +++ b/gnu/packages/gnuzilla.scm
> > @@ -178,6 +178,10 @@ (define-public mozjs
> >                    ((".*killed process should not have exitStatus.*")
> >                     ""))
> >
> > +                ;; FIXME: Affected by DST.
> > +                (substitute* "non262/Date/15.9.5.7.js"
> > +                  (("PST") "UTC"))
> > +
> >                  ;; This was fixed sometime between 102.15.1 and 115.11.0.
> >                  ;; These tests are supposed to be skipped on all 64-bit systems.
> >                  #$@(if (target-riscv64?)
>
> Hello!  Could you please explain a bit more what this patch fixes?

The test suite currently fails:
--8<---------------cut here---------------start------------->8---
TEST-UNEXPECTED-FAIL | non262/Date/15.9.5.7.js | (args: "") | d = new Date(1744545315400); d == new Date(d.toDateString() + " " + d.toLocaleTimeString()) = Sun Apr 13 2025 03:55:15 GMT-0700 (Pacific Daylight Time) expected: Sun Apr 13 2025 04:55:15 GMT-0700 (Pacific Daylight Time) [0.0 s]
TEST-UNEXPECTED-FAIL | non262/Date/15.9.5.7.js | (args: "") | d = new Date(1744574115400); d == new Date(d.toDateString() + " " + d.toLocaleTimeString()) = Sun Apr 13 2025 11:55:15 GMT-0700 (Pacific Daylight Time) expected: Sun Apr 13 2025 12:55:15 GMT-0700 (Pacific Daylight Time) [0.0 s]
TEST-UNEXPECTED-FAIL | non262/Date/15.9.5.7.js | (args: "") [0.0 s]
--8<---------------cut here---------------end--------------->8---

You can reproduce this by rebuilding mozjs on master.

Message #17 received at 77782 <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: André Batista <nandre <at> riseup.net>,
 Mark H Weaver <mhw <at> netris.org>, 77782 <at> debbugs.gnu.org,
 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>, Ian Eure <ian <at> retrospec.tv>
Subject: Re: [bug#77782] [PATCH 2/2] gnu: mozjs: Work around DST affected
 tests.
Date: Mon, 14 Apr 2025 13:06:59 +0200

On Mon, Apr 14 2025, Hilton Chain wrote:

> On Mon, 14 Apr 2025 06:12:45 +0800,
> Clément Lassieur wrote:
>>
>> On Sun, Apr 13 2025, Hilton Chain wrote:
>>
>> > * gnu/packages/gnuzilla.scm (mozjs)[arguments]<#:phases>: Use UTC for timezone
>> > related tests.
>> >
>> > Change-Id: I480c78d208ccecda8a5467461a0e5c7228262f9d
>> > ---
>> >  gnu/packages/gnuzilla.scm | 4 ++++
>> >  1 file changed, 4 insertions(+)
>> >
>> > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
>> > index 76d5ab1d29..6bcff1c348 100644
>> > --- a/gnu/packages/gnuzilla.scm
>> > +++ b/gnu/packages/gnuzilla.scm
>> > @@ -178,6 +178,10 @@ (define-public mozjs
>> >                    ((".*killed process should not have exitStatus.*")
>> >                     ""))
>> >
>> > +                ;; FIXME: Affected by DST.
>> > +                (substitute* "non262/Date/15.9.5.7.js"
>> > +                  (("PST") "UTC"))
>> > +
>> >                  ;; This was fixed sometime between 102.15.1 and 115.11.0.
>> >                  ;; These tests are supposed to be skipped on all 64-bit systems.
>> >                  #$@(if (target-riscv64?)
>>
>> Hello!  Could you please explain a bit more what this patch fixes?
>
> The test suite currently fails:
>
> TEST-UNEXPECTED-FAIL | non262/Date/15.9.5.7.js | (args: "") | d = new Date(1744545315400); d == new Date(d.toDateString() + " " + d.toLocaleTimeString()) = Sun Apr 13 2025 03:55:15 GMT-0700 (Pacific Daylight Time) expected: Sun Apr 13 2025 04:55:15 GMT-0700 (Pacific Daylight Time) [0.0 s]
> TEST-UNEXPECTED-FAIL | non262/Date/15.9.5.7.js | (args: "") | d = new Date(1744574115400); d == new Date(d.toDateString() + " " + d.toLocaleTimeString()) = Sun Apr 13 2025 11:55:15 GMT-0700 (Pacific Daylight Time) expected: Sun Apr 13 2025 12:55:15 GMT-0700 (Pacific Daylight Time) [0.0 s]
> TEST-UNEXPECTED-FAIL | non262/Date/15.9.5.7.js | (args: "") [0.0 s]
>
> You can reproduce this by rebuilding mozjs on master.

And does the test still make sense with this patch?  Wouldn't it be
wiser to just disable the non-working test?

Message #20 received at 77782 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: 77782 <at> debbugs.gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>
Subject: [PATCH v2 1/2] gnu: Remove mozjs-102.
Date: Thu, 17 Apr 2025 20:46:53 +0800

It fails to build and has no dependent packages.

* gnu/packages/gnuzilla.scm (mozjs-102): Delete variable.

Change-Id: I16f67810fddd338b5e55a61b57975a83426bdf54
---
 gnu/packages/gnuzilla.scm | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index f4a912d8d5..76d5ab1d29 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -256,22 +256,6 @@ (define-public mozjs
 in C/C++.")
     (license license:mpl2.0))) ; and others for some files
 
-(define-public mozjs-102
-  (package
-    (inherit mozjs)
-    (name "mozjs")
-    (version "102.2.0")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "https://ftp.mozilla.org/pub/firefox"
-                                  "/releases/" version "esr/source/firefox-"
-                                  version "esr.source.tar.xz"))
-              (sha256
-               (base32
-                "1zwpgis7py1bf8p88pz3mpai6a02qrdb8ww2fa9kxxdl9b8r2k81"))))
-    (inputs (modify-inputs (package-inputs mozjs)
-              (replace "icu4c" icu4c-71)))))
-
 (define-public mozjs-78
   (package
     (inherit mozjs)

base-commit: f3fb333f7c7827780884d2e202f215e75db527af
-- 
2.49.0

Message #23 received at 77782 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: 77782 <at> debbugs.gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>
Subject: [PATCH v2 2/2] gnu: mozjs: Disable test suite failing for DST.
Date: Thu, 17 Apr 2025 20:46:54 +0800

* gnu/packages/gnuzilla.scm (mozjs)[arguments]<#:phases>: Delete test suite
non262/Date/15.9.5.7.js.

Change-Id: I480c78d208ccecda8a5467461a0e5c7228262f9d
---
 gnu/packages/gnuzilla.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 76d5ab1d29..78d6151ceb 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -186,6 +186,10 @@ (define-public mozjs
                             (("mips64") "mips64|riscv64")))
                        #~())
 
+                ;; FIXME: An one-hour difference is produced after DST
+                ;; starting in the timezone the test suite uses.
+                (delete-file "non262/Date/15.9.5.7.js")
+
                 ;; The test suite expects a lightly patched ICU.  Disable tests
                 ;; that do not work with the system version.  See
                 ;; "intl/icu-patches" for clues.
-- 
2.49.0

Message #26 received at 77782 <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: André Batista <nandre <at> riseup.net>,
 Mark H Weaver <mhw <at> netris.org>, 77782 <at> debbugs.gnu.org,
 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>, Ian Eure <ian <at> retrospec.tv>
Subject: Re: [bug#77782] [PATCH v2 2/2] gnu: mozjs: Disable test suite
 failing for DST.
Date: Thu, 17 Apr 2025 16:06:16 +0200

On Thu, Apr 17 2025, Hilton Chain wrote:

> * gnu/packages/gnuzilla.scm (mozjs)[arguments]<#:phases>: Delete test suite
> non262/Date/15.9.5.7.js.
>
> Change-Id: I480c78d208ccecda8a5467461a0e5c7228262f9d
> ---
>  gnu/packages/gnuzilla.scm | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
> index 76d5ab1d29..78d6151ceb 100644
> --- a/gnu/packages/gnuzilla.scm
> +++ b/gnu/packages/gnuzilla.scm
> @@ -186,6 +186,10 @@ (define-public mozjs
>                              (("mips64") "mips64|riscv64")))
>                         #~())
>  
> +                ;; FIXME: An one-hour difference is produced after DST
> +                ;; starting in the timezone the test suite uses.
> +                (delete-file "non262/Date/15.9.5.7.js")

Great, LGTM, thanks.

>                  ;; The test suite expects a lightly patched ICU.  Disable tests
>                  ;; that do not work with the system version.  See
>                  ;; "intl/icu-patches" for clues.

Message #31 received at 77782-done <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: Clément Lassieur <clement <at> lassieur.org>
Cc: André Batista <nandre <at> riseup.net>,
 Mark H Weaver <mhw <at> netris.org>, 77782-done <at> debbugs.gnu.org,
 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>, Ian Eure <ian <at> retrospec.tv>
Subject: Re: [bug#77782] [PATCH v2 2/2] gnu: mozjs: Disable test suite failing
 for DST.
Date: Sat, 19 Apr 2025 14:30:59 +0800

On Thu, 17 Apr 2025 22:06:16 +0800,
Clément Lassieur wrote:
>
> On Thu, Apr 17 2025, Hilton Chain wrote:
>
> > * gnu/packages/gnuzilla.scm (mozjs)[arguments]<#:phases>: Delete test suite
> > non262/Date/15.9.5.7.js.
> >
> > Change-Id: I480c78d208ccecda8a5467461a0e5c7228262f9d
> > ---
> >  gnu/packages/gnuzilla.scm | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
> > index 76d5ab1d29..78d6151ceb 100644
> > --- a/gnu/packages/gnuzilla.scm
> > +++ b/gnu/packages/gnuzilla.scm
> > @@ -186,6 +186,10 @@ (define-public mozjs
> >                              (("mips64") "mips64|riscv64")))
> >                         #~())
> >
> > +                ;; FIXME: An one-hour difference is produced after DST
> > +                ;; starting in the timezone the test suite uses.
> > +                (delete-file "non262/Date/15.9.5.7.js")
>
> Great, LGTM, thanks.
>
> >                  ;; The test suite expects a lightly patched ICU.  Disable tests
> >                  ;; that do not work with the system version.  See
> >                  ;; "intl/icu-patches" for clues.

Thanks, I have applied it as b276cf2f9785c71cc37688c3e2b1db38e2c710a1.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.