GNU bug report logs - #77816
[PATCH] Fix deleting the first line of calc-trail-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77816 in the body.
You can then email your comments to 77816 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wojciech Siewierski <wojciech <at> siewierski.eu>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix deleting the first line of calc-trail-mode
Date: Mon, 14 Apr 2025 19:20:37 +0200

[Message part 1 (text/plain, inline)]

As of GNU Emacs 30.1 it's not possible to delete the first line of the
calc trail visible after invoking the Emacs calculator.

To reproduce:

1. Start Emacs calc: C-x * c
2. Enter a few numbers: 10 RET 20 RET 30 RET
3. Try deleting the trail lines, repeat for each line: t k

Expected behavior: all the trail lines are being deleted.

Actual behavior: the first line is still left, no error is reported.

This bug was introduced in commit
8e1376a39125c3ffc0484077b502444d853eca79, included since Emacs 28.1.
Before that commit, calc trail used its first line as a header, which
wasn't meant to be deleted.  After migrating to using header-line, the
code preserving the first line was kept intact, still preventing the
removal of the first line even though it's no longer special.

I'm attaching a patch fixing this behavior.

Best regards
-- 
Wojciech Siewierski

[0001-Fix-deleting-the-first-line-of-calc-trail-mode.patch (text/patch, attachment)]

Message #10 received at 77816-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Wojciech Siewierski <wojciech <at> siewierski.eu>
Cc: 77816-done <at> debbugs.gnu.org
Subject: Re: bug#77816: [PATCH] Fix deleting the first line of calc-trail-mode
Date: Tue, 15 Apr 2025 11:58:19 +0300

> From: Wojciech Siewierski <wojciech <at> siewierski.eu>
> Date: Mon, 14 Apr 2025 19:20:37 +0200
> 
> As of GNU Emacs 30.1 it's not possible to delete the first line of the
> calc trail visible after invoking the Emacs calculator.
> 
> To reproduce:
> 
> 1. Start Emacs calc: C-x * c
> 2. Enter a few numbers: 10 RET 20 RET 30 RET
> 3. Try deleting the trail lines, repeat for each line: t k
> 
> Expected behavior: all the trail lines are being deleted.
> 
> Actual behavior: the first line is still left, no error is reported.
> 
> This bug was introduced in commit
> 8e1376a39125c3ffc0484077b502444d853eca79, included since Emacs 28.1.
> Before that commit, calc trail used its first line as a header, which
> wasn't meant to be deleted.  After migrating to using header-line, the
> code preserving the first line was kept intact, still preventing the
> removal of the first line even though it's no longer special.
> 
> I'm attaching a patch fixing this behavior.

Thanks, I've now installed this on the emacs-30 release branch, and
I'm closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.