GNU bug report logs - #77832
[PATCH] news: Add entry for the node-build-system API change.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77832 in the body.
You can then email your comments to 77832 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] news: Add entry for the node-build-system API change.
Date: Tue, 15 Apr 2025 22:52:48 +0200

* etc/news.scm: Add entry.

Change-Id: I11b33fef997764f661e03a4b527c7610c48940f0
---
 etc/news.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/etc/news.scm b/etc/news.scm
index 4b3da44540..7e9f41736d 100644
--- a/etc/news.scm
+++ b/etc/news.scm
@@ -28,6 +28,7 @@
 ;; Copyright © 2024 Nicolas Graves <ngraves <at> ngraves.fr>
 ;; Copyright © 2024 Sebastian Dümcke <code <at> sam-d.com>
 ;; Copyright © 2025 Roman Scherer <roman <at> burningswell.com>
+;; Copyright © 2025 Jelle Licht <jlicht <at> fsfe.org>
 
 ;;
 ;; Copying and distribution of this file, with or without modification, are
@@ -36,6 +37,23 @@
 
 (channel-news
  (version 0)
+ (entry (commit "3e9e164154af6245389af5a1781473b36263ad20")
+        (title
+         (en "Incompatible changes in the @code{node-build-system}"))
+        (body
+         (en "The @code{node-build-system} has been modified to work with the new
+@code{modify-json} API.
+
+Note that if you used @code{delete-dependencies} or
+@code{with-atomic-json-file-replacement} in your own packages previously, you now
+have to wrap these in @code{modify-json}.  For example:
+
+@lisp
+(modify-json (delete-dependencies '(\"tslint\")))
+@end lisp
+
+The @code{npm-binary} importer generates package expressions using the new
+@{modify-json} API.")))
 
  (entry (commit "0e51c6547ffdaf91777f7383da4a52a1a07b7286")
         (title

base-commit: 12a6dd40a7b88454cc8a8c930c22681fcee5b1ea
-- 
2.49.0

Message #8 received at 77832 <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: Julien Lepiller <julien <at> lepiller.eu>,
 Ludovic Courtès <ludo <at> gnu.org>, 77832 <at> debbugs.gnu.org
Subject: Re: [bug#77832] [PATCH] news: Add entry for the node-build-system
 API change.
Date: Wed, 16 Apr 2025 11:52:04 +0200

[Message part 1 (text/plain, inline)]

Thank you Jelle for writing the news and simplifying node-build-system.

Could you add this German news translation?  Also:

* I changed @{modify-json} to @code{modify-json}.

* I adjusted the line breaks to the 80 characters per line limit.

* When translating, I omitted the words “Note that”.  I believe they
could also be removed from the English version, but have not made that
change.  Does not matter much either way.

[german-news-node-api.scm (text/plain, inline)]

 (entry (commit "3e9e164154af6245389af5a1781473b36263ad20")
        (title
         (en "Incompatible changes in the @code{node-build-system}")
         (de "Inkompatible Änderungen im @code{node-build-system}"))
        (body
         (en "The @code{node-build-system} has been modified to work with the
new @code{modify-json} API.

Note that if you used @code{delete-dependencies} or
@code{with-atomic-json-file-replacement} in your own packages previously, you
now have to wrap these in @code{modify-json}.  For example:

@lisp
(modify-json (delete-dependencies '(\"tslint\")))
@end lisp

The @code{npm-binary} importer generates package expressions using the new
@code{modify-json} API.")
         (de "Das Erstellungssystem @code{node-build-system} wurde verändert und
benutzt jetzt die neue @code{modify-json}-API.

Wenn Sie bisher @code{delete-dependencies} oder
@code{with-atomic-json-file-replacement} in Ihren eigenen Paketen benutzt haben,
müssen Sie diese jetzt mit @code{modify-json} umhüllen.  Zum Beispiel:

@lisp
(modify-json (delete-dependencies '(\"tslint\")))
@end lisp

Der @code{npm-binary}-Importer verwendet die neue @code{modify-json}-API und
erzeugt damit Paketausdrücke.")))

[Message part 3 (text/plain, inline)]

Regards,
Florian

Message #11 received at 77832 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: Julien Lepiller <julien <at> lepiller.eu>,
 Florian Pelz <pelzflorian <at> pelzflorian.de>, 77832 <at> debbugs.gnu.org
Subject: Re: [bug#77832] [PATCH] news: Add entry for the node-build-system
 API change.
Date: Wed, 16 Apr 2025 16:04:51 +0200

Jelle Licht <jlicht <at> fsfe.org> writes:

> * etc/news.scm: Add entry.
>
> Change-Id: I11b33fef997764f661e03a4b527c7610c48940f0

LGTM, thanks. :-)

Message #16 received at 77832-done <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Julien Lepiller <julien <at> lepiller.eu>,
 Florian Pelz <pelzflorian <at> pelzflorian.de>, 77832-done <at> debbugs.gnu.org
Subject: Re: [bug#77832] [PATCH] news: Add entry for the node-build-system
 API change.
Date: Fri, 18 Apr 2025 15:06:18 +0200

Ludovic Courtès <ludo <at> gnu.org> writes:

> Jelle Licht <jlicht <at> fsfe.org> writes:
>
>> * etc/news.scm: Add entry.
>>
>> Change-Id: I11b33fef997764f661e03a4b527c7610c48940f0
>
> LGTM, thanks. :-)
Merged into master and pushed[*] including Florian's suggested edits as a4a7ff0319.


Thanks one and all!
- Jelle

[*]: After 10+ times of getting a 502 error

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.