GNU logs - #77876, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77876: 31.0.50; elec-pair --- `electric-pair-inhibit-predicate' ignored for `electric-pair-pairs'
Resent-From: Fernando de Morais <fernandodemorais.jf@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 17 Apr 2025 20:23:05 +0000
Resent-Message-ID: <handler.77876.B.174492137825814 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77876 <at> debbugs.gnu.org
From: Fernando de Morais <fernandodemorais.jf@HIDDEN>
Date: Thu, 17 Apr 2025 17:14:46 -0300
Message-ID: <87tt6meea1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2607:f8b0:4864:20::42d;
 envelope-from=fernandodemorais.jf@HIDDEN; helo=mail-pf1-x42d.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--=-=-=
Content-Type: text/plain
Content-Disposition: inline

*Notice:* I don't believe this is a bug, but I would like to bring up a
discussion about the issue.

To illustrate the matter, using `emacs -Q', please evaluate the
following snippet:

#+begin_src emacs-lisp  
  (progn
    (elisp-enable-lexical-binding 'interactive)

    (defun org-electric-pair-inhibit (char)
      (let ((pairs '(?* ?/ ?_ ?= ?~ ?+)))
        (or (when (member char pairs)
  	    (not (region-active-p)))
  	  (electric-pair-default-inhibit char))))

    (autoload #'setq-mode-local "mode-local")
    (setopt electric-pair-mode t)
    (setq-mode-local org-mode
  		   electric-pair-pairs (append
  					electric-pair-pairs
  					'((?* . ?*) (?/ . ?/)
  					  (?_ . ?_) (?= . ?=)
  					  (?~ . ?~) (?+ . ?+)))
  		   electric-pair-inhibit-predicate #'org-electric-pair-inhibit)
    (find-file "temp.org"))
#+end_src

Results in:

- The `org-electric-pair-inhibit' function is ignored, and the
  characters that should only be inserted in pairs when the region is
  active are inserted in pairs regardless.

After a bit of investigation, I found that characters listed in
`electric-pair-pairs' are always inserted in pairs unconditionally.  The
function defined in `electric-pair-inhibit-predicate' is called only for
the pairs defined in the syntax table of the corresponding major mode.

Although I believe this was a design decision, in my view, the
`electric-pair-inhibit-predicate' function should also apply to
characters in the `electric-pair-pairs' list.

I'm not sure about the implications for other use cases, but a little
change made to the `electric-pair-post-self-insert-function' solves the
issue (diff attached).

Do you think a change like this could be considered?  Thanks in advance.

-- 
Regards,
Fernando de Morais.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline; filename=elec-pair.patch

diff --git a/lisp/elec-pair.el b/lisp/elec-pair.el
index aa2577300fd..97aeca3f3b3 100644
--- a/lisp/elec-pair.el
+++ b/lisp/elec-pair.el
@@ -593,11 +593,10 @@ electric-pair-post-self-insert-function
         ;; Insert matching pair.
         ((and (memq syntax '(?\( ?\" ?\$))
               (not overwrite-mode)
-              (or unconditional
-                  (not (electric-pair--save-literal-point-excursion
-                         (goto-char pos)
-                         (funcall electric-pair-inhibit-predicate
-                                  last-command-event)))))
+              (not (electric-pair--save-literal-point-excursion
+                    (goto-char pos)
+                    (funcall electric-pair-inhibit-predicate
+                             last-command-event))))
          (save-excursion (electric-pair--insert pair num))))))))
 
 (defun electric-pair-open-newline-between-pairs-psif ()

--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Fernando de Morais <fernandodemorais.jf@HIDDEN>
Subject: bug#77876: Acknowledgement (31.0.50; elec-pair ---
 `electric-pair-inhibit-predicate' ignored for `electric-pair-pairs')
Message-ID: <handler.77876.B.174492137825814.ack <at> debbugs.gnu.org>
References: <87tt6meea1.fsf@HIDDEN>
X-Gnu-PR-Message: ack 77876
X-Gnu-PR-Package: emacs
Reply-To: 77876 <at> debbugs.gnu.org
Date: Thu, 17 Apr 2025 20:23:06 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 77876 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
77876: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77876
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77876: 31.0.50; elec-pair --- `electric-pair-inhibit-predicate' ignored for `electric-pair-pairs'
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 26 Apr 2025 12:29:02 +0000
Resent-Message-ID: <handler.77876.B77876.174567049030458 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Fernando de Morais <fernandodemorais.jf@HIDDEN>, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Cc: 77876 <at> debbugs.gnu.org
Date: Sat, 26 Apr 2025 15:27:57 +0300
Message-Id: <86wmb7t8du.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87tt6meea1.fsf@HIDDEN> (message from Fernando de Morais on
 Thu, 17 Apr 2025 17:14:46 -0300)
References: <87tt6meea1.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Fernando de Morais <fernandodemorais.jf@HIDDEN>
> Date: Thu, 17 Apr 2025 17:14:46 -0300
> 
> *Notice:* I don't believe this is a bug, but I would like to bring up a
> discussion about the issue.
> 
> To illustrate the matter, using `emacs -Q', please evaluate the
> following snippet:
> 
> #+begin_src emacs-lisp  
>   (progn
>     (elisp-enable-lexical-binding 'interactive)
> 
>     (defun org-electric-pair-inhibit (char)
>       (let ((pairs '(?* ?/ ?_ ?= ?~ ?+)))
>         (or (when (member char pairs)
>   	    (not (region-active-p)))
>   	  (electric-pair-default-inhibit char))))
> 
>     (autoload #'setq-mode-local "mode-local")
>     (setopt electric-pair-mode t)
>     (setq-mode-local org-mode
>   		   electric-pair-pairs (append
>   					electric-pair-pairs
>   					'((?* . ?*) (?/ . ?/)
>   					  (?_ . ?_) (?= . ?=)
>   					  (?~ . ?~) (?+ . ?+)))
>   		   electric-pair-inhibit-predicate #'org-electric-pair-inhibit)
>     (find-file "temp.org"))
> #+end_src
> 
> Results in:
> 
> - The `org-electric-pair-inhibit' function is ignored, and the
>   characters that should only be inserted in pairs when the region is
>   active are inserted in pairs regardless.
> 
> After a bit of investigation, I found that characters listed in
> `electric-pair-pairs' are always inserted in pairs unconditionally.  The
> function defined in `electric-pair-inhibit-predicate' is called only for
> the pairs defined in the syntax table of the corresponding major mode.
> 
> Although I believe this was a design decision, in my view, the
> `electric-pair-inhibit-predicate' function should also apply to
> characters in the `electric-pair-pairs' list.
> 
> I'm not sure about the implications for other use cases, but a little
> change made to the `electric-pair-post-self-insert-function' solves the
> issue (diff attached).
> 
> Do you think a change like this could be considered?  Thanks in advance.
> 
> -- 
> Regards,
> Fernando de Morais.
> 
> diff --git a/lisp/elec-pair.el b/lisp/elec-pair.el
> index aa2577300fd..97aeca3f3b3 100644
> --- a/lisp/elec-pair.el
> +++ b/lisp/elec-pair.el
> @@ -593,11 +593,10 @@ electric-pair-post-self-insert-function
>          ;; Insert matching pair.
>          ((and (memq syntax '(?\( ?\" ?\$))
>                (not overwrite-mode)
> -              (or unconditional
> -                  (not (electric-pair--save-literal-point-excursion
> -                         (goto-char pos)
> -                         (funcall electric-pair-inhibit-predicate
> -                                  last-command-event)))))
> +              (not (electric-pair--save-literal-point-excursion
> +                    (goto-char pos)
> +                    (funcall electric-pair-inhibit-predicate
> +                             last-command-event))))
>           (save-excursion (electric-pair--insert pair num))))))))
>  
>  (defun electric-pair-open-newline-between-pairs-psif ()

Jo�o, any comments or suggestions?

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77876: 31.0.50; elec-pair --- `electric-pair-inhibit-predicate' ignored for `electric-pair-pairs'
Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 26 Apr 2025 14:31:01 +0000
Resent-Message-ID: <handler.77876.B77876.174567781722153 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Eli Zaretskii <eliz@HIDDEN>
Cc: Fernando de Morais <fernandodemorais.jf@HIDDEN>, 77876 <at> debbugs.gnu.org
MIME-Version: 1.0
References: <87tt6meea1.fsf@HIDDEN> <86wmb7t8du.fsf@HIDDEN>
In-Reply-To: <86wmb7t8du.fsf@HIDDEN>
From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Date: Sat, 26 Apr 2025 15:30:35 +0100
Message-ID: <CALDnm53R4y1uiGYumUm7fcs-+xkw_9sRMDj=y6ziPzb00JVOow@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Sat, Apr 26, 2025 at 1:28=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> wrote:
>
> > From: Fernando de Morais <fernandodemorais.jf@HIDDEN>
> > Date: Thu, 17 Apr 2025 17:14:46 -0300
> >
> > *Notice:* I don't believe this is a bug, but I would like to bring up a
> > discussion about the issue.
> >
> > To illustrate the matter, using `emacs -Q', please evaluate the
> > following snippet:
> >
> > #+begin_src emacs-lisp
> >   (progn
> >     (elisp-enable-lexical-binding 'interactive)
> >
> >     (defun org-electric-pair-inhibit (char)
> >       (let ((pairs '(?* ?/ ?_ ?=3D ?~ ?+)))
> >         (or (when (member char pairs)
> >           (not (region-active-p)))
> >         (electric-pair-default-inhibit char))))
> >
> >     (autoload #'setq-mode-local "mode-local")
> >     (setopt electric-pair-mode t)
> >     (setq-mode-local org-mode
> >                  electric-pair-pairs (append
> >                                       electric-pair-pairs
> >                                       '((?* . ?*) (?/ . ?/)
> >                                         (?_ . ?_) (?=3D . ?=3D)
> >                                         (?~ . ?~) (?+ . ?+)))
> >                  electric-pair-inhibit-predicate #'org-electric-pair-in=
hibit)
> >     (find-file "temp.org"))
> > #+end_src
> >
> > Results in:
> >
> > - The `org-electric-pair-inhibit' function is ignored, and the
> >   characters that should only be inserted in pairs when the region is
> >   active are inserted in pairs regardless.
> >
> > After a bit of investigation, I found that characters listed in
> > `electric-pair-pairs' are always inserted in pairs unconditionally.  Th=
e
> > function defined in `electric-pair-inhibit-predicate' is called only fo=
r
> > the pairs defined in the syntax table of the corresponding major mode.
> >
> > Although I believe this was a design decision, in my view, the
> > `electric-pair-inhibit-predicate' function should also apply to
> > characters in the `electric-pair-pairs' list.
> >
> > I'm not sure about the implications for other use cases, but a little
> > change made to the `electric-pair-post-self-insert-function' solves the
> > issue (diff attached).
> >
> > Do you think a change like this could be considered?  Thanks in advance=
.
> >
> > --
> > Regards,
> > Fernando de Morais.
> >
> > diff --git a/lisp/elec-pair.el b/lisp/elec-pair.el
> > index aa2577300fd..97aeca3f3b3 100644
> > --- a/lisp/elec-pair.el
> > +++ b/lisp/elec-pair.el
> > @@ -593,11 +593,10 @@ electric-pair-post-self-insert-function
> >          ;; Insert matching pair.
> >          ((and (memq syntax '(?\( ?\" ?\$))
> >                (not overwrite-mode)
> > -              (or unconditional
> > -                  (not (electric-pair--save-literal-point-excursion
> > -                         (goto-char pos)
> > -                         (funcall electric-pair-inhibit-predicate
> > -                                  last-command-event)))))
> > +              (not (electric-pair--save-literal-point-excursion
> > +                    (goto-char pos)
> > +                    (funcall electric-pair-inhibit-predicate
> > +                             last-command-event))))
> >           (save-excursion (electric-pair--insert pair num))))))))
> >
> >  (defun electric-pair-open-newline-between-pairs-psif ()
>
> Jo=C3=A3o, any comments or suggestions?

I don't know, much of this is out of my mental cache.  But I would
start by checking
if it passes the unit tests for elec-pair.el (hoping that they haven't
been disabled
as as has happened in the past).  The tests have a pretty important say on
what the library is supposed to do, as they were carefully crafted from a g=
ood
number of edge cases and bug reports.

Jo=C3=A3o

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#77876: 31.0.50; elec-pair --- `electric-pair-inhibit-predicate' ignored for `electric-pair-pairs'
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 10 May 2025 09:33:02 +0000
Resent-Message-ID: <handler.77876.B77876.174686957721032 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77876
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: fernandodemorais.jf@HIDDEN, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Cc: 77876 <at> debbugs.gnu.org
Received: via spool by 77876-submit <at> debbugs.gnu.org id=B77876.174686957721032
          (code B ref 77876); Sat, 10 May 2025 09:33:02 +0000
Received: (at 77876) by debbugs.gnu.org; 10 May 2025 09:32:57 +0000
Received: from localhost ([127.0.0.1]:43928 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uDgZk-0005T3-Kx
	for submit <at> debbugs.gnu.org; Sat, 10 May 2025 05:32:57 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:54802)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1uDgZi-0005Sn-5t
 for 77876 <at> debbugs.gnu.org; Sat, 10 May 2025 05:32:54 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1uDgZc-0001di-MP; Sat, 10 May 2025 05:32:48 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=ABr1H/jGApOSb8uEMv0J+/OHV8tZYQn0gwlrrZtpWYE=; b=hANaLy5qNYoOJ0r03A9t
 ksqBxgrBhtGZmA7RrCBGHUA679XuUe+LFkOA2eP3DvGWbfIQknXwkI2HEljEnQ5Zdpw4qvDMKnxOb
 B7UGpnrGR2tjlVu75cHIX1OrWFJ6AHEP4j/4jiE7AolGv2ou7jVHMcQ5PsZp2jucLaWhlaGcsZII2
 CkHNVHvVWiMv0hlhXkVyzGJBIDGvUgNNVvpwcsj8euIzqSHSiN59VcaIvDQ2iFl5aqR7SThRG1xPF
 8eOk+hsQpR8nYcOZw/oPnqPqR9PcxT7+NCrjktm1ameRJkxZCBpL+e250j99Xi1YF24sJAyYZZ1hz
 0f5Ulm/PyL2rrQ==;
Date: Sat, 10 May 2025 12:32:46 +0300
Message-Id: <864ixsbykh.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CALDnm53R4y1uiGYumUm7fcs-+xkw_9sRMDj=y6ziPzb00JVOow@HIDDEN>
 (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Sat, 26 Apr 2025 15:30:35
 +0100)
References: <87tt6meea1.fsf@HIDDEN> <86wmb7t8du.fsf@HIDDEN>
 <CALDnm53R4y1uiGYumUm7fcs-+xkw_9sRMDj=y6ziPzb00JVOow@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Ping! Any progress with this issue?

> From: João Távora <joaotavora@HIDDEN>
> Date: Sat, 26 Apr 2025 15:30:35 +0100
> Cc: Fernando de Morais <fernandodemorais.jf@HIDDEN>, 77876 <at> debbugs.gnu.org
> 
> On Sat, Apr 26, 2025 at 1:28 PM Eli Zaretskii <eliz@HIDDEN> wrote:
> >
> > > From: Fernando de Morais <fernandodemorais.jf@HIDDEN>
> > > Date: Thu, 17 Apr 2025 17:14:46 -0300
> > >
> > > *Notice:* I don't believe this is a bug, but I would like to bring up a
> > > discussion about the issue.
> > >
> > > To illustrate the matter, using `emacs -Q', please evaluate the
> > > following snippet:
> > >
> > > #+begin_src emacs-lisp
> > >   (progn
> > >     (elisp-enable-lexical-binding 'interactive)
> > >
> > >     (defun org-electric-pair-inhibit (char)
> > >       (let ((pairs '(?* ?/ ?_ ?= ?~ ?+)))
> > >         (or (when (member char pairs)
> > >           (not (region-active-p)))
> > >         (electric-pair-default-inhibit char))))
> > >
> > >     (autoload #'setq-mode-local "mode-local")
> > >     (setopt electric-pair-mode t)
> > >     (setq-mode-local org-mode
> > >                  electric-pair-pairs (append
> > >                                       electric-pair-pairs
> > >                                       '((?* . ?*) (?/ . ?/)
> > >                                         (?_ . ?_) (?= . ?=)
> > >                                         (?~ . ?~) (?+ . ?+)))
> > >                  electric-pair-inhibit-predicate #'org-electric-pair-inhibit)
> > >     (find-file "temp.org"))
> > > #+end_src
> > >
> > > Results in:
> > >
> > > - The `org-electric-pair-inhibit' function is ignored, and the
> > >   characters that should only be inserted in pairs when the region is
> > >   active are inserted in pairs regardless.
> > >
> > > After a bit of investigation, I found that characters listed in
> > > `electric-pair-pairs' are always inserted in pairs unconditionally.  The
> > > function defined in `electric-pair-inhibit-predicate' is called only for
> > > the pairs defined in the syntax table of the corresponding major mode.
> > >
> > > Although I believe this was a design decision, in my view, the
> > > `electric-pair-inhibit-predicate' function should also apply to
> > > characters in the `electric-pair-pairs' list.
> > >
> > > I'm not sure about the implications for other use cases, but a little
> > > change made to the `electric-pair-post-self-insert-function' solves the
> > > issue (diff attached).
> > >
> > > Do you think a change like this could be considered?  Thanks in advance.
> > >
> > > --
> > > Regards,
> > > Fernando de Morais.
> > >
> > > diff --git a/lisp/elec-pair.el b/lisp/elec-pair.el
> > > index aa2577300fd..97aeca3f3b3 100644
> > > --- a/lisp/elec-pair.el
> > > +++ b/lisp/elec-pair.el
> > > @@ -593,11 +593,10 @@ electric-pair-post-self-insert-function
> > >          ;; Insert matching pair.
> > >          ((and (memq syntax '(?\( ?\" ?\$))
> > >                (not overwrite-mode)
> > > -              (or unconditional
> > > -                  (not (electric-pair--save-literal-point-excursion
> > > -                         (goto-char pos)
> > > -                         (funcall electric-pair-inhibit-predicate
> > > -                                  last-command-event)))))
> > > +              (not (electric-pair--save-literal-point-excursion
> > > +                    (goto-char pos)
> > > +                    (funcall electric-pair-inhibit-predicate
> > > +                             last-command-event))))
> > >           (save-excursion (electric-pair--insert pair num))))))))
> > >
> > >  (defun electric-pair-open-newline-between-pairs-psif ()
> >
> > João, any comments or suggestions?
> 
> I don't know, much of this is out of my mental cache.  But I would
> start by checking
> if it passes the unit tests for elec-pair.el (hoping that they haven't
> been disabled
> as as has happened in the past).  The tests have a pretty important say on
> what the library is supposed to do, as they were carefully crafted from a good
> number of edge cases and bug reports.
> 
> João
>

Last modified: Sat, 10 May 2025 09:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.