X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Sat, 19 Apr 2025 16:06:02 +0000 Resent-Message-ID: <handler.77924.B.174507875510266 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 77924 <at> debbugs.gnu.org Cc: Stefan Monnier <monnier@HIDDEN> X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.174507875510266 (code B ref -1); Sat, 19 Apr 2025 16:06:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Apr 2025 16:05:55 +0000 Received: from localhost ([127.0.0.1]:35845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u6AhW-0002fW-Mo for submit <at> debbugs.gnu.org; Sat, 19 Apr 2025 12:05:55 -0400 Received: from lists.gnu.org ([2001:470:142::17]:47548) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u6AhT-0002ez-DS for submit <at> debbugs.gnu.org; Sat, 19 Apr 2025 12:05:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <gerd.moellmann@HIDDEN>) id 1u6AhL-00022J-A0 for bug-gnu-emacs@HIDDEN; Sat, 19 Apr 2025 12:05:43 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <gerd.moellmann@HIDDEN>) id 1u6AhJ-0001u7-IH for bug-gnu-emacs@HIDDEN; Sat, 19 Apr 2025 12:05:42 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3995ff6b066so1445179f8f.3 for <bug-gnu-emacs@HIDDEN>; Sat, 19 Apr 2025 09:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745078740; x=1745683540; darn=gnu.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=DvMWM75l2U6mBu9r6RI09XZGJ8BeZ9oW08Ahx2iBeDc=; b=joLA6D12WSwx7Brq7GA3sJf+IgHNYI01UCqq77P7Lrp4erwmqwc+EKv/KvaT9gnvQF oJzgEG3x0cwsOkmRSYkAOs+DMoVsp4m53+V8XRU2LRx4Fmq9/yebHJops+Zfc379py4R sHyvQQvk1FQOe2BOTZzqdgrgJde0ZeIKReIA6bBDWCUXX7PYu7D6d7+iSpTK4H5oZhbj +b9KT+bNvSll2dtnV6ZIuolMDeABUPRVVdRn0SUHiPsaL2M3HpLArp/dCKX09Q9ew/O9 AC9/97fXNrWC68OtJv1UwOF7tGLHXq06g/RhUVBKqMkXtNSMMuQzk48wwwt8zge4xai0 IygA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745078740; x=1745683540; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DvMWM75l2U6mBu9r6RI09XZGJ8BeZ9oW08Ahx2iBeDc=; b=TAbEqyxUh2cP0XPCA4IjzO1y+v9zLfyWmEQACHavh3Jcm9AZaLqZg+ZDs0lsUQQKU9 IrGqzaKDWcA0bqOQHn2Z0vLX/MRDbRW5vucEESv1eYZ6c3Xq5WUnJjIem6GwR08SHcFC I0UKRZY5VwCs8vSbGa60fEILVrFkM+hhgOhfgNS/HMluUrkL7Lq6H9GmLKRkduIv4Vox Hx0RWcraFTnpw8MTr/u7FIurUk8IckrAoT6o5Xt6Vn+80r7+hNBJaJvOV4c780H4y5hx khmlXQ/FUt2q1lTGi/l0R3kqhJ5JFoPmDSVeHDsW+JDyveXqMSLPU5EuFqkq6YGE4H8r j0aw== X-Gm-Message-State: AOJu0YwjBZo8XM0d11vN9adfMF9+uo/16IofgB21PTBxloH8I4xI3brB elBH/t9lsmaBcm7Gm6OaYZXsgU16C3GVPYz9HsqHJ/NNWwx82j2XMcVi/bqu X-Gm-Gg: ASbGncu3xsFGMYrLDKjrOI6Siho2dtopg1xy01sMOPnC2GPylOg2ZFVyERC7KZraVn/ XJNgUqm8UAciqBY4B5CWRmgDecLZ2tOjbBducyh9iDtFRpwkona3nfsG/qsEH3vsGEu2Wh8HhhM xXafeMAZ+5ohdnl6XFDsOw8nMy5rymZRBfHPTplX2Nrw5juMsiHuikqsf+J/cjdQG8P/6iJ9yom h6rI/y5O3jBMOg5DZtWSjpVNbI2wVHhI7XsLej+DL2ISiBADFLpMmb8u2pGC8NZ3E566hcIznAR 3FMyzHCTUvHkdL7zrNI8oiEaX5xeZAQw9qhaSo0u18dj4lqInfeUoJGL799j1Ff5C2Fa7QsK3Ov RsMBu1XaZsfpls0nmGgLTGWka1yZdvR+myIi8e1m8l/zB/xilWA== X-Google-Smtp-Source: AGHT+IHAjkDYwqb0EjtFZ0JrL4ORcyAtyACfBgQrtaugqkk2cEKWIdQJeT0gYkEcpWMX8ZMPo9dDXw== X-Received: by 2002:a05:6000:4284:b0:391:3028:c779 with SMTP id ffacd0b85a97d-39efbae3ff8mr4914368f8f.45.1745078739497; Sat, 19 Apr 2025 09:05:39 -0700 (PDT) Received: from pro2 (p200300e0b7179a00edfd9109c079612a.dip0.t-ipconnect.de. [2003:e0:b717:9a00:edfd:9109:c079:612a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4235dasm6166630f8f.9.2025.04.19.09.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Apr 2025 09:05:39 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Date: Sat, 19 Apr 2025 18:05:38 +0200 Message-ID: <m2jz7gp25p.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=gerd.moellmann@HIDDEN; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) This is about the branch scratch/text-index on savannah, which is a port of what I have in my Emacs. The branch changes the implementation of Lisp markers. - Markers no longer form a doubly-linked list, they are stored in a marker vector instead which allows O(1) insertion and deletion of markers. (The idea of a marker vector is from what I did in igc. In my Emacs, both igc and old GC use the same marker vector implementation. The new one is different from the one in feature/igc.) - Lisp_Marker doesn't contain the character position directly. It is stored in the marker vector instead. This leads to faster, cache-friendly, marker position adjustments. - Markers don't contain byte positions. Byte positions are computed when needed. Bytepos <-> charpos conversion are done using a text-index data structure. This removes the heuristics currently used in master, and allows removing byte positions from markers. In summary, I'd say performance is good, to say the least, in many cases better, and it fixes corner cases leading the abysmal performance in current master. Please see the comments at the start of marker-vector.c and text-index.c for more details. Also see the thread(s) on emacs-devel with Stef an me.
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Subject: bug#77924: Acknowledgement (31.0.50; [Feature branch] Change marker implementation) Message-ID: <handler.77924.B.174507875510266.ack <at> debbugs.gnu.org> References: <m2jz7gp25p.fsf@HIDDEN> X-Gnu-PR-Message: ack 77924 X-Gnu-PR-Package: emacs Reply-To: 77924 <at> debbugs.gnu.org Date: Sat, 19 Apr 2025 16:06:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 77924 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 77924: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77924 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Sat, 19 Apr 2025 16:33:01 +0000 Resent-Message-ID: <handler.77924.B77924.174508037418435 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Cc: monnier@HIDDEN, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174508037418435 (code B ref 77924); Sat, 19 Apr 2025 16:33:01 +0000 Received: (at 77924) by debbugs.gnu.org; 19 Apr 2025 16:32:54 +0000 Received: from localhost ([127.0.0.1]:36106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u6B7e-0004nH-EZ for submit <at> debbugs.gnu.org; Sat, 19 Apr 2025 12:32:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49620) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1u6B7b-0004n3-Mr for 77924 <at> debbugs.gnu.org; Sat, 19 Apr 2025 12:32:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1u6B7W-00062t-8V; Sat, 19 Apr 2025 12:32:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=El/ssJyA02Ev9E3Zg0NjcTNEwerkL9i4ebQ+VsAUxCk=; b=G/mH79Rauci8m91MQrba Q1ELhD1JxiFl05aNoWJDyotMTne9CQGzUg1ckr4Tj+EpMKpsCLajNa+QgCrHO4Ix1HR76YNXQ1Y3O xst8hQl0ohRg6fw8WvYZfhilbmw0RPV5KManX1vV0UYnu3iYVkBX74ZyTWx82veu8cnNXfQsCGkT+ 1G0yyBwkNkPHgZjyUFJJCBrAs6wEmgIsFg07Y6qNAc/nfU3O+Slc3o9yCfeOqOIHjnW+UN5NyINH1 LZzdBCuAxak30V1bDI8G7Xcy8osG+QkclbaSF3iGSZomxl/lKsJmnoioYCHZuHkoxnn2xePRWIVaj znfQiC3O4wjaEw==; Date: Sat, 19 Apr 2025 19:32:42 +0300 Message-Id: <86plh86rit.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <m2jz7gp25p.fsf@HIDDEN> (message from Gerd =?UTF-8?Q?M=C3=B6llmann?= on Sat, 19 Apr 2025 18:05:38 +0200) References: <m2jz7gp25p.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: Stefan Monnier <monnier@HIDDEN> > From: Gerd Möllmann <gerd.moellmann@HIDDEN> > Date: Sat, 19 Apr 2025 18:05:38 +0200 > > This is about the branch scratch/text-index on savannah, which is a port > of what I have in my Emacs. > > The branch changes the implementation of Lisp markers. > > - Markers no longer form a doubly-linked list, they are stored in a > marker vector instead which allows O(1) insertion and deletion of > markers. (The idea of a marker vector is from what I did in igc. In my > Emacs, both igc and old GC use the same marker vector implementation. > The new one is different from the one in feature/igc.) > > - Lisp_Marker doesn't contain the character position directly. It is > stored in the marker vector instead. This leads to faster, > cache-friendly, marker position adjustments. > > - Markers don't contain byte positions. Byte positions are computed when > needed. Bytepos <-> charpos conversion are done using a text-index > data structure. This removes the heuristics currently used in master, > and allows removing byte positions from markers. > > In summary, I'd say performance is good, to say the least, in many cases > better, and it fixes corner cases leading the abysmal performance in > current master. > > Please see the comments at the start of marker-vector.c and text-index.c > for more details. Also see the thread(s) on emacs-devel with Stef an me. Thanks. Are there any backward-incompatible changes with this? Do all the tests still pass as well as they did before these changes?
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Sat, 19 Apr 2025 16:59:02 +0000 Resent-Message-ID: <handler.77924.B77924.174508191028355 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: monnier@HIDDEN, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174508191028355 (code B ref 77924); Sat, 19 Apr 2025 16:59:02 +0000 Received: (at 77924) by debbugs.gnu.org; 19 Apr 2025 16:58:30 +0000 Received: from localhost ([127.0.0.1]:36341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u6BWQ-0007NG-2N for submit <at> debbugs.gnu.org; Sat, 19 Apr 2025 12:58:30 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:45189) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u6BWN-0007Mt-Nq for 77924 <at> debbugs.gnu.org; Sat, 19 Apr 2025 12:58:28 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-43cfebc343dso22539975e9.2 for <77924 <at> debbugs.gnu.org>; Sat, 19 Apr 2025 09:58:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745081901; x=1745686701; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=60PrrnpWeSVE/nv5wmLOv1p4KC+SIWuq8eDu/MjvDMs=; b=BNFL2F0vga7tz8iVOM0z2hPg/NmGAtMwCXEwMQUGBeIZWDmF25Hb0ljI5YkDtjFlID JCrftjHphgHAMFdsLS9H3Hq2OOrArsg93zgptyaZB79dGymZTJjl9hhoEEE5GmI/H34Y Rw149wfIYBjrJkgISCgPF3XaJeez8vDZROjGk1qbiGkNUx4c+YRhUbDN44gVJaIqQhTM Vg1/wPgedni09+Lz3uNOC6MXaZlSfSFHTQ2xLthCeWSzQcLVJqMDkifYdkppX0PKF9iQ XA080LfSGdVvFDRX0PmxeLV097PC0NW22eh77xvPBM8fhgZlmrF8gfgwcpmKOL+/rVXC lZlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745081901; x=1745686701; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=60PrrnpWeSVE/nv5wmLOv1p4KC+SIWuq8eDu/MjvDMs=; b=h9CVCODiU9F8oSQYgDRfCM1HKZR/C6yoXi1NQkaYNyi+AMV18iRt0zrYlYCdH2expS DX1o/yarped2BnBht9ZTP1S7ygSflIyhMB2tzIdJSoFaa7Y2QG+MTV8J0Fj/1zkkiw0m lx7FExv2zkwXk2QJBLsd9tc1E3weY/ftuR9hdmVC/+7YkZxHWFZPpgyVGBFUkRX0aBWb 9xaC/vvJ0xLcvnx41Cxrtb182zTAunExQKvko7RBex+X/50N29lHOyHIMBi6FbgBzRMx Q6zF4ZRj+lUAHxaCCHYzmSeaMgYjmSlxGXUu9i1ZYP0DU/lcqJws+GitqVQkFCEwECVb y0MQ== X-Gm-Message-State: AOJu0YzmWm6zWISk+ttHy3OtiXUs8Gq7J2iKmNMfaizAQau0t41FcUhb 8+zJfb+cTxWmp6xRgFggdaiEjqDBQ+zzaQhZbMJSBoeUIMGrhW0L X-Gm-Gg: ASbGncsvydegQj599fV9fMGD4kzdSx4d9U3XmHDyP+p2hEsHokXzwoTcmBOkWAITzzb 9yBAg9KaNKpbeKAakj44dhY6nlartDkZ3vXLbQ8MNeB+qa1pdCHtdlf/j4uYfFoSITiqUn6nlQ3 uI6Mvvm8FluSVothHg4e+tEf1UcDqcl31YmhyMU5EUgIrIvKY4MNtljrod6PNcUJRjwZrzco4HX Eg5gYZIGNpt2r84lT8h2hAsSsgUSunPVyHlgM2wDL0KI2eWbCx5RP6uvJLD2MFcSqRbph/Oc1dW DE7yTy4C3IgCMgaL9EXOJN+nyZsfvmS9/ccylbP4gdfuggK56vWN207Xy5QGIui9oW37F0hTj0C BZXDrya7mgQSBIyW5aVqkqjo3Zik/f5/hNEOL8vcnY70AAJPq3w== X-Google-Smtp-Source: AGHT+IFtiiUDHtp/y9OET7/E4nnTbUsp2FSclehAVron4Ih2hIs47dyPUMSEeGq197A0b539ftcWYQ== X-Received: by 2002:a5d:584e:0:b0:391:39fb:59c8 with SMTP id ffacd0b85a97d-39efba5f83dmr5418865f8f.25.1745081901313; Sat, 19 Apr 2025 09:58:21 -0700 (PDT) Received: from pro2 (p200300e0b7179a00edfd9109c079612a.dip0.t-ipconnect.de. [2003:e0:b717:9a00:edfd:9109:c079:612a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4406d5aa100sm68414465e9.7.2025.04.19.09.58.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Apr 2025 09:58:20 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <86plh86rit.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <86plh86rit.fsf@HIDDEN> Date: Sat, 19 Apr 2025 18:58:20 +0200 Message-ID: <m2fri4ozpv.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: > Are there any backward-incompatible changes with this? None I'm aware of. > Do all the tests still pass as well as they did before these changes? I got a SEGV in buffer-tests right now when I checked again that went away an a second run. So I'll have to check that.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Sat, 19 Apr 2025 20:57:02 +0000 Resent-Message-ID: <handler.77924.B77924.174509619327042 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: monnier@HIDDEN, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174509619327042 (code B ref 77924); Sat, 19 Apr 2025 20:57:02 +0000 Received: (at 77924) by debbugs.gnu.org; 19 Apr 2025 20:56:33 +0000 Received: from localhost ([127.0.0.1]:38678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u6FEk-00071s-ON for submit <at> debbugs.gnu.org; Sat, 19 Apr 2025 16:56:32 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:44308) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u6FEe-000709-Tv for 77924 <at> debbugs.gnu.org; Sat, 19 Apr 2025 16:56:27 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-39efc1365e4so739930f8f.1 for <77924 <at> debbugs.gnu.org>; Sat, 19 Apr 2025 13:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745096179; x=1745700979; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gBhlG0sauO9gvuFz1FvZBSwGf51snW/0rypj0VQNIm0=; b=Lz2W02vwQ/cXY4lo3gWmJBnHwpfDwmFuhHV+Pgk8sW9NNrugqHfqcSjubqBvQuR2DJ gAaufwYmE2hLgYhpI7FQ4wZ6CF76Eg+d4cKSTV70FXp/ucF5rJbEnsd74DRWCoTNmwOs +GGOwucui0vw0uCQ6NwDcju7J5jP01g43tpTpcYR405l0UUrTGY9/w+GaNgE3Ww2UUq6 k4V+SChYdlQDqaYII5uE6Er8adldZLzc3V1sahGCpRFjdMFNSimJLdkyQzGCGZD3wR/k d2oekDZTqrUiDRnk/oXyKctuSCAlOs9LkjAvCXhRDxrY9hxqJ/odtQLuCA+nWRp/Jk3k nF7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745096179; x=1745700979; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gBhlG0sauO9gvuFz1FvZBSwGf51snW/0rypj0VQNIm0=; b=ebECDxSX+GYRlYlA2icr/9w0lB0Eo288jL7sE5A/DkSQ2c0OT5Bx10L1FdpmVcq+We O7KFWkTDdx9Lt6Ejtg+YfJjVCd5ioULw7FHalwqYi/B99hrootX+dxBVXMZ+wbnl5xjj TKJ/EhVYURDuNYFEeB8rXt+WBHEprkQ/b1lcK1451Lfd+9MndBMG4BBXGkbFujRv4qhg 5SkLPw1zFYhdOzC6ljUUGbo8w7SZaCHLiOmJezKCKaYxTTOv56HbKJbsXc6EjXS19fSG jvJrqKHYKPgg5SrLQgxnnTgbAnhMEmoNALNag0iHYVjp1axJGSoAckpVCRa9m91/QRh+ QRow== X-Gm-Message-State: AOJu0Yx3a/NeP0+LbYn6//Td9xYNheLShVdOIcR2qqdnH+pb7b8i3rzV v/Sv4pTg14WYzjIckMIzI/hB19R59wYwtNy3YM0e335Hqw4IzYB9 X-Gm-Gg: ASbGnctZhTIXpzIH7jnyXzwHVpEG9ZNk00bDbILevrfv1MIrIBX3u1pxMymoIJZFs9J yIkmI2VCk193iqeZNN9kf7TSlXaV2sSwP9TrbYKFAlruy1F5kwKO6u76nG5xEiZ4BpC6SmwNVmU BnrrcH98vfdbZEs6xgk0E0JBqGMltNj+Yotd3YQSVJoVpT1BXzlMAUV8PCTaXHk7CQYAR6W8Iuv tirNwS09vRkRd3j28iRdDDbKedr806EjeDWoFs+JzmpwcyInSjMXu+0u/LOExH/tTnCpN1Z1c6t nUGxE6dIQMkckfiScLZ1K3phsvPUrrI913rFCOZdnfj/4BJ35mvU3gHFJ/PDa/BHOtqYqwNwp4n pD37TLWLSN1ujYR3RmWuY8B9tbRNSDPmfNYlJVgd88rnc2GUI7w== X-Google-Smtp-Source: AGHT+IF6vB7I9hX7Mh23zeK99E4EXD8Z+iuiuFlgX/fdvNQD2VrwhZeG2KFN/SzOH7RSGQiwAr86gw== X-Received: by 2002:a05:6000:4012:b0:390:f9d0:5e3 with SMTP id ffacd0b85a97d-39efba37dbfmr5596446f8f.1.1745096178459; Sat, 19 Apr 2025 13:56:18 -0700 (PDT) Received: from pro2 (p200300e0b7179a00edfd9109c079612a.dip0.t-ipconnect.de. [2003:e0:b717:9a00:edfd:9109:c079:612a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa43c023sm6771029f8f.46.2025.04.19.13.56.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Apr 2025 13:56:18 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <m2fri4ozpv.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <86plh86rit.fsf@HIDDEN> <m2fri4ozpv.fsf@HIDDEN> Date: Sat, 19 Apr 2025 22:56:16 +0200 Message-ID: <m2r01ndg5r.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > Eli Zaretskii <eliz@HIDDEN> writes: > >> Are there any backward-incompatible changes with this? > > None I'm aware of. > >> Do all the tests still pass as well as they did before these changes? > > I got a SEGV in buffer-tests right now when I checked again that went > away an a second run. So I'll have to check that. SUMMARY OF TEST RESULTS ----------------------- Files examined: 530 Ran 8041 tests, 7765 results as expected, 0 unexpected, 276 skipped [scratch/text-index] gerd@mini 2025-04-19 22:51 Now fixed.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Sun, 20 Apr 2025 08:35:01 +0000 Resent-Message-ID: <handler.77924.B77924.174513806825288 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: monnier@HIDDEN, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174513806825288 (code B ref 77924); Sun, 20 Apr 2025 08:35:01 +0000 Received: (at 77924) by debbugs.gnu.org; 20 Apr 2025 08:34:28 +0000 Received: from localhost ([127.0.0.1]:44920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u6Q8B-0006Zo-K9 for submit <at> debbugs.gnu.org; Sun, 20 Apr 2025 04:34:27 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:56820) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u6Q89-0006ZZ-Q1 for 77924 <at> debbugs.gnu.org; Sun, 20 Apr 2025 04:34:26 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-43edecbfb94so33310055e9.1 for <77924 <at> debbugs.gnu.org>; Sun, 20 Apr 2025 01:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745138059; x=1745742859; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=TH2hoS2oGQcgBuXKJq7NKFRN4T7Zu8gWCvEwogdIpCc=; b=JRUt7mlqggMbOQ3C7oQTNFx1Fx0cJ/B0q0NSiU2ktEfS3sXeBMgrbYZXqDuNLBd9g6 MOgwCpCZVlz8UbMQuSVBndRhstn/uAJn+2mNP6GfEjFZDWs1rpL0qtXIIANCtpHPbBCi xRahbxw38TbxlthPLEXTH8XVjYnKgVKSeTrksUvPc2B2lbqxor5sVroA8StYi4OagX5H a2ZbG0j6WopAmymQc6bX5THf0ylMPhH+iq/H7uBxtSco2eW6a6eC2LCYzrz1BRYXGxb0 e7FWjeDRhvzsOGc0FWgNPAUH3LgykljhSkM6rJ4mQrVSvBT2hK6gP6lj5wgu9qYWBDRy 6NMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745138059; x=1745742859; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TH2hoS2oGQcgBuXKJq7NKFRN4T7Zu8gWCvEwogdIpCc=; b=nTXSKMS6xoUsNU1ooaRcZMqsSGDvQyIrEZf0Ln2CSTOVg1Um7bS5IC/9pCOvQzwUAM Y3PZJMH4oZrddv/jvQ4XLV9SNdevZ+eNvqV1JAprjokjdzp0IY6jSfe6Z84mksB9/sW3 eJBAm2zgBXVlaJTMcN/xVdz+ujd7NGf7wh/dcRIL9Q8nwJElrj/XoOY8LkS8J+aZV7bE H3bP3jBCs5Ghtb/09t6JEA3IcCHMVgcAvzYfdJyvzUSFs1ONZlj2CHXVLWExS3hdcHLi O4o66k9b1fjGpG1k+Uburu/n50kRMFMFZR+ZCVeXXAGGbKV+kaaaWV1qJ0bs3SIIBsdn 3k1w== X-Gm-Message-State: AOJu0YySSQ67RnMfqIOWSY3J7+R0Dfvpm9GR7UTHT5keyVBgoOTTEA1H B4iMOTctkOpzsyfo8zCwdZ0+jKNsgMZ5RnQwFmTgkyWF8BC3HpSI X-Gm-Gg: ASbGnctqJZtaMWS/+HUc4phxcNk1qODVqCHuBl0gLstBOCdiF9texxaJtQk8p9VySRD UuXYiF18FCp7C8d5oc81jXFMKh7P2GepA/JuY1S44tgztSFeFdJ7IZnr4KIeqOKaIJX0/sjCHe1 bF5uqfrt/kGletypFfyDfU7L1xXlX4CjXLndhWxWi/z9EnDPIqLb3QfcXuayKvVwvGb1Dzrp1h6 bfocX0t7hSqFbFAAy+nphWSA8zGDXLRXwYYOLG0bMtr/4IycTsQFETsb9zOelFzss5yfeDZVOSc kmBoFQc3rSxQ7nY7PM44l/RF/HgE/GpsSvRh1soNe2GZVlcdZLkRGh8Ic6bMcHlHyFsmMt6RV6s Ox3D4LN0RjazRMU0aG9YVw/gx14TIyno34DgjLv1M1pGm X-Google-Smtp-Source: AGHT+IHEQRVFUr7ZBe3VJHoQLi0qX0r5oAnDgX8/OQodcqxeHfsrpfKDf6OnonqIP/dlkcxbcQT/YQ== X-Received: by 2002:a05:600c:a143:b0:43d:878c:7c40 with SMTP id 5b1f17b1804b1-44076c9c6fbmr31452725e9.10.1745138059065; Sun, 20 Apr 2025 01:34:19 -0700 (PDT) Received: from pro2 (p200300e0b720a300c964490db7e76205.dip0.t-ipconnect.de. [2003:e0:b720:a300:c964:490d:b7e7:6205]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4206fasm8138747f8f.2.2025.04.20.01.34.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Apr 2025 01:34:18 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <m2r01ndg5r.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <86plh86rit.fsf@HIDDEN> <m2fri4ozpv.fsf@HIDDEN> <m2r01ndg5r.fsf@HIDDEN> Date: Sun, 20 Apr 2025 10:34:17 +0200 Message-ID: <m2y0vv2pva.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > >> Eli Zaretskii <eliz@HIDDEN> writes: >> >>> Are there any backward-incompatible changes with this? >> >> None I'm aware of. >> >>> Do all the tests still pass as well as they did before these changes? >> >> I got a SEGV in buffer-tests right now when I checked again that went >> away an a second run. So I'll have to check that. > > SUMMARY OF TEST RESULTS > ----------------------- > Files examined: 530 > Ran 8041 tests, 7765 results as expected, 0 unexpected, 276 skipped > [scratch/text-index] gerd@mini 2025-04-19 22:51 > > Now fixed. Commit message: --=-=-= Content-Type: application/octet-stream Content-Disposition: attachment; filename=text-index-change.log Content-Transfer-Encoding: base64 TmV3IG1hcmtlcnMsIHRleHQgaW5kZXgsIG1hcmtlciB2ZWN0b3JzIChidWcjNzc5MjQpCgpUaGlz IGNoYW5nZXMgdGhlIGltcGxlbWVudGF0aW9uIG9mIExpc3AgbWFya2Vycy4KCi0gTWFya2VycyBu byBsb25nZXIgZm9ybSBhIHNpbmdseS1saW5rZWQgbGlzdCwgdGhleSBhcmUgc3RvcmVkIGluIGEK ICBtYXJrZXIgdmVjdG9yIGluc3RlYWQgd2hpY2ggYWxsb3dzIE8oMSkgaW5zZXJ0aW9uIGFuZCBk ZWxldGlvbiBvZgogIG1hcmtlcnMuIChUaGUgaWRlYSBvZiBhIG1hcmtlciB2ZWN0b3IgaXMgZnJv bSB3aGF0IEkgZGlkIGluIGlnYy4gSW4gbXkKICBFbWFjcywgYm90aCBpZ2MgYW5kIG9sZCBHQyB1 c2UgdGhlIHNhbWUgbWFya2VyIHZlY3RvciBpbXBsZW1lbnRhdGlvbi4KICBUaGUgbmV3IG9uZSBp cyBkaWZmZXJlbnQgZnJvbSB0aGUgb25lIGluIGZlYXR1cmUvaWdjLikKCi0gTGlzcF9NYXJrZXIg ZG9lc24ndCBjb250YWluIHRoZSBjaGFyYWN0ZXIgcG9zaXRpb24gZGlyZWN0bHkuIEl0IGlzCiAg c3RvcmVkIGluIHRoZSBtYXJrZXIgdmVjdG9yIGluc3RlYWQuIFRoaXMgbGVhZHMgdG8gZmFzdGVy LAogIGNhY2hlLWZyaWVuZGx5LCBtYXJrZXIgcG9zaXRpb24gYWRqdXN0bWVudHMuCgotIE1hcmtl cnMgZG9uJ3QgY29udGFpbiBieXRlIHBvc2l0aW9ucy4gQnl0ZSBwb3NpdGlvbnMgYXJlIGNvbXB1 dGVkIHdoZW4KICBuZWVkZWQuIEJ5dGVwb3MgPC0+IGNoYXJwb3MgY29udmVyc2lvbiBhcmUgZG9u ZSB1c2luZyBhIHRleHQtaW5kZXgKICBkYXRhIHN0cnVjdHVyZS4gVGhpcyByZW1vdmVzIHRoZSBo ZXVyaXN0aWNzIGN1cnJlbnRseSB1c2VkIGluIG1hc3RlciwKICBhbmQgYWxsb3dzIHJlbW92aW5n IGJ5dGUgcG9zaXRpb25zIGZyb20gbWFya2Vycy4KClBsZWFzZSBzZWUgdGhlIGNvbW1lbnRzIGF0 IHRoZSBzdGFydCBvZiBtYXJrZXItdmVjdG9yLmMgYW5kIHRleHQtaW5kZXguYwpmb3IgbW9yZSBk ZXRhaWxzLiBBbHNvIHNlZSB0aGUgdGhyZWFkKHMpIG9uIGVtYWNzLWRldmVsIHdpdGggU3RlZiBh biBtZS4KCiogc3JjL21hcmtlci12ZWN0b3IuW2NoXSwgc3JjL3RleHQtaW5kZXguW2NoXTogTmV3 IGZpbGVzLgoqIHRlc3Qvc3JjL3RleHQtaW5kZXgtdGVzdHMuZWw6IE5ldyBmaWxlLgoKKiBzcmMv TWFrZWZpbGUuaW4gKGJhc2Vfb2JqKTogQWRkIG1hcmtlci12ZWN0b3IubyBhbmQKdGV4dC1pbmRl eC5vLgoKKiBzcmMvbGlzcC5oIChnY192c2l6ZSk6IE5ldyBmdW5jdGlvbi4KKHN0cnVjdCBMaXNw X01hcmtlcik6IFJlbW92ZSBwb3NpdGlvbnMgYW5kIG5leHQgcG9pbnRlci4gQWRkCm1hcmtlciB2 ZWN0b3IgaW5kZXguCgoqIHNyYy9hbGxvYy5jIChGbWFrZV9tYXJrZXIsIGJ1aWxkX21hcmtlcik6 IEFkYXB0IHRvIExpc3BfTWFya2VyCmNoYW5nZXMuCihtYXJrX2J1ZmZlcik6IFNldCBtYXJrZXIg dmVjdG9yIG1hcmtlZC4KKHVuY2hhaW5fZGVhZF9tYXJrZXJzKTogTmV3IGltcGxlbWVudGF0aW9u LgoKKiBzcmMvYnVmZmVyLmg6IChzdHJ1Y3QgYnVmZmVyX3RleHQpOiBBZGQgdGV4dCBpbmRleCBh bmQgbWFya2VyCnZlY3Rvci4KCiogc3JjL2J1ZmZlci5jOiAoRmdldF9idWZmZXJfY3JlYXRlKTog SW5pdGlhbGl6ZSBidWZmZXIncyB0ZXh0CmluZGV4IGFuZCBtYXJrZXIgdmVjdG9yLgooY2xvbmVf cGVyX2J1ZmZlcl92YWx1ZXMpOiBHZXQvc2V0IGNoYXJwb3MgdmlhIG1hcmtlciB2ZWN0b3IuCihy ZWNvcmRfYnVmZmVyX21hcmtlcnMpOiBDYWxsIHNldF9tYXJrZXJfYm90aCB3aXRob3V0IGJ5dGVw b3MuCihGbWFrZV9pbmRpcmVjdF9idWZmZXIpOiBJbml0aWFsaXplIG93biB0ZXh0J3MgaW5kZXgg dG8gTlVMTC4KQ2FsbCBidWlsZF9tYXJrZXIgd2l0aG91dCBieXRlcG9zLgooRmtpbGxfYnVmZmVy KTogVXNlIERPX01BUktFUlMgYW5kIG1hcmtlcl92ZWN0b3JfcmVzZXQuIEZyZWUgdGV4dAppbmRl eC4KKHN3YXBfYnVmZmVyX292ZXJsYXlzKTogVXNlIERPX01BUktFUlMuCihGc2V0X2J1ZmZlcl9t dWx0aWJ5dGUpOiBVc2UgRE9fTUFSS0VSUwoKKiBzcmMvY2FsbGludC5jIChGY2FsbF9pbnRlcmFj dGl2ZWx5KTogQ2FsbCBzZXRfbWFya2VyX2JvdGgKd2l0aG91dCBieXRlcG9zLgoKKiBzcmMvY29k aW5nLmMgKGRlY29kZV9jb2Rpbmdfb2JqZWN0KTogVXNlIERPX01BUktFUlMuCihkZWNvZGVfY29k aW5nX29iamVjdCk6IEdldC9zZXQgY2hhcnBvcyB2aWEgbWFya2VyIHZlY3Rvci4gVXNlCkRPX01B UktFUlMuCgoqIHNyYy9jb21wb3NpdGUuYyAoYXV0b2NtcF9jaGFycyk6IERvbid0IHBhc3MgYnl0 ZXBvcyB0bwpidWlsZF9tYXJrZXIuCgoqIHNyYy9kaXNwZXh0ZXJuLmggKFNFVF9NQVJLRVJfRlJP TV9URVhUX1BPUyk6RG9uJ3QgcGFzcyBieXRlcG9zCnRvIHNldF9tYXJrZXJfYm90aC4KCiogc3Jj L2VkaXRmbnMuYyAoRnBvaW50X21hcmtlciwgRnBvaW50X21pbl9tYXJrZXIpOgooRnBvaW50X21h eF9tYXJrZXIpOiBEb24ndCBidWlsZF9tYXJrZXIgd2l0aCBieXRlcG9zLgooc2F2ZV9yZXN0cmlj dGlvbl9zYXZlXzEsIHNhdmVfcmVzdHJpY3Rpb25fcmVzdG9yZV8xKToKQ2hhbmdlIHRvIG5vdCB1 c2UgYnl0ZXBvcy4gVXNlIERPX01BUktFUlMuCih0cmFuc3Bvc2VfbWFya2Vycyk6Cih0cmFuc3Bv c2VfbWFya2Vycyk6Cih0cmFuc3Bvc2VfbWFya2Vycyk6CgoqIHNyYy9lbWFjcy5jIChtYWluKTog Q2FsbCBpbml0X3RleHRfaW5kZXggYW5kCnN5bW5zX29mX3RleHRfaW5kZXguCgoqIHNyYy9mbnMu YyAoaW50ZXJuYWxfZXF1YWxfMSk6IERvbid0IHVzZSBtYXJrZXIgYnl0ZXBvcy4KKHZhbHVlX2Nt cCk6IEJldCBjaGFycG9zIHZpYSBtYXJrZXIgdmVjdG9yLgooc3hoYXNoX29iaik6IERvbid0IHVz ZSBtYXJrZXIgYnl0ZXBvcy4KCiogc3JjL2luZGVudC5jIChjaGVja19kaXNwbGF5X3dpZHRoLCBy ZXN0b3JlX3dpbmRvd19idWZmZXIpOgooRnZlcnRpY2FsX21vdGlvbik6IENhbGwgc2V0X21hcmtl cl9ib3RoIHdpdGhvdXQgYnl0ZXBvcy4KCiogc3JjL2luc2RlbC5jIChhZGp1c3Rfc3VzcGVuZF9h dXRvX2hzY3JvbGwpOiBHZXQgY2hhcnBvcyB2aWEgbWFya2VyIHZlY3Rvci4KKGFkanVzdF9tYXJr ZXJzX2Zvcl9kZWxldGUsIGFkanVzdF9tYXJrZXJzX2Zvcl9pbnNlcnQpOgooYWRqdXN0X21hcmtl cnNfZm9yX3JlcGxhY2UpOiBVc2UgdGV4dCBpbmRleCBmdW5jdGlvbnMuCihjb3VudF9ieXRlcyk6 IFJlbW92ZWQuCihhZGp1c3RfbWFya2Vyc19ieXRlcG9zKTogUmVtb3ZlIGNvZGUgYWRqdXN0aW5n IGJ5dGVwb3MuCgoqIHNyYy9scmVhZC5jIChyZWFkY2hhciwgdW5yZWFkY2hhcik6IEdldC9zZXQg Y2hhcnBvc3ZpYSBtYXJrZXIKdmVjdG9yLgoKKiBzcmMvbWFya2VyLmMgKGNhY2hlZF9jaGFyb3Ms IGNhY2hlZF9ieXRlcG9zLCBjYWNoZWRfYnVmZmVyKToKKGNhY2hlZF9tb2RpZmYpOiBSZW1vdmVk LgooY2xlYXJfY2hhcnBvc19jYWNoZSk6IEVtcHRpZWQuCihidWZfYnl0ZXBvc190b19jaGFycG9z LCBidWZfY2hhcnBvc190b19ieXRlb2lzKTogVXNlIHRleHQKaW5kZXguIFJlbW92ZSBvbGQgaW1w bGVtZW50YXRpb24uCihGbWFya2VyX3Bvc2l0aW9uLCBGbWFya2VyX2xhc3RfcG9zaXRpb24pOiBH ZXQgY2hhcnBvcyB2aWEgbWFya2VyIHZlY3Rvci4KKGF0dGFjaF9tYXJrZXIpOiBSZW1vdmUgYnl0 ZXBvcyBwYXJhbWV0ZXIuCihzZXRfbWFya2VyX2ludGVybmFsKTogRG9uJ3QgdXNlIGJ5dGUgcG9z aXRpb25zLgooc2V0X21hcmtlcl9ib3RoKTogUmVtb3ZlIGJ5dGVwb3MgcGFyYW1ldGVyLiBEb24n dCBhY3Qgb24gYnl0ZXBvcy4KKHNldF9tYXJrZXJfcmVzdHJpY3RlZF9ib3RoKTogRG9uJ3QgdXNl IGJ5dGUgcG9zaXRpb25zLgooc2V0X21hcmtlcl9yZXN0cmljdGVkX2JvdGgpOiBSZW1vdmUgYnl0 ZXBvcyBwYXJhbWV0ZXIuCih1bmNoYWluX21hcmtlcik6IFVzZSBtYXJrZXIgdmVjdG9yLgoobWFy a2VyX3Bvc2l0aW9uLCBtYXJrZXJfYnl0ZV9wb3NpdGlvbik6IFVzZSBtYXJrZXIgdmVjdG9yLgoK KiBzcmMvcGR1bXBlci5jIChkdW1wX21hcmtlcik6IEFkYXB0IHRvIGNoYW5nZXMgaW4gTGlzcF9N YXJrZXIuCihkdW1wX2J1ZmZlcik6IEFkYXB0IHRvIGNoYW5nZXMgaW4gc3RydWN0IGJ1ZmZlcl90 ZXh0LgoKKiBzcmMvcHJpbnQuYyAocHJpbnRfZmluaXNoKTogQ2FsbCBzZXRfbWFya2VyX2JvdGgg d2l0aG91dCBieXRlcG9zLgoKKiBzcmMvcHJvY2Vzcy5jICh1cGRhdGVfcHJvY2Vzc19tYXJrLCBy ZWFkX3Byb2Nlc3Nfb3V0cHV0X2FmdGVyX2luc2VydCk6CihGaW50ZXJuYWxfZGVmYXVsdF9wcm9j ZXNzX3NlbnRpbmVsKTogQ2FsbCBzZXRfbWFya2VyX2JvdGggd2l0aG91dApieXRlcG9zLgoKKiBz cmMvdW5kby5jIChyZWNvcmRfbWFya2VyX2FkanVzdG1lbnRzKTogR2V0IGNoYXJwb3MgdmlhIG1h cmtlcgp2ZWN0b3IuCgoqIHNyYy93aW5kb3cuYyAoc2VsZWN0X3dpbmRvd18xLCB3aW5kb3dfcG9p bnQpOgooRmRlbGV0ZV9vdGhlcl93aW5kb3dzX2ludGVybmEsIHNldF93aW5kb3dfYnVmZmVyKToK KHRlbXBfb3V0cHV0X2J1ZmZlcl9zaG93LCBGc3BsaXRfd2luZG93X2ludGVybmFsKToKKHdpbmRv d19zY3JvbGxfZm9yX2xvbmdfbGluZXMsIHdpbmRvd19zY3JvbGxfcGl4ZWxfYmFzZWQpOgood2lu ZG93X3Njcm9sbF9saW5lX2Jhc2VkLCBzY3JvbGxfY29tbWFuZCk6CihGcmVjZW50ZXIsIEZtb3Zl X3RvX3dpbmRvd19saW5lLCBGc2V0X3dpbmRvd19jb25maWd1cmF0aW9uKToKKEZzZXRfd2luZG93 X2NvbmZpZ3VyYXRpb24sIEZzZXRfd2luZG93X2NvbmZpZ3VyYXRpb24pOgooc2F2ZV93aW5kb3df c2F2ZSk6IERvbid0IHBhc3MKYnl0ZXBvcyBwYXJhbSB0byBzZXRfbWFya2VyXyogZnVuY3Rpb25z LCBidWlsZF9tYXJrZXIgZXRjLgoKKiBzcmMveGRpc3AuYyAoRmJ1ZmZlcl90ZXh0X3BpeGVsX3Np emUsICBtZXNzYWdlX2RvbG9nKToKKHdpdGhfZWNob19hcmVhX2J1ZmZlciwgdW53aW5kX3dpdGhf ZWNob19hcmVhX2J1ZmZlcik6CihyZXNpemVfbWluaV93aW5kb3csIGZvcm1hdF9tb2RlX2xpbmVf dW53aW5kX2RhdGEpOgoocmVkaXNwbGF5X3dpbmRvdywgcmVkaXNwbGF5X3dpbmRvdywgcmVkaXNw bGF5X3dpbmRvdyk6Cih0cnlfd2luZG93KTogRG9uJ3QgdXNlIG1hcmtlciBieXRlcG9zLCBwYXNz IGJ5dGVwb3MgcGFyYW0gdG8Kc2V0X21hcmtlcl8qIGZ1bmN0aW9ucywgZXRjLgo= --=-=-=--
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Mon, 21 Apr 2025 04:42:02 +0000 Resent-Message-ID: <handler.77924.B77924.174521048528223 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: monnier@HIDDEN, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174521048528223 (code B ref 77924); Mon, 21 Apr 2025 04:42:02 +0000 Received: (at 77924) by debbugs.gnu.org; 21 Apr 2025 04:41:25 +0000 Received: from localhost ([127.0.0.1]:58583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u6iyD-0007L7-2Y for submit <at> debbugs.gnu.org; Mon, 21 Apr 2025 00:41:25 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:55714) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u6iy9-0007Kr-HJ for 77924 <at> debbugs.gnu.org; Mon, 21 Apr 2025 00:41:22 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-43cebe06e9eso29897075e9.3 for <77924 <at> debbugs.gnu.org>; Sun, 20 Apr 2025 21:41:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745210475; x=1745815275; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a4yctWQ+K5GV/JUIZJYXyGh+x5gT0UW9J6vejl6I/Ko=; b=ko1DiD3xUQBF4QVROZi2FXNu/Y8J3b/E6nRZ+dQcuL/iIdfSdQSKoUKPhofKYIyjRn z2mXFsFSzrKjKgJ3UB99fnX3wU4EkwtS7wAQ2zhxCMr+5cPN8fT+dfKAcx8021l7jRmd d6Cb3Wyn9GLFBKHRL8VSMe7ov3KOyXgit0wZcCTdbW1aiBo9hRQAZ/WHyJt0yopAJJwi 2qyveVWN5ozaGTVbCnbKYPWy5tln6g0plPH225iuDM53sc5oLKheCqkimmYh+moPJ1zH bbSlf47KXkzn+Mhcw9/VFxLL4cCjV3rL7yXwj/LjIVLef5EL6xT6YYNNscpAiI1Zy2GV aa0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745210475; x=1745815275; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=a4yctWQ+K5GV/JUIZJYXyGh+x5gT0UW9J6vejl6I/Ko=; b=vvxXTd6iIVxlWFAXGhxC5JsVJVtxnbS8CzLGhKodmhy4pnQNgpqmSyIjEIIqSv9GxE FDrykeO86yQ+suJhkpxeWexzov4YMBpj3xFRTJ26I1TrMREV48E4Wa72+u3o9ejhomH6 keNbeH1CT5WJ5XrhZAs62wj5Pe3cHjINBOiJJLYAzrDP6yGcq8rEMnuV0c+Wr2Lotyf1 EhOpHkDPEUIcG4CEVuanHS8LlsfmphCZy+ulF+sz21nObd33h1WyBviHyqqOQTY2kjRR fRIoUS4t1FhWwd4eAodvKhW0b1Yas/59FCR1t3WneauPjomA0i9F6mB1LY4v/LptF24/ RQaQ== X-Gm-Message-State: AOJu0YyXQGD6q++SzatlHooC3Jx32R4WfjZNvyHHPHAfACXM8LSfs54M 2pLxsRYgZxm0bPI4y5Bxb+deptBbAel9teKE8I48rcQAagsO4QS8SAQmSA== X-Gm-Gg: ASbGncu/P4IIZS9FMRaGY7w3wmmOCzeS5qDc9d28lq3vA5LMQGYXFVieboGdnZ/B+Zf 5zr+Uc+LOu+wPdOjcdN4NQkLBwcfvU0MRxziRoTull/Yu1tdzhJKfZV1MMEugHntLN0OtuQ46ZA PtHPOsGY54/MiAKoi+onPE3VgEorAqc3UmDGQE7B/7EV04MpEXZ1mzY6lOinVkG1b1VPmqM1TcB BwD+ZudVDga/2581ovBP+cn65QDbDwbtPdFx00RbR6GLY1tDe3Qlymt9GIFDc/1cTEbW6fH5ujY FaWMJRTduVxALRUiZjcro03c9vwPl/rDAZg31zDp3NRR5Mv4EP4SHnC5DZAUnfPKKQ/HUxqj6FU Fa6fmKkDqSl9nhc5n0FwzjP8qKFjpODEERA3bal8a5wnQESw= X-Google-Smtp-Source: AGHT+IH6QxXfhY7Jvxvgixnjl9phvJiPV0Gef5HHfKJFicazE1K+s8zAobBWnPgvZAGs0zdB8lw7cQ== X-Received: by 2002:a05:600c:1c9d:b0:43b:ce36:7574 with SMTP id 5b1f17b1804b1-4406ab93b95mr84252345e9.11.1745210475142; Sun, 20 Apr 2025 21:41:15 -0700 (PDT) Received: from pro2 (p200300e0b728b60058490051f8c259a0.dip0.t-ipconnect.de. [2003:e0:b728:b600:5849:51:f8c2:59a0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4406d5bbcfesm120509575e9.23.2025.04.20.21.41.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Apr 2025 21:41:14 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <m2y0vv2pva.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <86plh86rit.fsf@HIDDEN> <m2fri4ozpv.fsf@HIDDEN> <m2r01ndg5r.fsf@HIDDEN> <m2y0vv2pva.fsf@HIDDEN> Date: Mon, 21 Apr 2025 06:41:13 +0200 Message-ID: <m2plh6dt3q.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > >> Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: >> >>> Eli Zaretskii <eliz@HIDDEN> writes: >>> >>>> Are there any backward-incompatible changes with this? >>> >>> None I'm aware of. >>> >>>> Do all the tests still pass as well as they did before these changes? >>> >>> I got a SEGV in buffer-tests right now when I checked again that went >>> away an a second run. So I'll have to check that. >> >> SUMMARY OF TEST RESULTS >> ----------------------- >> Files examined: 530 >> Ran 8041 tests, 7765 results as expected, 0 unexpected, 276 skipped >> [scratch/text-index] gerd@mini 2025-04-19 22:51 >> >> Now fixed. > > Commit message: A warning: the branch currently contains a bug that can lead to a stack overflow that looks like this: (lldb) bt * thread #1, queue =3D 'com.apple.main-thread', stop reason =3D EXC_BAD_ACC= ESS (code=3D2, address=3D0x16b0ffff0) frame #0: 0x000000010451bc38 emacs`ensure_charpos_indexed(b=3D0x0000000= 107280d28, charpos=3D4415031360) at text-index.c:356 frame #1: 0x000000010451bb10 emacs`text_index_charpos_to_bytepos(b=3D0x= 0000000107280840, charpos=3D25980) at text-index.c:621:3 frame #2: 0x00000001046cc1d0 emacs`marker_vector_bytepos(m=3D0x00000001= 07280d28) at marker-vector.c:323:10 frame #3: 0x0000000104529aec emacs`marker_byte_position(marker=3D(struc= t Lisp_Marker *) $52 =3D 0x0000000107280d28) at marker.c:376:29 frame #4: 0x000000010451cfb4 emacs`BUF_PT_BYTE(buf=3D0x0000000107280840= ) at buffer.h:909:6 !gud 909:6:/Users/gerd/emacs/github/cl-packages/src/buffer.h * frame #5: 0x000000010451bdec emacs`narrow_charpos_bounds(b=3D0x00000001= 07280840, prev=3D0x000000016b100178, next=3D0x000000016b100168, charpos=3D2= 5980) at text-index.c:549:42 frame #6: 0x000000010451bb78 emacs`text_index_charpos_to_bytepos(b=3D0x= 0000000107280840, charpos=3D25980) at text-index.c:628:23 frame #7: 0x00000001046cc1d0 emacs`marker_vector_bytepos(m=3D0x00000001= 07280d28) at marker-vector.c:323:10 frame #8: 0x0000000104529aec emacs`marker_byte_position(marker=3D(struc= t Lisp_Marker *) $52 =3D 0x0000000107280d28) at marker.c:376:29 frame #9: 0x000000010451cfb4 emacs`BUF_PT_BYTE(buf=3D0x0000000107280840= ) at buffer.h:909:6 frame #10: 0x000000010451bdec emacs`narrow_charpos_bounds(b=3D0x0000000= 107280840, prev=3D0x000000016b1002c8, next=3D0x000000016b1002b8, charpos=3D= 25980) at text-index.c:549:42 frame #11: 0x000000010451bb78 emacs`text_index_charpos_to_bytepos(b=3D0= x0000000107280840, charpos=3D25980) at text-index.c:628:23 frame #12: 0x00000001046cc1d0 emacs`marker_vector_bytepos(m=3D0x0000000= 107280d28) at marker-vector.c:323:10 frame #13: 0x0000000104529aec emacs`marker_byte_position(marker=3D(stru= ct Lisp_Marker *) $52 =3D 0x0000000107280d28) at marker.c:376:29 frame #14: 0x000000010451cfb4 emacs`BUF_PT_BYTE(buf=3D0x000000010728084= 0) at buffer.h:909:6 The reason for that is that functions like BUF_PT (and maybe others) are "too smart", in the case of indirect buffers, for what I need in the text index. I'll fix that a bit later today.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Mon, 21 Apr 2025 05:42:02 +0000 Resent-Message-ID: <handler.77924.B77924.174521411517250 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: monnier@HIDDEN, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174521411517250 (code B ref 77924); Mon, 21 Apr 2025 05:42:02 +0000 Received: (at 77924) by debbugs.gnu.org; 21 Apr 2025 05:41:55 +0000 Received: from localhost ([127.0.0.1]:58973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u6juk-0004U8-Uv for submit <at> debbugs.gnu.org; Mon, 21 Apr 2025 01:41:55 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:58800) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u6juh-0004TZ-UO for 77924 <at> debbugs.gnu.org; Mon, 21 Apr 2025 01:41:52 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-43ce71582e9so29318035e9.1 for <77924 <at> debbugs.gnu.org>; Sun, 20 Apr 2025 22:41:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745214106; x=1745818906; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F6n5TN1PKLlo04xHTY14abai59SWJMtQ/1bVxx0oy8A=; b=V8ez3hK2hGlaIfZDnNFATHz7DZcSMi3NSkNGCALCZKbHHLfng2lkVw922/3iIPuCkm vfVi0V13ftCk0r9grzxDY/mZYPdtfpXHFwdoU4IScCLzub+H1ppKRuj1AtKg1lkrH5ZC 80wuEZc98YED0B8PRHntd/rjSZpkBfrICOlAvmJOuECizIdFLMKayHug7NyDvtCHaQWq s7+7MwJfFPax7qsog0CujOHVsisxiP2d7NUasiw/GTQsi6Vm7juCzPlRdVf82+tO7IDO vZs3iG92+yBhXcqRUI2jXBx4BqpCMcH0Fwd5f/yMbdQN/FilrrlM94rNRTuRyzKMkQYQ n8Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745214106; x=1745818906; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=F6n5TN1PKLlo04xHTY14abai59SWJMtQ/1bVxx0oy8A=; b=rm2ylhY3gnZ0Jj/elmDjhCjxeS005VEC+BB4wl0d60I7CRzGla5B/K3t6T215hGmQr A6h3+Gpte2YwcmvtR+iv/e/3HOpqqJDbl5o4hDQxAVVZFYLtvGO96lbGnvsfOqOFM8Gt PGxMs48WDV90ZwifpqDhffDDYyLDz14n49t6V0dXEqZcXmS3fu4pZY6tp7mwFKEy9b7Q hf4L3bzXLxMZeLnSLR3alifp8/qpmh3pK7ZnDYnp4cuaAGtnIDbrBPcIhBATLbQwLbq/ 3Q3vz5NBvgOOhjOyRL376STfgdlyOTIinFV+Ym+HAtfzAhSLWvE14F0O9P/k4ex78f21 nhJA== X-Gm-Message-State: AOJu0YyTTmwcL6jvfO1MCU8pcyPr9FVMPI6qfqDll427Bj3VTPw0o+Et DYsguw9zFALKHrM6B7Ko1OvVTrqiJsmvHM1zTRREJlNUZuVtvKHm X-Gm-Gg: ASbGncttXsBGPF9K7JdQHJ1ln99+gDzjtOLe1b+E/6E78Nva1TdfkjHa495ekYiGq60 Lp2c8bPt/5O9Qe5xLnDG79XQDWKoNqginNJvZXIWTwBoxPYwK8MkjQprLWlSieSPsQnBMlVBG3a tjC1dhNZEr6nGo9eJ+r/yZgqC1n7MYFnm9eNn+7M1p7sEQrpDfiP1HEV8nVpWG2bGR4bcq/JORC RsGccftMQPSaO47rwr4O75Ei9t6bUF0Ywhec6aryK5qO94b8hPXDL8IWfCfkqjDZ+S949EZ2biv +RNy7UxaLbij49NrL4SddRbN1BLmJMorc9NhvzGIB7/fgA4DVClYrXBf49C4L/uV1liewaGgAjK qH0aSkjwr8KbdIQM3RftLmpxAVck06f3oX2sh/EysIw== X-Google-Smtp-Source: AGHT+IFNxg7VP/h/z45CezG4Ozg3U3UH1pW4xZBCaCnTOuVrlOqHp5ZNkmimdwdDg3d/H40nADtTAg== X-Received: by 2002:a05:6000:40db:b0:390:fb37:1bd with SMTP id ffacd0b85a97d-39efbacf35fmr8273929f8f.46.1745214105666; Sun, 20 Apr 2025 22:41:45 -0700 (PDT) Received: from pro2 (p200300e0b728b60058490051f8c259a0.dip0.t-ipconnect.de. [2003:e0:b728:b600:5849:51:f8c2:59a0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4332c1sm10579424f8f.27.2025.04.20.22.41.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Apr 2025 22:41:45 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <m2plh6dt3q.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <86plh86rit.fsf@HIDDEN> <m2fri4ozpv.fsf@HIDDEN> <m2r01ndg5r.fsf@HIDDEN> <m2y0vv2pva.fsf@HIDDEN> <m2plh6dt3q.fsf@HIDDEN> Date: Mon, 21 Apr 2025 07:41:43 +0200 Message-ID: <m2ldrudqaw.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > I'll fix that a bit later today. Done.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Richard Stallman <rms@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Mon, 21 Apr 2025 18:38:03 +0000 Resent-Message-ID: <handler.77924.B77924.17452606326865 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gerd =?UTF-8?Q?M=C3=83=C2=B6llmann?= <gerd.moellmann@HIDDEN> Cc: monnier@HIDDEN, 77924 <at> debbugs.gnu.org Reply-To: rms@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.17452606326865 (code B ref 77924); Mon, 21 Apr 2025 18:38:03 +0000 Received: (at 77924) by debbugs.gnu.org; 21 Apr 2025 18:37:12 +0000 Received: from localhost ([127.0.0.1]:38539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u6w12-0001me-4S for submit <at> debbugs.gnu.org; Mon, 21 Apr 2025 14:37:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44648) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <rms@HIDDEN>) id 1u6w0y-0001mO-2W for 77924 <at> debbugs.gnu.org; Mon, 21 Apr 2025 14:37:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <rms@HIDDEN>) id 1u6w0s-0004D9-L9; Mon, 21 Apr 2025 14:37:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Date:References:Subject:In-Reply-To:To:From: mime-version; bh=5xS9Dffv14cSATr9YgccjLjA+b3sqqTPiZ/V0+r/VD0=; b=gZGw+FZzCLZ4 zSMTj/+/OdH5+NFEVnPd1bBRo2c0sar9GfgpMH0wE6uNcdA002OMPG+T9OyuQfFAFH0cQjcK+4enc GmbARUP6qWiYlpcp9yppdJ/0pvMArkF02YBFUr2+u+EaXW0MTp3TKp3KeAyHvdZX8EMPOXqJCBZho NZX7speobTnw15tSLit5cS/V9xMue+Ru7TyA1G99Ti178ZIM2cy+jnIjnhQ7GkPq4tFaw028SUAXU dn6b1KyQa/PUmSmdaUxW13/nwUDHLPFe69kxGgh4lb4dIEzNOSLEC20uyMgnd0OGbhcw0doeyJiHq 8wJlNq8tuBJWvadbpLZnCw==; Received: from rms by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from <rms@HIDDEN>) id 1u6w0r-00055o-ST; Mon, 21 Apr 2025 14:37:01 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman <rms@HIDDEN> In-Reply-To: <m2jz7gp25p.fsf@HIDDEN> (message from Gerd =?UTF-8?Q?M=C3=83=C2=B6llmann?= on Sat, 19 Apr 2025 18:05:38 +0200) References: <m2jz7gp25p.fsf@HIDDEN> Message-Id: <E1u6w0r-00055o-ST@HIDDEN> Date: Mon, 21 Apr 2025 14:37:01 -0400 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] The one thing I worry about, regarding this new data structure, is that allocation of the vectors could get troblesome wnet there are many markers in a buffer. I don't know whether that theoretical problem makes a big difference in practice. The new scheme may be better. I just suggest looking at this question. -- Dr Richard Stallman (https://stallman.org) Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org)
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Stefan Kangas <stefankangas@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Tue, 22 Apr 2025 02:30:02 +0000 Resent-Message-ID: <handler.77924.B77924.174528899924710 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, 77924 <at> debbugs.gnu.org Cc: Stefan Monnier <monnier@HIDDEN> Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174528899924710 (code B ref 77924); Tue, 22 Apr 2025 02:30:02 +0000 Received: (at 77924) by debbugs.gnu.org; 22 Apr 2025 02:29:59 +0000 Received: from localhost ([127.0.0.1]:42016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u73OZ-0006QS-8t for submit <at> debbugs.gnu.org; Mon, 21 Apr 2025 22:29:59 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:46517) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1u73OW-0006Q6-0k for 77924 <at> debbugs.gnu.org; Mon, 21 Apr 2025 22:29:57 -0400 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5f3f04b5dbcso6326662a12.1 for <77924 <at> debbugs.gnu.org>; Mon, 21 Apr 2025 19:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745288990; x=1745893790; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=LtugAM+2soJLY6Vo5WyLZZN6rdXf3MY443IWnAR+la0=; b=HcodGUEKfRkKg1OuKbqr2ZX8EkFQYsuuFdXX5Zk4dcuwFi+J8bWXQ4hhTZXWiQocRF I6wY21cuHo2KH8muGGCERHreC9/mdV7/GuYMoChMGvlSrcByH1hQSrm6CPLI6JLf+STh wF1arthN7mq8EwvaMJbJvJYGP+SmHOgfpnc4kYZkwDyYk4y5olC8+qg+fFJs4exgb1VJ E6TERmkXGd+XrbyavjnktDYBFUo7PETxSVBOZQb+/F2KEvzX3MqJt5g+qBG4PsgAbc+G 8G0yk6Kj4vUkP0lOPVECsEIJHIL3xkrQ/jIXfnCedcUwtVaJJyKffAeyne/0pXq5JJOR 2aMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745288990; x=1745893790; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LtugAM+2soJLY6Vo5WyLZZN6rdXf3MY443IWnAR+la0=; b=InoLe6Nw5DJ2742ZgN+jZzRgGY1/doBbVZ+xNzgaIH6pPGNxFm6JlcKhWhA8CAh0Ty zTXWziuS1gQ5XLtep1RUkxAsKLcQwaVu5eVX6z52SPApX0ALLz4d2iEHANeEMfIsBgYK LEVkIv/ijs9qZ6aHW5H4t+5uAIi8hz7GAEmPFBTVI1a765uNjV3SevWbXGELimL7fS3A 5RHdFZo4NnqSctYyQn+guQ7Xqth5y6Rczn1tc64+OBGMKtYHpo1X6NGNUV15+//PofxU NPMFFGGW1WkJwxns+7pXSN5qVFDKwNbKpFSM4CqVnq2EWnw2h/PE9HWuNOJCzkUCvoqh zDCQ== X-Forwarded-Encrypted: i=1; AJvYcCVOUHyVpII3jYBdV4TyNVYxCnxPK0g78YvMNpLU/UBJucmw1MKHCrpO9SzJu3oEhM093iiUuQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yza5uuXVWAEOsRkdy0QFZek50cBMR1wfH/5gVSRLiYdsBMP+ki0 Db+N92PCwd3puMhojmyunMZlORhzFF7p67KOXo/mS+JobZBBL+ZpxJGLAiK6kTEVJ+8/IoKcsyi d+VtIt2taBYBmuLsTxlQhpfrzWEE7SwnP X-Gm-Gg: ASbGncsfSGtHlO6vGe5Ae3XpQQqutFz6yvv880G6owPX3aUMzAN8lM1DCX3UTKpv13+ 87RdY9zIdYx48oyGt3xeMzHidnsYczNivTaN/jX4dUtSd+8VA+SaEb9ha5DH+9wphhucVZSdgq3 e7TGSWGPAdXoN/LsoQtd2bcOIS X-Google-Smtp-Source: AGHT+IEk7Gfbl0OniHnOZ1VkCJy3qesbBCbCkyNIBJ2ely3f6kfOWFnfu1cdvrbJPdA307+6DywYI0k99uOTpCPSBjI= X-Received: by 2002:a05:6402:2356:b0:5f6:21a4:61d5 with SMTP id 4fb4d7f45d1cf-5f62857414dmr11380628a12.17.1745288989730; Mon, 21 Apr 2025 19:29:49 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 21 Apr 2025 22:29:47 -0400 Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 21 Apr 2025 22:29:47 -0400 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <m2jz7gp25p.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> MIME-Version: 1.0 Date: Mon, 21 Apr 2025 22:29:47 -0400 X-Gm-Features: ATxdqUFqPQGYNq0kzbhaE9F0TIBWpuuS7qnAH3sIfvyBsmsHLRu8SaiBzpMbiaw Message-ID: <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > This is about the branch scratch/text-index on savannah, which is a port > of what I have in my Emacs. > > The branch changes the implementation of Lisp markers. > > - Markers no longer form a doubly-linked list, they are stored in a > marker vector instead which allows O(1) insertion and deletion of > markers. (The idea of a marker vector is from what I did in igc. In my > Emacs, both igc and old GC use the same marker vector implementation. > The new one is different from the one in feature/igc.) > > - Lisp_Marker doesn't contain the character position directly. It is > stored in the marker vector instead. This leads to faster, > cache-friendly, marker position adjustments. > > - Markers don't contain byte positions. Byte positions are computed when > needed. Bytepos <-> charpos conversion are done using a text-index > data structure. This removes the heuristics currently used in master, > and allows removing byte positions from markers. > > In summary, I'd say performance is good, to say the least, in many cases > better, and it fixes corner cases leading the abysmal performance in > current master. This sounds great. I pushed a couple of typo fixes while reading the patches, please use them as you see fit (squash, etc.). - Any chance you could add a comment explaining how you arrived at text_index_interval=3D4*1024? If it's arbitrarily chosen, adding a comment to that effect might be useful. - Maybe rename `text-index-interval` to `text-index--interval` (to indicate that it's internal)? - I guess `use-text-index` can be removed? > Please see the comments at the start of marker-vector.c and text-index.c > for more details. Also see the thread(s) on emacs-devel with Stef an me. For posterity, I guess that would be: Re: Question about region caches https://lists.gnu.org/r/emacs-devel/2025-03/msg01382.html PS. BTW, a small procedural thing. Instead of merging master into a scratch/ branch, I recommend deleting the branch, rebasing it on master, and then pushing it again. This way, when we later merge it into master, we avoid the merge commits, and the history is kept clean and more easily reviewable. Not the end of the world either way, but something to consider.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Tue, 22 Apr 2025 04:13:01 +0000 Resent-Message-ID: <handler.77924.B77924.174529513129786 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas <stefankangas@HIDDEN> Cc: Stefan Monnier <monnier@HIDDEN>, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174529513129786 (code B ref 77924); Tue, 22 Apr 2025 04:13:01 +0000 Received: (at 77924) by debbugs.gnu.org; 22 Apr 2025 04:12:11 +0000 Received: from localhost ([127.0.0.1]:42737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u74zT-0007kL-0t for submit <at> debbugs.gnu.org; Tue, 22 Apr 2025 00:12:11 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:51615) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u74zQ-0007k7-Hf for 77924 <at> debbugs.gnu.org; Tue, 22 Apr 2025 00:12:09 -0400 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3995ff6b066so2407864f8f.3 for <77924 <at> debbugs.gnu.org>; Mon, 21 Apr 2025 21:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745295122; x=1745899922; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=hVIv5zgmPHgMvarwMS47WoU8pTy3QGZRk7haxdG839w=; b=fD+qj8C8ptm2Le/g+KNgchzXXPFVJ35HNqQ3EJZH6f7G1hGQtPnluEARBKnJogoWgA /fuT9TQKTCSPuRAdtmlPUySF9Qcs3DKcz9X0MVFI1MsATWwHlFO72MpOpquFpg1XniSA bHq+TLB0R3xRXN0rHFCjEx2kE379aWW0k2dnJ4+lI70LWQxHwahYbbDh00fzP3L+vuE4 2im6ObBAQgijAlDzJTvYAUYEcpBxMosZt+a26N9Pm0svACDEoHO3x2AJMJcolgxEW8WX f8QP7SdVLyQCAmQZE0PuM2n/AttR+VVknmHj2exvI34v/a0kWCUseahLpiaDUoGv5ujR Hnnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745295122; x=1745899922; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hVIv5zgmPHgMvarwMS47WoU8pTy3QGZRk7haxdG839w=; b=p0VvOgIk/q5LODkzPm5Sozq7hy2v03pbx94DJtbj9mOdQ9UyNzocAjaBnIAeXuGUb1 LgRAGMzIiWzx17c2Q1XhlVzTrq4MCRj/Fd5z8G2LeSYyN1OAJWa5HnthY2271QZgstUw bcOpZtcBkNOo337abdqFxtsBhiLZfkSu8UyHaKT/MpG5GRaR9ASgNb+YTSXa0DZtioQX o5ffjjGu+J+y4xG4K/LMymgG2zZUwHFKx/sM27pG2w09SQpbej+XDNP3c3LufmD74LMV yOtLxfPIHKwCzrLkSaimRAfSWMeR3L7XQRHT1BI/oHxRQFzsxXysJvE2N8aKRWf3037i utqg== X-Gm-Message-State: AOJu0YxiAZICq5mZC/vwxinbA+RXiEyD68ASs/1npIkX4YOdVrBbda7Z u2Y51jbA+MhrpmdWS3iTko/Uur8lRJl51Dw8K7NT/3aZE1qAZICIeSP3KA== X-Gm-Gg: ASbGncuWsUsNY92FP5CwUI6fSmajIO/1vkTf/qjKvPgrLXvNMWvw0l8lHyw3aI8nsxz 8UUatNdLP1C8LC1GHxjTdDEH/ds71rxYamFCNZjggXrr8iGVwtvomz+ttIw97nNt70VzAlOtRLe tiOEdba5G4bhcFU543dnmsXQ5vkJIc4iM/YT4R0XSGOJ8lGz5NT2IHjgdP6UsimTqA9MiYlnwJC ewHQ47mPvvZU2+5xTHUQ4m40J4doMs9GPEv+XAi/7DZUo7aLRsJs7hz3sRs1eWuaO4wzdftzY/h O2Hp0zOznYf0EXzGOr0yrfa2iFefr9Stqo0a6RSz9HIQcJ5TwzYhV25IMWKaZxdQKdWT4CH4SLU koIJvJ269lF84srS4J7ysfqFwMsirwts1dK7nZpr1pfes X-Google-Smtp-Source: AGHT+IEKSMMQP7pfvjG1yqbjGKdKa1M4UeCeNOnnVAumOjK7ApppRgY+xxiLxGNyDAWxYt7s+Qejfg== X-Received: by 2002:a5d:584e:0:b0:39c:140c:25e with SMTP id ffacd0b85a97d-39efba560b1mr10232167f8f.24.1745295121817; Mon, 21 Apr 2025 21:12:01 -0700 (PDT) Received: from pro2 (p200300e0b7301900b98b74cfc94b2689.dip0.t-ipconnect.de. [2003:e0:b730:1900:b98b:74cf:c94b:2689]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4406d5cf3a7sm157372395e9.32.2025.04.21.21.12.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 21:12:01 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> Date: Tue, 22 Apr 2025 06:12:00 +0200 Message-ID: <m27c3cesxb.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Kangas <stefankangas@HIDDEN> writes: > This sounds great. I pushed a couple of typo fixes while reading the > patches, please use them as you see fit (squash, etc.). Thanks, I've ported that back to my side. > > - Any chance you could add a comment explaining how you arrived at > text_index_interval=4*1024? If it's arbitrarily chosen, adding a > comment to that effect might be useful. It's neither completely arbitrary nor can I really say much about it. INTERVAL / 2 is basically the worst-case distance one has to scan through text. Don't really know what to say more, and the above is pretty obvious. > > - Maybe rename `text-index-interval` to `text-index--interval` (to > indicate that it's internal)? > > - I guess `use-text-index` can be removed? I've removed these Lisp variables a few days ago or so. They were only for experimenting with the whole thing. >> Please see the comments at the start of marker-vector.c and text-index.c >> for more details. Also see the thread(s) on emacs-devel with Stef an me. > > For posterity, I guess that would be: > > Re: Question about region caches > https://lists.gnu.org/r/emacs-devel/2025-03/msg01382.html > > PS. BTW, a small procedural thing. Instead of merging master into a > scratch/ branch, I recommend deleting the branch, rebasing it on > master, and then pushing it again. This way, when we later merge it > into master, we avoid the merge commits, and the history is kept > clean and more easily reviewable. Not the end of the world either > way, but something to consider. Sorry, too much work :-). (For reviewing a branch with merges from master I recommend to find the latest merge commit, take the parent commit on the master side, and range diff with that. (If you have the merge in the reflog, that speeds up finding the latest merge, but that's only the case if you did the merge in that repo.))
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Tue, 22 Apr 2025 08:36:02 +0000 Resent-Message-ID: <handler.77924.B77924.174531090214955 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas <stefankangas@HIDDEN> Cc: Stefan Monnier <monnier@HIDDEN>, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174531090214955 (code B ref 77924); Tue, 22 Apr 2025 08:36:02 +0000 Received: (at 77924) by debbugs.gnu.org; 22 Apr 2025 08:35:02 +0000 Received: from localhost ([127.0.0.1]:45130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u795q-0003t8-9U for submit <at> debbugs.gnu.org; Tue, 22 Apr 2025 04:35:02 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:43454) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u795m-0003sV-RP for 77924 <at> debbugs.gnu.org; Tue, 22 Apr 2025 04:34:59 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-43cf628cb14so42604975e9.1 for <77924 <at> debbugs.gnu.org>; Tue, 22 Apr 2025 01:34:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745310892; x=1745915692; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Tb4JDkU2blnmN5x2g4np2S05h3U5piwkOOK/N1EzUuo=; b=dUpGB/zZoSB46d/SsQ5TJP9V7wXz5Qgi/wVyjW0aZKHbSh4LcsYv2E4zMDPvU4xUi9 vLHysKSosWo5JuN68iBZbHD+vahBEapeeKbvIrXXK71SN21y8M4p0Gz8gIjOkTT9KNBI aH61s+3TYWz/YXxr9pJ00F47/KC3PDJcEqUWL5sx/IdHc6ox5sQQ7vYRI1aOm5dtwkOv 7UUaNGCFotlVH/l4bB4MPHJiYpwS/IuAgQxCHm2MpgFHaJjP81jV5ut3oSdb+mxie/vu YJqKtGJUntXi5UjFylnHRtsSUgXt09KalAtj/r9IYddGuI68ouwG3D1pQ944wZzjBAAY SlHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745310892; x=1745915692; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Tb4JDkU2blnmN5x2g4np2S05h3U5piwkOOK/N1EzUuo=; b=bnVUMe9rvX/VhmaQ8EhIwWfGzI9E2OH1GlAdPHCQ4dCCkKT5YSF+27/6YYFUWY8Q0Z SJHuYD9np1P1J7x8UfnbBYxbW9qD9JO0ORbfqmaZSVUeSpDrZK0Y+auhurMX7JH3U7Wf +LS4GLkYpJfgQkqniKYlmGhT629pIuwpKf3paQ17HeCqXNRXb1d+dGp/Srbx+QrlgqE+ iJgA9M4GmLUaA0tB/uQPjCmybYG0jbsmxpUODQ7Cr5oPmQhjrpnvQqdUR/7/JBjArtfo xBboUETqp01maJiBBvqeWxXzVq30SRma1meV238ju6OPcpOaprmdS5Skbw5GrkkHRChB vbyQ== X-Gm-Message-State: AOJu0YwLyRf25S/6XxydYtIf44dbwHgougZY+Yz7sXltTkVXCK2fklmP +jCEwKf9xzHv1R0veg01wAoeK2914cDOdKWnbUsSuyjrEo84GGAp X-Gm-Gg: ASbGncsvsDN7CwkQnMDEM7Ged0fRJvgXO2Spf9wzbElcngZAibA17xfmisGNFZjTGlU VneZ7gqdUTNJd4nR8U48QHrmd/b3219ff4EWyWXbPbnEnMGPngF2/OQB/A8XjQzQE/onudHNOLn nsaAXxk2FKw+Gy5jrmtKE9GuHEmutvhS87OI6849/p9gGpdm2hg3gCtIGJ3sa0Dy5MT7LVKrG6v HHXVgjqmCBHzKrknABEKIcpSlWojhLh2seDPlT/v2dkhZi5zFyjMOrDg2395rAHn45dhm76bWdI faKKdZik0Qp1fYlEXFQ7xLE+U4OCHeCHYW8BeQhnXKIC7AoiiE9yBXU8LKGn3K65MCHHWRA0zKS nhiXWxv/aNr9L7KH5foRnaif1YH2+ohAtoUgzWRSzm0mf X-Google-Smtp-Source: AGHT+IEPb9L3GK6F2JqmVlIJ4kUNmfaccmKk9VCh6IJjdCW0zyPyKBhevDxE4kDELRl/8hBvyShgOw== X-Received: by 2002:a05:6000:4313:b0:39f:d0a:5b23 with SMTP id ffacd0b85a97d-39f0d0a5b9fmr3489827f8f.17.1745310892215; Tue, 22 Apr 2025 01:34:52 -0700 (PDT) Received: from pro2 (p200300e0b7301900b98b74cfc94b2689.dip0.t-ipconnect.de. [2003:e0:b730:1900:b98b:74cf:c94b:2689]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4a4f2dsm14543928f8f.95.2025.04.22.01.34.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 01:34:51 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <m27c3cesxb.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> Date: Tue, 22 Apr 2025 10:34:50 +0200 Message-ID: <m2v7qw8uhh.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > Stefan Kangas <stefankangas@HIDDEN> writes: > >> This sounds great. I pushed a couple of typo fixes while reading the >> patches, please use them as you see fit (squash, etc.). > > Thanks, I've ported that back to my side. > >> >> - Any chance you could add a comment explaining how you arrived at >> text_index_interval=3D4*1024? If it's arbitrarily chosen, adding a >> comment to that effect might be useful. > > It's neither completely arbitrary nor can I really say much about it. > INTERVAL / 2 is basically the worst-case distance one has to scan > through text. Don't really know what to say more, and the above is > pretty obvious. > >> >> - Maybe rename `text-index-interval` to `text-index--interval` (to >> indicate that it's internal)? >> >> - I guess `use-text-index` can be removed? > > I've removed these Lisp variables a few days ago or so. They were only > for experimenting with the whole thing. > >>> Please see the comments at the start of marker-vector.c and text-index.c >>> for more details. Also see the thread(s) on emacs-devel with Stef an me. >> >> For posterity, I guess that would be: >> >> Re: Question about region caches >> https://lists.gnu.org/r/emacs-devel/2025-03/msg01382.html >> >> PS. BTW, a small procedural thing. Instead of merging master into a >> scratch/ branch, I recommend deleting the branch, rebasing it on >> master, and then pushing it again. This way, when we later merge it >> into master, we avoid the merge commits, and the history is kept >> clean and more easily reviewable. Not the end of the world either >> way, but something to consider. > > Sorry, too much work :-). > > (For reviewing a branch with merges from master I recommend to find the > latest merge commit, take the parent commit on the master side, and > range diff with that. (If you have the merge in the reflog, that > speeds up finding the latest merge, but that's only the case if you did > the merge in that repo.)) There was the open question left whether or not it pays off to avoid the binary search in charpos -> bytepos conversion. Benchmarked it with (defun elb-replace-region-contents-entry () (with-temp-buffer (let ((step (apply #'concat (make-list 2000 "=F0=9F=99=82=C3=A9t=C3=A9= =F0=9F=91=B6=F0=9F=8F=BF ")))) (dotimes (_ (/ 100000 (length step))) (insert step))) (dotimes (_ 100000) (let* ((a (1+ (random (point-max)))) (b (1+ (random (point-max)))) (beg (min a b)) (end (max a b))) (replace-region-contents beg end "=F0=9F=99=82=C3=A9t=C3=A9=F0=9F=91=B6=F0= =9F=8F=BF =F0=9F=99=82=C3=A9t=C3=A9=F0=9F=91=B6=F0=9F=8F=BF "))))) 2000 runs on my idle Mac mini, M1 etc. * Without optimization Results | test | non-gc (s) | gc (s) | gcs | total (s) | err (= s) | |-------------------------+------------+--------+-----+-----------+------= ---| | replace-region-contents | 0.93 | 0.00 | 0 | 0.93 | 0.= 33 | |-------------------------+------------+--------+-----+-----------+------= ---| | total | 0.93 | 0.00 | 0 | 0.93 | 0.= 33 | * With opt. Results | test | non-gc (s) | gc (s) | gcs | total (s) | err (= s) | |-------------------------+------------+--------+-----+-----------+------= ---| | replace-region-contents | 0.89 | 0.00 | 0 | 0.89 | 0.= 32 | |-------------------------+------------+--------+-----+-----------+------= ---| | total | 0.89 | 0.00 | 0 | 0.89 | 0.= 32 | I think the large err values are because of the random and the O(ND) in replace-region-contents. Whatever, the optimization seems to pay off, so I'll add that to scratch/text-index on savannah later. Tests with the change: SUMMARY OF TEST RESULTS ----------------------- Files examined: 530 Ran 8041 tests, 7765 results as expected, 0 unexpected, 276 skipped I consider this feature done when that is in, and play with arm64 NEON a bit instead. In C++ ;-).
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Tue, 22 Apr 2025 12:36:01 +0000 Resent-Message-ID: <handler.77924.B77924.17453253221567 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas <stefankangas@HIDDEN> Cc: Stefan Monnier <monnier@HIDDEN>, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.17453253221567 (code B ref 77924); Tue, 22 Apr 2025 12:36:01 +0000 Received: (at 77924) by debbugs.gnu.org; 22 Apr 2025 12:35:22 +0000 Received: from localhost ([127.0.0.1]:46680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7CqQ-0000P9-BF for submit <at> debbugs.gnu.org; Tue, 22 Apr 2025 08:35:22 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:57697) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u7CqL-0000Ja-Ve for 77924 <at> debbugs.gnu.org; Tue, 22 Apr 2025 08:35:20 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-39ac9aea656so6432665f8f.3 for <77924 <at> debbugs.gnu.org>; Tue, 22 Apr 2025 05:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745325311; x=1745930111; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9nGA6aIVQjMwSpRqCbGI68janZHQuzAZ1L5Qa9zWo6U=; b=ZIU1/jmWFnvmwIP6lLQ8PDFqoMFQqR3/FH8DsPA/WT/RaxQGLUxCRRdEHhdS3KNNjk 5B8G6JSXiGuIdlLAbjCN3Ydtfo+pGmXV2m3LobOhLwn5d/n+VVR7xDx8uXf18/VeXPv+ bGws6fn8WeE1YsYl7io48qbV9hp0SgpeAKo68EHM1BeAZ01BVIQEBKD0kvDUhX/6URXk 26KpCj9AcrqtMGF+Fmxx6RY58EzW65/cUQyJKRW8uI5ZzDpsaUm73b/6fivAe57Vkz0J S7antqXvH8HJHjQ4On/fgr6BV4TvUusT8NQKk6TtaWSK7DmiNcehEX7sk3HSobAUhL70 buBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745325311; x=1745930111; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9nGA6aIVQjMwSpRqCbGI68janZHQuzAZ1L5Qa9zWo6U=; b=qvPuVFjC69wSDh5VJrfxTizshZl9kB+C/WY2UlVB/lWas/qionw3WNT8/yAhFE2Cah pyZPNcK2FA9eUrhUJaClqZiYYG6V0k97qRSiA3gosUu6ofq9NszFXkv2716/EMwut134 /TXkVzMUityS93uCPKS/mAwI/D+jnmr+E8n2MHA6w2ex3Op2tqPGfijfgi9Cwy1OEO2o c0h75Y2H8xzzN0ffKFKSV/LYmPCtimxa1Br3xbwKjb1gKo3IuEB5+JKznyAYNYopNJua wXvotH5umgdf2ObSlKhfruL+CifwBQl2wwBOBFSVRvsaQ5UCb01fQpn+V57kHXHR5VMv hLXg== X-Gm-Message-State: AOJu0YxkNP6gpn7Q1vqqTHphGcR9/dBulIw4mmnNVR0xvNYJOS6VlVKB UJq6dzEaWUvN/pCnjgMNF83AO+dok/hYSk3cuQ5F0hdltvPjZuYd X-Gm-Gg: ASbGncvRsRYTaZJl27ikVQQs5gK9xsVRcATdVJdg0uOZVMRVim+j/DadYIypIkNgqMP AakLBhEZMZ4J3RIBmX57D/mPevthXr76VyJqjYQBIJoFvlQY6niVgx15/fn955rKzYFQ+KJF1aZ UJ1aA27DvHVBE3OT3BLqIlWAh0yjpm33riSuLy/kwhvEUuMm3uqSe5muolXbizvNOp6oONYRM60 n3BItY0wNX/bsJ9L6ZCJTXKTBMa3QGmSx1s9hiTHGn0GgGOZYn4ywIYeNnYSI2f+XjImA5qkfm7 v3jfZYeiU8VuU08Yk76RBJFyRJp30+kvYp4g8/aj1OizAO6F6rUjs/rlpnxe0AznLxcybVkrXbo 3KK5/BVB66wrlkzWUeAY33t/a2kGnoacjm5Efi7RCFSpPs6K6ZsWuFzc= X-Google-Smtp-Source: AGHT+IGzuho3kRn4rCOEWC6cWyh6x6r1qp3xkirZzO2cOddwwWmrnTcXTNqRTvYLXmBQEKEfJNpgKg== X-Received: by 2002:a05:6000:188e:b0:391:4835:d8a8 with SMTP id ffacd0b85a97d-39efba2ab31mr12878607f8f.1.1745325311341; Tue, 22 Apr 2025 05:35:11 -0700 (PDT) Received: from pro2 (p200300e0b7301900b98b74cfc94b2689.dip0.t-ipconnect.de. [2003:e0:b730:1900:b98b:74cf:c94b:2689]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4a4f21sm15329030f8f.91.2025.04.22.05.35.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 05:35:10 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <m2v7qw8uhh.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <m2v7qw8uhh.fsf@HIDDEN> Date: Tue, 22 Apr 2025 14:35:09 +0200 Message-ID: <m24iygz85e.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > * Without optimization Results > > | test | non-gc (s) | gc (s) | gcs | total (s) | err= (s) | > |-------------------------+------------+--------+-----+-----------+----= -----| > | replace-region-contents | 0.93 | 0.00 | 0 | 0.93 | = 0.33 | > |-------------------------+------------+--------+-----+-----------+----= -----| > | total | 0.93 | 0.00 | 0 | 0.93 | = 0.33 | > > * With opt. Results > > | test | non-gc (s) | gc (s) | gcs | total (s) | err= (s) | > |-------------------------+------------+--------+-----+-----------+----= -----| > | replace-region-contents | 0.89 | 0.00 | 0 | 0.89 | = 0.32 | > |-------------------------+------------+--------+-----+-----------+----= -----| > | total | 0.89 | 0.00 | 0 | 0.89 | = 0.32 | ** master Results | test | non-gc (s) | gc (s) | gcs | total (s) | err (= s) | |-------------------------+------------+--------+-----+-----------+------= ---| | replace-region-contents | 1.04 | 0.00 | 0 | 1.04 | 0.= 33 | |-------------------------+------------+--------+-----+-----------+------= ---| | total | 1.04 | 0.00 | 0 | 1.04 | 0.= 33 | So, improvement, also here with text-index.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Stefan Monnier <monnier@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Tue, 22 Apr 2025 14:09:01 +0000 Resent-Message-ID: <handler.77924.B77924.174533089421248 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Cc: Stefan Kangas <stefankangas@HIDDEN>, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174533089421248 (code B ref 77924); Tue, 22 Apr 2025 14:09:01 +0000 Received: (at 77924) by debbugs.gnu.org; 22 Apr 2025 14:08:14 +0000 Received: from localhost ([127.0.0.1]:49142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7EIH-0005Wd-D6 for submit <at> debbugs.gnu.org; Tue, 22 Apr 2025 10:08:13 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24109) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1u7EID-0005WM-CL for 77924 <at> debbugs.gnu.org; Tue, 22 Apr 2025 10:08:10 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 21E90807B7; Tue, 22 Apr 2025 10:08:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1745330879; bh=kJ8/x3iHlNeGMYzyIxdnhfPN7sLOCY952fURqJFoG3E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=e6nkIlYXu02DPSriAmXduud6bs5lhFcFjmckr3uynlCVajSygIEsZPbUyz6mz+AF4 qhPV+BKkIVyvAYyPMjG4dmJYOWVooWR+Rj6EUgX6ybykh1X+V2ItFRHT8oLSzTzAjC y/Va3R3MQ+hCKk7mNPs7QWJNpoQqAxZyP5oBZOCcXkYQG4aex53zRrqJpNxdkKrfUY VZeFwJjcebEDvMhwBLiKM+k/+J/SA0y/O43edhVtREGq2ZDXVBIhgkESXZ4e6Sukpy ijjxFQss8TtuG4TVA69HkQuszIRUSoyCQriCiKejZJmFeHh9GnAwr0u4v+R3KtImit GPOOZ4ZyTnr1w== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 13648803EA; Tue, 22 Apr 2025 10:07:59 -0400 (EDT) Received: from pastel (104-195-208-18.cpe.teksavvy.com [104.195.208.18]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D31AC120568; Tue, 22 Apr 2025 10:07:58 -0400 (EDT) From: Stefan Monnier <monnier@HIDDEN> In-Reply-To: <m27c3cesxb.fsf@HIDDEN> Message-ID: <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> Date: Tue, 22 Apr 2025 10:07:58 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) >> - Any chance you could add a comment explaining how you arrived at >> text_index_interval=3D4*1024? If it's arbitrarily chosen, adding a >> comment to that effect might be useful. > It's neither completely arbitrary nor can I really say much about it. > INTERVAL / 2 is basically the worst-case distance one has to scan > through text. Don't really know what to say more, and the above is > pretty obvious.=20 FWIW, the current code in `master` uses a threshold of 5k (sometimes 5k bytes, sometimes 5k chars) as the minimum distance between "cache-markers". It's a tradeoff between the size of the text-index array (and the time it takes to populate/update it) and the time it takes to scan the text from one of the positions recorded in that array to the position we're actually interested in. We haven't really investigated which value would be ideal. The code that does the scan can probably be improved significantly (e.g. by processing the text several bytes at a time). > (defun elb-replace-region-contents-entry () > (with-temp-buffer > (let ((step (apply #'concat (make-list 2000 "=F0=9F=99=82=C3=A9t=C3= =A9=F0=9F=91=B6=F0=9F=8F=BF ")))) > (dotimes (_ (/ 100000 (length step))) > (insert step))) >=20 > (dotimes (_ 100000) > (let* ((a (1+ (random (point-max)))) > (b (1+ (random (point-max)))) > (beg (min a b)) > (end (max a b))) > (replace-region-contents beg end "=F0=9F=99=82=C3=A9t=C3=A9=F0=9F= =91=B6=F0=9F=8F=BF =F0=9F=99=82=C3=A9t=C3=A9=F0=9F=91=B6=F0=9F=8F=BF "))))) As discussed in the other thread, this performs fairly few charpos->bytepos conversions, actually. Instead it spends most of its time inside the `diffseq.h` code. You could try something like: (require 'subr-x) =20=20=20=20 (defun elb-replace-region-contents-entry () (with-temp-buffer (let ((step (apply #'concat (make-list 2000 "=F0=9F=99=82=C3=A9t=C3= =A9=F0=9F=91=B6=F0=9F=8F=BF ")))) (dotimes (_ (/ 500000 (length step))) (insert step)) =20=20=20=20 (dotimes (_ 100000) (let* ((a (+ (point-min) (random (buffer-size)))) (b (min (+ a (length step) (random 512) -256) (point-max= )))) (replace-region-contents a b (lambda () step))))))) which should spend more time in Emacs's code (especially in `buffer_chars_equal`) than in `diffseq.h` >> PS. BTW, a small procedural thing. Instead of merging master into a >> scratch/ branch, I recommend deleting the branch, rebasing it on >> master, and then pushing it again. This way, when we later merge it >> into master, we avoid the merge commits, and the history is kept >> clean and more easily reviewable. Not the end of the world either >> way, but something to consider. > > Sorry, too much work :-). > > (For reviewing a branch with merges from master I recommend to find the > latest merge commit, take the parent commit on the master side, and > range diff with that. (If you have the merge in the reflog, that > speeds up finding the latest merge, but that's only the case if you did > the merge in that repo.)) git diff origin/master...origin/scratch/text-index should take care of it. If there's interest, I could take care of rebasing (and improving the commit messages on the rebased commits) before merging into `master`. > I consider this feature done when that is in, and play with arm64 NEON a > bit instead. In C++ ;-). BTW, regarding processing several bytes at a time, we could try something like long unsigned eightbytes =3D BUF_FETCH_8BYTES (bytepos); long unsigned eightbits =3D ((~eightbytes) & 0x8080808080808080) >> 7; long unsigned fourtwobits =3D eightbits + (eightbits >> 32); long unsigned twofourbits =3D fourtwobits + (fourtwobits >> 16); nchars +=3D (twofourbits + (twofourbits >> 8)) & 0xff; Not sure it would be significantly faster than the current code, tho. Maybe an even easier first change would be to replace if (CHAR_HEAD_P (BUF_FETCH_BYTE (b, bytepos))) ++charpos; with charpos +=3D (~BUF_FETCH_BYTE (b, bytepos)) >> 7; so as to avoid a branch that can be sometimes hard to predict. Stefan
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Tue, 22 Apr 2025 14:35:02 +0000 Resent-Message-ID: <handler.77924.B77924.174533244226182 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier <monnier@HIDDEN> Cc: Stefan Kangas <stefankangas@HIDDEN>, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174533244226182 (code B ref 77924); Tue, 22 Apr 2025 14:35:02 +0000 Received: (at 77924) by debbugs.gnu.org; 22 Apr 2025 14:34:02 +0000 Received: from localhost ([127.0.0.1]:49206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7EhF-0006o4-DY for submit <at> debbugs.gnu.org; Tue, 22 Apr 2025 10:34:01 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:46383) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u7EhC-0006nh-ET for 77924 <at> debbugs.gnu.org; Tue, 22 Apr 2025 10:33:59 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-43ea40a6e98so47745825e9.1 for <77924 <at> debbugs.gnu.org>; Tue, 22 Apr 2025 07:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745332432; x=1745937232; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=on5QFVVfxk3WRAguyn+t3APA8iJPfIvDCaVsiaUrK7k=; b=PCwDjXWkck7uBJ6+CP78+EDHsH9I6Ym9M4+Zv2xrXe8v8SHsj2gztIWjKVNOTCUT/W xBU5okmA5HnCSlhpEVq+JH7D+GJ7pNwV269GJzG+ecLm5oEQjwRt9dODEvFQ26+YHg8j xZXCXAmp0noxjOxNo1m18fpYZH2UKJDUUkeQp8jyn+L+qnr6FQHNDsmsI1ctyfphcg6E sthLhjIhBhqWGspNGnVuNuZhQQjbYAu2VzvxLPmfnT0rr01k51RJUspAQL9WRBFn6u5B GKZD0jV/0L7q5I6eDzw6FVyNlAp5HnPcyrwmfZOLKjR7Ygg2I1f1oPAm661hJaTpaBtS 5eQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745332432; x=1745937232; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=on5QFVVfxk3WRAguyn+t3APA8iJPfIvDCaVsiaUrK7k=; b=MmKNN4BR3xOsNgiJPYl451WNg4Xw2RdCHlGLqnXdXROZ347hWlMwK7bZqAQd1idPE4 jFViAw9VsSW8/sc6HLfZ+MYIdVj+nLP21u5O0oeJuMM733dcfRn2HDTzWz+kpwUZFGMn ai293V0yKVTLXwkrwacaP5X2KJn826HtspXdimo/mMATvEtz+PXx9wfOzlaQMNXXyKgT O8pd1rQ8RDGk3OF6d5p/Xj5WPE8Kvy0KzZXO+pHD3rV0JdCuqPun2JceLhblksBer8Gl Ul8k7HJqfCkMJyfzEiD4ftVr1n9WPqrUR32eOKgk8oxTIhybDE3GW1n1zReKdeoDr0AE wwvg== X-Forwarded-Encrypted: i=1; AJvYcCXRXRah8EsrqPp1Tjr5svLNY25h3pR7+45654NdjKIdDZ+6xUwsQN4V1GXAsdrSKhnCKpVXxg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyA2VaQAtUvdpPqKwMxxq4HusPd2ocxLhr+Go8/UBjq8Wj15Gqy a9W/gOLEvy7Jh8Hgq2PaJQWN85LBhJBv8pa78GEc6XEwLjjIvvbpK3Qn3Pr4 X-Gm-Gg: ASbGncsuNSvv1icw5WeUpkhuyFisl3H42JFzS3CvBvZqsY2CoxVIZZkM30g0RzKVGRK gCx7y19veoc4HdMxI4chqV1j9q5p/AuNxgG15JQSw1LI/DW8y+C0FmMhVytVlew+GLqiOmvkr3t Cbx7LlpTG0qEqMfDgI4F32up6xAgi4J8fhMOH2UQnQcFXxPtiwSe6XrKnvBwtWYUJfTHnv7Dy/J wIcly6xYYUCvyAMbdbv7OOD85u44EGWyQA+uXYBPF6fDqMzIXSmC8hMTYc+OMvKYImVT9JGkYzq E9THNh/tqSDHp0gispwggVHQM4270xvg0sP+D1c/x/C6/bEVijN5lFBezQTjwdxmqjUH9AkZs7v +a0ebb/JLPEh8NxZyqu7qYbl/XvGmNkdrzyinoq31r+ZB X-Google-Smtp-Source: AGHT+IEhVYXgDq5HF2+3KktF6Ezcj2/QoQ8nIWJ3qoJWxMt671lnxhFRS4KyL9JAKW1VfHplhlWRhA== X-Received: by 2002:a05:600c:1f83:b0:43c:efed:733e with SMTP id 5b1f17b1804b1-4406ab98a0dmr143932615e9.14.1745332431668; Tue, 22 Apr 2025 07:33:51 -0700 (PDT) Received: from pro2 (p200300e0b7301900b98b74cfc94b2689.dip0.t-ipconnect.de. [2003:e0:b730:1900:b98b:74cf:c94b:2689]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4406d5bbe45sm176827325e9.24.2025.04.22.07.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 07:33:51 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> Date: Tue, 22 Apr 2025 16:33:50 +0200 Message-ID: <m234e0xo35.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Monnier <monnier@HIDDEN> writes: >>> - Any chance you could add a comment explaining how you arrived at >>> text_index_interval=3D4*1024? If it's arbitrarily chosen, adding a >>> comment to that effect might be useful. >> It's neither completely arbitrary nor can I really say much about it. >> INTERVAL / 2 is basically the worst-case distance one has to scan >> through text. Don't really know what to say more, and the above is >> pretty obvious.=20 > > FWIW, the current code in `master` uses a threshold of 5k (sometimes 5k > bytes, sometimes 5k chars) as the minimum distance between > "cache-markers". > > It's a tradeoff between the size of the text-index array (and the time > it takes to populate/update it) and the time it takes to scan the text > from one of the positions recorded in that array to the position we're > actually interested in. > > We haven't really investigated which value would be ideal. True. It might even be different between machines, don't know. I once, in the beginning, tried large values, don't remember, maybe 16K, and performance seemed to drop, but not much. Difficult to find an ideal value. > The code that does the scan can probably be improved significantly > (e.g. by processing the text several bytes at a time). For sure.=20 >> (defun elb-replace-region-contents-entry () >> (with-temp-buffer >> (let ((step (apply #'concat (make-list 2000 "=F0=9F=99=82=C3=A9t=C3= =A9=F0=9F=91=B6=F0=9F=8F=BF ")))) >> (dotimes (_ (/ 100000 (length step))) >> (insert step))) >>=20 >> (dotimes (_ 100000) >> (let* ((a (1+ (random (point-max)))) >> (b (1+ (random (point-max)))) >> (beg (min a b)) >> (end (max a b))) >> (replace-region-contents beg end "=F0=9F=99=82=C3=A9t=C3=A9=F0= =9F=91=B6=F0=9F=8F=BF =F0=9F=99=82=C3=A9t=C3=A9=F0=9F=91=B6=F0=9F=8F=BF "))= ))) > > As discussed in the other thread, this performs fairly few > charpos->bytepos conversions, actually. Instead it spends most of its > time inside the `diffseq.h` code. You could try something like: > > (require 'subr-x) >=20=20=20=20=20 > (defun elb-replace-region-contents-entry () > (with-temp-buffer > (let ((step (apply #'concat (make-list 2000 "=F0=9F=99=82=C3=A9t= =C3=A9=F0=9F=91=B6=F0=9F=8F=BF ")))) > (dotimes (_ (/ 500000 (length step))) > (insert step)) >=20=20=20=20=20 > (dotimes (_ 100000) > (let* ((a (+ (point-min) (random (buffer-size)))) > (b (min (+ a (length step) (random 512) -256) (point-m= ax)))) > (replace-region-contents a b (lambda () step))))))) > > which should spend more time in Emacs's code (especially in > `buffer_chars_equal`) than in `diffseq.h` > >>> PS. BTW, a small procedural thing. Instead of merging master into a >>> scratch/ branch, I recommend deleting the branch, rebasing it on >>> master, and then pushing it again. This way, when we later merge it >>> into master, we avoid the merge commits, and the history is kept >>> clean and more easily reviewable. Not the end of the world either >>> way, but something to consider. >> >> Sorry, too much work :-). >> >> (For reviewing a branch with merges from master I recommend to find the >> latest merge commit, take the parent commit on the master side, and >> range diff with that. (If you have the merge in the reflog, that >> speeds up finding the latest merge, but that's only the case if you did >> the merge in that repo.)) > > git diff origin/master...origin/scratch/text-index > > should take care of it. > > If there's interest, I could take care of rebasing (and improving the > commit messages on the rebased commits) before merging into `master`. Please consider the branch yours, if you like, as far as I am concerned :-). Because... >> I consider this feature done when that is in, and play with arm64 NEON a >> bit instead. In C++ ;-). ...of that- > > BTW, regarding processing several bytes at a time, we could try > something like > > long unsigned eightbytes =3D BUF_FETCH_8BYTES (bytepos); > long unsigned eightbits =3D ((~eightbytes) & 0x8080808080808080) >> 7; > long unsigned fourtwobits =3D eightbits + (eightbits >> 32); > long unsigned twofourbits =3D fourtwobits + (fourtwobits >> 16); > nchars +=3D (twofourbits + (twofourbits >> 8)) & 0xff; > > Not sure it would be significantly faster than the current code, tho. > Maybe an even easier first change would be to replace > > if (CHAR_HEAD_P (BUF_FETCH_BYTE (b, bytepos))) > ++charpos; > > with > > charpos +=3D (~BUF_FETCH_BYTE (b, bytepos)) >> 7; > > so as to avoid a branch that can be sometimes hard to predict. > Hard to tell if that would be faster. Maybe if I know a bit more about the current state of affairs of SIMD support, one could write something using that. That would certainly be faster. On my M1 chips it would mean processing 16 bytes at a time (128 bit registers), and I've seen a presentation that talked about 256 and even 512 bits on some Intel CPUs (AMX).
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Tue, 22 Apr 2025 16:16:02 +0000 Resent-Message-ID: <handler.77924.B77924.174533854013135 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier <monnier@HIDDEN> Cc: Stefan Kangas <stefankangas@HIDDEN>, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174533854013135 (code B ref 77924); Tue, 22 Apr 2025 16:16:02 +0000 Received: (at 77924) by debbugs.gnu.org; 22 Apr 2025 16:15:40 +0000 Received: from localhost ([127.0.0.1]:49581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7GHb-0003Pk-UZ for submit <at> debbugs.gnu.org; Tue, 22 Apr 2025 12:15:40 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:54535) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u7GHZ-0003PO-GO for 77924 <at> debbugs.gnu.org; Tue, 22 Apr 2025 12:15:38 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-39ee682e0ddso3131016f8f.1 for <77924 <at> debbugs.gnu.org>; Tue, 22 Apr 2025 09:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745338531; x=1745943331; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0IdxlHIzBCDMPIji0toDWDgysoTF9XODBpOYwXcF03A=; b=TVZ4ZXhdliDOq6ZMyrEr3pz174tApPFiFtNfOzMcRQS6Hm2ZssGAUTfcmu9Xmp69Wn yNOVpEliLBR3Qctbb/8GT6nbfVsNz2uMto5bIscX6Z/vLVf+49ckl9Uez1dQ7Mlw+e1d /4lupRunX1CZUUxmdQXomOzriEHJd3P+Hv7hCuCU0gsaRh6sEbKn+f0EzaerGsvoer+B YxoSXnYuGIyAe3CIaHc9sehiqiIoEfGTXCA1rgPtWaB6Ksak1dANjz3PS4OL6umfl378 zajq20Oo3r+LcBt3IcyZaI0IRARNNrLpd/uQZLHDo3CqSryKDJ7+h5SSmjdjk1Y41eeP AYBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745338531; x=1745943331; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0IdxlHIzBCDMPIji0toDWDgysoTF9XODBpOYwXcF03A=; b=MZaghdwwmlun+2OxpHUM16/UT3bw6VReqtQWYhXkFwHLkN1abQl8flbz41j46CU/5x 231zYcPboBcsG962edTjaBdFVWrKJdvO8tsvirECpd+4krMoVLuQqi8dh/3OfLlrCukU Jusbin3u2LJ3XzQlM82GTUD9dQLPjvekwXjCqYQcgX5xEVThJcAV/eI0sjeHcTOmN7m4 6ex+7vQwDvPLiSe+pG9JpN8hs5+brX8ZKL8ZXSCWalmk60gR1paQzVBGyvynhoXOcGqm VL6akydNKi4ox5vfQrehRP1tsYXdGUNHlfUjysitjWQKaVzlwJoGUXKt1TAQ42L7JtsT Gp5w== X-Forwarded-Encrypted: i=1; AJvYcCVtmJYgK5fvfVuAgsgODIkvf886Mf8Yb4FioxPiL4sTnODmNF/m6S6XehAAtPsxsAC55iEJGg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzxwdwdBqZ0T3IsAtxVMriBVxdUtzOF+6bHjpqZLDgOFu5DjVAr O9q02FPgq9ohIgF3L+toNWFKKw/KQrrkfMgSzJvhJMC4pawMuTlhsFRK9pXT X-Gm-Gg: ASbGncsfcHJzZ/TuEC/qfS0j5wJB3yTV5i8Fq6Sa7wVzarSIbgSnR6gc2YsDFh+Bh9J QySoFMMTAj6D0/WDupIdJ9NQJftZW623Jc6S8nXVjZoWytXWTRdF81Hg4mLUfVAL6Ky/TpWwEpb eqrmX3sZya/hTqcbM0Pi2wGK9UselpGxdlL7MAphEZChSpvTDSt4lqqlBadCYDdkNMwJSZ7Rmgb ToEtJiY3zOzXRSR00GqLQYjL4W6Fczf2cU1DKTyx3MdZL3pJddfbvTcdtEFIjsC/NUcr+oCcTmx 5nxVLyXBoU2893uQARE71GFSER2EBWNj9S8V60EbaskMdwuzRHRgMMwjZnC7lrQ3yOJqwbjUY9B nD3O+iwQOtThw1JGlbm1wB2OUc76Mwko/t583sPBL0hmqc1LUCw== X-Google-Smtp-Source: AGHT+IF2PJ5lppdBSepu8CJsJRFZlKLym4iu2BOEszFG5f5WzV73sAtKnGHFBgeuwWMeTT9IHemgbQ== X-Received: by 2002:a05:6000:4201:b0:39e:cbc7:ad2c with SMTP id ffacd0b85a97d-39efba5ede7mr12658516f8f.25.1745338530785; Tue, 22 Apr 2025 09:15:30 -0700 (PDT) Received: from pro2 (p200300e0b7301900d125c0c7bda1f42d.dip0.t-ipconnect.de. [2003:e0:b730:1900:d125:c0c7:bda1:f42d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4a4be2sm15468110f8f.83.2025.04.22.09.15.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 09:15:30 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> Date: Tue, 22 Apr 2025 18:15:29 +0200 Message-ID: <m2sem0yxy6.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Monnier <monnier@HIDDEN> writes: > As discussed in the other thread, this performs fairly few > charpos->bytepos conversions, actually. Instead it spends most of its > time inside the `diffseq.h` code. You could try something like: > > (require 'subr-x) >=20=20=20=20=20 > (defun elb-replace-region-contents-entry () > (with-temp-buffer > (let ((step (apply #'concat (make-list 2000 "=F0=9F=99=82=C3=A9t= =C3=A9=F0=9F=91=B6=F0=9F=8F=BF ")))) > (dotimes (_ (/ 500000 (length step))) > (insert step)) >=20=20=20=20=20 > (dotimes (_ 100000) > (let* ((a (+ (point-min) (random (buffer-size)))) > (b (min (+ a (length step) (random 512) -256) (point-m= ax)))) > (replace-region-contents a b (lambda () step))))))) > > which should spend more time in Emacs's code (especially in > `buffer_chars_equal`) than in `diffseq.h` Tried to run that on my mini, but it didn't finish in ca. 2h. So I tried to call that function on my MB, and had to kill my Emacs :-). Anyway, the other benchmarks showed an improvement over master, so I'm content.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 23 Apr 2025 04:48:02 +0000 Resent-Message-ID: <handler.77924.B77924.174538366017086 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier <monnier@HIDDEN> Cc: Stefan Kangas <stefankangas@HIDDEN>, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174538366017086 (code B ref 77924); Wed, 23 Apr 2025 04:48:02 +0000 Received: (at 77924) by debbugs.gnu.org; 23 Apr 2025 04:47:40 +0000 Received: from localhost ([127.0.0.1]:51760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7S1I-0004RB-54 for submit <at> debbugs.gnu.org; Wed, 23 Apr 2025 00:47:39 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:50384) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u7S1C-0004PL-1S for 77924 <at> debbugs.gnu.org; Wed, 23 Apr 2025 00:47:33 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-39c31e4c3e5so4071924f8f.0 for <77924 <at> debbugs.gnu.org>; Tue, 22 Apr 2025 21:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745383643; x=1745988443; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pZG5GxUojJpj/koYvFt1Ok329/eNL9LEAZZ5jFGH0K4=; b=XyEWgL+CRlaQbwH8+temyrbi0+r4oW0l6WCxlFVn+A1q1mKSBMm0HBAVAbGLQ2+0hL xz5r8Xbq1AFIHmcBkycELJryE8QVpA3l35/rN9f5g1aiWoixKkQLvFhElolMkwELLNgq by6QgZRT8EWXRnFgn5ckC6VVX32gxt8lkRBSsCiYAATChqzVdPbQbozbpbk93hWt1w+t N4V5e1wSSfynydRanzmMOkP4C8+FeDsKqom8Z7miY5/xRrMvngn8X3sieKiNtD6C1/Hn wSBNzcWSoLs0hHSUYwi4Vlq+9owC8AHH8upSiYnn3apK+o7j19AyLeX8rkBKuaIXRM40 eMVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745383643; x=1745988443; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pZG5GxUojJpj/koYvFt1Ok329/eNL9LEAZZ5jFGH0K4=; b=hMoN2kgOk0RZH5B+R0XpGGdBMR/K8cIflZtpPuM37172cTj0CHGhH3hFJESLSLZgQf mY62K41nn5hiCP0M69BY8c/3mVeaP6AAW6I9bs1liN+HKuQ9PgyiIIwREwZt7ADGpe0o EfA0t6Ss7PzdQDK7YzHEROKnI+huRfh1b4jMsVytx+HYqONUMVgAmiVXAbmJi/EiQ66r 5K5BCDZhpnamflQ3b29BrPRyahuZyNVUpoPmVMjTKrlZZTxd9l+YGfTxQgN3V5bMcmbP tRVLKAblVyZYTBX9R8AP7DSZP0xuR/lBK4USnekvJ2R6Lin4QjKrJ922ty2lGnR5rubh K3Kw== X-Forwarded-Encrypted: i=1; AJvYcCXwqkVZmPipl/j6km5Ki+OQ8ftAb05rfktBNFwkqAo8Hc0jMg3jMZ87SuaAas0+b7Czmkvn0Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxYNNbfey88UwjBr278sxxyZfWn0+Frba1JGPnzkzN+Kj0ZYgAc BGfxRmH5KzcCRCwxW7VNY3lfcm2r8uIYN7nz+nIMasopG+E/rg8D7P98UO4B X-Gm-Gg: ASbGncselJ39fRMKyogSYhdutGEAOS8+yHh+5JrFTSxMS5sgWWTzoJalIZCtyT1E1PR Am892c5Svcy4jYjGi5GJB4rrWD0tnfYUWSLiEd5oAi8WOXUCbR6PF34f8H2EjXpusZXXJu+V0Ig 2Vd4prbPNbgsCk17TQWhkytv5U2JOYqdLKMWGEyJTSRtX53zheLlyRMIABzAhwa/ecLjGx7SC5G +yoTp2eUn/95VD+abxfcM8EmIb2K++O14vGNr9vu+Oh4TuZouZsm/3RNyJvP1GQ4fYjzULGJa6h o72gm5Jkt5zZxNYDGJ6vWDOCBO6PB2++87eBB6Z+W268fz3o6xuoTbgtSiYxshbuc2zxSRml4Dq lxa7WDSX+JKHrUJtgQ9PLCFPmfFOqg/td7He7BBTc4TgWWfshrw== X-Google-Smtp-Source: AGHT+IFp7NgH85Sm0SwIhRrT2IUc89uyfzzpFcK00racoPJyoLBZayaEMDfZvQw6JSFJFOJWPM4wHQ== X-Received: by 2002:adf:f94a:0:b0:39f:6e9:8701 with SMTP id ffacd0b85a97d-39f06e9871dmr7755023f8f.7.1745383642926; Tue, 22 Apr 2025 21:47:22 -0700 (PDT) Received: from pro2 (p200300e0b7376d00808a7ba45869fd57.dip0.t-ipconnect.de. [2003:e0:b737:6d00:808a:7ba4:5869:fd57]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa43315esm17083895f8f.26.2025.04.22.21.47.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 21:47:22 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <m234e0xo35.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> Date: Wed, 23 Apr 2025 06:47:21 +0200 Message-ID: <m2frhzbi1y.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: >>>> PS. BTW, a small procedural thing. Instead of merging master into a >>>> scratch/ branch, I recommend deleting the branch, rebasing it on >>>> master, and then pushing it again. This way, when we later merge = it >>>> into master, we avoid the merge commits, and the history is kept >>>> clean and more easily reviewable. Not the end of the world either >>>> way, but something to consider. >>> >>> Sorry, too much work :-). >>> >>> (For reviewing a branch with merges from master I recommend to find the >>> latest merge commit, take the parent commit on the master side, and >>> range diff with that. (If you have the merge in the reflog, that >>> speeds up finding the latest merge, but that's only the case if you did >>> the merge in that repo.)) >> >> git diff origin/master...origin/scratch/text-index >> >> should take care of it. >> >> If there's interest, I could take care of rebasing (and improving the >> commit messages on the rebased commits) before merging into `master`. > > Please consider the branch yours, if you like, as far as I am concerned > :-). Because... > >>> I consider this feature done when that is in, and play with arm64 NEON a >>> bit instead. In C++ ;-). > > ...of that- It just appeared to me that I better ask instead of making assumptions: When I landed tty child frames in master, there was a certain procedure how to do that. See https://yhetil.org/emacs-devel/m2ldwdrnds.fsf@HIDDEN/ where I asked about this, and see Eli's reply. In essence: No rebasing, squashing, and so on. Following that procedure, is why I posted the change-log-style commit message for such a merge here. My assumption up to a few minutes ago was that that procedure has changed? Which I wouldn't know because I'm not following the lists for some time. But, as I said, now I'm not really sure...
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 23 Apr 2025 13:16:02 +0000 Resent-Message-ID: <handler.77924.B77924.174541414312330 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Cc: monnier@HIDDEN, 77924 <at> debbugs.gnu.org, stefankangas@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174541414312330 (code B ref 77924); Wed, 23 Apr 2025 13:16:02 +0000 Received: (at 77924) by debbugs.gnu.org; 23 Apr 2025 13:15:43 +0000 Received: from localhost ([127.0.0.1]:55626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7Zx0-0003Cl-WD for submit <at> debbugs.gnu.org; Wed, 23 Apr 2025 09:15:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47234) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1u7Zww-0003B3-Eb for 77924 <at> debbugs.gnu.org; Wed, 23 Apr 2025 09:15:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1u7Zwq-0001EJ-RG; Wed, 23 Apr 2025 09:15:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=EW7N0whvSk//RvU/7mra9CyHBNCX9lr7CoGL2JuOJc8=; b=DyebpIfnBCscR5gC9Z4h aoCDsocExxifa4NDG+XbH5+rBLIaTYJl742V43eke9zfxnmVSMJJ4MaiXxAwA2JsTJEDLKX2g7mjO Sd6difj7WjyMJewTkXdFIV9zZe2VmmOnogmQKhFx7mqMqfMhvKJNiHilxW1k3Mh5P9hy4bQXVcwoe LLpx1EGY+c5AfpB/ehOlegi5s1AIpzad2begGSs0uWDj3HzVyj6zsvBmQ2WBgXntjGQqcZZO6Vlom dk7xPY31k4UdvyI12bJPb+oMpCVsQAZbEz953V98W4yUBWyu9bhCrVlyQe1CdjlhOoz94v0odQ/F4 /gzu35F4hNYzog==; Date: Wed, 23 Apr 2025 16:15:16 +0300 Message-Id: <861ptj10kb.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <m2frhzbi1y.fsf@HIDDEN> (message from Gerd =?UTF-8?Q?M=C3=B6llmann?= on Wed, 23 Apr 2025 06:47:21 +0200) References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: Stefan Kangas <stefankangas@HIDDEN>, 77924 <at> debbugs.gnu.org > From: Gerd Möllmann <gerd.moellmann@HIDDEN> > Date: Wed, 23 Apr 2025 06:47:21 +0200 > > Gerd Möllmann <gerd.moellmann@HIDDEN> writes: > > >>>> PS. BTW, a small procedural thing. Instead of merging master into a > >>>> scratch/ branch, I recommend deleting the branch, rebasing it on > >>>> master, and then pushing it again. This way, when we later merge it > >>>> into master, we avoid the merge commits, and the history is kept > >>>> clean and more easily reviewable. Not the end of the world either > >>>> way, but something to consider. > >>> > >>> Sorry, too much work :-). > >>> > >>> (For reviewing a branch with merges from master I recommend to find the > >>> latest merge commit, take the parent commit on the master side, and > >>> range diff with that. (If you have the merge in the reflog, that > >>> speeds up finding the latest merge, but that's only the case if you did > >>> the merge in that repo.)) > >> > >> git diff origin/master...origin/scratch/text-index > >> > >> should take care of it. > >> > >> If there's interest, I could take care of rebasing (and improving the > >> commit messages on the rebased commits) before merging into `master`. > > > > Please consider the branch yours, if you like, as far as I am concerned > > :-). Because... > > > >>> I consider this feature done when that is in, and play with arm64 NEON a > >>> bit instead. In C++ ;-). > > > > ...of that- > > It just appeared to me that I better ask instead of making assumptions: > When I landed tty child frames in master, there was a certain procedure > how to do that. See > > https://yhetil.org/emacs-devel/m2ldwdrnds.fsf@HIDDEN/ > > where I asked about this, and see Eli's reply. In essence: No rebasing, > squashing, and so on. Following that procedure, is why I posted the > change-log-style commit message for such a merge here. > > My assumption up to a few minutes ago was that that procedure has > changed It hasn't changed. Some people like to rebase, others dislike rebasing. (Full disclosure: I'm in the latter camp.) Since we decided not to care either way, we don't request contributors to do it one way or the other: they can do it however they like, and we will accept that regardless.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 23 Apr 2025 13:28:02 +0000 Resent-Message-ID: <handler.77924.B77924.174541482720929 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: monnier@HIDDEN, 77924 <at> debbugs.gnu.org, stefankangas@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174541482720929 (code B ref 77924); Wed, 23 Apr 2025 13:28:02 +0000 Received: (at 77924) by debbugs.gnu.org; 23 Apr 2025 13:27:07 +0000 Received: from localhost ([127.0.0.1]:55689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7a81-0005RB-EE for submit <at> debbugs.gnu.org; Wed, 23 Apr 2025 09:27:07 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:44306) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u7a7x-0005PE-On for 77924 <at> debbugs.gnu.org; Wed, 23 Apr 2025 09:27:03 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-39efc1365e4so2421213f8f.1 for <77924 <at> debbugs.gnu.org>; Wed, 23 Apr 2025 06:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745414815; x=1746019615; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=PmD3mVRvObB78SVM+3LgMUXgPDydYty2hzJoXX0iVhw=; b=Lybm9aOIrvoCqT7qfors4LsquHWJDJcBF+jXLx1q7EZtVXNs1G4/BHUG2v6Najaemo Jg88aNrFF76EM7wCVwzqcp32aG1EjcfeABlFiRZcIObi7cDjc/mtJwENQ6w/FrXMu77z /OYTfIP1Xh6ReKHlBIGDkclSCAfPfg0TPyxwxdX5oa7HVMiUrK4We8/cgVkNkVQl5nC2 gU94AqL51P7T+RJ6ulJ4+tLb91Z5D1XGDOmeN6tgp6a3xBHcjH4lTRx74PvsXoW9o/aF L4lLeDXk7oBuKwXnK5Rm8l5SyMNeqQVaWjR+0iBjlwJp0I/2NVfrYJYsHK9Z2SyD9CBv CvYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745414815; x=1746019615; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PmD3mVRvObB78SVM+3LgMUXgPDydYty2hzJoXX0iVhw=; b=l6t2baaGNclysOvDC37rcYYC3V9GzH7z4fpQx7NE89N6eEnTij2mFxg+z5ogv7ALOG KQTtutMP65FXyuXD8Q+odxL2Ou0oOWhnM0bTrjwiVKd43mXEzfJm6d2/idfl40Alfb9q FfYFb4sKO/uKH23/PLFFdchY7NW/AML3eZal/Gi6lRhK2ouKkw9l3kjqfNfuq8uuN6dE NKHyNRd5sw9eO79Xn44MajUok4bFrGGV+iHR7Xwn71pp4mqMIgutdvOUGYxkJF5trHcS Rhj8dEiC3Rm6cZooQrIbYXbZUjIAQs+b25zJ1jID+/XfVqkzMbHBAVDnGu4gtndinf0u CBsQ== X-Forwarded-Encrypted: i=1; AJvYcCUUYNYUKkIzn+mI4W3QTrfmCFcVKXZLFYwyri3WFJQdKvsbe+yOtJuNKE/dLBioOoLRTaUSyg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxTontJ0M2E38EgmxmxM0CeuDYDknyAV3Kxhvva17VaQgn12YGZ 4Fz1CqXRLSZfa6oX6hLkhfxR1+AXehrhfE0vUOYk/AzAzEauKtuFzyhlLV3v X-Gm-Gg: ASbGnctXKJcNiTAAZqFNz0xpRor3x4C7PodanGzQg/OYBuIoGRP40JwYyS4F2OvVt/Y xXwGX93ldmU7vBdwqqnWfrq2qjublRx06PB2IeG2XgiA8k083ZkTXElfGzUOFrikVxnpebFZKED fb2Qnm2bnF62QAR1vCYc+76gv9vOvSVWp6GhnYIJbd34ApJ/NxjAXT97DX+TYjcZe/WjmuYUi8B hkX8md2QkM3oplxXSmM3D/IUNQFOC6LyO5+Z0lpr3wz5yMNe+pBwCxO71nIoP4Wy/Wk0qeSa604 fV4QSMmXmm8j9ALSeNZ/zbA4f68sKjsrcKZ4fS00pXkufu3BIXuimS2Cl6lyS0ZqPZsC66AYjlB O1ufVkN7o1/LNOapYNrtU6pPSgIisdQKj1DmtYOGHocfqizejYw== X-Google-Smtp-Source: AGHT+IGBNMy8jVN/yO+QdXSbKI2z1MeNKX56kAuHrZwcxny3TCoFQ4TI6oQY3B8OFmV4vhDuzKieuQ== X-Received: by 2002:a5d:5983:0:b0:39f:ed8:d6c2 with SMTP id ffacd0b85a97d-39f0ed8d6e0mr6838542f8f.4.1745414815082; Wed, 23 Apr 2025 06:26:55 -0700 (PDT) Received: from pro2 (p200300e0b7376d00808a7ba45869fd57.dip0.t-ipconnect.de. [2003:e0:b737:6d00:808a:7ba4:5869:fd57]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4207dbsm18632846f8f.4.2025.04.23.06.26.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 06:26:54 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <861ptj10kb.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> Date: Wed, 23 Apr 2025 15:26:53 +0200 Message-ID: <m2zfg7nh42.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> My assumption up to a few minutes ago was that that procedure has >> changed > > It hasn't changed. > > Some people like to rebase, others dislike rebasing. (Full > disclosure: I'm in the latter camp.) (I'm in the same camp.) > Since we decided not to care either way, we don't request contributors > to do it one way or the other: they can do it however they like, and > we will accept that regardless. Thanks for the clarification!
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Stefan Monnier <monnier@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 23 Apr 2025 14:35:03 +0000 Resent-Message-ID: <handler.77924.B77924.174541887010162 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Cc: Eli Zaretskii <eliz@HIDDEN>, stefankangas@HIDDEN, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174541887010162 (code B ref 77924); Wed, 23 Apr 2025 14:35:03 +0000 Received: (at 77924) by debbugs.gnu.org; 23 Apr 2025 14:34:30 +0000 Received: from localhost ([127.0.0.1]:58213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7bBD-0002dV-I6 for submit <at> debbugs.gnu.org; Wed, 23 Apr 2025 10:34:29 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44127) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1u7bB4-0002bg-9k for 77924 <at> debbugs.gnu.org; Wed, 23 Apr 2025 10:34:22 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C077F4413E3; Wed, 23 Apr 2025 10:34:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1745418851; bh=cSo5HNerwmLuYBwxanuQCn6uXdpsvRrca5/ymddZFqg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=IRlz8sjGz7v9hCuL9YYB+kvICVzQ3N3BCqii1AenDjL2bjbg1sD81E2RptE7SALzn sFum4jAZsPot7H4xjB1ikfsVTNGVy3kvINrEkMBVfDaa2kTsVCvnDSOO5HSJBzm3MY 7a3PH4XUht3HmNTAVnPTpuCoXD/7woIz3+DV7WUzXFOfjBRZul4uyhEFlnQXNshwvc OKoWquWlIfpUl9lwsL+UrHJaGH3OH57gElKPDMnWBIK85bifK/keXPokkzbVUCBywq 2UqWXTg0q3KxcuJwcLnsJevCPhH4LJMOy46uoFY9l3kHpOFhxfR1x+IE6Occ/6iBU9 BnSQ3awyZC8nw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E8C5B4412F5; Wed, 23 Apr 2025 10:34:11 -0400 (EDT) Received: from pastel (104-195-208-18.cpe.teksavvy.com [104.195.208.18]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B3803120262; Wed, 23 Apr 2025 10:34:11 -0400 (EDT) From: Stefan Monnier <monnier@HIDDEN> In-Reply-To: <m2zfg7nh42.fsf@HIDDEN> Message-ID: <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> Date: Wed, 23 Apr 2025 10:34:11 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) FWIW, I'm not a great fan of rebasing either. I did rebase the branch last night not for rebasing's sake but because I felt there was a need for more detailed commit messages. In any case, any objection to merging the branch? Stefan
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 23 Apr 2025 14:42:07 +0000 Resent-Message-ID: <handler.77924.B77924.174541930114748 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier <monnier@HIDDEN> Cc: gerd.moellmann@HIDDEN, stefankangas@HIDDEN, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174541930114748 (code B ref 77924); Wed, 23 Apr 2025 14:42:07 +0000 Received: (at 77924) by debbugs.gnu.org; 23 Apr 2025 14:41:41 +0000 Received: from localhost ([127.0.0.1]:58225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7bIA-0003pK-8G for submit <at> debbugs.gnu.org; Wed, 23 Apr 2025 10:41:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43354) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1u7bI0-0003n8-MB for 77924 <at> debbugs.gnu.org; Wed, 23 Apr 2025 10:41:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1u7bHu-0003p0-U0; Wed, 23 Apr 2025 10:41:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uZZR5XNQBhzq4j8Wxt708by1PnPUpHpwmwrJGKVqdqY=; b=Tk600g5B1Vqn og+RgQYouAgP43bq58xGw+41PGsbX17XD78uj2gngu2+ZiwHhMGt/qLCZFZYz9QiRLLzHhZpMwyXh fswsQBEpNyid7oS5WZ7vhtuwNhjjcL7odzrb8edjOx6HZgF/gqymkMh7ckY45MYR7tzyyk2/CGNI+ 2i4vaz5yUdjEbJTxzI8F1o7tjvDxMpz8H2QrZqn+q41mrlrdnfcy5V2E4ipu7iryWtY1LiAfA1BYs ptN/vlheaFcCYkGqR5fUHFG/0KjoulSDq/I4S6T0y39gsteTomRVf9cihjbibZRSuWNXcDohTLZgg DKh0nozfK7gf+WCkUOyurw==; Date: Wed, 23 Apr 2025 17:41:18 +0300 Message-Id: <86plh3ym7l.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> (message from Stefan Monnier on Wed, 23 Apr 2025 10:34:11 -0400) References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Stefan Monnier <monnier@HIDDEN> > Cc: Eli Zaretskii <eliz@HIDDEN>, stefankangas@HIDDEN, > 77924 <at> debbugs.gnu.org > Date: Wed, 23 Apr 2025 10:34:11 -0400 > > FWIW, I'm not a great fan of rebasing either. I did rebase the branch > last night not for rebasing's sake but because I felt there was a need > for more detailed commit messages. > > In any case, any objection to merging the branch? I'd like to have a closer review of it first, so please wait for a while. When I skimmed it, I remember having several, hopefully minor, aspects that stood out, and I want to take a closer look.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 23 Apr 2025 14:48:09 +0000 Resent-Message-ID: <handler.77924.B77924.174541967718417 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: monnier@HIDDEN, gerd.moellmann@HIDDEN Cc: stefankangas@HIDDEN, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174541967718417 (code B ref 77924); Wed, 23 Apr 2025 14:48:09 +0000 Received: (at 77924) by debbugs.gnu.org; 23 Apr 2025 14:47:57 +0000 Received: from localhost ([127.0.0.1]:58255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7bOG-0004mv-8U for submit <at> debbugs.gnu.org; Wed, 23 Apr 2025 10:47:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41444) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1u7bO4-0004ks-NL for 77924 <at> debbugs.gnu.org; Wed, 23 Apr 2025 10:47:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1u7bNn-0004aD-Je; Wed, 23 Apr 2025 10:47:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=byOoPkj1vy8BboUloOVWJzT9AjjCMI/XWLbz+9+Zqmk=; b=iKytlme/TSkx 1cW82ACTd0c7mq0mLHwlrwAStiDMrG5GlUP0FKjl/tU81W+IOp6PhaJHU+VHLOCgHXDCPuf6C+A5K WRjQzgIevZxUWX421JjwJdJ7QODBK4JuyR59XahZED5KSElLayMl5g/NKWASCt0DOCUzXSxr8XgWj M0OAHpoZbfj5SrPKWChg+BsBSwfpROlUHtRVC4l16zDZvbnMRhPrQdPdDTPhx5i9nM2SSw1Vt6Hn1 2tlRks7fFN+TQAMzb/qgDSx+1ajZzQZlmDB4Y21TNUpgEZ83qlWWvsr8NmzYWXmnmEtB6UDxOjq/H 9ciQUz1lWWoHKllK0MC8Iw==; Date: Wed, 23 Apr 2025 17:47:24 +0300 Message-Id: <86o6wnylxf.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <86plh3ym7l.fsf@HIDDEN> (message from Eli Zaretskii on Wed, 23 Apr 2025 17:41:18 +0300) References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: gerd.moellmann@HIDDEN, stefankangas@HIDDEN, 77924 <at> debbugs.gnu.org > Date: Wed, 23 Apr 2025 17:41:18 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > > From: Stefan Monnier <monnier@HIDDEN> > > Cc: Eli Zaretskii <eliz@HIDDEN>, stefankangas@HIDDEN, > > 77924 <at> debbugs.gnu.org > > Date: Wed, 23 Apr 2025 10:34:11 -0400 > > > > FWIW, I'm not a great fan of rebasing either. I did rebase the branch > > last night not for rebasing's sake but because I felt there was a need > > for more detailed commit messages. > > > > In any case, any objection to merging the branch? > > I'd like to have a closer review of it first, so please wait for a > while. When I skimmed it, I remember having several, hopefully minor, > aspects that stood out, and I want to take a closer look. Btw, did I miss some benchmarks? I presume that the main motivation for this branch is to speed up markers and charpos-to-bytepos conversions, is that right? If so, the only benchmark I saw shows only a very mild speed-up, but maybe I missed something?
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Stefan Monnier <monnier@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 23 Apr 2025 15:37:05 +0000 Resent-Message-ID: <handler.77924.B77924.174542262221223 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Martin Rudalics <rudalics@HIDDEN> Cc: gerd.moellmann@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, stefankangas@HIDDEN, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174542262221223 (code B ref 77924); Wed, 23 Apr 2025 15:37:05 +0000 Received: (at 77924) by debbugs.gnu.org; 23 Apr 2025 15:37:02 +0000 Received: from localhost ([127.0.0.1]:58386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7c9k-0005Vt-SA for submit <at> debbugs.gnu.org; Wed, 23 Apr 2025 11:37:02 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:21220) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1u7c9h-0005Ue-VX for 77924 <at> debbugs.gnu.org; Wed, 23 Apr 2025 11:36:58 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0310E10002E; Wed, 23 Apr 2025 11:36:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1745422611; bh=ffx/workOmf5tCpcmV0NMeE5mndTlGu583Igm9eUnPQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=TYW564DObV5w2C7t2VQcdxnUYcQBMHVvOyDIc4o0vEWMgkbLyFVRiQ0li2xhu/RJc +I/JzXDMUw7mqRq77EM0/FL0QYOSmU8by7Ib83PUXrR8Tkzz+a2yznrK2RgLWCqxrN W/F+j/vV4tJ1zd36ts/MV/tJLMGUaSBPyUVR8pYtIv9lo51b4yf900o8LmNqxdhyP1 qFVnWjeCCvi8dVbzcLJmLUyeesjqfEY47aPIxHaxoU5ejq/lr4QMRV490HV0nnfhev /+V4ChEUZ7bDKIrUJ0nkUIFmW10ziaE38+qI8h9vAOVixEKFSRVhOaQnExyq4bBaEe 4JV4VJwvKfQpQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3FBBE100027; Wed, 23 Apr 2025 11:36:51 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3000F12022C; Wed, 23 Apr 2025 11:36:51 -0400 (EDT) From: Stefan Monnier <monnier@HIDDEN> In-Reply-To: <86o6wnylxf.fsf@HIDDEN> Message-ID: <jwvjz7agaos.fsf-monnier+emacs@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> Date: Wed, 23 Apr 2025 11:36:36 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.105 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) [ Hi Martin, need your opinion on `marker-last-position`. ] Eli wrote: >> I'd like to have a closer review of it first, so please wait for a >> while. When I skimmed it, I remember having several, hopefully minor, >> aspects that stood out, and I want to take a closer look. Please do. I hope my rebase makes it easier. =F0=9F=99=82 BTW, during my rebasing I noticed the following incompatibility: commit 89ad510b2ebd5ed3ed8477e4a45ada3402bcedca Author: Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> Date: Thu Apr 17 08:42:52 2025 +0200 =20=20=20=20 marker-vector.c: Move marker's position info to the array makes it "impossible" to implement `marker-last-position`. AFAICT this function is not used outside of Emacs at all (based on a search of all *ELPA packages), but it *is* used in `window--state-put-2`, since the following commit: commit 912e37b811107768e0cb3bc95184177f817dbdb2 Author: Martin Rudalics <rudalics@HIDDEN> Date: Mon Mar 4 10:33:49 2024 +0100 =20=20=20=20 Fix 'set-window-configuration' and 'window-state-put' What's the impact of breaking `marker-last-position`? Stefan
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 23 Apr 2025 16:11:03 +0000 Resent-Message-ID: <handler.77924.B77924.174542461811721 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier <monnier@HIDDEN> Cc: Eli Zaretskii <eliz@HIDDEN>, stefankangas@HIDDEN, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174542461811721 (code B ref 77924); Wed, 23 Apr 2025 16:11:03 +0000 Received: (at 77924) by debbugs.gnu.org; 23 Apr 2025 16:10:18 +0000 Received: from localhost ([127.0.0.1]:58490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7cfw-00032P-Re for submit <at> debbugs.gnu.org; Wed, 23 Apr 2025 12:10:18 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:53730) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u7cfs-0002yD-Fl for 77924 <at> debbugs.gnu.org; Wed, 23 Apr 2025 12:10:14 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-43cfba466b2so66856175e9.3 for <77924 <at> debbugs.gnu.org>; Wed, 23 Apr 2025 09:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745424606; x=1746029406; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eV1tYS8iSRNx5VHdGjj5ZLuaPazEnVMlqsYqXNi6B7g=; b=WWpU922kIA4WyeNcA89SpqNElJEBrr+2L3GcQ0S6llvVM6ke9lzxGBCYPsth7kbsPk OcgbB/DSquEwPzPDxukqZ5JDuYgKSl1H1wMNV1mnnWBM9m5vaiqn0xF4ZMY5CYJt/N8H d6sSyz7JHzvLhn1DprwHotiECVh1GEaIH+ttaQSZDm4OhyKifwsMX5nx+lUDTgvPyPom D9NSoyV3twpF7rA/Ccot8nBCRhVrLpTI0yWiqkKKj8luJiooaQc78v8R4+oMSEPA5eGA p4yB6fgQ8zOLbM9SCIH7bjY7CmsbfchJvu1+8hNCuicr3yrqa/AbfbLcaX00DB9XVHSz pORw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745424606; x=1746029406; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eV1tYS8iSRNx5VHdGjj5ZLuaPazEnVMlqsYqXNi6B7g=; b=Q8Fpl+VR5RqKeFg4ltygMCwiOoHB02rI6lneOX4so5EXnQdv1IuZt4Dkt7HBGd2gqn sf1j2g98N7HCxfIOZSFzzhlgx8J8LurT9xQqk9OvEQs33IzJ307UU6imvzZaYOMNTDCx pmaC5gVwPLU3w92E4tRsHtjIm8JTWxbQJV4EcapU49Ik74UVD0hv8VjMQCP/ebRtdyXR 9MWYd0VGURRkP88d8nPrKrMFBpPRq1ug6b+al4NRv2RvPs7vEiYiUFuHdSGHLS5DO9Lp 32UeSWEa5LFmoCG6Cud5h0JNHJcfsGHnSzlXv2lh484pHyOdW/KfNVo6PMV34VLfyqEo FqAQ== X-Forwarded-Encrypted: i=1; AJvYcCV9L37iK3+HTZsEFZe+NSBf/TWGrOFq+NtBkN6vxn8eF45eTiWV6h0u1+Qw6IorPbDKGYwiWQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzYoJzR9/fnBPNzVZrDgYqFiOc+m57rox4ak91tkma/w6wy9SoA vYpGBL+fRairQ/PiGJbvNJIMaXJkv5mQimxtgO4J3NZtFV02IdDNBFohYhOK X-Gm-Gg: ASbGncuzbKuTwimyn6zJlP/bYECADfg6FcHXg+f4cx//ENlC3hlEI9xDs4oiDq2xJEb 0ev1dS2LzD3pjZLPxKZUf2J9wtraw3OmeNwj2RVL30LxAcFQDB8baQbaVt/0GrnsXbk4yr7REPx dmM4ibI0a5aID7R1seiWW1NJk6jrNDX+4M8vldMN7M9p2Q5TggecX4/JRJiAsde3Tq2HpgKwlCv pUwa3tPHTfHMkhZjB5b+0GXg3U2NUd3oDGsVKzppSOt4Ma9bFi1xrXWarWA1pRsd3xP+iGrIoLl Px3O96UMROqMJ2vp23Hr1gKVhK9xaV0JRv0RVrmRiNv8f2Sk3PplSOOoYxSSAaPfWAsmaGeF4o9 rHF2+BPS2X+UT+SqssvADA0mRv0ioh2i6GRCLY0VM13cYr7HEWg== X-Google-Smtp-Source: AGHT+IF3xjq4XXmm4gFrhmQcQHQOJlHaH8cHc+Np0wgrSu5FBgDJw1hPhJNV8lnhICa31HxTbzAwhg== X-Received: by 2002:a05:600c:1383:b0:43d:23fe:e8a6 with SMTP id 5b1f17b1804b1-4406ab78e24mr145960975e9.5.1745424605694; Wed, 23 Apr 2025 09:10:05 -0700 (PDT) Received: from pro2 (p200300e0b7376d00808a7ba45869fd57.dip0.t-ipconnect.de. [2003:e0:b737:6d00:808a:7ba4:5869:fd57]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4a498csm18973762f8f.85.2025.04.23.09.10.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 09:10:05 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> Date: Wed, 23 Apr 2025 18:10:04 +0200 Message-ID: <m2msc6oo4j.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Monnier <monnier@HIDDEN> writes: > FWIW, I'm not a great fan of rebasing either. I did rebase the branch > last night not for rebasing's sake but because I felt there was a need > for more detailed commit messages. > > In any case, any objection to merging the branch? BTW, while porting back your changes, I got 1 emacs-git =E2=80=A6 am --3way -- /Users/gerd/emacs/github/cl-packages/0= 003-marker_vector_adjust_for_delete-Delete-function.patch Markdown-style quotes in commit message Markdown-style quotes in commit message Commit aborted; please see the file CONTRIBUTE :-)
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 23 Apr 2025 16:24:03 +0000 Resent-Message-ID: <handler.77924.B77924.174542544121518 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier <monnier@HIDDEN> Cc: Eli Zaretskii <eliz@HIDDEN>, Ihor Radchenko <yantar92@HIDDEN>, stefankangas@HIDDEN, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174542544121518 (code B ref 77924); Wed, 23 Apr 2025 16:24:03 +0000 Received: (at 77924) by debbugs.gnu.org; 23 Apr 2025 16:24:01 +0000 Received: from localhost ([127.0.0.1]:58521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7ctF-0005av-9k for submit <at> debbugs.gnu.org; Wed, 23 Apr 2025 12:24:01 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:43419) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u7ctB-0005ZH-EB for 77924 <at> debbugs.gnu.org; Wed, 23 Apr 2025 12:23:58 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3912fdddf8fso886801f8f.1 for <77924 <at> debbugs.gnu.org>; Wed, 23 Apr 2025 09:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745425431; x=1746030231; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZBnCY05jVwquqDXWob+MyVwxSbObnp/Uw1s1LTsavCs=; b=LcvJXGcbSsR0nXU43Lzpd5bzFGomtWF/XtQkHVi+kiZ4gUZ+f/joSNH+y01yJlfKZM jhF+8i+3FDZak4nXkT7vH/Gt7KkJorMHrOzDdIJ/JZAOafs8PjG8+sIlEWyJHHYmR/Bk 4ogg0srUMyQixP9v38qm5pkIEPn+Sy5TEBb14s/S/dRe2tZ2W/jrol+OgjfpM/ZEy0Ey U6bzV93IF3RryVxDVX/G5vIvCRqHPyTecNZauTI68CpJsKxAZwyjKyQvb6ZtYANB73dY 78Tf4ZzBnIE2bLfRTn09I7mZ3z24CjQHj2IYGpJQ9BzsOPkeHQCcimXB7NERk2nBFObc HMVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745425431; x=1746030231; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZBnCY05jVwquqDXWob+MyVwxSbObnp/Uw1s1LTsavCs=; b=ScPaXIATZTpkcK2BNmiEhWd7BpfmAZVN48JQdXTMA7SfmgSz6hYz5Df4WQoYBm+VPE v7JvoEO1VveQoYfqyXl3IAAFcQNimTpAjRrDLQhtyJBQw5ut3/zV5NQ44iAuXcSqdG2O hZUUA5C3uk6LRGKitvGJNznhvEXQoK0dihkX4dkZda3vLmT0NazWM7RaDD64nJZC428+ vijZUqZcNqXKWxqi39do+p9bTiNaCn6It4uM7pOKJiJfqvwTUyDBIlMjf5BShnIymZ3q rdggKCf6KmTzmNRYP+UNb7k8Km+WgltFg8edeIVvY7lDkTkjRyUNEQTt9vNgLB7D/aQm 2mew== X-Forwarded-Encrypted: i=1; AJvYcCURAovt66ZeEuNwPRa4zo/HSE+uVQpqhqW+MJjBwZ5kDb1+/B1iGwgooRXB6kAWpqajkWjYEQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxKfBSWIMHplr+01MRjEuYcFfni4dXuUZB7RDiRfRRmWslH8W7L 340NME5BvZ3fF8fA7A7xpSFJ/12o1+xFFneJPYHTJVD/0yi3Z3cM X-Gm-Gg: ASbGncsVLIst8LKLmuOGoJuZbHGHYOVWh0X6qU45DMftiOk+IMOVCrldLzqmP9Rg0Q/ g2q/Z6zzHgi6lEBrQQnqFzZRTAfL0BG7h8ZiV+of0yTkmpV+CzYlFrECxU7yZRkC5I3zLFc9SY5 dKu9YYFFndRfGiubHefwCk5wv6TQaD5nrPSW7SQ//3CY+0M3smwDy5yKUfaUgt0af+CRj/hcsly G/nWlEfFV1d9Um8L9POzTbYTorDXvC7agfro/0jXPhcs7x0vqhnBOytytR9j3iLKdKTXGMEWKgP iyxyOnFqRuvIs/WNSWHnEMn2uE91I9+uOdrvqxVhy7wbm8GiZaxci7GJXoLzDTSLt1S8MEcLqLp ooPeYsv+xlymp3FJeBZ5ekuKuIdOPgckqXX7IcHzQBXhyy1AvdA== X-Google-Smtp-Source: AGHT+IGPx12cVg3ALlwEMXZkylJo0auQCjculeAEgtkvgvKZHMEamJXX1Nd/3ZlwtSux3jyqYCiQNw== X-Received: by 2002:a5d:648d:0:b0:39e:cbca:8a72 with SMTP id ffacd0b85a97d-3a06723a853mr3020042f8f.12.1745425431136; Wed, 23 Apr 2025 09:23:51 -0700 (PDT) Received: from pro2 (p200300e0b7376d00808a7ba45869fd57.dip0.t-ipconnect.de. [2003:e0:b737:6d00:808a:7ba4:5869:fd57]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44092d178aesm31435895e9.8.2025.04.23.09.23.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 09:23:50 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <jwvecxiga9d.fsf-monnier+emacs@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvecxiga9d.fsf-monnier+emacs@HIDDEN> Date: Wed, 23 Apr 2025 18:23:49 +0200 Message-ID: <m2v7quonhm.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Monnier <monnier@HIDDEN> writes: > Gerd and I played with some micro benchmarks to confirm that the > pathological behaviors are indeed solved, but other than that, the focus > was on making sure the branch does not make the normal case slower > (contrary to my sorted-array-of-markers-with-gap). And, not to forget, it removed the cache markers which piled up a bit in igc. That was actually my original motivation at the beginning. Very nice, but so far only for. And, I don't know if that's wishful thinking, but it feels a bit snappier in interactive use.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Stefan Monnier <monnier@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 23 Apr 2025 16:30:07 +0000 Resent-Message-ID: <handler.77924.B77924.174542580225500 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: gerd.moellmann@HIDDEN, Ihor Radchenko <yantar92@HIDDEN>, stefankangas@HIDDEN, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174542580225500 (code B ref 77924); Wed, 23 Apr 2025 16:30:07 +0000 Received: (at 77924) by debbugs.gnu.org; 23 Apr 2025 16:30:02 +0000 Received: from localhost ([127.0.0.1]:58542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7cz1-0006cy-Vy for submit <at> debbugs.gnu.org; Wed, 23 Apr 2025 12:30:01 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62294) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1u7cyz-0006bj-LW for 77924 <at> debbugs.gnu.org; Wed, 23 Apr 2025 12:29:57 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4BFA980911; Wed, 23 Apr 2025 11:41:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1745422911; bh=S16DMYFoKf/EaVE6DyAn2JaKqqvN8b3xl9NnOsSZznY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iTpCVPiGxFRz+BiPFY/5wKMxatR2PwQbQ1dRJzOkw7IXxnNseAFIqApu+8ZzIEOzQ +EnJmdB5y4tDaNHI20Hna6+Co8DF85fWnDzqPRLtDUy+lXufqp5BOX4NdIkF7ucsC/ ZC1sAfIKfm5RYfahji+VLxgth11XrMiAgEdfLKoA9TDjLDzE454Ioj0ZAtxTuMcJgg Gj8b/M9KMCMbKaQGOlQd3mrt70gdo/9cfRtLZEtpH0rVSbAmBjHAiqT2bVE2zfG+jM JUYxh7/g40Fx5kotVJOlPT/SQ6bIbCAAWjKeqVAKE+Nxm9OvKME9CYhsmCjcnvsVkw SFk7AXWdn3IhQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8732980823; Wed, 23 Apr 2025 11:41:51 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 780551200E4; Wed, 23 Apr 2025 11:41:51 -0400 (EDT) From: Stefan Monnier <monnier@HIDDEN> In-Reply-To: <86o6wnylxf.fsf@HIDDEN> Message-ID: <jwvecxiga9d.fsf-monnier+emacs@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> Date: Wed, 23 Apr 2025 11:41:43 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.207 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Btw, did I miss some benchmarks? I presume that the main motivation > for this branch is to speed up markers and charpos-to-bytepos > conversions, is that right? If so, the only benchmark I saw shows only > a very mild speed-up, but maybe I missed something? AFAICT we have tuned the current charpos<->bytepos conversion code such that its worst case virtually never shows up in practice. Supposedly Ihor has a use case where that conversion still can make a noticeable difference, but I don't know if he tried the `text-index` branch to confirm that it makes a measurable difference on his case. Gerd and I played with some micro benchmarks to confirm that the pathological behaviors are indeed solved, but other than that, the focus was on making sure the branch does not make the normal case slower (contrary to my sorted-array-of-markers-with-gap). Stefan
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 05:02:02 +0000 Resent-Message-ID: <handler.77924.B77924.174547088827814 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier <monnier@HIDDEN> Cc: gerd.moellmann@HIDDEN, yantar92@HIDDEN, stefankangas@HIDDEN, 77924 <at> debbugs.gnu.org Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174547088827814 (code B ref 77924); Thu, 24 Apr 2025 05:02:02 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 05:01:28 +0000 Received: from localhost ([127.0.0.1]:33497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7oiF-0007EV-FN for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 01:01:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47780) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1u7oiB-0007Da-CT for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 01:01:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1u7oi5-0004SD-84; Thu, 24 Apr 2025 01:01:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2FUNtTtQ+QfWwDzE1OnAuGQr7x+6BOOTNOnUTUghUQM=; b=KkhowpNPHwTk nNyN9WE2LNjmXkcB/WNH5BIhWheFnZvfx6upbaYc7JPVaF2PuNuxY4Nn3kMszcVWK2sLP3HJbWR3U 4Iz1ROUWsSAAv7S6GBXseZSQX1agnIzcq8Kxxrpi58Eed4PMhzDupXime451W87XQChQb/pBBu7k1 QIrN0m6BAcf7jJ02nLTzpKXQDqyX5GyI59iSQxT3EQuvMC/E12U/wBJGXCKV3ywBY1i9jlzfhOJ3I 6Ljwe6lSWVL6R8D+MkotIBchhl3JwtjhhO3TpTq3a1PLoylR/Bxw6CVpOJTsdW/02L3rs5MCiEA1s 8RWs2zhPJk4pYfzFskIypg==; Date: Thu, 24 Apr 2025 08:01:10 +0300 Message-Id: <86msc6ywyx.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <jwvecxiga9d.fsf-monnier+emacs@HIDDEN> (message from Stefan Monnier on Wed, 23 Apr 2025 11:41:43 -0400) References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvecxiga9d.fsf-monnier+emacs@HIDDEN> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Stefan Monnier <monnier@HIDDEN> > Cc: gerd.moellmann@HIDDEN, stefankangas@HIDDEN, > 77924 <at> debbugs.gnu.org, Ihor Radchenko <yantar92@HIDDEN> > Date: Wed, 23 Apr 2025 11:41:43 -0400 > > > Btw, did I miss some benchmarks? I presume that the main motivation > > for this branch is to speed up markers and charpos-to-bytepos > > conversions, is that right? If so, the only benchmark I saw shows only > > a very mild speed-up, but maybe I missed something? > > AFAICT we have tuned the current charpos<->bytepos conversion code such > that its worst case virtually never shows up in practice. > > Supposedly Ihor has a use case where that conversion still can make > a noticeable difference, but I don't know if he tried the `text-index` > branch to confirm that it makes a measurable difference on his case. > > Gerd and I played with some micro benchmarks to confirm that the > pathological behaviors are indeed solved, but other than that, the focus > was on making sure the branch does not make the normal case slower > (contrary to my sorted-array-of-markers-with-gap). Still, for performance-oriented changes, it would be nice to see some benchmarks. Scrolling through some large file with many non-ASCII characters comes to mind (the Unicode UCD has quite a few of such files). Also, I believe there were cases where a lot of conversions created gobs of markers which slowed down things; it would be good to run those cases to see how they are affected. And finally, how about running the whole benchmark suite we have, in case it uncovers some unexpected results? Thanks.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 05:43:02 +0000 Resent-Message-ID: <handler.77924.B77924.174547335621266 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: yantar92@HIDDEN, Stefan Monnier <monnier@HIDDEN>, 77924 <at> debbugs.gnu.org, stefankangas@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174547335621266 (code B ref 77924); Thu, 24 Apr 2025 05:43:02 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 05:42:36 +0000 Received: from localhost ([127.0.0.1]:33833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7pM3-0005Wv-Tf for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 01:42:36 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:51613) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u7pLx-0005Vf-NP for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 01:42:31 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-3995ff6b066so243822f8f.3 for <77924 <at> debbugs.gnu.org>; Wed, 23 Apr 2025 22:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745473343; x=1746078143; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Iu1pI3kf35bt0Ai5AF1lvMYxu5X+zRnoaIXDJ1FPSio=; b=i0sQIJ3/PbeOYGD0qPaGx3RAdtxu4w75xPFLFg6rQ9O7oE7LrSm3SVRw4RlUfGgl8n ebC5G2vOsNRW6R22y9XrOIxCirCqHOl2HE5NLa6cPpQ5kj8ylbO33V8NSTvPY8Y6M393 QM6GbMJU8X1k3GUi9IcDmbSAYfWdEAailWpjYPilkfdoxxtoO3PU30duR9vo8R2OQzIC MDxEKPr803pdePpTXFtLZRenjWqdSnKgzxvQrl8rEJNUvk1wwUwr2g07HTwYNgWEXnuq OLvgZbyKqvXkpHTDBTHBUev15JCAmxloBsN5vq5vsWxTuUmZvKbxEupO8F2DKgk0aUqm 4bMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745473343; x=1746078143; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Iu1pI3kf35bt0Ai5AF1lvMYxu5X+zRnoaIXDJ1FPSio=; b=dekOeV3/1xSGhPctHpWMY8nDjppOJbYkpkXtw53NDAULO6kf4g7f7BX+9m0tytduhk CG0xZw3SULLPMZlYSdhYjEmy5RqKdMeyMgDj9GNGTv5rBbk1oglFge/nriYS6sMXPoyh Vy6LxXtUChwNZHea3l71jvp/eGzaZHXuOpZfBPCUhdcERpIOHLlF9q5l5zD6iGjxbZyR umuvG2ihn5kiYmCsSNih2U7wHawkOx1jGLlGM1NWRN5bARF3AT4ULOF8qiA6wwAVMQlE +bqf51Wony2Jj22qrwz7O9oVAghobERpFoWBdqB7o+a3LDhZNb2R5xWi5vk+f1Kq50rS 1CAw== X-Forwarded-Encrypted: i=1; AJvYcCW6YpieAM19qyzklQM140twxlmsOHyg0hRyj+CAPSMIFPXgfUpNxNvPjdGdXWJPiBakEI/SVw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyA76IAE1tCO52ot+kDAmiT9819+B+0Cn0jsc/CRHas07BW7WRz oR6r1j+Jp3jU0WWJp0BNZNF7hAvpHPNAxVX4Fax5o/c15Mwh8FNe X-Gm-Gg: ASbGnct+8IbDUw3mJJjpzUEHCzN6hnrGpPuS3DRaHMKQly3o06kzUvFTH5cHRrDsI0/ A5awx3rnpBo2ur7TwujwGooMqaUhgL1AE/wPi+FHy0eAIA0SnV8wxNUUNyG+Hfbb2DvDqTFWtzR hmqBF3lfXI4ORI+TWG4UQNuxd1qXnjWmXXZhY/WwnPf2V9ylUUkA5aL1ldLXtN4qaaBTBBvS6RI FSZ+5wvkb2+S2jEytaqT4TFfwbt9HMdzEFob1eBnv9zR1BplV343H6tWy/OsawQQchn/lFKcvHb yBDLJEgf+pB/2Zt+YLz0hHfxhHxxZeLUR8FdUuAyeBHh/Op/mVMto82OHjfoSiiLB6VLn5V/xJA hZMZ/ULZKuh9yav+1LQyBqJs8zRz3S0iHf56v7x7TDD4u/9r1eQ== X-Google-Smtp-Source: AGHT+IFAKPPXYiOuag8ubKQWlXlDqv8TYsiz4IEIydDan/YnW9+7kVtefFMKjeX0a8WKslvds907Ug== X-Received: by 2002:a05:6000:228a:b0:391:29c0:83f5 with SMTP id ffacd0b85a97d-3a06cfa2f2cmr766351f8f.44.1745473343266; Wed, 23 Apr 2025 22:42:23 -0700 (PDT) Received: from pro2 (p200300e0b70e65008c33e61e626c43d3.dip0.t-ipconnect.de. [2003:e0:b70e:6500:8c33:e61e:626c:43d3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d4c492fsm861276f8f.42.2025.04.23.22.42.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 22:42:22 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <86msc6ywyx.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvecxiga9d.fsf-monnier+emacs@HIDDEN> <86msc6ywyx.fsf@HIDDEN> Date: Thu, 24 Apr 2025 07:42:21 +0200 Message-ID: <m2ikmunmiq.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> From: Stefan Monnier <monnier@HIDDEN> >> Cc: gerd.moellmann@HIDDEN, stefankangas@HIDDEN, >> 77924 <at> debbugs.gnu.org, Ihor Radchenko <yantar92@HIDDEN> >> Date: Wed, 23 Apr 2025 11:41:43 -0400 >> >> > Btw, did I miss some benchmarks? I presume that the main motivation >> > for this branch is to speed up markers and charpos-to-bytepos >> > conversions, is that right? If so, the only benchmark I saw shows only >> > a very mild speed-up, but maybe I missed something? >> >> AFAICT we have tuned the current charpos<->bytepos conversion code such >> that its worst case virtually never shows up in practice. >> >> Supposedly Ihor has a use case where that conversion still can make >> a noticeable difference, but I don't know if he tried the `text-index` >> branch to confirm that it makes a measurable difference on his case. >> >> Gerd and I played with some micro benchmarks to confirm that the >> pathological behaviors are indeed solved, but other than that, the focus >> was on making sure the branch does not make the normal case slower >> (contrary to my sorted-array-of-markers-with-gap). > > Still, for performance-oriented changes, it would be nice to see some > benchmarks. Scrolling through some large file with many non-ASCII > characters comes to mind (the Unicode UCD has quite a few of such > files). > > Also, I believe there were cases where a lot of conversions > created gobs of markers which slowed down things; it would be good to > run those cases to see how they are affected. > > And finally, how about running the whole benchmark suite we have, in > case it uncovers some unexpected results? I can offer to run benchmarks on my Mac mini. But we should agree upon what elisp-benchmark files I should use and on the number of runs, because running them takes an eternity, and because some of the benchmarks Stef (and me for elb-search) ran are not in the "official" elisp-benchmarks package. Don't know about the scrolling benchmark. Is what is in elisp-benchmarks enough? If not, can you please give me a bencnhmark file for what you want benchmarked?
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Visuwesh <visuweshm@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 06:02:02 +0000 Resent-Message-ID: <handler.77924.B77924.174547450627780 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: gerd.moellmann@HIDDEN, yantar92@HIDDEN, Stefan Monnier <monnier@HIDDEN>, 77924 <at> debbugs.gnu.org, stefankangas@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174547450627780 (code B ref 77924); Thu, 24 Apr 2025 06:02:02 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 06:01:46 +0000 Received: from localhost ([127.0.0.1]:34016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7pec-0007Dy-A6 for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 02:01:46 -0400 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:57450) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <visuweshm@HIDDEN>) id 1u7peZ-0007DX-HA for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 02:01:45 -0400 Received: by mail-pl1-x644.google.com with SMTP id d9443c01a7336-224100e9a5cso7720245ad.2 for <77924 <at> debbugs.gnu.org>; Wed, 23 Apr 2025 23:01:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745474497; x=1746079297; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=79jaPFDtTTrB5qdmUUdnvFyWF9PKdyVJERdh8gR2r+g=; b=e2QZ1x8YesPrdz5uC8EmpxJ77btB0bSDca5+Q68e1e8vAmrzKVemt0/6oJUnR6n1ve aVqWIpVd9wckQLkaKsNGIXI6FQ6mldJEuHvnpyg43vNM8HskwxviYg+y6pfc75tOUrk0 epA+yBg4ics/skTXFGDP7AEN3gz+5/GxPkWo6ILVk26Js/Hd67NOgcVX5rvi+Bp46ank +FCRLu/WDBx9wMRcS8yrVRoR7EUPsK+qcxHuBtgb/VUSCQIwBSXWkGcr7OCxegEQvnJv 4cjwIT6kmoZjRcty+YfxM4u2YVoxe9jgvN92SRl8nph8DR9kdVAEJz6choXKq4BEKOaB yq0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745474497; x=1746079297; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=79jaPFDtTTrB5qdmUUdnvFyWF9PKdyVJERdh8gR2r+g=; b=G7tuky+Hu1HPRFwEVUEDtXpdSjgqltUyIkh59y5O+hIfC+mMFEVdek/7slVvjuT9q/ xQSfKlByAYn9xbV0W4DaxbAfHEoHHBeb58LlLQ59XhMtF3+qHQApMEsoDaZSyfRi3Sp7 39v227OVPLxY4WGxO7lkqLiQNnur0fYzRG10bMwJTfl1ZqcM/AaXlvIs5L0kCp6TEIkB Xwv+G594yJwW7ZutM916s0TdjFPFTv6PUHcGgwJS4210NQfKmLSvdfTXDck4/weYBkha TSghYKnsli6ztbgFLFFCa7yocXI6JGvnplwdjSlZfym9d2fwritFvVfA3RfSu7IAHezI WQHA== X-Forwarded-Encrypted: i=1; AJvYcCU+BwTJws2dcARA9DDD16CMFxrNfkQZc+RfBbf+8g2TTQJXkinnG+3Z20Mo4eSR15A0Dx8dKQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwVwK115c13GnLpgiwN4GIgjWHBz9yfjQsHkn3Ia7aKXyiSL8L2 YKvS44pzYJHpm2b9ZmwEyLqG4RLshVAsrcR35XyXUgyCj55jF+NN X-Gm-Gg: ASbGncvmOxOjDrsfYHpvBY5dWaZCwpGIwy+uyHLfIOQX02IQf07jiK1zVEecOhV3Gwy Dk2a2wA7rpyFwT9wvWTyn3BV4iKBQItxVvetXglahWriqCBxaC1/r1fPL5nmS1VnnesC+VXai+K w/mx35YzDF5lF/P7j9HgoTecOHE29p2BHCBtc6trt7wL2mCH2JOO2Yn0YmYc4mJ/JO0U34GwDw4 pf+pxLh0fqTGYQFznLjLnduVrzCv3IoI3HIW9e6dLzUjaWcBxK+nFkcKUlUbNujiMkDeBBKePdM aPGoS9IuBFhHNP+CCfBkKiXi5gnmWOXUND5W5Q== X-Google-Smtp-Source: AGHT+IFUTjmTvjXMurOoCCmgB31mMsYTeKmn6x2ewRUehz/hLUWlDisz9Ky5LEWOWf4AILCV60yCfQ== X-Received: by 2002:a17:902:cecb:b0:223:5525:6239 with SMTP id d9443c01a7336-22db3d7afcdmr20704205ad.38.1745474497224; Wed, 23 Apr 2025 23:01:37 -0700 (PDT) Received: from localhost ([115.240.90.130]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-22db50e79f7sm4692155ad.155.2025.04.23.23.01.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 23:01:36 -0700 (PDT) From: Visuwesh <visuweshm@HIDDEN> In-Reply-To: <86msc6ywyx.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvecxiga9d.fsf-monnier+emacs@HIDDEN> <86msc6ywyx.fsf@HIDDEN> Date: Thu, 24 Apr 2025 11:31:33 +0530 Message-ID: <87plh2m72a.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE=8F= =E0=AE=AA=E0=AF=8D=E0=AE=B0=E0=AE=B2=E0=AF=8D 24, 2025] Eli Zaretskii wrote: >> From: Stefan Monnier <monnier@HIDDEN> >> Cc: gerd.moellmann@HIDDEN, stefankangas@HIDDEN, >> 77924 <at> debbugs.gnu.org, Ihor Radchenko <yantar92@HIDDEN> >> Date: Wed, 23 Apr 2025 11:41:43 -0400 >>=20 >> > Btw, did I miss some benchmarks? I presume that the main motivation >> > for this branch is to speed up markers and charpos-to-bytepos >> > conversions, is that right? If so, the only benchmark I saw shows only >> > a very mild speed-up, but maybe I missed something? >>=20 >> AFAICT we have tuned the current charpos<->bytepos conversion code such >> that its worst case virtually never shows up in practice. >>=20 >> Supposedly Ihor has a use case where that conversion still can make >> a noticeable difference, but I don't know if he tried the `text-index` >> branch to confirm that it makes a measurable difference on his case. >>=20 >> Gerd and I played with some micro benchmarks to confirm that the >> pathological behaviors are indeed solved, but other than that, the focus >> was on making sure the branch does not make the normal case slower >> (contrary to my sorted-array-of-markers-with-gap). > > Still, for performance-oriented changes, it would be nice to see some > benchmarks. Scrolling through some large file with many non-ASCII > characters comes to mind (the Unicode UCD has quite a few of such > files). Is there a standard benchmark code that I can try for this? I have such a large HTML file with Tamil text, and I can scroll through the buffer produced by shr-render-buffer.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 06:30:02 +0000 Resent-Message-ID: <handler.77924.B77924.17454761744487 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Visuwesh <visuweshm@HIDDEN> Cc: Eli Zaretskii <eliz@HIDDEN>, yantar92@HIDDEN, Stefan Monnier <monnier@HIDDEN>, 77924 <at> debbugs.gnu.org, stefankangas@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.17454761744487 (code B ref 77924); Thu, 24 Apr 2025 06:30:02 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 06:29:34 +0000 Received: from localhost ([127.0.0.1]:34252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7q5V-0001AJ-Ra for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 02:29:34 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:61881) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u7q5S-00019M-S0 for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 02:29:32 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-43cf0d787eeso6389785e9.3 for <77924 <at> debbugs.gnu.org>; Wed, 23 Apr 2025 23:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745476164; x=1746080964; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NFshJ97chhyt5ft4ijgl/cFX14Q3ue5+blHCc1Bn700=; b=hPz3wKPDrVFha89OISy9lbONPOL4ZM97082lSrsGDeQk3hT98h5pqjayKDbJTs2vhK s+ohd0GS3C08gNoREyDjs20qlozldlPlsRDl4XJniA30rKynkrBRENU+IuXaXPbmWBq4 a9udVXUeW8wA9pes/4qDBk3RXtJcwGcGPJ7rBcogcTzDPc3U1Z7SUq+/XHYoqwn8HjbO TVy7mp9B9se6aI4+UFjPeJhmBJOrz//Q37NJwAwNjDMuw0FOz8zfftfQxvi6dCmciTnG sP2IC28tLBpk9d9eN5bMHOAWbZKXnEx1wFqaA7DHYWVI1zH/zwjUYlLUl506wTrqw96e GaVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745476164; x=1746080964; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NFshJ97chhyt5ft4ijgl/cFX14Q3ue5+blHCc1Bn700=; b=BFrxnlkAIna7ez7q/UvDh4imAsoz9n+f1JL3WYbt2zvgcOtBpATLpSuhT/vJbXAmsa KF0qoiGD/Ya66OJIfvmvndUZJxB1iJ1JWpXw9ZXi5kvpTAvhJcgQG89UgJTE/RvFLyTI CyRHA/ljPvRdDmeHSGSQY6Cuhij2IxNPpgcoQIAz2crBwPwlZOd5+hLHG8p2bNZKX5mC PfC5ExaPwCyglONvigOg0LKYvl5ksryLlpbEtWtofocibWSRBJ65+ridr7OQQ774+fSe LyWcrpSaQvGekQOrpT3ygIr4JCdil1hGW09yiy6IOgLBxECehlJHJ6vkKaAMswBxeRqd 2o1A== X-Forwarded-Encrypted: i=1; AJvYcCWOltvMTonC+J4MYfxzRpyXDuwuJ0tLdNHke6yJb0Sgo4jT9RjrTrQV8WZb3YnRCtXP74wg0g==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwF18rADxpqeiSuJs2mhzLcuzph5/M6VS+cN4XlRHce0sf3Qtm8 mbX0UWNimbCbJhdNV+q0c2pZRvfXkDkm+ZLlN6SKh6mfBfTkbCynX8+yAJ// X-Gm-Gg: ASbGnctSiWUqcCqiEpvUcYJOKIlMrK6LzdxUZpD5TNjEkP73kBAYa6NJQjT84bBJC/B hWP0PwSIMMZhCsOwdo+oBMJfJvfb8RPlTfgWf1Y96ly+SN5K7Mh8B+ewmHzpTlV0SZVDnMuUxOX k81gKHgeNbm9XJVpkZODJICmucEgvnZWedJTfR3PVvELy56Hyew95h7Gp61sQBh0EieIgwVbILk GlIO1/Ti93+DxtahVfFzA+V21dznw1XHF2DLoNrtwxws+QMZ63PibxSRj31W+29R59EyFkVOj/k KhUI1E4uuWEVXQbWwmaKNMUrgBA0wsUEg344TQen/ghm5TOlQisfinEzFlfVudzMq4wVqkyPGTV scQT5pwcDx0MTp0/AlsTVq2+OZUWDJNoAMkOuvoN+HAjKPho4wg== X-Google-Smtp-Source: AGHT+IGQxixqOBuA98mz+W1fbjX325Is6dV1n6Jw1Lc33AY97Z4Wp+MyLHVmeAz7NAFbtIolxMqELw== X-Received: by 2002:a05:600c:348d:b0:43c:e8a5:87a with SMTP id 5b1f17b1804b1-4409bd2deb3mr12270875e9.16.1745476163749; Wed, 23 Apr 2025 23:29:23 -0700 (PDT) Received: from pro2 (p200300e0b70e65008c33e61e626c43d3.dip0.t-ipconnect.de. [2003:e0:b70e:6500:8c33:e61e:626c:43d3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d1e19e1sm7744055e9.0.2025.04.23.23.29.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 23:29:23 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <87plh2m72a.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvecxiga9d.fsf-monnier+emacs@HIDDEN> <86msc6ywyx.fsf@HIDDEN> <87plh2m72a.fsf@HIDDEN> Date: Thu, 24 Apr 2025 08:29:22 +0200 Message-ID: <m2ecxinkcd.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Visuwesh <visuweshm@HIDDEN> writes: > [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE= =8F=E0=AE=AA=E0=AF=8D=E0=AE=B0=E0=AE=B2=E0=AF=8D 24, 2025] Eli Zaretskii wr= ote: > >>> From: Stefan Monnier <monnier@HIDDEN> >>> Cc: gerd.moellmann@HIDDEN, stefankangas@HIDDEN, >>> 77924 <at> debbugs.gnu.org, Ihor Radchenko <yantar92@HIDDEN> >>> Date: Wed, 23 Apr 2025 11:41:43 -0400 >>>=20 >>> > Btw, did I miss some benchmarks? I presume that the main motivation >>> > for this branch is to speed up markers and charpos-to-bytepos >>> > conversions, is that right? If so, the only benchmark I saw shows on= ly >>> > a very mild speed-up, but maybe I missed something? >>>=20 >>> AFAICT we have tuned the current charpos<->bytepos conversion code such >>> that its worst case virtually never shows up in practice. >>>=20 >>> Supposedly Ihor has a use case where that conversion still can make >>> a noticeable difference, but I don't know if he tried the `text-index` >>> branch to confirm that it makes a measurable difference on his case. >>>=20 >>> Gerd and I played with some micro benchmarks to confirm that the >>> pathological behaviors are indeed solved, but other than that, the focus >>> was on making sure the branch does not make the normal case slower >>> (contrary to my sorted-array-of-markers-with-gap). >> >> Still, for performance-oriented changes, it would be nice to see some >> benchmarks. Scrolling through some large file with many non-ASCII >> characters comes to mind (the Unicode UCD has quite a few of such >> files). > > Is there a standard benchmark code that I can try for this? I have such > a large HTML file with Tamil text, and I can scroll through the buffer > produced by shr-render-buffer. The elisp-benchmarks package has an elb-scroll.el, in its benchmarks directory. AFAICT, that loads an xmenu.c from the resources sub-directory of the benchmarks. You could copy that, or modify it. P.S. One can set the benchmarks directory to somewhere else, and run benchmarks like this: (setq elb-bench-directory "~/emacs/notes/code/benchmarks") (elisp-benchmarks-run ".*replace-region-contents.*" t 100) The 100 is the number of runs, which should be chosen high enough that the "err" column in the result buffer is reasonably low. I'd start with 1 to see how long that takes, and then increase it.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 07:52:01 +0000 Resent-Message-ID: <handler.77924.B77924.17454810692834 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Cc: yantar92@HIDDEN, monnier@HIDDEN, 77924 <at> debbugs.gnu.org, stefankangas@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.17454810692834 (code B ref 77924); Thu, 24 Apr 2025 07:52:01 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 07:51:09 +0000 Received: from localhost ([127.0.0.1]:35133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7rMR-0000jR-77 for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 03:51:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57198) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1u7rMM-0000hb-LI for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 03:51:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1u7rMG-0006ca-2O; Thu, 24 Apr 2025 03:50:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=p2tNpTMXHhHKkn6V0pilyke804QdVAMpvWc5KuMpTPw=; b=cwCnvro05Kx/EyThzqo0 7ZnjxAuxV7tby8ib41Yhl4bw3FDaW6cWYusuA2ZtAfTZScHAgxUimBkre3kY24H4FpVA9s89pfp8f X7qzy5TDKvAyTqNNyvinb7O3Ll4fFlyjS0c/woOm4cnaUHZabIAFsmMvwJ8VpIxDoT9rqb2nGhw+c F29BQ/Q4unC5Pay1cUrvTiYfeXjZRS3PC1f315A/FxTNtv2Ksm5MmXJtONOed7etof6zka9uS0DZQ /cIANZoRGUJ0gf2t30sGgbIb9PbKm7l9fhf9IAMSSqt8udGt1BN99O1mEctAm7oOwzo3Cav5l3QsS e5K2QPGx3AxljQ==; Date: Thu, 24 Apr 2025 10:50:50 +0300 Message-Id: <86cyd2yp45.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <m2ikmunmiq.fsf@HIDDEN> (message from Gerd =?UTF-8?Q?M=C3=B6llmann?= on Thu, 24 Apr 2025 07:42:21 +0200) References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvecxiga9d.fsf-monnier+emacs@HIDDEN> <86msc6ywyx.fsf@HIDDEN> <m2ikmunmiq.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Gerd Möllmann <gerd.moellmann@HIDDEN> > Cc: Stefan Monnier <monnier@HIDDEN>, stefankangas@HIDDEN, > 77924 <at> debbugs.gnu.org, yantar92@HIDDEN > Date: Thu, 24 Apr 2025 07:42:21 +0200 > > Eli Zaretskii <eliz@HIDDEN> writes: > > > Still, for performance-oriented changes, it would be nice to see some > > benchmarks. Scrolling through some large file with many non-ASCII > > characters comes to mind (the Unicode UCD has quite a few of such > > files). > > > > Also, I believe there were cases where a lot of conversions > > created gobs of markers which slowed down things; it would be good to > > run those cases to see how they are affected. > > > > And finally, how about running the whole benchmark suite we have, in > > case it uncovers some unexpected results? > > I can offer to run benchmarks on my Mac mini. Should be fine, I think. I very much doubt that there will be significant differences between platforms for this kind of changes. > But we should agree upon what elisp-benchmark files I should use and on > the number of runs, because running them takes an eternity, and because > some of the benchmarks Stef (and me for elb-search) ran are not in the > "official" elisp-benchmarks package. I trust you and Stefan to decide on that. I myself am not familiar with the elisp-benchmarks suite well enough to have an opinion that is of importance. From where I stand, the important part is comparing the current master with the branch. > Don't know about the scrolling benchmark. Is what is in elisp-benchmarks > enough? If not, can you please give me a bencnhmark file for what you > want benchmarked? I don't know whether we have it in elisp-benchmarks, but if we don't, then the following should be good enough: (defun scroll-up-benchmark () (interactive) (let ((oldgc gcs-done) (oldtime (float-time))) (condition-case nil (while t (scroll-up) (redisplay)) (error (message "GCs: %d Elapsed time: %f seconds" (- gcs-done oldgc) (- (float-time) oldtime)))))) Evaluate this, then invoke "M-x scroll-up-benchmark" in a large buffer with lots of non-ASCII characters. Compare the timings between the two versions of Emacs. Thanks.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 07:52:02 +0000 Resent-Message-ID: <handler.77924.B77924.17454811183017 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Visuwesh <visuweshm@HIDDEN> Cc: gerd.moellmann@HIDDEN, yantar92@HIDDEN, monnier@HIDDEN, 77924 <at> debbugs.gnu.org, stefankangas@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.17454811183017 (code B ref 77924); Thu, 24 Apr 2025 07:52:02 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 07:51:58 +0000 Received: from localhost ([127.0.0.1]:35149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7rNG-0000mQ-43 for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 03:51:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37064) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1u7rNE-0000m0-85 for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 03:51:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1u7rN8-0006fe-B3; Thu, 24 Apr 2025 03:51:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nvoWgsTvzitwy7hXzhzFYXwQughyQVQO/50x9B6Xo7U=; b=B5RlXAkVrdvW JYa7XwTlFN9df1Rj8+56hCi+8hh0wKHYIew2cBPcvAuMhZVF5xMOIJQVwwrmoCK6VHKTLzixFoUlF Oy6q6rdy4WR6tsnSbEad0uACRpYv9FBojyHOoItaLVI+viWjStNqReHW04sle7PyBaEFzuTvGCVGV HE8UKoOE0PjydvkhR9MICiiMizHi5HKA35icpQBa2d08t/kyghxwcCOBNGoWiaHIYZ+wfVNFTXiwb w0x/l5yHbdOYwDJKzYe6+EJenFfpJhpE+CNMI9sBDeB4OyNgLZBj14xeZR4L1ICkWaUvDrJjHYB6u kZAV/Tp55UEkm792DZZLZA==; Date: Thu, 24 Apr 2025 10:51:47 +0300 Message-Id: <86bjsmyp2k.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <87plh2m72a.fsf@HIDDEN> (message from Visuwesh on Thu, 24 Apr 2025 11:31:33 +0530) References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvecxiga9d.fsf-monnier+emacs@HIDDEN> <86msc6ywyx.fsf@HIDDEN> <87plh2m72a.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Visuwesh <visuweshm@HIDDEN> > Cc: Stefan Monnier <monnier@HIDDEN>, gerd.moellmann@HIDDEN, > yantar92@HIDDEN, stefankangas@HIDDEN, 77924 <at> debbugs.gnu.org > Date: Thu, 24 Apr 2025 11:31:33 +0530 > > > Still, for performance-oriented changes, it would be nice to see some > > benchmarks. Scrolling through some large file with many non-ASCII > > characters comes to mind (the Unicode UCD has quite a few of such > > files). > > Is there a standard benchmark code that I can try for this? I have such > a large HTML file with Tamil text, and I can scroll through the buffer > produced by shr-render-buffer. See my response to Gerd a few minutes ago.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 07:58:02 +0000 Resent-Message-ID: <handler.77924.B77924.17454814394666 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Cc: yantar92@HIDDEN, stefankangas@HIDDEN, monnier@HIDDEN, 77924 <at> debbugs.gnu.org, visuweshm@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.17454814394666 (code B ref 77924); Thu, 24 Apr 2025 07:58:02 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 07:57:19 +0000 Received: from localhost ([127.0.0.1]:35200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7rSQ-0001DA-Ka for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 03:57:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55634) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1u7rSN-0001Cr-Fz for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 03:57:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1u7rSH-0007IM-Dq; Thu, 24 Apr 2025 03:57:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=7rA89W0VcncexLZfhAUyNga85DsLLehjTxhjklbMsQk=; b=HWFCpUL+Oh6S6QTx6BA4 fq6APuPnS+52CnDppFD93cBSgn9sSfhBlWmx2/sMjDXcNdL7uhDHvrPXlOImpBurf1mmDlgoB+HEn BqIGFrFHUH/imPKYqYfqzk4oarV+btpMwD6T3/nqJui+la+gNbxw/IjKsdoa9C01awyIOBYmYRgOe I+he13xJW3G5IAwgK0HZl5JaG5hy4IiTFT6eESk/3dXWCLl4OJAl705i+jnYQZ0SKOKGu2HqdOgYb eiOfLfZq4FLAFJzz1IX71myaNFIdQf1z4FCBsj29BCDkoo0QuZnJqu8lWMXEZgvkxmblJsyjuxPNm M2OAj7ZsXjMIXQ==; Date: Thu, 24 Apr 2025 10:57:00 +0300 Message-Id: <86a586yotv.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <m2ecxinkcd.fsf@HIDDEN> (message from Gerd =?UTF-8?Q?M=C3=B6llmann?= on Thu, 24 Apr 2025 08:29:22 +0200) References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvecxiga9d.fsf-monnier+emacs@HIDDEN> <86msc6ywyx.fsf@HIDDEN> <87plh2m72a.fsf@HIDDEN> <m2ecxinkcd.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Gerd Möllmann <gerd.moellmann@HIDDEN> > Cc: Eli Zaretskii <eliz@HIDDEN>, Stefan Monnier > <monnier@HIDDEN>, yantar92@HIDDEN, stefankangas@HIDDEN, > 77924 <at> debbugs.gnu.org > Date: Thu, 24 Apr 2025 08:29:22 +0200 > > > Is there a standard benchmark code that I can try for this? I have such > > a large HTML file with Tamil text, and I can scroll through the buffer > > produced by shr-render-buffer. > > The elisp-benchmarks package has an elb-scroll.el, in its benchmarks > directory. AFAICT, that loads an xmenu.c from the resources > sub-directory of the benchmarks. Please test scrolling with non-ASCII characters, not with xmenu.c (which is pure-ASCII), since charpos-to-bytepos conversions in pure-ASCII buffers are trivial.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: martin rudalics <rudalics@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 08:02:02 +0000 Resent-Message-ID: <handler.77924.B77924.17454817096025 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier <monnier@HIDDEN> Cc: gerd.moellmann@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, stefankangas@HIDDEN, 77924 <at> debbugs.gnu.org, Juri Linkov <juri@HIDDEN> Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.17454817096025 (code B ref 77924); Thu, 24 Apr 2025 08:02:02 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 08:01:49 +0000 Received: from localhost ([127.0.0.1]:35250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7rWm-0001Z5-Jl for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 04:01:48 -0400 Received: from mout.gmx.net ([212.227.17.20]:36935) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1u7rWk-0001Yq-9I for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 04:01:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1745481689; x=1746086489; i=rudalics@HIDDEN; bh=6GLzlAx5aCBFgJ6OJthQSlO6JA+GoCXHvWj/Zm8f4ig=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=f2oTR2J9BWooxmeHIXzx24Gw8QPTgjhd54I6O2KpRSKPlj5IFHZk18TTpTf5K3Yj XQKBQcILmUiV9ZmlbofmQh4CyzaPoGAJt/FC6bxZSb0Mr74Bi6tJceqBetxSqFDS2 Zvbv0GHKqxnyg+jbUouAvFpzVUmv+zjzzmYPEEiZqVkuH5YFzEFroKX4F2F8MyvKV cvWNXA/tzlUH59fZ1uEPnJQuA0eFr8OKIOvXswoDWYRfx40tOKV345YIMf91iTTXN dheJRNqBsCaUrIfkiq0vIYJTvI6xySfrgEEsDJQxdqxnEe6XNeNh2fHECof/kbrNI PyLeblQi1ZBZlfhFkA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([46.125.249.94]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MEUz4-1uJNqc0NWU-00ET9P; Thu, 24 Apr 2025 10:01:28 +0200 Message-ID: <0b0d5bf1-bf98-4f89-87d6-de7e8c5dc291@HIDDEN> Date: Thu, 24 Apr 2025 10:01:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvjz7agaos.fsf-monnier+emacs@HIDDEN> Content-Language: en-US From: martin rudalics <rudalics@HIDDEN> In-Reply-To: <jwvjz7agaos.fsf-monnier+emacs@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 X-Provags-ID: V03:K1:CPqpV+tf5DFw1NQb2DSJc/ZTfILE85RrvFdzAUsNQnn42gWDIGG aHBhwLlc1cjpsx9r7e9J79hBW7E4t4FS6ANBIGcbMlStSQ2diAHlc8DGCqleH+6kk7c+B4H eQejdzCJO3GTYpUppzU0aVA6vutqu8OJ44MjpdVubLM7HBzPW1Zt5BSE+zHioY2a/gLyiZA loVyIGrSXHHGVpSQeCRYw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:IQ5BXSliD1s=;bOzTKkCHqlLGrE0R/Puftf9dmLF uYehZciS+FYvPKw8ypUMh7lZTFzAlZzN2JJhiaaMP47OSJvNKQgaqG73OMB9sKR1jyX6uqp/7 5LiJcWv/nJwwaLQGu2E7NqdtBtT21l2RV35gq1qgKF5fPDEbUP0azDLMgilsQXmNFGJOv+Kxt l9jDuctsP/Uw3YZjO4ac3OnEnWVY9vm0F0yFSqIj1eAWKQtNhiVWO+HgZ6kd4TYASz1l0k5MQ h8Zso15L7OoxRD7uRLk4iDC7T550t7iI2w516BMSjn0uIEc8NPVbwzZ8tONBR5N6qd9DwgW1v R6RoiGSIF2DY5SKHKNFyBrbpn1LZUFQ7/kEp+8kzreAqzO2+bHphQ0wyuwozMZz6p50NBjMDY xGHA/42KxZhwrvmGxrmds67QNNozFZAc1nIuzy+9Kc5DVZbnWSVIIlt88j82BWpoGwRMuKND9 JQaTLGSldoaHCen4ZivBeqHRMrOnyVmzVc0FHZGAlZb7lM7SLyx2zYTH0oPShNbBJdTZ0HsV6 waq6OSiO3nF0OZMZ/IiJGneRiWkJqfGECt0ESbH1b39FtmZ8Vcf7jFuf0IsKU0vsM1EvLw3eL Vv6+7tlKorEc79ZdLTeUBEGj/VK/58bQUz5cJWnkvqVFTNxEhjUXY1sB+YObmlUyPJpeDuRxr Ki8vHEokqSxuBB8MmCtGoVrxP/OC5Rgz790JA8dKLqhljbKksZ4Zz8UeuH9sWRDrvkmusuky8 MiwONbG5S7qOO6uY2dY4jrt1DF6i4Ng+PecHqFpMov7zZUZJjgqPZrLfM8kB40hgi7ufatsl4 FWjeaVJnM+MFweZLUmvy63KT7JDVPib5tnddGswugHkyDRx4LPK0LUXWic+q6EMok4DV6VsXl NEUAyhN095PIV9Kd8YGPEH6DcqELpJuvelVXCBM5Hd2KfRdlF5Vc51yGCSyV4PefHnIU9E1Dx XHLX64yA9HegcqcOBz8CC/MMyYlGLLuBmirnglM6KhJ4bOKAsOZAZdYs6kp8D22REQSjsnO1c JMy8hvNyulfchGVmwjVIZovCrmx8h6FLC26t6T2XFtbqmLVGokCnVYRCbMaIgScyDvEQGYp3b IGylVUAKcwDliFHCkHcgv3ID2xOfkgpVVpGgxMHee0yAMfMUqXz7LcieKz300pdZDOrjMnwD2 +7W/qhi5hzLBMyU5Cz7+FV73A8Km3jpDB2KhZFY9KMULiMPfwgOjdrj06v+xqmADxG28b2Iju +vWrtwiORA97mYdjPoczTOojdddxgh/h3gH/5mM2wsqWCU2eCgmefrstt2Ixd/Yv7GAQb7829 Blf/qexz9cLEoA/R3mIuXbuE1E55BtWM+FD8KMi+6+AVi0QHvDuVPNJRyM60UawrlqL/4zH3L ihxNMN9ALhE4Lgo0G3528XcbLJJ7QMmgmlQrWFaM/CTKLBXe+gJ5TEtLqcaVLznqspbHPkBEv cU08COmwiVrdMHJ19fsYOl1IKGYJR+ZIyTe0kcpm/iAk3nZFlgn4vRn0ZEhgRj3SDSIH48jfY vFZDF9kGJiCe2qJDGZCkmlZRdDoHmVNNg0MuTeCboQBDjLNfMUPs/NM4Bg4D6b3HKgvR6jzEm FEtpEHrbAdXjEy06/8XJqxVF3pd6fJQWS/IlFBhDCELWEQvM6hh1j4Dme7AnGRRgsWFFMpbsf fwsGiKyNQpkJi5m5w+cS1+hm+uG+Cj8dKwIYR8qKv0Lw7vKmbgg85Dj3PmjQhaL8Da5H8BJ1S XrciWVzVfrcRicez2NA0ehUeG9YBuJ8diMp93qKtyY7NfrCDPd6M5rgUCrWlGXy6HG9oy2tVt w+0WqoWWOLk6Wu9LIpOkpr5UjATd/wE7+Iy9aHHSinnl2pK3iUGg4i2wB8Xde5xZo05WZKzMR qnOJMMR1ihPJl2yQEv/UmQw7u/HxLXIWfFDn5XaQk+dYB1EliPhba1A2qYsHnTvWOqR1c29t3 efU6Ssmkb6bk7I0Z/EcBTvqVJ6y/kDnkhGTVCQttz/0FxYNu9liC90PXVw1YaVsHkjU6jplMb ORJVM5Gh7Askd6QLanzod0KFWcDhlF7iHhqip0WISULkXjI/B4dl5/cOMT5omWQjNREj1YFEY W2aZtsWXoN4B+ZNYWrFhzB6hPSNtuXWz5iPVXYWDkoijrwrhjDbyBhzixsxFWU666AC3RCEA+ e8NZ4TV+LmaQTRp2ANBdRDxZ6AiXXgBApgws2i+GD1KcVcdyOXR2e2dvMS4R5vdN+L4c7iFFx 5gHPvstZz51fbXXv1AJuWbW9x9nxiY6E8Bup8+bT+sH8cHtClJnT1jbmCT6D5DoplcEeuBRjn DYT663TdZI/f05yMvs8+u0v1dsjsALsQxrPMRvk9+IU3karYOmKPSG6AM5BnI6+8D0DHcrZdO A29cSaZO0i+1dhRhzq2QOiCBszUjqWJXIfvRZIVI60HGGLHDM9M5VPoEfeTssD0nXcFyQp43f 7VlKPiJzQAxuJYPQooCqc+WFb5gS1fgIY6XQLQ+066eOLXcytmdoItUri4b3Jym4AtWLfHG1d 0PWS1n+LYgo2OmCkC1xLOBecxK0lk5ZOnEXH7ZAfYEGzPekwuvXHKuxRPtE10njaTR6V1uImh WVAxQaGL6zvgiORBB/PpPX4a1osbJ6b4Vg9/3LJ1acS+3Mtm4WCEpmA+WB7+amEII7fo9YEO2 wFn/cl7H2ZEiI4reCEcuLbQt/PLts/9+HnoRn9xU7e76nAkSJPilm/PqTLVO5xjxqxWbS0A72 OcPnjgeGPY1YH7mRywTiLpD8OaWAsoSK3ac3GO1MAYnSW/xZYJFIPbGwvEDsZ/CQVd3vujvH7 sFRX1mbthmSaWNsTltzUgiwjZ2FYXAqqBDlnA0LYmu8Yf+LymOZ5BLU+JoZMh+aADQoSdvk6L PFO8lawQJJsWZsUWGNwYYPT+VC9KDSI6WM76xI3pE6kz6qo7hNywXkCvv86LIgosAujPB7Wej AlkhHjcrrea/ThYv8wyJX9jPKdimD53mteXkZc9FASkK5bsug98Ym6RnI1vLc6NFyr+RQCFx6 kMPFs8EUcSBrcQNwVnWIBB3cxR7bsXcb1DBlJMJFAwn207+B6Q0jgdaRKY4Y1WiKdmBPR09LE iLgw0lUMq9GzQ= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) ID4gQlRXLCBkdXJpbmcgbXkgcmViYXNpbmcgSSBub3RpY2VkIHRoZSBmb2xsb3dpbmcgaW5j b21wYXRpYmlsaXR5Og0KID4NCiA+ICAgICAgY29tbWl0IDg5YWQ1MTBiMmViZDVlZDNlZDg0 NzdlNGE0NWFkYTM0MDJiY2VkY2ENCiA+ICAgICAgQXV0aG9yOiBHZXJkIE3DtmxsbWFubiA8 Z2VyZC5tb2VsbG1hbm5AZ21haWwuY29tPg0KID4gICAgICBEYXRlOiAgIFRodSBBcHIgMTcg MDg6NDI6NTIgMjAyNSArMDIwMA0KID4NCiA+ICAgICAgICAgIG1hcmtlci12ZWN0b3IuYzog TW92ZSBtYXJrZXIncyBwb3NpdGlvbiBpbmZvIHRvIHRoZSBhcnJheQ0KID4NCiA+IG1ha2Vz IGl0ICJpbXBvc3NpYmxlIiB0byBpbXBsZW1lbnQgYG1hcmtlci1sYXN0LXBvc2l0aW9uYC4N Cg0KV2hhdCB3b3VsZCAnbWFya2VycCcgdGhlbiByZXR1cm4gZm9yIGEgbWFya2VyIHdob3Nl IGJ1ZmZlciBoYXMgYmVlbg0Ka2lsbGVkPyAgVGhlIGlkZWEgb2YgJ21hcmtlci1sYXN0LXBv c2l0aW9uJyBpcyB0aGF0IGlmIHNvbWUgYWdlbnQgKGxpa2UNCmEgdGFiIGJhciBlbnRyeSkg a2VlcHMgYSByZWZlcmVuY2UgdG8gYSBraWxsZWQgYnVmZmVyLCB0aGF0IGJ1ZmZlcg0KY2Fu bm90IGJlIGNvbGxlY3RlZCBhbmQgbmVpdGhlciBpdHMgbWFya2VycywgYWx0aG91Z2ggdGhl IGxhdHRlciBoYXZlDQpiZWVuIHVuY2hhaW5lZCBhbHJlYWR5LiAg4oCYbWFya2VyLXBvc2l0 aW9u4oCZIHdvdWxkIGFsd2F5cyByZXR1cm4gbmlsIGZvcg0Kc3VjaCBhIG1hcmtlciBidXQg J21hcmtlci1sYXN0LXBvc2l0aW9uJyB3b3VsZCBoYXZlIHdvcmtlZCBpbiB0aGUgcGFzdC4N Cg0KID4gQUZBSUNUIHRoaXMgZnVuY3Rpb24gaXMgbm90IHVzZWQgb3V0c2lkZSBvZiBFbWFj cyBhdCBhbGwgKGJhc2VkIG9uDQogPiBhIHNlYXJjaCBvZiBhbGwgKkVMUEEgcGFja2FnZXMp LCBidXQgaXQgKmlzKiB1c2VkIGluDQogPiBgd2luZG93LS1zdGF0ZS1wdXQtMmAsIHNpbmNl IHRoZSBmb2xsb3dpbmcgY29tbWl0Og0KID4NCiA+ICAgICAgY29tbWl0IDkxMmUzN2I4MTEx MDc3NjhlMGNiM2JjOTUxODQxNzdmODE3ZGJkYjINCiA+ICAgICAgQXV0aG9yOiBNYXJ0aW4g UnVkYWxpY3MgPHJ1ZGFsaWNzQGdteC5hdD4NCiA+ICAgICAgRGF0ZTogICBNb24gTWFyIDQg MTA6MzM6NDkgMjAyNCArMDEwMA0KID4NCiA+ICAgICAgICAgIEZpeCAnc2V0LXdpbmRvdy1j b25maWd1cmF0aW9uJyBhbmQgJ3dpbmRvdy1zdGF0ZS1wdXQnDQogPg0KID4gV2hhdCdzIHRo ZSBpbXBhY3Qgb2YgYnJlYWtpbmcgYG1hcmtlci1sYXN0LXBvc2l0aW9uYD8NCg0KSWYgJ3dp bmRvdy1yZXN0b3JlLWtpbGxlZC1idWZmZXItd2luZG93cycgaXMgYSBmdW5jdGlvbiB0aGF0 IHRyaWVzIHRvDQpyZXN1cnJlY3QgYSBraWxsZWQgYnVmZmVyLCBpdCBjb3VsZCBub3QgZGVy aXZlIHRoZSBwb3NpdGlvbiBvZiB0aGUgc3RhcnQNCmFuZCBwb2ludCBwb3NpdGlvbiBvZiB0 aGUgYnVmZmVyIGluIHRoYXQgd2luZG93LiAgU28gQUZBSUNUIHRoZSBmdW5jdGlvbg0KJ3Rh Yi1iYXItc2VsZWN0LXJlc3RvcmUtd2luZG93cycgd291bGQgYmUgYWZmZWN0ZWQuICBKdXJp IGNhbiB0ZWxsIG1vcmUuDQoNCm1hcnRpbg0K
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 08:31:03 +0000 Resent-Message-ID: <handler.77924.B77924.174548346016303 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: yantar92@HIDDEN, monnier@HIDDEN, 77924 <at> debbugs.gnu.org, stefankangas@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174548346016303 (code B ref 77924); Thu, 24 Apr 2025 08:31:03 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 08:31:00 +0000 Received: from localhost ([127.0.0.1]:35550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7ryz-0004ES-Hm for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 04:30:59 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:43239) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u7ryv-0004Ci-Pw for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 04:30:54 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-43cf680d351so11303255e9.0 for <77924 <at> debbugs.gnu.org>; Thu, 24 Apr 2025 01:30:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745483447; x=1746088247; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=4Egl1x/w85M7L233AfkuFEpceodBWSIi/agSDGF4hjs=; b=EUr7w5bgurJJLgJgiFW5Fxnp4C84qZyBj30Ngr6t60zzP0b8+u2akCbZpkmc3kGwcd Je9hmq0U13sR5yJvVmgDqFQ683Bov2gaGsd6KVlcN/FnEiWoj9nDVGJ4kIokUiEj0Wso KSE1VN8Q27kXXl3MWAr1I7aZmLPZ0hhXTze4R8QUb1M5NXY2gvYSU5OaKbuU6UVEYVZo LKUIfswhv7UV8xV/qZC8GgvljGu5iSxqhz4yHIK2sh500HXumO8EtbvagNLsj7cqvh9U EmEa5YlXhg1X3uiwxekPOzi+VoOu9T1pRZF9mfBG05yHRubCfa522y/ApVMdAOaS2mc3 E+cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745483447; x=1746088247; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4Egl1x/w85M7L233AfkuFEpceodBWSIi/agSDGF4hjs=; b=LzeRO1GF2oSJr2U5uFlG8+5V7Q49/bJsRo1xnc4Nu/07EfdwC4R6PjjPSZxLTXjU/+ rapoZYM76vq++Bfl+hg3IZm5sMRCP4rLkH4HSfIfkfNdGPbFemD5IOmsWf1s7aNCQZYR PsFtTTkMAqnhGHZ30jJCcdFK/6SVPATWmn+V949m4jrfRBjsQ/1eUGwk2qnCmhDTKvZB zwGdz86ewfV8py6yPDLaSr837imnY7RYnFO80kRHRO52FF4yt1ivUMh/RCP98jaLFsvB FKyDWh37+fQhlTyMTfxsMRPV8k5InqlrU7hu/V6fotkI9BJZ03LW3Dit5PW98HMuONIl +WzA== X-Forwarded-Encrypted: i=1; AJvYcCWaVD/qzUAiz9L28/hwFpn32XrXE8O3MoBUs8GcKIakH3+4GfdGjMyxSd/a3w3YJX9AOZBJaw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yz9zlTx6xQiWEKy5tIYIovwOlKmMJGVvOe6RzSxm5p1pPOE+boD nzK0cwBVE9KEQFoudD+K6DkDdQQyulYUg3QozwMHIUEImdRFV2L7 X-Gm-Gg: ASbGncvEpO/3YJyM+PLRiwsJpSCOFH4OXFIE/Dxy4H8ah0qwAzYoNyy+1HBjQ5cvGNJ iP2QMG54H4XUCsln9ckx3B6KQA6cb9ooXEXwUVgl5VUFMMBvr1W4zeJ+n+4g4tg/Kk+VCOZxc/W rFD6WNXinVSuzqnjadZAFF4tFzLOPrkbHLv/lchdb7Au3PN6Z3tJUvsswFssN5a3x44C0CHBg0W Q3nb7wL+RPra25dJkrXCLchlm/7nFqdBfJV/sXSllAPr1tghPhSwSokn3oFZeFhxM3zvBFPNEf+ aQ4KnjlVJKLeFM9weQWqDVw+emRWTFSAcPgx9GxxGpUesEL60/YejX0W4BytASK3+QhvBBCHyWu wcRR1e8WE2bkcnMF4/Ytmtzp5m2X99z7ESsmK1AZGda8r/38H+g== X-Google-Smtp-Source: AGHT+IFe9ocf36yBoA+fIm6zeUZEY79jWmxrABtrt9Vrdo791PSjgVQ3jP93M5YnvdKxoiC8GrqDWw== X-Received: by 2002:a05:600c:4711:b0:439:5f04:4f8d with SMTP id 5b1f17b1804b1-4409c4bd615mr11211655e9.12.1745483447169; Thu, 24 Apr 2025 01:30:47 -0700 (PDT) Received: from pro2 (p200300e0b70e65008c33e61e626c43d3.dip0.t-ipconnect.de. [2003:e0:b70e:6500:8c33:e61e:626c:43d3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d2d86f7sm10864065e9.32.2025.04.24.01.30.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 01:30:46 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <86cyd2yp45.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvecxiga9d.fsf-monnier+emacs@HIDDEN> <86msc6ywyx.fsf@HIDDEN> <m2ikmunmiq.fsf@HIDDEN> <86cyd2yp45.fsf@HIDDEN> Date: Thu, 24 Apr 2025 10:30:45 +0200 Message-ID: <m2a586neq2.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: > I trust you and Stefan to decide on that. I myself am not familiar > with the elisp-benchmarks suite well enough to have an opinion that is > of importance. From where I stand, the important part is comparing > the current master with the branch. > >> Don't know about the scrolling benchmark. Is what is in elisp-benchmarks >> enough? If not, can you please give me a bencnhmark file for what you >> want benchmarked? > > I don't know whether we have it in elisp-benchmarks, but if we don't, > then the following should be good enough: > > (defun scroll-up-benchmark () > (interactive) > (let ((oldgc gcs-done) > (oldtime (float-time))) > (condition-case nil (while t (scroll-up) (redisplay)) > (error (message "GCs: %d Elapsed time: %f seconds" > (- gcs-done oldgc) (- (float-time) oldtime)))))) > > Evaluate this, then invoke "M-x scroll-up-benchmark" in a large buffer > with lots of non-ASCII characters. Compare the timings between the > two versions of Emacs. elb-scroll from elisp-bechmarks is basically (dotimes (_ 10) (elb-smie-mode) (goto-char (point-min)) (condition-case nil (while t (scroll-up nil) (redisplay 'force)) (end-of-buffer nil)))))) looks similar, but I don't know what elb-smie-mode does. Seems to have something to do with prog-mode, so maybe this depends on the test file being a C file, which might be interesting for Visuwesh.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 09:11:01 +0000 Resent-Message-ID: <handler.77924.B77924.174548584329982 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics <rudalics@HIDDEN> Cc: Pip Cet <pipcet@HIDDEN>, Helmut Eller <eller.helmut@HIDDEN>, Juri Linkov <juri@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, 77924 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, stefankangas@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174548584329982 (code B ref 77924); Thu, 24 Apr 2025 09:11:01 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 09:10:43 +0000 Received: from localhost ([127.0.0.1]:35915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7sbS-0007nV-UX for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 05:10:43 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:53615) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u7sbQ-0007n0-LL for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 05:10:41 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-391342fc0b5so558966f8f.3 for <77924 <at> debbugs.gnu.org>; Thu, 24 Apr 2025 02:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745485834; x=1746090634; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=125GVzrBJlY54kM198a222PxiPAjkXqJbj3YihxG0cA=; b=X5kzcbgPQOwpiHQBNf8YgeIS+iTUAWEIPe0hHAYbOncKSmyQxxbzNy5nffPUzjt3Gq 688cnFsM6QGP1fNICj1xOYDWszZovKPFp7UesHLWTzMYDHvZAK8b6Ua/L0IZ+7CXb+Nh 8/5ItOwUdJ0Q/krAsxm/oRcDPWm5AU0sGZKDK/iRfYRKBRIDA+l/yivqO2Go+DB5YB+L RLZXoR9OiZrwdL2pG3Fi7oI1DONt5dwCCEMc5eaW2YljL6v06q73cjppHf73RC4LEdar XszJxqFbffFRkY72OebLB09pEZjE7Zd4j8y9y7JYB98veCYDcpP86DLWpn/Out45R9vm L4wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745485834; x=1746090634; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=125GVzrBJlY54kM198a222PxiPAjkXqJbj3YihxG0cA=; b=b6u3hMvIVFcIiIUW7CnTu4km+jhCoA0LYyUSqSltGF3uTm2vZ4oOp3OP+hd+ZoOk+i kvolmo6ebyUMJck4OSQt7MjBrhFQyARJupt37TdljuMYIGnUBocoQjc7bm+0BbKH/3Ui FFLTzjVu9x/7kCHccua/dx9V2buRO/OT6k+axZtW/zN3mLFBTYC9uKxJPa1M6Xwgr2L4 RwIfibIU7u0+2U/x99tMuvt4pGA4y7YP0ScaUvnoUpEfulZicgZ9vNwawVbRyWYNmUUa wohnyutF36sBSMsN1omPHckPh1KTXHReT1LQROyp6OhszUqYVQQVtooMK7+XXpE91IcZ DKgw== X-Forwarded-Encrypted: i=1; AJvYcCVBlVGpNqgyPWuPMiz+LQeuR00tdbWQc0NN6JKbW1o3wSXf2YOnyPUxqh7BezlOO7dwoaSAXA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyijWx2PKGnWEM+eSYMJfEX7P7nSjKgzQB9htgoiAYLSLwCM/xs ixl0tNAthNuDX2jrQc8BogsCXZLXgUyHY+rpf6IOr2lKH4d8WJO6 X-Gm-Gg: ASbGnct1jkVOWFfqFAqP2Zwa0+y5z7sODY39qlCs3sg3YF35CPFmwWnahCeiqv47173 ke1Tb4uklhOLSjcsHVI6po8F5h+usrL6hE0D6++PQmmNyoyjWpunGx3YF86nk+Spv63Un96rvNS QEtSGpxEYPWBPu9RSXa1JlqFvFkfjonW++QjRhQCTsk2uJsbSRGr7KXajpPqJmSd6oqoMSv7D6J fdW5w68t/j9e89sJNjFq1+Et3FfIvOY35poJlq+DNzkOhTuexodsUQ4DjpTj4325Z0c4JMyKNjH LBz8G4yYJPX75s+nMiQ0U4XEOPmdhx1bSpRT0o44DHzsPpdcQWx5j2N8o8CVqojh79U0H2CqHHs WYH5T7eXlKoSuaTATubGoxhc3gK7rBnbEo71gAAxvRdLo+VxFpA== X-Google-Smtp-Source: AGHT+IGrQj0qxj7zPg+sIkN3KDJEvLqUOx8tMSgndteSIb2LfKKHCxcjUJCm+bM0rTXwv4wBBJI6Sg== X-Received: by 2002:a05:6000:402a:b0:39c:266c:400a with SMTP id ffacd0b85a97d-3a06cfc5d7amr1518049f8f.50.1745485833898; Thu, 24 Apr 2025 02:10:33 -0700 (PDT) Received: from pro2 (p200300e0b70e65008c33e61e626c43d3.dip0.t-ipconnect.de. [2003:e0:b70e:6500:8c33:e61e:626c:43d3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d4a815bsm1398346f8f.8.2025.04.24.02.10.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 02:10:33 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <0b0d5bf1-bf98-4f89-87d6-de7e8c5dc291@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvjz7agaos.fsf-monnier+emacs@HIDDEN> <0b0d5bf1-bf98-4f89-87d6-de7e8c5dc291@HIDDEN> Date: Thu, 24 Apr 2025 11:10:32 +0200 Message-ID: <m25xitorg7.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) martin rudalics <rudalics@HIDDEN> writes: >> BTW, during my rebasing I noticed the following incompatibility: >> >> commit 89ad510b2ebd5ed3ed8477e4a45ada3402bcedca >> Author: Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> >> Date: Thu Apr 17 08:42:52 2025 +0200 >> >> marker-vector.c: Move marker's position info to the array >> >> makes it "impossible" to implement `marker-last-position`. > > What would 'markerp' then return for a marker whose buffer has been > killed? The idea of 'marker-last-position' is that if some agent (like > a tab bar entry) keeps a reference to a killed buffer, that buffer > cannot be collected and neither its markers, although the latter have > been unchained already. =E2=80=98marker-position=E2=80=99 would always r= eturn nil for > such a marker but 'marker-last-position' would have worked in the past. > >> AFAICT this function is not used outside of Emacs at all (based on >> a search of all *ELPA packages), but it *is* used in >> `window--state-put-2`, since the following commit: >> >> commit 912e37b811107768e0cb3bc95184177f817dbdb2 >> Author: Martin Rudalics <rudalics@HIDDEN> >> Date: Mon Mar 4 10:33:49 2024 +0100 >> >> Fix 'set-window-configuration' and 'window-state-put' >> >> What's the impact of breaking `marker-last-position`? > > If 'window-restore-killed-buffer-windows' is a function that tries to > resurrect a killed buffer, it could not derive the position of the start > and point position of the buffer in that window. So AFAICT the function > 'tab-bar-select-restore-windows' would be affected. Juri can tell more. > > martin Hm, that might be an unsolvable problem with igc, actually. At least I don't know ATM how it could be solved. Let me try to explain. The function below is what igc uses to scan a marker vector and remove stale references (weak references). It's from my Emacs, not from feature/igc, but that doesn't play a role. the situation is the same here and there. igc.c: 2136 static mps_res_t 2137 fix_marker_vector (mps_ss_t ss, struct Lisp_Vector *v) 2138 { 2139 MPS_SCAN_BEGIN (ss) 2140 { 2141 const ptrdiff_t max_entry =3D XFIXNUM (v->contents[MARKER_VECTOR_= MAX_ENTRY]); 2142 for (ptrdiff_t e =3D MARKER_VECTOR_HEADER_SIZE; 2143 e <=3D max_entry; e +=3D MARKER_VECTOR_ENTRY_SIZE) 2144 { 2145 /* Note that we cannot access anything of a marker here becau= se 2146 that is not allowed by MPS while scanning an unrelated 2147 object. This includes MARKERP because that accesses the 2148 header of a marker. */ 2149 Lisp_Object *p =3D &v->contents[e + MARKER_VECTOR_OFFSET_MARK= ER]; 2150 if (!NILP (*p) && !FIXNUMP (*p)) 2151 { 2152 IGC_FIX12_OBJ (ss, p); 2153 if (NILP (*p)) 2154 { 2155 /* Changed to nil means the weak reference was to a d= ead 2156 marker. Put on free-list. */ 2157 v->contents[e] =3D v->contents[MARKER_VECTOR_FREE]; 2158 v->contents[MARKER_VECTOR_FREE] =3D make_fixnum (e); 2159 } 2160 } 2161 } 2162 } 2163 MPS_SCAN_END (ss); 2164 return MPS_RES_OK; 2165 } The problem is that MPS doesn't allow accessing other MPS-managed objects while working on the marker vector. See the comment at line 2145. Markers are such MPS-managed objects, so we can't read or change members of a marker here, not the buffer, not something else. That restriction is very real, it suffices to add a MARKERP there to make things literally fall apart when a marker object happens to be behind a memory barrier, for example. Like I said, no idea. I've added Helmut and Pip in CC.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 09:19:01 +0000 Resent-Message-ID: <handler.77924.B77924.174548629632247 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics <rudalics@HIDDEN> Cc: Pip Cet <pipcet@HIDDEN>, Helmut Eller <eller.helmut@HIDDEN>, Juri Linkov <juri@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, 77924 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, stefankangas@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174548629632247 (code B ref 77924); Thu, 24 Apr 2025 09:19:01 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 09:18:16 +0000 Received: from localhost ([127.0.0.1]:35974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7sim-0008O1-41 for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 05:18:16 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:61697) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u7sii-0008NO-KA for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 05:18:13 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-39c266c2dd5so811012f8f.3 for <77924 <at> debbugs.gnu.org>; Thu, 24 Apr 2025 02:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745486286; x=1746091086; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LtgcemCM43s1/LgT3PX8uc69O/iQX5xxHBlZ9nM9G0Q=; b=V9fEGVgs+RzdMfhUC2YxfHkFZZIuCIlO5mJJ4cjzSLeVXPHIJAyxIgSPkmXg9WtcYt q86AdAiNh5b9OYIMCbdgcBRLxeEqEoKDty0n91hgmWrnO1nkU1/T40wjsPP8k7gy4g7q 3YUMtimIAh3x96MLH+WnJ3sg+IRGPW0lNqOBuErBLa9fjUZW6svC7GudIifrV1aqS0k2 3TBkX+tpD+tiyfsMs8+buxD0ybk0yWRTpHyeGexx1XFXfngLA8hb+1KTc7eEKyFF+uD/ ixBreQ1TTvNj6iJhKSdYA0Tazc7TzrCSSPDwZnmQrmIv4Ga97YGawrQsmbkqZ3NNCxR7 oGIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745486286; x=1746091086; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LtgcemCM43s1/LgT3PX8uc69O/iQX5xxHBlZ9nM9G0Q=; b=M3CSu9O4jMinfy+YdOXIAcPxyRsHbymdLnGBfNT7kHIzI/tt6EQOBkLrD1B79lAwKr zBKz8iEp7zJOZaXEWIRF8P5RlRIhUAM/CCto8N8i9cea1geFDCKjRG5NLCft1oTHcjqF 6QnbFSTdkQX96r48mriCzYlY4Pi+Rw/mEY0hZUmFEXLnfTTwNvjTDiWYU9xAbNekGmcp 1uwZ0r85BJpJHf/sk/2rw4f9rDFNjANitNEJujngti0KV4dP/LYeTPlndDr54yFyVsi5 tGBhg12Up23oUoqoRSdraP4F0FOv+L9qIw6K58gO0pcdIhRRBAxoWQfwyckACzoI3oTW MlzQ== X-Forwarded-Encrypted: i=1; AJvYcCXRCMVd7YRu9+3oCd24tAgWWS24nSURJ/A2Oy2uC7U7b+Xt5TwoeMn9h7SqcDFScVbVoorpjw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw2siS+S+GDyocSeXRKqXtEXt7158ZlezNUoEgI0MBiPsoCfgV9 6C5906d635L4iUUGE2ur12fkahMnjeviPNDKGW9qgU8FrZpSVTp2aSYfC+SU X-Gm-Gg: ASbGncsm7368TD5zkngP1lCAjo/n79XZxGftU8pv9myprXXkUFhwc/uGpokmTfUzUyX U+GdEWQbyYZMKi3TimXGdqFM5Sgma4sCXu0h6I2PJY+76+ZBca5O6kqnBJPXF+SlVD3maAfBVmo txXNvRfdG3qTLtAvshuQeh7tg/rTs5KzTZhr2POSw4gp+bohub393ZFWVtIMfTwO/CQ81gE7dII qPYe/BEQ6/KIknkCprgQ0nmTtUUccKuj8mCul76uvB+FAS2lhNtWIj7iEYBNgYDiu1MvyWyfOm9 O/R+bzxdV4V2wH48dVQ7OLNT3WMWJVEKifKc2WbUDEv2b5TocXGcuOhYucXWFTCYHXDjYJWH2GN MuOATsHVs8KxGp86+a3t+NlWDqtreamAo1Pj2huLlza0n94FKOw== X-Google-Smtp-Source: AGHT+IFW5p1JNLZd6mJt/SrYTxZEswqWshb5fdtdmT3K2brpIAVYpFyXYfzdnlKc6VQWdCEL2po0kQ== X-Received: by 2002:a05:6000:1787:b0:38b:d7d2:12f6 with SMTP id ffacd0b85a97d-3a06cf4b720mr1424477f8f.2.1745486286390; Thu, 24 Apr 2025 02:18:06 -0700 (PDT) Received: from pro2 (p200300e0b70e65008c33e61e626c43d3.dip0.t-ipconnect.de. [2003:e0:b70e:6500:8c33:e61e:626c:43d3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d4c30d7sm1426875f8f.44.2025.04.24.02.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 02:18:06 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <m25xitorg7.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvjz7agaos.fsf-monnier+emacs@HIDDEN> <0b0d5bf1-bf98-4f89-87d6-de7e8c5dc291@HIDDEN> <m25xitorg7.fsf@HIDDEN> Date: Thu, 24 Apr 2025 11:18:04 +0200 Message-ID: <m21pthor3n.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > martin rudalics <rudalics@HIDDEN> writes: > >>> BTW, during my rebasing I noticed the following incompatibility: >>> >>> commit 89ad510b2ebd5ed3ed8477e4a45ada3402bcedca >>> Author: Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> >>> Date: Thu Apr 17 08:42:52 2025 +0200 >>> >>> marker-vector.c: Move marker's position info to the array >>> >>> makes it "impossible" to implement `marker-last-position`. >> >> What would 'markerp' then return for a marker whose buffer has been >> killed? The idea of 'marker-last-position' is that if some agent (like >> a tab bar entry) keeps a reference to a killed buffer, that buffer >> cannot be collected and neither its markers, although the latter have >> been unchained already. =E2=80=98marker-position=E2=80=99 would always = return nil for >> such a marker but 'marker-last-position' would have worked in the past. >> >>> AFAICT this function is not used outside of Emacs at all (based on >>> a search of all *ELPA packages), but it *is* used in >>> `window--state-put-2`, since the following commit: >>> >>> commit 912e37b811107768e0cb3bc95184177f817dbdb2 >>> Author: Martin Rudalics <rudalics@HIDDEN> >>> Date: Mon Mar 4 10:33:49 2024 +0100 >>> >>> Fix 'set-window-configuration' and 'window-state-put' >>> >>> What's the impact of breaking `marker-last-position`? >> >> If 'window-restore-killed-buffer-windows' is a function that tries to >> resurrect a killed buffer, it could not derive the position of the start >> and point position of the buffer in that window. So AFAICT the function >> 'tab-bar-select-restore-windows' would be affected. Juri can tell more. >> >> martin > > Hm, that might be an unsolvable problem with igc, actually. At least I > don't know ATM how it could be solved. > > Let me try to explain. The function below is what igc uses to scan a > marker vector and remove stale references (weak references). It's from > my Emacs, not from feature/igc, but that doesn't play a role. the > situation is the same here and there. > > igc.c: > 2136 static mps_res_t > 2137 fix_marker_vector (mps_ss_t ss, struct Lisp_Vector *v) > 2138 { > 2139 MPS_SCAN_BEGIN (ss) > 2140 { > 2141 const ptrdiff_t max_entry =3D XFIXNUM (v->contents[MARKER_VECTO= R_MAX_ENTRY]); > 2142 for (ptrdiff_t e =3D MARKER_VECTOR_HEADER_SIZE; > 2143 e <=3D max_entry; e +=3D MARKER_VECTOR_ENTRY_SIZE) > 2144 { > 2145 /* Note that we cannot access anything of a marker here bec= ause > 2146 that is not allowed by MPS while scanning an unrelated > 2147 object. This includes MARKERP because that accesses the > 2148 header of a marker. */ > 2149 Lisp_Object *p =3D &v->contents[e + MARKER_VECTOR_OFFSET_MA= RKER]; > 2150 if (!NILP (*p) && !FIXNUMP (*p)) > 2151 { > 2152 IGC_FIX12_OBJ (ss, p); > 2153 if (NILP (*p)) > 2154 { > 2155 /* Changed to nil means the weak reference was to a= dead > 2156 marker. Put on free-list. */ > 2157 v->contents[e] =3D v->contents[MARKER_VECTOR_FREE]; > 2158 v->contents[MARKER_VECTOR_FREE] =3D make_fixnum (e); > 2159 } > 2160 } > 2161 } > 2162 } > 2163 MPS_SCAN_END (ss); > 2164 return MPS_RES_OK; > 2165 } > > The problem is that MPS doesn't allow accessing other MPS-managed > objects while working on the marker vector. See the comment at line 2145. > > Markers are such MPS-managed objects, so we can't read or change members > of a marker here, not the buffer, not something else. > > That restriction is very real, it suffices to add a MARKERP there to > make things literally fall apart when a marker object happens to be > behind a memory barrier, for example. > > Like I said, no idea. I've added Helmut and Pip in CC. No wait, not a problem :-). If someone from Lisp has that marker in his hands, it's of course not dead. So, sorry for the confusion. So, one could, theoretically store the charpos in a field of a marker when "unchaining" it. Ugly, but doable.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Visuwesh <visuweshm@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 09:39:01 +0000 Resent-Message-ID: <handler.77924.B77924.17454875046664 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Cc: Eli Zaretskii <eliz@HIDDEN>, stefankangas@HIDDEN, yantar92@HIDDEN, 77924 <at> debbugs.gnu.org, monnier@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.17454875046664 (code B ref 77924); Thu, 24 Apr 2025 09:39:01 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 09:38:24 +0000 Received: from localhost ([127.0.0.1]:36226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7t2F-0001jP-Hr for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 05:38:24 -0400 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]:48384) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <visuweshm@HIDDEN>) id 1u7t2A-0001hi-J4 for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 05:38:20 -0400 Received: by mail-pj1-x1044.google.com with SMTP id 98e67ed59e1d1-301a4d5156aso958954a91.1 for <77924 <at> debbugs.gnu.org>; Thu, 24 Apr 2025 02:38:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745487492; x=1746092292; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QcfMngQAgbXD4ITDt4jbHaQo7z5dVA0EA66uCB4vtSc=; b=mtjrhyDLwJ6ZGHWxYKimc6sEMchqKWZFUIQIGo5vIjv99aOAtfeqnpBA/NPWG4GonL 15XyjmzNgrwR/3QBiX3BsfkUj+BwxIRqZJuwaFQ9ucJ3wvVNKmqarpgHKt/5I5g6U86h tlck02pxjFXzT1Jnu4/QYUvRbICgx6m5E1HqYLlayIhHZsH1q4FUksmKJTuKbwl7Gkqf 4VpMuJTYQY8ZxHqejbismsdkHlGVbHcBqGluEWEWmNQT1P3VP30u0q5mE0R3y879GKz8 6SmnL8ntM95uZquyYkFrA/X7r9nKkQpCgs5RIlRzK8OrwOaSEhDVwUhW2OI6PfZHDSY9 qrtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745487492; x=1746092292; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QcfMngQAgbXD4ITDt4jbHaQo7z5dVA0EA66uCB4vtSc=; b=HZJgLa7paBGpy/DZ8qBuDAERRFL/8bJdvQ42Bghc3Sz5jJfnkCbIorJZtJ1BEr31uu 4BAYfoTSz62ZS4/xouJoJfzTQkm4p64+hAYngAnIbjx+H1aQNgkxisQBkQAuGgmWeXe8 MUEpnGu5uC6OoPGGQswile02MiK0mxBlpGWVVeKsijMZAwe1pZ2kNn2W/gTWM70Fqg+R j5QTZWvwBgtEqyMWKjtNnQYS9/Tp5sZgmXsp64BusujNG/q5VoGAHidUo0WRnSn35tEX VXxAW1amZusnxbHQwCIrRWc7EN89xSfRX36+jsK3HWw2CNeHxMQ4cpwHfZMB+D1+qWhU CMHw== X-Forwarded-Encrypted: i=1; AJvYcCX5uKhUGMygmGQoqJrOk8hub6Q/XYXYD0EOPQ7mqIlvar7bBvZYDAK/xC6ssPvQNtYCjx012A==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yz7mj3A/RfIwytDMZF+ev1ia0ce7W6fxRiP2jX/C/I26BcWGlL0 4WqRQqCli+oZF4dLGtGibcllZYQNLPxDAnm1Adg8zKUVHb2wcPDL X-Gm-Gg: ASbGncsEMG9MAjzOLnn8MJi6HhLT5Xc8F3AnncC2Kq+4ySSrz5Wol4X7ackHNCPr1qa +dgY+v+TPBnF3JvExH0wwJfNwiarKrdaaz6fXz9dHKGocuICak6i+5U4usYuvOCflh57Je3HooM RhLNFsTPc4o+08IqAjMDvRqhrCnGr4LJnlkWCFFUlZo8uzPGUqQmTKlTV6IZ/mjMrLG/hrlQS1M fAwmCL0URCc+FLSf8xmFgjvu3svf+r+4YqIa9adJ1AUAasOkE4IvOTRRU1Nrue/kcZSVBo89RTe 8TTmC36RIgq533hJdIoC97jTZ/FntByEmWJqlw20ew== X-Google-Smtp-Source: AGHT+IGQDkd38YJKM661NWUzzDrYleoWQ6Gd4KeZb7URltUhxQYn4ku39KdfK1TT2lA5TEJ2vK/aBA== X-Received: by 2002:a17:90b:6cb:b0:2ee:d024:e4fc with SMTP id 98e67ed59e1d1-309ed341c95mr3305022a91.33.1745487492115; Thu, 24 Apr 2025 02:38:12 -0700 (PDT) Received: from localhost ([1.7.159.71]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-309ef03b22esm962157a91.4.2025.04.24.02.38.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 02:38:11 -0700 (PDT) From: Visuwesh <visuweshm@HIDDEN> In-Reply-To: <m2a586neq2.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvecxiga9d.fsf-monnier+emacs@HIDDEN> <86msc6ywyx.fsf@HIDDEN> <m2ikmunmiq.fsf@HIDDEN> <86cyd2yp45.fsf@HIDDEN> <m2a586neq2.fsf@HIDDEN> Date: Thu, 24 Apr 2025 15:08:07 +0530 Message-ID: <87frhxnbls.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE=8F= =E0=AE=AA=E0=AF=8D=E0=AE=B0=E0=AE=B2=E0=AF=8D 24, 2025] Gerd M=C3=B6llmann = wrote: > Eli Zaretskii <eliz@HIDDEN> writes: > >> I trust you and Stefan to decide on that. I myself am not familiar >> with the elisp-benchmarks suite well enough to have an opinion that is >> of importance. From where I stand, the important part is comparing >> the current master with the branch. >> >>> Don't know about the scrolling benchmark. Is what is in elisp-benchmarks >>> enough? If not, can you please give me a bencnhmark file for what you >>> want benchmarked? >> >> I don't know whether we have it in elisp-benchmarks, but if we don't, >> then the following should be good enough: >> >> (defun scroll-up-benchmark () >> (interactive) >> (let ((oldgc gcs-done) >> (oldtime (float-time))) >> (condition-case nil (while t (scroll-up) (redisplay)) >> (error (message "GCs: %d Elapsed time: %f seconds" >> (- gcs-done oldgc) (- (float-time) oldtime)))))) >> >> Evaluate this, then invoke "M-x scroll-up-benchmark" in a large buffer >> with lots of non-ASCII characters. Compare the timings between the >> two versions of Emacs. > > elb-scroll from elisp-bechmarks is basically > > (dotimes (_ 10) > (elb-smie-mode) > (goto-char (point-min)) > (condition-case nil > (while t (scroll-up nil) (redisplay 'force)) > (end-of-buffer nil)))))) > > looks similar, but I don't know what elb-smie-mode does. elb-smie-mode's is Stefan's SMIE demo as a C major-mode AFAIU. > Seems to have something to do with prog-mode, so maybe this depends on > the test file being a C file, which might be interesting for Visuwesh. I commented out (elb-smie-mode) form in the above snippet and that showed a backtrace which I could not explain. Replacing the form with (text-mode) didn't help either. So I'm running the benchmark with that form intact, even though the file I'm scrolling through is a text file. I am running the benchmark currently, and will report the results once they are done. Debugger entered--Lisp error: (overflow-error) round(-0.0e+NaN) (let ((squares (apply #'+ (mapcar #'(lambda (x) (expt x 2)) errs)))) (rou= nd (/ (* 100 (sqrt squares)) elapsed))) (format "|%2d%%\n" (let ((squares (apply #'+ (mapcar #'(lambda ... ...) e= rrs)))) (round (/ (* 100 (sqrt squares)) elapsed)))) (insert (format "|%2d%%\n" (let ((squares (apply #'+ (mapcar #'... errs))= )) (round (/ (* 100 (sqrt squares)) elapsed))))) (let* ((--cl-var-- tests) (test nil) (l nil) (test-elapsed nil) (test-gcs= nil) (test-gc-elapsed nil) (test-err nil) (elapsed 0) (gcs 0) (gc-elapsed = 0) (errs nil) (--cl-var-- t)) (while (consp --cl-var--) (setq test (car --c= l-var--)) (setq l (gethash test res)) (setq test-elapsed (let* ((--cl-var--= l) (x nil) (--cl-var-- 0)) (while (consp --cl-var--) (setq x (car --cl-var= --)) (setq --cl-var-- (+ --cl-var-- (car x))) (setq --cl-var-- (cdr --cl-va= r--))) --cl-var--)) (setq test-gcs (let* ((--cl-var-- l) (x nil) (--cl-var-= - 0)) (while (consp --cl-var--) (setq x (car --cl-var--)) (setq --cl-var-- = (+ --cl-var-- (car ...))) (setq --cl-var-- (cdr --cl-var--))) --cl-var--)) = (setq test-gc-elapsed (let* ((--cl-var-- l) (x nil) (--cl-var-- 0)) (while = (consp --cl-var--) (setq x (car --cl-var--)) (setq --cl-var-- (+ --cl-var--= (car ...))) (setq --cl-var-- (cdr --cl-var--))) --cl-var--)) (setq test-er= r (if (cdr l) (elb-std-deviation (mapcar #'car l)))) (insert (apply #'forma= t "|%s|%.2f|%.2f|%d|%.2f" test (mapcar #'(lambda (x) (/ x runs)) (list (- t= est-elapsed test-gc-elapsed) test-gc-elapsed test-gcs test-elapsed)))) (ins= ert (format "|%2d%%\n" (if test-err (round (/ (* 100 test-err) test-elapsed= )) -0.0))) (setq elapsed (+ elapsed test-elapsed)) (setq gcs (+ gcs test-gc= s)) (setq gc-elapsed (+ gc-elapsed test-gc-elapsed)) (setq errs (nconc errs= (list (or test-err -0.0)))) (setq --cl-var-- (cdr --cl-var--)) (setq --cl-= var-- nil)) (insert "|-\n") (insert (apply #'format "|total|%.2f|%.2f|%d|%.= 2f" (mapcar #'(lambda (x) (/ x runs)) (list (- elapsed gc-elapsed) gc-elaps= ed gcs elapsed)))) (insert (format "|%2d%%\n" (let ((squares (apply #'+ (ma= pcar ... errs)))) (round (/ (* 100 (sqrt squares)) elapsed))))) nil) elb--display(("scroll") #<hash-table equal 0/0 0x10e69c524987 ...> 1) (while (>=3D (setq --cl-var-- (1- --cl-var--)) 0) (message "Iteration num= ber: %d" i) (let* ((--cl-var-- tests) (test nil) (entry-point nil) (--cl-va= r-- t)) (while (consp --cl-var--) (setq test (car --cl-var--)) (setq entry-= point (intern (concat "elb-" test "-entry"))) (garbage-collect) (message "R= unning %s..." test) (let ((time (condition-case err (condition-case nil ...= ...) (... ... nil)))) (if time (progn (let* (... ...) (puthash v ... v))))= ) (setq --cl-var-- (cdr --cl-var--)) (setq --cl-var-- nil)) nil) (elb--disp= lay tests res i) (setq i (+ i 1))) (let* ((runs (or runs elb-runs)) (--cl-var-- runs) (i 1)) (while (>=3D (s= etq --cl-var-- (1- --cl-var--)) 0) (message "Iteration number: %d" i) (let*= ((--cl-var-- tests) (test nil) (entry-point nil) (--cl-var-- t)) (while (c= onsp --cl-var--) (setq test (car --cl-var--)) (setq entry-point (intern (co= ncat "elb-" test "-entry"))) (garbage-collect) (message "Running %s..." tes= t) (let ((time (condition-case err ... ...))) (if time (progn (let* ... ...= )))) (setq --cl-var-- (cdr --cl-var--)) (setq --cl-var-- nil)) nil) (elb--d= isplay tests res i) (setq i (+ i 1))) nil) (let ((tests (let ((names 'nil)) (mapatoms #'(lambda (s) (let ... ...))) = (sort names #'string-lessp)))) (let* ((runs (or runs elb-runs)) (--cl-var--= runs) (i 1)) (while (>=3D (setq --cl-var-- (1- --cl-var--)) 0) (message "I= teration number: %d" i) (let* ((--cl-var-- tests) (test nil) (entry-point n= il) (--cl-var-- t)) (while (consp --cl-var--) (setq test (car --cl-var--)) = (setq entry-point (intern (concat "elb-" test "-entry"))) (garbage-collect)= (message "Running %s..." test) (let ((time ...)) (if time (progn ...))) (s= etq --cl-var-- (cdr --cl-var--)) (setq --cl-var-- nil)) nil) (elb--display = tests res i) (setq i (+ i 1))) nil)) (let* ((native-comp-speed elb-speed) (compilation-safety elb-safety) (com= pile-function (if (featurep 'native-compile) #'native-compile #'byte-compil= e-file)) (res (make-hash-table :test #'equal)) (sources (directory-files el= b-bench-directory t "\\.el\\'")) (test-sources (if selector (let* ((--cl-va= r-- sources) (f nil) (--cl-var-- nil)) (while (consp --cl-var--) (setq f (c= ar --cl-var--)) (if (string-match selector f) (progn ...)) (setq --cl-var--= (cdr --cl-var--))) (nreverse --cl-var--)) sources))) (if recompile (progn = (mapc #'(lambda (f) (message "Compiling... %s" f) (funcall compile-function= f)) test-sources))) (mapc #'(lambda (file) (condition-case err (load file)= ((debug error) (message "Error loading: %S" err) nil))) (mapcar (if (and (= featurep 'native-compile) (fboundp 'comp-el-to-eln-filename)) #'comp-el-to-= eln-filename #'file-name-sans-extension) test-sources)) (let ((tests (let (= (names 'nil)) (mapatoms #'(lambda ... ...)) (sort names #'string-lessp)))) = (let* ((runs (or runs elb-runs)) (--cl-var-- runs) (i 1)) (while (>=3D (set= q --cl-var-- (1- --cl-var--)) 0) (message "Iteration number: %d" i) (let* (= (--cl-var-- tests) (test nil) (entry-point nil) (--cl-var-- t)) (while (con= sp --cl-var--) (setq test (car --cl-var--)) (setq entry-point (intern ...))= (garbage-collect) (message "Running %s..." test) (let (...) (if time ...))= (setq --cl-var-- (cdr --cl-var--)) (setq --cl-var-- nil)) nil) (elb--displ= ay tests res i) (setq i (+ i 1))) nil))) (progn (if --cl-rest-- (signal 'wrong-number-of-arguments (list 'elisp-be= nchmarks-run (+ 3 (length --cl-rest--))))) (let* ((native-comp-speed elb-sp= eed) (compilation-safety elb-safety) (compile-function (if (featurep 'nativ= e-compile) #'native-compile #'byte-compile-file)) (res (make-hash-table :te= st #'equal)) (sources (directory-files elb-bench-directory t "\\.el\\'")) (= test-sources (if selector (let* ((--cl-var-- sources) (f nil) (--cl-var-- n= il)) (while (consp --cl-var--) (setq f ...) (if ... ...) (setq --cl-var-- .= ..)) (nreverse --cl-var--)) sources))) (if recompile (progn (mapc #'(lambda= (f) (message "Compiling... %s" f) (funcall compile-function f)) test-sourc= es))) (mapc #'(lambda (file) (condition-case err (load file) ((debug error)= (message "Error loading: %S" err) nil))) (mapcar (if (and (featurep 'nativ= e-compile) (fboundp 'comp-el-to-eln-filename)) #'comp-el-to-eln-filename #'= file-name-sans-extension) test-sources)) (let ((tests (let ((names ...)) (m= apatoms #'...) (sort names #'string-lessp)))) (let* ((runs (or runs elb-run= s)) (--cl-var-- runs) (i 1)) (while (>=3D (setq --cl-var-- (1- --cl-var--))= 0) (message "Iteration number: %d" i) (let* ((--cl-var-- tests) (test nil)= (entry-point nil) (--cl-var-- t)) (while (consp --cl-var--) (setq test ...= ) (setq entry-point ...) (garbage-collect) (message "Running %s..." test) (= let ... ...) (setq --cl-var-- ...) (setq --cl-var-- nil)) nil) (elb--displa= y tests res i) (setq i (+ i 1))) nil)))) (let* ((recompile (if --cl-rest-- (car-safe (prog1 --cl-rest-- (setq --cl= -rest-- (cdr --cl-rest--)))) t)) (runs (car-safe (prog1 --cl-rest-- (setq -= -cl-rest-- (cdr --cl-rest--)))))) (progn (if --cl-rest-- (signal 'wrong-num= ber-of-arguments (list 'elisp-benchmarks-run (+ 3 (length --cl-rest--))))) = (let* ((native-comp-speed elb-speed) (compilation-safety elb-safety) (compi= le-function (if (featurep 'native-compile) #'native-compile #'byte-compile-= file)) (res (make-hash-table :test #'equal)) (sources (directory-files elb-= bench-directory t "\\.el\\'")) (test-sources (if selector (let* (... ... ..= .) (while ... ... ... ...) (nreverse --cl-var--)) sources))) (if recompile = (progn (mapc #'(lambda ... ... ...) test-sources))) (mapc #'(lambda (file) = (condition-case err (load file) (... ... nil))) (mapcar (if (and (featurep = ...) (fboundp ...)) #'comp-el-to-eln-filename #'file-name-sans-extension) t= est-sources)) (let ((tests (let (...) (mapatoms ...) (sort names ...)))) (l= et* ((runs (or runs elb-runs)) (--cl-var-- runs) (i 1)) (while (>=3D (setq = --cl-var-- ...) 0) (message "Iteration number: %d" i) (let* (... ... ... ..= .) (while ... ... ... ... ... ... ... ...) nil) (elb--display tests res i) = (setq i (+ i 1))) nil))))) elisp-benchmarks-run("elb-scroll" t 100) (progn (elisp-benchmarks-run "elb-scroll" t 100)) eval((progn (elisp-benchmarks-run "elb-scroll" t 100)) t) elisp--eval-last-sexp(nil) #f(compiled-function () #<bytecode 0xf3e77a510d12>)() handler-bind-1(#f(compiled-function () #<bytecode 0xf3e77a510d12>) (error= ) eval-expression--debug) eval-last-sexp(nil) funcall-interactively(eval-last-sexp nil) call-interactively(eval-last-sexp nil nil) command-execute(eval-last-sexp)
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 10:00:02 +0000 Resent-Message-ID: <handler.77924.B77924.174548876012782 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics <rudalics@HIDDEN> Cc: Pip Cet <pipcet@HIDDEN>, Helmut Eller <eller.helmut@HIDDEN>, Juri Linkov <juri@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, 77924 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, stefankangas@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174548876012782 (code B ref 77924); Thu, 24 Apr 2025 10:00:02 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 09:59:20 +0000 Received: from localhost ([127.0.0.1]:36398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7tMV-0003K6-LI for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 05:59:19 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:58611) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u7tMT-0003Jd-1v for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 05:59:17 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-39c1ef4acf2so576864f8f.0 for <77924 <at> debbugs.gnu.org>; Thu, 24 Apr 2025 02:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745488751; x=1746093551; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eY3DdER2f+MvFoYNa3MbluouUpFYhcLzHMExU+jMqu8=; b=DL6noyhbSd4T/gZq8ISH8folFOfodLxzDTRjx1GeFIKMQwPWzwblg5EkqEzuTX7Gni mpPmMlX14H+/ypumljEvbjPTH5d33bJJ+FCcYxoMphiq/jWUVz1yqH7urmhRpEyd4MSZ nP367RqZJA9CuYV+UE1fJkhSdzBVrcr2AP99GoD8EAyj8tUPrxvTLEHxeDvNLkG8+uU0 LWOOmzT3fwtIC0nqjNi0H2sFVWqD5SbugIxKCChoi6xKhgtoI5LK+wTr8uIRBuxCUEFh 5roE9CM3guTpZtjQU55D0kZQXojxzkDXRpqczkCtfjHxVz+xBG8LItEXQPXYFljPDOzf eCKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745488751; x=1746093551; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eY3DdER2f+MvFoYNa3MbluouUpFYhcLzHMExU+jMqu8=; b=UoFboSYVJrNv/HcLymAO1mIYO4Xz8awLS2uXJBBBG+JlTDvmYkTMwW5mQ+duPspmDj nFWrWygo7zUMO8RN3WjElABVxEFvYxJGzmx2N9P2JNUyRNGd3ocb/se98vFIaPkZZxwn PJcFZ0drCe6hhybYO8lYFe732KHEJklS9l35fP89ALFd2Nve0unEdWN8LWk9JaEjLb+s GZqtIY4+ppM0QoHWbv2G0RF9s6WMUB0GilN+leiS3Sw5ktbzrmgqcfevi/SiEsdDVniE Uh6FPuxcl9EYyM8fZZzw2ITJG8tqALQSB1Rl+D4WCG0m6HpAYhMYbfR5fGH2zleQtYt1 fFYA== X-Forwarded-Encrypted: i=1; AJvYcCUgwKqSFwYk4PBj3sRj/qDSOIce6hLU8gid/5+9DfJ5Ri4StMkwdKyqSZjtlw0uyRCZEExWBw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YziU7PUWeWeom5WT4IaHUon1RGlH1WgfwAM4Tx+f7MOZjK3T9Kq KQ5zL+5NiIaDkb5kP1sQwhXk7VG5jOx6l/rBcUrq2A5pqh1Lb5sh X-Gm-Gg: ASbGncuuDiC2xfXPnvTS0DJuDowuxPwN9UsXcs1QRJRobyVsPdgvnnvnchXtBuL4qdV QmmzW4z+cyUBQyEUfQJnQLLOO85ZxBqx5lv8ew0lu0GncYT5nwJj0N6hixdaExgsjYO/Ux6+61w 1ObUfVLPEuTQ9pZn222dJn/0j6s1yXIJCsZe216q/SzoLYRamYH7ymm5hGLwpJf/XCiLJHeX9sC 0PyNXALUOSWWtLXd9mKrR+EOrpXVLbhMDemwa8vQnZHW+QNDgyuePkkSIVlD8o6axOuhQp1pXZk GZ5SsDcu6vCQ24ua+34KofkitIel6zW5FoDSwCWE0M/sV04i0z7d9Cxh2S0WY3BR2wXyx+LVpvY pWjTXBA0b+BiDGX3bOw6lKMahZWy+hs+IstO93/QOE4FrCf9ULg== X-Google-Smtp-Source: AGHT+IHMJ0MxzIhignnvrt2xqqkFf17VGv1vbmwqwJVtUlYBaDzfxobX56I/6KiJKaha8pxv7gvR4w== X-Received: by 2002:a05:6000:2283:b0:390:e8d4:6517 with SMTP id ffacd0b85a97d-3a06cf5efc9mr1572130f8f.21.1745488750862; Thu, 24 Apr 2025 02:59:10 -0700 (PDT) Received: from pro2 (p200300e0b70e65008c33e61e626c43d3.dip0.t-ipconnect.de. [2003:e0:b70e:6500:8c33:e61e:626c:43d3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d532dfesm1564711f8f.63.2025.04.24.02.59.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 02:59:10 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <m21pthor3n.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvjz7agaos.fsf-monnier+emacs@HIDDEN> <0b0d5bf1-bf98-4f89-87d6-de7e8c5dc291@HIDDEN> <m25xitorg7.fsf@HIDDEN> <m21pthor3n.fsf@HIDDEN> Date: Thu, 24 Apr 2025 11:59:09 +0200 Message-ID: <m2wmb9namq.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > So, one could, theoretically store the charpos in a field of a marker > when "unchaining" it. Ugly, but doable. And one could do something practically, which I now pushed to savannah.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 10:07:06 +0000 Resent-Message-ID: <handler.77924.B77924.174548921715640 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Visuwesh <visuweshm@HIDDEN> Cc: Eli Zaretskii <eliz@HIDDEN>, stefankangas@HIDDEN, yantar92@HIDDEN, 77924 <at> debbugs.gnu.org, monnier@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174548921715640 (code B ref 77924); Thu, 24 Apr 2025 10:07:06 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 10:06:57 +0000 Received: from localhost ([127.0.0.1]:36442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7tTr-00043x-2i for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 06:06:57 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:47495) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u7tTk-000421-Hl for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 06:06:51 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3913958ebf2so637209f8f.3 for <77924 <at> debbugs.gnu.org>; Thu, 24 Apr 2025 03:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745489202; x=1746094002; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nMeeg034WgnHukDiAdYxWCJ8y7BDBhpffWyeJZmPpQA=; b=SO1KkcqJrPFd9AFevfgVoeqSQuvoaLjyRbvRHkGQ/iK+SOEsKi5UGA7hi3etpgPUTW bm4FWvfbAxfYdFPoj9TTxaBfi5QEqFC/QRQ2w9mXT2VOsk91iZ7nEZntzdLeY6j1WUEJ UMHukIyPE5S8AzB/JBBrkABOOl4dNC6s38NxSt1SfEoyMAerKvVUsg1cjMgtbdtSotAe HIcOK+ei58Ueow0nFhstTgjdXRjDhKcPtNE7t9Z7OzN1Aeon6Q31dCBmyLAbCCBAZn4U TZfWGUtxzWyRNVTfdaMnEcTD5h4D9ExI0srsZAANZqXIuLo4MtlpDYm3/v/FfDR/uxbs ytBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745489202; x=1746094002; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nMeeg034WgnHukDiAdYxWCJ8y7BDBhpffWyeJZmPpQA=; b=G8K9gvi+VkgVSn4uTdHuSyM8gmz1BrYV3WloEn3xqLiI+Fod7rAUxCTo5O9oDH+hw+ sj5w2Uql/cCiW9+zotcZYHsha+285Dlnk90ChynAZxkfskdFUNbGRDXJd0/t4s5fSm6n f509sbTqDJpczNTyYB9JWDrBDttzktPSi+0M3YdWh6tSojNDlRf5jKG5sTyt3zQOkuZa T6W3ZIuxV1Seb3ShFeuSt8ds5VPg05MK35YRBDmPaGf+2awvKQIIppsnfqN7RAsbqt1Q CemYzxcTA70XElrwKZbu9csy/u3x8JbietIYA20uBnAWtYq2UJvcWHyIVz6DnbPneRrC luLg== X-Forwarded-Encrypted: i=1; AJvYcCUGEOvNiOgOIzVPG8foofDpRFqse2Bv3XP1n2Qv7KP3z8o57QZYzHA3PDqgVyhGBfrmHgjklA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyvFhzRGEptg8AqCoODnIky5d54ZMENUYrDtLGnRJbdpaC0sYoA IaoaFuIYJWsa2UKz8efdbgCSK59TpgnPbLGst8vq2VUEUbvhzVC9SiBXGNGG X-Gm-Gg: ASbGncs9ux5K/AgnCMtM2SAMqkO3C30ulQuu7EOOxWdaZQAH7/UT7jAf8xJMSbwMi1l bJAsqZhTj9gPUdbKJiHok0qMP1mAtGysiP4hpi1yV0JTGHfTZSblq2hUQ/xS49ybjmXrzcZQBi8 lP0kRBKo04ao8PXOGa/WAhYyGb8pA5npWvFCeTNtpf4DmLOnO5inyuwVSkB7WcYhjHFTbchg0Zz DAj+0X+sz89akwA+mvqxfgK5+hmyA8vqwARzXVR5yuVtPCMGf34OAN18+t4ADt9cMZfeIk5Q1CM CFkkLIWjyzFgwcBVThPnlLXzVhloPC0Q5phYFt9WtLht5wtoRlLJq4JVHXWRiMASHrw1P2awU4y 2SxWGfNEX5K1tVwAOoZ1Pj2kiOQDtpCgL76f8BgjdjApvRxNa2A== X-Google-Smtp-Source: AGHT+IGtvPMavSikn+/n6Nw3pTBiDc3t34Mpct0/aUfbCpvl/H5xIlYiDvaw/JK2XqO/CAYmf1N5JQ== X-Received: by 2002:a5d:6da7:0:b0:39c:f0d:9146 with SMTP id ffacd0b85a97d-3a06cfa5b6cmr1673364f8f.45.1745489201972; Thu, 24 Apr 2025 03:06:41 -0700 (PDT) Received: from pro2 (p200300e0b70e65008c33e61e626c43d3.dip0.t-ipconnect.de. [2003:e0:b70e:6500:8c33:e61e:626c:43d3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d532551sm1584678f8f.65.2025.04.24.03.06.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 03:06:41 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <87frhxnbls.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvecxiga9d.fsf-monnier+emacs@HIDDEN> <86msc6ywyx.fsf@HIDDEN> <m2ikmunmiq.fsf@HIDDEN> <86cyd2yp45.fsf@HIDDEN> <m2a586neq2.fsf@HIDDEN> <87frhxnbls.fsf@HIDDEN> Date: Thu, 24 Apr 2025 12:06:40 +0200 Message-ID: <m2plh1naa7.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Visuwesh <visuweshm@HIDDEN> writes: > [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE= =8F=E0=AE=AA=E0=AF=8D=E0=AE=B0=E0=AE=B2=E0=AF=8D 24, 2025] Gerd M=C3=B6llma= nn wrote: > >> looks similar, but I don't know what elb-smie-mode does. > > elb-smie-mode's is Stefan's SMIE demo as a C major-mode AFAIU. Thanks, but I have no idea what that does. > >> Seems to have something to do with prog-mode, so maybe this depends on >> the test file being a C file, which might be interesting for Visuwesh. > > I commented out (elb-smie-mode) form in the above snippet and that > showed a backtrace which I could not explain. Replacing the form with > (text-mode) didn't help either. So I'm running the benchmark with that > form intact, even though the file I'm scrolling through is a text file. > I am running the benchmark currently, and will report the results once > they are done. > > Debugger entered--Lisp error: (overflow-error) > round(-0.0e+NaN) > (let ((squares (apply #'+ (mapcar #'(lambda (x) (expt x 2)) errs)))) > (round (/ (* 100 (sqrt squares)) elapsed))) > (format "|%2d%%\n" (let ((squares (apply #'+ (mapcar #'(lambda ... > ...) errs)))) (round (/ (* 100 (sqrt squares)) elapsed)))) > (insert (format "|%2d%%\n" (let ((squares (apply #'+ (mapcar #'... > errs)))) (round (/ (* 100 (sqrt squares)) elapsed))))) > (let* ((--cl-var-- tests) (test nil) (l nil) (test-elapsed nil) > (test-gcs nil) (test-gc-elapsed nil) (test-err nil) (elapsed 0) (gcs > 0) (gc-elapsed 0) (errs nil) (--cl-var-- t)) (while (consp --cl-var--) > (setq test (car --cl-var--)) (setq l (gethash test res)) (setq > test-elapsed (let* ((--cl-var-- l) (x nil) (--cl-var-- 0)) (while > (consp --cl-var--) (setq x (car --cl-var--)) (setq --cl-var-- (+ > --cl-var-- (car x))) (setq --cl-var-- (cdr --cl-var--))) --cl-var--)) > (setq test-gcs (let* ((--cl-var-- l) (x nil) (--cl-var-- 0)) (while > (consp --cl-var--) (setq x (car --cl-var--)) (setq --cl-var-- (+ > --cl-var-- (car ...))) (setq --cl-var-- (cdr --cl-var--))) > --cl-var--)) (setq test-gc-elapsed (let* ((--cl-var-- l) (x nil) > (--cl-var-- 0)) (while (consp --cl-var--) (setq x (car --cl-var--)) > (setq --cl-var-- (+ --cl-var-- (car ...))) (setq --cl-var-- (cdr > --cl-var--))) --cl-var--)) (setq test-err (if (cdr l) > (elb-std-deviation (mapcar #'car l)))) (insert (apply #'format Something went wrong when computing the "err" values, apparently. Maybe it'll work if you increase the number of runs the NaN goes away?
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Visuwesh <visuweshm@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 10:34:03 +0000 Resent-Message-ID: <handler.77924.B77924.174549079325565 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Cc: Eli Zaretskii <eliz@HIDDEN>, stefankangas@HIDDEN, yantar92@HIDDEN, 77924 <at> debbugs.gnu.org, monnier@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174549079325565 (code B ref 77924); Thu, 24 Apr 2025 10:34:03 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 10:33:13 +0000 Received: from localhost ([127.0.0.1]:36614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7ttE-0006do-J0 for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 06:33:12 -0400 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:44437) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <visuweshm@HIDDEN>) id 1u7tt7-0006cc-Ir for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 06:33:05 -0400 Received: by mail-pf1-x441.google.com with SMTP id d2e1a72fcca58-736b350a22cso611390b3a.1 for <77924 <at> debbugs.gnu.org>; Thu, 24 Apr 2025 03:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745490775; x=1746095575; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PFWSNAAUnyUb1IFjv6bZyc8g7vi3AQWGyjte3qjWp/U=; b=IhQZLeUHmcQWOrap+mfomUZaoqU/eZcKbYGltDlal4E4C7v3nnVLUUKlHr01d/iqxI CvkxD8M3FjTC0TU7NjsMDhbVXO7Kwus+da9HJIeCpXDXyyTvRDTlj7SExsEIMeh0xNM4 9txvqZNDU4t26s/xtSWNgHxlylqACvfAZCu3HX5sqFichCka3GVtNEGFFQF/1dmCzhwG aUHHLSPoT1AE8mwOG/SOlBV/mzQGIYwTp73GR9yvRxENpwYFeIRvirUMBk/mfp4o3MKj 2tEzE6O62EEDbr3TExFwa9EfpyyNUFnldBNuZwR19nyx0z5o6MDUjMUByMLBkeFzxCpU i1cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745490775; x=1746095575; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PFWSNAAUnyUb1IFjv6bZyc8g7vi3AQWGyjte3qjWp/U=; b=IgH+ITLXSPn7jKEGrb6/NZXj1FE6K/rT352W8y8zTOOjBAS6zcLjw6Sid5tKC6MP7X 6Z20A0kpaJG8KgL/EhaiUaZxj92wtZ3b4TAieazVMBvsaIqrECOVsE61N4lMzzZlf2cS PWclVDiLoIiqwA/X6DluDoWpYhxLWA/Fee+E51LGq3wSgaJx9TEouCPyvDvsjN4Avnxv +BZVnbfiV6V3wtAshba/VuVRrlgibQrix4s+kK1SUsvz8/JoK7oMvF/bOLMY2Ag/Q6QS cmsbaO+0OAg2WM6Rjc8GxPPJrIlCT8ydh4VtsZKIaULmZ+lQ/eGug63UFwjW0mff1LdR U4sg== X-Forwarded-Encrypted: i=1; AJvYcCVurZrLZcgJOmyL0JbbmS2yPYeQtwgYaC0Lpw3zDu1YGTPhjVw4e7ia15LK+s5DlOkjowqeEw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxbQbhiDnPWmc3+FGBXF1vXGxAxe2GbzU25+XMGHTQpE4N0jQP+ 0PyGbpUj9sNgDrtp4rWxRPytqqhLZXRkqdW3dNoz+8s5u46NNBzJ X-Gm-Gg: ASbGncuJyTJ7LoXazMZ/kGgO96LM7d09w1XF8sGw3GdoMJ4KBKJHsLYFL1GDhdE2agg SFvflro1pAIZaz0z+LdgdSmWelB7CnxeK31P7DgLJ1fjCOC24eqp/S/JCPHtd+3v7HdH7V6bcph FNVsenYslZvexHzssenS4Ya39BdiSveHgJgsnlIoWUh2bZOYdmSqQknwCiy/OVjvlt/wFu0cvBk gqn4tCsACGGlqGw8Gd7XWJ60l0u3y2WY51ABExK9ayMFTdN3IHF93y01wKYBEpR10L8ElEHXjuB GWGNEDy4AyvTtBBMzleji1o8t9bETFqS9uzcGVYZow== X-Google-Smtp-Source: AGHT+IHoxvSgnTaXo42OtKc+u2Mn/ah6qjqStcfeNbIzdZkq9RiekgFc2VVhfqwdLQLqhbAHsLF4Hw== X-Received: by 2002:a05:6a20:d706:b0:1f5:77bd:ecbc with SMTP id adf61e73a8af0-20444e9b3a8mr2768233637.16.1745490775007; Thu, 24 Apr 2025 03:32:55 -0700 (PDT) Received: from localhost ([1.7.159.71]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-73e2593f4cfsm1047474b3a.38.2025.04.24.03.32.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 03:32:54 -0700 (PDT) From: Visuwesh <visuweshm@HIDDEN> In-Reply-To: <m2plh1naa7.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvecxiga9d.fsf-monnier+emacs@HIDDEN> <86msc6ywyx.fsf@HIDDEN> <m2ikmunmiq.fsf@HIDDEN> <86cyd2yp45.fsf@HIDDEN> <m2a586neq2.fsf@HIDDEN> <87frhxnbls.fsf@HIDDEN> <m2plh1naa7.fsf@HIDDEN> Date: Thu, 24 Apr 2025 16:02:50 +0530 Message-ID: <87cyd1alyl.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE=8F= =E0=AE=AA=E0=AF=8D=E0=AE=B0=E0=AE=B2=E0=AF=8D 24, 2025] Gerd M=C3=B6llmann = wrote: >>> Seems to have something to do with prog-mode, so maybe this depends on >>> the test file being a C file, which might be interesting for Visuwesh. >> >> I commented out (elb-smie-mode) form in the above snippet and that >> showed a backtrace which I could not explain. Replacing the form with >> (text-mode) didn't help either. So I'm running the benchmark with that >> form intact, even though the file I'm scrolling through is a text file. >> I am running the benchmark currently, and will report the results once >> they are done. >> >> Debugger entered--Lisp error: (overflow-error) >> round(-0.0e+NaN) >> (let ((squares (apply #'+ (mapcar #'(lambda (x) (expt x 2)) errs)))) >> (round (/ (* 100 (sqrt squares)) elapsed))) >> (format "|%2d%%\n" (let ((squares (apply #'+ (mapcar #'(lambda ... >> ...) errs)))) (round (/ (* 100 (sqrt squares)) elapsed)))) >> (insert (format "|%2d%%\n" (let ((squares (apply #'+ (mapcar #'... >> errs)))) (round (/ (* 100 (sqrt squares)) elapsed))))) >> (let* ((--cl-var-- tests) (test nil) (l nil) (test-elapsed nil) >> (test-gcs nil) (test-gc-elapsed nil) (test-err nil) (elapsed 0) (gcs >> 0) (gc-elapsed 0) (errs nil) (--cl-var-- t)) (while (consp --cl-var--) >> (setq test (car --cl-var--)) (setq l (gethash test res)) (setq >> test-elapsed (let* ((--cl-var-- l) (x nil) (--cl-var-- 0)) (while >> (consp --cl-var--) (setq x (car --cl-var--)) (setq --cl-var-- (+ >> --cl-var-- (car x))) (setq --cl-var-- (cdr --cl-var--))) --cl-var--)) >> (setq test-gcs (let* ((--cl-var-- l) (x nil) (--cl-var-- 0)) (while >> (consp --cl-var--) (setq x (car --cl-var--)) (setq --cl-var-- (+ >> --cl-var-- (car ...))) (setq --cl-var-- (cdr --cl-var--))) >> --cl-var--)) (setq test-gc-elapsed (let* ((--cl-var-- l) (x nil) >> (--cl-var-- 0)) (while (consp --cl-var--) (setq x (car --cl-var--)) >> (setq --cl-var-- (+ --cl-var-- (car ...))) (setq --cl-var-- (cdr >> --cl-var--))) --cl-var--)) (setq test-err (if (cdr l) >> (elb-std-deviation (mapcar #'car l)))) (insert (apply #'format > > Something went wrong when computing the "err" values, apparently. Maybe > it'll work if you increase the number of runs the NaN goes away? Oddly enough, it throws an error as soon as I start the benchmark. I don't think even a single iteration in the loop of elb-scroll-entry is complete, let alone a complete run.
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Pip Cet <pipcet@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 11:17:08 +0000 Resent-Message-ID: <handler.77924.B77924.17454933788999 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Cc: Helmut Eller <eller.helmut@HIDDEN>, Juri Linkov <juri@HIDDEN>, martin rudalics <rudalics@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, 77924 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, stefankangas@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.17454933788999 (code B ref 77924); Thu, 24 Apr 2025 11:17:08 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 11:16:18 +0000 Received: from localhost ([127.0.0.1]:36811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7uYw-0002Ku-6I for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 07:16:17 -0400 Received: from mail-4316.protonmail.ch ([185.70.43.16]:59251) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1u7uYm-0002JZ-5O for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 07:16:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1745493356; x=1745752556; bh=PvCVt5u7WyUvGbQ7vaBCaNXVQJSouDrqQkQ0cbFKRQU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=pB6gmAMRvUvc7w3O6va6xKgS58ihCyhlM34j3KmPs/ft0U60KMgHmJEbp1tNNdpxg hs6Os8M4kyz+7zk284evPQs1kgKAn4YF8J/PzTJJ2kvGZHrJoxzOIrqNl9X3M2F5iR a0nFH1NLQVKaCoksh81e+KiWMBGWGoPS63L5GEYrrJejETfm/+zJZevtk2Kx/PzhaS G1e9FWh2vEHvO10eGyhV1BTv9F8Zwpo7kt19C+r7SNzOBnGIX0V1ncbkOP0E1NeYb4 GS//fA4t/nvrKARa/He53cClJj7Z6T1t9znvmFEj9InyY1XGYEnu8xlKklbHzRaFNw CQsMEimLWr4XQ== Date: Thu, 24 Apr 2025 11:15:50 +0000 From: Pip Cet <pipcet@HIDDEN> Message-ID: <87jz79q080.fsf@HIDDEN> In-Reply-To: <m2wmb9namq.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvjz7agaos.fsf-monnier+emacs@HIDDEN> <0b0d5bf1-bf98-4f89-87d6-de7e8c5dc291@HIDDEN> <m25xitorg7.fsf@HIDDEN> <m21pthor3n.fsf@HIDDEN> <m2wmb9namq.fsf@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 20e9abb88a09993a532565af2629ed9312a8f34f MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > >> So, one could, theoretically store the charpos in a field of a marker >> when "unchaining" it. Ugly, but doable. > > And one could do something practically, which I now pushed to savannah. Can you explain how that works in the non-indirect buffer case? AFAICT, we call marker_vector_reset but not marker_vector_remove in that case, and there is no code in marker_vector_reset to remember the last charpos. And the comment in marker_vector_reset sounds like it's not called at all in the IGC case? Pip
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 11:25:09 +0000 Resent-Message-ID: <handler.77924.B77924.174549386711589 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Visuwesh <visuweshm@HIDDEN> Cc: Eli Zaretskii <eliz@HIDDEN>, stefankangas@HIDDEN, yantar92@HIDDEN, 77924 <at> debbugs.gnu.org, monnier@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174549386711589 (code B ref 77924); Thu, 24 Apr 2025 11:25:09 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 11:24:27 +0000 Received: from localhost ([127.0.0.1]:36819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7ugn-00030e-Re for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 07:24:26 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:52552) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u7uge-0002zN-9L for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 07:24:17 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-39c0e0bc733so774500f8f.1 for <77924 <at> debbugs.gnu.org>; Thu, 24 Apr 2025 04:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745493846; x=1746098646; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TyXDSQAcMWcDu2pfgnctucYXTO8uRt2jS/u6sFpepro=; b=GS/RnLhamgvqcYT+E/WPV3BtKSTmE4A+Q5VWnZI10+De+ngIusOCwHgsXtMlpy6Ypl nsTWDWehkUG7RSRSLbM48KFyh6ANP7krw0vZD6Ex5fYO0vTEep8GWmLUJDQcl18bk6Ml u4qV/oDtX0IoFdUb0zHHpFulRiN+2SusY3jPk8ugMH4mwjn1vS2z8pK1aEMC7CdQekU/ CCDsdz0h7grV2zU3Ve2ZFKlPXJgyZs0NwHTJC0D5ZUSLP3rGL7HIvu8pP969BTpawdD8 yFuBhJ5Z95aDTCXwY+biapY5PEBdkyQNp31aeYYVxHKe6OJqEpUlbNQR2uOgAjnwmP5O GJjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745493846; x=1746098646; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TyXDSQAcMWcDu2pfgnctucYXTO8uRt2jS/u6sFpepro=; b=xOnYiatwOkWyq1neTDiybAg9OPlmrBXOh8fF4sUKYZBoxxa8aiXdflW6a65O1EvAHI yuU+gJdSQgSGWKGZFPlM3QlBfTjUgjYBEAHJyBmCl/4jtl3fjQjV1oEyBfCPpbGks7GF QmzhXSAXkd8hf0CYhV0i1AV7LqMZQrCiofKSbdS+sxkPRSYyZLu2K3kbPW7Aa+w+eZ1e bQOsCHui9bumHUv1pP3UpxPM3sMF3yE85EktKRd6QTB6j6SnulMkmddSlFl7mhD8Lg4q Od6WVOd4QwMTUmsHsnXZwEfp063UjK1eUQeQHyERKiiNiY9k0i+Hi45L/sfTrhZZllR+ hNcw== X-Forwarded-Encrypted: i=1; AJvYcCXKTCSGpNaQp7LWTu1/MEDXAgHHmiUxKkUgWCkpEcXV2Y3y6w/BvOCi2RBCO/9ACbkdmXYp7Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzrAHNzM0ZvPc6Vt5mqtw/jqgHwJjll5CvPN1UPtAILCTN9fRta BptWdZflj8U3tPg+JKW13CvciRXv2m/pl3aRUBV0/r43FOxsnWrW X-Gm-Gg: ASbGncuoUReRBjwnlfzM4beso6QO6fv2EC7OMOpxHGMryEjDiRCltN+mdBU7n2QyvM3 DDbEcK1yl8KM9q2AWJt4nv6k2n3zb2vG+z/9YdPRalKpWhIKhObENc6Dw9HE0G3z29RJwL2+ESt vVRPsP3IAaICIOMzCgZ8RPjKbBPnZsQyQhrxIVS7brkHfwESCDvEyNNJk4NMr4UbYK2pK45Eo5d 3KTrkFW/Um/AS+alK+s1eVMxvg9nP4VOClj9wZtdFdYLr0rcnd6P6+cNQYXWDI8Xqr0B5wfm62v GrsKdLV+Ii/Y7U5CRB5/qD3s+uFjXreTh1+aEcPUP77p7JwKn6BvFRrRf7P4R/jWv3oB69DmF0k JIycUDKH8XOzO/1bspPn5tR/7HYPslmi1suwNZYrX8G+nvkY7gg== X-Google-Smtp-Source: AGHT+IGnDWjnc+JY/e8FpYxatx++zdArLxgorL0XDpUyAlykB6ujEX0Dc1VaymPoAXAQ8XLmnyjWtw== X-Received: by 2002:a05:6000:4310:b0:39e:e75b:5cc with SMTP id ffacd0b85a97d-3a06cf5490cmr1941012f8f.16.1745493845591; Thu, 24 Apr 2025 04:24:05 -0700 (PDT) Received: from pro2 (p200300e0b70e65008c33e61e626c43d3.dip0.t-ipconnect.de. [2003:e0:b70e:6500:8c33:e61e:626c:43d3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d54c313sm1784250f8f.92.2025.04.24.04.24.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 04:24:05 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <87cyd1alyl.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <CADwFkmmabgGhBFUFYeNuFUuJC575YZdA+PVaOh19Hnxj-A-1wQ@HIDDEN> <m27c3cesxb.fsf@HIDDEN> <jwvzfg8493r.fsf-monnier+emacs@HIDDEN> <m234e0xo35.fsf@HIDDEN> <m2frhzbi1y.fsf@HIDDEN> <861ptj10kb.fsf@HIDDEN> <m2zfg7nh42.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvecxiga9d.fsf-monnier+emacs@HIDDEN> <86msc6ywyx.fsf@HIDDEN> <m2ikmunmiq.fsf@HIDDEN> <86cyd2yp45.fsf@HIDDEN> <m2a586neq2.fsf@HIDDEN> <87frhxnbls.fsf@HIDDEN> <m2plh1naa7.fsf@HIDDEN> <87cyd1alyl.fsf@HIDDEN> Date: Thu, 24 Apr 2025 13:24:04 +0200 Message-ID: <m2ldrpn6p7.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Visuwesh <visuweshm@HIDDEN> writes: > [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE= =8F=E0=AE=AA=E0=AF=8D=E0=AE=B0=E0=AE=B2=E0=AF=8D 24, 2025] Gerd M=C3=B6llma= nn wrote: > >>>> Seems to have something to do with prog-mode, so maybe this depends on >>>> the test file being a C file, which might be interesting for Visuwesh. >>> >>> I commented out (elb-smie-mode) form in the above snippet and that >>> showed a backtrace which I could not explain. Replacing the form with >>> (text-mode) didn't help either. So I'm running the benchmark with that >>> form intact, even though the file I'm scrolling through is a text file. >>> I am running the benchmark currently, and will report the results once >>> they are done. >>> >>> Debugger entered--Lisp error: (overflow-error) >>> round(-0.0e+NaN) >>> (let ((squares (apply #'+ (mapcar #'(lambda (x) (expt x 2)) errs)))) >>> (round (/ (* 100 (sqrt squares)) elapsed))) >>> (format "|%2d%%\n" (let ((squares (apply #'+ (mapcar #'(lambda ... >>> ...) errs)))) (round (/ (* 100 (sqrt squares)) elapsed)))) >>> (insert (format "|%2d%%\n" (let ((squares (apply #'+ (mapcar #'... >>> errs)))) (round (/ (* 100 (sqrt squares)) elapsed))))) >>> (let* ((--cl-var-- tests) (test nil) (l nil) (test-elapsed nil) >>> (test-gcs nil) (test-gc-elapsed nil) (test-err nil) (elapsed 0) (gcs >>> 0) (gc-elapsed 0) (errs nil) (--cl-var-- t)) (while (consp --cl-var--) >>> (setq test (car --cl-var--)) (setq l (gethash test res)) (setq >>> test-elapsed (let* ((--cl-var-- l) (x nil) (--cl-var-- 0)) (while >>> (consp --cl-var--) (setq x (car --cl-var--)) (setq --cl-var-- (+ >>> --cl-var-- (car x))) (setq --cl-var-- (cdr --cl-var--))) --cl-var--)) >>> (setq test-gcs (let* ((--cl-var-- l) (x nil) (--cl-var-- 0)) (while >>> (consp --cl-var--) (setq x (car --cl-var--)) (setq --cl-var-- (+ >>> --cl-var-- (car ...))) (setq --cl-var-- (cdr --cl-var--))) >>> --cl-var--)) (setq test-gc-elapsed (let* ((--cl-var-- l) (x nil) >>> (--cl-var-- 0)) (while (consp --cl-var--) (setq x (car --cl-var--)) >>> (setq --cl-var-- (+ --cl-var-- (car ...))) (setq --cl-var-- (cdr >>> --cl-var--))) --cl-var--)) (setq test-err (if (cdr l) >>> (elb-std-deviation (mapcar #'car l)))) (insert (apply #'format >> >> Something went wrong when computing the "err" values, apparently. Maybe >> it'll work if you increase the number of runs the NaN goes away? > > Oddly enough, it throws an error as soon as I start the benchmark. I > don't think even a single iteration in the loop of elb-scroll-entry is > complete, let alone a complete run. Hm, I can't really get that to run really well either, but while trying I found that - it must be run with GUI emacs -Q because it tries to enlarge-window which it can't on a terminal, and it assumes certain sizes ("stipulated sizes not whatever" error) - the resources directory containing xmenu.c or whatever must be a sibling to the benchmarks directory - The pattern matching the test case doesn't seem to always work. I use ".*scroll.*" but the report at the end shows also "setq" and "font-lock"??? =20=20
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 11:30:11 +0000 Resent-Message-ID: <handler.77924.B77924.174549420513457 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Pip Cet <pipcet@HIDDEN> Cc: Helmut Eller <eller.helmut@HIDDEN>, Juri Linkov <juri@HIDDEN>, martin rudalics <rudalics@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, 77924 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, stefankangas@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174549420513457 (code B ref 77924); Thu, 24 Apr 2025 11:30:11 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 11:30:05 +0000 Received: from localhost ([127.0.0.1]:36829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7umF-0003UG-Jf for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 07:30:03 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:43171) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u7um7-0003TX-Em for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 07:29:55 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-43cf680d351so12481535e9.0 for <77924 <at> debbugs.gnu.org>; Thu, 24 Apr 2025 04:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745494185; x=1746098985; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cNlRiCP5XOBI5gMAOr0Cs0LUAKbP5j8q/XhQOMRrOv4=; b=JYVCjl6rDiLcCH4swB6mpFn+EdQFgoVRlveeuLRqWmsJ+q0Tq5W5CFM1zfcIMCW6Jp ndZ7CaFxf0yvVS1UdpmFoZ128/YyyPnMXWpdTjyMBC3h1i+Rct4geB4a+GdyGOoQCUIO 7DpOqCFgpGsc9AmL5NstYceNluITaVKH6eao8Hts5rXNornfgpmZpJhge4/UI368SctI IJ1fn8Vbth/WKNOUtI05VTRS1KYOZRlBS/BifAWTh54nXEF7sKWxnEyC1XcB02nxBwsY gBif++AHLaOMp2+QGZmygrCmzSgfFde3vGpeJf8vEs/gYKak4cFIJqifhg7pbmxwx80v c5Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745494185; x=1746098985; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cNlRiCP5XOBI5gMAOr0Cs0LUAKbP5j8q/XhQOMRrOv4=; b=W+ZXmfYKNxFlZOemur5zLTr26yNMFp5BCqHMXzXqguxQX56WYS3+MNl7/MMBdqSzMe CedMIHNU0exD7Po2LTG0VDANhs3QwuE8Qncm7wshLaUK3fcOfLSiome5GXDftUnl3RVo UVFMc79Kz3BaZmw0rTsXockNBB8mDxVL2yzZ7vz8AqnbYfbWUx5FBIK07xs8aH/ILVJr vLz2v3CIPlSPrunSsrrbf3I12bVzrLcbc0yMpnkzEwvacPy9ibFY3fputUW+ewNeDnhT 5sqdLCB90eV80tr/x5hYVbGOWp/I4UhMaq4nJayml+Xpj0YblrepIS+4FfESk67c8bSB MSNg== X-Forwarded-Encrypted: i=1; AJvYcCUVY5hSqtDTK1o5yTKpcYyWQkvyeSnyhyc1p3faNGHtY98Ea1LMwbi/AnZTkj7O1kvwbdNs9g==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxwgqUkzxKitbV2cCtqxsz4SxGfGaz0x278/RxPI4+Ww06KSTx6 wUsLu5oD8kqgf5Tn5JVPuJGRNSSaco6NBVo6+CI2XkgOKatMwkIw X-Gm-Gg: ASbGnctkoQdEW1h736pj8az8oWiyPqQ/gV9vISV4gGPACwCyc1mPMqFWn1d79xcobfI mViha3fVY8OrAET83dvpgCEMrp5x6Bz8xeqsd8OWq+Yr/lca+kFmt03c6hC2LB8h5xBMQ8oteFN 2b2YsLl+jmzyjWU2XKSciV3Boxl2AF2A2JcNyEBo9BK+jF7z6W70z2qBIU5jHTYjN1CJJVadd8R EQlMymcFebo2yHC/n09PADiO+kMGi31uR///VmqNKEOpOVDjLEyGYZsbUAX1ZwKA2W4bad8mm7A fmEhqFIOUdPB8/FOJbXK9YfnCsiNebH4l12Q9nvQ+Pc/U7JifxKm28+BOMR/lnyOICvaLKUxxtn dap+5QKNHUibX1NaInWNRsHM16pe2w3TcMJee1hdySzzEunTtQA== X-Google-Smtp-Source: AGHT+IFYuv7eyxY6dxTGGgoV3l9g784RF1jYmcILF/pOFECBVYSxHor1ahJ8YW7af7OpAjlabD0XPg== X-Received: by 2002:a7b:cb58:0:b0:43d:174:2668 with SMTP id 5b1f17b1804b1-4409c370359mr16012905e9.0.1745494184769; Thu, 24 Apr 2025 04:29:44 -0700 (PDT) Received: from pro2 (p200300e0b70e65008c33e61e626c43d3.dip0.t-ipconnect.de. [2003:e0:b70e:6500:8c33:e61e:626c:43d3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d2a2e43sm17629685e9.10.2025.04.24.04.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 04:29:44 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <87jz79q080.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvjz7agaos.fsf-monnier+emacs@HIDDEN> <0b0d5bf1-bf98-4f89-87d6-de7e8c5dc291@HIDDEN> <m25xitorg7.fsf@HIDDEN> <m21pthor3n.fsf@HIDDEN> <m2wmb9namq.fsf@HIDDEN> <87jz79q080.fsf@HIDDEN> Date: Thu, 24 Apr 2025 13:29:43 +0200 Message-ID: <m2h62dn6fs.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Pip Cet <pipcet@HIDDEN> writes: > Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > >> Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: >> >>> So, one could, theoretically store the charpos in a field of a marker >>> when "unchaining" it. Ugly, but doable. >> >> And one could do something practically, which I now pushed to savannah. > > Can you explain how that works in the non-indirect buffer case?=20=20 Yes, it doesn't :-). > AFAICT, we call marker_vector_reset but not marker_vector_remove in > that case, and there is no code in marker_vector_reset to remember the > last charpos. And the comment in marker_vector_reset sounds like it's > not called at all in the IGC case? You mean this: /* The old GC contains at least one assertion that unchaining markers in kill-buffer resets the markers' buffers. IGC does not do this, can't do this, and does not need it. */ What I meant there is what I described in my mistaken mail before, that it can't do anything with the markers. But if they are dead, who cares. CLassic thinko. I'll remove these comments. Thanks!
X-Loop: help-debbugs@HIDDEN Subject: bug#77924: 31.0.50; [Feature branch] Change marker implementation Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 24 Apr 2025 11:38:09 +0000 Resent-Message-ID: <handler.77924.B77924.174549465024031 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 77924 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Pip Cet <pipcet@HIDDEN> Cc: Helmut Eller <eller.helmut@HIDDEN>, Juri Linkov <juri@HIDDEN>, martin rudalics <rudalics@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, 77924 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, stefankangas@HIDDEN Received: via spool by 77924-submit <at> debbugs.gnu.org id=B77924.174549465024031 (code B ref 77924); Thu, 24 Apr 2025 11:38:09 +0000 Received: (at 77924) by debbugs.gnu.org; 24 Apr 2025 11:37:30 +0000 Received: from localhost ([127.0.0.1]:36848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7utT-0006Et-Er for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 07:37:29 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:46291) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1u7utJ-00069l-TF for 77924 <at> debbugs.gnu.org; Thu, 24 Apr 2025 07:37:23 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4394a823036so8773415e9.0 for <77924 <at> debbugs.gnu.org>; Thu, 24 Apr 2025 04:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745494631; x=1746099431; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4cxOzQiOZBM7/9a1EpurPKXaeYzJjI5pBQBA1FvogNI=; b=J+4tSneSQMU8RPHdAFbo47ZXS9q80k3Y1mrz7GoJ+3XoJSkf8xy8vQLqOOsSPLy3OG hM3CBPuQ6HsmIqMz+ptNA4EZZOX9jkBiyhL3as4g8C94HbtMCyMkPkCMlZ+xOCx2q1bY S388JeMYZQ2OiJqj4pH08XrTdEMplEKw1QtJyFG4gHkr9rX/YpZhZd09+UyHPyf6KySn yoAbfYmgW6cXBva8laUFBzjDh3AVGYNA5EoQlicULtXU3u35HReKhIV9zmcRV7QseJzZ S9aJIlgvmdeGaPRUYn8WBj4TV5oTtDC1ilbJkAKhQ56dzwbaAl45sMbinwNS7wAKnf5R mQ/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745494631; x=1746099431; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4cxOzQiOZBM7/9a1EpurPKXaeYzJjI5pBQBA1FvogNI=; b=NfuDYhTXewANJvMOujsDRAeP2lPrq3ZGtuBwmSXIeG9rnbFROcSUzoAR3xox7IAAsS 7iSBgizwkV3NkDa8S9/K+Q/HnXPRCwWoIBU0W3cHBb94cLETq0HbC3G68yOFus9jk6A3 5G76Isfz6OVno69NRwi6ru7PhiYPcUYkl20Yf+G+JsgdTCwGt5XyDeBTaEX9i11jWuc1 qe/f5bFnVThL4UdjC6pRuIpiGiTKHsbGSOO/vPFyHbaM614XMud4eN1IYqEpSeWhThBj DbnjsmgTQ9vqFKf+wdnvTTLtztG4jL1Gj4b0/HsWMyI4fVMXCXbNH2SMj92MMfLAqfh2 L7yw== X-Forwarded-Encrypted: i=1; AJvYcCVwU3eGjbW3x8iA81TnnEkaZUATUzyySt++dd/C6nIFwjdJxdkCGgfxfG3uD1luq91segLEug==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy3Z39fuS+3GEbiteeMuK3ouAEaejNQxspxTZaeHsaAC7Z+dmRS UOr5bGTit7v/haqud3uvrb1MYcKdyP2iwidgDIAJ2tiHjnal8S4v X-Gm-Gg: ASbGncu+SHR2p9KBqas4CkecuOoySvngOaOZQZLGS53V7/CL/nK4lGEuIQoVazRR4Bs 7DzPkYgUwncAJKqw7jStFdl3x9oh5eXute5yoK8q5rqiB+YvKWYLeN4aTe0Yvr0FdfztxH8MtvF +DV7KAR5Yu/JZVAEP9k/Uq+iU5TkvNdhm1o//+pMUlwNMkRiPC84nR8uNTnrsp4TB+uvWC/q9nP 8bIheUWUB3Z455YEv4Ryvf+WagD2oy07aU76e/ox5Npz0PUvzzGIqp5NrX2mZAMcwq7LKZlsymd yQUnPz3SDdfz/SWNqZUwdEXJkMNPE5j0J1qOuZ7HPhhJKo7D4XJ5fOcledLjbysgQLMz1FOMdHw PPpg21qBH7X7GGfxdrHUMeATfeTfRLD64BGSAqwrnqCBgmMIWJw== X-Google-Smtp-Source: AGHT+IEv4IJlPZFhYw0Tk/9Q6QvzSbl+4w+2E3d4tskJkEdLkr5o2eVLKzqC7AG9wNwlBkUxp6/RyA== X-Received: by 2002:a05:600c:1c8d:b0:43c:ed61:2c26 with SMTP id 5b1f17b1804b1-4409bd1f46cmr21483725e9.17.1745494631500; Thu, 24 Apr 2025 04:37:11 -0700 (PDT) Received: from pro2 (p200300e0b70e65008c33e61e626c43d3.dip0.t-ipconnect.de. [2003:e0:b70e:6500:8c33:e61e:626c:43d3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d2a1dc3sm17292185e9.13.2025.04.24.04.37.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 04:37:11 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <m2h62dn6fs.fsf@HIDDEN> References: <m2jz7gp25p.fsf@HIDDEN> <jwvmsc70wzm.fsf-monnier+emacs@HIDDEN> <86plh3ym7l.fsf@HIDDEN> <86o6wnylxf.fsf@HIDDEN> <jwvjz7agaos.fsf-monnier+emacs@HIDDEN> <0b0d5bf1-bf98-4f89-87d6-de7e8c5dc291@HIDDEN> <m25xitorg7.fsf@HIDDEN> <m21pthor3n.fsf@HIDDEN> <m2wmb9namq.fsf@HIDDEN> <87jz79q080.fsf@HIDDEN> <m2h62dn6fs.fsf@HIDDEN> Date: Thu, 24 Apr 2025 13:37:10 +0200 Message-ID: <m2cyd1n63d.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > I'll remove these comments. Show now be on savannah.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.