GNU logs - #77943, boring messages

Message sent to janneke@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#77943] [PATCH 0/2] Using the Shepherd's system log on the Hurd
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: janneke@HIDDEN, guix-patches@HIDDEN
Resent-Date: Sun, 20 Apr 2025 15:54:02 +0000
Resent-Message-ID: <handler.77943.B.17451643906498 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77943 <at> debbugs.gnu.org
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Yelninei <yelninei@HIDDEN>, Janneke Nieuwenhuizen <janneke@HIDDEN>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Date: Sun, 20 Apr 2025 17:52:37 +0200
Message-ID: <cover.1745163830.git.ludo@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello!

This changes the Hurd to use the Shepherd’s system log instead of
syslogd from Inetutils, as is already the case on Linux.  I wanted
to try now that Yelninei and I have addressed most of the issues
they reported in this area: <https://issues.guix.gnu.org/77634>.

It works, but maybe we should hold on a bit though, because of this:

--8<---------------cut here---------------start------------->8---
shepherd[1]: GNU Shepherd 1.0.4 (Guile 3.0.9, i586-pc-gnu)
shepherd[1]: Starting service root...
[…]
shepherd[1]: Service root-file-system running with value #t.
shepherd[1]: Service root-file-system has been started.
Uncaught exception in task:
In fibers.scm:
    172:8  7 (_)
In shepherd/service/system-log.scm:
    240:7  6 (run-system-log #<<channel> getq: #<atomic-box 33088d0?> ?)
In ice-9/suspendable-ports.scm:
   681:11  5 (read-delimited _ _ _)
    613:2  4 (read-char _)
   184:27  3 (fill-input #<input: /dev/klog 44> _ _)
     72:4  2 (read-bytes #<input: /dev/klog 44> #vu8(51 98 120 121 ?) ?)
In unknown file:
           1 (port-read #<input: /dev/klog 44> #vu8(51 98 120 121 ?) ?)
In ice-9/boot-9.scm:
  1685:16  0 (raise-exception _ #:continuable? _)
ice-9/boot-9.scm:1685:16: In procedure raise-exception:
In procedure fport_read: (os/device) operation would block
--8<---------------cut here---------------end--------------->8---

It’s non-fatal but I think everything going to /dev/log after that
is dismissed—IOW, the system log doesn’t log anything.  There’s also
the "\0" sender that appears in /var/log/messages: it works, but it’s
not nice.

I reported it on bug-hurd and hopefully it has an easy solution.

Ludovic Courtès (2):
  services: shepherd: Provide the right #:kernel-log-file on the Hurd.
  system: hurd: Switch to the Shepherd’s system log.

 gnu/services/shepherd.scm | 9 +++++++++
 gnu/system/hurd.scm       | 4 ++--
 2 files changed, 11 insertions(+), 2 deletions(-)


base-commit: d14663b94a7428eccbfa27aa620dc3d8ba67d752
-- 
2.49.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: bug#77943: Acknowledgement ([PATCH 0/2] Using the Shepherd's
 system log on the Hurd)
Message-ID: <handler.77943.B.17451643906498.ack <at> debbugs.gnu.org>
References: <cover.1745163830.git.ludo@HIDDEN>
X-Gnu-PR-Message: ack 77943
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 77943 <at> debbugs.gnu.org
Date: Sun, 20 Apr 2025 15:54:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Janneke Nieuwenhuizen <janneke@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 77943 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
77943: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77943
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#77943] [PATCH 1/2] services: shepherd: Provide the right #:kernel-log-file on the Hurd.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 20 Apr 2025 15:56:04 +0000
Resent-Message-ID: <handler.77943.B77943.17451645107225 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77943 <at> debbugs.gnu.org
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Yelninei <yelninei@HIDDEN>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Date: Sun, 20 Apr 2025 17:54:46 +0200
Message-ID: <ee2ded1a592d8f91595c26c08f6f9f047d74b4f2.1745163830.git.ludo@HIDDEN>
In-Reply-To: <cover.1745163830.git.ludo@HIDDEN>
References: <cover.1745163830.git.ludo@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

* gnu/services/shepherd.scm (shepherd-system-log-service-type):
Pass #:kernel-log-file.

Reported-by: Yelninei <yelninei@HIDDEN>
Change-Id: I6f7a4b4e8e69a116069886e3879400d600645b30
---
 gnu/services/shepherd.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/services/shepherd.scm b/gnu/services/shepherd.scm
index c8e01c9d83..156a36c2da 100644
--- a/gnu/services/shepherd.scm
+++ b/gnu/services/shepherd.scm
@@ -781,6 +781,15 @@ (define shepherd-system-log-service-type
                                     (#f #~())
                                     (value #~(#:message-destination #$value)))

+                               ;; The Shepherd <= 1.0.4 chooses /proc/kmsg
+                               ;; unconditionally.  Fix that.
+                               #:kernel-log-file
+                               (cond ((string-contains %host-type "linux") ;Linux
+                                      "/proc/kmsg")
+                                     ((string-suffix? "-gnu" %host-type) ;GNU/Hurd
+                                      "/dev/klog")
+                                     (else #f))
+
                                #:date-format #$date-format
                                #:history-size #$history-size
                                #:max-silent-time #$max-silent-time)))))
-- 
2.49.0

Message sent to janneke@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#77943] [PATCH 2/2] system: hurd: Switch to the =?UTF-8?Q?Shepherd=E2=80=99s?= system log.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: janneke@HIDDEN, guix-patches@HIDDEN
Resent-Date: Sun, 20 Apr 2025 15:56:05 +0000
Resent-Message-ID: <handler.77943.B77943.17451645377717 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77943 <at> debbugs.gnu.org
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Janneke Nieuwenhuizen <janneke@HIDDEN>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Date: Sun, 20 Apr 2025 17:54:47 +0200
Message-ID: <061859f87aa8adc79b408425fe1f92f8c2118d3f.1745163830.git.ludo@HIDDEN>
In-Reply-To: <cover.1745163830.git.ludo@HIDDEN>
References: <cover.1745163830.git.ludo@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

This is a followup to 8492a3c8962664db4bd0e7475f63be0ef59db87a.

* gnu/system/hurd.scm (%base-services/hurd): Replace
‘syslog-service-type’ by ‘shepherd-system-log-service-type’.

Change-Id: I3e12087a04f06210bd10b649b29fcf9949c5aa35
---
 gnu/system/hurd.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/system/hurd.scm b/gnu/system/hurd.scm
index c9df366f24..96b6a9a290 100644
--- a/gnu/system/hurd.scm
+++ b/gnu/system/hurd.scm
@@ -1,5 +1,5 @@
 ;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2020-2024 Ludovic Courtès <ludo@HIDDEN>
+;;; Copyright © 2020-2025 Ludovic Courtès <ludo@HIDDEN>
 ;;; Copyright © 2020, 2023, 2024 Janneke Nieuwenhuizen <janneke@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -100,7 +100,7 @@ (define %base-services/hurd
                          `(("/bin/sh" ,(file-append bash "/bin/sh"))
                            ("/usr/bin/env" ,(file-append coreutils
                                                          "/bin/env"))))
-                (service syslog-service-type))
+                (service shepherd-system-log-service-type))
           (map (lambda (n)
                  (service hurd-getty-service-type
                           (hurd-getty-configuration
-- 
2.49.0

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#77943] [PATCH 1/2] services: shepherd: Provide the right #:kernel-log-file on the Hurd.
Resent-From: yelninei@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 02 Jun 2025 14:36:02 +0000
Resent-Message-ID: <handler.77943.B77943.174887495430356 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: 77943 <77943 <at> debbugs.gnu.org>
Received: via spool by 77943-submit <at> debbugs.gnu.org id=B77943.174887495430356
          (code B ref 77943); Mon, 02 Jun 2025 14:36:02 +0000
Received: (at 77943) by debbugs.gnu.org; 2 Jun 2025 14:35:54 +0000
Received: from localhost ([127.0.0.1]:52539 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uM6GX-0007tV-Di
	for submit <at> debbugs.gnu.org; Mon, 02 Jun 2025 10:35:53 -0400
Received: from mail.w13.tutanota.de ([185.205.69.213]:53374)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <yelninei@HIDDEN>)
 id 1uM6GU-0007sq-EK
 for 77943 <at> debbugs.gnu.org; Mon, 02 Jun 2025 10:35:51 -0400
Received: from tutadb.w10.tutanota.de (w10.api.tuta.com [IPv6:fd:ac::d:10])
 by mail.w13.tutanota.de (Postfix) with ESMTP id 12811905D69F
 for <77943 <at> debbugs.gnu.org>; Mon,  2 Jun 2025 16:35:43 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1748874942; 
 s=s1; d=tutamail.com;
 h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender;
 bh=H28s7tiFQf8Ir3ONW7pKd8arlPzcUZcDQOh6ql+zgAA=;
 b=ea7S0pVAzL0dY081OHcnvaNRMyIxSWGr0ck3mGBrbraR7E9hfbtF5M1CjNiR3tBg
 wllh52aPAj3rrS5onBERIAztuyTnrfbEf9fUbybMCl3MnINKdF3EGFpWMMD7zlDJ2x/
 9mC95lExSZyjN/jzBukOu30uNyTJdnw4SOmpi0XLzfClcKzLspsxwmBv8e7KAv+AN8S
 3A4yHVHnl30oKfU2r9PbwijkxW3GVyx4uYQntO7s6+mjh6kQnNWpotHazgk8ay+rTcw
 jzdMCHpyHj5ifhaHcehqB/csyf6F1lreXet994Hboao9MkSYRdEZi9qTOtJWSUQkqa4
 kS07I0rr/A==
Date: Mon, 2 Jun 2025 16:35:42 +0200 (CEST)
From: yelninei@HIDDEN
Message-ID: <OPRqyKU--F-9@HIDDEN>
In-Reply-To: <ee2ded1a592d8f91595c26c08f6f9f047d74b4f2.1745163830.git.ludo@HIDDEN>
References: <cover.1745163830.git.ludo@HIDDEN>
 <ee2ded1a592d8f91595c26c08f6f9f047d74b4f2.1745163830.git.ludo@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hi Ludo,

I am a bit late to this:

Does it still make sense to duplicate the default kernel-log-file in guix a=
nd shepherd now that 1.0.5 is available?

The issue with=C2=A0ED_WOULD_BLOCK is still present on hurd-0.9.git20250420=
 on core-packages-team.=C2=A0
I tried it for a while with #:kernel-log-file set to #f and it felt like it=
 was slowing down shepherd significantly enough to be mildly annoying but i=
dk if this is something I only noticed because I was actively looking for c=
hanges.


Apr 20, 2025, 15:54 by ludo@HIDDEN:

> * gnu/services/shepherd.scm (shepherd-system-log-service-type):
> Pass #:kernel-log-file.
>
> Reported-by: Yelninei <yelninei@HIDDEN>
> Change-Id: I6f7a4b4e8e69a116069886e3879400d600645b30
> ---
> gnu/services/shepherd.scm | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/gnu/services/shepherd.scm b/gnu/services/shepherd.scm
> index c8e01c9d83..156a36c2da 100644
> --- a/gnu/services/shepherd.scm
> +++ b/gnu/services/shepherd.scm
> @@ -781,6 +781,15 @@ (define shepherd-system-log-service-type
> (#f #~())
> (value #~(#:message-destination #$value)))
>
> +                               ;; The Shepherd <=3D 1.0.4 chooses /proc/=
kmsg
> +                               ;; unconditionally.  Fix that.
> +                               #:kernel-log-file
> +                               (cond ((string-contains %host-type "linux=
") ;Linux
> +                                      "/proc/kmsg")
> +                                     ((string-suffix? "-gnu" %host-type)=
 ;GNU/Hurd
> +                                      "/dev/klog")
> +                                     (else #f))
> +
> #:date-format #$date-format
> #:history-size #$history-size
> #:max-silent-time #$max-silent-time)))))
> --
> 2.49.0
>

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#77943] [PATCH 1/2] services: shepherd: Provide the right #:kernel-log-file on the Hurd.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 02 Jun 2025 16:10:03 +0000
Resent-Message-ID: <handler.77943.B77943.174888060125031 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: yelninei@HIDDEN
Cc: 77943 <77943 <at> debbugs.gnu.org>
Received: via spool by 77943-submit <at> debbugs.gnu.org id=B77943.174888060125031
          (code B ref 77943); Mon, 02 Jun 2025 16:10:03 +0000
Received: (at 77943) by debbugs.gnu.org; 2 Jun 2025 16:10:01 +0000
Received: from localhost ([127.0.0.1]:53342 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uM7jc-0006VX-1S
	for submit <at> debbugs.gnu.org; Mon, 02 Jun 2025 12:10:00 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:49406)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1uM7jZ-0006VC-Iz
 for 77943 <at> debbugs.gnu.org; Mon, 02 Jun 2025 12:09:58 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1uM7jT-0006pP-Hy; Mon, 02 Jun 2025 12:09:51 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=jLwOCbjSdYvZfajpIB8WHDUXe9PpsZ7mdNoofNLxfho=; b=I+IRSbYUzDME45Yz5xgX
 PEzNAi9njMD+y8UqeImWY5wWCagFcL9HjnrUe1bXtCWF2C36BsakC/7KJHuKnqr/VpSgwUZ9mq5O8
 E9vN6o/tLiRhJPIGPph4NeGQQHDObYz7Tpd1Kd1is1b034HaGDtPj+EBK6bn0mSlbiNrirlxqnzge
 hfDgmxsRKRKFlG2Gmi1V8dFj+SfEeF9MmMR2eUfb27I6B8PeF4zTVHzAA2oyn2vfui6ed3SSF8nkA
 Opsuh0SpKLG9aKextiHMKpJs9nqiaDlAmU34EUBcihRAprDURxuaLJoFCegoQgcOXw5s6ukmwfKfP
 IXCzGOlGT8e+Rg==;
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
In-Reply-To: <OPRqyKU--F-9@HIDDEN> (yelninei@HIDDEN's message of
 "Mon, 2 Jun 2025 16:35:42 +0200 (CEST)")
References: <cover.1745163830.git.ludo@HIDDEN>
 <ee2ded1a592d8f91595c26c08f6f9f047d74b4f2.1745163830.git.ludo@HIDDEN>
 <OPRqyKU--F-9@HIDDEN>
User-Agent: mu4e 1.12.11; emacs 29.4
X-URL: https://people.bordeaux.inria.fr/lcourtes/
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
X-Revolutionary-Date: Quartidi 14 Prairial an 233 de la =?UTF-8?Q?R=C3=A9volution,?= jour de l'Acacia
Date: Mon, 02 Jun 2025 17:01:37 +0200
Message-ID: <87cybmp4q6.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

yelninei@HIDDEN writes:

> Does it still make sense to duplicate the default kernel-log-file in guix=
 and shepherd now that 1.0.5 is available?

No, it=E2=80=99s no longer necessary.

> The issue with=C2=A0ED_WOULD_BLOCK is still present on hurd-0.9.git202504=
20 on core-packages-team.=C2=A0

Right, I started looking into it back then but then didn=E2=80=99t take the=
 time
to track it down.

> I tried it for a while with #:kernel-log-file set to #f and it felt
> like it was slowing down shepherd significantly enough to be mildly
> annoying but idk if this is something I only noticed because I was
> actively looking for changes.

How did you notice that it was slowing down?  That was with 1.0.5,
right?

Thanks,
Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#77943] [PATCH 1/2] services: shepherd: Provide the right #:kernel-log-file on the Hurd.
Resent-From: yelninei@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 02 Jun 2025 20:03:02 +0000
Resent-Message-ID: <handler.77943.B77943.174889456130799 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: 77943 <77943 <at> debbugs.gnu.org>
Received: via spool by 77943-submit <at> debbugs.gnu.org id=B77943.174889456130799
          (code B ref 77943); Mon, 02 Jun 2025 20:03:02 +0000
Received: (at 77943) by debbugs.gnu.org; 2 Jun 2025 20:02:41 +0000
Received: from localhost ([127.0.0.1]:55445 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uMBMn-00080g-Au
	for submit <at> debbugs.gnu.org; Mon, 02 Jun 2025 16:02:41 -0400
Received: from mail.w13.tutanota.de ([185.205.69.213]:34532)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <yelninei@HIDDEN>)
 id 1uMBMj-000809-UU
 for 77943 <at> debbugs.gnu.org; Mon, 02 Jun 2025 16:02:38 -0400
Received: from tutadb.w10.tutanota.de (w10.api.tuta.com [IPv6:fd:ac::d:10])
 by mail.w13.tutanota.de (Postfix) with ESMTP id D522490859D7
 for <77943 <at> debbugs.gnu.org>; Mon,  2 Jun 2025 22:02:01 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1748894521; 
 s=s1; d=tutamail.com;
 h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender;
 bh=rBfmXgQO3iGgf5ltKdi9RNdo2KGVtTJTTC91UaWOqkU=;
 b=iVawMyPEf+Y1/6K5KzecRAEN+aRCk8uib3WdJZsSzP6PlQkN6vhS1auhJXdlOojN
 JOEV95ePrsoyv+A6bPIVm+k4oyvtl3IU2imlotkMlG/vg70KBoBT0WjpCG5oG+gj00D
 cBa+8vGeZl8c2WWdueDPeLrI3d5UFo5+IVomQSC2BIbKEBdaSm4+iNN+mEq3jvciDzZ
 /fo6X+9qm0j0FYMA7njbfaWc4hwTIpTA0iImlJhpM1AxBs8Qu/wHOKPOd0rDSsfFO7K
 XjS7FqnNHxlGXcitLa6Fuh9AWbgU+phJLwiRQY5gsPH9f2LCiNlw+2wubm6b/cg94vK
 5NoY2TdY1g==
Date: Mon, 2 Jun 2025 22:02:01 +0200 (CEST)
From: yelninei@HIDDEN
Message-ID: <ORmE8ZQ--F-9@HIDDEN>
In-Reply-To: <87cybmp4q6.fsf@HIDDEN>
References: <cover.1745163830.git.ludo@HIDDEN>
 <ee2ded1a592d8f91595c26c08f6f9f047d74b4f2.1745163830.git.ludo@HIDDEN>
 <OPRqyKU--F-9@HIDDEN> <87cybmp4q6.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hello,

Jun 2, 2025, 16:09 by ludo@HIDDEN:

> The issue with=C2=A0ED_WOULD_BLOCK is still present on hurd-0.9.git202504=
20 on core-packages-team.=C2=A0
>
> Right, I started looking into it back then but then didn=E2=80=99t take t=
he time
> to track it down.
>
>> I tried it for a while with #:kernel-log-file set to #f and it felt
>> like it was slowing down shepherd significantly enough to be mildly
>> annoying but idk if this is something I only noticed because I was
>> actively looking for changes.
>>
>
> How did you notice that it was slowing down?  That was with 1.0.5,
> right?
>

I dont know if I am just imagining this but anything ssh related felt a bit=
 laggy but idk how the syslog should cause this except that sshd logs to sy=
slog and shepherd is also managing the sshd socket.

 Also things like herd status felt a lot slower.

But all of this was not really consistent and I dont know if I am just maki=
ng this up so this might be all wrong.
No this was all with 1.0.4, tested this on master around when you sent the =
initial version. And on core-packages-team shepherd is still 1.0.4.

> Thanks,
> Ludo=E2=80=99.
>

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#77943] [PATCH 1/2] services: shepherd: Provide the right #:kernel-log-file on the Hurd.
Resent-From: yelninei@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 10 Jun 2025 09:52:03 +0000
Resent-Message-ID: <handler.77943.B77943.174954906913241 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: 77943 <77943 <at> debbugs.gnu.org>
Received: via spool by 77943-submit <at> debbugs.gnu.org id=B77943.174954906913241
          (code B ref 77943); Tue, 10 Jun 2025 09:52:03 +0000
Received: (at 77943) by debbugs.gnu.org; 10 Jun 2025 09:51:09 +0000
Received: from localhost ([127.0.0.1]:34548 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uOvdM-0003RL-Ax
	for submit <at> debbugs.gnu.org; Tue, 10 Jun 2025 05:51:09 -0400
Received: from mail.w13.tutanota.de ([185.205.69.213]:34432)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <yelninei@HIDDEN>)
 id 1uOvdI-0003Pi-4j
 for 77943 <at> debbugs.gnu.org; Tue, 10 Jun 2025 05:51:05 -0400
Received: from tutadb.w10.tutanota.de (w10.api.tuta.com [IPv6:fd:ac::d:10])
 by mail.w13.tutanota.de (Postfix) with ESMTP id 8E3C6940B9F2
 for <77943 <at> debbugs.gnu.org>; Tue, 10 Jun 2025 11:50:27 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1749549027; 
 s=s1; d=tutamail.com;
 h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender;
 bh=t+F5Gh0Itpit7mozM3Y5Bh0csM5kOHMxARoOg+djmGk=;
 b=SFdbj5YZw49AshILKWBF05VwBtCnlgktAmRrNm+IYLzGltmKCOZg8bGwvu2EW0JK
 Ee4+cFkNnWlTJS+Ks02+ozCSHkA9bDFMwZvQ8cUwlQD0g5s0N907V+uT0+PxVkxu/LZ
 xjHHIjA5vYpP/IcXCvDkeRUQXwNv3ULg8ye4PJV0ePDKq/QF1JBXzaZ63HIHyoPnv+o
 v4JLXHqIt3PvY0QfuClLU3Ht/ys9jK0i5TnTHG8hl+nmhp8bfULiqg+4YGtxx8HUQqH
 fJBGHK9TFZGWXWYY9/om/smvZgo6TdlUzd7ecPaPbUvwED9wwFC4gbOENCpUYM7SujQ
 wNQLz55/8Q==
Date: Tue, 10 Jun 2025 11:50:27 +0200 (CEST)
From: yelninei@HIDDEN
Message-ID: <OSK14Qd--F-9@HIDDEN>
In-Reply-To: <87cybmp4q6.fsf@HIDDEN>
References: <cover.1745163830.git.ludo@HIDDEN>
 <ee2ded1a592d8f91595c26c08f6f9f047d74b4f2.1745163830.git.ludo@HIDDEN>
 <OPRqyKU--F-9@HIDDEN> <87cybmp4q6.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hello Ludo,


Jun 2, 2025, 16:09 by ludo@HIDDEN:

> Hi,
>
> Right, I started looking into it back then but then didn=E2=80=99t take t=
he time
> to track it down.
>

I tried your patch that you sent to bug-hurd but I still end up with D_WOUL=
D_BLOCK at the end. Was it working for you?

As pointed out by Samuel on bug-hurd the initial "if (err) return err" look=
s weird. I tried removing it and at the end of /dev/klog it died with SIGLO=
ST.

I then tried this patch similar to yours to intercept D_WOULD_BLOCK at the =
beginning instead:

diff --git a/trans/streamio.c b/trans/streamio.c
index e42ff908..ee3cf9b4 100644
--- a/trans/streamio.c
+++ b/trans/streamio.c
@@ -1005,7 +1005,12 @@ dev_read (size_t amount, void **buf, size_t *len, in=
t nowait)
=C2=A0=C2=A0 size_t max, avail;
=C2=A0
=C2=A0=C2=A0 if (err)
-=C2=A0=C2=A0=C2=A0 return err;
+=C2=A0=C2=A0=C2=A0 {
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (err =3D=3D D_WOULD_BLOCK)
+=09=C2=A0 return EWOULDBLOCK;
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else
+=09=C2=A0 return err;
+=C2=A0=C2=A0=C2=A0 }
=C2=A0
=C2=A0=C2=A0 while (!buffer_readable (input_buffer))
=C2=A0=C2=A0=C2=A0=C2=A0 {

and my example now fails with EAGAIN.

I am not sure yet what is setting this, the joy of global variables.

However something still seems wrong when I added back the shepherd syslog. =
It still crashes/hangs when it reaches the initial end of /dev/klog and doe=
s not process messages further:=20
there is an extra message and e.g. sshd messages to the syslog dont get pro=
cessed.

root@childhurd ~# ./main
irq handler [11]: new delivery port f5e44038 entry f4f39840

errno: Resource temporarily unavailable

To be continued.

Note: I had to add the patch to the default hurd and just patching the hurd=
 package that is used in operating-system-hurd was not enough. Dont know wh=
at is up with that.

> Thanks,
> Ludo=E2=80=99.
>

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#77943] [PATCH 1/2] services: shepherd: Provide the right #:kernel-log-file on the Hurd.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 10 Jun 2025 12:56:02 +0000
Resent-Message-ID: <handler.77943.B77943.174956015023064 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: yelninei@HIDDEN
Cc: 77943 <77943 <at> debbugs.gnu.org>
Received: via spool by 77943-submit <at> debbugs.gnu.org id=B77943.174956015023064
          (code B ref 77943); Tue, 10 Jun 2025 12:56:02 +0000
Received: (at 77943) by debbugs.gnu.org; 10 Jun 2025 12:55:50 +0000
Received: from localhost ([127.0.0.1]:37232 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uOyW6-0005zv-13
	for submit <at> debbugs.gnu.org; Tue, 10 Jun 2025 08:55:50 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:40994)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1uOyW2-0005ze-8B
 for 77943 <at> debbugs.gnu.org; Tue, 10 Jun 2025 08:55:47 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1uOyVw-0002Ty-Gm; Tue, 10 Jun 2025 08:55:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=z94Tz2ckCvskd3zFiXgdDyOASkA4fVkx9pLQXdX73JU=; b=NkdBPAwZD63rMmEW7CP2
 mmUTxEg7vz6xnE0wcy1X3Wdh/eWvp8NlKK38pzmunAlKTLPg7XG7GMq2J18IOSovc/NfS0BgzOgw0
 B8tDckhoNTrHQGJ8KuUCHfItpGJmnwXwfEXKnlNZVHpE2Q+K+6979icfGFmStVjf45HFGgLk0JOQ0
 NcexMTipzyCUw1RdElOOQJ3Ao1HLSu388Gscu9GSMc5xTfqf+5SmvFbfQoA18S3B+b8kDuEVIFfCx
 ht8a3w3kk3jpvSMaQ8ryctW7mDTLCUc69pGRycB5GFseSaIbXMF3AADmm3igeVleFcnsPoufmu7ck
 9GFiQlZKrsT10w==;
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
In-Reply-To: <OSK14Qd--F-9@HIDDEN> (yelninei@HIDDEN's message of
 "Tue, 10 Jun 2025 11:50:27 +0200 (CEST)")
References: <cover.1745163830.git.ludo@HIDDEN>
 <ee2ded1a592d8f91595c26c08f6f9f047d74b4f2.1745163830.git.ludo@HIDDEN>
 <OPRqyKU--F-9@HIDDEN> <87cybmp4q6.fsf@HIDDEN>
 <OSK14Qd--F-9@HIDDEN>
User-Agent: mu4e 1.12.11; emacs 29.4
X-URL: https://people.bordeaux.inria.fr/lcourtes/
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
X-Revolutionary-Date: Duodi 22 Prairial an 233 de la =?UTF-8?Q?R=C3=A9volution,?= jour de la Camomille
Date: Tue, 10 Jun 2025 14:46:44 +0200
Message-ID: <87frg7kbm3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi Yelninei,

yelninei@HIDDEN writes:

> I tried your patch that you sent to bug-hurd but I still end up with D_WO=
ULD_BLOCK at the end. Was it working for you?

No no, it wasn=E2=80=99t, but I haven=E2=80=99t taken the time to dig furth=
er.

> As pointed out by Samuel on bug-hurd the initial "if (err) return err" lo=
oks weird. I tried removing it and at the end of /dev/klog it died with SIG=
LOST.

[...]

> and my example now fails with EAGAIN.

I=E2=80=99m not sure what example but EAGAIN is fine, it=E2=80=99s what we =
want.

Thanks for investigating!

Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#77943] [PATCH 1/2] services: shepherd: Provide the right #:kernel-log-file on the Hurd.
Resent-From: yelninei@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 10 Jun 2025 14:57:04 +0000
Resent-Message-ID: <handler.77943.B77943.174956741031367 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: 77943 <77943 <at> debbugs.gnu.org>
Received: via spool by 77943-submit <at> debbugs.gnu.org id=B77943.174956741031367
          (code B ref 77943); Tue, 10 Jun 2025 14:57:04 +0000
Received: (at 77943) by debbugs.gnu.org; 10 Jun 2025 14:56:50 +0000
Received: from localhost ([127.0.0.1]:39103 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uP0PA-00089Z-1E
	for submit <at> debbugs.gnu.org; Tue, 10 Jun 2025 10:56:49 -0400
Received: from mail.w13.tutanota.de ([185.205.69.213]:51802)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <yelninei@HIDDEN>)
 id 1uP0P7-000884-2i
 for 77943 <at> debbugs.gnu.org; Tue, 10 Jun 2025 10:56:45 -0400
Received: from tutadb.w10.tutanota.de (w10.api.tuta.com [IPv6:fd:ac::d:10])
 by mail.w13.tutanota.de (Postfix) with ESMTP id 17480943099E
 for <77943 <at> debbugs.gnu.org>; Tue, 10 Jun 2025 16:56:39 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1749567398; 
 s=s1; d=tutamail.com;
 h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender;
 bh=7MIMsKjkZxHUFjPhSFT+2Rrc18jRYl1XpkcHtQrOhCA=;
 b=z8JIIXea0WLaUFP2MzKKSrb1K/fOMRQC4NU+4PVzdWSSrOBJVUN1ph4iTCi0e3Jo
 JRN6ArzHhTW7siL9FmB3ZjigC8MdHadxbrAJmVi2xsQ3B51+IyjwZz9x4JcmXftPqSg
 QPi6U4NdQi+vEYFJEG63VWN++P0w7utGT5Qcy22nbytCddFl29ufeT58oXZ83jIyD7z
 RRGK1OMbilubVY4a0vRVi6j8hJLP6NhXUzAIbSnHAfLYkzaBU0U/uRdaVhuRI0y/pvE
 krrNGgMkN/8lgmODlXf+cWQP4TLDCN7h2MPNC05fLhGzC0/HLCuPAWSe7I3oAbmgAUe
 +OFIscufVg==
Date: Tue, 10 Jun 2025 16:56:38 +0200 (GMT+02:00)
From: yelninei@HIDDEN
Message-ID: <OSPKyE1--F-9@HIDDEN>
In-Reply-To: <87frg7kbm3.fsf@HIDDEN>
References: <cover.1745163830.git.ludo@HIDDEN>
 <ee2ded1a592d8f91595c26c08f6f9f047d74b4f2.1745163830.git.ludo@HIDDEN>
 <OPRqyKU--F-9@HIDDEN> <87cybmp4q6.fsf@HIDDEN>
 <OSK14Qd--F-9@HIDDEN> <87frg7kbm3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hello,


Jun 10, 2025, 12:55 by ludo@HIDDEN:

> Hi Yelninei,
>
> yelninei@HIDDEN writes:
>
>> I tried your patch that you sent to bug-hurd but I still end up with D_W=
OULD_BLOCK at the end. Was it working for you?
>>
>
> No no, it wasn=E2=80=99t, but I haven=E2=80=99t taken the time to dig fur=
ther.
>
>> As pointed out by Samuel on bug-hurd the initial "if (err) return err" l=
ooks weird. I tried removing it and at the end of /dev/klog it died with SI=
GLOST.
>>
>
> [...]
>
>> and my example now fails with EAGAIN.
>>
>
> I=E2=80=99m not sure what example but EAGAIN is fine, it=E2=80=99s what w=
e want.
>

The example is just some terrible C code that runs fgets in a loop.

When I try something similar with guile and (@ (ice-9 rdelim) read-line) it=
 seems to block forever at the "last" line.
=C2=A0From the C example that last line seems to be missing a terminating n=
ewline and I am thinking read-line cannot handle this situation when the de=
liminator is just EAGAIN so the port is never handed of to fibers (fport_re=
ad which was erroring before seems to return -1=C2=A0 in this case as a ssi=
ze_t cast to size_t which also seems wrong ).

Further investigation required.
> Thanks for investigating!
>
> Ludo=E2=80=99.
>
Yelninei

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#77943] [PATCH 1/2] services: shepherd: Provide the right #:kernel-log-file on the Hurd.
Resent-From: yelninei@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 02 Aug 2025 14:02:01 +0000
Resent-Message-ID: <handler.77943.B77943.17541432989505 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: 77943 <77943 <at> debbugs.gnu.org>
Received: via spool by 77943-submit <at> debbugs.gnu.org id=B77943.17541432989505
          (code B ref 77943); Sat, 02 Aug 2025 14:02:01 +0000
Received: (at 77943) by debbugs.gnu.org; 2 Aug 2025 14:01:38 +0000
Received: from localhost ([127.0.0.1]:36738 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uiCnp-0002TF-Kg
	for submit <at> debbugs.gnu.org; Sat, 02 Aug 2025 10:01:37 -0400
Received: from mail.w13.tutanota.de ([185.205.69.213]:57750)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <yelninei@HIDDEN>)
 id 1uiCnn-0002Pj-DM
 for 77943 <at> debbugs.gnu.org; Sat, 02 Aug 2025 10:01:35 -0400
Received: from tutadb.w10.tutanota.de (w10.api.tuta.com [IPv6:fd:ac::d:10])
 by mail.w13.tutanota.de (Postfix) with ESMTP id E3A75ACD6025
 for <77943 <at> debbugs.gnu.org>; Sat,  2 Aug 2025 16:00:58 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1754143258; 
 s=s1; d=tutamail.com;
 h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender;
 bh=64jImghiStaiXcakDitJ03SAC3I04Ff1r4CMCc1H/3E=;
 b=CpjVoxfonoriIb9u1LW6AGxCHhKBodSUcJ+/XrLnQYzMPgdWk7RSWGriL4f62B+G
 /yqbXp/PCsXXaHFnCY0RN8xJsXlKucWOd7clBx0EXKtugJdlhWh7Mj6Dwn8ugCPRgKw
 UzcPSkyMBIMwhYb8LSZXi5ErjSTpCkd04XmzXCL71jPO3fRmTUBuJf0HwdGmcM15WbM
 Lv3vzUasYuOezSWvGrrhSbaOQvDmEBpuRdxv5z0sPoHnBQnEIMgKgGo23px9C2uflPU
 uunY5N3TxtUXzxbVvIgWat9umTiL1E3gkcfkCKGGJ18KMhS+z46hfMoilZFzHRhO6zV
 mWayLhl9Sg==
Date: Sat, 2 Aug 2025 16:00:58 +0200 (CEST)
From: yelninei@HIDDEN
Message-ID: <OWf4UUz--F-9@HIDDEN>
In-Reply-To: <OSPKyE1--F-9@HIDDEN>
References: <cover.1745163830.git.ludo@HIDDEN>
 <ee2ded1a592d8f91595c26c08f6f9f047d74b4f2.1745163830.git.ludo@HIDDEN>
 <OPRqyKU--F-9@HIDDEN> <87cybmp4q6.fsf@HIDDEN>
 <OSK14Qd--F-9@HIDDEN> <87frg7kbm3.fsf@HIDDEN>
 <OSPKyE1--F-9@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hi Ludo,

I found where the error gets set (debugging global variables is not fun)

As a reminder we get the D_WOULD_BLOCK error back from the initial=20

if(err)
=C2=A0 =C2=A0 return err;
check in dev_read.

In our case this comes from device_read_reply_inband from the errorcode par=
ameter. I am not yet sure where/how this gets called.

My little C example now returns EWOULDBLOCK when reaching the "end" of /dev=
/klog.

However this does not really help the shepherd syslog because guile's read-=
line blocks forever waiting for a terminating newline. Also guile is unawar=
e that further attempts to read would EWOULDBLOCK as "(select (vector port)=
 #() #() 0)" indicates that reading is possible but then actually trying to=
 a get a char blocks.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#77943] [PATCH 1/2] services: shepherd: Provide the right #:kernel-log-file on the Hurd.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 17 Aug 2025 15:21:01 +0000
Resent-Message-ID: <handler.77943.B77943.175544400328912 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: yelninei@HIDDEN
Cc: 77943 <77943 <at> debbugs.gnu.org>
Received: via spool by 77943-submit <at> debbugs.gnu.org id=B77943.175544400328912
          (code B ref 77943); Sun, 17 Aug 2025 15:21:01 +0000
Received: (at 77943) by debbugs.gnu.org; 17 Aug 2025 15:20:03 +0000
Received: from localhost ([127.0.0.1]:47180 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1unfAw-0007WD-S7
	for submit <at> debbugs.gnu.org; Sun, 17 Aug 2025 11:20:03 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:48346)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1unfAt-0007VY-7O
 for 77943 <at> debbugs.gnu.org; Sun, 17 Aug 2025 11:20:00 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1unfAn-0007sh-It; Sun, 17 Aug 2025 11:19:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=oixzG5K7h0oQk6d3uU8BhGn2Z7FZ2lm8+2+CupyO/Zk=; b=T0LpaBE43KyZ6WPUhQ4K
 aDDQMlQJZhM8iLISwYxzrK1wfEzkcOsarxARnQS2RpxTm0KoXX1+QE9bPtpnO5LH28N0ymbw2KacP
 fWEJOEDL/znoHm8Dp2cXpzfL9glLo4RXzOqTD2b5EeydwfVErcbgKFz97QmhMsGX5ZdNddSh7Ci0o
 TBWlJXlRzA41iVCnkMhdWJb+8WP1IzL0zSmEOEPbrHShhjr+INhYp7PtcssMpw5wmv8Lo2pF2tl6m
 PHshJmvUg74id/bgvUkARbEvA34eJb2R/5tZS2QiVbMktNiNyf5zMf6UyMcG17g3tYxMlFqOM91pC
 U2bFOzMtywMqZQ==;
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
In-Reply-To: <OWf4UUz--F-9@HIDDEN> (yelninei@HIDDEN's message of
 "Sat, 2 Aug 2025 16:00:58 +0200 (CEST)")
References: <cover.1745163830.git.ludo@HIDDEN>
 <ee2ded1a592d8f91595c26c08f6f9f047d74b4f2.1745163830.git.ludo@HIDDEN>
 <OPRqyKU--F-9@HIDDEN> <87cybmp4q6.fsf@HIDDEN>
 <OSK14Qd--F-9@HIDDEN> <87frg7kbm3.fsf@HIDDEN>
 <OSPKyE1--F-9@HIDDEN> <OWf4UUz--F-9@HIDDEN>
User-Agent: mu4e 1.12.11; emacs 30.1
X-URL: https://people.bordeaux.inria.fr/lcourtes/
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
X-Revolutionary-Date: =?UTF-8?Q?D=C3=A9cadi?= 30 Thermidor an 233 de la
 =?UTF-8?Q?R=C3=A9volution,?= jour du Moulin
Date: Sun, 17 Aug 2025 17:11:23 +0200
Message-ID: <87sehqq8ys.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hello,

yelninei@HIDDEN writes:

> I found where the error gets set (debugging global variables is not fun)
>
> As a reminder we get the D_WOULD_BLOCK error back from the initial=20
>
> if(err)
> =C2=A0 =C2=A0 return err;
> check in dev_read.
>
> In our case this comes from device_read_reply_inband from the errorcode p=
arameter. I am not yet sure where/how this gets called.
>
> My little C example now returns EWOULDBLOCK when reaching the "end" of /d=
ev/klog.

So you have a patch for /hurd/streamio and a C reproducer?  (Maybe you
sent it already and I haven=E2=80=99t seen.)

> However this does not really help the shepherd syslog because guile's
> read-line blocks forever waiting for a terminating newline. Also guile
> is unaware that further attempts to read would EWOULDBLOCK as "(select
> (vector port) #() #() 0)" indicates that reading is possible but then
> actually trying to a get a char blocks.

Ah but I think that=E2=80=99s fine: shepherd, suspendable ports are enabled=
 (via
Fibers), which means that read attempts that return EAGAIN or
EWOULDBLOCK result in the calling fiber being suspended.

You would need to try this for real, but it should be fine.

Thanks!

Ludo=E2=80=99.

Last modified: Sun, 17 Aug 2025 15:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.