GNU bug report logs - #77952
[PATCH 0/2] Fix threadsafety errors in offlineimap with python-3.11.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77952 in the body.
You can then email your comments to 77952 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH 0/2] Fix threadsafety errors in offlineimap with python-3.11.
Date: Mon, 21 Apr 2025 12:11:45 +0200

Offlineimap3 is broken since the latest python-team branch merge, which upgrades to python 3.11, see

    https://github.com/OfflineIMAP/offlineimap3/issues/151

Commit 7cd32cf in upstream repository fixes the issue, but there is no new release since then.

As latest tag upstream dates from 4 years ago, it is time to update to a non release, fixing the problem.

This upgrade requires also urllib3-1.25.

Cayetano Santos (2):
  gnu: Add python-urllib3-1.25.
  gnu: offlineimap3: Update to 8.0.0-0.db34745.

 gnu/packages/mail.scm       | 80 +++++++++++++++++++------------------
 gnu/packages/python-web.scm | 15 +++++++
 2 files changed, 56 insertions(+), 39 deletions(-)


base-commit: f9a7f2c8afdf33a36bd36177c0aa98d35331bf26
--
2.49.0

Message #8 received at 77952 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 77952 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH 1/2] gnu: Add python-urllib3-1.25.
Date: Mon, 21 Apr 2025 12:15:30 +0200

* gnu/packages/python-web.scm (python-urllib3-1.25): New variable.

Change-Id: I28ea55b42dee708ad8d15e51d6b8e8a5ec2f392f
---
 gnu/packages/python-web.scm | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 8fe9f58978..ef5cd127df 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -5139,6 +5139,21 @@ (define-public python-urllib3-next
      (list python-hatchling
            python-hatch-vcs))))
 
+(define-public python-urllib3-1.25
+  (package
+    (inherit python-urllib3)
+    (version "1.25.19")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "urllib3" version))
+       (sha256
+        (base32
+         "09rmjqm5syhhc8fx3v06h3yv6cqy0b1081jg8wm5grpwpr72j61h"))))
+    (native-inputs
+     (list python-setuptools
+           python-wheel))))
+
 (define-public python-urllib3-1.26
   (package
     (inherit python-urllib3)
-- 
2.49.0

Message #11 received at 77952 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 77952 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH 2/2] gnu: offlineimap3: Update to 8.0.0-0.db34745.
Date: Mon, 21 Apr 2025 12:15:31 +0200

* gnu/packages/mail.scm (offlineimap3): Update to 8.0.0-0.db34745.

Change-Id: Ic000dd21aeb1ae98c6af9335b8bda93ffeb1e959
---
 gnu/packages/mail.scm | 80 ++++++++++++++++++++++---------------------
 1 file changed, 41 insertions(+), 39 deletions(-)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 9f88bbf70d..8e56efaddd 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -1184,47 +1184,49 @@ (define-public bogofilter
     (license license:gpl3+)))
 
 (define-public offlineimap3
-  (package
-    (name "offlineimap3")
-    (version "8.0.0")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/OfflineIMAP/offlineimap3")
-                    (commit (string-append "v" version))))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "0y3giaz9i8vvczlxkbwymfkn3vi9fv599dy4pc2pn2afxsl4mg2w"))))
-    (build-system python-build-system)
-    (native-inputs
-     (list asciidoc))
-    (inputs
-     (list python-distro python-imaplib2 python-rfc6555))
-    (arguments
-     `(;; Tests require a modifiable IMAP account.
-       #:tests? #f
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'build 'build-documentation
-           (lambda _
-             (substitute* "docs/Makefile"
-               ;; Prevent xmllint and xsltproc from downloading a DTD file.
-               (("a2x -v") "a2x --no-xmllint --xsltproc-opts=--nonet -v"))
-             (invoke "make" "-C" "docs" "man")))
-         (add-after 'install 'install-documentation
-           (lambda* (#:key outputs #:allow-other-keys)
-             (let* ((out (assoc-ref outputs "out"))
-                    (man (string-append out "/share/man")))
-               (install-file "docs/offlineimap.1" (string-append man "/man1"))
-               (install-file "docs/offlineimapui.7" (string-append man "/man7"))))))))
-    (home-page "https://www.offlineimap.org")
-    (synopsis "Sync emails between two repositories")
-    (description
-     "OfflineImap synchronizes emails between two repositories, so that you
+  (let ((commit "db347452273bb0f1b1a8ea952f6fb46cf95fedbf")
+        (revision "0"))
+    (package
+      (name "offlineimap3")
+      (version (git-version "8.0.0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/OfflineIMAP/offlineimap3")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0af6qxnjihpk29ns5i8545yj5spa0a0w85vrikaja768xc56wkrg"))))
+      (build-system python-build-system)
+      (native-inputs
+       (list asciidoc python-wheel))
+      (inputs
+       (list python-distro python-imaplib2 python-rfc6555 python-urllib3-1.25))
+      (arguments
+       `(;; Tests require a modifiable IMAP account.
+         #:tests? #f
+                  #:phases
+                  (modify-phases %standard-phases
+                    (add-after 'build 'build-documentation
+                      (lambda _
+                        (substitute* "docs/Makefile"
+                          ;; Prevent xmllint and xsltproc from downloading a DTD file.
+                          (("a2x -v") "a2x --no-xmllint --xsltproc-opts=--nonet -v"))
+                        (invoke "make" "-C" "docs" "man")))
+                    (add-after 'install 'install-documentation
+                      (lambda* (#:key outputs #:allow-other-keys)
+                        (let* ((out (assoc-ref outputs "out"))
+                               (man (string-append out "/share/man")))
+                          (install-file "docs/offlineimap.1" (string-append man "/man1"))
+                          (install-file "docs/offlineimapui.7" (string-append man "/man7"))))))))
+      (home-page "https://www.offlineimap.org")
+      (synopsis "Sync emails between two repositories")
+      (description
+       "OfflineImap synchronizes emails between two repositories, so that you
 can read the same mailbox from multiple computers.  It supports IMAP as REMOTE
 repository and Maildir/IMAP as LOCAL repository.")
-    (license license:gpl2+)))
+      (license license:gpl2+))))
 
 (define-public offlineimap
   (deprecated-package "offlineimap" offlineimap3))
-- 
2.49.0

Message #16 received at 77952-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 77952-done <at> debbugs.gnu.org
Subject: [PATCH 0/2] Fix threadsafety errors in offlineimap with python-3.11.
Date: Wed, 23 Apr 2025 23:20:42 +0100

[Message part 1 (text/plain, inline)]

Hi,

Thanks for the patches.

I've migrated to G-expressions and pyproject and pushed to master as:

3f61193716 * gnu: offlineimap3: Update to 8.0.0-0.db34745.
fc718a5df9 * gnu: Add python-urllib3-1.25.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.