GNU bug report logs - #77953
[PATCH] gnu: kitty: Fix build for Python update.

Previous Next

To reply to this bug, email your comments to 77953 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman <at> burningswell.com>
To: guix-patches <at> gnu.org
Cc: Roman Scherer <roman <at> burningswell.com>, sharlatanus <at> gmail.com
Subject: [PATCH] gnu: kitty: Fix build for Python update.
Date: Mon, 21 Apr 2025 12:37:34 +0200

* gnu/packages/terminals.scm (kitty): Fix build for Python update.

Change-Id: I4324526936c2a104b3c2f85f75344f54813c089a
---
 gnu/packages/terminals.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
index 3931811024..2ca6c791e3 100644
--- a/gnu/packages/terminals.scm
+++ b/gnu/packages/terminals.scm
@@ -1338,6 +1338,8 @@ (define-public kitty
           (delete 'configure)   ;no configure script
           (replace 'build
             (lambda* (#:key inputs #:allow-other-keys)
+              ;; Don't fail on deprecation warnings from GCC
+              (setenv "CFLAGS" "-Wno-error=deprecated-declarations")
               ;; The "kitty" sub-directory must be writable prior to
               ;; configuration (e.g., un-setting updates).
               (for-each make-file-writable (find-files "kitty"))
@@ -1355,6 +1357,31 @@ (define-public kitty
                 ;; tests.
                 (setenv "PATH" (string-append "linux-package/bin:"
                                               (getenv "PATH")))
+                ;; Don't fail on deprecation warnings from Python
+                (substitute* "test.py"
+                  (("'error'") "'ignore'"))
+                ;; Fails: No writable cache directories
+                (substitute* "kitty_tests/fonts.py"
+                  (("    def test_box_drawing")
+                   (string-append
+                    "    @unittest.skip('No writable cache directories')\n"
+                    "    def test_box_drawing")))
+                ;; Fails: Permission denied
+                (substitute* "kitty_tests/parser.py"
+                  (("import time")
+                   "import time\nimport unittest\n")
+                  (("    def test_graphics_command")
+                   (string-append
+                    "    @unittest.skip('Permission denied')\n"
+                    "    def test_graphics_command")))
+                ;; TypeError: expected bytes, str found
+                (substitute* "kitty_tests/tui.py"
+                  (("from . import BaseTest")
+                   "from . import BaseTest\nimport unittest\n")
+                  (("    def test_multiprocessing_spawn")
+                   (string-append
+                    "    @unittest.skip('TypeError: expected bytes, str found')\n"
+                    "    def test_multiprocessing_spawn")))
                 (invoke "python3" "test.py"))))
           (add-before 'install 'rm-pycache
             ;; created python cache __pycache__ are non deterministic

base-commit: f9a7f2c8afdf33a36bd36177c0aa98d35331bf26
-- 
2.49.0

Message #8 received at 77953 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 77953 <at> debbugs.gnu.org
Cc: roman <at> burningswell.com
Subject: [PATCH] gnu: kitty: Fix build for Python update.
Date: Mon, 21 Apr 2025 13:11:12 +0100

[Message part 1 (text/plain, inline)]

Hi,

Kitty in Guix is way too dated comparing to the Upstream, did you try to
bump the version instead?

0.21.2 (2021-06-28) -> 0.41.1 (2025-03-28)

https://github.com/kovidgoyal/kitty/releases/tag/v0.21.2
https://github.com/kovidgoyal/kitty/releases/tag/v0.41.1

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 77953 <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman <at> burningswell.com>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: roman <at> burningswell.com, 77953 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: kitty: Fix build for Python update.
Date: Mon, 21 Apr 2025 14:59:49 +0200

[Message part 1 (text/plain, inline)]

Hi Sharlatan,

yes, I gave it a quick try, but wasn't successful. There were some
packages missing. I think I got an error about nerd fonts missing. This
isn't in Guix and I'm not sure it can, because of licenses. Do you know?

I'm also not too familiar with the Python eco-system.

Can we merge this or some variation of it for now? It is blocking most
of my systems to update Guix.

Thanks, Roman

Sharlatan Hellseher <sharlatanus <at> gmail.com> writes:

> Hi,
>
> Kitty in Guix is way too dated comparing to the Upstream, did you try to
> bump the version instead?
>
> 0.21.2 (2021-06-28) -> 0.41.1 (2025-03-28)
>
> https://github.com/kovidgoyal/kitty/releases/tag/v0.21.2
> https://github.com/kovidgoyal/kitty/releases/tag/v0.41.1

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 77953-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 77953-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: kitty: Fix build for Python update.
Date: Mon, 21 Apr 2025 15:28:53 +0100

[Message part 1 (text/plain, inline)]

I've adjusted commit message and pushed to master as
bca0016e9b785bba3947a9e9ec5aa88c289ec521.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 77953 <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman <at> burningswell.com>
To: help-debbugs <at> gnu.org (GNU bug Tracking System)
Cc: 77953 <at> debbugs.gnu.org, Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: Re: bug#77953: closed ([PATCH] gnu: kitty: Fix build for Python
 update.)
Date: Mon, 21 Apr 2025 20:06:21 +0200

[Message part 1 (text/plain, inline)]

Thank you Oleg!

help-debbugs <at> gnu.org (GNU bug Tracking System) writes:

> Your bug report
>
> #77953: [PATCH] gnu: kitty: Fix build for Python update.
>
> which was filed against the guix-patches package, has been closed.
>
> The explanation is attached below, along with your original report.
> If you require more details, please reply to 77953 <at> debbugs.gnu.org.
>
> --
> 77953: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77953
> GNU Bug Tracking System
> Contact help-debbugs <at> gnu.org with problems
>
> From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
> Subject: [PATCH] gnu: kitty: Fix build for Python update.
> To: 77953-done <at> debbugs.gnu.org
> Date: Mon, 21 Apr 2025 15:28:53 +0100 (3 hours, 36 minutes, 45 seconds ago)
>
>
> I've adjusted commit message and pushed to master as
> bca0016e9b785bba3947a9e9ec5aa88c289ec521.
>
> --
> Oleg
>
> ----------
>
> From: Roman Scherer <roman <at> burningswell.com>
> Subject: [PATCH] gnu: kitty: Fix build for Python update.
> To: guix-patches <at> gnu.org
> Cc: Roman Scherer <roman <at> burningswell.com>, sharlatanus <at> gmail.com
> Date: Mon, 21 Apr 2025 12:37:34 +0200
> Date: Mon, 21 Apr 2025 12:37:34 +0200 (7 hours, 28 minutes, 4 seconds ago)
>
> * gnu/packages/terminals.scm (kitty): Fix build for Python update.
>
> Change-Id: I4324526936c2a104b3c2f85f75344f54813c089a
> ---
>  gnu/packages/terminals.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
> index 3931811024..2ca6c791e3 100644
> --- a/gnu/packages/terminals.scm
> +++ b/gnu/packages/terminals.scm
> @@ -1338,6 +1338,8 @@ (define-public kitty
>            (delete 'configure)   ;no configure script
>            (replace 'build
>              (lambda* (#:key inputs #:allow-other-keys)
> +              ;; Don't fail on deprecation warnings from GCC
> +              (setenv "CFLAGS" "-Wno-error=deprecated-declarations")
>                ;; The "kitty" sub-directory must be writable prior to
>                ;; configuration (e.g., un-setting updates).
>                (for-each make-file-writable (find-files "kitty"))
> @@ -1355,6 +1357,31 @@ (define-public kitty
>                  ;; tests.
>                  (setenv "PATH" (string-append "linux-package/bin:"
>                                                (getenv "PATH")))
> +                ;; Don't fail on deprecation warnings from Python
> +                (substitute* "test.py"
> +                  (("'error'") "'ignore'"))
> +                ;; Fails: No writable cache directories
> +                (substitute* "kitty_tests/fonts.py"
> +                  (("    def test_box_drawing")
> +                   (string-append
> +                    "    @unittest.skip('No writable cache directories')\n"
> +                    "    def test_box_drawing")))
> +                ;; Fails: Permission denied
> +                (substitute* "kitty_tests/parser.py"
> +                  (("import time")
> +                   "import time\nimport unittest\n")
> +                  (("    def test_graphics_command")
> +                   (string-append
> +                    "    @unittest.skip('Permission denied')\n"
> +                    "    def test_graphics_command")))
> +                ;; TypeError: expected bytes, str found
> +                (substitute* "kitty_tests/tui.py"
> +                  (("from . import BaseTest")
> +                   "from . import BaseTest\nimport unittest\n")
> +                  (("    def test_multiprocessing_spawn")
> +                   (string-append
> +                    "    @unittest.skip('TypeError: expected bytes, str found')\n"
> +                    "    def test_multiprocessing_spawn")))
>                  (invoke "python3" "test.py"))))
>            (add-before 'install 'rm-pycache
>              ;; created python cache __pycache__ are non deterministic
>
> base-commit: f9a7f2c8afdf33a36bd36177c0aa98d35331bf26

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.